ruby-lol 0.9.9 → 0.9.10

data/spec/fixtures/v1.3/get-summoner.json

@@ -1 +1,16 @@
-{"30743211":{"id":30743211,"name":"intinig","profileIconId":599,"summonerLevel":30,"revisionDate":1390360425000},"33249714":{"id":33249714,"name":"intinir","profileIconId":26,"summonerLevel":30,"revisionDate":1390538264000}}
+{
+  "30743211": {
+    "id": 30743211,
+    "name": "intinig",
+    "profileIconId": 599,
+    "summonerLevel": 30,
+    "revisionDate": 1390360425000
+  },
+  "33249714": {
+    "id": 33249714,
+    "name": "intinir",
+    "profileIconId": 26,
+    "summonerLevel": 30,
+    "revisionDate": 1390538264000
+  }
+}

data/spec/lol/client_spec.rb

@@ -93,6 +93,18 @@ describe Client do
     end
   end
 
+  describe "#static" do
+    it "returns an instance of StaticRequest" do
+      expect(subject.static).to be_a(StaticRequest)
+    end
+
+    it "initializes the StaticRequest with the current API key and region" do
+      expect(StaticRequest).to receive(:new).with(subject.api_key, subject.region)
+
+      subject.static
+    end
+  end
+
   describe "#api_key" do
     it "returns an api key" do
       expect(subject.api_key).to eq("foo")

data/spec/lol/request_spec.rb

@@ -59,15 +59,6 @@ describe Request do
       expect(subject.api_url("bar")).to eq("http://prod.api.pvp.net/api/lol/euw/v1.1/bar?api_key=api_key")
     end
 
-    it "has lol if url is different from v2.1" do
-      expect(subject.api_url("foo")).to eq("http://prod.api.pvp.net/api/lol/euw/v1.1/foo?api_key=api_key")
-    end
-
-    it "does not have lol only url is v2.1" do
-      expect(Request).to receive(:api_version).at_least(:once).and_return("v2.1")
-      expect(subject.api_url("foo")).to eq("http://prod.api.pvp.net/api/euw/v2.1/foo?api_key=api_key")
-    end
-
     it "optionally accept query string parameters" do
       expect(subject.api_url("foo", a: 'b')).to eq("http://prod.api.pvp.net/api/lol/euw/v1.1/foo?a=b&api_key=api_key")
     end

data/spec/lol/static_request_spec.rb

@@ -0,0 +1,93 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe StaticRequest do
+  describe "api_version" do
+    it "is v1" do
+      expect(StaticRequest.api_version).to eq("v1")
+    end
+  end
+
+  let(:request) { StaticRequest.new "api_key", "euw" }
+
+  describe "api_url" do
+    it "contains a static-data path component" do
+      expect(request.api_url("foo")).to eq("http://prod.api.pvp.net/api/lol/static-data/euw/v1/foo?api_key=api_key")
+    end
+  end
+
+  StaticRequest::STANDARD_ENDPOINTS.each do |endpoint|
+    describe "##{endpoint}" do
+      it "returns a Proxy" do
+        expect(request.send(endpoint).class).to eq(StaticRequest::Proxy)
+      end
+
+      describe "#get" do
+        it "proxies get to StaticRequest with the correct endpoint" do
+          expect(request).to receive(:get).with(endpoint, anything, anything)
+
+          request.send(endpoint).get
+        end
+
+        context "without_id" do
+          let(:fixtures) { load_fixture("#{endpoint.dasherize}", StaticRequest.api_version, "get") }
+
+          subject do
+            expect(request).to receive(:perform_request)
+              .with(request.api_url("#{endpoint.dasherize}"))
+              .and_return(fixtures)
+
+            request.send(endpoint).get
+          end
+
+          it "returns an Array" do
+            expect(subject).to be_an(Array)
+          end
+
+          it "returns an Array of OpenStructs" do
+            expect(subject.map(&:class).uniq).to eq([OpenStruct])
+          end
+
+          it "fetches #{endpoint} from the API" do
+            expect(subject.size).to eq(fixtures["data"].size)
+          end
+        end
+
+        context "with_id" do
+          let(:id) { 1 }
+          let(:fixtures) { load_fixture("#{endpoint.dasherize}-by-id", StaticRequest.api_version, "get") }
+
+          subject do
+            expect(request).to receive(:perform_request)
+              .with(request.api_url("#{endpoint.dasherize}/#{id}"))
+              .and_return(fixtures)
+
+            request.send(endpoint).get(id)
+          end
+
+          it "returns an OpenStruct" do
+            expect(subject).to be_an(OpenStruct)
+          end
+        end
+      end
+    end
+  end
+
+  describe "realm" do
+    let(:fixtures) { load_fixture("realm", StaticRequest.api_version, "get") }
+
+    subject do
+      expect(request).to receive(:perform_request)
+        .with(request.api_url("realm"))
+        .and_return(fixtures)
+
+      request.send("realm").get
+    end
+
+    it "returns an OpenStruct" do
+      expect(subject).to be_an(OpenStruct)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lol
 version: !ruby/object:Gem::Version
-  version: 0.9.9
+  version: 0.9.10
 platform: ruby
 authors:
 - Giovanni Intini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-04 00:00:00.000000000 Z
+date: 2014-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -281,6 +281,7 @@ files:
 - lib/lol/rune.rb
 - lib/lol/rune_page.rb
 - lib/lol/rune_slot.rb
+- lib/lol/static_request.rb
 - lib/lol/stats_request.rb
 - lib/lol/summoner.rb
 - lib/lol/summoner_request.rb
@@ -302,6 +303,17 @@ files:
 - spec/fixtures/v1.3/get-summoner-name.json
 - spec/fixtures/v1.3/get-summoner-runes.json
 - spec/fixtures/v1.3/get-summoner.json
+- spec/fixtures/v1/get-champion-by-id.json
+- spec/fixtures/v1/get-champion.json
+- spec/fixtures/v1/get-item-by-id.json
+- spec/fixtures/v1/get-item.json
+- spec/fixtures/v1/get-mastery-by-id.json
+- spec/fixtures/v1/get-mastery.json
+- spec/fixtures/v1/get-realm.json
+- spec/fixtures/v1/get-rune-by-id.json
+- spec/fixtures/v1/get-rune.json
+- spec/fixtures/v1/get-summoner-spell-by-id.json
+- spec/fixtures/v1/get-summoner-spell.json
 - spec/fixtures/v2.2/get-team.json
 - spec/fixtures/v2.3/get-league.json
 - spec/lol/champion_request_spec.rb
@@ -325,6 +337,7 @@ files:
 - spec/lol/rune_page_spec.rb
 - spec/lol/rune_slot_spec.rb
 - spec/lol/rune_spec.rb
+- spec/lol/static_request_spec.rb
 - spec/lol/stats_request_spec.rb
 - spec/lol/summoner_request_spec.rb
 - spec/lol/summoner_spec.rb
@@ -371,6 +384,17 @@ test_files:
 - spec/fixtures/v1.3/get-summoner-name.json
 - spec/fixtures/v1.3/get-summoner-runes.json
 - spec/fixtures/v1.3/get-summoner.json
+- spec/fixtures/v1/get-champion-by-id.json
+- spec/fixtures/v1/get-champion.json
+- spec/fixtures/v1/get-item-by-id.json
+- spec/fixtures/v1/get-item.json
+- spec/fixtures/v1/get-mastery-by-id.json
+- spec/fixtures/v1/get-mastery.json
+- spec/fixtures/v1/get-realm.json
+- spec/fixtures/v1/get-rune-by-id.json
+- spec/fixtures/v1/get-rune.json
+- spec/fixtures/v1/get-summoner-spell-by-id.json
+- spec/fixtures/v1/get-summoner-spell.json
 - spec/fixtures/v2.2/get-team.json
 - spec/fixtures/v2.3/get-league.json
 - spec/lol/champion_request_spec.rb
@@ -394,6 +418,7 @@ test_files:
 - spec/lol/rune_page_spec.rb
 - spec/lol/rune_slot_spec.rb
 - spec/lol/rune_spec.rb
+- spec/lol/static_request_spec.rb
 - spec/lol/stats_request_spec.rb
 - spec/lol/summoner_request_spec.rb
 - spec/lol/summoner_spec.rb