ruby-lol 0.9.19.1 → 0.10.0

data/spec/lol/client_spec.rb

@@ -161,6 +161,38 @@ describe Client do
     end
   end
 
+  describe '#current_game' do
+    it 'returns an instance of CurrentGameRequest' do
+      expect(subject.current_game).to be_a CurrentGameRequest
+    end
+
+    it 'initializes CurrentGameRequest with the current API key an region' do
+      expect(CurrentGameRequest).to receive(:new).with subject.api_key, subject.region, subject.cache_store
+      subject.current_game
+    end
+
+    it 'memoizes the result' do
+      expect(CurrentGameRequest).to receive(:new).and_return(double).exactly(:once)
+      2.times { subject.current_game }
+    end
+  end
+
+  describe '#featured_games' do
+    it 'returns an instance of FeaturedGamesRequest' do
+      expect(subject.featured_games).to be_a FeaturedGamesRequest
+    end
+
+    it 'initializes FeaturedGamesRequest with the current API key an region' do
+      expect(FeaturedGamesRequest).to receive(:new).with subject.api_key, subject.region, subject.cache_store
+      subject.featured_games
+    end
+
+    it 'memoizes the result' do
+      expect(FeaturedGamesRequest).to receive(:new).and_return(double).exactly(:once)
+      2.times { subject.featured_games }
+    end
+  end
+
   describe "#api_key" do
     it "returns an api key" do
       expect(subject.api_key).to eq("foo")

data/spec/lol/current_game_request_spec.rb

@@ -0,0 +1,47 @@
+require 'spec_helper'
+require 'lol'
+
+describe Lol::CurrentGameRequest do
+  subject { Lol::CurrentGameRequest.new 'api_key', 'euw' }
+
+  it 'inherits from Lol::Request' do
+    expect(subject.class.ancestors[1]).to eq Lol::Request
+  end
+
+  describe '#api_url' do
+    it 'returns base_url joined with the given path and the api query string' do
+      expect(subject.api_url 'foo').to eq "https://euw.api.pvp.net/observer-mode/rest/consumer/foo?api_key=api_key"
+    end
+
+    it 'delegates to api_base_url' do
+      allow(subject).to receive(:api_base_url).and_return 'bar'
+      expect(subject.api_url 'foo').to match /^bar\/observer-mode\/rest\/consumer\/foo/
+    end
+
+    it 'delegates to api_query_string' do
+      allow(subject).to receive(:api_query_string).with(a: 'a').and_return 'baz'
+      expect(subject.api_url 'foo', a: 'a').to match /foo\?baz$/
+    end
+  end
+
+  describe '#spectator_game_info' do
+    let(:expected_url) { 'getSpectatorGameInfo/EUW1/1' }
+
+    it 'requires platform and summoner id' do
+      expect {
+        subject.spectator_game_info
+      }.to raise_error ArgumentError, /\(0 for 2\)/
+    end
+
+    it 'returns a DynamicModel' do
+      stub_request subject, 'current-game', expected_url
+      expect(subject.spectator_game_info 1, '1').to be_a DynamicModel
+    end
+
+    it 'gives the response to DynamicModel' do
+      allow(subject).to receive(:perform_request).with(instance_of(String)).and_return 'a'
+      expect(Lol::DynamicModel).to receive(:new).with('a').and_return 'foo'
+      subject.spectator_game_info 1, '1'
+    end
+  end
+end

data/spec/lol/featured_games_request_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+require 'lol'
+
+describe Lol::FeaturedGamesRequest do
+  subject { Lol::FeaturedGamesRequest.new 'api_key', 'euw' }
+
+  it 'inherits from Lol::Request' do
+    expect(subject.class.ancestors[1]).to eq Lol::Request
+  end
+
+  describe '#api_url' do
+    it 'returns base_url joined with the given path and the api query string' do
+      expect(subject.api_url 'foo').to eq "https://euw.api.pvp.net/observer-mode/rest/foo?api_key=api_key"
+    end
+
+    it 'delegates to api_base_url' do
+      allow(subject).to receive(:api_base_url).and_return 'bar'
+      expect(subject.api_url 'foo').to match /^bar\/observer-mode\/rest\/foo/
+    end
+
+    it 'delegates to api_query_string' do
+      allow(subject).to receive(:api_query_string).with(a: 'a').and_return 'baz'
+      expect(subject.api_url 'foo', a: 'a').to match /foo\?baz$/
+    end
+  end
+
+  describe '#get' do
+    it 'returns a dynamic model' do
+      stub_request subject, 'featured-games', 'featured'
+      expect(subject.get).to be_a Lol::DynamicModel
+    end
+
+    it 'gives the response to DynamicModel' do
+      allow(subject).to receive(:perform_request).with(instance_of(String)).and_return 'a'
+      expect(Lol::DynamicModel).to receive(:new).with('a').and_return 'foo'
+      subject.get
+    end
+  end
+end

data/spec/lol/request_spec.rb

@@ -99,25 +99,51 @@ describe Request do
     end
   end
 
-    describe "api_url" do
-      it "defaults on Request#region" do
-        expect(subject.api_url("bar")).to match(/\/euw\//)
-      end
+  describe "api_url" do
+    it "defaults on Request#region" do
+      expect(subject.api_url("bar")).to match(/\/euw\//)
+    end
 
-      it "defaults on Reques.api_version" do
-        expect(subject.api_url("bar")).to match(/\/v1.1\//)
-      end
+    it "defaults on Reques.api_version" do
+      expect(subject.api_url("bar")).to match(/\/v1.1\//)
+    end
 
-      it "a path" do
-        expect { subject.api_url }.to raise_error(ArgumentError)
-      end
+    it "a path" do
+      expect { subject.api_url }.to raise_error(ArgumentError)
+    end
 
-      it "returns a full fledged api url" do
-        expect(subject.api_url("bar")).to eq("https://euw.api.pvp.net/api/lol/euw/v1.1/bar?api_key=api_key")
-      end
+    it "returns a full fledged api url" do
+      expect(subject.api_url("bar")).to eq("https://euw.api.pvp.net/api/lol/euw/v1.1/bar?api_key=api_key")
+    end
 
-      it "optionally accept query string parameters" do
-        expect(subject.api_url("foo", a: 'b')).to eq("https://euw.api.pvp.net/api/lol/euw/v1.1/foo?a=b&api_key=api_key")
-      end
+    it "optionally accept query string parameters" do
+      expect(subject.api_url("foo", a: 'b')).to eq("https://euw.api.pvp.net/api/lol/euw/v1.1/foo?a=b&api_key=api_key")
+    end
+
+    it "delegates the base url to #api_base_url" do
+      allow(subject).to receive(:api_base_url).and_return 'foo'
+      expect(subject.api_url 'bar').to match /^foo/
+    end
+
+    it "delegates the query string to #api_query_string" do
+      allow(subject).to receive(:api_query_string).and_return 'foo'
+      expect(subject.api_url 'bar').to match /\?foo$/
+    end
+  end
+
+  describe "#api_base_url" do
+    it "returns the base domain" do
+      expect(subject.api_base_url).to eq "https://euw.api.pvp.net"
+    end
+  end
+
+  describe "#api_query_string" do
+    it "returns the api key as query string" do
+      expect(subject.api_query_string).to eq "api_key=api_key"
+    end
+
+    it "optionally accept other params" do
+      expect(subject.api_query_string foo: 'bar').to eq "foo=bar&api_key=api_key"
     end
   end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lol
 version: !ruby/object:Gem::Version
-  version: 0.9.19.1
+  version: 0.10.0
 platform: ruby
 authors:
 - Giovanni Intini
@@ -278,7 +278,9 @@ files:
 - lib/lol/champion_request.rb
 - lib/lol/champion_statistics_summary.rb
 - lib/lol/client.rb
+- lib/lol/current_game_request.rb
 - lib/lol/dynamic_model.rb
+- lib/lol/featured_games_request.rb
 - lib/lol/game.rb
 - lib/lol/game_request.rb
 - lib/lol/invalid_api_response.rb
@@ -312,6 +314,8 @@ files:
 - ruby-lol.gemspec
 - spec/acceptance_spec.rb
 - spec/api_version_spec.rb
+- spec/fixtures/v1.0/get-current-game.json
+- spec/fixtures/v1.0/get-featured-games.json
 - spec/fixtures/v1.0/get-lol-status-shard-by-region.json
 - spec/fixtures/v1.0/get-lol-status-shards.json
 - spec/fixtures/v1.2/get-champion-266.json
@@ -348,7 +352,9 @@ files:
 - spec/lol/champion_spec.rb
 - spec/lol/champion_statistics_summary_spec.rb
 - spec/lol/client_spec.rb
+- spec/lol/current_game_request_spec.rb
 - spec/lol/dynamic_model_spec.rb
+- spec/lol/featured_games_request_spec.rb
 - spec/lol/game_request_spec.rb
 - spec/lol/game_spec.rb
 - spec/lol/invalid_api_response_spec.rb
@@ -408,6 +414,8 @@ summary: Ruby wrapper to Riot Games API
 test_files:
 - spec/acceptance_spec.rb
 - spec/api_version_spec.rb
+- spec/fixtures/v1.0/get-current-game.json
+- spec/fixtures/v1.0/get-featured-games.json
 - spec/fixtures/v1.0/get-lol-status-shard-by-region.json
 - spec/fixtures/v1.0/get-lol-status-shards.json
 - spec/fixtures/v1.2/get-champion-266.json
@@ -444,7 +452,9 @@ test_files:
 - spec/lol/champion_spec.rb
 - spec/lol/champion_statistics_summary_spec.rb
 - spec/lol/client_spec.rb
+- spec/lol/current_game_request_spec.rb
 - spec/lol/dynamic_model_spec.rb
+- spec/lol/featured_games_request_spec.rb
 - spec/lol/game_request_spec.rb
 - spec/lol/game_spec.rb
 - spec/lol/invalid_api_response_spec.rb