ruby-lol 0.9.13 → 0.9.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 006de251c4e277db5f622c9a32b88bdf79f8d958
-  data.tar.gz: ec86dcb6c1b7dcd8f86f4bfbe0de26c229ca36f4
+  metadata.gz: 81dabecfe271cb17a25f3533ccd1a34455e93847
+  data.tar.gz: dba729c13e5c7a801bdcd28bd9efc5f089e0c55a
 SHA512:
-  metadata.gz: ebf690e5492bb56291144b7b46af261e0ac916dc68f4645e69fa3b7cf911d0d64567eb07aec2b95f04493d35d9cf7e1d69ddb4a8bd1a55e4b19dbd3ac0bc3d01
-  data.tar.gz: 8a63a55a1d9b5793576718d8f5019a1071cf74da00cc14c81a71a5e8ea4c33258bcfb00cf293eb60dde86363d77d622f058394c377e9f0509b0cc7cf9ad3395c
+  metadata.gz: 066470b73875a474f830f944e2f80dbd18b2ecd8025f113ea1b87140b56102c8fec34f1070106237be7f42c4613cf577d2126256b291357f74350b15bf6a1f6d
+  data.tar.gz: 9c5c98ff2490c338924c042b24f8cda09bc475e4ab3d662f35e56512827fd1d1c91c4e10e0d2eb02df391b7b5059696bae82da82d49a00273112cf2158d1655b

data/README.md

@@ -22,15 +22,17 @@ Or install it yourself as:
 
 ## Usage
 
+[ Outdated, anyone who wants to contribute to this please do it :) ]
+
 ```ruby
 require 'lol'
 
-client = Lol::Client.new "my_api_key", "euw"
-# => <Lol::Client:0x007fd09d1abb00 @api_key="my_api_key", @region="euw">
+client = Lol::Client.new "my_api_key", {region: "euw"}
+# => <Lol::Client:0x000000020c0b28 @api_key="my_api_key", @region="euw", @cached=false>
 
 # NEW! You can cache requests using Redis now
 # ttl defaults to 900
-client = Lol::Client.new "my_api_key", "euw", {redis: "redis://localhost:6379", ttl: 900}
+client = Lol::Client.new "my_api_key", {region: "euw", redis: "redis://localhost:6379", ttl: 900}
 
 # Available Requests
 client.champion
@@ -118,6 +120,9 @@ client.static.champion.get(champData: 'lore')
 5. Create new Pull Request
 
 ## Changelog
+ - 0.9.14 Fixed a caching bug
+ - 0.9.13 Updated to latest API versions
+ - 0.9.12 Fixed a caching bug
  - 0.9.11 Added caching support via REDIS
  - 0.9.7 Updated LeagueRequest to API v2.3
  - 0.9.6 Updated SummonerRequest and GameRequest to API v1.3

data/lib/lol/request.rb

@@ -55,10 +55,7 @@ module Lol
       raise NotFound.new("404 Not Found") if response.respond_to?(:code) && response.not_found?
       raise InvalidAPIResponse.new(response["status"]["message"]) if response.is_a?(Hash) && response["status"]
 
-      if cached?
-        store.set clean_url(url), response.to_json
-        store.expire url, ttl
-      end
+      store.setex clean_url(url), ttl, response.to_json if cached?
 
       response
     end

data/lib/lol/version.rb

@@ -1,3 +1,3 @@
 module Lol
-  VERSION = "0.9.13"
+  VERSION = "0.9.14"
 end

data/spec/lol/request_spec.rb

@@ -54,6 +54,8 @@ describe Request do
     context "caching" do
       before :all do
         class FakeRedis < Redis
+          attr_reader :store
+
           def initialize options = {}
             @store = {}
           end
@@ -62,11 +64,8 @@ describe Request do
             @store[key]
           end
 
-          def set key, val
+          def setex key, ttl, val
             @store[key] = val
-          end
-
-          def expire key, ttl
             @store["#{key}:ttl"] = ttl
           end
         end
@@ -82,7 +81,6 @@ describe Request do
       it "is cached" do
         expect(request.class).not_to receive(:get)
         request.perform_request "/foo"
-
       end
 
       it "serializes cached responses" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lol
 version: !ruby/object:Gem::Version
-  version: 0.9.13
+  version: 0.9.14
 platform: ruby
 authors:
 - Giovanni Intini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-02 00:00:00.000000000 Z
+date: 2014-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler