ruby-lol 0.0.6 → 0.0.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e4514fa6155984e91035d39c11f299138b3b104
-  data.tar.gz: 38fd725d0b900483523b5ffb7fb93c5131ce9eda
+  metadata.gz: 64b2c711ab04175c2affa3e50c2e2edcd19174cc
+  data.tar.gz: 332cbea429a999952017e23e26e156dcf777e64c
 SHA512:
-  metadata.gz: 2a9c947b9c8f803bf1cf13850bfd40f0d7aad75b1bd81878a508cef07f51353306154b859e26a7fab50f496913e3153275119f5d062786477a6d9105f7b08374
-  data.tar.gz: 26103c71d7782de216d3eeb7a81f0062e4bd33f101fa0bb4cc29d6e39de0a798221ce0516042060cbfaa275ff0cf4c51abce4752ff1222e0281a07f8c204383b
+  metadata.gz: 745627a7bcdcb12d570f246dd5da1dd8636e7061036de7f9b24b4ea9a7b323f9db119c923d53c49efd0b20acd9d80cd7fbba8944cac0d6e1a509f6746c4817bf
+  data.tar.gz: 7b7c2824be9137a8f3c7b63bf6851ca912f4750076f159cb7aac1b91f00877a10f43f3b3a7086119af4b5881390fb06c7c8534a273193731f4939148ce5b0d37

data/README.md

@@ -3,6 +3,10 @@
 
 ruby-lol is a wrapper to the [Riot Games API](https://developer.riotgames.com).
 
+## IMPORTANT NOTICE
+
+An important piece of refactoring is happening in the *refactoring* branch. Check it out for updated docs. I plan to merge it in this week.
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -32,32 +36,48 @@ Or install it yourself as:
     na_client = Lol::Client.new "my_api_key", :region => "na"
     # => <Lol::Client:0x007fd09d1abb00 @api_key="my_api_key", @region="na">
 
-    # gets all champions
-    champions = client.champion
-    # => Array of Lol::Champion
-
-    # let's play a bit, who is free to play?
-    client.champion.select {|c| c.free_to_play }.map {|c| c.name}
-    # => %w(Aatrox Cassiopeia Lux Malphite MissFortune MonkeyKing Nautilus Sivir Talon Taric)
-
-    # it's time to fetch some of my games, isn't it?
-    games = client.game my_summoner_id
-    # => Array of Lol::Game
-
-    # let's get one game and look into it
-    game = games.first
-
-    # who was I playing with?
-    game.fellow_players
-    # => Array of Lol::Player
-
-    # gimme some stats!
-    game.statistics
-    # => Array of Lol::RawStatistic
-
-    # let's get some info about my Leagues now
-    leagues = client.league my_summoner_id
-    # => Array of Lol::League
+    # Available Requests
+    client.champion
+    # => Lol::ChampionRequest
+    client.game
+    # => Lol::GameRequest
+    client.league
+    # => Lol::LeagueRequest
+    client.stats
+    # => Lol::StatsRequest
+    client.summoner
+    # => Lol::SummonerRequest
+    client.team
+    # => Lol::TeamRequest
+
+    # Available methods for each request type
+    client.champion.get
+    # => Lol::Champion
+
+    client.game.recent(summoner_id)
+    # => Lol::Game
+
+    client.league.get(summoner_id)
+    # => Lol::League
+
+    client.stats.summary(summoner_id)
+    # => Lol::SummaryStats
+    client.stats.ranked(summoner_id)
+    # => Lol::RankedStats
+
+    client.summoner.masteries(summoner_id)
+    # => Lol::Masteries
+    client.summoner.runes(summoner_id)
+    # => Lol::Runes
+    client.summoner.by_name(name)
+    # => Lol::Summoner
+    client.summoner.get(summoner_id)
+    # => Lol::Summoner
+    client.summoner.name(summoner_ids)
+    # => Array
+
+    client.team.get(summoner_id)
+    # => Array
 ```
 
 ## Contributing

data/lib/lol/champion.rb

@@ -1,5 +1,3 @@
-require 'lol/model'
-
 module Lol
   class Champion < Lol::Model
     # @!attribute [r] id

data/lib/lol/champion_request.rb

@@ -0,0 +1,11 @@
+module Lol
+  class ChampionRequest < Request
+
+    # Retrieve all champions, v1.1
+    # @return [Array] an array of champions
+    def get
+      perform_request(api_url("v1.1", "champion"))["champions"].map {|c| Champion.new(c)}
+    end
+
+  end
+end

data/lib/lol/client.rb

@@ -5,7 +5,6 @@ module Lol
   class InvalidAPIResponse < StandardError; end
 
   class Client
-    include HTTParty
 
     # @!attribute [rw] region
     #   @return [String] name of region
@@ -15,110 +14,29 @@ module Lol
     #   @return [String] the API key that has been used
     attr_reader :api_key
 
-    # Returns a full url for an API call
-    # @param version [String] API version to call
-    # @param path [String] API path to call
-    # @return [String] full fledged url
-    def api_url version, path, params = {}
-      lol = version == "v1.1" ? "lol" : ""
-      query_string = URI.encode_www_form params.merge api_key: api_key
-      File.join "http://prod.api.pvp.net/api/", lol, "/#{region}/#{version}/", "#{path}?#{query_string}"
-    end
-
-    # Calls the API via HTTParty and handles errors
-    #
-    def get url
-      response = self.class.get(url)
-      if response.is_a?(Hash) && response["status"]
-        raise InvalidAPIResponse.new(response["status"]["message"])
-      else
-        response
-      end
-    end
-
-    # Calls the latest API version of champion
+    # @return [ChampionRequest]
     def champion
-      champion11
-    end
-
-    # Retrieve all champions, v1.1
-    # @return [Array] an array of champions
-    def champion11
-      get(api_url("v1.1", "champion"))["champions"].map {|c| Champion.new(c)}
-    end
-
-    # Calls the latest API version of game returning the list of
-    # recent games played by a summoner
-    def game *args
-      game11 *args
-    end
-
-    # Returns a list of the recent games played by a summoner
-    # @param summoner_id [Fixnum] Summoner id
-    # @return [Array] an array of games
-    def game11 summoner_id
-      summoner_api_path = "game/by-summoner/#{summoner_id}/recent"
-      get(api_url("v1.1", summoner_api_path))["games"].map do |game_data|
-        Game.new game_data
-      end
-    end
-
-    # Calls the latest API version of league
-    def league summoner_id
-      league21 summoner_id
-    end
-
-    # Retrieves leagues data for summoner, including leagues for all of summoner's teams, v2.1
-    # @return [Array] an array of champions
-    def league21 summoner_id
-      response = get(api_url("v2.1", "league/by-summoner/#{summoner_id}"))[summoner_id]
-      response.is_a?(Hash) ? [League.new(response)] : response.map {|l| League.new l}
-    end
-
-    # Calls the latest API version of stats
-    def stats *args
-      stats11 *args
-    end
-
-    # Retrieves player statistics summaries for the given summoner
-    # @return [Array] an array of player statistics, one per queue type
-    def stats11 summoner_id, extra = {}
-      if extra.keys.select { |k| k.to_sym != :season }.any?
-        raise ArgumentError, 'Only :season is allowed as extra parameter'
-      end
-      stats_api_path = "stats/by-summoner/#{summoner_id}/summary"
-      get(api_url('v1.1', stats_api_path, extra))['playerStatSummaries'].map do |player_stat_data|
-        PlayerStatistic.new player_stat_data
-      end
+      @champion_request ||= ChampionRequest.new(api_key, region)
     end
 
-    # Calls the latest API version of ranked_stats
-    def ranked_stats *args
-      ranked_stats11 *args
+    # @return [GameRequest]
+    def game
+      @game_request ||= GameRequest.new(api_key, region)
     end
 
-    # Retrieves ranked statistics summary for the given summoner
-    # @return [RankedStatisticsSummary] Ranked Stats.
-    #   Includes stats for Twisted Treeline and Summoner's Rift
-    def ranked_stats11 summoner_id, extra = {}
-      if extra.keys.select { |k| k.to_sym != :season }.any?
-        raise ArgumentError, 'Only :season is allowed as extra parameter'
-      end
-      stats_api_path = "stats/by-summoner/#{summoner_id}/ranked"
-      RankedStatisticsSummary.new get api_url 'v1.1', stats_api_path, extra
+    # @return [StatsRequest]
+    def stats
+      @stats_request ||= StatsRequest.new(api_key, region)
     end
 
-    # Calls the latest API version of team returning the list of teams for the given summoner
-    def team *args
-      team21 *args
+    # @return [LeagueRequest]
+    def league
+      @league_request ||= LeagueRequest.new(api_key, region)
     end
 
-    # Retrieves the list of Teams for the given summoner
-    # @return [Array] List of Team
-    def team21 summoner_id
-      get(api_url 'v2.1', "team/by-summoner/#{summoner_id}").map do |team_data|
-        Team.new team_data
-      end
+    # @return [TeamRequest]
+    def team
+      @team_request ||= TeamRequest.new(api_key, region)
     end
 
     # Initializes a Lol::Client

data/lib/lol/game_request.rb

@@ -0,0 +1,13 @@
+module Lol
+  class GameRequest < Request
+    # Returns a list of the recent games played by a summoner
+    # @param summoner_id [Fixnum] Summoner id
+    # @return [Array] an array of games
+    def recent summoner_id
+      summoner_api_path = "game/by-summoner/#{summoner_id}/recent"
+      perform_request(api_url("v1.1", summoner_api_path))["games"].map do |game_data|
+        Game.new game_data
+      end
+    end
+  end
+end

data/lib/lol/league_request.rb

@@ -0,0 +1,11 @@
+module Lol
+  class LeagueRequest < Request
+    # Retrieves leagues data for summoner, including leagues for all of summoner's teams, v2.1
+    # @return [Array] an array of champions
+    def get summoner_id
+      response = perform_request(api_url("v2.1", "league/by-summoner/#{summoner_id}"))[summoner_id]
+      response.is_a?(Hash) ? [League.new(response)] : response.map {|l| League.new l}
+    end
+
+  end
+end

data/lib/lol/team_request.rb

@@ -0,0 +1,11 @@
+module Lol
+  class TeamRequest < Request
+    # Retrieves the list of Teams for the given summoner
+    # @return [Array] List of Team
+    def get summoner_id
+      perform_request(api_url 'v2.1', "team/by-summoner/#{summoner_id}").map do |team_data|
+        Team.new team_data
+      end
+    end
+  end
+end

data/lib/lol/version.rb

@@ -1,3 +1,3 @@
 module Lol
-  VERSION = "0.0.6"
+  VERSION = "0.0.7"
 end

data/lib/lol.rb

@@ -1,18 +1,27 @@
-require __dir__ + "/lol/client"
-require __dir__ + "/lol/champion"
-require __dir__ + "/lol/game"
-require __dir__ + "/lol/league"
-require __dir__ + "/lol/player"
-require __dir__ + "/lol/raw_statistic"
-require __dir__ + "/lol/player_statistic"
-require __dir__ + "/lol/aggregated_statistic"
-require __dir__ + "/lol/ranked_statistics_summary"
-require __dir__ + "/lol/champion_statistics_summary"
-require __dir__ + "/lol/champion_statistic"
-require __dir__ + "/lol/team"
-require __dir__ + "/lol/roster"
-require __dir__ + "/lol/team_member"
-require __dir__ + "/lol/team_statistic"
-require __dir__ + "/lol/match_summary"
-require __dir__ + "/lol/league_entry"
-require __dir__ + "/lol/mini_series"
+require "lol/client"
+
+require "lol/request"
+require "lol/champion_request"
+require "lol/game_request"
+require "lol/stats_request"
+require "lol/team_request"
+require "lol/league_request"
+
+require "lol/model"
+require "lol/champion"
+require "lol/game"
+require "lol/league"
+require "lol/player"
+require "lol/raw_statistic"
+require "lol/player_statistic"
+require "lol/aggregated_statistic"
+require "lol/ranked_statistics_summary"
+require "lol/champion_statistics_summary"
+require "lol/champion_statistic"
+require "lol/team"
+require "lol/roster"
+require "lol/team_member"
+require "lol/team_statistic"
+require "lol/match_summary"
+require "lol/league_entry"
+require "lol/mini_series"

data/spec/lol/champion_request_spec.rb

@@ -0,0 +1,32 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe ChampionRequest do
+  it "inherits from Request" do
+    expect(ChampionRequest.ancestors[1]).to eq(Request)
+  end
+
+  describe "get" do
+    let(:request) { ChampionRequest.new "api_key", "euw" }
+
+    subject do
+      expect(request).to receive(:perform_request).with(request.api_url("v1.1", "champion")).and_return(load_fixture("champion", "v1.1", "get"))
+
+      request.get
+    end
+
+    it "returns an array" do
+      expect(subject).to be_a(Array)
+    end
+
+    it "returns an array of champions" do
+      expect(subject.map {|e| e.class}.uniq).to eq([Champion])
+    end
+
+    it "fetches champions from the API" do
+      expect(subject.size).to eq(load_fixture("champion", "v1.1", "get")["champions"].size)
+    end
+  end
+end

data/spec/lol/client_spec.rb

@@ -20,200 +20,64 @@ describe Client do
     end
   end
 
-  describe "#get" do
-    it "calls HTTParty get" do
-      expect(Client).to receive(:get).and_return(error_401)
-      expect { subject.get "foo"}.to raise_error(InvalidAPIResponse)
-    end
-
-    it "handles 401" do
-      expect(Client).to receive(:get).and_return(error_401)
-      expect { subject.champion }.to raise_error(InvalidAPIResponse)
-    end
-  end
 
   describe "#champion" do
-    it "defaults to v1.1" do
-      expect(subject).to receive(:champion11)
-      subject.champion
-    end
-  end
-
-  describe "#champion11" do
-    let(:client) { Client.new "foo" }
-
-    subject do
-      expect(client).to receive(:get).with(client.api_url("v1.1", "champion")).and_return(load_fixture("champion", "v1.1", "get"))
-
-      client.champion11
+    it "returns an instance of ChampionRequest" do
+      expect(subject.champion).to be_a(ChampionRequest)
     end
 
-    it "returns an array" do
-      expect(subject).to be_a(Array)
-    end
+    it "initializes the ChampionRequest with the current API key and region" do
+      expect(ChampionRequest).to receive(:new).with(subject.api_key, subject.region)
 
-    it "returns an array of champions" do
-      expect(subject.map {|e| e.class}.uniq).to eq([Champion])
-    end
-
-    it "fetches champions from the API" do
-      expect(subject.size).to eq(load_fixture("champion", "v1.1", "get")["champions"].size)
+      subject.champion
     end
   end
 
   describe '#game' do
-    it 'requires a summoner id' do
-      expect { subject.game }.to raise_error ArgumentError
-    end
-
-    it 'defaults to v1.1' do
-      expect(subject).to receive(:game11).with 'foo'
-      subject.game 'foo'
+    it "returns an instance of GameRequest" do
+      expect(subject.game).to be_a(GameRequest)
     end
-  end
-
-  describe '#game11' do
-    let(:client) { Client.new 'foo' }
 
-    subject do
-      expect(Client).to receive(:get).with(client.api_url('v1.1', "game/by-summoner/1/recent")).and_return load_fixture('game', 'v1.1', 'get')
-      client.game11 1
-    end
-
-    it 'returns an array' do
-      expect(subject).to be_a Array
-    end
-
-    it 'returns an array of Games' do
-      expect(subject.map(&:class).uniq).to eq [Game]
-    end
+    it "initializes the GameRequest with the current API key and region" do
+      expect(GameRequest).to receive(:new).with(subject.api_key, subject.region)
 
-    it 'fetches games from the API' do
-      expect(subject.size).to eq load_fixture('game', 'v1.1', 'get')['games'].size
+      subject.game
     end
   end
 
   describe '#stats' do
-    it 'defaults to v1.1' do
-      expect(subject).to receive(:stats11).with 'foo'
-      subject.stats 'foo'
-    end
-  end
-
-  describe '#stats11' do
-    let(:client) { Client.new 'foo' }
-    let(:fixture) { load_fixture 'stats', 'v1.1', 'get' }
-
-    subject do
-      expect(Client).to receive(:get).with(client.api_url('v1.1', "stats/by-summoner/1/summary")).and_return fixture
-      client.stats11 1
-    end
-
-    it 'requires a summoner' do
-      expect { client.stats }.to raise_error ArgumentError
-    end
-
-    it 'returns an array' do
-      expect(subject).to be_a Array
-    end
-
-    it 'returns an array of PlayerStatistic' do
-      expect(subject.map(&:class).uniq).to eq [PlayerStatistic]
-    end
-
-    it 'fetches PlayerStatistics from the API' do
-      expect(subject.size).to eq load_fixture('stats', 'v1.1', 'get')['playerStatSummaries'].size
-    end
-
-    it 'optionally accepts a season' do
-      expect(Client).to receive(:get).with(client.api_url('v1.1', 'stats/by-summoner/1/summary', season: '1')).and_return fixture
-      client.stats11 '1', season: '1'
-    end
-
-    it 'raises an error when unexpected parameter is received' do
-      expect { client.stats11 '1', asd: 'foo' }.to raise_error ArgumentError
-    end
-  end
-
-  describe '#ranked_stats' do
-    it 'defaults to v1.1' do
-      expect(subject).to receive(:ranked_stats11).with 'foo'
-      subject.ranked_stats 'foo'
-    end
-  end
-
-  describe '#ranked_stats11' do
-    let(:client) { Client.new 'foo' }
-    let(:fixture) { load_fixture 'ranked_stats', 'v1.1', 'get' }
-
-    subject do
-      expect(Client).to receive(:get).with(client.api_url('v1.1', "stats/by-summoner/1/ranked")).and_return fixture
-      client.ranked_stats11 1
+    it "returns an instance of StatsRequest" do
+      expect(subject.stats).to be_a(StatsRequest)
     end
 
-    it 'requires a summoner' do
-      expect { client.ranked_stats }.to raise_error ArgumentError
-    end
-
-    it 'returns a RankedStatisticsSummary' do
-      expect(subject).to be_a RankedStatisticsSummary
-    end
-
-    it 'fetches RankedStatisticsSummary from the API' do
-      expect(subject.champions.size).to eq load_fixture('ranked_stats', 'v1.1', 'get')['champions'].size
-    end
-
-    it 'optionally accepts a season' do
-      expect(Client).to receive(:get).with(client.api_url('v1.1', 'stats/by-summoner/1/ranked', season: '1')).and_return fixture
-      client.ranked_stats11 '1', season: '1'
-    end
+    it "initializes the StatsRequest with the current API key and region" do
+      expect(StatsRequest).to receive(:new).with(subject.api_key, subject.region)
 
-    it 'raises an error when unexpected parameter is received' do
-      expect { client.ranked_stats11 '1', asd: 'foo' }.to raise_error ArgumentError
+      subject.stats
     end
   end
 
   describe '#team' do
-    it 'defaults to v2.1' do
-      expect(subject).to receive(:team21).with 'foo'
-      subject.team 'foo'
-    end
-  end
-
-  describe '#team21' do
-    let(:client) { Client.new 'foo' }
-    let(:fixture) { load_fixture 'team', 'v2.1', 'get' }
-
-    subject do
-      expect(Client).to receive(:get).with(client.api_url('v2.1', "team/by-summoner/1")).and_return fixture
-      client.team21 1
+    it "returns an instance of TeamRequest" do
+      expect(subject.team).to be_a(TeamRequest)
     end
 
-    it 'requires a summoner' do
-      expect { client.team21 }.to raise_error ArgumentError
-    end
+    it "initializes the TeamRequest with the current API key and region" do
+      expect(TeamRequest).to receive(:new).with(subject.api_key, subject.region)
 
-    it 'returns an array' do
-      expect(subject).to be_a Array
-    end
-
-    it 'returns an array of Team' do
-      expect(subject.map(&:class).uniq).to eq [Team]
-    end
-
-    it 'fetches Team from the API' do
-      expect(subject.size).to eq fixture.size
+      subject.team
     end
   end
 
-  describe "#region" do
-    it "returns current region" do
-      expect(subject.region).to eq("euw")
+  describe "#league" do
+    it "returns an instance of LeagueRequest" do
+      expect(subject.league).to be_a(LeagueRequest)
     end
 
-    it "can be set to a new region" do
-      subject.region = "NA"
-      expect(subject.region).to eq("NA")
+    it "initializes the LeagueRequest with the current API key and region" do
+      expect(LeagueRequest).to receive(:new).with(subject.api_key, subject.region)
+
+      subject.league
     end
   end
 
@@ -227,50 +91,15 @@ describe Client do
     end
   end
 
-  describe "api_url" do
-    it "defaults on Client#region" do
-      expect(subject.api_url("foo", "bar")).to match(/\/euw\//)
-    end
-
-    it "requires a version and a path" do
-      expect { subject.api_url("foo") }.to raise_error(ArgumentError)
-    end
-
-    it "returns a full fledged api url" do
-      expect(subject.api_url("foo", "bar")).to eq("http://prod.api.pvp.net/api/euw/foo/bar?api_key=foo")
-    end
-
-    it "has lol if url is v1.1" do
-      expect(subject.api_url("v1.1", "foo")).to eq("http://prod.api.pvp.net/api/lol/euw/v1.1/foo?api_key=foo")
-    end
-
-    it "does not have lol if url is v2.1 or greater" do
-      expect(subject.api_url("v2.1", "foo")).to eq("http://prod.api.pvp.net/api/euw/v2.1/foo?api_key=foo")
-    end
-
-    it "optionally accept query string parameters" do
-      expect(subject.api_url("v2.1", "foo", a: 'b')).to eq("http://prod.api.pvp.net/api/euw/v2.1/foo?a=b&api_key=foo")
+  describe "#region" do
+    it "returns current region" do
+      expect(subject.region).to eq("euw")
     end
-  end
 
-  describe "league" do
-    it "calls latest version of league" do
-      expect(subject).to receive(:league21)
-      subject.league("foo")
+    it "can be set to a new region" do
+      subject.region = "NA"
+      expect(subject.region).to eq("NA")
     end
   end
 
-  describe "league21" do
-    let(:client) { Client.new "foo" }
-
-    subject do
-      expect(client).to receive(:get).with(client.api_url("v2.1", "league/by-summoner/foo")).and_return(load_fixture("league", "v2.1", "get"))
-
-      client.league21("foo")
-    end
-
-    it "returns an array of Leagues" do
-      expect(subject.map(&:class).uniq).to eq([League])
-    end
-  end
 end

data/spec/lol/game_request_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe GameRequest do
+  it "inherits from Request" do
+    expect(GameRequest.ancestors[1]).to eq(Request)
+  end
+
+  describe "#recent" do
+    let(:request) { GameRequest.new "api_key", "euw" }
+
+    subject do
+      expect(request.class).to receive(:get).with(request.api_url('v1.1', "game/by-summoner/1/recent")).and_return load_fixture('game', 'v1.1', 'get')
+
+      request.recent 1
+    end
+
+    it 'returns an array' do
+      expect(subject).to be_a Array
+    end
+
+    it 'returns an array of Games' do
+      expect(subject.map(&:class).uniq).to eq [Game]
+    end
+
+    it 'fetches games from the API' do
+      expect(subject.size).to eq load_fixture('game', 'v1.1', 'get')['games'].size
+    end
+  end
+
+end

data/spec/lol/league_request_spec.rb

@@ -0,0 +1,24 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe LeagueRequest do
+  it "inherits from Request" do
+    expect(LeagueRequest.ancestors[1]).to eq(Request)
+  end
+
+  describe "#get" do
+    let(:request) { LeagueRequest.new "api_key", "euw" }
+
+    subject do
+      expect(request.class).to receive(:get).with(request.api_url("v2.1", "league/by-summoner/foo")).and_return(load_fixture("league", "v2.1", "get"))
+
+      request.get("foo")
+    end
+
+    it "returns an array of Leagues" do
+      expect(subject.map(&:class).uniq).to eq([League])
+    end
+  end
+end

data/spec/lol/request.rb

@@ -0,0 +1,51 @@
+module Lol
+  # Encapsulates common methods for all requests
+  # Request classes inherit from this
+  class Request
+    include HTTParty
+
+    # @!attribute [r] api_key
+    #   @return [String] api_key
+    attr_reader :api_key
+
+
+    # @!attribute [rw] region
+    #   @return [String] region
+    attr_accessor :region
+
+    # Returns a full url for an API call
+    # @param version [String] API version to call
+    # @param path [String] API path to call
+    # @return [String] full fledged url
+    def api_url version, path, params = {}
+      lol = version == "v1.1" ? "lol" : ""
+      query_string = URI.encode_www_form params.merge api_key: api_key
+      File.join "http://prod.api.pvp.net/api/", lol, "/#{region}/#{version}/", "#{path}?#{query_string}"
+    end
+
+    # Calls the API via HTTParty and handles errors
+    # @param url [String] the url to call
+    # @return [String] raw response of the call
+    def perform_request url
+      response = self.class.get(url)
+      if response.is_a?(Hash) && response["status"]
+        raise InvalidAPIResponse.new(response["status"]["message"])
+      else
+        response
+      end
+    end
+
+    def initialize api_key, region
+      @api_key = api_key
+      @region = region
+    end
+    private
+
+    # Sets api_key to new_key
+    # @param new_key [String] a Riot Games API key
+    # @return [String] new_key
+    def api_key= new_key
+      @api_key = new_key
+    end
+  end
+end

data/spec/lol/request_spec.rb

@@ -0,0 +1,56 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe Request do
+  context "initialization" do
+    it "requires an api_key parameter" do
+      expect { ChampionRequest.new }.to raise_error(ArgumentError)
+    end
+
+    it "accepts a region parameter" do
+      expect { ChampionRequest.new "foo" }.to raise_error(ArgumentError)
+    end
+  end
+
+  subject { Request.new "api_key", "euw"}
+
+  describe "#perform_request" do
+    it "calls HTTParty get" do
+      expect(subject.class).to receive(:get).and_return(error_401)
+      expect { subject.perform_request "foo"}.to raise_error(InvalidAPIResponse)
+    end
+
+    it "handles 401" do
+      expect(subject.class).to receive(:get).and_return(error_401)
+      expect { subject.perform_request "foo" }.to raise_error(InvalidAPIResponse)
+    end
+  end
+
+  describe "api_url" do
+    it "defaults on Request#region" do
+      expect(subject.api_url("foo", "bar")).to match(/\/euw\//)
+    end
+
+    it "requires an api_key a version and a path" do
+      expect { subject.api_url "foo" }.to raise_error(ArgumentError)
+    end
+
+    it "returns a full fledged api url" do
+      expect(subject.api_url("foo", "bar")).to eq("http://prod.api.pvp.net/api/euw/foo/bar?api_key=api_key")
+    end
+
+    it "has lol if url is v1.1" do
+      expect(subject.api_url("v1.1", "foo")).to eq("http://prod.api.pvp.net/api/lol/euw/v1.1/foo?api_key=api_key")
+    end
+
+    it "does not have lol if url is v2.1 or greater" do
+      expect(subject.api_url("v2.1", "foo")).to eq("http://prod.api.pvp.net/api/euw/v2.1/foo?api_key=api_key")
+    end
+
+    it "optionally accept query string parameters" do
+      expect(subject.api_url("v2.1", "foo", a: 'b')).to eq("http://prod.api.pvp.net/api/euw/v2.1/foo?a=b&api_key=api_key")
+    end
+  end
+end

data/spec/lol/stats_request.rb

@@ -0,0 +1,29 @@
+module Lol
+  class StatsRequest < Request
+    # Retrieves player statistics summaries for the given summoner
+    # @param [String] summoner_id
+    # @return [Array] an array of player statistics, one per queue type
+    def summary summoner_id, extra = {}
+      if extra.keys.select { |k| k.to_sym != :season }.any?
+        raise ArgumentError, 'Only :season is allowed as extra parameter'
+      end
+      stats_api_path = "stats/by-summoner/#{summoner_id}/summary"
+      perform_request(api_url('v1.1', stats_api_path, extra))['playerStatSummaries'].map do |player_stat_data|
+        PlayerStatistic.new player_stat_data
+      end
+    end
+
+    # Retrieves ranked statistics summary for the given summoner
+    # @param [String] summoner_id
+    # @return [RankedStatisticsSummary] Ranked Stats.
+    #   Includes stats for Twisted Treeline and Summoner's Rift
+    def ranked summoner_id, extra = {}
+      if extra.keys.select { |k| k.to_sym != :season }.any?
+        raise ArgumentError, 'Only :season is allowed as extra parameter'
+      end
+      stats_api_path = "stats/by-summoner/#{summoner_id}/ranked"
+      RankedStatisticsSummary.new perform_request api_url 'v1.1', stats_api_path, extra
+    end
+
+  end
+end

data/spec/lol/stats_request_spec.rb

@@ -0,0 +1,79 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe StatsRequest do
+  let(:request) { StatsRequest.new "api_key", "euw" }
+
+  it "inherits from Request" do
+    expect(GameRequest.ancestors[1]).to eq(Request)
+  end
+
+  describe "#summary" do
+    let(:fixture) { load_fixture 'stats', 'v1.1', 'get' }
+
+    subject do
+      expect(request.class).to receive(:get).with(request.api_url('v1.1', "stats/by-summoner/1/summary")).and_return fixture
+
+      request.summary 1
+    end
+
+    it 'requires a summoner' do
+      expect { request.summary }.to raise_error ArgumentError
+    end
+
+    it 'returns an array' do
+      expect(subject).to be_a Array
+    end
+
+    it 'returns an array of PlayerStatistic' do
+      expect(subject.map(&:class).uniq).to eq [PlayerStatistic]
+    end
+
+    it 'fetches PlayerStatistics from the API' do
+      expect(subject.size).to eq load_fixture('stats', 'v1.1', 'get')['playerStatSummaries'].size
+    end
+
+    it 'optionally accepts a season' do
+      expect(request.class).to receive(:get).with(request.api_url('v1.1', 'stats/by-summoner/1/summary', season: '1')).and_return fixture
+      request.summary '1', season: '1'
+    end
+
+    it 'raises an error when unexpected parameter is received' do
+      expect { request.summary '1', asd: 'foo' }.to raise_error ArgumentError
+    end
+  end
+
+  describe "#ranked" do
+    let(:fixture) { load_fixture 'ranked_stats', 'v1.1', 'get' }
+
+    subject do
+      expect(request.class).to receive(:get).with(request.api_url('v1.1', "stats/by-summoner/1/ranked")).and_return fixture
+      request.ranked 1
+    end
+
+    it 'requires a summoner' do
+      expect { request.ranked }.to raise_error ArgumentError
+    end
+
+    it 'returns a RankedStatisticsSummary' do
+      expect(subject).to be_a RankedStatisticsSummary
+    end
+
+    it 'fetches RankedStatisticsSummary from the API' do
+      expect(subject.champions.size).to eq load_fixture('ranked_stats', 'v1.1', 'get')['champions'].size
+    end
+
+    it 'optionally accepts a season' do
+      expect(request.class).to receive(:get).with(request.api_url('v1.1', 'stats/by-summoner/1/ranked', season: '1')).and_return fixture
+
+      request.ranked '1', season: '1'
+    end
+
+    it 'raises an error when unexpected parameter is received' do
+      expect { request.ranked '1', asd: 'foo' }.to raise_error ArgumentError
+    end
+  end
+
+end

data/spec/lol/team_request_spec.rb

@@ -0,0 +1,39 @@
+require "spec_helper"
+require "lol"
+
+include Lol
+
+describe TeamRequest do
+  let(:request) { TeamRequest.new "api_key", "euw" }
+
+  it "inherits from Request" do
+    expect(TeamRequest.ancestors[1]).to eq(Request)
+  end
+
+  describe "get" do
+    let(:request) { TeamRequest.new "api_key", "euw" }
+    let(:fixture) { load_fixture 'team', 'v2.1', 'get' }
+
+    subject do
+      expect(request.class).to receive(:get).with(request.api_url('v2.1', "team/by-summoner/1")).and_return fixture
+      request.get 1
+    end
+
+    it 'requires a summoner' do
+      expect { request.get }.to raise_error ArgumentError
+    end
+
+    it 'returns an array' do
+      expect(subject).to be_a Array
+    end
+
+    it 'returns an array of Team' do
+      expect(subject.map(&:class).uniq).to eq [Team]
+    end
+
+    it 'fetches Team from the API' do
+      expect(subject.size).to eq fixture.size
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -43,3 +43,7 @@ end
 def error_401
   {"status" => {"message" => "Foo", "status_code" => 401}}
 end
+
+RSpec.configure do |c|
+  c.fail_fast = true
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lol
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Giovanni Intini
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-14 00:00:00.000000000 Z
+date: 2013-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -244,12 +244,15 @@ files:
 - lib/lol.rb
 - lib/lol/aggregated_statistic.rb
 - lib/lol/champion.rb
+- lib/lol/champion_request.rb
 - lib/lol/champion_statistic.rb
 - lib/lol/champion_statistics_summary.rb
 - lib/lol/client.rb
 - lib/lol/game.rb
+- lib/lol/game_request.rb
 - lib/lol/league.rb
 - lib/lol/league_entry.rb
+- lib/lol/league_request.rb
 - lib/lol/match_summary.rb
 - lib/lol/mini_series.rb
 - lib/lol/model.rb
@@ -260,6 +263,7 @@ files:
 - lib/lol/roster.rb
 - lib/lol/team.rb
 - lib/lol/team_member.rb
+- lib/lol/team_request.rb
 - lib/lol/team_statistic.rb
 - lib/lol/version.rb
 - ruby-lol.gemspec
@@ -270,12 +274,15 @@ files:
 - spec/fixtures/v2.1/get-league.json
 - spec/fixtures/v2.1/get-team.json
 - spec/lol/aggregated_statistic_spec.rb
+- spec/lol/champion_request_spec.rb
 - spec/lol/champion_spec.rb
 - spec/lol/champion_statistic_spec.rb
 - spec/lol/champion_statistics_summary_spec.rb
 - spec/lol/client_spec.rb
+- spec/lol/game_request_spec.rb
 - spec/lol/game_spec.rb
 - spec/lol/league_entry_spec.rb
+- spec/lol/league_request_spec.rb
 - spec/lol/league_spec.rb
 - spec/lol/match_summary_spec.rb
 - spec/lol/mini_series_spec.rb
@@ -283,8 +290,13 @@ files:
 - spec/lol/player_statistic_spec.rb
 - spec/lol/ranked_statistics_summary_spec.rb
 - spec/lol/raw_statistic_spec.rb
+- spec/lol/request.rb
+- spec/lol/request_spec.rb
 - spec/lol/roster_spec.rb
+- spec/lol/stats_request.rb
+- spec/lol/stats_request_spec.rb
 - spec/lol/team_member_spec.rb
+- spec/lol/team_request_spec.rb
 - spec/lol/team_spec.rb
 - spec/lol/team_statistic_spec.rb
 - spec/spec_helper.rb
@@ -321,12 +333,15 @@ test_files:
 - spec/fixtures/v2.1/get-league.json
 - spec/fixtures/v2.1/get-team.json
 - spec/lol/aggregated_statistic_spec.rb
+- spec/lol/champion_request_spec.rb
 - spec/lol/champion_spec.rb
 - spec/lol/champion_statistic_spec.rb
 - spec/lol/champion_statistics_summary_spec.rb
 - spec/lol/client_spec.rb
+- spec/lol/game_request_spec.rb
 - spec/lol/game_spec.rb
 - spec/lol/league_entry_spec.rb
+- spec/lol/league_request_spec.rb
 - spec/lol/league_spec.rb
 - spec/lol/match_summary_spec.rb
 - spec/lol/mini_series_spec.rb
@@ -334,8 +349,13 @@ test_files:
 - spec/lol/player_statistic_spec.rb
 - spec/lol/ranked_statistics_summary_spec.rb
 - spec/lol/raw_statistic_spec.rb
+- spec/lol/request.rb
+- spec/lol/request_spec.rb
 - spec/lol/roster_spec.rb
+- spec/lol/stats_request.rb
+- spec/lol/stats_request_spec.rb
 - spec/lol/team_member_spec.rb
+- spec/lol/team_request_spec.rb
 - spec/lol/team_spec.rb
 - spec/lol/team_statistic_spec.rb
 - spec/spec_helper.rb