ruby-lokalise-api 2.8.0 → 2.9.0

data/spec/lib/ruby-lokalise-api/rest/files_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
 
   describe '#files' do
-    it 'should return all files' do
+    it 'returns all files' do
       files = VCR.use_cassette('files') do
         test_client.files project_id
       end.collection
@@ -14,7 +16,7 @@ RSpec.describe Lokalise::Client do
       expect(file.key_count).to eq(1)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       files = VCR.use_cassette('all_files_pagination') do
         test_client.files project_id, limit: 1, page: 1
       end

data/spec/lib/ruby-lokalise-api/rest/keys_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
   let(:key_id) { 15_305_182 }
   let(:new_key_id) { 15_519_770 }
 
   describe '#keys' do
-    it 'should return all keys' do
+    it 'returns all keys' do
       keys = VCR.use_cassette('all_keys') do
         test_client.keys project_id
       end.collection
@@ -12,7 +14,7 @@ RSpec.describe Lokalise::Client do
       expect(keys.count).to eq(1)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       keys = VCR.use_cassette('all_keys_pagination') do
         test_client.keys project_id, limit: 1, page: 1
       end
@@ -126,8 +128,8 @@ RSpec.describe Lokalise::Client do
     expect(response['keys_removed']).to eq(true)
   end
 
-  context 'key chained methods' do
-    it 'should support update and destroy' do
+  context 'when key methods are chained' do
+    it 'supports update and destroy' do
       key = VCR.use_cassette('create_another_key') do
         test_client.create_keys project_id, key_name: 'chained_k', platforms: %w[ios]
       end.collection.first
@@ -153,8 +155,8 @@ RSpec.describe Lokalise::Client do
     end
   end
 
-  context 'keys collection chained methods' do
-    it 'should support destroy_all' do
+  context 'when keys collection methods are chained' do
+    it 'supports destroy_all' do
       keys = VCR.use_cassette('create_keys_collection') do
         test_client.create_keys project_id, [
           {

data/spec/lib/ruby-lokalise-api/rest/languages_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
   let(:language_id) { 640 }
   let(:new_language_id) { 894 }
 
   describe '#system_languages' do
-    it 'should return all system languages' do
+    it 'returns all system languages' do
       languages = VCR.use_cassette('all_system_languages') do
         test_client.system_languages
       end.collection
@@ -13,7 +15,7 @@ RSpec.describe Lokalise::Client do
       expect(languages.first.lang_iso).to eq('ab')
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       languages = VCR.use_cassette('all_system_languages_pagination') do
         test_client.system_languages limit: 10, page: 3
       end
@@ -27,7 +29,7 @@ RSpec.describe Lokalise::Client do
   end
 
   describe '#project_languages' do
-    it 'should return all project languages' do
+    it 'returns all project languages' do
       languages = VCR.use_cassette('all_project_languages') do
         test_client.project_languages project_id
       end.collection
@@ -36,7 +38,7 @@ RSpec.describe Lokalise::Client do
       expect(languages.first.lang_iso).to eq('en')
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       languages = VCR.use_cassette('all_project_languages_pagination') do
         test_client.project_languages project_id, limit: 1, page: 2
       end
@@ -89,8 +91,8 @@ RSpec.describe Lokalise::Client do
     expect(response['language_deleted']).to eq(true)
   end
 
-  context 'project language chained methods' do
-    it 'should support update and destroy' do
+  context 'when project language methods are chained' do
+    it 'supports update and destroy' do
       language = VCR.use_cassette('create_another_language') do
         test_client.create_languages project_id, lang_iso: 'ab', custom_name: 'chained lang'
       end.collection.first

data/spec/lib/ruby-lokalise-api/rest/orders_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:team_id) { 176_692 }
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
@@ -6,7 +8,7 @@ RSpec.describe Lokalise::Client do
   let(:card_id) { 1774 }
 
   describe '#orders' do
-    it 'should return all orders' do
+    it 'returns all orders' do
       orders = VCR.use_cassette('all_orders') do
         test_client.orders team_id
       end.collection
@@ -15,7 +17,7 @@ RSpec.describe Lokalise::Client do
       expect(orders.first.order_id).to eq(order_id)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       orders = VCR.use_cassette('all_orders_pagination') do
         test_client.orders team_id, limit: 1, page: 1
       end

data/spec/lib/ruby-lokalise-api/rest/payment_cards_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:card_id) { 1773 }
 
   describe '#payment_cards' do
-    it 'should return all payment cards' do
+    it 'returns all payment cards' do
       cards = VCR.use_cassette('all_payment_cards') do
         test_client.payment_cards
       end.collection
@@ -12,7 +14,7 @@ RSpec.describe Lokalise::Client do
       expect(card.last4).to eq('0358')
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       cards = VCR.use_cassette('all_payment_cards_pagination') do
         test_client.payment_cards limit: 1, page: 1
       end
@@ -62,7 +64,7 @@ RSpec.describe Lokalise::Client do
     expect(result['card_id']).to eq(card_id)
   end
 
-  it 'should support chained destroy' do
+  it 'supports chained destroy' do
     card = VCR.use_cassette('payment_card') do
       test_client.payment_card card_id
     end

data/spec/lib/ruby-lokalise-api/rest/projects_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:new_project_id) { '572222075c0953fd70d492.30502628' }
 
   describe '#projects' do
-    it 'should return all projects' do
+    it 'returns all projects' do
       projects = VCR.use_cassette('all_projects') do
         test_client.projects
       end.collection
@@ -12,7 +14,7 @@ RSpec.describe Lokalise::Client do
       expect(project.name).to eq('demo phoenix')
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       projects = VCR.use_cassette('all_projects_pagination') do
         test_client.projects limit: 1, page: 2
       end
@@ -87,8 +89,8 @@ RSpec.describe Lokalise::Client do
     expect(response['project_deleted']).to eq(true)
   end
 
-  context 'project chained methods' do
-    it 'should support update, empty, and destroy' do
+  context 'when project methods are chained' do
+    it 'supports update, empty, and destroy' do
       project = VCR.use_cassette('create_another_project') do
         test_client.create_project name: 'chained proj'
       end

data/spec/lib/ruby-lokalise-api/rest/screenshots_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
   let(:screenshot_id) { 115_185 }
 
   describe '#screenshots' do
-    it 'should return all screenshots' do
+    it 'returns all screenshots' do
       screenshots = VCR.use_cassette('all_screenshots') do
         test_client.screenshots project_id
       end.collection
@@ -11,7 +13,7 @@ RSpec.describe Lokalise::Client do
       expect(screenshots.count).to eq(1)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       screenshots = VCR.use_cassette('all_screenshots_pagination') do
         test_client.screenshots project_id, limit: 1, page: 1
       end
@@ -69,8 +71,8 @@ RSpec.describe Lokalise::Client do
     expect(response['screenshot_deleted']).to eq(true)
   end
 
-  context 'screenshot chained methods' do
-    it 'should support update and destroy' do
+  context 'when screenshot methods are chained' do
+    it 'supports update and destroy' do
       screenshot = screenshot_from_file do |file|
         VCR.use_cassette('create_another_screenshot') do
           test_client.create_screenshots project_id, data: file.read, title: 'chained screen'

data/spec/lib/ruby-lokalise-api/rest/snapshots_spec.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
   let(:snapshot_id) { 27_881 }
 
   describe '#snapshots' do
-    it 'should return all snapshots' do
+    it 'returns all snapshots' do
       snapshots = VCR.use_cassette('all_snapshots') do
         test_client.snapshots project_id
       end.collection
@@ -19,7 +21,7 @@ RSpec.describe Lokalise::Client do
       expect(snapshot.created_at_timestamp).to eq(1_544_461_324)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       snapshots = VCR.use_cassette('all_snapshots_pagination') do
         test_client.snapshots project_id, limit: 1, page: 2
       end
@@ -65,8 +67,8 @@ RSpec.describe Lokalise::Client do
     expect(response['snapshot_deleted']).to eq(true)
   end
 
-  context 'snapshot chained methods' do
-    it 'should support destroy and restore' do
+  context 'when snapshot methods are chained' do
+    it 'supports destroy and restore' do
       snapshot = VCR.use_cassette('create_another_snapshot') do
         test_client.create_snapshot project_id, title: 'chained'
       end

data/spec/lib/ruby-lokalise-api/rest/tasks_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
   let(:key_id) { 15_571_976 }
   let(:task_id) { 4387 }
 
   describe '#tasks' do
-    it 'should return all tasks' do
+    it 'returns all tasks' do
       tasks = VCR.use_cassette('all_tasks') do
         test_client.tasks project_id
       end.collection
@@ -12,7 +14,7 @@ RSpec.describe Lokalise::Client do
       expect(tasks.count).to eq(3)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       tasks = VCR.use_cassette('all_tasks_pagination') do
         test_client.tasks project_id, limit: 2, page: 2
       end
@@ -92,8 +94,8 @@ RSpec.describe Lokalise::Client do
     expect(response['task_deleted']).to eq(true)
   end
 
-  context 'task chained methods' do
-    it 'should support update and destroy' do
+  context 'when task methods are chained' do
+    it 'supports update and destroy' do
       task = VCR.use_cassette('create_another_task') do
         test_client.create_task project_id, title: 'chained',
                                             keys: [key_id],

data/spec/lib/ruby-lokalise-api/rest/team_user_groups_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:team_id) { 176_692 }
   let(:group_id) { 515 }
@@ -8,7 +10,7 @@ RSpec.describe Lokalise::Client do
   let(:user_id) { 35_554 }
 
   describe '#team_user_groups' do
-    it 'should return all team_user_groups' do
+    it 'returns all team_user_groups' do
       team_user_groups = VCR.use_cassette('team_user_groups') do
         test_client.team_user_groups team_id
       end
@@ -17,7 +19,7 @@ RSpec.describe Lokalise::Client do
       expect(team_user_groups.team_id).to eq(team_id)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       team_users = VCR.use_cassette('team_user_groups_pagination') do
         test_client.team_user_groups team_id, limit: 1, page: 2
       end
@@ -121,8 +123,8 @@ RSpec.describe Lokalise::Client do
     expect(group.members).to be_empty
   end
 
-  context 'team user group chained methods' do
-    it 'should support update and destroy' do
+  context 'when team user group methods are chained' do
+    it 'supports update and destroy' do
       group = VCR.use_cassette('another_team_user_group') do
         test_client.team_user_group team_id, third_group_id
       end
@@ -145,7 +147,7 @@ RSpec.describe Lokalise::Client do
       expect(response['group_deleted']).to eq(true)
     end
 
-    it 'should support project management' do
+    it 'supports project management' do
       group = VCR.use_cassette('team_user_group') do
         test_client.team_user_group team_id, group_id
       end
@@ -167,7 +169,7 @@ RSpec.describe Lokalise::Client do
       expect(group.projects).not_to include(another_project_id)
     end
 
-    it 'should support users management' do
+    it 'supports users management' do
       group = VCR.use_cassette('team_user_group') do
         test_client.team_user_group team_id, group_id
       end

data/spec/lib/ruby-lokalise-api/rest/team_users_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:team_id) { 176_692 }
   let(:team_user_id) { 25_953 }
   let(:another_user_id) { 26_265 }
 
   describe '#team_users' do
-    it 'should return all team_users' do
+    it 'returns all team_users' do
       team_users = VCR.use_cassette('team_users') do
         test_client.team_users team_id
       end
@@ -13,7 +15,7 @@ RSpec.describe Lokalise::Client do
       expect(team_users.team_id).to eq(team_id)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       team_users = VCR.use_cassette('all_team_users_pagination') do
         test_client.team_users team_id, limit: 1, page: 3
       end
@@ -56,8 +58,8 @@ RSpec.describe Lokalise::Client do
     expect(response['team_user_deleted']).to eq(true)
   end
 
-  context 'team user chained methods' do
-    it 'should support update and destroy' do
+  context 'when team user methods are chained' do
+    it 'supports update and destroy' do
       team_user = VCR.use_cassette('another_team_user') do
         test_client.team_user team_id, another_user_id
       end

data/spec/lib/ruby-lokalise-api/rest/teams_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   specify '#teams' do
     teams = VCR.use_cassette('teams') do

data/spec/lib/ruby-lokalise-api/rest/translation_providers_spec.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:team_id) { 176_692 }
 
   describe '#translation_providers' do
-    it 'should return all providers' do
+    it 'returns all providers' do
       providers = VCR.use_cassette('all_translation_providers') do
         test_client.translation_providers team_id
       end.collection
@@ -11,7 +13,7 @@ RSpec.describe Lokalise::Client do
       expect(providers.first.slug).to eq('gengo')
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       providers = VCR.use_cassette('all_translation_providers_pagination') do
         test_client.translation_providers team_id, limit: 1, page: 2
       end

data/spec/lib/ruby-lokalise-api/rest/translations_spec.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 RSpec.describe Lokalise::Client do
   let(:project_id) { '803826145ba90b42d5d860.46800099' }
   let(:translation_id) { 80_015_147 }
   let(:another_translation_id) { 82_070_312 }
 
   describe '#translations' do
-    it 'should return all translations' do
+    it 'returns all translations' do
       translations = VCR.use_cassette('translations') do
         test_client.translations project_id
       end.collection
@@ -12,7 +14,7 @@ RSpec.describe Lokalise::Client do
       expect(translations.count).to eq(9)
     end
 
-    it 'should support pagination' do
+    it 'supports pagination' do
       translations = VCR.use_cassette('all_translations_pagination') do
         test_client.translations project_id, limit: 4, page: 2, disable_references: 0,
                                              filter_is_reviewed: 0
@@ -32,7 +34,7 @@ RSpec.describe Lokalise::Client do
       end
 
       expect(next_page_trans).to be_an_instance_of(Lokalise::Collections::Translation)
-      expect(next_page_trans.client).to be_an_instance_of(Lokalise::Client)
+      expect(next_page_trans.client).to be_an_instance_of(described_class)
       expect(next_page_trans.request_params[:page]).to eq(3)
       expect(next_page_trans.request_params[:disable_references]).to eq(0)
       expect(next_page_trans.total_results).to eq(187)
@@ -45,7 +47,7 @@ RSpec.describe Lokalise::Client do
       end
 
       expect(prev_page_trans).to be_an_instance_of(Lokalise::Collections::Translation)
-      expect(prev_page_trans.client).to be_an_instance_of(Lokalise::Client)
+      expect(prev_page_trans.client).to be_an_instance_of(described_class)
       expect(prev_page_trans.request_params[:page]).to eq(1)
       expect(next_page_trans.request_params[:disable_references]).to eq(0)
       expect(prev_page_trans.total_results).to eq(187)
@@ -85,8 +87,8 @@ RSpec.describe Lokalise::Client do
     expect(translation.is_reviewed).to eq(true)
   end
 
-  context 'translation chained methods' do
-    it 'should support update' do
+  context 'when translation chained methods are used' do
+    it 'supports update' do
       translation = VCR.use_cassette('another_translation') do
         test_client.translation project_id, another_translation_id
       end