ruby-lokalise-api 2.1.0 → 2.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d80bce654f8a062530bb976701b4325642c2f9226d49b875ed9b611a0e8c7af8
-  data.tar.gz: 8d1a71d71f64fcd7fc4ea39d3f3501150f6f08ec809685d777343fc826250df1
+  metadata.gz: 7df41029b7adabd3bac978798ce048ae42a0c5e5d35c576c601c0b9b6995ce57
+  data.tar.gz: faed59d883ee1f446f72ed64ff0b85f85963d16f808bc20f08f18514938bf44e
 SHA512:
-  metadata.gz: b3104ba420248487cd1baa2f4f310390b71a1e852002535ad2a2d85fcb61de9197804a05761b03d7a4fc38ddcbe3b12d3d2fce8c460666c02cda63162fb74269
-  data.tar.gz: c8c6a680b30f268dc0ec7823f6485dbe6211149177587f3e1ea108d81ad3d00a338a67a94e1959907b7ae9ea29526cc1840fd11172ad78fdafb35d28df1262d0
+  metadata.gz: 9e5f04d28fefa3d892310c7d596ee2cd66fe7606f7f1eec68f854101ebea00fc69e3e6c1ae5ff6c742294a128ea85cb1eca249d7fdd02f30a6cddb10a1777157
+  data.tar.gz: 2e33876bd69588e81ae657454d4d0dc67aa589c1283e2737b40706da7c16896c78934aad94daac5da256ed185b26b887d73e8dc16af19c00160d475faa50b2db

data/CHANGELOG.md

@@ -1,4 +1,9 @@
 # Changelog
+## 2.1.1 (17-May-19)
+
+* Incorporate API updates (new attributes, mostly creation and update timestamps)
+* Remove trailing slash from request URLs
+* Updated cassettes and target Rubies (for Travis)
 
 ## 2.1.0 (19-Mar-19)
 

data/README.md

@@ -1132,7 +1132,7 @@ user.destroy
 @client.translations(project_id, params = {})   # Input:
                                                 ## project_id (string, required)
                                                 ## params (hash)
-                                                ### :disable_references (string) - whether to disable key references. Supported values are 0 and 1
+                                                ### Find full list in the docs
                                                 ### :page and :limit
                                                 # Output:
                                                 ## Collection of translations for the project

data/lib/ruby-lokalise-api/connection.rb

@@ -7,7 +7,7 @@ module Lokalise
         headers: {
           accept: 'application/json',
           user_agent: "ruby-lokalise-api gem/#{Lokalise::VERSION}",
-          'X-Api-Token': token
+          'x-api-token': token
         },
         url: BASE_URL
       }

data/lib/ruby-lokalise-api/data/attributes.json

@@ -5,7 +5,8 @@
     "comment",
     "added_by",
     "added_by_email",
-    "added_at"
+    "added_at",
+    "added_at_timestamp"
   ],
   "contributor": [
     "user_id",
@@ -15,7 +16,8 @@
     "is_admin",
     "is_reviewer",
     "languages",
-    "admin_rights"
+    "admin_rights",
+    "created_at_timestamp"
   ],
   "file": [
     "filename",
@@ -39,7 +41,8 @@
     "context",
     "base_words",
     "char_limit",
-    "custom_attributes"
+    "custom_attributes",
+    "created_at_timestamp"
   ],
   "language": [
     "lang_id",
@@ -65,13 +68,15 @@
     "translation_tier",
     "translation_tier_name",
     "briefing",
-    "total"
+    "total",
+    "created_at_timestamp"
   ],
   "payment_card": [
     "card_id",
     "last4",
     "brand",
-    "created_at"
+    "created_at",
+    "created_at_timestamp"
   ],
   "project": [
     "project_id",
@@ -80,7 +85,12 @@
     "created_at",
     "created_by",
     "created_by_email",
-    "team_id"
+    "team_id",
+    "created_at_timestamp",
+    "base_language_id",
+    "base_language_iso",
+    "settings",
+    "statistics"
   ],
   "screenshot": [
     "screenshot_id",
@@ -90,14 +100,17 @@
     "description",
     "screenshot_tags",
     "width",
-    "height"
+    "height",
+    "created_at",
+    "created_at_timestamp"
   ],
   "snapshot": [
     "snapshot_id",
     "title",
     "created_at",
     "created_by",
-    "created_by_email"
+    "created_by_email",
+    "created_at_timestamp"
   ],
   "task": [
     "task_id",
@@ -106,19 +119,23 @@
     "status",
     "progress",
     "due_date",
+    "due_date_timestamp",
     "keys_count",
     "words_count",
     "created_at",
+    "created_at_timestamp",
     "created_by",
     "created_by_email",
     "can_be_parent",
     "task_type",
     "parent_task_id",
     "closing_tags",
+    "do_lock_translations",
     "languages",
     "auto_close_languages",
     "auto_close_task",
     "completed_at",
+    "completed_at_timestamp",
     "completed_by",
     "completed_by_email"
   ],
@@ -128,20 +145,23 @@
     "created_at",
     "plan",
     "quota_usage",
-    "quota_allowed"
+    "quota_allowed",
+    "created_at_timestamp"
   ],
   "team_user": [
     "user_id",
     "email",
     "fullname",
     "created_at",
-    "role"
+    "role",
+    "created_at_timestamp"
   ],
   "translation": [
     "translation_id",
     "key_id",
     "language_iso",
     "modified_at",
+    "modified_at_timestamp",
     "modified_by",
     "modified_by_email",
     "translation",

data/lib/ruby-lokalise-api/request.rb

@@ -27,7 +27,10 @@ module Lokalise
 
     def delete(path, client, params = {})
       respond_with(
+        # Rubocop tries to replace `delete` with `gsub` but that's a different method here!
+        # rubocop:disable Style/CollectionMethods
         connection(client.token).delete(prepare(path)) do |req|
+          # rubocop:enable Style/CollectionMethods
           req.body = MultiJson.dump(params)
         end,
         client
@@ -36,9 +39,9 @@ module Lokalise
 
     private
 
-    # Get rid of double slashes in the `path` and leading slash
+    # Get rid of double slashes in the `path`, leading and trailing slash
     def prepare(path)
-      path.gsub(%r{\A/}, '').gsub %r{//}, '/'
+      path.gsub(%r{\A/}, '').gsub(%r{//}, '/').gsub(%r{/\z}, '')
     end
 
     def respond_with(response, client)

data/lib/ruby-lokalise-api/version.rb

@@ -1,3 +1,3 @@
 module Lokalise
-  VERSION = '2.1.0'.freeze
+  VERSION = '2.1.1'.freeze
 end

data/ruby-lokalise-api.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake',                      '~> 12.1'
   spec.add_development_dependency 'rspec',                     '~> 3.6'
   spec.add_development_dependency 'rubocop',                   '~> 0.60'
+  spec.add_development_dependency 'rubocop-performance',       '~> 1.0'
   spec.add_development_dependency 'simplecov',                 '~> 0.16'
   spec.add_development_dependency 'vcr',                       '~> 4.0'
 end

data/spec/lib/ruby-lokalise-api/rest/comments_spec.rb

@@ -43,7 +43,8 @@ RSpec.describe Lokalise::Client do
     expect(comment.key_id).to eq(another_key_id)
     expect(comment.added_by).to eq(20_181)
     expect(comment.added_by_email).to eq('bodrovis@protonmail.com')
-    expect(comment.added_at).to eq('2018-12-09 19:41:44 (Etc/UTC)')
+    expect(comment.added_at).to eq('2018-12-09 18:41:44 (Etc/UTC)')
+    expect(comment.added_at_timestamp).to eq(1_544_380_904)
   end
 
   specify '#create_comments' do

data/spec/lib/ruby-lokalise-api/rest/contributors_spec.rb

@@ -37,12 +37,13 @@ RSpec.describe Lokalise::Client do
 
     expect(contributor.user_id).to eq(20_181)
     expect(contributor.email).to eq('bodrovis@protonmail.com')
-    expect(contributor.fullname).to eq('Ilya')
-    expect(contributor.created_at).to eq('2018-08-21 17:35:25 (Etc/UTC)')
+    expect(contributor.fullname).to eq('Ilya B')
+    expect(contributor.created_at).to eq('2018-08-21 15:35:25 (Etc/UTC)')
     expect(contributor.is_admin).to eq(true)
     expect(contributor.is_reviewer).to eq(true)
-    expect(contributor.languages.first['lang_id']).to eq(640)
+    expect(contributor.languages.first['lang_id']).to eq(803)
     expect(contributor.admin_rights.first).to eq('upload')
+    expect(contributor.created_at_timestamp).to eq(1_534_865_725)
   end
 
   specify '#create_contributors' do

data/spec/lib/ruby-lokalise-api/rest/projects_spec.rb

@@ -39,9 +39,14 @@ RSpec.describe Lokalise::Client do
     expect(project.name).to eq('demo phoenix')
     expect(project.team_id).to eq(176_692)
     expect(project.description).to eq('')
-    expect(project.created_at).to eq('2018-09-24 18:05:22 (Etc/UTC)')
+    expect(project.created_at).to eq('2018-09-24 16:05:22 (Etc/UTC)')
     expect(project.created_by).to eq(20_181)
     expect(project.created_by_email).to eq('bodrovis@protonmail.com')
+    expect(project.created_at_timestamp).to eq(1_537_805_122)
+    expect(project.base_language_id).to eq(640)
+    expect(project.base_language_iso).to eq('en')
+    expect(project.settings['per_platform_key_names']).to eq(false)
+    expect(project.statistics['progress_total']).to eq(18)
   end
 
   specify '#create_project' do

data/spec/lib/ruby-lokalise-api/rest/snapshots_spec.rb

@@ -10,12 +10,13 @@ RSpec.describe Lokalise::Client do
 
       snapshot = snapshots.first
 
-      expect(snapshots.count).to eq(2)
-      expect(snapshot.title).to eq('test')
-      expect(snapshot.snapshot_id).to eq(snapshot_id)
-      expect(snapshot.created_at).to eq('2018-12-10 17:01:48 (Etc/UTC)')
+      expect(snapshots.count).to eq(1)
+      expect(snapshot.title).to eq('test rspec')
+      expect(snapshot.snapshot_id).to eq(27_882)
+      expect(snapshot.created_at).to eq('2018-12-10 17:02:04 (Etc/UTC)')
       expect(snapshot.created_by).to eq(20_181)
       expect(snapshot.created_by_email).to eq('bodrovis@protonmail.com')
+      expect(snapshot.created_at_timestamp).to eq(1_544_461_324)
     end
 
     it 'should support pagination' do

data/spec/lib/ruby-lokalise-api/rest/tasks_spec.rb

@@ -27,30 +27,34 @@ RSpec.describe Lokalise::Client do
 
   specify '#task' do
     task = VCR.use_cassette('task') do
-      test_client.task project_id, task_id
+      test_client.task project_id, '11925'
     end
 
-    expect(task.task_id).to eq(task_id)
-    expect(task.title).to eq('another rspec key')
-    expect(task.description).to eq('desc here')
-    expect(task.status).to eq('created')
-    expect(task.progress).to eq(0)
+    expect(task.task_id).to eq(11_925)
+    expect(task.title).to eq('Demo review')
+    expect(task.description).to eq('')
+    expect(task.status).to eq('in progress')
+    expect(task.progress).to eq(1)
     expect(task.due_date).to eq(nil)
-    expect(task.keys_count).to eq(1)
-    expect(task.words_count).to eq(0)
-    expect(task.created_at).to eq('2018-12-10 18:37:02 (Etc/UTC)')
+    expect(task.due_date_timestamp).to eq(nil)
+    expect(task.keys_count).to eq(16)
+    expect(task.words_count).to eq(275)
+    expect(task.created_at).to eq('2019-05-13 16:15:26 (Etc/UTC)')
+    expect(task.created_at_timestamp).to eq(1_557_764_126)
     expect(task.created_by).to eq(20_181)
     expect(task.created_by_email).to eq('bodrovis@protonmail.com')
     expect(task.can_be_parent).to eq(true)
-    expect(task.task_type).to eq('translation')
+    expect(task.task_type).to eq('review')
     expect(task.parent_task_id).to eq(nil)
     expect(task.closing_tags).to eq([])
-    expect(task.languages.first['language_iso']).to eq('ru')
+    expect(task.languages.first['language_iso']).to eq('sq')
     expect(task.auto_close_languages).to eq(true)
     expect(task.auto_close_task).to eq(true)
     expect(task.completed_by).to eq(nil)
     expect(task.completed_by_email).to eq(nil)
     expect(task.completed_at).to eq(nil)
+    expect(task.completed_at_timestamp).to eq(nil)
+    expect(task.do_lock_translations).to eq(false)
   end
 
   specify '#create_task' do

data/spec/lib/ruby-lokalise-api/rest/team_users_spec.rb

@@ -28,14 +28,15 @@ RSpec.describe Lokalise::Client do
 
   specify '#team_user' do
     team_user = VCR.use_cassette('team_user') do
-      test_client.team_user team_id, team_user_id
+      test_client.team_user team_id, '20181'
     end
 
-    expect(team_user.user_id).to eq(team_user_id)
-    expect(team_user.email).to eq('rspec@test.com')
-    expect(team_user.fullname).to eq('Rspec test')
-    expect(team_user.created_at).to eq('2018-12-07 18:21:24 (Etc/UTC)')
-    expect(team_user.role).to eq('member')
+    expect(team_user.user_id).to eq(20_181)
+    expect(team_user.email).to eq('bodrovis@protonmail.com')
+    expect(team_user.fullname).to eq('Ilya B')
+    expect(team_user.created_at).to eq('2018-08-21 15:35:25 (Etc/UTC)')
+    expect(team_user.created_at_timestamp).to eq(1_534_865_725)
+    expect(team_user.role).to eq('owner')
   end
 
   specify '#update_team_user' do

data/spec/lib/ruby-lokalise-api/rest/teams_spec.rb

@@ -1,22 +1,23 @@
 RSpec.describe Lokalise::Client do
   specify '#teams' do
     teams = VCR.use_cassette('teams') do
-      test_client.teams page: 1, limit: 1
+      test_client.teams page: 2, limit: 1
     end
 
     team = teams.collection.first
 
     expect(teams.collection.length).to eq(1)
-    expect(teams.total_results).to eq(1)
-    expect(teams.total_pages).to eq(1)
+    expect(teams.total_results).to eq(2)
+    expect(teams.total_pages).to eq(2)
     expect(teams.results_per_page).to eq(1)
-    expect(teams.current_page).to eq(1)
+    expect(teams.current_page).to eq(2)
 
     expect(team.team_id).to eq(176_692)
     expect(team.name).to eq('Ilya\'s Team')
-    expect(team.created_at).to eq('2018-08-21 17:35:25 (Etc/UTC)')
+    expect(team.created_at).to eq('2018-08-21 15:35:25 (Etc/UTC)')
+    expect(team.created_at_timestamp).to eq(1_534_865_725)
     expect(team.plan).to eq('Trial')
-    expect(team.quota_usage['users']).to eq(4)
+    expect(team.quota_usage['users']).to eq(9)
     expect(team.quota_allowed['keys']).to eq(999_999_999)
   end
 end

data/spec/lib/ruby-lokalise-api/rest/translation_providers_spec.rb

@@ -13,14 +13,14 @@ RSpec.describe Lokalise::Client do
 
     it 'should support pagination' do
       providers = VCR.use_cassette('all_translation_providers_pagination') do
-        test_client.translation_providers team_id, limit: 2, page: 1
+        test_client.translation_providers team_id, limit: 1, page: 2
       end
 
       expect(providers.collection.count).to eq(1)
-      expect(providers.total_results).to eq(3)
+      expect(providers.total_results).to eq(2)
       expect(providers.total_pages).to eq(2)
-      expect(providers.results_per_page).to eq(2)
-      expect(providers.current_page).to eq(1)
+      expect(providers.results_per_page).to eq(1)
+      expect(providers.current_page).to eq(2)
     end
   end
 

data/spec/lib/ruby-lokalise-api/rest/translations_spec.rb

@@ -14,16 +14,18 @@ RSpec.describe Lokalise::Client do
 
     it 'should support pagination' do
       translations = VCR.use_cassette('all_translations_pagination') do
-        test_client.translations project_id, limit: 4, page: 2, disable_references: 0
+        test_client.translations project_id, limit: 4, page: 2, disable_references: 0,
+                                             filter_is_reviewed: 0
       end
 
       expect(translations.collection.count).to eq(4)
-      expect(translations.total_results).to eq(9)
-      expect(translations.total_pages).to eq(3)
+      expect(translations.total_results).to eq(187)
+      expect(translations.total_pages).to eq(47)
       expect(translations.results_per_page).to eq(4)
       expect(translations.current_page).to eq(2)
       expect(translations.request_params[:page]).to eq(2)
       expect(translations.request_params[:disable_references]).to eq(0)
+      expect(translations.request_params[:filter_is_reviewed]).to eq(0)
 
       next_page_trans = VCR.use_cassette('translations_next_page') do
         translations.next_page
@@ -33,9 +35,9 @@ RSpec.describe Lokalise::Client do
       expect(next_page_trans.client).to be_an_instance_of(Lokalise::Client)
       expect(next_page_trans.request_params[:page]).to eq(3)
       expect(next_page_trans.request_params[:disable_references]).to eq(0)
-      expect(next_page_trans.total_results).to eq(9)
+      expect(next_page_trans.total_results).to eq(187)
       expect(next_page_trans.current_page).to eq(3)
-      expect(next_page_trans.next_page?).to eq(false)
+      expect(next_page_trans.next_page?).to eq(true)
       expect(next_page_trans.prev_page?).to eq(true)
 
       prev_page_trans = VCR.use_cassette('translations_prev_page') do
@@ -46,7 +48,7 @@ RSpec.describe Lokalise::Client do
       expect(prev_page_trans.client).to be_an_instance_of(Lokalise::Client)
       expect(prev_page_trans.request_params[:page]).to eq(1)
       expect(next_page_trans.request_params[:disable_references]).to eq(0)
-      expect(prev_page_trans.total_results).to eq(9)
+      expect(prev_page_trans.total_results).to eq(187)
       expect(prev_page_trans.current_page).to eq(1)
       expect(prev_page_trans.next_page?).to eq(true)
       expect(prev_page_trans.prev_page?).to eq(false)
@@ -61,13 +63,14 @@ RSpec.describe Lokalise::Client do
     expect(translation.translation_id).to eq(translation_id)
     expect(translation.key_id).to eq(15_571_975)
     expect(translation.language_iso).to eq('en')
-    expect(translation.modified_at).to eq('2018-12-10 19:04:08 (Etc/UTC)')
+    expect(translation.modified_at).to eq('2019-03-26 16:41:31 (Etc/UTC)')
+    expect(translation.modified_at_timestamp).to eq(1_553_618_491)
     expect(translation.modified_by).to eq(20_181)
     expect(translation.modified_by_email).to eq('bodrovis@protonmail.com')
-    expect(translation.translation).to eq('rspec trans')
+    expect(translation.translation).to eq('RSpec is a testing suite')
     expect(translation.is_fuzzy).to eq(false)
-    expect(translation.is_reviewed).to eq(true)
-    expect(translation.words).to eq(2)
+    expect(translation.is_reviewed).to eq(false)
+    expect(translation.words).to eq(5)
   end
 
   specify '#update_translation' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lokalise-api
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Ilya Bodrov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-19 00:00:00.000000000 Z
+date: 2019-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -108,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.60'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement