ruby-livr 2.0.0 → 2.1.0

data/spec/06-primitive_values_spec.rb

@@ -0,0 +1,133 @@
+require 'spec_helper.rb'
+
+RSpec.describe "primitive values" do
+
+  it "iso_date: numbers and booleans are wrong dates" do
+    validator = LIVR::Validator.new(
+      "date1" => "iso_date",
+      "date2" => "iso_date",
+      "date3" => "iso_date"
+    )
+
+    output = validator.validate("date1" => 20200101, "date2" => 1.5, "date3" => true)
+
+    expect(output).to eq(false)
+    expect(validator.get_errors).to eq(
+      "date1" => "WRONG_DATE",
+      "date2" => "WRONG_DATE",
+      "date3" => "WRONG_DATE"
+    )
+  end
+
+  it "iso_date: only YYYY-MM-DD strings are dates" do
+    validator = LIVR::Validator.new(
+      "date1" => "iso_date",
+      "date2" => "iso_date",
+      "date3" => "iso_date",
+      "date4" => "iso_date"
+    )
+
+    output = validator.validate("date1" => "2020-01-1x", "date2" => "+020-01-01", "date3" => "2020-1-1-1", "date4" => "2020-01-01")
+
+    expect(output).to eq(false)
+    expect(validator.get_errors).to eq(
+      "date1" => "WRONG_DATE",
+      "date2" => "WRONG_DATE",
+      "date3" => "WRONG_DATE"
+    )
+  end
+
+  it "integer, positive_integer: strings are decimal numbers" do
+    validator = LIVR::Validator.new(
+      "int1" => "integer",
+      "int2" => "positive_integer",
+      "int3" => "positive_integer"
+    )
+
+    output = validator.validate("int1" => "010", "int2" => "09", "int3" => "0x10")
+
+    expect(output).to eq(false)
+    expect(validator.get_errors).to eq("int3" => "NOT_POSITIVE_INTEGER")
+
+    expect(validator.validate("int1" => "010", "int2" => "09")).to eq("int1" => 10, "int2" => 9)
+  end
+
+  it "numeric rules: underscores are not digits" do
+    validator = LIVR::Validator.new(
+      "number1" => "integer",
+      "number2" => "positive_integer",
+      "number3" => { "min_number" => 1 },
+      "number4" => { "number_between" => [1, 2000] }
+    )
+
+    output = validator.validate("number1" => "1_000", "number2" => "1_000", "number3" => "1_000", "number4" => "1_000.5")
+
+    expect(output).to eq(false)
+    expect(validator.get_errors).to eq(
+      "number1" => "NOT_INTEGER",
+      "number2" => "NOT_POSITIVE_INTEGER",
+      "number3" => "NOT_NUMBER",
+      "number4" => "NOT_NUMBER"
+    )
+  end
+
+  it "min_number, max_number, number_between: integers stay integers" do
+    validator = LIVR::Validator.new(
+      "number1" => { "min_number" => 18 },
+      "number2" => { "max_number" => 100 },
+      "number3" => { "number_between" => [1, 100] },
+      "number4" => { "number_between" => [1, 100] }
+    )
+
+    output = validator.validate("number1" => 32, "number2" => "33", "number3" => "35", "number4" => "1.5")
+
+    expect(output.values.map(&:class)).to eq([Integer, Integer, Integer, Float])
+    expect(output).to eq("number1" => 32, "number2" => 33, "number3" => 35, "number4" => 1.5)
+  end
+
+  it "modifiers return strings to the next rules" do
+    validator = LIVR::Validator.new(
+      "email" => [ "required", "trim", "email", "to_lc" ],
+      "code"  => [ "to_uc", { "one_of" => ["ABC"] } ],
+      "phone" => [ { "leave_only" => "0123456789" }, { "max_length" => 5 } ],
+      "name"  => [ { "remove" => "-" }, "string" ]
+    )
+
+    output = validator.validate(
+      "email" => " User@Example.com ",
+      "code"  => "abc",
+      "phone" => "12-34",
+      "name"  => "a-b"
+    )
+
+    expect(output).to eq("email" => "user@example.com", "code" => "ABC", "phone" => "1234", "name" => "ab")
+    expect(output.values.map(&:class).uniq).to eq([String])
+  end
+
+  it "modifiers pass lists through unchanged" do
+    validator = LIVR::Validator.new(
+      "list1" => "trim",
+      "list2" => "to_lc",
+      "list3" => "to_uc",
+      "list4" => { "remove" => "1" },
+      "list5" => { "leave_only" => "1" }
+    )
+
+    input = { "list1" => [" a "], "list2" => ["A"], "list3" => ["a"], "list4" => [1, 2], "list5" => [1, 2] }
+
+    expect(validator.validate(input)).to eq(input)
+  end
+
+  it "required: false, 0 and whitespace are values" do
+    validator = LIVR::Validator.new(
+      "field1" => "required",
+      "field2" => "required",
+      "field3" => "required"
+    )
+
+    output = validator.validate("field1" => false, "field2" => 0, "field3" => " ")
+
+    expect(output).to eq("field1" => false, "field2" => 0, "field3" => " ")
+  end
+
+end

data/spec/test_suite/aliases_negative/02-address/aliases.json

@@ -4,7 +4,7 @@
         "rules": { "nested_object":{
             "street": "required",
             "zip": ["required", "positive_integer"],
-            "city": {"one_of": ["Kiev", "Kharkiv"] }
+            "city": {"one_of": ["Kyiv", "Kharkiv"] }
         }}
     },
 
@@ -13,7 +13,7 @@
         "rules": { "nested_object":{
             "street": "required",
             "zip": ["required", "positive_integer"],
-            "city": {"one_of": ["Kiev", "Kharkiv"] }
+            "city": {"one_of": ["Kyiv", "Kharkiv"] }
         }},
         "error": "WRONG_ADDRESS"
     }

data/spec/test_suite/aliases_negative/02-address/input.json

@@ -2,12 +2,12 @@
     "address": {
         "street": "",
         "zip": -1232131,
-        "city": "Moscow"
+        "city": "Lviv"
     },
     "address_custom_error": {
         "street": "My street",
         "zip": "12312",
-        "city": "Moscow"
+        "city": "Lviv"
     },
     "extra_field": 12
 }

data/spec/test_suite/aliases_positive/01-adult_age/input.json

@@ -3,6 +3,7 @@
     "age2": 33,
     "age3": 35,
     "age4": 36,
+    "empty_age": "",
     "age1_custom_error": 37,
     "age2_custom_error": 38,
     "age3_custom_error": 100,

data/spec/test_suite/aliases_positive/01-adult_age/output.json

@@ -3,6 +3,7 @@
     "age2": 33,
     "age3": 35,
     "age4": 36,
+    "empty_age": "",
     "age1_custom_error": 37,
     "age2_custom_error": 38,
     "age3_custom_error": 100,

data/spec/test_suite/aliases_positive/01-adult_age/rules.json

@@ -3,6 +3,8 @@
     "age2": ["adult_age"],
     "age3": [ { "adult_age": [] } ],
     "age4": { "adult_age": [] },
+    "empty_age": "adult_age",
+    "missed_age": "adult_age",
     "age1_custom_error": "adult_age_with_custom_error",
     "age2_custom_error": ["adult_age_with_custom_error"],
     "age3_custom_error": [ { "adult_age_with_custom_error": [] } ],

data/spec/test_suite/aliases_positive/02-address/aliases.json

@@ -4,7 +4,7 @@
         "rules": { "nested_object":{
             "street": "required",
             "zip": ["required", "positive_integer"],
-            "city": {"one_of": ["Kiev", "Kharkiv"] }
+            "city": {"one_of": ["Kyiv", "Kharkiv"] }
         }}
     },
 
@@ -13,7 +13,7 @@
         "rules": { "nested_object":{
             "street": "required",
             "zip": ["required", "positive_integer"],
-            "city": {"one_of": ["Kiev", "Kharkiv"] }
+            "city": {"one_of": ["Kyiv", "Kharkiv"] }
         }},
         "error": "WRONG_ADDRESS"
     }

data/spec/test_suite/aliases_positive/02-address/input.json

@@ -2,7 +2,7 @@
     "address": {
         "street": "My street",
         "zip": 1232131,
-        "city": "Kiev"
+        "city": "Kyiv"
     },
     "address_custom_error": {
         "street": "My street",

data/spec/test_suite/aliases_positive/02-address/output.json

@@ -2,7 +2,7 @@
     "address": {
         "street": "My street",
         "zip": 1232131,
-        "city": "Kiev"
+        "city": "Kyiv"
     },
     "address_custom_error": {
         "street": "My street",

data/spec/test_suite/negative/01-required/errors.json

@@ -1,5 +1,8 @@
 {
     "first_name": "REQUIRED",
     "last_name": "REQUIRED",
-    "middle_name": "REQUIRED"
+    "middle_name": "REQUIRED",
+    "constructor": "REQUIRED",
+    "toString": "REQUIRED",
+    "hasOwnProperty": "REQUIRED"
 }

data/spec/test_suite/negative/01-required/input.json

@@ -2,6 +2,7 @@
     "first_name": "",
     "last_name": null,
     "age": "25",
+    "__proto__": { "middle_name": "Some" },
 
     "value_is_hash":        {"test": 1},
     "value_is_empty_hash":  {},

data/spec/test_suite/negative/01-required/rules.json

@@ -6,5 +6,9 @@
     "value_is_hash":        "required",
     "value_is_empty_hash":  "required",
     "value_is_array":       "required",
-    "value_is_empty_array": "required"
+    "value_is_empty_array": "required",
+
+    "constructor":    "required",
+    "toString":       "required",
+    "hasOwnProperty": "required"
 }

data/spec/test_suite/negative/03-one_of/errors.json

@@ -2,7 +2,9 @@
     "city1": "NOT_ALLOWED_VALUE",
     "city2": "NOT_ALLOWED_VALUE",
     "city3": "NOT_ALLOWED_VALUE",
+    "city4": "NOT_ALLOWED_VALUE",
     "number1": "NOT_ALLOWED_VALUE",
+    "number2": "NOT_ALLOWED_VALUE",
 
     "value_is_hash":        "FORMAT_ERROR",
     "value_is_empty_hash":  "FORMAT_ERROR",

data/spec/test_suite/negative/03-one_of/input.json

@@ -2,7 +2,9 @@
     "city1": "New York",
     "city2": "New York",
     "city3": "New York",
+    "city4": "New York",
     "number1": "1.0",
+    "number2": 40,
     "extra_city": "New York",
 
     "value_is_hash":        {"test": 1},

data/spec/test_suite/negative/03-one_of/rules.json

@@ -1,11 +1,13 @@
 {
-    "city1": { "one_of": [["Moscow", "Kiev" ]] },
-    "city2": [{ "one_of": [["Moscow", "Kiev" ]] }],
-    "city3": { "one_of": ["Moscow", "Kiev"] },
+    "city1": { "one_of": [["Lviv", "Kyiv" ]] },
+    "city2": [{ "one_of": [["Lviv", "Kyiv" ]] }],
+    "city3": { "one_of": ["Lviv", "Kyiv"] },
+    "city4": { "one_of": ["Kyiv", "Lviv", "Odesa", "Kharkiv"] },
     "number1": { "one_of": [1, "1.00", "1"] },
+    "number2": { "one_of": [[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39]] },
 
-    "value_is_hash":        { "one_of": [["Moscow", "Kiev" ]] },
-    "value_is_empty_hash":  { "one_of": [["Moscow", "Kiev" ]] },
-    "value_is_array":       { "one_of": [["Moscow", "Kiev" ]] },
-    "value_is_empty_array": { "one_of": [["Moscow", "Kiev" ]] }
+    "value_is_hash":        { "one_of": [["Lviv", "Kyiv" ]] },
+    "value_is_empty_hash":  { "one_of": [["Lviv", "Kyiv" ]] },
+    "value_is_array":       { "one_of": [["Lviv", "Kyiv" ]] },
+    "value_is_empty_array": { "one_of": [["Lviv", "Kyiv" ]] }
 }

data/spec/test_suite/negative/12-positive_decimal/errors.json

@@ -2,6 +2,7 @@
     "number1": "NOT_POSITIVE_DECIMAL",
     "number2": "NOT_POSITIVE_DECIMAL",
     "number3": "NOT_POSITIVE_DECIMAL",
+    "number4": "NOT_POSITIVE_DECIMAL",
 
     "value_is_string":      "NOT_POSITIVE_DECIMAL",
     "value_is_hash":        "FORMAT_ERROR",

data/spec/test_suite/negative/12-positive_decimal/input.json

@@ -2,6 +2,7 @@
     "number1": "10.10.10",
     "number2": "0",
     "number3": -1.12,
+    "number4": "0.0",
     "empty_field": "",
     "extra_field": "100",
 

data/spec/test_suite/negative/12-positive_decimal/rules.json

@@ -2,6 +2,7 @@
     "number1": "positive_decimal",
     "number2": ["positive_decimal"],
     "number3": [ { "positive_decimal": [] } ],
+    "number4": ["positive_decimal"],
     "empty_field": "positive_decimal",
 
     "value_is_string":      "positive_decimal",

data/spec/test_suite/negative/16-email/errors.json

@@ -4,6 +4,28 @@
     "email3": "WRONG_EMAIL",
     "email4": "WRONG_EMAIL",
     "email5": "WRONG_EMAIL",
+    "email6": "WRONG_EMAIL",
+    "email7": "WRONG_EMAIL",
+    "email8": "WRONG_EMAIL",
+    "email9": "WRONG_EMAIL",
+    "email10": "WRONG_EMAIL",
+    "email11": "WRONG_EMAIL",
+    "email12": "WRONG_EMAIL",
+    "email13": "WRONG_EMAIL",
+    "email14": "WRONG_EMAIL",
+    "email15": "WRONG_EMAIL",
+    "email16": "WRONG_EMAIL",
+    "email17": "WRONG_EMAIL",
+    "email18": "WRONG_EMAIL",
+    "email19": "WRONG_EMAIL",
+    "email20": "WRONG_EMAIL",
+    "email21": "WRONG_EMAIL",
+    "email22": "WRONG_EMAIL",
+    "email23": "WRONG_EMAIL",
+    "email24": "WRONG_EMAIL",
+    "email25": "WRONG_EMAIL",
+    "email26": "WRONG_EMAIL",
+    "email27": "WRONG_EMAIL",
 
     "value_is_hash":        "FORMAT_ERROR",
     "value_is_empty_hash":  "FORMAT_ERROR",

data/spec/test_suite/negative/16-email/input.json

@@ -4,6 +4,29 @@
     "email3": "test+test.t_e_s_t@ma_il.in.ua",
     "email4": "user name@gmail.com",
     "email5": "username@mail.c om",
+    "email6": "en ny@enny.devoffice.com",
+    "email7": "enny..tester@devoffice.com",
+    "email8": ".enny@enny.devoffice.com",
+    "email9": "enny.devoffice.com",
+    "email10": "test@test",
+    "email11": "tester@enny..devoffice.com",
+    "email12": "en(ny@enny.devoffice.com",
+    "email13": "en)ny@enny.devoffice.com",
+    "email14": "en[enny@devoffice.com",
+    "email15": "en]ny@devoffice.com",
+    "email16": "ho:rhe@tester.devoffice.com",
+    "email17": "enny;tester@devoffice.com",
+    "email18": "te,st@devoffice.com",
+    "email19": "test<er@devoffice.com",
+    "email20": "tes>ter@devoffice.com",
+    "email21": "tester@@devoffice.com",
+    "email22": "tester@tes ter.devoffice.com",
+    "email23": "@enny tm.devoffice.com",
+    "email24": "тестувальник@пошта.укр ",
+    "email25": "test@mail.com\n",
+    "email26": "te\nst@mail.com",
+    "email27": "test@ma\nil.com",
+
     "empty_field": "",
     "extra_field": "aaaa",
 

data/spec/test_suite/negative/16-email/rules.json

@@ -4,6 +4,29 @@
     "email3": [ { "email": [] } ],
     "email4": "email",
     "email5": "email",
+    "email6": "email",
+    "email7": "email",
+    "email8": "email",
+    "email9": "email",
+    "email10": "email",
+    "email11": "email",
+    "email12": "email",
+    "email13": "email",
+    "email14": "email",
+    "email15": "email",
+    "email16": "email",
+    "email17": "email",
+    "email18": "email",
+    "email19": "email",
+    "email20": "email",
+    "email21": "email",
+    "email22": "email",
+    "email23": "email",
+    "email24": "email",
+    "email25": "email",
+    "email26": "email",
+    "email27": "email",
+
     "empty_field": "email",
 
     "value_is_hash":        "email",

data/spec/test_suite/negative/17-equal_to_field/errors.json

@@ -2,6 +2,10 @@
     "field1": "FIELDS_NOT_EQUAL",
     "field2": "FIELDS_NOT_EQUAL",
     "field3": "FIELDS_NOT_EQUAL",
+    "same_number_exponent":     "FIELDS_NOT_EQUAL",
+    "same_number_leading_zero": "FIELDS_NOT_EQUAL",
+    "same_number_space":        "FIELDS_NOT_EQUAL",
+    "missing_other_field":      "FIELDS_NOT_EQUAL",
 
     "value_is_hash":        "FORMAT_ERROR",
     "value_is_empty_hash":  "FORMAT_ERROR",

data/spec/test_suite/negative/17-equal_to_field/input.json

@@ -4,6 +4,11 @@
     "field3": "some value",
     "empty_field":  "",
     "extra_field": "some value",
+    "number": "10",
+    "same_number_exponent":     "1e1",
+    "same_number_leading_zero": "010",
+    "same_number_space":        " 10",
+    "missing_other_field":      "some value",
 
     "value_is_hash":        {"test": 1},
     "value_is_empty_hash":  {},

data/spec/test_suite/negative/17-equal_to_field/rules.json

@@ -3,6 +3,10 @@
     "field2": { "equal_to_field": ["field1"] },
     "field3": { "equal_to_field": ["field1"] },
     "empty_field":  { "equal_to_field": "field2" },
+    "same_number_exponent":     { "equal_to_field": "number" },
+    "same_number_leading_zero": { "equal_to_field": "number" },
+    "same_number_space":        { "equal_to_field": "number" },
+    "missing_other_field":      { "equal_to_field": "missing_field" },
 
     "value_is_hash":        { "equal_to_field": "field2" },
     "value_is_empty_hash":  { "equal_to_field": "field2" },

data/spec/test_suite/negative/18-nested_object/input.json

@@ -1,6 +1,6 @@
 {
     "address": {
-        "country": "Russia",
+        "country": "Poland",
         "zip": "AAA",
         "street": "",
         "building": "-10"

data/spec/test_suite/negative/21-list_of_different_objects/errors.json

@@ -13,5 +13,10 @@
         },
         "FORMAT_ERROR",
         "FORMAT_ERROR"
-    ]
+    ],
+    "only_wrong_items": ["FORMAT_ERROR", "FORMAT_ERROR", "FORMAT_ERROR", "FORMAT_ERROR", "FORMAT_ERROR"],
+    "valid_and_wrong_items": [null, "FORMAT_ERROR"],
+    "null_item": ["FORMAT_ERROR"],
+    "selector_is_not_string": ["FORMAT_ERROR", "FORMAT_ERROR"],
+    "selector_is_builtin_property": ["FORMAT_ERROR", "FORMAT_ERROR", "FORMAT_ERROR", "FORMAT_ERROR"]
 }

data/spec/test_suite/negative/21-list_of_different_objects/input.json

@@ -22,5 +22,27 @@
         },
         "Some Wrong Data"
     ],
-    "users": "not an array"
+    "users": "not an array",
+    "only_wrong_items": [
+        "Some Wrong Data",
+        10,
+        {"product_type": "wrongtype"},
+        {"name": "No product type"},
+        ["material"]
+    ],
+    "valid_and_wrong_items": [
+        {"product_type": "service", "name": "Service"},
+        "Some Wrong Data"
+    ],
+    "null_item": [null],
+    "selector_is_not_string": [
+        {"product_type": ["material"], "material_id": 1},
+        {"product_type": {"material": 1}, "material_id": 1}
+    ],
+    "selector_is_builtin_property": [
+        {"product_type": "constructor"},
+        {"product_type": "toString"},
+        {"product_type": "hasOwnProperty"},
+        {"product_type": "__proto__"}
+    ]
 }

data/spec/test_suite/negative/21-list_of_different_objects/rules.json

@@ -13,5 +13,40 @@
                 "name": ["required", {"max_length": 10} ]
             }
         }
-    ]}]
+    ]}],
+
+    "only_wrong_items": { "list_of_different_objects": [
+        "product_type", {
+            "material": { "product_type": "required", "material_id": "positive_integer" },
+            "service": { "product_type": "required", "name": "required" }
+        }
+    ]},
+
+    "valid_and_wrong_items": { "list_of_different_objects": [
+        "product_type", {
+            "material": { "product_type": "required", "material_id": "positive_integer" },
+            "service": { "product_type": "required", "name": "required" }
+        }
+    ]},
+
+    "null_item": { "list_of_different_objects": [
+        "product_type", {
+            "material": { "product_type": "required", "material_id": "positive_integer" },
+            "service": { "product_type": "required", "name": "required" }
+        }
+    ]},
+
+    "selector_is_not_string": { "list_of_different_objects": [
+        "product_type", {
+            "material": { "product_type": "required", "material_id": "positive_integer" },
+            "service": { "product_type": "required", "name": "required" }
+        }
+    ]},
+
+    "selector_is_builtin_property": { "list_of_different_objects": [
+        "product_type", {
+            "material": { "product_type": "required", "material_id": "positive_integer" },
+            "service": { "product_type": "required", "name": "required" }
+        }
+    ]}
 }

data/spec/test_suite/negative/23-url/errors.json

@@ -2,6 +2,8 @@
     "url1": "WRONG_URL",
     "url2": "WRONG_URL",
     "url3": "WRONG_URL",
+    "url4": "WRONG_URL",
+    "url5": "WRONG_URL",
 
     "value_is_hash":        "FORMAT_ERROR",
     "value_is_empty_hash":  "FORMAT_ERROR",

data/spec/test_suite/negative/23-url/input.json

@@ -2,6 +2,8 @@
     "url1": "www.google.com",
     "url2": "ftp://facebook.com",
     "url3": "http://g_oogle.com",
+    "url4": "https://google.com\n",
+    "url5": "http://webbylab.com/?param_1=123\n",
     "empty_field": "",
     "extra_field": "aaaa",
 

data/spec/test_suite/negative/23-url/rules.json

@@ -2,6 +2,8 @@
     "url1": "url",
     "url2": { "url": [] },
     "url3": [ { "url": [] } ],
+    "url4": "url",
+    "url5": "url",
     "empty_field": "url",
 
     "value_is_hash":        "url",

data/spec/test_suite/negative/24-iso_date/errors.json

@@ -2,6 +2,12 @@
     "iso_date1": "WRONG_DATE",
     "iso_date2": "WRONG_DATE",
     "iso_date3": "WRONG_DATE",
+    "iso_date4": "WRONG_DATE",
+    "iso_date5": "WRONG_DATE",
+    "iso_date6": "WRONG_DATE",
+    "iso_date7": "WRONG_DATE",
+    "iso_date8": "WRONG_DATE",
+    "iso_date9": "WRONG_DATE",
     "like_iso_date": "WRONG_DATE",
 
     "value_is_hash":        "FORMAT_ERROR",

data/spec/test_suite/negative/24-iso_date/input.json

@@ -2,6 +2,12 @@
     "iso_date1": "2014-13-10",
     "iso_date2": "2011-02-29",
     "iso_date3": "2014-10-10T22:22",
+    "iso_date4": "1900-02-29",
+    "iso_date5": "2024-00-10",
+    "iso_date6": "2024-01-00",
+    "iso_date7": "2024-04-31",
+    "iso_date8": "2024-1-01",
+    "iso_date9": "2024-01-01\n",
     "like_iso_date":"aaaa-bb-cc",
     "empty_field": "",
     "extra_field": "aaaa",

data/spec/test_suite/negative/24-iso_date/rules.json

@@ -2,6 +2,12 @@
     "iso_date1": "iso_date",
     "iso_date2": { "iso_date": [] },
     "iso_date3": [ { "iso_date": [] } ],
+    "iso_date4": "iso_date",
+    "iso_date5": "iso_date",
+    "iso_date6": "iso_date",
+    "iso_date7": "iso_date",
+    "iso_date8": "iso_date",
+    "iso_date9": "iso_date",
     "like_iso_date": [ { "iso_date": [] } ],
     "empty_field": "iso_date",