ruby-lint 2.0.2 → 2.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 56bd721e0aca3a78130df4c345585657f7f01118
-  data.tar.gz: 3c9631f8a0740b18165f13bdc4bea569fd11fadd
+  metadata.gz: a5355b24009dac40be5b9313a612e968f2b71336
+  data.tar.gz: d1b276f90c9fadb73252b8f07f934764cca283f0
 SHA512:
-  metadata.gz: 6cb899c24380a7d86fe129f0b56a3893bf3de04a4b4319544c587974ac19a44294e979851c7b10522bb2ace0643dff0ecc23070ed03b60788f104eda7e7fb2df
-  data.tar.gz: c5b17aad2123653d3ec0be97f715d5986e9ee2b0ef09739c606fcee003af2cabb6f8174724207ecf0fc76bee9c3e347bec8bfb7e4c68a797336788ed43a61f14
+  metadata.gz: f12df86be5066b3d541656d5e14f52bd8ab89948653fd295d9f3ddc0280850c5042531594b6efe8b68cceb3c69004a28f166e8d985a6bf26727200335d69f1ae
+  data.tar.gz: 6ad9f338d114d2346a488192fea36d9360dad21204d8b990543eea99e5af55220f5e4d02d255ec58f64196e7994ec855dfffe4fd4bc8d16a5ebe0a508276e60f

data/README.md

@@ -83,32 +83,27 @@ the following output:
     test.rb: warning: line 12, column 1: unused local variable greeting
     test.rb: error: line 14, column 1: wrong number of arguments (expected 0 but got 1)
 
-## Integration
-
-* Vim using [Syntastic][syntastic]
-* Emacs using [Flycheck][flycheck]
-
-## ruby-lint versus Rubocop
+## ruby-lint versus RuboCop
 
 A question commonly asked is what purpose ruby-lint serves compared to other
-tools such as [Rubocop][rubocop]. After all, upon first sight the two tools
+tools such as [RuboCop][rubocop]. After all, upon first sight the two tools
 look pretty similar.
 
-The big difference between ruby-lint and Rubocop is that ruby-lint focuses
+The big difference between ruby-lint and RuboCop is that ruby-lint focuses
 primarily on technical problems such as the use of undefined methods/variables,
-unused variables/method arguments and more. Rubocop on the other hand focuses
+unused variables/method arguments and more. RuboCop on the other hand focuses
 mostly on style related issues based on a community driven Ruby style guide.
 This means that it will for example warn you about methods written using
 camelCase and method bodies that are considered to be too long.
 
-Personally I have little interest in adding style related analysis as Rubocop
+Personally I have little interest in adding style related analysis as RuboCop
 already does that and in my opinion does a far better job at it. I also simply
 think it's too boring to write analysis like this. Having said that, ruby-lint
 has some basic style related analysis (e.g. the use of `BEGIN`) but this mostly
 serves as a simple example on how to write analysis code.
 
 In the end it depends on what your needs are. If you have a team that's having
-trouble following a consistent coding style then Rubocop is probably the right
+trouble following a consistent coding style then RuboCop is probably the right
 tool for the job. On the other hand, if you're trying to debug a nasty bug then
 ruby-lint will most likely be more useful.
 
@@ -141,7 +136,5 @@ All source code in this repository is licensed under the MIT license unless
 specified otherwise. A copy of this license can be found in the file "LICENSE"
 in the root directory of this repository.
 
-[syntastic]: https://github.com/scrooloose/syntastic
-[flycheck]: https://github.com/flycheck/flycheck/
 [rubocop]: https://github.com/bbatsov/rubocop
 [yard]: http://yardoc.org/

data/checksum/ruby-lint-2.0.2.gem.sha512

@@ -0,0 +1 @@
+74d06cbed15bf1cbadd58a35a36e1984ba9081c68b9e0db9ed324197c05b9139e382ec26e667bfac1a5336ba31f91feb2a2f0fccef687df24f506fdc7331624d

data/doc/changelog.md

@@ -5,6 +5,18 @@ This document contains a short summary of the various releases of ruby-lint.
 For a full list of commits included in each release see the corresponding Git
 tags (named after the versions).
 
+## 2.0.3 - 2015-01-09
+
+* ruby-lint now adds errors for certain iteration/loop keywords that are used
+  outside of loops. See <http://git.io/dsVzhA> for more information.
+* The FileScanner was modified to allow it to process directories containing
+  dashes, see <http://git.io/eNiq9A> for more information.
+* Definitions for Mongoid, Sinatra, win32ole, glib2, gtk3, libxml, RubyTree, and
+  the ALM REST API were added.
+* Usage of `Array#|` has been replaced with `Array#+` in
+  `RubyObject#determine_parent`, leading to a small performance boost, see
+  <http://git.io/1SIguw> for more information.
+
 ## 2.0.2 - 2014-08-05
 
 * Definitions for Celluloid have been added.

data/lib/ruby-lint.rb

@@ -67,6 +67,7 @@ require_relative 'ruby-lint/analysis/undefined_methods'
 require_relative 'ruby-lint/analysis/argument_amount'
 require_relative 'ruby-lint/analysis/pedantics'
 require_relative 'ruby-lint/analysis/useless_equality_checks'
+require_relative 'ruby-lint/analysis/loop_keywords'
 
 require_relative 'ruby-lint/report'
 require_relative 'ruby-lint/report/entry'

data/lib/ruby-lint/analysis/loop_keywords.rb

@@ -0,0 +1,66 @@
+module RubyLint
+  module Analysis
+    ##
+    # Analysis class that checks if certain keywords are used inside a
+    # block/loop or not. For example, the following is not valid Ruby code:
+    #
+    #     next
+    #
+    # But the following is valid:
+    #
+    #     [10, 20].each do |n|
+    #       next
+    #     end
+    #
+    # The following isn't valid either:
+    #
+    #     def foo
+    #       next
+    #     end
+    #
+    # See {KEYWORDS} for a list of the keywords that can only be used inside a
+    # loop.
+    #
+    class LoopKeywords < Base
+      register 'loop_keywords'
+
+      ##
+      # List of keywords that can only be used inside a loop.
+      #
+      # @return [Array]
+      #
+      KEYWORDS = [:next, :break]
+
+      ##
+      # List of statements that do allow the use of the various keywords.
+      #
+      # @return [Array]
+      #
+      STATEMENTS = [:while, :until, :for]
+
+      KEYWORDS.each do |kw|
+        define_method("on_#{kw}") { |node| verify_keyword(kw, node) }
+      end
+
+      STATEMENTS.each do |statement|
+        define_method("on_#{statement}") do
+          @allow_keyword = true
+        end
+
+        define_method("after_#{statement}") do
+          @allow_keyword = false
+        end
+      end
+
+      ##
+      # @param [Symbol] keyword
+      # @param [RubyLint::AST::Node] node
+      #
+      def verify_keyword(keyword, node)
+        if current_scope.type != :block and !@allow_keyword
+          error("#{keyword} can only be used inside a loop/block", node)
+        end
+      end
+    end # BlockKeywords
+  end # Analysis
+end # RubyLint

data/lib/ruby-lint/analysis/pedantics.rb

@@ -1,9 +1,20 @@
 module RubyLint
   module Analysis
     ##
-    # The {RubyLint::Analysis::UselessRuby} class checks for various useless
-    # Ruby features, the use of redundant tokens such as `then` for `if`
-    # statements and various other pedantics.
+    # This class adds (pedantic) warnings for various features that aren't
+    # really that useful or needed. This serves mostly as a simple example on
+    # how to write an analysis class.
+    #
+    # Currently warnings are added for the following:
+    #
+    # * BEGIN/END blocks
+    # * Statements that use `then` or `do` when it's not needed
+    #
+    # For example:
+    #
+    #     BEGIN { puts 'foo' }
+    #
+    # This would result in the warning "BEGIN/END is useless" being added.
     #
     class Pedantics < Base
       register 'pedantics'

data/lib/ruby-lint/definition/ruby_object.rb

@@ -697,7 +697,9 @@ module RubyLint
         if parent.type == type and parent.name == name
           parent_definition = parent
         else
-          parent_definition = parent.lookup(type, name, true, exclude | [self])
+          exclude = exclude + [self] unless exclude.include?(self)
+
+          parent_definition = parent.lookup(type, name, true, exclude)
         end
 
         return parent_definition

data/lib/ruby-lint/definitions/core/win32ole.rb

@@ -0,0 +1,312 @@
+# This file was automatically generated, any manual changes will be lost the
+# next time this file is generated.
+#
+# Platform: ruby 1.9.3
+
+RubyLint.registry.register('WIN32OLE') do |defs|
+  defs.define_constant('WIN32OLE') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+    klass.define_method('codepage')
+
+    klass.define_method('codepage=') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_method('connect') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_method('const_load') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_method('create_guid')
+
+    klass.define_method('locale')
+
+    klass.define_method('locale=') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_method('ole_free') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_method('ole_initialize')
+
+    klass.define_method('ole_reference_count') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_method('ole_show_help') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_method('ole_uninitialize')
+
+    klass.define_instance_method('[]') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_instance_method('[]=') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_instance_method('_getproperty') do |method|
+      method.define_argument('arg1')
+      method.define_argument('arg2')
+      method.define_argument('arg3')
+    end
+
+    klass.define_instance_method('_invoke') do |method|
+      method.define_argument('arg1')
+      method.define_argument('arg2')
+      method.define_argument('arg3')
+    end
+
+    klass.define_instance_method('_setproperty') do |method|
+      method.define_argument('arg1')
+      method.define_argument('arg2')
+      method.define_argument('arg3')
+    end
+
+    klass.define_instance_method('each')
+
+    klass.define_instance_method('invoke') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_instance_method('method_missing') do |method|
+      method.define_rest_argument('arg1')
+    end
+
+    klass.define_instance_method('ole_activex_initialize')
+
+    klass.define_instance_method('ole_free')
+
+    klass.define_instance_method('ole_func_methods')
+
+    klass.define_instance_method('ole_get_methods')
+
+    klass.define_instance_method('ole_method') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_instance_method('ole_method_help') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_instance_method('ole_methods')
+
+    klass.define_instance_method('ole_obj_help')
+
+    klass.define_instance_method('ole_put_methods')
+
+    klass.define_instance_method('ole_query_interface') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_instance_method('ole_respond_to?') do |method|
+      method.define_argument('arg1')
+    end
+
+    klass.define_instance_method('ole_type')
+
+    klass.define_instance_method('ole_typelib')
+
+    klass.define_instance_method('setproperty') do |method|
+      method.define_rest_argument('arg1')
+    end
+  end
+
+  defs.define_constant('WIN32OLE::ARGV') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_ACP') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_MACCP') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_OEMCP') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_SYMBOL') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_THREAD_ACP') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_UTF7') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::CP_UTF8') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::LOCALE_SYSTEM_DEFAULT') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::LOCALE_USER_DEFAULT') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_ARRAY') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_BOOL') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_BSTR') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_BYREF') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_CY') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_DATE') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_DISPATCH') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_EMPTY') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_ERROR') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_I1') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_I2') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_I4') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_I8') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_INT') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_NULL') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_PTR') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_R4') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_R8') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_UI1') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_UI2') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_UI4') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_UI8') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_UINT') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_UNKNOWN') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_USERDEFINED') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VARIANT::VT_VARIANT') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+
+  defs.define_constant('WIN32OLE::VERSION') do |klass|
+    klass.inherits(defs.constant_proxy('Object', RubyLint.registry))
+
+  end
+end