ruby-lint 1.0.3 → 1.1.0

data/gen/rails/constants.txt

@@ -0,0 +1,12 @@
+AbstractController
+ActionController
+ActionDispatch
+ActionMailer
+ActionPack
+ActionView
+ActiveModel
+ActiveRecord
+ActiveSupport
+Arel
+Rails
+Sprockets

data/gen/rails/requires.rb

@@ -0,0 +1,2 @@
+require 'mail'
+require 'rails/all'

data/gen/stdlib/constants.rb

@@ -0,0 +1,30 @@
+# Loads all stdlib files and writes a list of constants to a text file. This is
+# run outside of Rake to ensure a clean environment not polluted by Rake and
+# other loaded dependencies.
+
+require_relative 'requires'
+
+# These are maintained manually.
+ignore = DATA.read.split("\n")
+consts = Object.constants.map(&:to_s) - ignore
+
+File.open(File.expand_path('../constants.txt', __FILE__), 'w') do |handle|
+  handle.write(consts.sort.join("\n"))
+end
+
+__END__
+ARGV
+BasicObject
+Class
+ENV
+Kernel
+Module
+RSS
+Rubinius
+RubyLex
+RubySL
+RubyToken
+Rubysl
+STDERR
+STDIN
+STDOUT

data/gen/stdlib/constants.txt

@@ -0,0 +1,214 @@
+ARGF
+Abbrev
+Addrinfo
+ArgumentError
+Array
+Base64
+BasicSocket
+Benchmark
+Bignum
+Binding
+CGI
+CLEANINGS
+CMath
+COMMON_HEADERS
+COMMON_LIBS
+COMPILE_C
+COMPILE_CXX
+COMPILE_RULES
+CONFIG
+CONFTEST
+CONFTEST_C
+COUTFLAG
+CPPOUTFILE
+CROSS_COMPILING
+CSV
+CXX_EXT
+C_EXT
+Comparable
+Complex
+ConditionVariable
+Config
+DATA
+DRb
+DRbIdConv
+DRbObject
+DRbUndumped
+Data
+Date
+DateTime
+Delegator
+Digest
+Dir
+EOFError
+ERB
+EXPORT_PREFIX
+Encoding
+EncodingError
+Enumerable
+Enumerator
+Errno
+Etc
+Exception
+Exception2MessageMapper
+ExceptionForMatrix
+FALSE
+FailedMessage
+FalseClass
+Fcntl
+Fiber
+FiberError
+File
+FileTest
+FileUtils
+Find
+Fixnum
+Float
+FloatDomainError
+Forwardable
+GC
+GServer
+Gem
+GetoptLong
+HDR_EXT
+Hash
+INSTALL_DIRS
+IO
+IOError
+IPAddr
+IPSocket
+IRB
+IndexError
+Integer
+Interrupt
+JSON
+Kconv
+KeyError
+LIBARG
+LIBPATHFLAG
+LINK_SO
+LoadError
+LocalJumpError
+Logger
+Logging
+MAIN_DOES_NOTHING
+MakeMakefile
+Marshal
+MatchData
+Math
+Matrix
+Method
+Monitor
+MonitorMixin
+Mutex
+Mutex_m
+NIL
+NKF
+NameError
+NilClass
+NoMemoryError
+NoMethodError
+NotImplementedError
+Numeric
+ORIG_LIBPATH
+OUTFLAG
+Object
+ObjectSpace
+Observable
+Open3
+OpenSSL
+OpenStruct
+OpenURI
+OptionParser
+PP
+PStore
+Pathname
+PrettyPrint
+Prime
+Proc
+Process
+Profiler__
+Psych
+Queue
+RPATHFLAG
+RUBYGEMS_ACTIVATION_MONITOR
+RUBY_COPYRIGHT
+RUBY_DESCRIPTION
+RUBY_ENGINE
+RUBY_PATCHLEVEL
+RUBY_PLATFORM
+RUBY_RELEASE_DATE
+RUBY_REVISION
+RUBY_VERSION
+RULE_SUBST
+Random
+Range
+RangeError
+Rational
+RbConfig
+Readline
+Regexp
+RegexpError
+Resolv
+RubyVM
+RuntimeError
+SRC_EXT
+STRING_OR_FAILED_FORMAT
+ScanError
+Scanf
+ScriptError
+SecureRandom
+SecurityError
+Set
+Shellwords
+Signal
+SignalException
+SimpleDelegator
+SingleForwardable
+Singleton
+SizedQueue
+Socket
+SocketError
+SortedSet
+StandardError
+StopIteration
+String
+StringIO
+StringScanner
+Struct
+Symbol
+SyntaxError
+SystemCallError
+SystemExit
+SystemStackError
+TCPServer
+TCPSocket
+TOPLEVEL_BINDING
+TRUE
+TRY_LINK
+TSort
+Tempfile
+ThWait
+Thread
+ThreadError
+ThreadGroup
+ThreadsWait
+Time
+Timeout
+TimeoutError
+TracePoint
+TrueClass
+TypeError
+UDPSocket
+UNIVERSAL_INTS
+UNIXServer
+UNIXSocket
+URI
+UnboundMethod
+Vector
+WEBrick
+WeakRef
+XMLRPC
+YAML
+ZeroDivisionError
+Zlib

data/gen/stdlib/requires.rb

@@ -0,0 +1,64 @@
+require 'abbrev'
+require 'base64'
+require 'benchmark'
+require 'cgi'
+require 'cmath'
+require 'complex'
+require 'csv'
+require 'date'
+require 'delegate'
+require 'digest'
+require 'drb'
+require 'e2mmap'
+require 'English'
+require 'erb'
+require 'expect'
+require 'fileutils'
+require 'find'
+require 'forwardable'
+require 'getoptlong'
+require 'gserver'
+require 'ipaddr'
+require 'irb'
+require 'json'
+require 'kconv'
+require 'logger'
+require 'mathn'
+require 'matrix'
+require 'mkmf'
+require 'monitor'
+require 'mutex_m'
+require 'observer'
+require 'open3'
+require 'openssl'
+require 'open-uri'
+require 'optparse'
+require 'ostruct'
+require 'pathname'
+require 'pp'
+require 'prettyprint'
+require 'prime'
+require 'profiler'
+require 'pstore'
+require 'rational'
+require 'resolv'
+require 'scanf'
+require 'securerandom'
+require 'set'
+require 'shellwords'
+require 'singleton'
+require 'socket'
+require 'stringio'
+require 'tempfile'
+require 'thread'
+require 'thwait'
+require 'timeout'
+require 'time'
+require 'tmpdir'
+require 'tsort'
+require 'uri'
+require 'weakref'
+require 'webrick'
+require 'xmlrpc'
+require 'yaml'
+require 'zlib'

data/lib/ruby-lint.rb

@@ -1,17 +1,7 @@
-gem 'parser', '~> 2.0'
+gem 'parser', ['~> 2.1', '>= 2.1.1']
 
 require 'parser'
-
-# Try to load the latest parser and fall back to 2.0. This should only occur on
-# Ruby versions >= 2.1 (e.g. Rubinius HEAD).
-begin
-  require 'parser/current'
-rescue NotImplementedError => error
-  warn "Falling back to Ruby 2.0: #{error.message}"
-
-  require 'parser/ruby20'
-  Parser::CurrentRuby = Parser::Ruby20
-end
+require 'parser/current'
 
 require 'yaml'
 require 'set'
@@ -20,11 +10,13 @@ require 'zlib'
 
 require_relative 'ruby-lint/extensions/string'
 
+require_relative 'ruby-lint/ruby_lint'
 require_relative 'ruby-lint/variable_predicates'
 require_relative 'ruby-lint/ast/node'
 require_relative 'ruby-lint/ast/builder'
 require_relative 'ruby-lint/parser'
 require_relative 'ruby-lint/file_scanner'
+require_relative 'ruby-lint/file_list'
 require_relative 'ruby-lint/nested_stack'
 require_relative 'ruby-lint/docstring/parser'
 require_relative 'ruby-lint/docstring/param_tag'
@@ -36,6 +28,7 @@ require_relative 'ruby-lint/cache'
 require_relative 'ruby-lint/cache_entry'
 
 require_relative 'ruby-lint/constant_path'
+require_relative 'ruby-lint/inspector'
 
 require_relative 'ruby-lint/definition_builder/base'
 require_relative 'ruby-lint/definition_builder/ruby_module'
@@ -54,17 +47,16 @@ require_relative 'ruby-lint/method_call/attribute'
 require_relative 'ruby-lint/method_call/define_method'
 
 require_relative 'ruby-lint/iterator'
-require_relative 'ruby-lint/global_scope'
 require_relative 'ruby-lint/virtual_machine'
 require_relative 'ruby-lint/constant_loader'
 require_relative 'ruby-lint/file_loader'
 require_relative 'ruby-lint/method_call_info'
 
+require_relative 'ruby-lint/definition/registry'
 require_relative 'ruby-lint/definition/ruby_object'
 require_relative 'ruby-lint/definition/ruby_method'
 require_relative 'ruby-lint/definition/constant_proxy'
 require_relative 'ruby-lint/definitions/core'
-require_relative 'ruby-lint/definitions/global_variables'
 
 require_relative 'ruby-lint/analysis/base'
 require_relative 'ruby-lint/analysis/unused_variables'
@@ -73,6 +65,7 @@ require_relative 'ruby-lint/analysis/undefined_variables'
 require_relative 'ruby-lint/analysis/undefined_methods'
 require_relative 'ruby-lint/analysis/argument_amount'
 require_relative 'ruby-lint/analysis/pedantics'
+require_relative 'ruby-lint/analysis/useless_equality_checks'
 
 require_relative 'ruby-lint/report'
 require_relative 'ruby-lint/report/entry'

data/lib/ruby-lint/analysis/undefined_methods.rb

@@ -43,7 +43,8 @@ module RubyLint
       # @param [String] name
       #
       def has_definition?(scope, name)
-        exists = scope.has_definition?(scope.method_call_type, name)
+        type   = scope.method_call_type
+        exists = scope.has_definition?(type, name)
 
         # Due to the way `parser` wraps block nodes (`(block (send) ...)`
         # opposed to `(send ... (block))`) we'll try to find the method in the
@@ -53,6 +54,12 @@ module RubyLint
           exists = prev.has_definition?(prev.method_call_type, name)
         end
 
+        # If method_missing is defined we'll assume the method calls are
+        # handled gracefully and not add any errors for them.
+        if !exists and scope.has_definition?(type, 'method_missing')
+          exists = true
+        end
+
         return exists
       end
 

data/lib/ruby-lint/analysis/useless_equality_checks.rb

@@ -0,0 +1,92 @@
+module RubyLint
+  module Analysis
+    ##
+    # Analysis class that checks for equality checks and adds warnings when
+    # these always evaluate to false. An example of such a check is
+    # `:hello == 'hello'`.
+    #
+    # This analysis class was added after a co-worker banged their head against
+    # a wall after finding the following code:
+    #
+    #     if some_value.to_sym == "overall"
+    #       # ...
+    #     end
+    #
+    # This code would never evaluate to true. In the particular case this would
+    # result in it never caching certain data.
+    #
+    class UselessEqualityChecks < Base
+      ##
+      # @param [RubyLint::AST::Node] node
+      #
+      def on_send(node)
+        receiver, name, arg = *node
+
+        return unless name == :==
+
+        left_type  = node_type(receiver)
+        right_type = node_type(arg)
+
+        if skip_type?(left_type) or skip_type?(right_type)
+          return
+        end
+
+        if left_type != right_type
+          warning(
+            "Comparing #{left_type} with #{right_type} evaluates to false",
+            node
+          )
+        end
+      end
+
+      ##
+      # Returns the type name for a given AST node.
+      #
+      # @param [RubyLint::AST::Node] node
+      # @return [String]
+      #
+      def node_type(node)
+        definition = vm.associations[node]
+        type       = nil
+
+        if definition
+          type = definition_type(definition)
+        end
+
+        return type
+      end
+
+      ##
+      # Returns the type name of the given definition.
+      #
+      # @param [RubyLint::Definition::RubyObject] object
+      # @return [String]
+      #
+      def definition_type(object)
+        name = nil
+
+        # Built-in types such as Array.
+        if object.ruby_class
+          name = object.ruby_class
+
+        # Variables
+        elsif object.variable? and object.value
+          name = definition_type(object.value)
+
+        # Constants.
+        elsif object.constant? and !object.name.empty?
+          name = object.name
+        end
+
+        return name
+      end
+
+      ##
+      # @param [String] type
+      #
+      def skip_type?(type)
+        return !type || type == 'unknown'
+      end
+    end # UselessEqualityChecks
+  end # Analysis
+end # RubyLint