ruby-lint 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5e5bbee286e1be1ba6f024458ccf916d7aaa6f6d
-  data.tar.gz: 62be929b8a02f3e9fc701d3a9d5cc979d69614d1
+  metadata.gz: 26f5ebcb21cde063e50e4f8cc406f06632d686dd
+  data.tar.gz: b2496b982aae763c97b28b96570338e71f4b1ddc
 SHA512:
-  metadata.gz: 45574e47f9dcb4017f64f80fd89bc8d7b10bffdbb4648ed3cc42b09373e04e3dd413a3ed4e68e84736082a1c377f0d6ce61b6b8729ef848bb26f0f4b4ce5574e
-  data.tar.gz: ab7b40f9108af2d2d6879ccfddf806cff09f413f9fd6adc4d499d874934a266be36d6884eb9629761c8dbc86d14559171cc8ef3863e6a3faffedc4f94e2a2494
+  metadata.gz: 15371f1e7dc8130470e8ef9a5ea60e178cbddd60d10394ba6f77f40de77e2c053be9ab3e4864fe5feba714e0a6765a12d30bcacf88cbd2b81edf5ec27f2e2785
+  data.tar.gz: e257a03edb2834d66484d9969c4bcfd31c2ff12bd4e63da105bd217643d9c26182b78a1d17d37314f9ce2435821072af2f0c2a8ee1950a34bf72da1017cc7010

data/MANIFEST

@@ -20,6 +20,7 @@ checksum/ruby-lint-0.9.0.gem.sha512
 checksum/ruby-lint-0.9.1.gem.sha512
 checksum/ruby-lint-1.0.0.gem.sha512
 checksum/ruby-lint-1.0.0.pre.preview1.gem.sha512
+checksum/ruby-lint-1.0.1.gem.sha512
 doc/.gitkeep
 doc/DCO.md
 doc/architecture.md

data/checksum/ruby-lint-1.0.1.gem.sha512

@@ -0,0 +1 @@
+67b8deac49560700db3388a20cfff941fb852b70b6760a66bb8d5fc67b718623d88668eef9322484eeb88fd8609d91ab7c42fb30259c53c381f33b609a566187

data/doc/changelog.md

@@ -5,6 +5,13 @@ This document contains a short summary of the various releases of ruby-lint.
 For a full list of commits included in each release see the corresponding Git
 tags (named after the versions).
 
+## 1.0.2 - 2013-12-19
+
+This release changes the default file scanner directories from `$PWD` to
+`$PWD/app` and `$PWD/lib` as the former proved to be too much trouble. This
+release also changes the pre-globbing of the file scanner so that it only
+starts looking for files when actually needed.
+
 ## 1.0.1 - 2013-12-15
 
 A small bugfix release that contains the following changes/fixes:

data/doc/configuration.md

@@ -115,9 +115,9 @@ Example:
 
 ### directories
 
-A list of directories to search in for externally defined constants. By
-default this is set to the current working directory which, for big projects,
-can slow things down.
+A list of directories to search in for externally defined constants. By default
+this is set to `$PWD/app` and `$PWD/lib` (depending on which directories
+exist). For most applications you do not need to change this value.
 
 Example:
 

data/lib/ruby-lint/configuration.rb

@@ -237,7 +237,7 @@ module RubyLint
     # @return [Array]
     #
     def default_directories
-      return [Dir.pwd]
+      return FileScanner.default_directories
     end
 
     ##

data/lib/ruby-lint/file_scanner.rb

@@ -12,11 +12,34 @@ module RubyLint
   class FileScanner
     attr_reader :directories, :ignore
 
+    ##
+    # Array containing names of directories that (often) contain Ruby source
+    # files.
+    #
+    # @return [Array]
+    #
+    RUBY_DIRECTORIES = %w{app lib}
+
+    ##
+    # @return [Array]
+    #
+    def self.default_directories
+      directories = []
+
+      RUBY_DIRECTORIES.each do |dir|
+        path = File.join(Dir.pwd, dir)
+
+        directories << path if File.directory?(path)
+      end
+
+      return directories
+    end
+
     ##
     # @param [Array] directories A collection of base directories to search in.
     # @param [Array] ignore A list of paths to ignore.
     #
-    def initialize(directories = [Dir.pwd], ignore = [])
+    def initialize(directories = self.class.default_directories, ignore = [])
       unless directories.respond_to?(:each)
         raise TypeError, 'Directories must be specified as an Enumerable'
       end
@@ -26,10 +49,6 @@ module RubyLint
 
       # Hash that will contain the matching file paths for a given constant.
       @constant_paths_cache = {}
-
-      # Globbing all files at once and then comparing those results is faster
-      # than running a Dir.glob for every call to #scan.
-      @glob_cache = Dir.glob("#{directories.join(',')}/**/*.rb")
     end
 
     ##
@@ -41,6 +60,10 @@ module RubyLint
     # @return [Array]
     #
     def scan(constant)
+      # Globbing all files at once and then comparing those results is faster
+      # than running a Dir.glob for every call to #scan.
+      @glob_cache ||= Dir.glob("#{directories.join(',')}/**/*.rb")
+
       unless constant_paths_cached?(constant)
         build_constant_paths_cache(constant)
       end

data/lib/ruby-lint/version.rb

@@ -1,3 +1,3 @@
 module RubyLint
-  VERSION = '1.0.1'
+  VERSION = '1.0.2'
 end # RubyLint

data/spec/ruby-lint/file_scanner_spec.rb

@@ -10,6 +10,19 @@ describe RubyLint::FileScanner do
     lambda { RubyLint::FileScanner.new(10) }.should raise_error(TypeError)
   end
 
+  example 'set the default directories' do
+    scanner = RubyLint::FileScanner.new
+
+    scanner.directories.empty?.should == false
+  end
+
+  example 'do not include non existing directories' do
+    app     = File.join(Dir.pwd, 'app')
+    scanner = RubyLint::FileScanner.new
+
+    scanner.directories.include?(app).should == false
+  end
+
   example 'finding a class' do
     scanner = RubyLint::FileScanner.new([@lib_dir])
     paths   = scanner.scan('Example::User')

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lint
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Yorick Peterse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-15 00:00:00.000000000 Z
+date: 2013-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -213,6 +213,7 @@ files:
 - checksum/ruby-lint-0.9.1.gem.sha512
 - checksum/ruby-lint-1.0.0.gem.sha512
 - checksum/ruby-lint-1.0.0.pre.preview1.gem.sha512
+- checksum/ruby-lint-1.0.1.gem.sha512
 - doc/.gitkeep
 - doc/DCO.md
 - doc/architecture.md