ruby-lint 0.9.1 → 1.0.0.pre.preview1

data/spec/ruby-lint/cli/analyze_spec.rb

@@ -38,5 +38,15 @@ describe RubyLint::CLI do
       output.should =~ /Execution time:/
       output.should =~ /Memory usage:/
     end
+
+    example 'run analysis on an entire directory' do
+      @command.parse([fixture_path('deeply')])
+
+      @output.rewind
+
+      output = @output.read
+
+      output.should =~ /undefined method foobar/
+    end
   end
 end

data/spec/ruby-lint/constant_path.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe RubyLint::ConstantPath do
+  context 'resolving definitions' do
+    before :all do
+      @scope = ruby_object.new(:type => :const, :name => 'Example')
+      @foo   = @scope.define_constant('Foo')
+      @bar   = @foo.define_constant('Bar')
+
+      lvar = ruby_object.new(
+        :type  => :lvar,
+        :name  => 'example',
+        :value => @foo
+      )
+
+      @scope.add_definition(lvar)
+    end
+
+    example 'resolve a path of purely constants' do
+      node = s(:const, s(:const, nil, :Foo), :Bar)
+      defs = RubyLint::ConstantPath.new(node).resolve(@scope)
+
+      defs.is_a?(ruby_object).should == true
+
+      defs.name.should == 'Bar'
+      defs.type.should == :const
+    end
+
+    example 'resolve a path containing a variable' do
+      node = s(:const, s(:lvar, :example), :Bar)
+      defs = RubyLint::ConstantPath.new(node).resolve(@scope)
+
+      defs.is_a?(ruby_object).should == true
+
+      defs.name.should == 'Bar'
+      defs.type.should == :const
+    end
+
+    example 'resolve a path for a constant assignment' do
+      node = s(:casgn, s(:const, nil, :Foo), :Bar, s(:int, 10))
+      defs = RubyLint::ConstantPath.new(node).resolve(@scope)
+
+      defs.is_a?(ruby_object).should == true
+
+      defs.name.should == 'Bar'
+      defs.type.should == :const
+    end
+  end
+
+  example 'return the root node of a constant path' do
+    node = s(:const, s(:const, nil, :Foo), :Bar)
+    root = RubyLint::ConstantPath.new(node).root_node
+
+    root.should == [:const, 'Foo']
+  end
+
+  example 'generate the name of a constant path' do
+    node = s(:const, s(:const, nil, :Foo), :Bar)
+    name = RubyLint::ConstantPath.new(node).to_s
+
+    name.should == 'Foo::Bar'
+  end
+end

data/spec/ruby-lint/definition/ruby_object_spec.rb

@@ -196,10 +196,10 @@ describe ruby_object do
   end
 
   example 'storing location information in a definition' do
-    obj = ruby_object.new(:line => 10, :column => 2, :file => '(ruby-lint)')
+    obj = ruby_object.new(:line => 10, :column => 3, :file => '(ruby-lint)')
 
     obj.line.should   == 10
-    obj.column.should == 2
+    obj.column.should == 3
     obj.file.should   == '(ruby-lint)'
   end
 

data/spec/ruby-lint/report_spec.rb

@@ -8,7 +8,7 @@ describe 'RubyLint::Report' do
       :level   => :info,
       :message => 'info message',
       :line    => 1,
-      :column  => 1,
+      :column  => 2,
       :file    => 'file.rb'
     )
 
@@ -19,7 +19,7 @@ describe 'RubyLint::Report' do
     entry.level.should   == :info
     entry.message.should == 'info message'
     entry.line.should    == 1
-    entry.column.should  == 1
+    entry.column.should  == 2
     entry.file.should    == 'file.rb'
   end
 

data/spec/ruby-lint/runner_spec.rb

@@ -54,4 +54,21 @@ describe RubyLint::Runner do
 
     output.empty?.should == true
   end
+
+  example 'conditionally disable analysis classes' do
+    # This analysis class triggers the "undefined method foobar..." error.
+    RubyLint::Analysis::UndefinedMethods.stub(:analyze?) do |ast, vm|
+      # This ensures that the passed arguments are passed in the right order
+      # and of the right type.
+      !(ast.is_a?(RubyLint::AST::Node) && vm.is_a?(RubyLint::VirtualMachine))
+    end
+
+    files  = [fixture_path('uses_external_invalid.rb')]
+    dirs   = [fixture_path('file_scanner/rails')]
+    config = RubyLint::Configuration.new(:directories => dirs)
+    runner = RubyLint::Runner.new(config)
+    output = runner.analyze(files)
+
+    output.empty?.should == true
+  end
 end

data/spec/ruby-lint/virtual_machine/assignments/assignment_arguments_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe RubyLint::VirtualMachine do
+  context 'variable assignments as method arguments' do
+    example 'assign a local variable in a method argument' do
+      code  = 'puts(number = 10)'
+      defs  = build_definitions(code)
+      value = defs.lookup(:lvar, 'number').value
+
+      value.type.should  == :int
+      value.value.should == 10
+    end
+  end
+end

data/spec/ruby-lint/virtual_machine/assignments/constants_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe RubyLint::VirtualMachine do
+  context 'constants and local variables' do
+    # https://github.com/YorickPeterse/ruby-lint/issues/60
+    example 'access a constant path using a local variable' do
+      code = <<-CODE
+module Example
+  NUMBER = 10
+end
+
+const  = Example
+string = const::NUMBER
+      CODE
+
+      defs  = build_definitions(code)
+      value = defs.lookup(:lvar, 'string').value
+
+      value.type.should  == :int
+      value.value.should == 10
+    end
+  end
+end

data/spec/ruby-lint/virtual_machine/location_spec.rb

@@ -13,7 +13,7 @@ end
       obj  = defs.lookup(:const, 'Example')
 
       obj.line.should   == 2
-      obj.column.should == 0
+      obj.column.should == 1
       obj.file.should   == '(ruby-lint)'
     end
 
@@ -28,7 +28,7 @@ end
       obj  = defs.lookup(:const, 'Example')
 
       obj.line.should   == 2
-      obj.column.should == 0
+      obj.column.should == 1
       obj.file.should   == '(ruby-lint)'
     end
 
@@ -43,7 +43,7 @@ end
       obj  = defs.lookup(:instance_method, 'example')
 
       obj.line.should   == 2
-      obj.column.should == 0
+      obj.column.should == 1
       obj.file.should   == '(ruby-lint)'
     end
 
@@ -57,7 +57,7 @@ number = 10
       obj  = defs.lookup(:lvar, 'number')
 
       obj.line.should   == 2
-      obj.column.should == 0
+      obj.column.should == 1
       obj.file.should   == '(ruby-lint)'
     end
   end

data/spec/ruby-lint/virtual_machine/method_call_tracking_spec.rb

@@ -30,10 +30,10 @@ end
 
     example 'track call location information' do
       @third.calls[0].line.should   == 8
-      @third.calls[0].column.should == 2
+      @third.calls[0].column.should == 3
 
       @third.calls[1].line.should   == 9
-      @third.calls[1].column.should == 2
+      @third.calls[1].column.should == 3
     end
 
     example 'track the call definitions' do
@@ -43,10 +43,10 @@ end
 
     example 'track call location information in inverse direction' do
       @first.callers[0].line.should   == 8
-      @first.callers[0].column.should == 2
+      @first.callers[0].column.should == 3
 
       @second.callers[0].line.should   == 9
-      @second.callers[0].column.should == 2
+      @second.callers[0].column.should == 3
     end
 
     example 'track method calls in inverse direction' do

data/task/build.rake

@@ -1,9 +1,4 @@
-desc 'Builds and signs a new Gem'
-task :signed_build => [:build] do
-  name = "#{GEMSPEC.name}-#{GEMSPEC.version}.gem"
-  path = File.join(File.expand_path('../../pkg', __FILE__), name)
-
-  sh("gem sign #{path}")
-
+desc 'Builds a new Gem and its checksum'
+task :signed_build do
   Rake::Task['checksum'].invoke
 end

data/task/doc.rake

@@ -10,5 +10,7 @@ task :upload_doc => :doc do
   version_dir = File.join(root_dir, RubyLint::VERSION)
 
   sh "scp -r yardoc europa:#{version_dir}"
-  sh "ssh europa ln -s #{version_dir} #{root_dir}/latest"
+
+  sh "ssh europa 'rm -f #{root_dir}/latest " \
+    "&& ln -s #{version_dir} #{root_dir}/latest'"
 end

data/task/generate.rake

@@ -17,6 +17,9 @@ namespace :generate do
   task :everything, :overwrite do |task, args|
     args.with_defaults(:overwrite => false)
 
+    # Require the entire stdlib so we can generate the definitions for it.
+    require_relative '../misc/stdlib'
+
     directory = File.expand_path(
       '../../lib/ruby-lint/definitions/core/',
       __FILE__

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-lint
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 1.0.0.pre.preview1
 platform: ruby
 authors:
 - Yorick Peterse
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-21 00:00:00.000000000 Z
+date: 2013-11-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parser
@@ -24,34 +24,26 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: 2.0.0
-- !ruby/object:Gem::Dependency
-  name: racc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 1.4.10
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: 1.4.10
 - !ruby/object:Gem::Dependency
   name: slop
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.4'
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.4.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.4'
     - - '>='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 3.4.7
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -122,20 +114,6 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: rubygems-openpgp
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -223,6 +201,7 @@ files:
 - MANIFEST
 - README.md
 - Rakefile
+- benchmark/bootup.rb
 - benchmark/virtual_machine.rb
 - bin/ruby-lint
 - checksum/.gitkeep
@@ -230,6 +209,7 @@ files:
 - checksum/ruby-lint-0.0.4.gem.sha512
 - checksum/ruby-lint-0.0.5.gem.sha512
 - checksum/ruby-lint-0.9.0.gem.sha512
+- checksum/ruby-lint-0.9.1.gem.sha512
 - doc/.gitkeep
 - doc/DCO.md
 - doc/architecture.md
@@ -251,6 +231,7 @@ files:
 - lib/ruby-lint/analysis/unused_variables.rb
 - lib/ruby-lint/ast/builder.rb
 - lib/ruby-lint/ast/node.rb
+- lib/ruby-lint/benchmark/average.rb
 - lib/ruby-lint/cache.rb
 - lib/ruby-lint/cache_entry.rb
 - lib/ruby-lint/cli.rb
@@ -260,6 +241,7 @@ files:
 - lib/ruby-lint/cli/plot.rb
 - lib/ruby-lint/configuration.rb
 - lib/ruby-lint/constant_loader.rb
+- lib/ruby-lint/constant_path.rb
 - lib/ruby-lint/default_names.rb
 - lib/ruby-lint/definition/constant_proxy.rb
 - lib/ruby-lint/definition/ruby_method.rb
@@ -433,7 +415,6 @@ files:
 - lib/ruby-lint/file_scanner.rb
 - lib/ruby-lint/generated_constant.rb
 - lib/ruby-lint/global_scope.rb
-- lib/ruby-lint/helper/constant_paths.rb
 - lib/ruby-lint/inspector.rb
 - lib/ruby-lint/iterator.rb
 - lib/ruby-lint/method_call/alias.rb
@@ -493,6 +474,7 @@ files:
 - spec/ruby-lint/cli/analyze_spec.rb
 - spec/ruby-lint/cli/ast_spec.rb
 - spec/ruby-lint/configuration_spec.rb
+- spec/ruby-lint/constant_path.rb
 - spec/ruby-lint/definition/constant_proxy_spec.rb
 - spec/ruby-lint/definition/dsl_spec.rb
 - spec/ruby-lint/definition/ruby_method_spec.rb
@@ -520,6 +502,8 @@ files:
 - spec/ruby-lint/runner_spec.rb
 - spec/ruby-lint/virtual_machine/alias_spec.rb
 - spec/ruby-lint/virtual_machine/assignments/arrays_spec.rb
+- spec/ruby-lint/virtual_machine/assignments/assignment_arguments_spec.rb
+- spec/ruby-lint/virtual_machine/assignments/constants_spec.rb
 - spec/ruby-lint/virtual_machine/assignments/hashes_spec.rb
 - spec/ruby-lint/virtual_machine/assignments/optional_spec.rb
 - spec/ruby-lint/virtual_machine/assignments/return_values_spec.rb
@@ -598,12 +582,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - '>'
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: A linter and static code analysis tool for Ruby.

checksums.yaml.gz.asc

@@ -1,17 +0,0 @@
------BEGIN PGP SIGNATURE-----
-Version: GnuPG v2.0.22 (GNU/Linux)
-
-iQIcBAABAgAGBQJSZaGYAAoJEPMbESk2SfRE2+cP/RopiS2DlcZsvLj9GGnAgE3P
-g+qKKUC0Uhkuy9h5x6n/0vSGHOkObbIyyMS+nSkU5gilfeyCnABJSJ2bjdhw7FIj
-WkO17SZea38vWq+96i/XogikLQGa91wB0H000S/cPSCqMRzAejd7wEatboeUO/vv
-DHTtMNAB/zRLpK09f+0jfKykpyCs/IYnf0ksgj3vjM6KWhpPJgbfTs4U9RLDLNmi
-ZNkWoukKeMnm/t2ZBIbd99HnJ2k1TDo/eWSg0nLf+VXxdJSCCwPPS6yJMAdOm/s/
-gn1i+TtEI3ChwDUx+ayIDIRNtHLZvYX06WA+hmyFc7N5uv9EWxzg54dRzcZtT4FT
-XI0ffAAi9AdPp1GY9Rpswj5ZxD7bg4kTFSXp+ZViUR0kv9K21G6MnohRLQfD2tUR
-k/PidGMVtZj6/NZGXcWVSgSneCSa7GUFSDOqW3FxJP1JqREAgiKWmltX+y4GUoLp
-QnqGdG1ny0kK02a8T0MrYcS6+nCyK+V2VkPrXXn7Vjh8gapK41XqCz9z1YeNEFVt
-zW12bBnn9S6mZTbeseTiXwAimY/6SPKgDOhcCePvvWJpnLUW1lDTZquVjcZ0C4fZ
-68lh3NG0ou2sXvSZrDoHtLo/Ee0tZ9aoaxu2U7PQFMYRymP2ra1MtKzyeO+khlk7
-ob8exXEmfBbQGIo5r31v
-=jpFY
------END PGP SIGNATURE-----

data.tar.gz.asc

@@ -1,17 +0,0 @@
------BEGIN PGP SIGNATURE-----
-Version: GnuPG v2.0.22 (GNU/Linux)
-
-iQIcBAABAgAGBQJSZaGYAAoJEPMbESk2SfRECJIP/2L6stRY1E8JXvwIahm88gbf
-SXnmSsAEmJhpDs0OpItM6XWG+Or3L1Eu8F0g2FIS3u1nidaYXMCyrXXZqfyeMtC3
-zpimnnYL/NDMDqsAuLJFc5fidg2gEAHIY8ujTKH1LOJjsvVim5Cxhzz+BSu9mxAK
-WulazfRLEk76dmuSKANkciD1DWXySnGHU7wNITvPtlRzJgVs54wDQtlzhgQQu8sG
-Xq9nTLiJRFpquCrUsnAWxSJ8NWtXMgV8+i+50hJ/zI+wqt8VvZNX92XUfgTheUgG
-v9qMfa/+Bo7OBieZSv5sOuAaEywyRFsfe6b+D7NlZmfGeS71fX7tW0zG7jyFZZ0V
-vnQgyrTQYfEl8E8Htr3nGtSZ9LbrBkQIkQ2R1oP64ATm/NXz1kLhMJSB0Q/Gpco5
-9PXyiGHNylCOw8JrVW5wihKMO3Vo0R6B4tM/C4zkjOxpGhUCbRNOUlqyWLGSC0Af
-Gl/vF8ptxHAW0CuCwIIeWjwIv1NTi08zc/+ay380QcHulmlexBeY+h+CaWYT3ONt
-64JXR3VNgspjNYbdFHitDA1eHH9dc3b2n+pzvQNU3QoK1FCwt4uH4HCGYbcdH82F
-oRzPnb73MVuPUFEBz7jf3RX/gK0BRC7XDzqqREuyTN78Rxf6IcNEVYO6snj/EmkL
-GJw1BUlOMnbV54Y2rwBj
-=AnGR
------END PGP SIGNATURE-----