ruby-link-checker 0.3.0 → 0.4.0

data/spec/ruby-link-checker/tasks_spec.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+describe LinkChecker::Tasks do
+  describe '#_handle_result' do
+    # Reproduces issue #12: SystemStackError when logging causes repeated errors
+    # https://github.com/dblock/ruby-link-checker/issues/12
+    context 'when logger.info raises an error repeatedly' do
+      let(:checker) { LinkChecker::Net::HTTP::Checker.new(methods: ['GET']) }
+      let(:task_klass) { LinkChecker::Net::HTTP::Task }
+      let(:url) { 'https://www.example.org' }
+
+      before do
+        stub_request(:get, url).to_return(status: 200, body: '', headers: {})
+      end
+
+      it 'does not cause infinite recursion leading to SystemStackError' do
+        tasks = described_class.new(checker, task_klass, url, ['GET'])
+
+        # Stub logger to always raise an error on info, simulating the scenario
+        # from issue #12 where logging causes a stack overflow due to the
+        # rescue block in _handle_result recursively calling itself
+        allow(tasks).to receive(:logger).and_return(
+          instance_double(LinkChecker::Logger).tap do |logger|
+            allow(logger).to receive(:info).and_raise(StandardError, 'stack level too deep')
+            allow(logger).to receive(:error)
+          end
+        )
+
+        # Should not raise SystemStackError - the error should be handled gracefully
+        expect { tasks.execute! }.not_to raise_error
+      end
+    end
+  end
+
+  describe '#retries' do
+    let(:checker) { LinkChecker::Net::HTTP::Checker.new(methods: ['GET'], retries: 2) }
+    let(:task_klass) { LinkChecker::Net::HTTP::Task }
+    let(:url) { 'https://www.example.org' }
+
+    it 'delegates to the checker' do
+      tasks = described_class.new(checker, task_klass, url, ['GET'])
+      expect(tasks.send(:retries)).to eq 2
+    end
+  end
+end

data/spec/ruby-link-checker/typhoeus/hydra/checker_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe LinkChecker::Typhoeus::Hydra::Checker do
-  module TestLinkChecker
+  module TyphoeusTestLinkChecker
     class Task < LinkChecker::Typhoeus::Hydra::Task; end
 
     class LinkChecker < LinkChecker::Typhoeus::Hydra::Checker
@@ -19,9 +19,15 @@ describe LinkChecker::Typhoeus::Hydra::Checker do
     end
   end
 
-  describe TestLinkChecker::LinkChecker do
+  describe TyphoeusTestLinkChecker::LinkChecker do
     it_behaves_like 'a link checker'
 
+    describe '.config' do
+      it 'returns the Config module' do
+        expect(LinkChecker::Typhoeus::Hydra.config).to eq LinkChecker::Typhoeus::Hydra::Config
+      end
+    end
+
     context 'with timeout options', vcr: { cassette_name: '200' } do
       before do
         LinkChecker::Typhoeus::Hydra.configure do |config|
@@ -64,4 +70,24 @@ describe LinkChecker::Typhoeus::Hydra::Checker do
       end
     end
   end
+
+  describe LinkChecker::Typhoeus::Hydra::Result do
+    describe '#code' do
+      it 'returns -1 when the response raises' do
+        request = instance_double(Typhoeus::Request)
+        response = instance_double(Typhoeus::Response)
+        allow(response).to receive(:code).and_raise(StandardError)
+        result = described_class.new(URI('https://www.example.org'), 'GET', nil, request, response, {})
+        expect(result.code).to eq(-1)
+      end
+    end
+  end
+
+  describe '#run' do
+    it 'delegates to the hydra' do
+      checker = described_class.new
+      expect(checker.instance_variable_get(:@hydra)).to receive(:run)
+      checker.run
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -5,7 +5,9 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'rubygems'
 
 require 'simplecov'
-SimpleCov.start
+SimpleCov.start do
+  add_filter '/spec/'
+end
 
 require 'rspec'
 require 'ruby-link-checker'

data/spec/support/link_checker.rb

@@ -7,6 +7,10 @@ shared_context 'a link checker' do
     it 'has a default user-agent' do
       expect(subject.user_agent).to eq "Ruby Link Checker/#{LinkChecker::VERSION}"
     end
+
+    it 'has no default headers' do
+      expect(subject.headers).to eq({})
+    end
   end
 
   context 'user-agent' do
@@ -19,6 +23,16 @@ shared_context 'a link checker' do
     end
   end
 
+  context 'headers' do
+    subject do
+      described_class.new(headers: { 'DNT' => '1' })
+    end
+
+    it 'updates headers' do
+      expect(subject.headers).to eq('DNT' => '1')
+    end
+  end
+
   context 'check' do
     let(:url) { 'https://www.example.org' }
 
@@ -104,6 +118,16 @@ shared_context 'a link checker' do
               expect(result.options).to eq({})
             end
 
+            context 'with custom headers' do
+              subject do
+                described_class.new(methods: ['GET'], headers: { 'DNT' => '1' })
+              end
+
+              it 'sends custom headers' do
+                expect(result.request_headers['DNT']).to eq '1'
+              end
+            end
+
             it 'returns results' do
               expect(subject.results).to eq(
                 error: [],

metadata

@@ -1,15 +1,28 @@
 --- !ruby/object:Gem::Specification
 name: ruby-link-checker
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Daniel Doubrovkine
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-07-05 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: async-http
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -24,7 +37,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description:
 email: dblock@dblock.org
 executables: []
 extensions: []
@@ -42,37 +54,41 @@ files:
 - benchmarks/check.rb
 - benchmarks/data/opensearch.org/links.txt
 - benchmarks/data/opensearch.org/small.txt
-- coverage/assets/0.13.1/DataTables-1.10.20/images/sort_asc.png
-- coverage/assets/0.13.1/DataTables-1.10.20/images/sort_asc_disabled.png
-- coverage/assets/0.13.1/DataTables-1.10.20/images/sort_both.png
-- coverage/assets/0.13.1/DataTables-1.10.20/images/sort_desc.png
-- coverage/assets/0.13.1/DataTables-1.10.20/images/sort_desc_disabled.png
-- coverage/assets/0.13.1/application.css
-- coverage/assets/0.13.1/application.js
-- coverage/assets/0.13.1/colorbox/border.png
-- coverage/assets/0.13.1/colorbox/controls.png
-- coverage/assets/0.13.1/colorbox/loading.gif
-- coverage/assets/0.13.1/colorbox/loading_background.png
-- coverage/assets/0.13.1/favicon_green.png
-- coverage/assets/0.13.1/favicon_red.png
-- coverage/assets/0.13.1/favicon_yellow.png
-- coverage/assets/0.13.1/images/ui-bg_flat_0_aaaaaa_40x100.png
-- coverage/assets/0.13.1/images/ui-bg_flat_75_ffffff_40x100.png
-- coverage/assets/0.13.1/images/ui-bg_glass_55_fbf9ee_1x400.png
-- coverage/assets/0.13.1/images/ui-bg_glass_65_ffffff_1x400.png
-- coverage/assets/0.13.1/images/ui-bg_glass_75_dadada_1x400.png
-- coverage/assets/0.13.1/images/ui-bg_glass_75_e6e6e6_1x400.png
-- coverage/assets/0.13.1/images/ui-bg_glass_95_fef1ec_1x400.png
-- coverage/assets/0.13.1/images/ui-bg_highlight-soft_75_cccccc_1x100.png
-- coverage/assets/0.13.1/images/ui-icons_222222_256x240.png
-- coverage/assets/0.13.1/images/ui-icons_2e83ff_256x240.png
-- coverage/assets/0.13.1/images/ui-icons_454545_256x240.png
-- coverage/assets/0.13.1/images/ui-icons_888888_256x240.png
-- coverage/assets/0.13.1/images/ui-icons_cd0a0a_256x240.png
-- coverage/assets/0.13.1/loading.gif
-- coverage/assets/0.13.1/magnify.png
+- coverage/assets/0.13.2/DataTables-1.10.20/images/sort_asc.png
+- coverage/assets/0.13.2/DataTables-1.10.20/images/sort_asc_disabled.png
+- coverage/assets/0.13.2/DataTables-1.10.20/images/sort_both.png
+- coverage/assets/0.13.2/DataTables-1.10.20/images/sort_desc.png
+- coverage/assets/0.13.2/DataTables-1.10.20/images/sort_desc_disabled.png
+- coverage/assets/0.13.2/application.css
+- coverage/assets/0.13.2/application.js
+- coverage/assets/0.13.2/colorbox/border.png
+- coverage/assets/0.13.2/colorbox/controls.png
+- coverage/assets/0.13.2/colorbox/loading.gif
+- coverage/assets/0.13.2/colorbox/loading_background.png
+- coverage/assets/0.13.2/favicon_green.png
+- coverage/assets/0.13.2/favicon_red.png
+- coverage/assets/0.13.2/favicon_yellow.png
+- coverage/assets/0.13.2/images/ui-bg_flat_0_aaaaaa_40x100.png
+- coverage/assets/0.13.2/images/ui-bg_flat_75_ffffff_40x100.png
+- coverage/assets/0.13.2/images/ui-bg_glass_55_fbf9ee_1x400.png
+- coverage/assets/0.13.2/images/ui-bg_glass_65_ffffff_1x400.png
+- coverage/assets/0.13.2/images/ui-bg_glass_75_dadada_1x400.png
+- coverage/assets/0.13.2/images/ui-bg_glass_75_e6e6e6_1x400.png
+- coverage/assets/0.13.2/images/ui-bg_glass_95_fef1ec_1x400.png
+- coverage/assets/0.13.2/images/ui-bg_highlight-soft_75_cccccc_1x100.png
+- coverage/assets/0.13.2/images/ui-icons_222222_256x240.png
+- coverage/assets/0.13.2/images/ui-icons_2e83ff_256x240.png
+- coverage/assets/0.13.2/images/ui-icons_454545_256x240.png
+- coverage/assets/0.13.2/images/ui-icons_888888_256x240.png
+- coverage/assets/0.13.2/images/ui-icons_cd0a0a_256x240.png
+- coverage/assets/0.13.2/loading.gif
+- coverage/assets/0.13.2/magnify.png
 - coverage/index.html
 - lib/ruby-link-checker.rb
+- lib/ruby-link-checker/async/http.rb
+- lib/ruby-link-checker/async/http/checker.rb
+- lib/ruby-link-checker/async/http/config.rb
+- lib/ruby-link-checker/async/http/result.rb
 - lib/ruby-link-checker/callbacks.rb
 - lib/ruby-link-checker/checker.rb
 - lib/ruby-link-checker/config.rb
@@ -105,10 +121,16 @@ files:
 - spec/fixtures/404_404.yml
 - spec/fixtures/429_200.yml
 - spec/fixtures/429_429_200.yml
+- spec/ruby-link-checker/async/http/checker_spec.rb
 - spec/ruby-link-checker/callbacks_spec.rb
 - spec/ruby-link-checker/checker_spec.rb
 - spec/ruby-link-checker/config_spec.rb
+- spec/ruby-link-checker/errors/redirect_loop_error_spec.rb
 - spec/ruby-link-checker/net/http/checker_spec.rb
+- spec/ruby-link-checker/result_error_spec.rb
+- spec/ruby-link-checker/result_spec.rb
+- spec/ruby-link-checker/task_spec.rb
+- spec/ruby-link-checker/tasks_spec.rb
 - spec/ruby-link-checker/typhoeus/hydra/checker_spec.rb
 - spec/ruby-link-checker/version_spec.rb
 - spec/spec_helper.rb
@@ -122,7 +144,6 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -130,15 +151,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Fast ruby link checker.
 test_files: []