ruby-libvirt 0.8.1 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fee786f1797ab1c5a5e8d496b387667786a5f703872a29125fbc0d43f6737b4b
-  data.tar.gz: e79852df639e0ff830afae0918e2e5e3754e555eb2db8c9641b38cb834793091
+  metadata.gz: cedabfb7ce30484b1ee1781d9c54eecc102f3a02ae4e8bb3939dc76048db072d
+  data.tar.gz: a5bbc0558a140785b26f7687b3d155767f2813baa51271d7114ff7389761755d
 SHA512:
-  metadata.gz: f927ee0ed89539c2db5ae8aa955d4e03960b770e511bec78b5e46972ccc61f8e3d6bcf1d5c34efa84b3573b9f55365bdb6be52534ad7e3777b6d6b926d5001da
-  data.tar.gz: 933864259c5b508f6956de0c5f99ba3a9ba3c741863e9f9e74fbe2d433f83e68fbf650725598f0c41c3df3c9abe51f3a717ccd27da547a57d359b86071379e03
+  metadata.gz: 61db9b3ab4593e7712a96bd740aaf2c4ef825605a6773038f679f120e62f08dc9052421fd0b1b67a98e3d34593f93ef90df7f3fdb09cc34174ba2ececd75062f
+  data.tar.gz: 6d8821193b57518149efcda6d2a14c6eadc06895e7388f9b344ae28f56529e4ee70623fcea2fb70683e4541f15e4e72e5baa8071c17bf54cfb2c7273a1174d2e

data/NEWS.rst

@@ -0,0 +1,229 @@
+=====================
+ruby-libvirt releases
+=====================
+
+
+0.8.3 (2024-05-13)
+==================
+
+* Fix runtime warnings with Ruby >= 3.2
+* Improve build system
+* Improve website
+
+
+0.8.2 (2024-02-09)
+==================
+
+* Fix ``StoragePool#list_all_volumes``
+* Fix regression in ``Domain#attach_device`` and ``Domain#detach_device``
+
+
+0.8.1 (2024-02-08)
+==================
+
+* Add missing ``virDomainUndefineFlagsValues`` constants
+* Require libvirt 2.0.0
+* Always use pkg-config for detecting libvirt
+* Drop most compile-time feature checks
+
+
+0.8.0 (2021-11-15)
+==================
+
+* Fix default values for ``node_cpu_stats`` and ``node_memory_stats``
+* Fix cpumap allocation for ``virDomainGetVcpus``
+* Enforce UTF8 for strings and exceptions
+* Drop local ``have_const``
+* Use sensible default for ``libvirt_domain_qemu_agent_command``
+
+
+0.7.1 (2018-02-18)
+==================
+
+* Fix a bad bug in block_resize (Marius Rieder)
+* Fix up some problems pointed out by clang
+* Fix up the tests for small semantic differences in how libvirt works
+
+
+0.7.0 (2016-09-22)
+==================
+
+* Fix network lease API to allow arguments that libvirt allows
+* Implement ``VIRT_STORAGE_POOL_CREATE`` flags
+* Implement more ``VIR_STORAGE_VOL`` flags
+* Implement ``VIR_DOMAIN_QEMU_AGENT_COMMAND_SHUTDOWN``
+* Implement ``virDomainDefineXMLFlags``
+* Implement ``virDomainRename``
+* Implement ``virDomainSetUserPassword``
+* Implement ``VIR_DOMAIN_TIME_SYNC``
+* Fix the return value from ``virStreamSourceFunc`` so volume upload works
+
+
+0.6.0 (2015-11-20)
+==================
+
+* Fix possible buffer overflow
+* Fix storage volume creation error messages
+* Add additional storage pool defines
+* Implement ``Network#dhcp_leases`` method
+* Implement ``Connect#node_alloc_pages`` method
+* Implement ``Domain#time`` method
+* Implement ``Connect#domain_capabilities`` method
+* Implement ``Domain#core_dump_with_format`` method
+* Implement ``Domain#fs_freeze`` method
+* Implement ``Domain#fs_info`` method
+* Implement ``Connect#node_free_pages`` method
+
+
+0.5.2 (2014-01-08)
+==================
+
+* Fix to make sure we don't free more entires than retrieved
+
+
+0.5.1 (2013-12-15)
+==================
+
+* Fixes to compile against older libvirt
+* Fixes to compile against ruby 1.8
+
+
+0.5.0 (2013-12-09)
+==================
+
+* Updated ``Network`` class, implementing almost all libvirt APIs
+* Updated ``Domain`` class, implementing almost all libvirt APIs
+* Updated ``Connection`` class, implementing almost all libvirt APIs
+* Updated ``DomainSnapshot`` class, implementing almost all libvirt APIs
+* Updated ``NodeDevice`` class, implementing almost all libvirt APIs
+* Updated ``Storage`` class, implementing almost all libvirt APIs
+* Add constants for almost all libvirt defines
+* Improved performance in the library by using alloca
+
+
+0.4.0 (2011-07-27)
+==================
+
+* Updated ``Domain`` class, implementing ``dom.memory_parameters=``,
+  ``dom.memory_parameters``, ``dom.updated?``, ``dom.migrate2``,
+  ``dom.migrate_to_uri2``, ``dom.migrate_set_max_speed``,
+  ``dom.qemu_monitor_command``, ``dom.blkio_parameters``,
+  ``dom.blkio_parameters=``, ``dom.state``, ``dom.open_console``,
+  ``dom.screenshot`` and ``dom.inject_nmi``
+* Implementation of the ``Stream`` class, which covers the libvirt
+  ``virStream`` APIs
+* Add the ability to build against non-system libvirt libraries
+* Updated ``Error`` object, which now includes the libvirt code, component and
+  level of the error, as well as all of the error constants from ``libvirt.h``
+* Updated ``Connect`` class, implementing ``conn.sys_info``, ``conn.stream``,
+  ``conn.interface_change_begin``, ``conn.interface_change_commit`` and
+  ``conn.interface_change_rollback``
+* Updated ``StorageVol`` class, implementing ``vol.download`` and
+  ``vol.upload``
+* Various bugfixes
+
+
+0.3.0 (2010-12-12)
+==================
+
+* Implementation of ``Libvirt::open_auth``, ``Libvirt::event_register_impl``
+* Updated ``Connect`` class, implementing ``conn.compare_cpu``,
+  ``conn.baseline_cpu``, ``conn.domain_event_register_any``,
+  ``conn.domain_event_deregister_any``, ``conn.domain_event_register``,
+  ``conn.domain_event_deregister`` and ``conn.create_domain_xml``
+* Updated ``Domain`` class, implementing ``dom.get_vcpus``,
+  ``dom.update_device``, ``dom.scheduler_type``, ``dom.scheduler_parameters``,
+  ``dom.scheduler_parameters=``, ``dom.num_vcpus``, ``dom.vcpus_flags=`` and
+  ``dom.qemu_monitor_command``
+* Updated ``Interface`` class, implementing ``interface.free``
+* Many potential memory leaks have been fixed
+* Many bugfixes
+* Documentation update of many methods, including all of the lookup methods
+  that were missing before
+
+
+0.2.0 (2010-07-01)
+==================
+
+* Updated ``Storage`` class, implementing ``pool.active?``,
+  ``pool.persistent?`` and ``pool.vol_create_xml_from``
+* Updated ``Connect`` class, implementing ``conn.node_free_memory``,
+  ``conn.node_cells_free_memory``, ``conn.node_get_security_model``,
+  ``conn.encrypted?``, ``conn.libversion`` and ``conn.secure?``
+* Updated ``Network`` class, implementing ``net.active?`` and
+  ``net.persistent?``
+* Update ``Domain`` class, implementing ``conn.domain_xml_from_native``,
+  ``conn.domain_xml_to_native``, ``dom.migrate_to_uri``,
+  ``dom.migrate_set_max_downtime``, ``dom.managed_save``,
+  ``dom.has_managed_save?``, ``dom.managed_save_remove``,
+  ``dom.security_label``, ``dom.block_stats``, ``dom.memory_stats``,
+  ``dom.blockinfo``, ``dom.block_peek``, ``dom.memory_peek``, ``dom.active?``,
+  ``dom.persistent?``, ``dom.snapshot_create_xml``, ``dom.num_of_snapshots``,
+  ``dom.list_snapshots``, ``dom.lookup_snapshot_by_name``,
+  ``dom.has_current_snapshot?``, ``dom.revert_to_snapshot``,
+  ``dom.current_snapshot``, ``snapshot.xml_desc``, ``snapshot.delete``,
+  ``dom.job_info`` and ``dom.abort_job``
+* Implementation of the ``NodeDevice`` class
+* Implementation of the ``Secret`` class
+* Implementation of the ``NWFilter`` class
+* Implementation of the ``Interface`` class
+* Conversion of the development tree to git
+* New maintainer (Chris Lalancette). David Lutterkort has agreed to transfer
+  maintainership since he is not actively involved in their development
+  anymore
+
+
+0.1.0 (2008-11-18)
+==================
+
+* Add binding for ``virConnectFindStoragePoolSources`` (Chris Lalancette)
+* Fix ``dom_migrate`` (Chris Lalancette)
+* Add the ``MIGRATE_LIVE`` (``enum virDomainMigrateFlags``) flag
+* Slight improvements of the unit tests
+
+
+0.0.7 (2008-04-15)
+==================
+
+* Binding for ``virDomainMigrate``
+* Fix crash caused by using ``virResetError``
+* More sensible message included in exceptions
+
+
+0.0.6 (2008-04-02)
+==================
+
+* Fix test failure exposed by the Fedora builders
+
+
+0.0.5 (2008-04-02)
+==================
+
+* Explicit free methods for various objects (based on a patch by Vadim Zaliva)
+* Make the FLAGS argument for various calls optional, and default it to 0
+  (Chris Lalancette)
+* More finegrained exceptions on errors, containing libvirt error message
+  (Mohammed Morsi)
+
+
+0.0.4 (2008-04-01)
+==================
+
+* Bindings for the libvirt storage API (requires libvirt 0.4.1)
+* Suppress some bindings if the underlying libvirt doesn't support it
+* Bindings for ``virDomainSetMemory``, ``virDomainPinVcpu`` and
+  ``virDomainSetVcpus`` (Vadim Zaliva)
+
+
+0.0.2 (2007-12-06)
+==================
+
+* Add ``virNodeGetInfo`` binding
+* Convert Ruby API from StudlyCaps to under_score_separation, since that's
+  the Ruby convention
+
+
+0.0.1 (2007-11-19)
+==================
+
+* Initial release

data/README.rst

@@ -0,0 +1,45 @@
+============
+ruby-libvirt
+============
+
+Ruby bindings for `libvirt <https://libvirt.org/>`__.
+
+
+Usage
+=====
+
+Add ``require 'libvirt'`` to your program, then call
+``Libvirt::open`` or ``Libvirt::open_read_only`` to obtain a
+connection.
+
+See ``examples/*.rb`` and ``tests/*.rb`` for more examples.
+
+
+Hacking
+=======
+
+On a Fedora machine, run
+
+::
+
+    $ yum install libvirt-devel ruby-devel rubygem-rake
+
+followed by
+
+::
+
+    $ rake build
+
+To run code against the bindings without having to install them
+first, ``$RUBYLIB`` needs to be set appropriately. For example:
+
+::
+
+    $ export RUBYLIB="lib:ext/libvirt"
+    $ ruby -rlibvirt -e 'puts Libvirt::version[0]'
+
+
+Contributing
+============
+
+See `CONTRIBUTING.rst <CONTRIBUTING.rst>`__.

data/Rakefile

@@ -11,75 +11,96 @@
 
 # Rakefile for ruby-rpm -*- ruby -*-
 require 'rake/clean'
-begin
-  require 'rdoc/task'
-rescue LoadError
-  require 'rake/rdoctask'
-end
 require 'rake/testtask'
+require 'rdoc/task'
 require 'rubygems/package_task'
-require 'rbconfig'
 
 PKG_NAME='ruby-libvirt'
-PKG_VERSION='0.8.1'
-
-EXT_CONF='ext/libvirt/extconf.rb'
-MAKEFILE="ext/libvirt/Makefile"
-LIBVIRT_MODULE="ext/libvirt/_libvirt.so"
-SPEC_FILE="ruby-libvirt.spec"
-LIBVIRT_SRC=Dir.glob("ext/libvirt/*.c")
-LIBVIRT_SRC << MAKEFILE
+PKG_VERSION='0.8.3'
+
+EXT_DIR = "ext/libvirt"
+EXTCONF = "#{EXT_DIR}/extconf.rb"
+MAKEFILE = "#{EXT_DIR}/Makefile"
+LIBVIRT_MODULE = "#{EXT_DIR}/_libvirt.so"
+SPEC_FILE = "#{PKG_NAME}.spec"
+SRC_FILES = FileList[
+    "#{EXT_DIR}/_libvirt.c",
+    "#{EXT_DIR}/common.c",
+    "#{EXT_DIR}/common.h",
+    "#{EXT_DIR}/connect.c",
+    "#{EXT_DIR}/connect.h",
+    "#{EXT_DIR}/domain.c",
+    "#{EXT_DIR}/domain.h",
+    "#{EXT_DIR}/interface.c",
+    "#{EXT_DIR}/interface.h",
+    "#{EXT_DIR}/network.c",
+    "#{EXT_DIR}/network.h",
+    "#{EXT_DIR}/nodedevice.c",
+    "#{EXT_DIR}/nodedevice.h",
+    "#{EXT_DIR}/nwfilter.c",
+    "#{EXT_DIR}/nwfilter.h",
+    "#{EXT_DIR}/secret.c",
+    "#{EXT_DIR}/secret.h",
+    "#{EXT_DIR}/storage.c",
+    "#{EXT_DIR}/storage.h",
+    "#{EXT_DIR}/stream.c",
+    "#{EXT_DIR}/stream.h",
+]
+LIB_FILES = FileList[
+    "lib/libvirt.rb",
+]
+GEN_FILES = FileList[
+    MAKEFILE,
+    "#{EXT_DIR}/extconf.h",
+]
 
 #
 # Additional files for clean/clobber
 #
 
-CLEAN.include [ "ext/**/*.o", LIBVIRT_MODULE, "ext/**/depend", "ext/**/*.gcda",
-                "ext/**/*.gcno", "ext/**/*.gcov" ]
-
-CLOBBER.include [ "ext/**/mkmf.log", "ext/**/extconf.h", MAKEFILE ]
-
-task :default => :build
+CLEAN.include [ "#{EXT_DIR}/*.o", LIBVIRT_MODULE ]
+CLOBBER.include [ "#{EXT_DIR}/mkmf.log" ] + GEN_FILES
 
 #
 # Build locally
 #
-file MAKEFILE => EXT_CONF do |t|
-    Dir::chdir(File::dirname(EXT_CONF)) do
-        extra = ""
-        args = ARGV.grep(/^--with-libvirt-include=/)
-        extra += args[0].chomp unless args.empty?
-        args = ARGV.grep(/^--with-libvirt-lib=/)
-        extra += " " + args[0].chomp unless args.empty?
-
-        unless sh "ruby #{File::basename(EXT_CONF)} #{extra}"
-            $stderr.puts "Failed to run extconf"
-            break
-        end
+
+task :default => :build
+
+file MAKEFILE => EXTCONF do |t|
+    Dir::chdir(File::dirname(EXTCONF)) do
+        sh "ruby #{File::basename(EXTCONF)}"
     end
 end
-file LIBVIRT_MODULE => LIBVIRT_SRC do |t|
-    Dir::chdir(File::dirname(EXT_CONF)) do
-        unless sh "make"
-            $stderr.puts "make failed"
-            break
-        end
-     end
+file LIBVIRT_MODULE => SRC_FILES + [ MAKEFILE ] do |t|
+    Dir::chdir(File::dirname(EXTCONF)) do
+        sh "make"
+    end
 end
 desc "Build the native library"
 task :build => LIBVIRT_MODULE
 
 #
-# Test task
+# Test tasks
 #
 
+TEST_FILES = FileList[
+    "tests/test_conn.rb",
+    "tests/test_domain.rb",
+    "tests/test_interface.rb",
+    "tests/test_network.rb",
+    "tests/test_nodedevice.rb",
+    "tests/test_nwfilter.rb",
+    "tests/test_open.rb",
+    "tests/test_secret.rb",
+    "tests/test_storage.rb",
+    "tests/test_stream.rb",
+    "tests/test_utils.rb",
+]
+
 Rake::TestTask.new(:test) do |t|
-    t.test_files = [ 'tests/test_conn.rb', 'tests/test_domain.rb',
-                     'tests/test_interface.rb', 'tests/test_network.rb',
-                     'tests/test_nodedevice.rb', 'tests/test_nwfilter.rb',
-                     'tests/test_open.rb', 'tests/test_secret.rb',
-                     'tests/test_storage.rb', 'tests/test_stream.rb' ]
-    t.libs = [ 'lib', 'ext/libvirt' ]
+    t.test_files = TEST_FILES
+    t.libs << EXT_DIR
 end
 task :test => :build
 
@@ -87,65 +108,55 @@ task :test => :build
 # Documentation tasks
 #
 
-RDOC_FILES = FileList[ "README.rdoc", "lib/libvirt.rb",
-                       "ext/libvirt/_libvirt.c", "ext/libvirt/connect.c",
-                       "ext/libvirt/domain.c", "ext/libvirt/interface.c",
-                       "ext/libvirt/network.c", "ext/libvirt/nodedevice.c",
-                       "ext/libvirt/nwfilter.c", "ext/libvirt/secret.c",
-                       "ext/libvirt/storage.c", "ext/libvirt/stream.c" ]
+RDOC_MAIN = "doc/main.rdoc"
+RDOC_FILES = FileList[ RDOC_MAIN ] + SRC_FILES + LIB_FILES
 
-Rake::RDocTask.new do |rd|
-    rd.main = "README.rdoc"
+RDoc::Task.new do |rd|
+    rd.main = RDOC_MAIN
     rd.rdoc_dir = "doc/site/api"
     rd.rdoc_files.include(RDOC_FILES)
 end
 
-Rake::RDocTask.new(:ri) do |rd|
-    rd.main = "README.rdoc"
+RDoc::Task.new(:ri) do |rd|
+    rd.main = RDOC_MAIN
     rd.rdoc_dir = "doc/ri"
     rd.options << "--ri-system"
     rd.rdoc_files.include(RDOC_FILES)
 end
 
-#
-# Splint task
-#
-
-task :splint => [ MAKEFILE ] do |t|
-    Dir::chdir(File::dirname(EXT_CONF)) do
-        unless sh "splint -I" + Config::CONFIG['vendorarchdir'] + " *.c"
-            $stderr.puts "Failed to run splint"
-            break
-        end
-    end
-end
-
 #
 # Package tasks
 #
 
-PKG_FILES = FileList[ "Rakefile", "COPYING", "README", "NEWS", "README.rdoc",
-                      "lib/**/*.rb",
-                      "ext/**/*.[ch]", "ext/**/MANIFEST", "ext/**/extconf.rb",
-                      "tests/**/*",
-                      "spec/**/*" ]
-
-DIST_FILES = FileList[ "pkg/*.src.rpm",  "pkg/*.gem",  "pkg/*.zip",
-                       "pkg/*.tgz" ]
+PKG_FILES = FileList[
+    "Rakefile",
+    "COPYING",
+    "README.rst",
+    "NEWS.rst",
+    EXTCONF,
+    RDOC_MAIN,
+] + SRC_FILES + LIB_FILES + TEST_FILES
 
 SPEC = Gem::Specification.new do |s|
     s.name = PKG_NAME
     s.version = PKG_VERSION
-    s.email = "libvir-list@redhat.com"
-    s.homepage = "https://ruby.libvirt.org/"
-    s.summary = "Ruby bindings for LIBVIRT"
     s.files = PKG_FILES
-    s.required_ruby_version = '>= 1.8.1'
-    s.extensions = "ext/libvirt/extconf.rb"
-    s.author = "David Lutterkort, Chris Lalancette"
-    s.rubyforge_project = "None"
-    s.description = "Ruby bindings for libvirt."
+    s.extensions = EXTCONF
+    s.required_ruby_version = ">= 1.8.1"
+    s.summary = "Ruby bindings for libvirt"
+    s.description = <<~EOF
+        ruby-libvirt allows applications written in Ruby to use the
+        libvirt API.
+    EOF
+    s.authors = ["David Lutterkort", "Chris Lalancette"]
     s.license = "LGPL-2.1-or-later"
+    s.email = "devel@lists.libvirt.org"
+    s.homepage = "https://ruby.libvirt.org/"
+    s.metadata = {
+        "source_code_uri" => "https://gitlab.com/libvirt/libvirt-ruby",
+        "bug_tracker_uri" => "https://gitlab.com/libvirt/libvirt-ruby/-/issues",
+        "documentation_uri" => "https://ruby.libvirt.org/api/index.html",
+    }
 end
 
 Gem::PackageTask.new(SPEC) do |pkg|
@@ -155,12 +166,22 @@ end
 
 desc "Build (S)RPM for #{PKG_NAME}"
 task :rpm => [ :package ] do |t|
-    system("sed -e 's/@VERSION@/#{PKG_VERSION}/' #{SPEC_FILE} > pkg/#{SPEC_FILE}")
-    Dir::chdir("pkg") do |dir|
-        dir = File::expand_path(".")
-        system("rpmbuild --define '_topdir #{dir}' --define '_sourcedir #{dir}' --define '_srcrpmdir #{dir}' --define '_rpmdir #{dir}' --define '_builddir #{dir}' -ba #{SPEC_FILE} > rpmbuild.log 2>&1")
-        if $? != 0
-            raise "rpmbuild failed"
-        end
-    end
+    pkg_dir = File::expand_path("pkg")
+    sed = [
+        "sed",
+        "-e", "'s/@VERSION@/#{PKG_VERSION}/'",
+        "#{SPEC_FILE}.in", ">#{pkg_dir}/#{SPEC_FILE}",
+    ]
+    sh sed.join(" ")
+    rpmbuild = [
+        "rpmbuild",
+        "--clean",
+        "--define", "'_topdir #{pkg_dir}'",
+        "--define", "'_sourcedir #{pkg_dir}'",
+        "--define", "'_srcrpmdir #{pkg_dir}'",
+        "--define", "'_rpmdir #{pkg_dir}'",
+        "--define", "'_builddir #{pkg_dir}'",
+        "-ba", "#{pkg_dir}/#{SPEC_FILE}",
+    ]
+    sh rpmbuild.join(" ")
 end

data/ext/libvirt/connect.c

@@ -2741,6 +2741,7 @@ static VALUE libvirt_connect_node_free_pages(int argc, VALUE *argv, VALUE c)
 void ruby_libvirt_connect_init(void)
 {
     c_connect = rb_define_class_under(m_libvirt, "Connect", rb_cObject);
+    rb_undef_alloc_func(c_connect);
 
     /*
      * Class Libvirt::Connect::Nodeinfo

data/ext/libvirt/domain.c

@@ -1232,7 +1232,7 @@ static VALUE libvirt_domain_autostart_equal(VALUE d, VALUE autostart)
  * call-seq:
  *   dom.attach_device(device_xml, flags=0) -> nil
  *
- * Call virDomainAttachDevice[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDevice]
+ * Call virDomainAttachDeviceFlags[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainAttachDeviceFlags]
  * to attach the device described by the device_xml to the domain.
  */
 static VALUE libvirt_domain_attach_device(int argc, VALUE *argv, VALUE d)
@@ -1241,25 +1241,23 @@ static VALUE libvirt_domain_attach_device(int argc, VALUE *argv, VALUE d)
 
     rb_scan_args(argc, argv, "11", &xml, &flags);
 
-    if (ruby_libvirt_value_to_uint(flags) != 0) {
-        ruby_libvirt_generate_call_nil(virDomainAttachDeviceFlags,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml),
-                                       ruby_libvirt_value_to_uint(flags));
-    } else {
-        ruby_libvirt_generate_call_nil(virDomainAttachDevice,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml));
-    }
+    /* NOTE: can't use virDomainAttachDevice() when flags==0 here
+     *       because that function only works on active domains and
+     *       VIR_DOMAIN_AFFECT_CURRENT==0.
+     *
+     * See https://gitlab.com/libvirt/libvirt-ruby/-/issues/11 */
+    ruby_libvirt_generate_call_nil(virDomainAttachDeviceFlags,
+                                   ruby_libvirt_connect_get(d),
+                                   ruby_libvirt_domain_get(d),
+                                   StringValueCStr(xml),
+                                   ruby_libvirt_value_to_uint(flags));
 }
 
 /*
  * call-seq:
  *   dom.detach_device(device_xml, flags=0) -> nil
  *
- * Call virDomainDetachDevice[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDevice]
+ * Call virDomainDetachDeviceFlags[https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainDetachDeviceFlags]
  * to detach the device described by the device_xml from the domain.
  */
 static VALUE libvirt_domain_detach_device(int argc, VALUE *argv, VALUE d)
@@ -1268,18 +1266,16 @@ static VALUE libvirt_domain_detach_device(int argc, VALUE *argv, VALUE d)
 
     rb_scan_args(argc, argv, "11", &xml, &flags);
 
-    if (ruby_libvirt_value_to_uint(flags) != 0) {
-        ruby_libvirt_generate_call_nil(virDomainDetachDeviceFlags,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml),
-                                       ruby_libvirt_value_to_uint(flags));
-    } else {
-        ruby_libvirt_generate_call_nil(virDomainDetachDevice,
-                                       ruby_libvirt_connect_get(d),
-                                       ruby_libvirt_domain_get(d),
-                                       StringValueCStr(xml));
-    }
+    /* NOTE: can't use virDomainDetachDevice() when flags==0 here
+     *       because that function only works on active domains and
+     *       VIR_DOMAIN_AFFECT_CURRENT==0.
+     *
+     * See https://gitlab.com/libvirt/libvirt-ruby/-/issues/11 */
+    ruby_libvirt_generate_call_nil(virDomainDetachDeviceFlags,
+                                   ruby_libvirt_connect_get(d),
+                                   ruby_libvirt_domain_get(d),
+                                   StringValueCStr(xml),
+                                   ruby_libvirt_value_to_uint(flags));
 }
 
 /*
@@ -4067,6 +4063,7 @@ static VALUE libvirt_domain_user_password_equal(VALUE d, VALUE in)
 void ruby_libvirt_domain_init(void)
 {
     c_domain = rb_define_class_under(m_libvirt, "Domain", rb_cObject);
+    rb_undef_alloc_func(c_domain);
 
     rb_define_const(c_domain, "NOSTATE", INT2NUM(VIR_DOMAIN_NOSTATE));
     rb_define_const(c_domain, "RUNNING", INT2NUM(VIR_DOMAIN_RUNNING));
@@ -4392,6 +4389,8 @@ void ruby_libvirt_domain_init(void)
      * Class Libvirt::Domain::Snapshot
      */
     c_domain_snapshot = rb_define_class_under(c_domain, "Snapshot", rb_cObject);
+    rb_undef_alloc_func(c_domain_snapshot);
+
     rb_define_const(c_domain_snapshot, "DELETE_CHILDREN",
                     INT2NUM(VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN));
     rb_define_method(c_domain_snapshot, "xml_desc",

data/ext/libvirt/interface.c

@@ -174,6 +174,8 @@ static VALUE libvirt_interface_free(VALUE i)
 void ruby_libvirt_interface_init(void)
 {
     c_interface = rb_define_class_under(m_libvirt, "Interface", rb_cObject);
+    rb_undef_alloc_func(c_interface);
+
     rb_define_const(c_interface, "XML_INACTIVE",
                     INT2NUM(VIR_INTERFACE_XML_INACTIVE));
     rb_define_attr(c_interface, "connection", 1, 0);

data/ext/libvirt/network.c

@@ -329,6 +329,8 @@ static VALUE libvirt_network_get_dhcp_leases(int argc, VALUE *argv, VALUE n)
 void ruby_libvirt_network_init(void)
 {
     c_network = rb_define_class_under(m_libvirt, "Network", rb_cObject);
+    rb_undef_alloc_func(c_network);
+
     rb_define_attr(c_network, "connection", 1, 0);
 
     rb_define_method(c_network, "undefine", libvirt_network_undefine, 0);