ruby-jss 4.1.1 → 4.2.0b2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c0df8e9b794ba674f60a7a224e9f7b9ae166d6ef5ff39435920e17460412a770
-  data.tar.gz: afef3a2acddf6588525facb25eb3273a1e96c02a5d3b2c57771cd951bf8fc0d6
+  metadata.gz: 998e9334c72d6bfa5826e571d4c69077d5876ecc047e5fb6d8329eec9e7935a1
+  data.tar.gz: 10cc0ac1056319a810d87234d98ab9ef8523e9156e96db018fe7729fc166988d
 SHA512:
-  metadata.gz: fbd69adff24c3b718c0711042a36162f92f5f399081239c6d1f4919daf4fa978980a6a424a9cdc87e0635beafa04368f8eba71991fdef1d999ce799c8433db62
-  data.tar.gz: eae8268d15ecdd23d0f88039e6329a5d298e570716a3abfe552fc861bc403583b8402066379f2e5bd3c3e36f0ebf2eea543aa9bed0c9f34f18394d8473a8910d
+  metadata.gz: 3b8b65205b159d6cc79c7dba9c3968d10746a7158037ed5326812e31b17c1a769c44d5c5ddf00442a073a5e42ee38ae993619390b088ff9ebafd089c5f4505b2
+  data.tar.gz: 8e55221f470dcaa7f385fdae5d725db9e179434b0f33fb31090bc403fed7a71c3988c4a2f6ca0ec6204ad49d20f4253d6dcf5cce31aa0f0677dcc48dc052bba7

data/CHANGES.md

@@ -14,6 +14,72 @@ __Please update all installations of ruby-jss to at least v1.6.0.__
 
 Many many thanks to actae0n of Blacksun Hackers Club for reporting this issue and providing examples of how it could be exploited.
 
+--------
+## \[4.2.0] Unreleased
+
+### Moving forward with the Jamf Pro API
+With this release, we begin the long process of porting existing classes from the Classic API to the Jamf Pro API where possible, starting with `Jamf::Package`. So far, our implementation of classes from the Jamf Pro API has been limited to those not already implemented via the Classic API.
+
+However, because of our stated goals for implementing things in the Jamf Pro API (see [README-2.0.0.md](README-2.0.0.md)), we can't just change the existing classes without breaking lots of code. For example, in order to eliminate various 'hidden permissions requirements' and adhere more closely to the actual API, we're [eliminating cross-object validation](README-2.0.0.md#cross-object-validation-in-setters). 
+
+For Packages, this means that when setting the categoryId, you must provide an id, not a category name. In Jamf::Package, using the Classic API, you could provide a name, and ruby-jss would look at the categories in the API and validate/convert to an id. This required 'undocumented' permissions to see the category endpoints when working with the package endpoints. NOTE: if you have read-permissions on categories, you can still use the `Jamf::Category.valid_id` method to convert from names to ids yourself. That method is available for all collection classes in both APIs.
+
+In order to move forward with Jamf Pro-based classes, while providing reasonable backward compatibility, here's the plan:
+
+  - For each class being migrated, and new class, prepended with `J` will be created.  So for accessing packages via the Jamf Pro API, we are introducing the class `Jamf::JPackage`. We've had an experimental  Jamf Pro version of Jamf::JpBuilding for a while, and it has been renamed to `Jamf::JBuilding` 
+  - The original Classic API-based class will be marked as deprecated when the matching J-class is released.
+  - The deprecated classes will exist for at least one year (probably longer) but will get few, if any, updates, mostly limited to security-related fixes. As of this release, `Jamf::Package` and `Jamf::Building` are deprecated. 
+  - During the deprecation period, please update all your code to use the new Jamf Pro API-based classes.
+  - When the older Classic API-based class is actually removed, the remaning Jamf Pro API-based class will be aliased back to the original name, without the `J`. So at that point `Jamf::Package` and `Jamf::JPackage` will be the same class. At this time please start updating your code to use the non-J version of the class name.
+  - After some long-ish period of time (2-5 years?), the `J` version of the class name will be removed. Or - maybe not! Aliases are cheap :-)
+
+If you have thoughts or comments on this, please reach out:
+  - [Open an issue on github](https://github.com/PixarAnimationStudios/ruby-jss/issues)
+  - [Email the developers at ruby-jss@pixar.com](mailto:ruby-jss@pixar.com)
+  - Join the conversation in the [#ruby-jss Macadmins Slack Channel](https://macadmins.slack.com/archives/C03C7F563MK)
+
+### Added
+  - `Jamf::JPackage`: The first major migration of a class from the Classic to the Jamf Pro API.
+    - Implements the /v1/packages endpoints
+    - Support for manifests
+    - Support for uploads to the /v1/packages/{id}/upload endpoint via the `#upload` method
+    - Implements the /v1/deploy-package endpoint via the `#deploy_via_mdm` instance method. For this to work:
+      - The endpoint must be enabled - contact Jamf Support.
+      - The package must have a manifest
+      - The .pkg file must be a "Product Archive", e.g. it must contain a 'Distribution' file, as when created with the `productbuild` command. Component packages created with `pkgbuild` will not work.
+      - The .pkg file must be signed.
+  
+### Changed
+  - `Jamf::JpBuilding` is now known as `Jamf::JBuilding`
+
+### Fixed
+  - [Github issue #102](https://github.com/PixarAnimationStudios/ruby-jss/issues/102): Apply redundant boolean value to indicate that a MobileDeviceApplication is/is not in Self Service. Thanks @carolinebeauchamp!
+
+  - [Github #103](https://github.com/PixarAnimationStudios/ruby-jss/pull/103) Fixed and issue where linking a mobile device application to VPP failed as the vpp_admin_account_id wasn't included in the XML. Thanks @carolinebeauchamp!
+
+  - [Github #104](https://github.com/PixarAnimationStudios/ruby-jss/pull/104) Add allow_user_to_delete attribute. Thanks @carolinebeauchamp!
+
+  - [Github #105](https://github.com/PixarAnimationStudios/ruby-jss/pull/105) Fix configuration preferences in MobileDeviceApplication. Thanks @carolinebeauchamp!
+
+  - Some lingering method parameter fixes for ruby 3.x compatibility
+
+  - Fix for `Jamf::Group#remove_member`
+
+  - Fixes for `Jamf::Scopable::Scope#set_exclusions`, `#set_limitations` and more.
+
+  - Fix to ensure passing correct connection object when fetching.
+
+### Deprecated
+  - `Jamf::Package` and `Jamf::Building` are now deprecated amd will be removed in a future release. Please update your code to use `Jamf::JBuilding` and `Jamf::JPackage`
+
+  - Auto-generated OAPISchemas are no longer used _directly_. There's still too much inconsistency and other problems that arise from using them as we were. See the NOTE from the previous release. 
+
+    For the forseeable future we'll keep the overall structure of the class/mixin hierarchy, and will probably use the auto-generated classes for reference, but as new classes are added to ruby-jss via the Jamf Pro API, the `OAPISchemas` classes will be hand-tweaked and hand-maintained as needed, just like APIObject classes always have been for objects in the Classic API. 
+
+    To start with, we're keeping the ones currently in use (about 40 of them) where they've always lived, in the `lib/jamf/api/jamf_pro/oapi_schemas` directory, and the new bespoke ones will go there also. The other ~550 unused auto-generated classes will be removed from ruby-jss.  
+    
+    For details about how the've been auto-generated, see the `generate_object_models` tool in the bin directory.
+
 --------
 ## \[4.1.1] 2024-06-25
 
@@ -29,7 +95,6 @@ Many many thanks to actae0n of Blacksun Hackers Club for reporting this issue an
   - A bug in Jamf::PatchTitle which prevented use of non-default connection objects.
   
   - Some ObjectModel classes from the OAPI3 schema were not getting generated, causing problems when using Zeitwerk's `eager_load`. Thanks to @j-o-lantern0422 and @jcruce13 for reporting the issue, and @nick-f for providing a fix!
-
     
     NOTE: Given the nature of this issue, along with known inconsistencies in the data structures and naming of items in the OAPI3 schema, plus the fact that we're starting to migrate to the JP API for more complex object handling (e.g. `Jamf::MobileDevice`)  we're probably going to stop using the auto-generated `Jamf::OAPISchemas` classes - at least in the way we have been using them. Most likely we'll still generate them, but then hand-edit them to create more robust, bespoke classes for the items we implement (as we did in the Classic API), and only include those required for the objects implemented. These changes shouldn't affect compatibility. Feedback is welcome, via GitHub or The [#ruby-jss channel in Macadmins Slack](https://macadmins.slack.com/archives/C03C7F563MK) 
 

data/README.md

@@ -37,7 +37,7 @@ Many many thanks to actae0n of Blacksun Hackers Club for reporting this issue an
 
 - [Version 2.0.0 has been released](#version-200-has-been-released)
   - [Highlights](#highlights)
-- [_IMPORTANT_: Known Security Issue in v1.5.3 and below](#_important_-known-security-issue-in-v153-and-below)
+- [IMPORTANT: Known Security Issue in v1.5.3 and below](#important-known-security-issue-in-v153-and-below)
 - [DESCRIPTION](#description)
 - [SYNOPSIS](#synopsis)
 - [USAGE](#usage)
@@ -479,13 +479,13 @@ Full documentation is available at [rubydoc.info](http://www.rubydoc.info/gems/r
 
 There's a [wiki on the github page](https://github.com/PixarAnimationStudios/ruby-jss/wiki), feel free to contribute examples and tidbits.
 
-If you have questions or feedback about ruby-jss, please reach out  to us via:
+If you have questions or feedback about ruby-jss, please reach out to us via:
 - [Open an issue on github](https://github.com/PixarAnimationStudios/ruby-jss/issues)
 - [Email the developers at ruby-jss@pixar.com](mailto:ruby-jss@pixar.com)
 - Join the conversation in the [#ruby-jss Macadmins Slack Channel](https://macadmins.slack.com/archives/C03C7F563MK)
 
 ## LICENSE
 
-Copyright 2023 Pixar
+Copyright 2025 Pixar
 
 Licensed under a modified Apache License, Version 2.0. See LICENSE.txt for details

data/bin/cgrouper

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/bin/jamfHelperBackgrounder

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/bin/netseg-update

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -275,7 +275,7 @@ Notes:
       @columns.include?(:cidr) || \
       @columns.include?(:mask)
 
-    @use_cidr = (@columns.include?(:cidr) || @columns.include?(:mask))
+    @use_cidr = @columns.include?(:cidr) || @columns.include?(:mask)
   end
 
   def parse_a_data_line(line)

data/data/ruby-jss.conf.example

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/account.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -44,7 +44,7 @@ module Jamf
   #
   class Account < Jamf::APIObject
 
-    # Note: This class is not fully extended and since the resource
+    # NOTE: This class is not fully extended and since the resource
     # is different than the rest, methods like Jamf::Account.all do not work
 
     # Mix-Ins
@@ -104,19 +104,19 @@ module Jamf
     end
 
     # @return [Array<Hash>] all JSS account groups
-    def self.all_groups(refresh = false,  api: nil, cnx: Jamf.cnx)
+    def self.all_groups(refresh = false, api: nil, cnx: Jamf.cnx)
       cnx = api if api
       all(refresh, cnx: cnx)[:groups]
     end
 
     # @return [Array<Hash>] all JSS account group ids
-    def self.all_group_ids(refresh = false,  api: nil, cnx: Jamf.cnx)
+    def self.all_group_ids(refresh = false, api: nil, cnx: Jamf.cnx)
       cnx = api if api
       all(refresh, cnx: cnx)[:groups].map { |i| i[:id] }
     end
 
     # @return [Array<Hash>] all JSS account group names
-    def self.all_group_names(refresh = false,  api: nil, cnx: Jamf.cnx)
+    def self.all_group_names(refresh = false, api: nil, cnx: Jamf.cnx)
       cnx = api if api
       all(refresh, cnx: cnx)[:groups].map { |i| i[:name] }
     end
@@ -161,7 +161,7 @@ module Jamf
       super
 
       # check to see if a user has been specified, haven't built groups yet
-      is_user = [:userid, :username].any? { |key| args.keys.include? key }
+      is_user = %i[userid username].any? { |key| args.keys.include? key }
 
       return unless is_user
 
@@ -171,7 +171,6 @@ module Jamf
       @access_level = @init_data[:access_level]
       @privilege_set = @init_data[:privilege_set]
       @privileges = @init_data[:privileges]
-
     end # initialize
 
   end # class accounts

data/lib/jamf/api/classic/api_objects/advanced_computer_search.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/advanced_mobile_device_search.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -64,7 +64,7 @@ module Jamf
 
     # what data fields come back along with the display fields
     # for each mobiledevices?
-    RESULT_ID_FIELDS = [:id, :name, :udid].freeze
+    RESULT_ID_FIELDS = %i[id name udid].freeze
 
     # the object type for this object in
     # the object history table.

data/lib/jamf/api/classic/api_objects/advanced_user_search.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -64,7 +64,7 @@ module Jamf
 
     # what data fields come back along with the display fields
     # for each user?
-    RESULT_ID_FIELDS = [:id, :name].freeze
+    RESULT_ID_FIELDS = %i[id name].freeze
 
     # the object type for this object in
     # the object history table.

data/lib/jamf/api/classic/api_objects/building.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -38,8 +38,13 @@ module Jamf
   # A Building in the JSS.
   # These are simple, in that they only have an ID and a name.
   #
+  # @deprecated Use {Jamf::JBuiding} instead. This class will be removed in a future release.
+  #
   # @see Jamf::APIObject
   #
+  # For accessing buildings via the Jamf Pro API, see {Jamf::JBuiding}, which
+  # provides access to the other building-related attributes.
+  #
   class Building < Jamf::APIObject
 
     # Mix-Ins

data/lib/jamf/api/classic/api_objects/categorizable.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -109,6 +109,7 @@ module Jamf
     #
     def category_object
       return nil unless category_assigned?
+
       Jamf::Category.fetch id: @category_id
     end # cat obj
 
@@ -175,6 +176,7 @@ module Jamf
     def unset_category
       # no change, go home
       return nil if @category_name.nil?
+
       @category_name = nil
       @category_id = nil
       @need_to_update = true
@@ -220,6 +222,7 @@ module Jamf
     #
     def add_category_to_xml(xmldoc)
       return if category_name.to_s.empty?
+
       cat_elem = REXML::Element.new('category')
 
       if self.class::CATEGORY_DATA_TYPE == String

data/lib/jamf/api/classic/api_objects/category.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -116,7 +116,12 @@ module Jamf
     #
     def priority=(new_val = @priority)
       return nil if new_val == @priority
-      raise Jamf::InvalidDataError, "priority must be an integer between #{POSSIBLE_PRIORITIES.first} and #{POSSIBLE_PRIORITIES.last} (inclusive)" unless POSSIBLE_PRIORITIES.include? new_val
+
+      unless POSSIBLE_PRIORITIES.include? new_val
+        raise Jamf::InvalidDataError, 
+              "priority must be an integer between #{POSSIBLE_PRIORITIES.first} and #{POSSIBLE_PRIORITIES.last} (inclusive)"
+      end
+
       @priority = new_val
       @need_to_update = true
     end

data/lib/jamf/api/classic/api_objects/computer.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/computer_extension_attribute.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/computer_group.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -28,7 +28,6 @@ module Jamf
   # Classes
   #####################################
 
-
   # A computer group in the JSS
   #
   # See also the parent class Jamf::Group
@@ -39,7 +38,6 @@ module Jamf
   #
   class ComputerGroup < Jamf::Group
 
-
     # Mix-Ins
     #####################################
     include Jamf::MDM

data/lib/jamf/api/classic/api_objects/computer_invitation.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -139,7 +139,6 @@ module Jamf
       ssh_username: 'casper_remote',
       hide_account: 'true'
     })
-
       super args
 
       @name = @init_data[:invitation]
@@ -184,9 +183,7 @@ module Jamf
       obj = doc.add_element RSRC_OBJECT_KEY.to_s
       obj.add_element('invitation_type').text = invitation_type
       obj.add_element('create_account_if_does_not_exist').text = create_account_if_does_not_exist
-      if expiration_date_epoch
-        obj.add_element('expiration_date_epoch').text = expiration_date_epoch
-      end
+      obj.add_element('expiration_date_epoch').text = expiration_date_epoch if expiration_date_epoch
       obj.add_element('ssh_username').text = ssh_username
       obj.add_element('hide_account').text = hide_account
       obj.add_element('invitation_status').text = invitation_status

data/lib/jamf/api/classic/api_objects/creatable.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/criteriable/criteria.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -62,7 +62,7 @@ module Jamf
       #####################################
 
       ### Criterion instances we maintain need these attributes.s
-      CRITERION_ATTRIBUTES = [:priority, :and_or, :name, :search_type, :value].freeze
+      CRITERION_ATTRIBUTES = %i[priority and_or name search_type value].freeze
 
       #####################################
       ### Attributes
@@ -95,6 +95,7 @@ module Jamf
         unless new_criteria.is_a?(Array) && new_criteria.reject { |c| c.is_a?(Jamf::Criteriable::Criterion) }.empty?
           raise Jamf::InvalidDataError, 'Argument must be an Array of Jamf::Criteriable::Criterion instances.'
         end
+
         new_criteria.each { |nc| criterion_ok? nc }
         @criteria = new_criteria
         set_priorities
@@ -146,7 +147,7 @@ module Jamf
       ###
       ### @return [void]
       ###
-      def insert_criterion(priority, criterion)
+      def insert_criterion(_priority, criterion)
         criterion_ok? criterion
         @criteria.insert criterion[:priority], criterion
         set_priorities
@@ -163,6 +164,7 @@ module Jamf
       def delete_criterion(priority)
         if @criteria[priority]
           raise Jamf::MissingDataError, "Criteria can't be empty" if @criteria.count == 1
+
           @criteria.delete_at priority
           set_priorities
         end
@@ -182,6 +184,7 @@ module Jamf
       ###
       def set_criterion(priority, criterion)
         raise Jamf::NoSuchItemError, "No current criterion with priority '#{priority}'" unless @criteria[priority]
+
         criterion_ok? criterion
         @criteria[priority] = criterion
         set_priorities
@@ -240,6 +243,7 @@ module Jamf
         raise Jamf::InvalidDataError, "Missing :name for criterion: #{criterion.signature}" unless criterion.name
         raise Jamf::InvalidDataError, "Missing :search_type for criterion: #{criterion.signature}" unless criterion.search_type
         raise Jamf::InvalidDataError, "Missing :value for criterion: #{criterion.signature}" unless criterion.value
+
         true
       end
 

data/lib/jamf/api/classic/api_objects/criteriable/criterion.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -132,6 +132,7 @@ module Jamf
 
         if args[:search_type]
           raise Jamf::InvalidDataError, 'Invalid :search_type' unless SEARCH_TYPES.include? args[:search_type]
+
           @search_type = args[:search_type]
         end
 
@@ -190,6 +191,7 @@ module Jamf
       #
       def search_type=(new_val)
         raise Jamf::InvalidDataError, 'Invalid :search_type' unless SEARCH_TYPES.include? new_val
+
         @search_type = new_val
       end
 

data/lib/jamf/api/classic/api_objects/criteriable.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -187,6 +187,6 @@ module Jamf
       @need_to_update = true if @in_jss
     end
 
-    end # module Criteriable
+  end # module Criteriable
 
 end # module Jamf

data/lib/jamf/api/classic/api_objects/department.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -61,7 +61,7 @@ module Jamf
     #####################################
 
     ### The base for REST resources of this class
-    RSRC_BASE = "departments"
+    RSRC_BASE = 'departments'
 
     ### the hash key used for the JSON list output of all objects in the JSS
     RSRC_LIST_KEY = :departments

data/lib/jamf/api/classic/api_objects/distribution_point.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")
 #    with the following modification; you may not use this file except in
@@ -429,13 +429,14 @@ module Jamf
     def unmount
       return nil unless mounted?
 
-      if system "/sbin/umount '#{@mountpoint}'"
-        sleep 1 # the umount takes time.
-        @mountpoint.rmdir if @mountpoint.directory? && !@mountpoint.mountpoint?
-        @mounted = false
-      else
-        raise Jamf::FileServiceError, "There was a problem unmounting #{@mountpoint}"
-      end
+      raise Jamf::FileServiceError, "There was a problem unmounting #{@mountpoint}" unless system "/sbin/umount '#{@mountpoint}'"
+
+      sleep 1 # the umount takes time.
+      @mountpoint.rmdir if @mountpoint.directory? && !@mountpoint.mountpoint?
+      @mounted = false
+      
+        
+      
       nil
     end # unmount
 

data/lib/jamf/api/classic/api_objects/ebook.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -23,8 +23,6 @@
 ###
 ###
 
-
-#
 module Jamf
 
   # This is just a stub for now.

data/lib/jamf/api/classic/api_objects/extendable.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/ibeacon.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -67,7 +67,7 @@ module Jamf
     OBJECT_HISTORY_OBJECT_TYPE = 360
 
     # The major & minor values, if used, must be in this range
-    MAJOR_MINOR_RANGE = 0..65_535.freeze
+    MAJOR_MINOR_RANGE = 0..65_535
 
     # If not used, this is the value for the major and minor
     MAJOR_MINOR_UNUSED = -1
@@ -101,7 +101,6 @@ module Jamf
       @minor ||= MAJOR_MINOR_UNUSED
     end # init
 
-
     # Public Instance Methods
     #####################################
 
@@ -192,7 +191,6 @@ module Jamf
       doc.to_s
     end # rest_xml
 
-
   end # class ibeacon
 
 end # module