ruby-jss 4.1.1 → 4.2.0

data/lib/jamf/api/classic/api_objects/peripheral_type.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -42,7 +42,7 @@ module Jamf
   ###
   ### @see Jamf::APIObject
   ###
-  class PeripheralType  < Jamf::APIObject
+  class PeripheralType < Jamf::APIObject
 
     #####################################
     ### MixIns
@@ -60,7 +60,7 @@ module Jamf
     #####################################
 
     ### The base for REST resources of this class
-    RSRC_BASE = "peripheraltypes"
+    RSRC_BASE = 'peripheraltypes'
 
     ### the hash key used for the JSON list output of all objects in the JSS
     RSRC_LIST_KEY = :peripheral_types
@@ -69,9 +69,8 @@ module Jamf
     ### It's also used in various error messages
     RSRC_OBJECT_KEY = :peripheral_type
 
-
     ### field types can be one of these, either String or Symbol
-    FIELD_TYPES = [:text, :menu]
+    FIELD_TYPES = %i[text menu]
 
     # the object type for this object in
     # the object history table.
@@ -90,13 +89,13 @@ module Jamf
     ### Initialize
     ###
     def initialize(**args)
-
       super
 
       @fields = []
-      if @init_data[:fields]
-        @init_data[:fields].each{ |f|  @fields[f[:order]] = f }
-      end
+      return unless @init_data[:fields]
+
+      @init_data[:fields].each { |f| @fields[f[:order]] = f }
+      
     end # initialize
 
     ### The definitions of the fields stored for this peripheral type.
@@ -131,9 +130,7 @@ module Jamf
     ###
     ### @return [Array<Hash>] The field definitions
     ###
-    def fields
-      @fields
-    end
+    attr_reader :fields
 
     ###
     ### Replace the entire Array of field definitions.
@@ -144,12 +141,11 @@ module Jamf
     ###
     ### @return [void]
     ###
-    def fields= (new_fields)
-      unless new_fields.kind_of? Array and  new_fields.reject{|c| c.kind_of? Hash }.empty?
-        raise Jamf::InvalidDataError, "Argument must be an Array of Hashes."
-      end
-      raise "A peripheral type can have a maximmum of 20 fields"  if new_fields.count > 20
-      new_fields.each{ |f| field_ok? f }
+    def fields=(new_fields)
+      raise Jamf::InvalidDataError, 'Argument must be an Array of Hashes.' unless new_fields.is_a? Array and new_fields.reject { |c| c.is_a? Hash }.empty?
+      raise 'A peripheral type can have a maximmum of 20 fields' if new_fields.count > 20
+
+      new_fields.each { |f| field_ok? f }
       @fields = new_fields
       order_fields
       @need_to_update = true
@@ -169,6 +165,7 @@ module Jamf
     ###
     def set_field(order, **field)
       raise Jamf::NoSuchItemError, "No field with number '#{order}'. Use #append_field, #prepend_field, or #insert_field" unless @fields[order]
+
       field_ok? field
       @fields[order] = field
       @need_to_update = true
@@ -213,7 +210,7 @@ module Jamf
     ###
     def insert_field(order, **field)
       field_ok? field
-      @fields.insert((order -1), field)
+      @fields.insert((order - 1), field)
       order_fields
       @need_to_update = true
     end
@@ -226,15 +223,14 @@ module Jamf
     ### @return [void]
     ###
     def delete_field(order)
-      if @fields[order]
-        raise Jamf::MissingDataError, "Fields can't be empty" if @fields.count == 1
-        @fields.delete_at index
-        order_fields
-        @need_to_update = true
-      end
-    end
-
+      return unless @fields[order]
+      raise Jamf::MissingDataError, "Fields can't be empty" if @fields.count == 1
 
+      @fields.delete_at index
+      order_fields
+      @need_to_update = true
+      
+    end
 
     ##############################
     ### private methods
@@ -246,13 +242,13 @@ module Jamf
     ### Return true or raise an exception
     ###
     def field_ok?(field)
-      raise Jamf::InvalidDataError, "Field elements must be hashes with :name, :type, and possibly :choices" unless field.kind_of? Hash
-      raise Jamf::InvalidDataError, "Fields require names" if field[:name].to_s.empty?
+      raise Jamf::InvalidDataError, 'Field elements must be hashes with :name, :type, and possibly :choices' unless field.is_a? Hash
+      raise Jamf::InvalidDataError, 'Fields require names' if field[:name].to_s.empty?
       raise Jamf::InvalidDataError, "Fields :type must be one of: :#{FIELD_TYPES.join(', :')}" unless FIELD_TYPES.include? field[:type].to_sym
 
       if field[:type].to_sym == :menu
-        unless field[:choices].kind_of? Array and  field[:choices].reject{|c| c.kind_of? String}.empty?
-          raise Jamf::InvalidDataError, "Choices for menu fields must be an Array of Strings"
+        unless field[:choices].is_a? Array and field[:choices].reject { |c| c.is_a? String }.empty?
+          raise Jamf::InvalidDataError, 'Choices for menu fields must be an Array of Strings'
         end # unless
       else
         field[:choices] = []
@@ -265,11 +261,10 @@ module Jamf
     ###
     def order_fields
       @fields.compact!
-      @fields.each_index{|i| @fields[i][:order] = i+1}
+      @fields.each_index { |i| @fields[i][:order] = i + 1 }
       @fields.unshift nil
     end
 
-
     ###
     ###
     ###
@@ -281,19 +276,18 @@ module Jamf
       pkg.add_element('name').text = @name
       fields = pkg.add_element 'fields'
 
-      flds =  @fields.compact
+      flds = @fields.compact
       flds.each_index do |i|
         field = fields.add_element 'field'
-        field.add_element('order').text =flds[i][:order]
+        field.add_element('order').text = flds[i][:order]
         field.add_element('name').text = flds[i][:name]
         field.add_element('type').text = flds[i][:type].to_s
         choices = field.add_element('choices')
-        unless flds[i][:choices].empty?
-          flds[i][:choices].each{|c| choices.add_element('choice').text = c}
-        end
+        flds[i][:choices].each { |c| choices.add_element('choice').text = c } unless flds[i][:choices].empty?
       end # each index do i
-      return doc.to_s
+      doc.to_s
     end # rest xml
 
   end # class Peripheral
+
 end # module

data/lib/jamf/api/classic/api_objects/policy.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")

data/lib/jamf/api/classic/api_objects/purchasable.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -70,7 +70,7 @@ module Jamf
 
     PURCHASABLE = true
 
-    SUBSET_PURCH = "Purchasing"
+    SUBSET_PURCH = 'Purchasing'
 
     #####################################
     ###  Variables
@@ -116,118 +116,125 @@ module Jamf
     ### @return [Time]
     attr_reader :warranty_expires
 
-
     #####################################
     ###  Mixed-in Instance Methods
     #####################################
 
-
-
-
     ### @return [void]
-    def applecare_id= (new_val)
+    def applecare_id=(new_val)
       return nil if @applecare_id == new_val
+
       @applecare_id = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def is_leased= (new_val)
+    def is_leased=(new_val)
       return nil if @is_leased == new_val
+
       @is_leased = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def lease_expires= (date)
+    def lease_expires=(date)
       parsed_date = Jamf.parse_time date
       return nil if @lease_expires == parsed_date
+
       @lease_expires = parsed_date
       @need_to_update = true
     end
 
     ### @return [void]
-    def is_purchased= (new_val)
+    def is_purchased=(new_val)
       return nil if @is_purchased == new_val
+
       @is_purchased = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def purchase_price= (new_val)
+    def purchase_price=(new_val)
       return nil if @purchase_price == new_val
+
       @purchase_price = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def life_expectancy= (new_val)
+    def life_expectancy=(new_val)
       return nil if @life_expectancy == new_val
+
       @life_expectancy = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def po_number= (new_val)
+    def po_number=(new_val)
       return nil if @po_number == new_val
+
       @po_number = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def po_date= (date)
+    def po_date=(date)
       parsed_date = Jamf.parse_time date
       return nil if @po_date == parsed_date
+
       @po_date = parsed_date
       @need_to_update = true
     end
 
     ### @return [void]
-    def purchasing_account= (new_val)
+    def purchasing_account=(new_val)
       return nil if @purchasing_account == new_val
+
       @purchasing_account = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def purchasing_contact= (new_val)
+    def purchasing_contact=(new_val)
       return nil if @purchasing_contact == new_val
+
       @purchasing_contact = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def vendor= (new_val)
+    def vendor=(new_val)
       return nil if @vendor == new_val
+
       @vendor = new_val
       @need_to_update = true
     end
 
     ### @return [void]
-    def warranty_expires= (date)
+    def warranty_expires=(date)
       parsed_date = Jamf.parse_time date
       return nil if @warranty_expires == parsed_date
+
       @warranty_expires = parsed_date
       @need_to_update = true
     end
 
-
     ###
     ### @return [Boolean] does this item have any purchasing info?
     ###
     def has_purchasing?
       @applecare_id or \
-      @is_leased or \
-      @is_purchased or \
-      @lease_expires or \
-      @life_expectancy or \
-      @po_date or \
-      @po_number or \
-      @purchase_price or \
-      @purchasing_account or \
-      @purchasing_contact or \
-      @vendor or \
-      @warranty_expires
+        @is_leased or \
+        @is_purchased or \
+        @lease_expires or \
+        @life_expectancy or \
+        @po_date or \
+        @po_number or \
+        @purchase_price or \
+        @purchasing_account or \
+        @purchasing_contact or \
+        @vendor or \
+        @warranty_expires
     end
 
     ###
@@ -239,18 +246,18 @@ module Jamf
     ###
     def purchasing
       {
-        :applecare_id => @applecare_id,
-        :is_leased => @is_leased,
-        :is_purchased => @is_purchased,
-        :lease_expires => @lease_expires,
-        :life_expectancy => @life_expectancy,
-        :po_date => @po_date,
-        :po_number => @po_number,
-        :purchase_price => @purchase_price,
-        :purchasing_account => @purchasing_account,
-        :purchasing_contact => @purchasing_contact,
-        :vendor => @vendor,
-        :warranty_expires => @warranty_expires,
+        applecare_id: @applecare_id,
+        is_leased: @is_leased,
+        is_purchased: @is_purchased,
+        lease_expires: @lease_expires,
+        life_expectancy: @life_expectancy,
+        po_date: @po_date,
+        po_number: @po_number,
+        purchase_price: @purchase_price,
+        purchasing_account: @purchasing_account,
+        purchasing_contact: @purchasing_contact,
+        vendor: @vendor,
+        warranty_expires: @warranty_expires
       }
     end
 
@@ -267,9 +274,9 @@ module Jamf
 
       @purchasing = @init_data[:purchasing]
 
-      @lease_expires = JSS.epoch_to_time  @purchasing[:lease_expires_epoch]
-      @po_date = JSS.epoch_to_time  @purchasing[:po_date_epoch]
-      @warranty_expires = JSS.epoch_to_time  @purchasing[:warranty_expires_epoch]
+      @lease_expires = JSS.epoch_to_time @purchasing[:lease_expires_epoch]
+      @po_date = JSS.epoch_to_time @purchasing[:po_date_epoch]
+      @warranty_expires = JSS.epoch_to_time @purchasing[:warranty_expires_epoch]
 
       @applecare_id = @purchasing[:applecare_id]
       @is_leased = @purchasing[:is_leased]
@@ -296,7 +303,7 @@ module Jamf
       purch.add_element('is_purchased').text = @is_purchased.to_s
       purch.add_element('lease_expires_epoch').text = @lease_expires ? @lease_expires.to_jss_epoch : nil
       # Note, life expectancy can't be an empty xml element, it must be zero if emtpy.
-      purch.add_element('life_expectancy').text = @life_expectancy ? @life_expectancy : 0
+      purch.add_element('life_expectancy').text = @life_expectancy || 0
       purch.add_element('po_date_epoch').text = @po_date ? @po_date.to_jss_epoch : nil
       purch.add_element('po_number').text = @po_number
       purch.add_element('purchase_price').text = @purchase_price
@@ -304,7 +311,7 @@ module Jamf
       purch.add_element('purchasing_contact').text = @purchasing_contact
       purch.add_element('vendor').text = @vendor
       purch.add_element('warranty_expires_epoch').text = @warranty_expires ? @warranty_expires.to_jss_epoch : nil
-      return purch
+      purch
     end
 
     ### Aliases
@@ -312,4 +319,5 @@ module Jamf
     alias purchased? is_purchased
 
   end # module Purchasable
+
 end # module Jamf

data/lib/jamf/api/classic/api_objects/removable_macaddr.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -45,7 +45,7 @@ module Jamf
   ###
   ### @see Jamf::APIObject
   ###
-  class RemovableMacAddress  < Jamf::APIObject
+  class RemovableMacAddress < Jamf::APIObject
 
     #####################################
     ### Mix-Ins
@@ -57,13 +57,12 @@ module Jamf
     ### Class Methods
     #####################################
 
-
     #####################################
     ### Class Constants
     #####################################
 
     ### The base for REST resources of this class
-    RSRC_BASE = "removablemacaddresses"
+    RSRC_BASE = 'removablemacaddresses'
 
     ### the hash key used for the JSON list output of all objects in the JSS
     RSRC_LIST_KEY = :removable_mac_addresses

data/lib/jamf/api/classic/api_objects/restricted_software.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")
@@ -140,6 +140,7 @@ module Jamf
     def site=(new_val)
       if new_val.is_a? Integer
         raise Jamf::NoSuchItemError, "No site found with id #{new_val}" unless Jamf::Site.all_ids(cnx: @cnx).include? new_val
+
         new_val = Jamf::Site.map_all_ids_to(:name, cnx: @cnx)[new_val]
       else
         new_val = new_val.to_s
@@ -151,12 +152,15 @@ module Jamf
 
     def create
       raise Jamf::MissingDataError, 'process_name must be set before creating' if @process_name.to_s.empty?
-      raise Jamf::AlreadyExistsError, "A #{RSRC_OBJECT_KEY} named #{@name} already exists in the JSS" if self.class.all_names(:refresh, cnx: @cnx).include? @name
+      raise Jamf::AlreadyExistsError, "A #{RSRC_OBJECT_KEY} named #{@name} already exists in the JSS" if self.class.all_names(:refresh, 
+                                                                                                                              cnx: @cnx).include? @name
+
       super
     end
 
     def update
       raise Jamf::MissingDataError, 'process_name must be set before updating' if @process_name.to_s.empty?
+
       super
     end
 

data/lib/jamf/api/classic/api_objects/scopable/scope.rb

@@ -1,4 +1,4 @@
-# Copyright 2023 Pixar
+# Copyright 2025 Pixar
 
 #    Licensed under the Apache License, Version 2.0 (the "Apache License")
 #    with the following modification; you may not use this file except in
@@ -608,7 +608,7 @@ module Jamf
         raise Jamf::InvalidDataError, "List must be an Array of #{key} identifiers, it may be empty." unless list.is_a? Array
 
         # check the idents
-        list.map! do |ident|
+        list_of_ids = list.map do |ident|
           item_id = validate_item(:target, key, ident)
 
           if @exclusions[key]&.include?(item_id)
@@ -619,9 +619,9 @@ module Jamf
           item_id
         end # each
 
-        return nil if list.sort == @targets[key].sort
+        return nil if list_of_ids.sort == @targets[key].sort
 
-        @targets[key] = list
+        @targets[key] = list_of_ids
         @all_targets = false
         note_pending_changes
       end # sinclude_in_scope
@@ -726,7 +726,7 @@ module Jamf
         raise Jamf::InvalidDataError, "List must be an Array of #{key} identifiers, it may be empty." unless list.is_a? Array
 
         # check the idents
-        list.map! do |ident|
+        list_of_ids = list.map do |ident|
           item_id = validate_item(:limitation, key, ident)
           if @exclusions[key]&.include?(item_id)
             raise Jamf::AlreadyExistsError, "Can't set #{key} limitation for '#{name}' because it's already an explicit exclusion."
@@ -735,9 +735,9 @@ module Jamf
           item_id
         end # each
 
-        return nil if list.sort == @limitations[key].sort
+        return nil if list_of_ids.sort == @limitations[key].sort
 
-        @limitations[key] = list
+        @limitations[key] = list_of_ids
         note_pending_changes
       end # set_limitation
       alias set_limitation set_limitations
@@ -812,24 +812,26 @@ module Jamf
         raise Jamf::InvalidDataError, "List must be an Array of #{key} identifiers, it may be empty." unless list.is_a? Array
 
         # check the idents
-        list.map! do |ident|
+        list_of_ids = list.map do |ident|
           item_id = validate_item(:exclusion, key, ident)
           case key
           when *@target_keys
-            if @targets[key] && @exclusions[key].include?(item_id)
-              raise Jamf::AlreadyExistsError, "Can't exclude #{key} '#{ident}' because it's already explicitly included."
+            if @targets[key]&.include?(item_id)
+              msg = "Can't exclude #{key} '#{ident}' because it's already explicitly included."
+              raise Jamf::AlreadyExistsError, msg
             end
           when *LIMITATIONS
-            if @limitations[key] && @exclusions[key].include?(item_id)
-              raise Jamf::AlreadyExistsError, "Can't exclude #{key} '#{ident}' because it's already an explicit limitation."
+            if @limitations[key]&.include?(item_id)
+              msg = "Can't exclude #{key} '#{ident}' because it's already an explicit limitation."
+              raise Jamf::AlreadyExistsError, msg
             end
           end
           item_id
         end # each
 
-        return nil if list.sort == @exclusions[key].sort
+        return nil if list_of_ids.sort == @exclusions[key].sort
 
-        @exclusions[key] = list
+        @exclusions[key] = list_of_ids
         note_pending_changes
       end # set_exclusion
       alias set_exclusion set_exclusions

data/lib/jamf/api/classic/api_objects/scopable.rb

@@ -1,4 +1,4 @@
-### Copyright 2023 Pixar
+### Copyright 2025 Pixar
 
 ###
 ###    Licensed under the Apache License, Version 2.0 (the "Apache License")