ruby-jss 2.1.0b4 → 2.1.0b5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a00af3813560fa65f8597fc6a516d1b9933eb333f2aee3478646df1f93a45b9
-  data.tar.gz: 892e4f5ed6b7271c55377671ff13ccb7778a51b34d57b9da67086cd95ec7d0ca
+  metadata.gz: 3e4edfd42bf486020f780c565948d0b6de6db11413eaaf2f5a486243d8137a76
+  data.tar.gz: 0c3b1e370c9f1ffdcf97f7174b0dbc508f3c414efc5a86a0b5b09e0c42ba4e3f
 SHA512:
-  metadata.gz: 6461d576566cfd365c77ff36758a8c9558deb2bad8936b87be03f12dd3c7f7662734ec2eaaa7f1f4b5b83c9bb0264c9e06609c2f8f0ef20106d3c8db8be45484
-  data.tar.gz: 30a9a4dcf60a9aa0a25c4a64429e34f1f8cf6cf9609f80c94b675c0e498f74f46f3fc0842fab2d20ed248f0a792c2349a7373a273905ec45c3994b3b6f4fc3eb
+  metadata.gz: 7fd967954cc7642ec10054fff0c2d75f3dd30bce1836baf158a1fb4abe4f5d8a95ca493e9c1ef2b03fe1490874fdbf3f42b81af46389c7a86a6a73bdaeb867c2
+  data.tar.gz: f806304ae8b9fad9fae2ffc35b77681a26cf2bfd63dc202b5a52f25b43e2e278fda62321f05e0c3f47a6e063238b5eda86ec870814a971fb13e7631ecfa04f5a

data/CHANGES.md

@@ -18,21 +18,22 @@ Many many thanks to actae0n of Blacksun Hackers Club for reporting this issue an
 
 ### Added
 
-  - Support for the `/v1/jamf-management-framework/redeploy/{id}` Jamf Pro API endpoint in `Jamf::Computer` and 
+  - Support for the `/v1/jamf-management-framework/redeploy/{id}` Jamf Pro API endpoint in `Jamf::Computer` and
   `Jamf::ComputerGroup`. The method `redeploy_mgmt_framework` is both a Class and an Instance method for those classes
     - The instance method sends the redeployment to the single computer or all the members of the single computer group.
-    - The class method accepts a single id, or an array of ids.  
+    - The class method accepts a single id, or an array of ids.
       - When using `Jamf::Computer.redeploy_mgmt_framework` provide computer ids
       - When using `Jamf::ComputerGroup.redeploy_mgmt_framework` provide group ids, and all members of all groups will get
         the redeployment
-  - In all cases the result is a Hash of target computer ids (keys) and result value for each (Strings).
-    -  The result is either the UUID of the sent MDM command, or an error message if the MDM command couldn't be sent.
-  - All the code is in the `Jamf::MacOSRedeployMgmtFramework` module, q.v. in the [rubydoc documentation](https://www.rubydoc.info/gems/ruby-jss/Jamf/MacOSRedeployMgmtFramework)
+    - In all cases the result is a Hash of target computer ids (keys) and result value for each (Strings).
+      -  The result is either the UUID of the sent MDM command, or an error message if the MDM command couldn't be sent.
+    - All the code is in the `Jamf::MacOSRedeployMgmtFramework` module, q.v. in the [rubydoc documentation](https://www.rubydoc.info/gems/ruby-jss/Jamf/MacOSRedeployMgmtFramework)
 
 ### Fixed
 
   - A few internal rescues of a deprecated exception class
   - Removed auto-loading of deprecation files; now explicitly loaded.
+  - A few Ruby 2 => Ruby 3 bugs - method params needing double-splats (Thanks to @Timelost for reporting this one)
 
 ## \[2.0.0] - 2022-09-12
 

data/bin/cgrouper

@@ -23,10 +23,8 @@
 ###    KIND, either express or implied. See the Apache License for the specific
 ###    language governing permissions and limitations under the Apache License.
 
-
 # Create or change the membership of a computer group in the JSS
 
-
 # Load in the JSS library
 require 'jss-api'
 
@@ -44,9 +42,9 @@ class App
        [-S server] [-U user] [-T timeout] [-V] [--debug]
        group [-f /file/path ] [computer [computer ...]]"
 
-  ACTIONS_NEEDING_GROUP = [ :create_group, :rename_group, :delete_group, :add_members, :remove_members, :remove_all, :list_members]
+  ACTIONS_NEEDING_GROUP = %i[create_group rename_group delete_group add_members remove_members remove_all list_members]
 
-  ACTIONS_FOR_STATIC_GROUPS_ONLY = [:create_group, :add_members, :remove_members, :remove_all]
+  ACTIONS_FOR_STATIC_GROUPS_ONLY = %i[create_group add_members remove_members remove_all]
 
   #####################################
   ### Attributes
@@ -57,31 +55,30 @@ class App
   ###
   ### set up
   ###
-  def initialize(args)
-
+  def initialize(**_args)
     @debug = false
 
     # define the options
     cli_opts = GetoptLong.new(
-      [ '--help', '-h', '-H', GetoptLong::NO_ARGUMENT ],
-      [ '--list-groups', '-L',  GetoptLong::NO_ARGUMENT ],
-      [ '--list-static', '-s',  GetoptLong::NO_ARGUMENT ],
-      [ '--list-smart', '-m',  GetoptLong::NO_ARGUMENT ],
-      [ '--create-group', '--create', '-c', GetoptLong::NO_ARGUMENT ],
-      [ '--rename-group', '--rename', '-n', GetoptLong::REQUIRED_ARGUMENT ],
-      [ '--delete-group', '--delete', '-d', GetoptLong::NO_ARGUMENT ],
-      [ '--list-members', '--list-computers', '-l', GetoptLong::NO_ARGUMENT ],
-      [ '--add-members', '--add', '-a', GetoptLong::NO_ARGUMENT ],
-      [ '--remove-members', '--remove', '-r', GetoptLong::NO_ARGUMENT ],
-      [ '--remove-all-members', '-R', GetoptLong::NO_ARGUMENT ],
-      [ '--file', '-f', GetoptLong::REQUIRED_ARGUMENT ],
-      [ '--server', '-S', GetoptLong::OPTIONAL_ARGUMENT],
-      [ '--port', '-P', GetoptLong::OPTIONAL_ARGUMENT],
-      [ '--user', '-U', GetoptLong::OPTIONAL_ARGUMENT],
-      [ '--no-verify-cert', '-V', GetoptLong::NO_ARGUMENT],
-      [ '--timeout', '-T', GetoptLong::OPTIONAL_ARGUMENT],
-      [ '--no-confirm', '-C', GetoptLong::NO_ARGUMENT],
-      [ '--debug', GetoptLong::NO_ARGUMENT]
+      ['--help', '-h', '-H', GetoptLong::NO_ARGUMENT],
+      ['--list-groups', '-L',  GetoptLong::NO_ARGUMENT],
+      ['--list-static', '-s',  GetoptLong::NO_ARGUMENT],
+      ['--list-smart', '-m', GetoptLong::NO_ARGUMENT],
+      ['--create-group', '--create', '-c', GetoptLong::NO_ARGUMENT],
+      ['--rename-group', '--rename', '-n', GetoptLong::REQUIRED_ARGUMENT],
+      ['--delete-group', '--delete', '-d', GetoptLong::NO_ARGUMENT],
+      ['--list-members', '--list-computers', '-l', GetoptLong::NO_ARGUMENT],
+      ['--add-members', '--add', '-a', GetoptLong::NO_ARGUMENT],
+      ['--remove-members', '--remove', '-r', GetoptLong::NO_ARGUMENT],
+      ['--remove-all-members', '-R', GetoptLong::NO_ARGUMENT],
+      ['--file', '-f', GetoptLong::REQUIRED_ARGUMENT],
+      ['--server', '-S', GetoptLong::OPTIONAL_ARGUMENT],
+      ['--port', '-P', GetoptLong::OPTIONAL_ARGUMENT],
+      ['--user', '-U', GetoptLong::OPTIONAL_ARGUMENT],
+      ['--no-verify-cert', '-V', GetoptLong::NO_ARGUMENT],
+      ['--timeout', '-T', GetoptLong::OPTIONAL_ARGUMENT],
+      ['--no-confirm', '-C', GetoptLong::NO_ARGUMENT],
+      ['--debug', GetoptLong::NO_ARGUMENT]
     )
 
     # here's where we hold cmdline args and other user options
@@ -92,68 +89,68 @@ class App
 
     # if stdin is not a tty, then we must assume
     # we're being passed a password
-    @options.getpass =  $stdin.tty? ? :prompt : :stdin
+    @options.getpass = $stdin.tty? ? :prompt : :stdin
 
     # parse the options
     cli_opts.each do |opt, arg|
       case opt
-        when '--help'
-          show_help
+      when '--help'
+        show_help
 
-        when '--list-groups'
-          @options.action = :list_groups
+      when '--list-groups'
+        @options.action = :list_groups
 
-        when '--list-static'
-          @options.action = :list_static
+      when '--list-static'
+        @options.action = :list_static
 
-        when '--list-smart'
-          @options.action = :list_smart
+      when '--list-smart'
+        @options.action = :list_smart
 
-        when '--list-members'
-          @options.action = :list_members
+      when '--list-members'
+        @options.action = :list_members
 
-        when '--create-group'
-          @options.action = :create_group
+      when '--create-group'
+        @options.action = :create_group
 
-        when '--rename-group'
-          @options.action = :rename_group
-          @options.new_name = arg
+      when '--rename-group'
+        @options.action = :rename_group
+        @options.new_name = arg
 
-        when '--delete-group'
-          @options.action = :delete_group
+      when '--delete-group'
+        @options.action = :delete_group
 
-        when '--add-members'
-          @options.action = :add_members
+      when '--add-members'
+        @options.action = :add_members
 
-        when '--remove-members'
-          @options.action = :remove_members
+      when '--remove-members'
+        @options.action = :remove_members
 
-        when '--remove-all-members'
-          @options.action = :remove_all
+      when '--remove-all-members'
+        @options.action = :remove_all
 
-        when '--file'
-          @options.input_file = Pathname.new arg
+      when '--file'
+        @options.input_file = Pathname.new arg
 
-        when '--server'
-          @options.server = arg
+      when '--server'
+        @options.server = arg
 
-        when '--port'
-          @options.port = arg
+      when '--port'
+        @options.port = arg
 
-        when '--user'
-          @options.user = arg
+      when '--user'
+        @options.user = arg
 
-        when '--no-verify-cert'
-          @options.verify_cert = false
+      when '--no-verify-cert'
+        @options.verify_cert = false
 
-        when '--timeout'
-          @options.timeout = arg
+      when '--timeout'
+        @options.timeout = arg
 
-        when '--no-confirm'
-          @options.no_confirm = true
+      when '--no-confirm'
+        @options.no_confirm = true
 
-        when '--debug'
-          @debug = true
+      when '--debug'
+        @debug = true
 
       end # case
     end # opts.each
@@ -168,17 +165,13 @@ class App
 
     # will we say anything when finished?
     @done_msg = nil
-
   end # init
 
-
-
   #####################################
   ###
   ### Do It
   ###
   def run
-
     if @options.action == :none
       puts USAGE
       return
@@ -188,75 +181,73 @@ class App
     @options.user ||= JSS::CONFIG.api_username
     @options.server ||= JSS::CONFIG.api_server_name
 
-    raise JSS::MissingDataError, "No JSS Username provided or found in the JSS gem config." unless @options.user
-    raise JSS::MissingDataError, "No JSS Server provided or found in the JSS gem config." unless @options.server
-
-    Jamf.cnx.connect( :server => @options.server,
-      :port => @options.port,
-      :verify_cert => @options.verify_cert,
-      :user => @options.user,
-      :pw => @options.getpass,
-      :stdin_line => 1,
-      :timeout => @options.timeout
-    )
+    raise JSS::MissingDataError, 'No JSS Username provided or found in the JSS gem config.' unless @options.user
+    raise JSS::MissingDataError, 'No JSS Server provided or found in the JSS gem config.' unless @options.server
 
+    Jamf.cnx.connect(server: @options.server,
+                     port: @options.port,
+                     verify_cert: @options.verify_cert,
+                     user: @options.user,
+                     pw: @options.getpass,
+                     stdin_line: 1,
+                     timeout: @options.timeout)
 
     if ACTIONS_NEEDING_GROUP.include? @options.action
 
-      raise JSS::MissingDataError, "Please specify a group name" unless @options.group
+      raise JSS::MissingDataError, 'Please specify a group name' unless @options.group
 
-     # get the group from the API
-      if @options.action == :create_group
-        @group = JSS::ComputerGroup.make :name => @options.group, :type => :static
-      else
-        @group = JSS::ComputerGroup.fetch :name => @options.group
-      end
+      # get the group from the API
+      @group = if @options.action == :create_group
+                 JSS::ComputerGroup.make name: @options.group, type: :static
+               else
+                 JSS::ComputerGroup.fetch name: @options.group
+               end
 
     end # if ACTIONS_NEEDING_GROUP
 
     # smart groups can't have some things done to them
-    raise InvalidTypeError, "You can't do that to a smart group. Use the JSS WebApp if needed." if ACTIONS_FOR_STATIC_GROUPS_ONLY.include? @options.action and @group.smart?
-
+    if ACTIONS_FOR_STATIC_GROUPS_ONLY.include? @options.action and @group.smart?
+      raise InvalidTypeError, 
+            "You can't do that to a smart group. Use the JSS WebApp if needed."
+    end
 
     case @options.action
 
-      when :list_groups
-        list_groups
+    when :list_groups
+      list_groups
 
-      when :list_static
-        list_groups :static
+    when :list_static
+      list_groups :static
 
-      when :list_smart
-        list_groups :smart
+    when :list_smart
+      list_groups :smart
 
-      when :list_members
-        list_members
+    when :list_members
+      list_members
 
-      when :create_group
-        create_group
+    when :create_group
+      create_group
 
-      when :rename_group
-        rename_group
+    when :rename_group
+      rename_group
 
-      when :delete_group
-        delete_group
+    when :delete_group
+      delete_group
 
-      when :add_members
-        add_members
+    when :add_members
+      add_members
 
-      when :remove_members
-        remove_members
+    when :remove_members
+      remove_members
 
-      when :remove_all
-        remove_all
+    when :remove_all
+      remove_all
 
     end # case @options.action
 
     puts "Done! #{@done_msg}" if @done_msg
-
   end # run
 
-
   #####################################
   ###
   ### Show Help
@@ -307,7 +298,6 @@ Notes:
    (spaces, tabs, & returns in any number or combination)
 
     FULLHELP
-
   end
 
   #####################################
@@ -316,21 +306,21 @@ Notes:
   ###
   def list_groups(show = :all)
     case show
-      when :all
-        label = "All"
-        groups_to_show = JSS::ComputerGroup.all
-      when :static
-        label = "Static"
-        groups_to_show = JSS::ComputerGroup.all_static
-      when :smart
-        label = "Smart"
-        groups_to_show = JSS::ComputerGroup.all_smart
-    end #case
+    when :all
+      label = 'All'
+      groups_to_show = JSS::ComputerGroup.all
+    when :static
+      label = 'Static'
+      groups_to_show = JSS::ComputerGroup.all_static
+    when :smart
+      label = 'Smart'
+      groups_to_show = JSS::ComputerGroup.all_smart
+    end # case
 
     puts "# #{label} computer groups in the JSS"
-    puts "#---------------------------------------------"
+    puts '#---------------------------------------------'
 
-    groups_to_show.sort{|a,b| a[:name].downcase <=> b[:name].downcase}.each do |grp|
+    groups_to_show.sort { |a, b| a[:name].downcase <=> b[:name].downcase }.each do |grp|
       puts grp[:name]
     end
   end
@@ -341,30 +331,26 @@ Notes:
   ###
   def list_members
     puts "# All members of JSS #{@group.smart? ? 'smart' : 'static'} computer group '#{@options.group}'"
-    puts "#--- name (id) ---------------------------------"
+    puts '#--- name (id) ---------------------------------'
 
     # put them into a tmp array, so that
     # we can sort by computer name, remembering that
     # there can be duplicate names.
     list = []
-    @group.members.each{|mem| list << "#{mem[:name]} (#{mem[:id]})" }
-    puts list.sort #.join("\n")
+    @group.members.each { |mem| list << "#{mem[:name]} (#{mem[:id]})" }
+    puts list.sort # .join("\n")
   end
 
-
   #####################################
   ###
   ### Create a new group
   ###
   def create_group
-
     return unless confirm "create a new static group named '#{@options.group}'"
-    @group.create
 
-    unless @options.computers.empty?
-      add_members
-    end
+    @group.create
 
+    add_members unless @options.computers.empty?
   end
 
   #####################################
@@ -373,36 +359,36 @@ Notes:
   ###
   def rename_group
     return unless confirm "rename group '#{@group.name}' to '#{@options.new_name}'"
+
     @group.name = @options.new_name
     @group.update
   end
 
-
   #####################################
   ###
   ### delete a group
   ###
   def delete_group
     return unless confirm "DELETE group '#{@group.name}'"
+
     @group.delete
   end
 
-
   #####################################
   ###
   ### add members to a group
   ###
   def add_members
-    raise JSS::MissingDataError, "No computer names provided" if @options.computers.empty?
+    raise JSS::MissingDataError, 'No computer names provided' if @options.computers.empty?
     raise JSS::UnsupportedError, "Smart group members can't be changed." if @group.smart?
     return unless @options.action == :create_group or confirm "add computers to group '#{@group.name}'"
 
     @options.computers.each do |c|
-      begin
-        @group.add_member c
-      rescue JSS::NoSuchItemError
-        puts "#{$!} - skipping"
-      end # begin
+      
+      @group.add_member c
+    rescue JSS::NoSuchItemError
+      puts "#{$!} - skipping"
+      # begin
     end # each
 
     @group.update
@@ -413,15 +399,16 @@ Notes:
   ### remove members from a group
   ###
   def remove_members
-    raise JSS::MissingDataError, "No computer names provided" if @options.computers.empty?
+    raise JSS::MissingDataError, 'No computer names provided' if @options.computers.empty?
     raise JSS::UnsupportedError, "Smart group members can't be changed." if @group.smart?
     return unless confirm "remove computers from group '#{@group.name}'"
+
     @options.computers.each do |c|
-      begin
-        @group.remove_member c
-      rescue JSS::NoSuchItemError
-        puts "#{$!} - skipping"
-      end
+      
+      @group.remove_member c
+    rescue JSS::NoSuchItemError
+      puts "#{$!} - skipping"
+      
     end
     @group.update
   end
@@ -433,11 +420,11 @@ Notes:
   def remove_all
     raise JSS::UnsupportedError, "Smart group members can't be changed." if @group.smart?
     return unless confirm "remove ALL computers from group '#{@group.name}'"
+
     @group.clear
     @group.update
   end
 
-
   #####################################
   ###
   ### Read computer names from a file
@@ -448,6 +435,7 @@ Notes:
   def get_computers_from_file
     raise JSS::NoSuchItemError "File #{@options.input_file} isn't a file or isn't readable." unless \
       @options.input_file.file? and @options.input_file.readable?
+
     @options.input_file.read.split(/\s+/)
   end
 
@@ -456,31 +444,26 @@ Notes:
   ### Get confirmation before doing something
   ### Returns true or false
   ###
-  def confirm (action)
-      return true if @options.no_confirm
+  def confirm(action)
+    return true if @options.no_confirm
 
-      print "Really #{action}? (y/n): "
-      $stdin.reopen '/dev/tty'
-      reply = $stdin.gets.strip
-      return true if reply =~ /^y/i
-      return false
+    print "Really #{action}? (y/n): "
+    $stdin.reopen '/dev/tty'
+    reply = $stdin.gets.strip
+    return true if reply =~ /^y/i
 
+    false
   end # confirm
 
-
 end # class App
 
 #######################################
 begin
   app = App.new(ARGV)
   app.run
-
 rescue
   # handle exceptions not handled elsewhere
   puts "An error occurred: #{$!}"
-  puts "Backtrace:" if app.debug
+  puts 'Backtrace:' if app.debug
   puts $@ if app.debug
-
-ensure
-
 end

data/bin/jamfHelperBackgrounder

@@ -53,7 +53,7 @@ class App
 
   # Set up
   #
-  def initialize(args)
+  def initialize(**args)
     if args.include? '-help'
       @help = true
       return
@@ -66,6 +66,7 @@ class App
 
       wintype_idx = args.index { |a| a == WIN_TYPE_PARAM }
       raise 'missing option: -windowType' unless wintype_idx
+
       args.delete_at wintype_idx
       @window_type = args.delete_at(wintype_idx).to_sym
 
@@ -93,6 +94,7 @@ class App
 
     if @as_user
       raise 'Only root can do things as another user' unless JSS.superuser?
+
       cmd = ['su', '-l', @as_user, '-c', "#{Shellwords.escape __FILE__} #{@arg_string}"]
       exec(*cmd)
     end
@@ -134,7 +136,7 @@ This command takes all the same commandline options as jamfHelper, plus these:
 WARNING: You shouldn't run this command directly as a launchd job. Rather
 you should write a small script that runs this command, and use launchd
 to run that.
-ENDHELP
+    ENDHELP
   end # show help
 
 end # app

data/lib/jamf/api/classic/api_objects/mobile_device_application.rb

@@ -194,7 +194,7 @@ module Jamf
     #
     # See Jamf::APIObject#initialize
     #
-    def initialize(args)
+    def initialize(**args)
       super
       general = @init_data[:general]
       @display_name = general[:display_name]

data/lib/jamf/version.rb

@@ -27,6 +27,6 @@
 module Jamf
 
   ### The version of ruby-jss
-  VERSION = '2.1.0b4'.freeze
+  VERSION = '2.1.0b5'.freeze
 
 end # module

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-jss
 version: !ruby/object:Gem::Version
-  version: 2.1.0b4
+  version: 2.1.0b5
 platform: ruby
 authors:
 - Chris Lasell
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-09-15 00:00:00.000000000 Z
+date: 2022-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: CFPropertyList