ruby-jss 2.0.0a11 → 2.0.0b5

data/lib/jamf/client/management_action.rb

@@ -31,7 +31,7 @@ module Jamf
 
     #  Module for working with the Management Action.app, which is an interface
     # to the Notification Center
-    # This should be extended into Jamf::Client
+    # This should be included into Jamf::Client
     #####################################
     module ManagementAction
 
@@ -43,67 +43,77 @@ module Jamf
       # MGMT_ACTION_BUNDLE_ID = 'com.jamfsoftware.Management-Action'.freeze
       # HUP_NOTIF_CTR_CMD = '/usr/bin/killall sighup usernoted NotificationCenter'.freeze
 
+      # when this module is included, also extend our Class Methods
+      def self.included(includer)
+        Jamf.load_msg "--> #{includer} is including Jamf::Client::ManagementAction"
+        includer.extend(ClassMethods)
+      end
+
       # class Methods
       #####################################
 
-      def management_action(msg, title: nil, subtitle: nil, delay: 0)
-        raise Jamf::InvalidDataError, 'delay: must be a non-negative integer.' unless delay.is_a?(Integer) && delay > -1
+      module ClassMethods
 
-        cmd = Shellwords.escape MGMT_ACTION.to_s
-        cmd << " -message #{Shellwords.escape msg.to_s}"
-        cmd << " -title #{Shellwords.escape title.to_s}" if title
-        cmd << " -subtitle #{Shellwords.escape subtitle.to_s}" if subtitle
-        cmd << " -deliverydelay #{Shellwords.escape delay}" if delay > 0
-        `#{cmd} 2>&1`
-      end
-      alias nc_notify management_action
-
-      # Skipping all the force-alerts stuff until we figure out cleaner
-      # ways to do it in 10.13+
-      # The plan is to be able to make the NotificationCenter notification be an
-      # 'alert' (which stays visible til the user clicks) or a
-      # 'banner' (which vanishes in a few seconds), regardless of the user's
-      # setting in the NC prefs.
-
-      def force_alerts
-        orig_flags = {}
-        console_users.each do |user|
-          orig_flags[user] = set_mgmt_action_ncprefs_flags user, NC_ALERT_STYLE_FLAGS, hup: false
+        def management_action(msg, title: nil, subtitle: nil, delay: 0)
+          raise Jamf::InvalidDataError, 'delay: must be a non-negative integer.' unless delay.is_a?(Integer) && delay > -1
+
+          cmd = Shellwords.escape MGMT_ACTION.to_s
+          cmd << " -message #{Shellwords.escape msg.to_s}"
+          cmd << " -title #{Shellwords.escape title.to_s}" if title
+          cmd << " -subtitle #{Shellwords.escape subtitle.to_s}" if subtitle
+          cmd << " -deliverydelay #{Shellwords.escape delay}" if delay > 0
+          `#{cmd} 2>&1`
+        end
+        alias nc_notify management_action
+
+        # Skipping all the force-alerts stuff until we figure out cleaner
+        # ways to do it in 10.13+
+        # The plan is to be able to make the NotificationCenter notification be an
+        # 'alert' (which stays visible til the user clicks) or a
+        # 'banner' (which vanishes in a few seconds), regardless of the user's
+        # setting in the NC prefs.
+
+        def force_alerts
+          orig_flags = {}
+          console_users.each do |user|
+            orig_flags[user] = set_mgmt_action_ncprefs_flags user, NC_ALERT_STYLE_FLAGS, hup: false
+          end
+          system HUP_NOTIF_CTR_CMD unless orig_flags.empty?
+          sleep 1
+          orig_flags
         end
-        system HUP_NOTIF_CTR_CMD unless orig_flags.empty?
-        sleep 1
-        orig_flags
-      end
 
-      def restore_alerts(orig_flags)
-        orig_flags.each do |user, flags|
-          set_mgmt_action_ncprefs_flags user, flags, hup: false
+        def restore_alerts(orig_flags)
+          orig_flags.each do |user, flags|
+            set_mgmt_action_ncprefs_flags user, flags, hup: false
+          end
+          system HUP_NOTIF_CTR_CMD unless orig_flags.empty?
         end
-        system HUP_NOTIF_CTR_CMD unless orig_flags.empty?
-      end
 
-      # set the NotificationCenter option flags for a user
-      # flags = an integer.
-      #
-      # Doesn't seem to work in 10.13, so ignore this for now.
-      #
-      # @return [Integer] the original flags, or given flags if no originals.
-      #
-      def set_mgmt_action_ncprefs_flags(user, flags, hup: true)
-        plist = Pathname.new "/Users/#{user}/Library/Preferences/#{NCPREFS_DOMAIN}.plist"
-        prefs = JSS.parse_plist plist
-        mgmt_action_setting = prefs['apps'].select { |a| a['bundle-id'] == MGMT_ACTION_BUNDLE_ID }.first
-        if mgmt_action_setting
-          orig_flags = mgmt_action_setting['flags']
-          mgmt_action_setting['flags'] = flags
-        else
-          orig_flags = flags
-          prefs['apps'] << { 'bundle-id' => MGMT_ACTION_BUNDLE_ID, 'flags' => flags }
+        # set the NotificationCenter option flags for a user
+        # flags = an integer.
+        #
+        # Doesn't seem to work in 10.13, so ignore this for now.
+        #
+        # @return [Integer] the original flags, or given flags if no originals.
+        #
+        def set_mgmt_action_ncprefs_flags(user, flags, hup: true)
+          plist = Pathname.new "/Users/#{user}/Library/Preferences/#{NCPREFS_DOMAIN}.plist"
+          prefs = JSS.parse_plist plist
+          mgmt_action_setting = prefs['apps'].select { |a| a['bundle-id'] == MGMT_ACTION_BUNDLE_ID }.first
+          if mgmt_action_setting
+            orig_flags = mgmt_action_setting['flags']
+            mgmt_action_setting['flags'] = flags
+          else
+            orig_flags = flags
+            prefs['apps'] << { 'bundle-id' => MGMT_ACTION_BUNDLE_ID, 'flags' => flags }
+          end
+          plist.open('w') { |f| f.write JSS.xml_plist_from(prefs) }
+          system HUP_NOTIF_CTR_CMD if hup
+          orig_flags
         end
-        plist.open('w') { |f| f.write JSS.xml_plist_from(prefs) }
-        system HUP_NOTIF_CTR_CMD if hup
-        orig_flags
-      end
+
+      end # ClassMethods
 
     end # moculde
 

data/lib/jamf/client.rb

@@ -64,9 +64,9 @@ module Jamf
     # the path to a users byhost folder from home
     USER_PREFS_BYHOST_FOLDER = 'Library/Preferences/ByHost/'.freeze
 
-    extend Jamf::Client::JamfBinary
-    extend Jamf::Client::JamfHelper
-    extend Jamf::Client::ManagementAction
+    include Jamf::Client::JamfBinary
+    include Jamf::Client::JamfHelper
+    include Jamf::Client::ManagementAction
 
     # Class Methods
     #####################################

data/lib/jamf/deprecations/deprecated_api_connection_class.rb

@@ -0,0 +1,29 @@
+# Copyright 2022 Pixar
+
+#
+#    Licensed under the Apache License, Version 2.0 (the "Apache License")
+#    with the following modification; you may not use this file except in
+#    compliance with the Apache License and the following modification to it:
+#    Section 6. Trademarks. is deleted and replaced with:
+#
+#    6. Trademarks. This License does not grant permission to use the trade
+#       names, trademarks, service marks, or product names of the Licensor
+#       and its affiliates, except as required to comply with Section 4(c) of
+#       the License and to reproduce the content of the NOTICE file.
+#
+#    You may obtain a copy of the Apache License at
+#
+#        http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the Apache License with the above modification is
+#    distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#    KIND, either express or implied. See the Apache License for the specific
+#    language governing permissions and limitations under the Apache License.
+
+# @deprecated Use class Jamf::Connection
+module Jamf
+
+  APIConnection = Connection
+
+end

data/lib/jamf/deprecations/deprecated_api_constant.rb

@@ -22,4 +22,6 @@
 #    language governing permissions and limitations under the Apache License.
 
 # @deprecated Use Jamf.cnx to access the module-wide default connection
-Jamf::API = Jamf.cnx
+module Jamf
+  API = Jamf.cnx
+end

data/lib/jamf/deprecations/deprecated_config_constant.rb

@@ -22,4 +22,6 @@
 #    language governing permissions and limitations under the Apache License.
 
 # @deprecated Use Jamf.config to access the module-wide config settings
-Jamf::CONFIG = Jamf.config
+module Jamf
+  CONFIG = Jamf.config
+end

data/lib/jamf/version.rb

@@ -27,6 +27,6 @@
 module Jamf
 
   ### The version of ruby-jss
-  VERSION = '2.0.0a11'.freeze
+  VERSION = '2.0.0b5'.freeze
 
 end # module

data/lib/jamf/zeitwerk_config.rb

@@ -0,0 +1,217 @@
+# Copyright 2022 Pixar
+
+#
+#    Licensed under the Apache License, Version 2.0 (the "Apache License")
+#    with the following modification; you may not use this file except in
+#    compliance with the Apache License and the following modification to it:
+#    Section 6. Trademarks. is deleted and replaced with:
+#
+#    6. Trademarks. This License does not grant permission to use the trade
+#       names, trademarks, service marks, or product names of the Licensor
+#       and its affiliates, except as required to comply with Section 4(c) of
+#       the License and to reproduce the content of the NOTICE file.
+#
+#    You may obtain a copy of the Apache License at
+#
+#        http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the Apache License with the above modification is
+#    distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+#    KIND, either express or implied. See the Apache License for the specific
+#    language governing permissions and limitations under the Apache License.
+
+# Gems
+######
+
+require 'zeitwerk'
+
+# Jamf's Zeitwerk Config and processes
+module JamfZeitwerkConfig
+
+  # touch this file to make zeitwerk and mixins send text to stderr as things load
+  # or get mixed in
+  VERBOSE_LOADING_FILE = Pathname.new('/tmp/ruby-jss-verbose-loading')
+
+  # Or, set this ENV var to also make zeitverk and mixins send text to stderr
+  VERBOSE_LOADING_ENV = 'RUBY_JSS_VERBOSE_LOADING'
+
+  # touch this file to make zeitwek  eager-load everything when the gem is required.
+  EAGER_LOAD_FILE = Pathname.new('/tmp/ruby-jss-zeitwerk-eager-load')
+
+  # Only look at the filesystem once.
+  def self.verbose_loading?
+    return @verbose_loading unless @verbose_loading.nil?
+
+    @verbose_loading = VERBOSE_LOADING_FILE.file?
+    @verbose_loading ||= ENV.include? VERBOSE_LOADING_ENV
+    @verbose_loading
+  end
+  
+  # rubocop: disable Style/StderrPuts
+  def self.load_msg(msg)
+    $stderr.puts msg if verbose_loading?    
+  end
+  # rubocop: enable Style/StderrPuts
+        
+  # The loader object for Xolo
+  def self.loader
+    @loader
+  end
+    
+  # Configure the Zeitwerk loader, See https://github.com/fxn/zeitwerk
+  def self.setup_zeitwerk_loader(zloader)
+    @loader = zloader
+
+    # Ignore this file (more ignores below)
+    loader.ignore __FILE__
+
+    ##### Collaped Paths
+    
+    # these paths all define classes & modules directly below 'Jamf'
+    # If we didn't collapse them, then e.g.
+    #   /jamf/api/base_classes/classic/group.rb
+    # would be expected to define
+    #   Jamf::Api::BaseClasses::Classic::Group
+    # rather than what we want:
+    #  Jamf::Group
+    ###################################################
+
+    loader.collapse("#{__dir__}/api")
+
+    loader.collapse("#{__dir__}/api/classic")
+    loader.collapse("#{__dir__}/api/classic/api_objects")
+    loader.collapse("#{__dir__}/api/classic/base_classes")
+
+    loader.collapse("#{__dir__}/api/jamf_pro")
+    loader.collapse("#{__dir__}/api/jamf_pro/api_objects")
+    loader.collapse("#{__dir__}/api/jamf_pro/mixins")
+    loader.collapse("#{__dir__}/api/jamf_pro/base_classes")
+    loader.collapse("#{__dir__}/api/jamf_pro/other_classes")
+
+    loader.collapse("#{__dir__}/deprecations")
+
+    ##### Inflected Paths
+    
+    # filenames => Constants, which don't adhere to zeitwerk's parsing standards.
+    #
+    # Mostly because the a filename like 'oapi_object' would be
+    # loaded by zeitwerk expecting it to define 'OapiObject', but it really
+    # defines 'OAPIObject'
+    ###############################################
+
+    # Connections
+    loader.inflector.inflect 'classic_api' => 'ClassicAPI'
+    loader.inflector.inflect 'jamf_pro_api' => 'JamfProAPI'
+    loader.inflector.inflect 'jamf_pro_api_error' => 'JamfProAPIError'
+
+    # API objects, resources, and mixins
+    loader.inflector.inflect 'oapi_schemas' => 'OAPISchemas'
+    loader.inflector.inflect 'oapi_object' => 'OAPIObject'
+    loader.inflector.inflect 'oapi_validate' => 'OAPIValidate'
+
+    loader.inflector.inflect 'jpapi_resource' => 'JPAPIResource'
+
+    loader.inflector.inflect 'api_object' => 'APIObject'
+    loader.inflector.inflect 'xml_workaround' => 'XMLWorkaround'
+    loader.inflector.inflect 'json_object' => 'JSONObject'
+    loader.inflector.inflect 'vppable' => 'VPPable'
+    loader.inflector.inflect 'osx_configuration_profile' => 'OSXConfigurationProfile'
+    loader.inflector.inflect 'jp_extendable' => 'JPExtendable'
+    loader.inflector.inflect 'mdm' => 'MDM'
+    loader.inflector.inflect 'ibeacon' => 'IBeacon'
+    loader.inflector.inflect 'powerbroker_identity_services' => 'PowerBroker'
+    loader.inflector.inflect 'admitmac' => 'ADmitMac'
+    loader.inflector.inflect 'ip_address' => 'IPAddress'
+    loader.inflector.inflect 'netboot_server' => 'NetBootServer'
+    loader.inflector.inflect 'vpp_account' => 'VPPAccount'
+    loader.inflector.inflect 'removable_macaddr' => 'RemovableMacAddress'
+    loader.inflector.inflect 'md_prestage_name' => 'MobileDevicePrestageName'
+    loader.inflector.inflect 'md_prestage_names' => 'MobileDevicePrestageNames'
+    loader.inflector.inflect 'md_prestage_skip_setup_items' => 'MobileDevicePrestageSkipSetupItems'
+    loader.inflector.inflect 'macos_managed_updates' => 'MacOSManagedUpdates'
+
+    # deprecations, separated so they load only when used.
+    # When its time to get rid of them, delete the files from the 
+    # 'deprecations' directory, and the matching line here.
+    loader.inflector.inflect('deprecated_api_constant' => 'API')
+    loader.inflector.inflect('deprecated_config_constant' => 'CONFIG')
+    loader.inflector.inflect('deprecated_api_connection_class' => 'APIConnection')
+
+    ##### Ingored Paths
+    
+    # These should be ignored, some will be required directly
+    #####################################
+
+    loader.ignore "#{__dir__}/db_connection.rb"
+    loader.ignore "#{__dir__}/ruby_extensions.rb"
+    loader.ignore "#{__dir__}/ruby_extensions"
+    loader.ignore "#{__dir__}/exceptions.rb"
+
+    lib_dir = Pathname.new(__dir__).parent.to_s
+    loader.ignore "#{lib_dir}/ruby-jss.rb" 
+    loader.ignore "#{lib_dir}/jss.rb" 
+    loader.ignore "#{lib_dir}/jss-api.rb" 
+    
+    ##### Callbacks
+
+    # callback for when a specific file/constant loads
+    # duplicate and uncomment this if desired to react to 
+    # specific things loading 
+    #####################################
+    # loader.on_load('Jamf::SomeClass') do |klass, abspath|
+    #   Jamf.load_msg "I just loaded #{klass} from #{abspath}"
+    # end
+
+    # callback for when anything loads
+    #  - const_path is like "Jamf::SomeClass" or "Jamf::SomeClass::SOME_CONST_ARRY"
+    #  - value is the value that constant contains after loading,
+    #    e.g. the class Jamf::SomeClass for 'Jamf::SomeClass' or
+    #    an Array for the constant  "Jamf::SomeClass::SOME_CONST_ARRY"
+    #  - abspath is the full path to the file where the constant was loaded from.
+    #####################################
+    loader.on_load do |const_path, value, abspath|
+      load_msg "Zeitwerk just loaded #{value.class} '#{const_path}' from:\n  #{abspath}"
+
+      # Parse OAPI_PROPERTIES into getters and setters for subclasses of
+      # OAPIObject in the JPAPI.
+      #
+      # The class we just loaded must have this method and constant
+      # and the method must not have run already for the class or any superclass.
+      # This prevents running parse_oapi_properties again in subclasses that
+      # don't need to do that
+      if value.respond_to?(:oapi_properties_parsed?) && \
+         defined?(value::OAPI_PROPERTIES) && \
+         !value.oapi_properties_parsed?
+
+        parsed = value.parse_oapi_properties
+        load_msg "Parsed OAPI_PROPERTIES for #{value}" if parsed
+      end
+
+      # Generate the identifier list methods (.all_*) for subclasses of APIObject
+      # in the Classic API
+      if value.is_a?(Class) && value.superclass == Jamf::APIObject
+
+        done = value.define_identifier_list_methods
+        load_msg "Defined identifier list methods for #{value}" if done
+      end
+    end
+
+    loader.setup
+  end # setup_zeitwerk_loader
+
+  # For testing the Zeitwrk Loader.
+  # Normally we want autoloading on demand,
+  # eager loading loads everything so we can see it
+  #
+  # To make this happen touch the file defined in EAGER_LOAD_FILE
+  def self.eager_load_for_testing
+    return unless EAGER_LOAD_FILE.file?
+
+    loader.eager_load(force: true)
+    warn :loaded
+    # rescue Zeitwerk::NameError => e
+    #   warn e.message
+  end
+
+end # module JamfZeitwerkConfig

data/lib/jamf.rb

@@ -54,49 +54,20 @@ require 'jamf/exceptions'
 require 'jamf/db_connection'
 
 # Configure the Zeitwerk loader, See https://github.com/fxn/zeitwerk
-require 'zeitwerk'
-require 'zeitwerk_config'
-
-# touch this file to make zeitwerk and mixins send text to stderr as things load
-# or get mixed in
-JAMF_VERBOSE_LOADING_FILE = Pathname.new('/tmp/ruby-jss-verbose-loading')
-
-# Or, set this ENV var to also make zeitverk and mixins send text to stderr
-JAMF_VERBOSE_LOADING_ENV = 'RUBY_JSS_VERBOSE_LOADING'.freeze
-
-# touch this file to make zeitwek  eager-load everything when the gem is required.
-JAMF_ZEITWERK_EAGER_LOAD_FILE = Pathname.new('/tmp/ruby-jss-zeitwerk-eager-load')
+require 'jamf/zeitwerk_config'
 
 # the `Zeitwerk::Loader.for_gem` creates the loader object, and must
 # happen in this file, so we pass it into a method defined in
 # zeitwerk_config
-setup_zeitwerk_loader Zeitwerk::Loader.for_gem
+JamfZeitwerkConfig.setup_zeitwerk_loader Zeitwerk::Loader.for_gem
 
 # Jamf, A Ruby module for interacting with the JAMF Pro Server via both of its REST APIs
 module Jamf
 
-  def self.validate_ruby_version
-    return if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new(MINIMUM_RUBY_VERSION)
-
-    raise "Can't use ruby-jss #{Jamf::VERSION}, ruby itself must be version #{MINIMUM_RUBY_VERSION} or greater, this is ruby #{RUBY_VERSION}."
-  end
-
-  # Only look at the filesystem once.
-  def self.verbose_loading?
-    return @verbose_loading unless @verbose_loading.nil?
-
-    @verbose_loading = JAMF_VERBOSE_LOADING_FILE.file?
-    @verbose_loading ||= ENV.include? JAMF_VERBOSE_LOADING_ENV
-    @verbose_loading
-  end
-
-  # rubocop: disable Style/StderrPuts
+  # Use the load_msg method defined for Zeitwerk
   def self.load_msg(msg)
-    return unless verbose_loading?
-
-    $stderr.puts msg
-  end
-  # rubocop: enable Style/StderrPuts
+    JamfZeitwerkConfig.load_msg msg
+  end  
 
   # the single instance of our configuration object
   def self.config
@@ -113,11 +84,8 @@ module Jamf
 
 end # module Jamf
 
-# make sure we can run
-Jamf.validate_ruby_version
-
 # JSS module is now a synonym for Jamf module
 JSS = Jamf
 
-# testing zeitwerk loading
-eager_load_for_testing if JAMF_ZEITWERK_EAGER_LOAD_FILE.file?
+# testing zeitwerk loading, the the desired file is present
+JamfZeitwerkConfig.eager_load_for_testing 

data/test/{README.md → README-TEST.md}

@@ -47,6 +47,9 @@ Want to test with a different version of ruby? Change the #! line of the `runtes
 
  - The individual tests are methods in classes defined in files in the 'tests' directory adjacent to this file.
  - In general, each class test a matching ruby-jss class, usually an APIObject (classic) or JPAPIResource (jamf pro).
+ - Shared code is in modules defined in the 'jamf_test' directory. See those files for more info. E.g.
+   - 'collection_tests.rb' defines common tests for all collection-resources
+   - 'prestage_tests.rb' defines common tests for 'computer_prestage' and 'mobile_device_prestage'
 
 **WARNING**: **DANGER DANGER** Be very careful about running these tests on your production Jamf Pro server!!!
 

data/test/bin/runtests

@@ -29,6 +29,40 @@ require 'pathname'
 require 'getoptlong'
 require 'ruby-jss'
 
+# Debug Trace support, Ideas from
+# https://gist.github.com/bendilley/1453a555e981ed533f68
+# and the other gist and stack overflow mentioned there.
+####################################
+
+# Enable tracing to help debug stack level too deep errors
+$do_tracing = false
+
+# set this to true to save the call traces to a file
+$save_trace = false
+
+# the file to hold the traces
+$trace_out = open('/tmp/ruby-jss-tests-trace.txt', 'w')
+
+# the max call-stack depth - adjust this to help catch and 
+# debug SystemStackError exceptions
+$trace_max_call_stack_depth = 1000
+
+# the tracing proc
+set_trace_func proc { |event, file, line, id, _binding, classname|
+  if $do_tracing
+    begin
+      if event == 'call'
+        $trace_out.puts "#{file}:#{line} #{classname}##{id}" if $save_trace 
+        raise 'MaxCallStackReached' if caller_locations.length > $trace_max_call_stack_depth
+      end
+    rescue => e
+      warn "ERROR: #{e.class}: #{e}"
+      e.backtrace.each { |l| warn "..#{l}" }
+      exit 1
+    end
+  end # if
+}
+
 # app
 class App
 
@@ -62,8 +96,8 @@ class App
     @testsdir = @appdir + 'tests'
 
     @tests_to_run = ARGV.dup
-    @tests_to_run = @testsdir.children.map { |c| c.basename.to_s }.sort if @tests_to_run .empty?
-    @tests_to_run.delete_if { |t| t.start_with? '.'}
+    @tests_to_run = @testsdir.children.map { |c| c.basename.to_s }.sort if @tests_to_run.empty?
+    @tests_to_run.delete_if { |t| t.start_with? '.' }
 
     @minitest_opts = ['--verbose']
 
@@ -126,6 +160,7 @@ class App
 
   ###################################
   def run_tests
+    puts
     JamfTest.say "Starting tests of ruby-jss v#{Jamf::VERSION}, using ruby version #{RUBY_VERSION}"
     JamfTest.say "API Connection: #{Jamf.cnx}; Server running Jamf Pro #{Jamf.cnx.jamf_version}"
 
@@ -158,6 +193,7 @@ class App
   ###################################
   def show_help
     return false unless @show_help
+
     puts <<-USAGEBLURB
 Usage: #{File.basename __FILE__} [options] [spec [spec ...]]
 
@@ -209,6 +245,10 @@ if $PROGRAM_NAME == __FILE__
     app = App.new
     app.run
     exit 0
+  rescue SystemStackError
+    puts $!
+    puts caller[0..100]
+    exit 1
   rescue => e
     puts "ERROR #{e.class}: #{e}"
     puts e.backtrace

data/test/lib/jamf_test/collection_tests.rb

@@ -176,11 +176,11 @@ module JamfTest
       say "Ran #{collection_class}.all_ids"
       validate_array ids, item_class: id_class
 
-
       identifiers.each do |ident|
         next if ident == :id
 
         mth = ident.to_s.end_with?('s') ? "all_#{ident}es" : "all_#{ident}s"
+        say "Testing #{collection_class}.#{mth}"
         collection_class.send mth
         say "Ran #{collection_class}.#{mth}"
       end
@@ -196,7 +196,6 @@ module JamfTest
       cached_ids = collection_class.all_ids cached_list: @cached_all
       say "Ran #{collection_class}.all_ids cached_list: @cached_all"
       validate_array cached_ids, item_class: id_class
-
     end
 
     #################
@@ -223,7 +222,6 @@ module JamfTest
 
       validate_hash ids_to_other
       validate_array ids_to_other.keys, item_class: id_class
-
     end
 
     ################
@@ -250,7 +248,6 @@ module JamfTest
 
       validate_hash ids_to_other
       validate_array ids_to_other.keys, item_class: id_class
-
     end
 
     ################
@@ -265,7 +262,9 @@ module JamfTest
       id, other = ids_to_other_ident.to_a.sample
 
       valid_id = collection_class.valid_id other
-      raise "#{collection_class} id #{id}, has #{other_ident} '#{other}', but calling .valid_id('#{other}') returned id: #{valid_id}" unless id.to_s == valid_id.to_s
+      unless id.to_s == valid_id.to_s
+        raise "#{collection_class} id #{id}, has #{other_ident} '#{other}', but calling .valid_id('#{other}') returned id: #{valid_id}"
+      end
 
       say "#{collection_class}.valid_id for #{other_ident} '#{other}' returned the correct id"
     end
@@ -284,13 +283,11 @@ module JamfTest
     ########### Object Tests
     ####################################
 
-
     # override this if the class requires more than 'name' with .create
     ################
     def create_new
       @unsaved_new_object = collection_class.create name: test_object_name
       say "Created new #{collection_class}, to be saved in Jamf."
-
     end
 
     # override this if your class can take more than 'name'