ruby-jss 0.11.0a6 → 0.11.0b1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 738e376502016631097bea927398750c1606a6f4
-  data.tar.gz: 9a82556c928e8cca44b4e37cd663b5959f9c774b
+  metadata.gz: ad7f8bb660801869ee8f70a9ae78a872c7b99296
+  data.tar.gz: 9a06851981b20938d10811b002821bfff9e5fa4d
 SHA512:
-  metadata.gz: 4b309bc27a8314a2b588678d056760acfcf68abc9b75c4044c0c53c669a57b9b20750acce2a5837dc37d838a9a3b6f28ed8966018a8df48394e5245672a2166f
-  data.tar.gz: 0d5ba01aef444d7e3a24a877b6a9de341a01fce551f9362f850de49bf5a8e2691af8e610e9ae82b14be30e59c2112a882ba432b51fd19b8e94a1d70544650049
+  metadata.gz: a61ae7382fa4ff8eba62f55b6ac31d46b9f6950e221563bcbb9ffd33ec36cdde578000e6bf73ccda72ff069da60737d41adb274a9e5bb74b007f115d368ea6e9
+  data.tar.gz: 40500cab943728f7b057583cb62501f8049307a0b17afc774cf62c4f9ed1eb4e2b41fd72d912501588de0253f3981321b28f05d6b2ad4273ba73916f10caa4af

data/CHANGES.md

@@ -1,6 +1,6 @@
 # Change History
 
-## v 0.11.0, 2018-02-19
+## v 0.11.0b1, 2018-02-19
 
 - Improvement: Updated general attributes for computers and mobile devices
 
@@ -18,6 +18,8 @@
 
 - Improvement: All handling of MDM commands is in the JSS::MDM module, which is mixed in to Computer, ComputerGroup, MobileDevice, and MobileDeviceGroup
 
+  *WARNING* Due to the expanded functionality of MDM commands overall, the syntax for calling .send_mdm_command may have changed, depening on how you used it. Please test your code before updating.
+
 - Fix: Scope objects use the api connection of their container
 
 - Improvement: 'devmode', use `JSS.devmode \[:on|:off]`` to set, and `JSS.devmode?`` to query.  Useful for developers, esp. in `irb` who want, e.g. to have a method output some state when in devmode, instead of/as well as behaving normally. This is currently the case for `JSS::MDM.send_mdm_command`.  When devmode? is true, the XML sent to the API for the command is printed to stdout before the command is sent to the target machine.
@@ -37,7 +39,7 @@
 
   For example, the {JSS::MobileDevice.audit_history} method returns an Array of JSS::ManagementHistory::AuditEvent instances,  and the
   {JSS::Computer.completed_policies} gives an Array of JSS::ManagementHistory::PolicyLog objects. These objects are read-only and
-  provide access to their values via attribute-style methods.
+  provide access to their values via attribute-style methods, and hash-like keys, similar to how OpenStruct objects do.
 
   As with MDM command handling, and computer app usage and mgmt data, the work is done by class methods, so that the data is available without creating instances of the Computers or MobileDevices, and the instance methods just
   call the class methods.
@@ -45,6 +47,11 @@
   *WARNING* these changes mean that the methods returning Arrays of ManagementHistory class instances are not backward compatible,
   since the earlier versions returned Hashes
 
+- Deprecated: The JSS::APIConnection convenience class methods .computer_history, .send_computer_mdm_command, and .send_computer_mdm_command.
+
+  These methods have been updated to work with the new methods in the MDM and ManagementHistory modules, but will be removed from JSS::APIConnection in a future release. Instead, call them directly from the JSS::Computer or JSS::MobileDevice classes, passing in the desired APIConnection if needed. Given the expansion of MDM commands and history details, maintaining the convenience methods in APIConnection is too prone to errors.
+
+
 ## v 0.10.2, 2018-02-16
 
 -  *IMPORTANT BUG FIX*: Updating JSS::Extendable objects with no changes to ext. attribs will no longer erase all ext attrib values. (!)

data/lib/jss/api_connection.rb

@@ -253,13 +253,10 @@ module JSS
   #   (if the object is {Matchable})
   # - {#fetch} retrieve an object from the JSS
   # - {#make} instantiate an object to be created in the JSS
-  # - {#send_computer_mdm_command} same as {Computer.send_mdm_command}
   # - {#computer_checkin_settings} same as {Computer.checkin_settings}
   # - {#computer_inventory_collection_settings} same as {Computer.inventory_collection_settings}
   # - {#computer_application_usage} same as {Computer.application_usage}
   # - {#computer_management_data} same as {Computer.management_data}
-  # - {#computer_history} same as {Computer.history}
-  # - {#send_mobiledevice_mdm_command} same as {MobileDevice.send_mdm_command}
   # - {#master_distribution_point} same as {DistributionPoint.master_distribution_point}
   # - {#my_distribution_point} same as {DistributionPoint.my_distribution_point}
   # - {#network_ranges} same as {NetworkSegment.network_ranges}
@@ -781,15 +778,22 @@ module JSS
     # Call {JSS::Computer.history} q.v., passing this API
     # connection
     #
+    # @deprecated Please use JSS::Computer.management_history or its
+    #   convenience methods. @see JSS::ManagementHistory
+    #
     def computer_history(ident, subset: nil)
-      JSS::Computer.history ident, subset: subset, api: self
+      JSS::Computer.history ident, subset, api: self
     end
 
     # Call {JSS::Computer.send_mdm_command} q.v.,  passing this API
     # connection
     #
+    # @deprecated Please use JSS::Computer.send_mdm_command or its
+    #   convenience methods. @see JSS::MDM
+    #
     def send_computer_mdm_command(targets, command, passcode = nil)
-      JSS::Computer.send_mdm_command targets, command, passcode, api: self
+      opts = passcode ? { passcode: passcode } : {}
+      JSS::Computer.send_mdm_command targets, command, opts: opts, api: self
     end
 
     # Get the DistributionPoint instance for the master
@@ -888,8 +892,11 @@ module JSS
     #
     # see {JSS::MobileDevice.send_mdm_command}
     #
-    def send_mobiledevice_mdm_command(targets, command, data = nil)
-      JSS::MobileDevice.send_mdm_command(targets, command, data, api: self)
+    # @deprecated Please use JSS::MobileDevice.send_mdm_command or its
+    #   convenience methods. @see JSS::MDM
+    #
+    def send_mobiledevice_mdm_command(targets, command, data = {})
+      JSS::MobileDevice.send_mdm_command(targets, command, opts: data, api: self)
     end
 
     # Remove the various cached data

data/lib/jss/api_object/management_history/hashlike.rb

@@ -6,15 +6,15 @@ module JSS
 
     # This is mixed in to the history event classes to
     # provide hash-like access to their attributes, so that
-    #    `some_event[:date_time]`
+    #    some_event[:date_time]
     # works the same as
-    #     `some_event.date_time`
+    #     some_event.date_time
     # just as with OpenStruct objects
     #
     module HashLike
 
       def [](attr)
-        self.send attr.to_sym
+        send attr.to_sym
       end
 
     end # HashLike

data/lib/jss/api_object/mdm.rb

@@ -450,6 +450,15 @@ module JSS
           targets.each { |group_id| target_ids += fetch(id: group_id).member_ids }
           targets = target_ids
         end
+
+        # make sure all of them are managed, or else the API will raise a 400
+        # 'Bad Request' when sending the command to an unmanaged target
+        all_mgd = self.map_all_ids_to(:managed).select { |_id, mgd| mgd }.keys
+
+        targets.each do |target_id|
+          raise JSS::UnmanagedError, "#{self} with id #{target_id} is not managed. Cannot send command." unless all_mgd.include? target_id
+        end
+
         targets
       end
 

data/lib/jss/version.rb

@@ -27,6 +27,6 @@
 module JSS
 
   ### The version of the JSS ruby gem
-  VERSION = '0.11.0a6'.freeze
+  VERSION = '0.11.0b1'.freeze
 
 end # module

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-jss
 version: !ruby/object:Gem::Version
-  version: 0.11.0a6
+  version: 0.11.0b1
 platform: ruby
 authors:
 - Chris Lasell
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-16 00:00:00.000000000 Z
+date: 2018-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: plist