ruby-ipmitool 0.4.1 → 0.5

data/lib/ruby-ipmitool.rb

@@ -29,10 +29,10 @@ class Ipmitool
 
   #Instantiates a new Ipmitool object.  Takes a hash containing :host, :user, and :password.
   #
-  #Ex: Ipmitool.new(:host => '192.168.1.1', :user => 'username', :password => 'password')
+  #Ex: Ipmitool.new(:host => '192.168.1.1', :user => 'username', :password => 'password', :optional => {})
   def initialize(conn = {})
     conn[:check_host] ||= true
-    raise ArgumentError, "Wrong number of arguments" if conn.count != 4
+    raise ArgumentError, "Wrong number of arguments" if conn.count < 4
     raise ArgumentError, "Host is required" if conn[:host].nil?
     raise ArgumentError, "User is required" if conn[:user].nil?
     raise ArgumentError, "Password is required" if conn[:password].nil?
@@ -48,12 +48,8 @@ class Ipmitool
   #Run a ping check to see if the host is responding
   def check_host
     result = `ping -q -c 2 #{@conn[:host]}`
-    if ($?.exitstatus == 0) do
-      pingable = true
-    else
-      pingable = false
-    end
-    pingable
+    # return true or false if exit status is 0
+    $?.exitstatus == 0
   end
 
   #Read sensor data from ipmitool and return a hash containing the value
@@ -182,7 +178,14 @@ class Ipmitool
 
   private
   def run_command(command, *args)
-    `#{@conn[:binary]} -H #{@conn[:host]} -U #{@conn[:user]} -P #{@conn[:password]} #{command} #{args unless args.nil?}`.downcase!
+    optional = []
+    if @conn[:optional]
+        @conn[:optional].each { |key, value|
+            optional << "-#{key} #{value}"
+        }
+    end
+
+    `#{@conn[:binary]} #{optional.join(" ")} -H #{@conn[:host]} -U #{@conn[:user]} -P #{@conn[:password]} #{command} #{args unless args.nil?}`.downcase!
   end
 
   def split_output(array, delimiter)

metadata

@@ -1,13 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-ipmitool
 version: !ruby/object:Gem::Version 
-  hash: 13
+  hash: 443364408258612160
   prerelease: 
   segments: 
   - 0
-  - 4
-  - 1
-  version: 0.4.1
+  - 5
+  version: "0.5"
 platform: ruby
 authors: 
 - Eugene Howe
@@ -15,7 +14,8 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-28 00:00:00 Z
+date: 2011-10-31 00:00:00 -04:00
+default_executable: 
 dependencies: []
 
 description: Wraps most functionality of ipmitool including user, sensor, channel, and chassis functions
@@ -28,6 +28,7 @@ extra_rdoc_files: []
 
 files: 
 - lib/ruby-ipmitool.rb
+has_rdoc: true
 homepage: 
 licenses: []
 
@@ -41,7 +42,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 2002549777813010636
       segments: 
       - 0
       version: "0"
@@ -50,14 +51,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3
+      hash: 2002549777813010636
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.7.2
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: Wrapper for the linux ipmitool command