ruby-hackernews 1.3.7 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a75ae2b32c9d840dd595bb25dfde7ca86364fecd
-  data.tar.gz: 3b125a1e73964ed58d0c1f7c51c105c667f08a2c
+  metadata.gz: f48014b00147c10a872eabab64e2c1514ac67f23
+  data.tar.gz: c8dad359b0c07c43e4e22272df143c1da0fcfaa7
 SHA512:
-  metadata.gz: e014746411f77467c3f4bd70a82acfab27d93b5e5713c5552029ed3f9df85db1dac81f8a97cb6189501d0ec1053a7b6033bbee2586a59fcf36805003f61fba7d
-  data.tar.gz: 8132a51491bf5b966810d5cf7ec00a203f2c54dece9d5dd9b3209ea89426bd6637ab81fe405671e57fe7b4cc8e409707bde1609848fef75801fc21ede64f268d
+  metadata.gz: 5edccf9e5df807bb7b1b65bf902a80553d4d2c8cebe615e87d999ed6b6061545bfe88b8aeb61732c4cfa999c35901fab7dc5d62711c50042b46154509a3f9a71
+  data.tar.gz: 1769d51cf5bb8c7889375eae78fd66df951fec39e0cd1a84a28fe829ee5dad7700ff01815dde62871ba3989b950aeb0e176e02e9d36378c87d5ae649a931df74

data/README.rdoc

@@ -35,7 +35,7 @@ You can provide a number of pages:
 
 There are methods for getting specific entry types:
 
-    Entry.questions # gets the first page of questions (ask NH)
+    Entry.questions # gets the first page of questions (ask HN)
     Entry.newest    # gets the first page of new links (new)
     Entry.jobs      # gets the first page of job offerts (jobs)
     Entry.shows     # gets the first page of shows (show HN)
@@ -90,7 +90,7 @@ Note that the method above will send a request to HN. If you just need the comme
     
 and
   
-    entry.comment_url
+    entry.comments_url
 
 Either of which will not issue a request to HN's site. 
 
@@ -174,3 +174,5 @@ Will return the HN comment url of the last submitted story of that user
 - Girish Sonawane ( https://github.com/girishso) for adding Entry#shows and Entry#new_shows methods
 - Niels Van Aken ( https://github.com/nvaken ) for a bugfix in EntryPageParser
 - Pedro Lambert ( https://github.com/p-lambert ) for fixing bugs and improving structure of CommentInfoParser, TimeInfoParser and UserInfoParser
+- FreedomBen ( https://github.com/FreedomBen ) for fixing a typo in the readme
+- Davide Santangelo ( https://github.com/davidesantangelo ) for reporting a bug related to jobs and show HN entries

data/lib/ruby-hackernews/domain/entry/entry.rb

@@ -14,7 +14,11 @@ module RubyHackernews
       @user     = user    
       @time     = time
       @comments_info = comments
-      @cache    = PageFetcher.new(@comments_info.page) if @comments_info
+      if @comments_info
+        @cache = PageFetcher.new(@comments_info.page)
+      else
+        @cache = PageFetcher.new(@link.href)
+      end
     end
 
     def text

data/lib/ruby-hackernews/services/entry_service.rb

@@ -13,6 +13,9 @@ module RubyHackernews
       next_url = nil
       pages.times do
         lines = parser.get_lines
+        while lines.first["class"] != "athing"
+          lines.shift
+        end
         (lines.length / 2).times do
           entry_infos << EntryParser.new(lines.shift, lines.shift).parse
         end

data/lib/ruby-hackernews/services/login_service.rb

@@ -8,8 +8,8 @@ module RubyHackernews
       login_url = page.search(".pagetop/a").last['href'].sub("/","")
       login_page = agent.get(ConfigurationService.base_url + login_url)
       form = login_page.forms.first
-      form.u = username
-      form.p = password
+      form.acct = username
+      form.pw = password
       page = form.submit
       return page.title != nil
     end

data/lib/ruby-hackernews/services/signup_service.rb

@@ -9,8 +9,8 @@ module RubyHackernews
       login_url = page.search(".pagetop/a").last['href'].sub("/","")
       login_page = agent.get(ConfigurationService.base_url + login_url)
       form = login_page.forms[1]
-      form.u = username
-      form.p = password
+      form.acct = username
+      form.pw = password
       page = form.submit
       return page.title != nil
     end

data/lib/ruby-hackernews/version.rb

@@ -1,3 +1,3 @@
 module RubyHackernews
-  VERSION = "1.3.7"
+  VERSION = "1.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-hackernews
 version: !ruby/object:Gem::Version
-  version: 1.3.7
+  version: 1.4.0
 platform: ruby
 authors:
 - Andrea Dallera
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-28 00:00:00.000000000 Z
+date: 2016-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -139,7 +139,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: An interface to Hacker News