ruby-hackernews 1.3.0 → 1.3.1

data/README.rdoc

@@ -15,7 +15,13 @@ then, in your script:
 
     require 'ruby-hackernews'
 
-before using it.
+before using it. If you want to include the namespace (RubyHackernews), add
+
+    include RubyHackernews
+
+otherwise, you'll have to access the gem's classes adding the module, like this:
+
+    RubyHackernews::Entry.all
 
 == Entries
 

data/Rakefile

@@ -8,7 +8,7 @@ require 'rake/testtask'
 
 spec = Gem::Specification.new do |s|
   s.name = 'ruby-hackernews'
-  s.version = '1.3.0'
+  s.version = '1.3.1'
   s.add_dependency('require_all', '>= 1.1.0')
   s.add_dependency('mechanize', '>= 1.0.0')
   s.has_rdoc = false

data/lib/ruby-hackernews/domain/entry/entry.rb

@@ -14,11 +14,19 @@ module RubyHackernews
       @user     = user    
       @time     = time
       @comments_info = comments
+      @cache    = PageFetcher.new(@comments_info.page)
+    end
+
+    def text
+      unless @text
+        @text = TextService.new.get_text(@cache.page)
+      end
+      return @text
     end
 
     def comments
       unless @comments
-        @comments = CommentService.new.get_comments(@comments_info.page)
+        @comments = CommentService.new.get_comments(@cache.page)
       end
       return @comments
     end

data/lib/ruby-hackernews/domain/user.rb

@@ -13,10 +13,6 @@ module RubyHackernews
       return LoginService.new.login(@name, password)
     end
 
-    def logout
-      return LoginService.new.logout
-    end
-
     def signup(password)
       return SignupService.new.signup(@name, password)
     end
@@ -28,7 +24,11 @@ module RubyHackernews
     def saved(pages = 1)
       return UserInfoService.new.saved(@name, pages)
     end
-    
+  
+    def logout
+      return LoginService.new.logout
+    end
+
     def comments(pages = 1)
       return UserInfoService.new.comments(@name, pages)
     end

data/lib/ruby-hackernews/services/comment_service.rb

@@ -3,24 +3,33 @@ module RubyHackernews
   class CommentService
     include MechanizeContext
 
-    def get_comments(page_url)
+    def get_comments(page)
+      table = page.search("table")[3]
+      return get_comments_entities(table)
+    end
+
+    def get_user_comments(user)
+      page = agent.get(ConfigurationService.base_url + "threads?id=#{user.name}")
+      table = page.search("table")[2]
+      return get_comments_entities(table)
+    end
+
+    def get_comments_entities(table)
       comments = []
-      last   = comments
-      current_level = -1
-      page = agent.get(page_url)
-      page.search("//table")[3].search("table/tr").select do |tr|
+      target   = comments
+      current_level = 0
+      table.search("table/tr").select do |tr|
         tr.search("span.comment").inner_html != "[deleted]"
       end.each do |tr|
         comment = parse_comment(tr)
         level = tr.search("img[@src='http://ycombinator.com/images/s.gif']").first['width'].to_i / 40
         difference = current_level - level
-        target = last
         (difference + 1).times do
-          target = target.parent || comments
+          target = target.kind_of?(Comment) && target.parent ? target.parent : comments
         end
-        target << comment
-        last = comment
         current_level = level
+        target << comment
+        target = comment
       end
       return comments
     end
@@ -59,7 +68,6 @@ module RubyHackernews
       form.submit
       return true
     end
-  
-  end
 
+  end
 end  

data/lib/ruby-hackernews/services/page_fetcher.rb

@@ -0,0 +1,20 @@
+
+module RubyHackernews
+
+  #acts as a cache
+  class PageFetcher
+    include MechanizeContext
+
+    def initialize(page_url)
+      @url = page_url
+    end
+
+    def page
+      unless @page
+        @page = agent.get(@url)
+      end
+      return @page
+    end
+
+  end
+end

data/lib/ruby-hackernews/services/parsers/text_parser.rb

@@ -0,0 +1,15 @@
+
+module RubyHackernews
+
+  class TextParser
+
+    def initialize(table)
+      @target_line = table.search("tr")[3]
+    end
+
+    def parse
+      return @target_line.search("td")[1].inner_text
+    end
+
+  end
+end

data/lib/ruby-hackernews/services/text_service.rb

@@ -0,0 +1,11 @@
+module RubyHackernews
+
+  class TextService
+    include MechanizeContext
+
+    def get_text(page)
+      return TextParser.new(page.search("table")[2]).parse
+    end
+
+  end
+end  

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruby-hackernews
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-28 00:00:00.000000000 Z
+date: 2012-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: require_all
-  requirement: &16407680 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: 1.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *16407680
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: mechanize
-  requirement: &16407120 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +37,12 @@ dependencies:
         version: 1.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *16407120
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 description: An interface to Hacker News
 email: andrea@andreadallera.com
 executables: []
@@ -41,31 +51,34 @@ extra_rdoc_files: []
 files:
 - README.rdoc
 - Rakefile
-- lib/ruby-hackernews/services/not_authenticated_error.rb
-- lib/ruby-hackernews/services/parsers/comments_info_parser.rb
-- lib/ruby-hackernews/services/parsers/link_info_parser.rb
+- lib/ruby-hackernews.rb
+- lib/ruby-hackernews/services/comment_service.rb
+- lib/ruby-hackernews/services/entry_service.rb
+- lib/ruby-hackernews/services/voting_service.rb
+- lib/ruby-hackernews/services/text_service.rb
 - lib/ruby-hackernews/services/parsers/entry_page_parser.rb
-- lib/ruby-hackernews/services/parsers/user_info_parser.rb
-- lib/ruby-hackernews/services/parsers/time_info_parser.rb
+- lib/ruby-hackernews/services/parsers/comments_info_parser.rb
 - lib/ruby-hackernews/services/parsers/voting_info_parser.rb
 - lib/ruby-hackernews/services/parsers/entry_parser.rb
-- lib/ruby-hackernews/services/user_info_service.rb
-- lib/ruby-hackernews/services/signup_service.rb
-- lib/ruby-hackernews/services/entry_service.rb
+- lib/ruby-hackernews/services/parsers/user_info_parser.rb
+- lib/ruby-hackernews/services/parsers/link_info_parser.rb
+- lib/ruby-hackernews/services/parsers/text_parser.rb
+- lib/ruby-hackernews/services/parsers/time_info_parser.rb
 - lib/ruby-hackernews/services/login_service.rb
-- lib/ruby-hackernews/services/configuration_service.rb
+- lib/ruby-hackernews/services/signup_service.rb
+- lib/ruby-hackernews/services/not_authenticated_error.rb
+- lib/ruby-hackernews/services/user_info_service.rb
 - lib/ruby-hackernews/services/mechanize_context.rb
-- lib/ruby-hackernews/services/comment_service.rb
-- lib/ruby-hackernews/services/voting_service.rb
-- lib/ruby-hackernews/domain/entry/link_info.rb
+- lib/ruby-hackernews/services/page_fetcher.rb
+- lib/ruby-hackernews/services/configuration_service.rb
+- lib/ruby-hackernews/domain/user.rb
 - lib/ruby-hackernews/domain/entry/time_info.rb
-- lib/ruby-hackernews/domain/entry/entry.rb
+- lib/ruby-hackernews/domain/entry/link_info.rb
 - lib/ruby-hackernews/domain/entry/user_info.rb
-- lib/ruby-hackernews/domain/entry/comments_info.rb
 - lib/ruby-hackernews/domain/entry/voting_info.rb
-- lib/ruby-hackernews/domain/user.rb
+- lib/ruby-hackernews/domain/entry/comments_info.rb
+- lib/ruby-hackernews/domain/entry/entry.rb
 - lib/ruby-hackernews/domain/comment/comment.rb
-- lib/ruby-hackernews.rb
 homepage: http://github.com/bolthar/ruby-hackernews
 licenses: []
 post_install_message: 
@@ -86,7 +99,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: An interface to Hacker News