ruby-hackernews 1.2.1 → 1.3.0

data/lib/ruby-hackernews/services/comment_service.rb

@@ -1,62 +1,65 @@
+module RubyHackernews
 
-class CommentService
-  include MechanizeContext
+  class CommentService
+    include MechanizeContext
 
-  def get_comments(page_url)
-    comments = []
-    last   = comments
-    current_level = -1
-    page = agent.get(page_url)
-    page.search("//table")[3].search("table/tr").select do |tr|
-      tr.search("span.comment").inner_html != "[deleted]"
-    end.each do |tr|
-      comment = parse_comment(tr)
-      level = tr.search("img[@src='http://ycombinator.com/images/s.gif']").first['width'].to_i / 40
-      difference = current_level - level
-      target = last
-      (difference + 1).times do
-        target = target.parent || comments
+    def get_comments(page_url)
+      comments = []
+      last   = comments
+      current_level = -1
+      page = agent.get(page_url)
+      page.search("//table")[3].search("table/tr").select do |tr|
+        tr.search("span.comment").inner_html != "[deleted]"
+      end.each do |tr|
+        comment = parse_comment(tr)
+        level = tr.search("img[@src='http://ycombinator.com/images/s.gif']").first['width'].to_i / 40
+        difference = current_level - level
+        target = last
+        (difference + 1).times do
+          target = target.parent || comments
+        end
+        target << comment
+        last = comment
+        current_level = level
       end
-      target << comment
-      last = comment
-      current_level = level
+      return comments
     end
-    return comments
-  end
 
-  def get_new_comments(pages = 1, url = ConfigurationService.comments_url)
-    parser = EntryPageParser.new(agent.get(url))
-    comments = []
-    pages.times do
-      lines = parser.get_lines
-      lines.each do |line|
-        comments << parse_comment(line)
+    def get_new_comments(pages = 1, url = ConfigurationService.comments_url)
+      parser = EntryPageParser.new(agent.get(url))
+      comments = []
+      pages.times do
+        lines = parser.get_lines
+        lines.each do |line|
+          comments << parse_comment(line)
+        end
+        next_url = parser.get_next_url || break
+        parser = EntryPageParser.new(agent.get(next_url))
       end
-      next_url = parser.get_next_url || break
-      parser = EntryPageParser.new(agent.get(next_url))
+      return comments
     end
-    return comments
-  end
 
-  def parse_comment(element)
-    text = ""
-    element.search("span.comment").first.children.each do |ch|
-      text = ch.inner_html.gsub(/<.{1,2}>/,"")
+    def parse_comment(element)
+      text = ""
+      element.search("span.comment").first.children.each do |ch|
+        text = ch.inner_html.gsub(/<.{1,2}>/,"")
+      end
+      header = element.search("span.comhead").first
+      voting = VotingInfoParser.new(element.search("td/center/a"), header).parse
+      user_info = UserInfoParser.new(header).parse
+      reply_link = element.search("td[@class='default']/p//u//a").first
+      reply_url = reply_link['href'] if reply_link     
+      return Comment.new(text, voting, user_info, reply_url)
     end
-    header = element.search("span.comhead").first
-    voting = VotingInfoParser.new(element.search("td/center/a"), header).parse
-    user_info = UserInfoParser.new(header).parse
-    reply_link = element.search("td[@class='default']/p//u//a").first
-    reply_url = reply_link['href'] if reply_link     
-    return Comment.new(text, voting, user_info, reply_url)
-  end
 
-  def write_comment(page_url, comment)
-    require_authentication
-    form = agent.get(page_url).forms.first
-    form.text = comment
-    form.submit
-    return true
-  end
+    def write_comment(page_url, comment)
+      require_authentication
+      form = agent.get(page_url).forms.first
+      form.text = comment
+      form.submit
+      return true
+    end
   
-end
+  end
+
+end  

data/lib/ruby-hackernews/services/configuration_service.rb

@@ -1,32 +1,35 @@
+module RubyHackernews
 
-class ConfigurationService
+  class ConfigurationService
 
-  def self.base_url=(url)
-    @base_url = url
-  end
+    def self.base_url=(url)
+      @base_url = url
+    end
 
-  def self.base_url
-    return @base_url || "http://news.ycombinator.com/"
-  end
+    def self.base_url
+      return @base_url || "http://news.ycombinator.com/"
+    end
 
-  def self.new_url
-    return File.join(self.base_url, "newest")
-  end
+    def self.new_url
+      return File.join(self.base_url, "newest")
+    end
 
-  def self.ask_url
-    return File.join(self.base_url, "ask")
-  end
+    def self.ask_url
+      return File.join(self.base_url, "ask")
+    end
 
-  def self.jobs_url
-    return File.join(self.base_url, "jobs")
-  end
+    def self.jobs_url
+      return File.join(self.base_url, "jobs")
+    end
 
-  def self.comments_url
-    return File.join(self.base_url, "newcomments")
-  end
+    def self.comments_url
+      return File.join(self.base_url, "newcomments")
+    end
+
+    def self.submit_url
+      return File.join(self.base_url, "submit")
+    end
 
-  def self.submit_url
-    return File.join(self.base_url, "submit")
   end
 
-end
+end

data/lib/ruby-hackernews/services/entry_service.rb

@@ -1,65 +1,67 @@
+module RubyHackernews
 
-class EntryService
-  include MechanizeContext
+  class EntryService
+    include MechanizeContext
 
-  def get_entries(pages = 1, url = ConfigurationService.base_url)
-    parser = EntryPageParser.new(agent.get(url))
-    entry_infos = []
-    pages.times do
-      lines = parser.get_lines
-      (lines.length / 2).times do
-        entry_infos << EntryParser.new(lines.shift, lines.shift).parse
+    def get_entries(pages = 1, url = ConfigurationService.base_url)
+      parser = EntryPageParser.new(agent.get(url))
+      entry_infos = []
+      pages.times do
+        lines = parser.get_lines
+        (lines.length / 2).times do
+          entry_infos << EntryParser.new(lines.shift, lines.shift).parse
+        end
+        next_url = parser.get_next_url || break
+        parser = EntryPageParser.new(agent.get(next_url))
       end
-      next_url = parser.get_next_url || break
-      parser = EntryPageParser.new(agent.get(next_url))
+      return entry_infos
     end
-    return entry_infos
-  end
 
-  def find_by_id(id)
-    page = agent.get(ConfigurationService.base_url + "item?id=#{id}")
-    lines = page.search("table")[2].search("tr")
-    return EntryParser.new(lines[0], lines[1]).parse
-  end
+    def find_by_id(id)
+      page = agent.get(ConfigurationService.base_url + "item?id=#{id}")
+      lines = page.search("table")[2].search("tr")
+      return EntryParser.new(lines[0], lines[1]).parse
+    end
 
-  def get_new_entries(pages = 1)
-    return get_entries(pages, ConfigurationService.new_url)
-  end
+    def get_new_entries(pages = 1)
+      return get_entries(pages, ConfigurationService.new_url)
+    end
 
-  def get_questions(pages = 1)
-    return get_entries(pages, ConfigurationService.ask_url)
-  end
+    def get_questions(pages = 1)
+      return get_entries(pages, ConfigurationService.ask_url)
+    end
 
-  def get_jobs(pages = 1)
-    return get_entries(pages, ConfigurationService.jobs_url)
-  end
-  
-  def submit(title, url)
-    require_authentication
-    form = agent.get(ConfigurationService.submit_url).forms.first
-    submit_link(form, title, url)
-    return true
-  end
+    def get_jobs(pages = 1)
+      return get_entries(pages, ConfigurationService.jobs_url)
+    end
+    
+    def submit(title, url)
+      require_authentication
+      form = agent.get(ConfigurationService.submit_url).forms.first
+      submit_link(form, title, url)
+      return true
+    end
 
-  def ask(title, text)
-    require_authentication
-    form = agent.get(ConfigurationService.submit_url).forms.first
-    submit_question(form, title, text)
-    return true
-  end
+    def ask(title, text)
+      require_authentication
+      form = agent.get(ConfigurationService.submit_url).forms.first
+      submit_question(form, title, text)
+      return true
+    end
 
-  private
-  def submit_link(form, title, url)
-    form.t = title
-    form.u = url
-    form.submit
-  end
+    private
+    def submit_link(form, title, url)
+      form.t = title
+      form.u = url
+      form.submit
+    end
 
-  def submit_question(form, title, text)
-    form.t = title
-    form.x = text
-    form.submit
+    def submit_question(form, title, text)
+      form.t = title
+      form.x = text
+      form.submit
+    end
+  
   end
 
-  
 end

data/lib/ruby-hackernews/services/login_service.rb

@@ -1,25 +1,28 @@
+module RubyHackernews
 
-class LoginService
-  include MechanizeContext
+  class LoginService
+    include MechanizeContext
 
-  def login(username, password)
-    page = agent.get(ConfigurationService.base_url)
-    login_url = page.search(".pagetop/a").last['href'].sub("/","")
-    login_page = agent.get(ConfigurationService.base_url + login_url)
-    form = login_page.forms.first
-    form.u = username
-    form.p = password
-    page = form.submit
-    return page.title != nil
-  end
+    def login(username, password)
+      page = agent.get(ConfigurationService.base_url)
+      login_url = page.search(".pagetop/a").last['href'].sub("/","")
+      login_page = agent.get(ConfigurationService.base_url + login_url)
+      form = login_page.forms.first
+      form.u = username
+      form.p = password
+      page = form.submit
+      return page.title != nil
+    end
+
+    def logout
+      require_authentication
+      page = agent.get(ConfigurationService.base_url)
+      login_url = page.search(".pagetop/a").last['href'].sub("/","")
+      logout_page = agent.get(ConfigurationService.base_url + login_url)
+      agent.cookie_jar.jar.clear
+      return logout_page.search(".pagetop/a").last.inner_html == "login"
+    end
 
-  def logout
-    require_authentication
-    page = agent.get(ConfigurationService.base_url)
-    login_url = page.search(".pagetop/a").last['href'].sub("/","")
-    logout_page = agent.get(ConfigurationService.base_url + login_url)
-    agent.cookie_jar.jar.clear
-    return logout_page.search(".pagetop/a").last.inner_html == "login"
   end
 
-end
+end  

data/lib/ruby-hackernews/services/mechanize_context.rb

@@ -1,27 +1,31 @@
-module MechanizeContext
+module RubyHackernews
 
-  @@contexts = {}
+  module MechanizeContext
 
-  def self.agent=(key)
-    @@default = key
-  end
+    @@contexts = {}
 
-  def agent
-    @@default ||= :default
-    @@contexts[@@default] = Mechanize.new unless @@contexts[@@default]
-    return @@contexts[@@default]
-  end
+    def self.agent=(key)
+      @@default = key
+    end
 
-  def [](key)
-    return @@contexts[key]
-  end
+    def agent
+      @@default ||= :default
+      @@contexts[@@default] = Mechanize.new unless @@contexts[@@default]
+      return @@contexts[@@default]
+    end
 
-  def require_authentication
-    raise NotAuthenticatedError unless authenticated?
-  end
+    def [](key)
+      return @@contexts[key]
+    end
+
+    def require_authentication
+      raise NotAuthenticatedError unless authenticated?
+    end
+
+    def authenticated?(key = :default)
+      return @@contexts[key] && @@contexts[key].cookie_jar.jar.any?
+    end
 
-  def authenticated?(key = :default)
-    return @@contexts[key] && @@contexts[key].cookie_jar.jar.any?
   end
 
-end
+end  

data/lib/ruby-hackernews/services/not_authenticated_error.rb

@@ -1,8 +1,11 @@
+module RubyHackernews
 
-class NotAuthenticatedError < StandardError
+  class NotAuthenticatedError < StandardError
 
-  def message
-    return "You need to authenticate before making this operation"
+    def message
+      return "You need to authenticate before making this operation"
+    end
+    
   end
-  
-end
+
+end

data/lib/ruby-hackernews/services/parsers/comments_info_parser.rb

@@ -1,16 +1,21 @@
-class CommentsInfoParser
+module RubyHackernews
 
-  def initialize(comments_element)
-    @element = comments_element.search("a")[1]
-  end
+  class CommentsInfoParser
+
+    def initialize(comments_element)
+      @element = comments_element.search("a")[1]
+    end
 
-  def parse
-    comments_info = nil
-    if @element && @element['href'] =~ /id/
-      comments      = @element.inner_html.split[0].to_i
-      comments_page = @element['href']
-      comments_info = CommentsInfo.new(comments, comments_page)
+    def parse
+      comments_info = nil
+      if @element && @element['href'] =~ /id/
+        comments      = @element.inner_html.split[0].to_i
+        comments_page = @element['href']
+        comments_info = CommentsInfo.new(comments, comments_page)
+      end
+      return comments_info
     end
-    return comments_info
+
   end
+
 end

data/lib/ruby-hackernews/services/parsers/entry_page_parser.rb

@@ -1,24 +1,27 @@
+module RubyHackernews
 
-class EntryPageParser
+  class EntryPageParser
 
-  def initialize(page)
-    @page = page
-  end
+    def initialize(page)
+      @page = page
+    end
 
-  def get_lines
-    lines = @page.search("//table")[2].search("tr").select do |tr|
-      tr['style'] !~ /height/ &&
-      tr.children.first.attributes.count != 0
+    def get_lines
+      lines = @page.search("//table")[2].search("tr").select do |tr|
+        tr['style'] !~ /height/ &&
+        tr.children.first.attributes.count != 0
+      end
+      more_link = lines.last.search("a").first
+      lines.pop if more_link && more_link.inner_html == "More"
+      return lines
+    end
+
+    def get_next_url
+      more_link = @page.search("//table")[2].search("tr/td/a").select { |node| node.inner_html == "More"}.first
+      return more_link['href'] if more_link
+      return nil
     end
-    more_link = lines.last.search("a").first
-    lines.pop if more_link && more_link.inner_html == "More"
-    return lines
-  end
 
-  def get_next_url
-    more_link = @page.search("//table")[2].search("tr/td/a").select { |node| node.inner_html == "More"}.first
-    return more_link['href'] if more_link
-    return nil
   end
 
-end
+end