ruby-hackernews 1.1.0 → 1.1.1

data/README.rdoc

@@ -117,3 +117,5 @@ You have to log out before logging in with a different user.
 
 - Mike Kelly ( https://github.com/mikekelly ) for fixing a bug in TimeInfo.time
 - Marc Köhlbrugge ( http://github.com/marckohlbrugge ) fox fixing and formatting the documentation
+- Peter Cooper ( http://github.com/peterc ) for bug reports
+- Peter Boctor ( http://github.com/boctor ) for fixing a bug about authentication

data/Rakefile

@@ -1,6 +1,5 @@
 
 require 'rubygems'
-require 'spec/rake/spectask'
 require 'rake'
 require 'rake/clean'
 require 'rake/gempackagetask'
@@ -9,7 +8,7 @@ require 'rake/testtask'
 
 spec = Gem::Specification.new do |s|
   s.name = 'ruby-hackernews'
-  s.version = '1.1.0'
+  s.version = '1.1.1'
   s.add_dependency('require_all', '>= 1.1.0')
   s.add_dependency('mechanize', '>= 1.0.0')
   s.has_rdoc = false
@@ -26,9 +25,4 @@ Rake::GemPackageTask.new(spec) do |p|
   p.gem_spec = spec
   p.need_tar = true
   p.need_zip = true
-end
-
-Spec::Rake::SpecTask.new do |t|
-  t.warning = true
-  t.spec_files = FileList['spec/**/*.rb']
-end
+end

data/lib/ruby-hackernews/domain/entry/time_info.rb

@@ -10,10 +10,12 @@ class TimeInfo
     return Time.now - @unit_of_measure * @value
   end
 
-  def initialize(value, unit_of_measure)
-    descriptor = unit_of_measure[unit_of_measure.length - 1].chr == "s" ? unit_of_measure[0..unit_of_measure.length - 2] : unit_of_measure
+  def initialize(value, unit_of_measure)    
     @value           = value
-    @unit_of_measure = self.class.const_get(descriptor.upcase)
+    if(unit_of_measure)
+      descriptor = unit_of_measure[unit_of_measure.length - 1].chr == "s" ? unit_of_measure[0..unit_of_measure.length - 2] : unit_of_measure
+      @unit_of_measure = self.class.const_get(descriptor.upcase)
+    end
   end
 
 

data/lib/ruby-hackernews/services/mechanize_context.rb

@@ -1,4 +1,3 @@
-
 module MechanizeContext
 
   @@contexts = {}
@@ -22,7 +21,7 @@ module MechanizeContext
   end
 
   def authenticated?(key = :default)
-    return @@contexts[key].cookie_jar.jar.any?
+    return @@contexts[key] && @@contexts[key].cookie_jar.jar.any?
   end
 
 end

data/lib/ruby-hackernews/services/parsers/time_info_parser.rb

@@ -6,8 +6,10 @@ class TimeInfoParser
   end
 
   def parse
-    value           = @element.text.strip.split[0].to_i
-    unit_of_measure = @element.text.strip.split[1]
+    if @element
+      value           = @element.text.strip.split[0].to_i
+      unit_of_measure = @element.text.strip.split[1]
+    end
     return TimeInfo.new(value, unit_of_measure)
   end
 end

data/lib/ruby-hackernews/services/parsers/user_info_parser.rb

@@ -6,8 +6,11 @@ class UserInfoParser
   end
 
   def parse
-    user_name = @element.search("a")[0].inner_html
-    user_page = @element.search("a")[0]['href']
+    user_element = @element.search("a")[0]
+    if user_element
+      user_name = user_element.inner_html
+      user_page = user_element['href']
+    end
     return UserInfo.new(user_name, user_page)
   end
 end

data/lib/ruby-hackernews/services/parsers/voting_info_parser.rb

@@ -9,7 +9,8 @@ class VotingInfoParser
   def parse
     upvote   = @voting_element[0]['href'] if @voting_element[0]
     downvote = @voting_element[1]['href'] if @voting_element[1]
-    score    = @score_element.search("span")[0].inner_html.split[0].to_i
+    points_element = @score_element.search("span")[0]
+    score    = points_element.inner_html.split[0].to_i if points_element
     return VotingInfo.new(score, upvote, downvote)
   end
 end

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: ruby-hackernews
 version: !ruby/object:Gem::Version 
-  version: 1.1.0
+  prerelease: false
+  segments: 
+  - 1
+  - 1
+  - 1
+  version: 1.1.1
 platform: ruby
 authors: 
 - Andrea Dallera
@@ -9,29 +14,39 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-10-18 00:00:00 +02:00
+date: 2011-06-08 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: require_all
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 1
+        - 0
         version: 1.1.0
-    version: 
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: mechanize
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        segments: 
+        - 1
+        - 0
+        - 0
         version: 1.0.0
-    version: 
+  type: :runtime
+  version_requirements: *id002
 description: An interface to Hacker News
 email: andrea@andreadallera.com
 executables: []
@@ -44,28 +59,28 @@ files:
 - README.rdoc
 - Rakefile
 - lib/ruby-hackernews.rb
-- lib/ruby-hackernews/domain/comment/comment.rb
-- lib/ruby-hackernews/domain/entry/entry.rb
-- lib/ruby-hackernews/domain/entry/comments_info.rb
-- lib/ruby-hackernews/domain/entry/link_info.rb
-- lib/ruby-hackernews/domain/entry/time_info.rb
-- lib/ruby-hackernews/domain/entry/voting_info.rb
-- lib/ruby-hackernews/domain/entry/user_info.rb
-- lib/ruby-hackernews/domain/user.rb
-- lib/ruby-hackernews/services/mechanize_context.rb
-- lib/ruby-hackernews/services/voting_service.rb
-- lib/ruby-hackernews/services/comment_service.rb
-- lib/ruby-hackernews/services/entry_service.rb
-- lib/ruby-hackernews/services/configuration_service.rb
+- lib/ruby-hackernews/services/parsers/voting_info_parser.rb
+- lib/ruby-hackernews/services/parsers/time_info_parser.rb
 - lib/ruby-hackernews/services/parsers/entry_page_parser.rb
 - lib/ruby-hackernews/services/parsers/link_info_parser.rb
+- lib/ruby-hackernews/services/parsers/comments_info_parser.rb
 - lib/ruby-hackernews/services/parsers/entry_parser.rb
 - lib/ruby-hackernews/services/parsers/user_info_parser.rb
-- lib/ruby-hackernews/services/parsers/voting_info_parser.rb
-- lib/ruby-hackernews/services/parsers/comments_info_parser.rb
-- lib/ruby-hackernews/services/parsers/time_info_parser.rb
+- lib/ruby-hackernews/services/voting_service.rb
+- lib/ruby-hackernews/services/mechanize_context.rb
 - lib/ruby-hackernews/services/login_service.rb
+- lib/ruby-hackernews/services/comment_service.rb
+- lib/ruby-hackernews/services/entry_service.rb
 - lib/ruby-hackernews/services/not_authenticated_error.rb
+- lib/ruby-hackernews/services/configuration_service.rb
+- lib/ruby-hackernews/domain/entry/comments_info.rb
+- lib/ruby-hackernews/domain/entry/voting_info.rb
+- lib/ruby-hackernews/domain/entry/entry.rb
+- lib/ruby-hackernews/domain/entry/user_info.rb
+- lib/ruby-hackernews/domain/entry/time_info.rb
+- lib/ruby-hackernews/domain/entry/link_info.rb
+- lib/ruby-hackernews/domain/comment/comment.rb
+- lib/ruby-hackernews/domain/user.rb
 has_rdoc: true
 homepage: http://github.com/bolthar/ruby-hackernews
 licenses: []
@@ -76,21 +91,25 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: An interface to Hacker News