ruby-feedparser 0.9.6 → 0.9.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef98b8e94313acaf4bb675bf288be24431c4667259cdba3c0cd8442a50a8a60d
-  data.tar.gz: 143101e95cd72744fe963cd2a9eb925c17060a718bc06e7024f41f221b50ab97
+  metadata.gz: e198cf8ee7423ff4edf5ba4367ac809ba1fe2a9d6361fcf53d12b984aa138228
+  data.tar.gz: bbbd8c024c4e85c991ae2ceae4494e24d8b0865d2fe6a4df2646007e798e96ac
 SHA512:
-  metadata.gz: b0ae6ccf83dc9fae3d8d0b16df210852d230c2927bccc5f94ce113e21efe51c175eb0123054183f2c63ae98b4356fdd66fee56628f9acf821c5c781f1da1763b
-  data.tar.gz: 1a920814efea8833c9b4172b1f97b54e76b3951013820da855786dc9303058a4a306b244d62b1ac7d8023c0c48fde9a8754e38884c5e0e0b4e8c8d9714aa54ee
+  metadata.gz: ac90154cfa40180e03d4b7b1d631186c6db1d70d79bdbb7f4edb4c54a66eddab3085e04480ed965b7c2e055770976873224b9d12f20be3d282817d6cd34245be
+  data.tar.gz: 4f658dc07c1d692b44f9abd0d400449cb0e1aa3d1cda8c782b052e45b193a8ad462ce7e2d8f951b3d15b301764e651f3781da93cf07f28c1ea8438ab87a1c989

data/lib/feedparser/feedparser.rb

@@ -233,7 +233,11 @@ module FeedParser
 
     def link
       if @link
-        uri = URI.parse(CGI.escape(@link))
+        begin
+          uri = URI.parse(@link)
+        rescue URI::InvalidURIError
+          return @link
+        end
         if uri.hostname && uri.scheme
           @link
         elsif feed && feed.origin

data/lib/feedparser/version.rb

@@ -1,3 +1,3 @@
 module FeedParser
-  VERSION = "0.9.6"
+  VERSION = "0.9.7"
 end

data/test/tc_feeditem.rb

@@ -0,0 +1,47 @@
+require 'feedparser/feedparser'
+require 'test/unit'
+
+
+class FeedItemTest < Test::Unit::TestCase
+  def setup
+    @item = FeedParser::FeedItem.new(nil, nil)
+  end
+
+  ########################################################################
+
+  def test_link_no_link
+    assert @item.link.nil?
+  end
+
+  def test_link_basic
+    @item.instance_variable_set('@link', 'https://www.example.com/')
+    assert_equal "https://www.example.com/", @item.link
+  end
+
+  def test_link_path_only
+    @item.instance_variable_set('@link', '/foo/bar/')
+    assert_equal "/foo/bar/", @item.link
+  end
+
+  def test_link_path_only_with_feed_origin
+    @item.instance_variable_set('@link', '/foo/bar/')
+    feed = FeedParser::Feed.new
+    feed.instance_variable_set('@origin', 'https://www.exampleorigin.com')
+    @item.instance_variable_set('@feed', feed)
+    assert_equal "https://www.exampleorigin.com/foo/bar/", @item.link
+  end
+
+  def test_link_full_link_with_feed_origin
+    @item.instance_variable_set('@link', 'https://www.exampleorigin.com/foo/bar/')
+    feed = FeedParser::Feed.new
+    feed.instance_variable_set('@origin', 'https://www.exampleorigin.com')
+    @item.instance_variable_set('@feed', feed)
+    assert_equal "https://www.exampleorigin.com/foo/bar/", @item.link
+  end
+
+  def test_link_with_non_ascii
+    @item.instance_variable_set('@link', 'https://www.example.people/☭/')
+    assert_equal "https://www.example.people/☭/", @item.link
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-feedparser
 version: !ruby/object:Gem::Version
-  version: 0.9.6
+  version: 0.9.7
 platform: ruby
 authors:
 - Lucas Nussbaum
 autorequire: feedparser
 bindir: bin
 cert_chain: []
-date: 2021-01-14 00:00:00.000000000 Z
+date: 2021-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: magic
@@ -47,6 +47,7 @@ files:
 - lib/feedparser/version.rb
 - setup.rb
 - test/tc_feed_parse.rb
+- test/tc_feeditem.rb
 - test/tc_html2text_parser.rb
 - test/tc_htmloutput.rb
 - test/tc_parser.rb