ruby-ecomm-client 1.1.0 → 1.7.0

data/spec/ruby-ecomm-client/service_profile_spec.rb

@@ -0,0 +1,33 @@
+require 'spec_helper'
+
+describe RubyEcommClient::ServiceProfile do
+  before do
+    use_test = [:qa, :production].include?(RubyEcommClient::Client.environment)
+
+    @shopper_id = use_test ? '261639' : '923518'
+    @low_tree_id = '2402'
+    @downgrade_tree_id = '2402'
+    @current_tree_id = '2410'
+    @upgrade_tree_id = '2418'
+    @resource_type = 'outright'
+    @resource_id = use_test ? 'd5e2ead3-c1c4-11e3-9ea5-005056953ce3' : 'b6be6fd0-c1a5-11e3-8e42-0050569575d8'
+
+    @config_client = RubyEcommClient::Client.new(@shopper_id, @resource_type, @resource_id)
+    @service = RubyEcommClient::ServiceProfile.new(@config_client)
+  end
+
+  context '#express_checkout?' do
+    it 'return false for unknown' do
+      VCR.use_cassette('express_checkout/unknown') do
+        @service.send(:config_client).shopper_id = '101010'
+        @service.express_checkout?.should eq(false)
+      end
+    end
+
+    it 'return true when configured' do
+      VCR.use_cassette('express_checkout/configured') do
+        @service.express_checkout?.should eq(true)
+      end
+    end
+  end
+end

data/spec/ruby-ecomm-client/service_purchase_spec.rb

@@ -0,0 +1,160 @@
+require 'spec_helper'
+
+class UtilTarget
+  include ::Utils
+end
+
+describe RubyEcommClient::Client do
+  before do
+    use_test = [:qa, :production].include?(RubyEcommClient::Client.environment)
+
+    @shopper_id = use_test ? '261639' : '923518'
+    @low_tree_id = '2402'
+    @downgrade_tree_id = '2402'
+    @current_tree_id = '2410'
+    @upgrade_tree_id = '2418'
+    @resource_type = 'outright'
+    @resource_id = use_test ? 'd5e2ead3-c1c4-11e3-9ea5-005056953ce3' : 'b6be6fd0-c1a5-11e3-8e42-0050569575d8'
+
+    @config_client = RubyEcommClient::Client.new(@shopper_id, @resource_type, @resource_id)
+    @service = RubyEcommClient::ServicePurchase.new(@config_client)
+  end
+
+  context '#request_change' do
+    it 'require target_tree_id non-nil' do
+      expect { @service.request_change(nil) }.to raise_error(ArgumentError)
+    end
+
+    it 'relay to request_change_via_express_checkout' do
+      @config_client.stub(:express_checkout?).and_return(true)
+      @service.should_receive(:request_change_via_express).with(37, '127.0.0.1').once
+      VCR.use_cassette('request_change/express/relay/default') do
+        @service.request_change(37)
+      end
+    end
+
+    it 'relay to request_change_via_manager' do
+      @config_client.stub(:express_checkout?).and_return(false)
+      @config_client.should_receive(:request_change_via_manager).with(37).once
+      VCR.use_cassette('request_change/manager/relay/default') do
+        @service.request_change(37)
+      end
+    end
+  end
+
+  context '#request_change_via_express_checkout' do
+    before do
+      @service.stub(:express_checkout?).and_return(true)
+    end
+
+    context 'upgrade' do
+      before do
+        RubyEcommClient.configure do |config|
+          config.ssl_cert_file = "config/keys/#{UtilTarget.environment}/client.crt"
+          config.ssl_cert_key_file = "config/keys/#{UtilTarget.environment}/client.key"
+        end
+
+        VCR.use_cassette('request_change/express/upgrade/default') do
+          @result = @service.request_change_via_express(@upgrade_tree_id)
+        end
+      end
+
+      it 'require target_tree_id non-nil' do
+        expect { @service.request_change_via_express(nil) }.to raise_error(ArgumentError)
+      end
+
+      it 'require target_tree_id non-blank' do
+        expect { @service.request_change_via_express('') }.to raise_error(ArgumentError)
+      end
+
+      it 'raise RubyEcommError for unknown resource_type' do
+        VCR.use_cassette('request_change/express/upgrade/unknown/resource_type') do
+          @service.send(:config_client).resource_type = 'flugel'
+          expect { @service.request_change_via_express(@upgrade_tree_id) }.to raise_error(RubyEcommError) { |e| e.result_code.should eq(-100) }
+        end
+      end
+
+      it 'raise RubyEcommError for unknown resource_id' do
+        VCR.use_cassette('request_change/express/upgrade/unknown/resource_id') do
+          @service.send(:config_client).resource_id = 'unknown'
+          expect { @service.request_change_via_express(@upgrade_tree_id) }.to raise_error(RubyEcommError) { |e| e.result_code.should eq(-304) }
+        end
+      end
+
+      it 'raise RubyEcommError for unknown target_tree_id' do
+        VCR.use_cassette('request_change/express/upgrade/unknown/target_tree_id') do
+          expect { @service.request_change_via_express(73223) }.to raise_error(RubyEcommError) { |e| e.result_code.should eq(-999) }
+        end
+      end
+
+      it "return no-op request_result for transition to same" do
+        VCR.use_cassette('request_change/express/upgrade/noop') do
+          result = @service.request_change_via_express(@current_tree_id)
+          result[:request_result].should eq(1)
+          result[:used_express_checkout].should eq(true)
+        end
+      end
+
+      it "return success request_result for valid transition" do
+        @result[:request_result].should eq(0)
+        @result[:used_express_checkout].should eq(true)
+      end
+    end
+
+    context 'downgrade' do
+      before do
+        RubyEcommClient.configure do |config|
+          config.ssl_cert_file = ''
+          config.ssl_cert_key_file = ''
+          config.ssl_cert_content = File.read("config/keys/#{UtilTarget.environment}/client.crt")
+          config.ssl_cert_key_content = File.read("config/keys/#{UtilTarget.environment}/client.key")
+        end
+
+        VCR.use_cassette('request_change/express/downgrade/default') do
+          @result = @service.request_change_via_express(@downgrade_tree_id)
+        end
+      end
+
+      it 'require target_tree_id non-nil' do
+        expect { @service.request_change_via_express(nil) }.to raise_error(ArgumentError)
+      end
+
+      it 'require target_tree_id non-blank' do
+        expect { @service.request_change_via_express('') }.to raise_error(ArgumentError)
+      end
+
+      it 'raise RubyEcommError for unknown resource_type' do
+        VCR.use_cassette('request_change/express/downgrade/unknown/resource_type') do
+          @service.send(:config_client).resource_type = 'flugel'
+          expect { @service.request_change_via_express(@downgrade_tree_id) }.to raise_error(RubyEcommError) { |e| e.result_code.should eq(-100) }
+        end
+      end
+
+      it 'raise RubyEcommError for unknown resource_id' do
+        VCR.use_cassette('request_change/express/downgrade/unknown/resource_id') do
+          @service.send(:config_client).resource_id = 'unknown'
+          expect { @service.request_change_via_express(@downgrade_tree_id) }.to raise_error(RubyEcommError) { |e| e.result_code.should eq(-304) }
+        end
+      end
+
+      it 'raise RubyEcommError for unknown target_tree_id' do
+        VCR.use_cassette('request_change/express/downgrade/unknown/target_tree_id') do
+          expect { @service.request_change_via_express(73541) }.to raise_error(RubyEcommError) { |e| e.result_code.should eq(-999) }
+        end
+      end
+
+      it "return no-op request_result for transition to same" do
+        VCR.use_cassette('request_change/express/downgrade/noop') do
+          result = @service.request_change_via_express(@current_tree_id)
+          result[:request_result].should eq(0)
+          result[:used_express_checkout].should eq(true)
+        end
+      end
+
+      it "return success request_result for valid transition" do
+        @result[:request_result].should eq(1)
+        @result[:used_express_checkout].should eq(true)
+      end
+    end
+  end
+end

data/spec/ruby-ecomm-client/util_spec.rb

@@ -0,0 +1,66 @@
+require 'spec_helper'
+
+class UtilTarget
+  include ::Utils
+
+  def validate
+    blank?('123')
+  end
+end
+
+describe Utils do
+  before do
+    @target = UtilTarget.new
+  end
+
+  context "#blank?" do
+    it "consider nil blank" do
+      UtilTarget.blank?(nil).should eq(true)
+    end
+
+    it "consider empty blank" do
+      UtilTarget.blank?('').should eq(true)
+    end
+
+    it "consider whitespace-only blank" do
+      UtilTarget.blank?(' ').should eq(true)
+    end
+
+    it "consider non-zero not blank" do
+      UtilTarget.blank?('a').should eq(false)
+    end
+
+    it "consider number not blank" do
+      UtilTarget.blank?(0).should eq(false)
+    end
+
+    it 'consider empty Array blank' do
+      UtilTarget.blank?([]).should eq(true)
+    end
+
+    it 'consider non-empty Array not blank' do
+      UtilTarget.blank?([1]).should eq(false)
+    end
+
+    it "mix into instance" do
+      UtilTarget.new.validate.should eq(false)
+    end
+  end
+
+  context '#environment' do
+    it 'not be nil' do
+      @target.environment.should_not be_nil
+    end
+
+    it 'not be blank' do
+      @target.environment.should_not eq('')
+    end
+
+    it 'honor ENV' do
+      old_env = ENV['RAILS_ENV']
+      ENV['RAILS_ENV'] = 'production'
+      @target.environment.should eq(:production)
+      ENV['RAILS_ENV'] = old_env
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,9 @@
 require 'rubygems'
 require 'bundler/setup'
 
+require 'simplecov'
+SimpleCov.start
+
 require 'ruby-ecomm-client' # and any other gems you need
 
 RSpec.configure do |config|
@@ -15,6 +18,13 @@ VCR.configure do |c|
   c.hook_into :fakeweb
 end
 
+include Utils
+RubyEcommClient.configure do |config|
+  config.requesting_app = 'outright'
+  config.ssl_cert_file = "config/keys/#{environment}/client.crt"
+  config.ssl_cert_key_file = "config/keys/#{environment}/client.key"
+end
+
 if [:qa, :production].include?(RubyEcommClient::Client.environment)
   VCR.turn_off!(:ignore_cassettes => true)
   FakeWeb.allow_net_connect = true

metadata

@@ -1,162 +1,162 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: ruby-ecomm-client
-version: !ruby/object:Gem::Version 
-  hash: 19
-  prerelease: 
-  segments: 
-  - 1
-  - 1
-  - 0
-  version: 1.1.0
+version: !ruby/object:Gem::Version
+  version: 1.7.0
 platform: ruby
-authors: 
+authors:
 - Shelby Sanders
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2014-03-28 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        hash: 73
-        segments: 
-        - 10
-        - 1
-        - 1
-        version: 10.1.1
-  type: :development
-  requirement: *id001
-  prerelease: false
+date: 2014-05-07 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rake
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 10.1.1
   type: :development
-  requirement: *id002
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 10.1.1
+- !ruby/object:Gem::Dependency
   name: ci_reporter
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id003
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: fakeweb
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id004
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: gemfury
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id005
   prerelease: false
-  name: rcov
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id006 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id006
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: rspec
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id007 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  requirement: *id007
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: vcr
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id008 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        hash: 23
-        segments: 
-        - 1
-        - 5
-        - 10
-        version: 1.5.10
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: freddy
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  requirement: *id008
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: nokogiri
-- !ruby/object:Gem::Dependency 
-  version_requirements: &id009 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.5.10
   type: :runtime
-  requirement: *id009
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.5.10
+- !ruby/object:Gem::Dependency
   name: savon
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Easy access to the e-commerce web services via Ruby
-email: 
+email:
 - ssanders@godaddy.com
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - .ruby-version
 - Gemfile
@@ -174,6 +174,7 @@ files:
 - fixtures/vcr_cassettes/request_change/express/downgrade/unknown/resource_id.yml
 - fixtures/vcr_cassettes/request_change/express/downgrade/unknown/resource_type.yml
 - fixtures/vcr_cassettes/request_change/express/downgrade/unknown/target_tree_id.yml
+- fixtures/vcr_cassettes/request_change/express/relay/default.yml
 - fixtures/vcr_cassettes/request_change/express/upgrade/default.yml
 - fixtures/vcr_cassettes/request_change/express/upgrade/noop.yml
 - fixtures/vcr_cassettes/request_change/express/upgrade/unknown/resource_id.yml
@@ -184,6 +185,7 @@ files:
 - fixtures/vcr_cassettes/request_change/manager/downgrade/unknown/resource_id.yml
 - fixtures/vcr_cassettes/request_change/manager/downgrade/unknown/resource_type.yml
 - fixtures/vcr_cassettes/request_change/manager/downgrade/unknown/target_tree_id.yml
+- fixtures/vcr_cassettes/request_change/manager/relay/default.yml
 - fixtures/vcr_cassettes/request_change/manager/upgrade/default.yml
 - fixtures/vcr_cassettes/request_change/manager/upgrade/noop.yml
 - fixtures/vcr_cassettes/request_change/manager/upgrade/unknown/resource_id.yml
@@ -194,53 +196,59 @@ files:
 - fixtures/vcr_cassettes/transitions/one.yml
 - lib/ruby-ecomm-client.rb
 - lib/ruby-ecomm-client/client.rb
-- lib/ruby-ecomm-client/converter.rb
+- lib/ruby-ecomm-client/config.rb
 - lib/ruby-ecomm-client/error.rb
+- lib/ruby-ecomm-client/service_base.rb
+- lib/ruby-ecomm-client/service_manager.rb
+- lib/ruby-ecomm-client/service_profile.rb
+- lib/ruby-ecomm-client/service_purchase.rb
+- lib/ruby-ecomm-client/util.rb
 - lib/ruby-ecomm-client/version.rb
 - lib/ruby-ecomm-client/wsdl/manager.wsdl
 - lib/ruby-ecomm-client/wsdl/profile.wsdl
 - lib/ruby-ecomm-client/wsdl/purchase.wsdl
 - ruby-ecomm-client.gemspec
+- script/bootstrap
 - script/cibuild
 - spec/ruby-ecomm-client/client_spec.rb
-- spec/ruby-ecomm-client/converter_spec.rb
+- spec/ruby-ecomm-client/config_spec.rb
 - spec/ruby-ecomm-client/error_spec.rb
+- spec/ruby-ecomm-client/service_base_spec.rb
+- spec/ruby-ecomm-client/service_manager_spec.rb
+- spec/ruby-ecomm-client/service_profile_spec.rb
+- spec/ruby-ecomm-client/service_purchase_spec.rb
+- spec/ruby-ecomm-client/util_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.secureserver.net/outright/ruby-ecomm-client
 licenses: []
-
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.8.15
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Easy access to the e-commerce web services via Ruby
-test_files: 
+test_files:
 - spec/ruby-ecomm-client/client_spec.rb
-- spec/ruby-ecomm-client/converter_spec.rb
+- spec/ruby-ecomm-client/config_spec.rb
 - spec/ruby-ecomm-client/error_spec.rb
+- spec/ruby-ecomm-client/service_base_spec.rb
+- spec/ruby-ecomm-client/service_manager_spec.rb
+- spec/ruby-ecomm-client/service_profile_spec.rb
+- spec/ruby-ecomm-client/service_purchase_spec.rb
+- spec/ruby-ecomm-client/util_spec.rb
 - spec/spec_helper.rb