ruby-dmm 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 670cb0b87fb60026c846a59d48748c97ddfc7d4f
-  data.tar.gz: 3844894fe455170c3986a19eecd0784100adc1df
+  metadata.gz: 05ff67107c04c13451281c2ddce1037f703bc594
+  data.tar.gz: c169bc92ef677da3de5b75d02d93b3bd09cf19da
 SHA512:
-  metadata.gz: fce2f4cda62595cc10d10688d6f1e9c76be0a01bd0c032fd9679f4a63381766c695c2ee19c221bb75a302a4e11e85767adfb9f7403264e8d5680f6cef789db61
-  data.tar.gz: 48802a4240c8136ed5715c0f33de35139d4965318dc20c47ca76c355be41db5a33e5c1187222d9456dddbaa877a36451ee403ee16238eb4631fe0cce2e5ea2df
+  metadata.gz: d8c039f51ec9c66217dfba522a124fb1550269ba32178d4c9c7efd7bf9e3a1b02b52e935c76819162266c37d4408fbbe3cb9d539648fa37b3f79a61bf322fc89
+  data.tar.gz: 032538ccbf823e0698bf0e280b37b47f1cd29a0ce7421ebdf4523bfa333c0bb86ce3d361a6527f2dbf8fb07283000b9ee67aa61fab7ca9d457b56da8127134b6

data/lib/ruby-dmm/response/item.rb

@@ -4,41 +4,29 @@ require 'ruby-dmm/response/item_info'
 module DMM
   class Response
     class Item
-      KEYS  = [
-        :affiliate_url,
-        :affiliate_url_sp,
-        :bandaiinfo,
-        :category_name,
-        :cdinfo,
-        :content_id,
-        :floor_name,
-        :isbn,
-        :jancode,
-        :maker_product,
-        :product_id,
-        :service_name,
-        :stock,
-        :title,
-        :url,
-        :url_sp,
-      ]
-      attr_reader *KEYS
-      attr_reader *[
+
+      PREDEFINED_KEYS = [
         :date,
         :iteminfo,
-        :large_images,
         :list_price,
         :price,
         :price_all,
         :prices,
         :small_images,
       ]
-      alias :bandai_info  :bandaiinfo
-      alias :cd_info      :cdinfo
-      alias :item_info    :iteminfo
+      attr_reader *PREDEFINED_KEYS
+      alias_method :item_info,  :iteminfo
+      alias_method :info,       :iteminfo
+
+      ALIAS_METHOD_MAP = {
+        :bandaiinfo => :bandai_info,
+        :cdinfo     => :cd_info,
+        :image_url  => :images,
+      }
 
       def initialize(item)
         item.each do |key, value|
+          key = key.to_sym
           case key
           when :date
             @date = Time.parse(value) if value
@@ -49,6 +37,16 @@ module DMM
           when :prices
             setup_prices(value) if value
           else
+            self.class.class_eval do
+              unless method_defined?(key)
+                define_method "#{key}" do
+                  instance_variable_get("@#{key}")
+                end
+                if name = ALIAS_METHOD_MAP[key.to_sym]
+                  alias_method name, key.to_sym
+                end
+              end
+            end
             instance_variable_set("@#{key}", item[key])
           end
         end

data/lib/ruby-dmm/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module DMM
-  VERSION = "0.1.1"
+  VERSION = "0.1.2"
 end

data/spec/response/item_spec.rb

@@ -7,10 +7,21 @@ describe DMM::Response::Item do
     @item = DMM::new.item_list.result.items.first
   end
 
-  describe 'methods which returns integer' do
-    subject { @item }
-    DMM::Response::Item::KEYS.each do |key|
-      it { should respond_to(key) }
+  describe '#images' do
+    subject { @item.images }
+    it { should be }
+    its([:list])  { should == 'http://pics.dmm.com/mono/movie/n_616dlr22659/n_616dlr22659pt.jpg' }
+    its([:small]) { should == 'http://pics.dmm.com/mono/movie/n_616dlr22659/n_616dlr22659ps.jpg' }
+    its([:large]) { should == 'http://pics.dmm.com/mono/movie/n_616dlr22659/n_616dlr22659pl.jpg' }
+  end
+
+  describe 'define alias methods' do
+    subject do
+      item = DMM::Response::Item::ALIAS_METHOD_MAP.keys.inject({}) {|h, key| h.merge(key => 1) }
+      DMM::Response::Item.new(item)
+    end
+    DMM::Response::Item::ALIAS_METHOD_MAP.values.each do |name|
+      it { should respond_to(name) }
     end
   end
 
@@ -27,4 +38,14 @@ describe DMM::Response::Item do
     end
     its(:large_images) { should == ["http://pics.dmm.co.jp/digital/video/aaa00000/aaa00000jp-9.jpg"] }
   end
+
+  describe 'define method for any keys' do
+    subject do
+      item = {
+        :not_defined_key => true,
+      }
+      DMM::Response::Item.new(item)
+    end
+    it { should respond_to(:not_defined_key) }
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-dmm
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - meganemura
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-28 00:00:00.000000000 Z
+date: 2013-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday