ruby-clock 0.8.0.rc2 → 0.8.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ec6ebc2ef5793e7d114920402b20ed5129e1f60a78cb444d208e45def25a36b
-  data.tar.gz: 3935724aaa45567dd2e769274f76fc1b5a3785f155d4885764a25635a8bf6c96
+  metadata.gz: 7e8d972bb2c2468f53d943f233e4e799df71a449b6f7b8c00a1ddbea33c54c92
+  data.tar.gz: fc97259d0575bd220f79dd25206128001eece56ec51eda06d95f28d718b65080
 SHA512:
-  metadata.gz: cf58749b267218114e3ad235fa64d0c7e21cecc13c75f6a655b63cf16f056dcc174e6cd724be74c3a5c39087eec808e03d72829674cff52d85f0f831340efeb3
-  data.tar.gz: 04eefdc557205145fad64889dec7f7dcf6af4ead08dcc8795af58be4fffc2a54d97bb261048478c98aab58be30124e47f1d35c5115976cdd4119b95903e9b5ce
+  metadata.gz: 6dcf79cbebb137a9f04e920b8d6ff0f910bd61536e3e666297217aef8d9942c656fca0d67d794c753ab42a9e035be364bcf3d3b6e465058ebfe7e8683fa94fea
+  data.tar.gz: a3ca20e788af53d77d5526aaacb3b7ff4b07e8852e7586fe181e1681985b32b5bce3a9f0a305507be335dfeee7399567a6cd31afe8262b6e0b84db9cd2d9a75a

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.8.0 RC3
+
+* make terrapin and posix-spawn gems optional
+
 ## 0.8.0 RC2
 
 * fix detection of Rails constant, for non-rails apps

data/Gemfile.lock

@@ -3,14 +3,11 @@ PATH
   specs:
     ruby-clock (0.8.0.rc2)
       method_source
-      posix-spawn (~> 0.3.15)
       rufus-scheduler (~> 3.8)
-      terrapin (~> 0.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    climate_control (0.2.0)
     concurrent-ruby (1.1.9)
     et-orbi (1.2.5)
       tzinfo
@@ -18,13 +15,10 @@ GEM
       et-orbi (~> 1.1, >= 1.1.8)
       raabro (~> 1.4)
     method_source (1.0.0)
-    posix-spawn (0.3.15)
     raabro (1.4.0)
     rake (12.3.3)
     rufus-scheduler (3.8.0)
       fugit (~> 1.1, >= 1.1.6)
-    terrapin (0.6.0)
-      climate_control (>= 0.0.3, < 1.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
 

data/README.md

@@ -138,9 +138,7 @@ to learn how to do this. Where the documentation references `s`, you should use
 
 ### Shell commands
 
-You can run shell commands in your jobs. They are invoked using
-[posix-spawn](https://github.com/rtomayko/posix-spawn), which means
-the ruby process is not forked.
+You can run shell commands in your jobs.
 
 ```ruby
 schedule.every '1 day' do
@@ -148,9 +146,14 @@ schedule.every '1 day' do
 end
 ```
 
-`shell` is a very simple convenience method which is implemented with
-[terrapin](https://github.com/thoughtbot/terrapin). If you want to use other terrapin
-features you can do so:
+By default they will be run with
+[ruby backticks](https://livebook.manning.com/concept/ruby/backtick).
+For better performance, install the [terrapin](https://github.com/thoughtbot/terrapin)
+and [posix-spawn](https://github.com/rtomayko/posix-spawn) gems.
+
+`shell` is a convenience method which just passes the string on.
+If you want to use other terrapin features, you can skip the `shell` command
+and use terrapin directly:
 
 ```ruby
 schedule.every '1 day' do

data/example-app/Clockfile

@@ -1,3 +1,11 @@
+def schedule.on_error(job, error)
+  raise error
+end
+
 schedule.every('2 seconds') do
   puts "hello from a ruby-clock job"
 end
+
+schedule.every('2 seconds') do
+  shell 'say hello'
+end

data/example-app/Gemfile

@@ -3,3 +3,5 @@
 source "https://rubygems.org"
 
 gem 'ruby-clock', path: '../'
+# gem 'terrapin'
+# gem 'posix-spawn'

data/example-app/Gemfile.lock

@@ -1,16 +1,13 @@
 PATH
   remote: ..
   specs:
-    ruby-clock (0.8.0.rc1)
+    ruby-clock (0.8.0.rc2)
       method_source
-      posix-spawn (~> 0.3.15)
       rufus-scheduler (~> 3.8)
-      terrapin (~> 0.6)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    climate_control (0.2.0)
     concurrent-ruby (1.1.9)
     et-orbi (1.2.5)
       tzinfo
@@ -18,12 +15,9 @@ GEM
       et-orbi (~> 1.1, >= 1.1.8)
       raabro (~> 1.4)
     method_source (1.0.0)
-    posix-spawn (0.3.15)
     raabro (1.4.0)
     rufus-scheduler (3.8.0)
       fugit (~> 1.1, >= 1.1.6)
-    terrapin (0.6.0)
-      climate_control (>= 0.0.3, < 1.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
 

data/lib/ruby-clock/version.rb

@@ -1,3 +1,3 @@
 module RubyClock
-  VERSION = "0.8.0.rc2"
+  VERSION = "0.8.0.rc3"
 end

data/lib/ruby-clock.rb

@@ -69,8 +69,41 @@ module RubyClock
     @rake_mutex.synchronize { rake_async(task) }
   end
 
+  def shell_runner
+    @shell_runner ||= begin
+      require 'terrapin'
+      require 'posix-spawn'
+
+      unless Terrapin::CommandLine.runner.class == Terrapin::CommandLine::PosixRunner
+        puts <<~MESSAGE
+
+          🤷 terrapin and posix-spawn are installed, but for some reason terrapin is
+             not using posix-spawn as its runner.
+
+        MESSAGE
+      end
+
+      puts '🐆 Using terrapin for shell commands.'
+      :terrapin
+    rescue LoadError
+      puts <<~MESSAGE
+
+        🦥 Using ruby backticks for shell commands.
+           For better performance, install the terrapin and posix-spawn gems.
+           See README.md for more info.
+
+      MESSAGE
+      :backticks
+    end
+  end
+
   def shell(command)
-    Terrapin::CommandLine.new(command).run
+    case shell_runner
+    when :terrapin
+      Terrapin::CommandLine.new(command).run
+    when :backticks
+      `#{command}`
+    end
   end
 
 end

data/release.md

@@ -1,3 +1,4 @@
 1. update lib/ruby-clock/version.rb
 2. update CHANGELOG.md
+3. commit and push to github
 3. `rake release`

data/ruby-clock.gemspec

@@ -31,6 +31,4 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "rufus-scheduler", '~> 3.8'
   spec.add_dependency "method_source"
-  spec.add_dependency "terrapin", '~> 0.6'
-  spec.add_dependency "posix-spawn", '~> 0.3.15'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-clock
 version: !ruby/object:Gem::Version
-  version: 0.8.0.rc2
+  version: 0.8.0.rc3
 platform: ruby
 authors:
 - John Bachir
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-10-12 00:00:00.000000000 Z
+date: 2021-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rufus-scheduler
@@ -38,34 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: terrapin
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.6'
-- !ruby/object:Gem::Dependency
-  name: posix-spawn
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.3.15
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.3.15
 description:
 email:
 - j@jjb.cc