ruby-audioinfo 0.5.2 → 0.5.4

data/lib/audioinfo/album.rb

@@ -1,146 +1,145 @@
-require "audioinfo"
+# frozen_string_literal: true
 
-class AudioInfo::Album
+require 'audioinfo'
 
-  IMAGE_EXTENSIONS = %w{jpg jpeg gif png}
+module AudioInfo
+  class Album
+    IMAGE_EXTENSIONS = %w[jpg jpeg gif png].freeze
 
-  # a regexp to match the "multicd" suffix of a "multicd" string
-  # example: "toto (disc 1)" will match ' (disc 1)'
-  MULTICD_REGEXP = /\s*(\(|\[)?\s*(disc|cd):?-?\s*(\d+).*(\)|\])?\s*$/i
+    # a regexp to match the "multicd" suffix of a "multicd" string
+    # example: "toto (disc 1)" will match ' (disc 1)'
+    MULTICD_REGEXP = /\s*(\(|\[)?\s*(disc|cd):?-?\s*(\d+).*(\)|\])?\s*$/i.freeze
 
-  attr_reader :files, :discnum, :multicd, :basename, :infos, :path
+    attr_reader :files, :discnum, :multicd, :basename, :infos, :path
 
-  # return the list of images in the album directory, with "folder.*" in first
-  def self.images(path)
-    path = path.dup.force_encoding("binary")
-    arr = Dir.glob( File.join(path, "*.{#{IMAGE_EXTENSIONS.join(",")}}"), File::FNM_CASEFOLD).collect do |f| 
-      File.expand_path(f)
-    end
-    # move "folder.*" image on top of the array
-    if folder = arr.detect { |f| f =~ /folder\.[^.]+$/ }
-      arr.delete(folder)
-      arr.unshift(folder)
+    # return the list of images in the album directory, with "folder.*" in first
+    def self.images(path)
+      path = path.dup.force_encoding('binary')
+      arr = Dir.glob(File.join(path, "*.{#{IMAGE_EXTENSIONS.join(',')}}"), File::FNM_CASEFOLD).collect do |f|
+        File.expand_path(f)
+      end
+      # move "folder.*" image on top of the array
+      if folder = arr.detect { |f| f =~ /folder\.[^.]+$/ }
+        arr.delete(folder)
+        arr.unshift(folder)
+      end
+      arr
     end
-    arr
-  end
 
-  # strip the "multicd" string from the given +name+
-  def self.basename(name)
-    name.sub(MULTICD_REGEXP, '')
-  end
+    # strip the "multicd" string from the given +name+
+    def self.basename(name)
+      name.sub(MULTICD_REGEXP, '')
+    end
 
-  # return the number of the disc in the box or 0
-  def self.discnum(name)
-    if name =~ MULTICD_REGEXP
-      $3.to_i
-    else
-      0
+    # return the number of the disc in the box or 0
+    def self.discnum(name)
+      if name =~ MULTICD_REGEXP
+        Regexp.last_match(3).to_i
+      else
+        0
+      end
     end
-  end
 
-  # open the Album with +path+. +fast_lookup+ will only check 
-  # first and last file of the directory
-  def initialize(path, fast_lookup = false)
-    @path = path
-    @multicd = false
-    @basename = @path
-    exts = AudioInfo::SUPPORTED_EXTENSIONS.collect do |ext|
-      ext.gsub(/[a-z]/) { |c| "[#{c.downcase}#{c.upcase}]" }
-    end.join(",")
+    # open the Album with +path+. +fast_lookup+ will only check
+    # first and last file of the directory
+    def initialize(path, fast_lookup = false)
+      @path = path
+      @multicd = false
+      @basename = @path
+      exts = AudioInfo::SUPPORTED_EXTENSIONS.collect do |ext|
+        ext.gsub(/[a-z]/) { |c| "[#{c.downcase}#{c.upcase}]" }
+      end.join(',')
 
-    # need to escape the glob path
-    glob_escaped_path = @path.gsub(/([{}?*\[\]])/) { |s| '\\' << s }
+      # need to escape the glob path
+      glob_escaped_path = @path.gsub(/([{}?*\[\]])/) { |s| '\\' << s }
 
-    glob_val = File.join(glob_escaped_path, "*.{#{exts}}")
-    file_names = Dir.glob(glob_val).sort
+      glob_val = File.join(glob_escaped_path, "*.{#{exts}}")
+      file_names = Dir.glob(glob_val).sort
 
-    if fast_lookup
-      file_names = [file_names.first, file_names.last]
+      file_names = [file_names.first, file_names.last] if fast_lookup
+
+      @files = file_names.collect do |f|
+        AudioInfo.new(f)
+      end
+
+      @infos = {}
+      @infos['album'] = @files.collect(&:album).uniq
+      @infos['album'] = @infos['album'].first if @infos['album'].size == 1
+      artists = @files.collect(&:artist).uniq
+      @infos['artist'] = artists.size > 1 ? 'various' : artists.first
+      @discnum = self.class.discnum(@infos['album'])
+
+      unless @discnum.zero?
+        @multicd = true
+        @basename = self.class.basename(@infos['album'])
+      end
     end
 
-    @files = file_names.collect do |f|
-      AudioInfo.new(f) 
+    # is the album empty?
+    def empty?
+      @files.empty?
     end
 
-    @infos = {}
-    @infos["album"] = @files.collect { |i| i.album }.uniq
-    @infos["album"] = @infos["album"].first if @infos["album"].size == 1
-    artists = @files.collect { |i| i.artist }.uniq
-    @infos["artist"] = artists.size > 1 ? "various" : artists.first
-    @discnum = self.class.discnum(@infos["album"])
+    # are all the files of the album MusicBrainz tagged ?
+    def mb_tagged?
+      return false if @files.empty?
 
-    if not @discnum.zero?
-      @multicd = true
-      @basename = self.class.basename(@infos["album"])
+      mb = true
+      @files.each do |f|
+        mb &&= f.mb_tagged?
+      end
+      mb
     end
-  end
 
-  # is the album empty?
-  def empty?
-    @files.empty?
-  end
+    # return an array of images with "folder.*" in first
+    def images
+      self.class.images(@path)
+    end
 
-  # are all the files of the album MusicBrainz tagged ?
-  def mb_tagged?
-    return false if @files.empty?
-    mb = true
-    @files.each do |f|
-      mb &&= f.mb_tagged?
+    # title of the album
+    def title
+      # count the occurences of the title and take the one who has most
+      hash_counted = files.collect(&:album).each_with_object(Hash.new(0)) { |album, hash| hash[album] += 1; }
+      if hash_counted.empty?
+        nil
+      else
+        hash_counted.max_by { |_k, v| v }[0]
+      end
     end
-    mb
-  end
 
-  # return an array of images with "folder.*" in first
-  def images
-    self.class.images(@path)
-  end
+    # mbid (MusicBrainz ID) of the album
+    def mbid
+      return nil unless mb_tagged?
 
-  # title of the album
-  def title
-    # count the occurences of the title and take the one who has most 
-    hash_counted = self.files.collect { |f| f.album }.inject(Hash.new(0)) { |hash, album| hash[album] += 1; hash }
-    if hash_counted.empty?
-      nil
-    else
-      hash_counted.sort_by { |k, v| v }.last[0]
+      @files.collect { |f| f.musicbrainz_infos['albumid'] }.uniq.first
     end
-  end
-
-  # mbid (MusicBrainz ID) of the album
-  def mbid
-    return nil unless mb_tagged?
-    @files.collect { |f| f.musicbrainz_infos["albumid"] }.uniq.first
-  end
 
-  # is the album multi-artist?
-  def va?
-    @files.collect { |f| f.artist }.uniq.size > 1
-  end
+    # is the album multi-artist?
+    def va?
+      @files.collect(&:artist).uniq.size > 1
+    end
 
-  # pretty print
-  def to_s
-    out = StringIO.new
-    out.puts(@path)
-    out.print "'#{title}'"
+    # pretty print
+    def to_s
+      out = StringIO.new
+      out.puts(@path)
+      out.print "'#{title}'"
 
-    unless va?
-      out.print " by '#{@files.first.artist}' "
-    end
+      out.print " by '#{@files.first.artist}' " unless va?
 
-    out.puts
+      out.puts
 
-    @files.sort_by { |f| f.tracknum }.each do |f|
-      out.printf("%02d %s %3d %s", f.tracknum, f.extension, f.bitrate, f.title)
-      if va?
-	      out.print(" "+f.artist)
+      @files.sort_by(&:tracknum).each do |f|
+        out.printf('%02d %s %3d %s', f.tracknum, f.extension, f.bitrate, f.title)
+        out.print(" #{f.artist}") if va?
+        out.puts
       end
-      out.puts
-    end
 
-    out.string
-  end
+      out.string
+    end
 
-  def inspect
-    @infos.inspect
+    def inspect
+      @infos.inspect
+    end
   end
 end

data/lib/audioinfo/case_insensitive_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CaseInsensitiveHash < Hash
   def initialize(hash = {})
     super
@@ -5,7 +7,7 @@ class CaseInsensitiveHash < Hash
       self[key.downcase] = value
     end
   end
-  
+
   def [](key)
     super(key.downcase)
   end

data/lib/audioinfo/mpcinfo.rb

@@ -1,13 +1,13 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
-require "stringio"
-require "mp3info/id3v2"
+require 'stringio'
+require 'mp3info/id3v2'
 
 class MpcInfoError < StandardError; end
 
 class MpcInfo
-
-  PROFILES_NAMES = [ 
+  PROFILES_NAMES = [
     'no profile',
     'Experimental',
     'unused',
@@ -24,17 +24,20 @@ class MpcInfo
     'BrainDead (q = 8.0)',
     'above BrainDead (q = 9.0)',
     'above BrainDead (q = 10.0)'
-  ]
+  ].freeze
 
-  FREQUENCIES = [ 44100, 48000, 37800, 32000 ]
+  FREQUENCIES = [44_100, 48_000, 37_800, 32_000].freeze
 
-  SV4_6_HEADER = Regexp.new('^[\x00\x01\x10\x11\x40\x41\x50\x51\x80\x81\x90\x91\xC0\xC1\xD0\xD1][\x20-37][\x00\x20\x40\x60\x80\xA0\xC0\xE0]/', nil, 'n')
+  SV4_6_HEADER = Regexp.new(
+    '^[\x00\x01\x10\x11\x40\x41\x50\x51\x80\x81\x90\x91\xC0\xC1\xD0\xD1][\x20-37][\x00\x20\x40\x60\x80\xA0\xC0\xE0]/',
+    nil,
+    'n'
+  )
 
-  attr_reader :infos
-  attr_reader :id3v2_tag
+  attr_reader :infos, :id3v2_tag
 
   def initialize(filename)
-    @file = File.open(filename, "rb")
+    @file = File.open(filename, 'rb')
 
     @infos = {}
     @infos['raw'] = {}
@@ -46,21 +49,20 @@ class MpcInfo
   def parse_infos
     mpc_header = @file.read(3)
 
-    if mpc_header == "MP+"
+    case mpc_header
+    when 'MP+'
       # this is SV7+
-      
+
       header = StringIO.new(@file.read(25))
       header_size = 28
-      #stream_version_byte = header.read(4).unpack("V").first 
-      stream_version_byte = header.read(1)[0].ord #.unpack("c").first 
+      # stream_version_byte = header.read(4).unpack("V").first
+      stream_version_byte = header.read(1)[0].ord # .unpack("c").first
 
       @infos['stream_major_version'] = (stream_version_byte & 0x0F)
       @infos['stream_minor_version'] = (stream_version_byte & 0xF0) >> 4
 
       @infos['frame_count']          = read32(header)
-      if @infos['stream_major_version'] != 7
-        raise(MpcInfoError, "Only Musepack SV7 supported")
-      end
+      raise(MpcInfoError, 'Only Musepack SV7 supported') if @infos['stream_major_version'] != 7
 
       flags_dword1 = read32(header)
 
@@ -83,103 +85,98 @@ class MpcInfo
       @infos['true_gapless']           = ((flags_dword2 & 0x80000000) >> 31) == 1
       @infos['last_frame_length']      = (flags_dword2 & 0x7FF00000) >> 20
 
-
-      not_sure_what   = read32(header, 3)
+      not_sure_what = read32(header, 3)
       @infos['raw']['encoder_version'] = read8(header)
-		
-      @infos['profile']     = PROFILES_NAMES[ @infos['raw']['profile'] ] || 'invalid'
-      @infos['sample_rate'] = FREQUENCIES[ @infos['raw']['sample_rate'] ]
 
-      if @infos['sample_rate'] == 0
-        raise(MpcInfoError, 'Corrupt MPC file: frequency == zero')
-      end
+      @infos['profile']     = PROFILES_NAMES[@infos['raw']['profile']] || 'invalid'
+      @infos['sample_rate'] = FREQUENCIES[@infos['raw']['sample_rate']]
 
-      sample_rate = @infos['sample_rate'];
-      channels = 2 #appears to be hardcoded
+      raise(MpcInfoError, 'Corrupt MPC file: frequency == zero') if (@infos['sample_rate']).zero?
+
+      sample_rate = @infos['sample_rate']
+      channels = 2 # appears to be hardcoded
       @infos['samples'] = (((@infos['frame_count'] - 1) * 1152) + @infos['last_frame_length']) * channels
       @infos['length'] = (((@infos['frame_count'] - 1) * 1152) + @infos['last_frame_length']) * channels
 
-      @infos['length']     = (@infos['samples'] / channels) / @infos['sample_rate'].to_f
-      if @infos['length'] == 0
-        raise(MpcInfoError, 'Corrupt MPC file: playtime_seconds == zero')
-      end
-	
+      @infos['length'] = (@infos['samples'] / channels) / @infos['sample_rate'].to_f
+      raise(MpcInfoError, 'Corrupt MPC file: playtime_seconds == zero') if (@infos['length']).zero?
+
       # add size of file header to avdataoffset - calc bitrate correctly + MD5 data
       avdataoffset = header_size
 
-      # FIXME is $ThisFileInfo['avdataend']  == File.size ????
+      # FIXME: is $ThisFileInfo['avdataend']  == File.size ????
       @infos['bitrate'] = ((@file.stat.size - avdataoffset) * 8) / @infos['length']
 
       @infos['title_peak'] = @infos['raw']['title_peak']
       @infos['title_peak_db'] = @infos['title_peak'].zero? ? 0 : peak_db(@infos['title_peak'])
-      if @infos['raw']['title_gain'] < 0
-        @infos['title_gain_db'] = (32768 + @infos['raw']['title_gain']) / -100.0
-      else
-        @infos['title_gain_db'] = @infos['raw']['title_gain'] / 100.0
-      end
+      @infos['title_gain_db'] = if (@infos['raw']['title_gain']).negative?
+                                  (32_768 + @infos['raw']['title_gain']) / -100.0
+                                else
+                                  @infos['raw']['title_gain'] / 100.0
+                                end
 
-      @infos['album_peak']        = @infos['raw']['album_peak'];
+      @infos['album_peak']        = @infos['raw']['album_peak']
       @infos['album_peak_db']     = @infos['album_peak'].zero? ? 0 : peak_db(@infos['album_peak'])
 
-      if @infos['raw']['album_gain'] < 0
-        @infos['album_gain_db'] = (32768 + @infos['raw']['album_gain']) / -100.0
-      else
-	@infos['album_gain_db'] = @infos['raw']['album_gain'] / 100.0
-      end
-      @infos['encoder_version']   = encoder_version(@infos['raw']['encoder_version'])
-
-=begin
-      #FIXME 
-      $ThisFileInfo['replay_gain']['track']['adjustment'] = @infos['title_gain_db'];
-      $ThisFileInfo['replay_gain']['album']['adjustment'] = @infos['album_gain_db'];
-      if @infos['title_peak'] > 0
-        #$ThisFileInfo['replay_gain']['track']['peak'] = @infos['title_peak']
-      elsif round(@infos['max_level'] * 1.18) > 0)
-        # ThisFileInfo['replay_gain']['track']['peak'] = getid3_lib::CastAsInt(round(@infos['max_level'] * 1.18)); // why? I don't know - see mppdec.c
-      end
-
-      if @infos['album_peak'] > 0
-	      #$ThisFileInfo['replay_gain']['album']['peak'] = @infos['album_peak'];
-      end
-
-      #ThisFileInfo['audio']['encoder'] = 'SV'.@infos['stream_major_version'].'.'.@infos['stream_minor_version'].', '.@infos['encoder_version'];
-      #$ThisFileInfo['audio']['encoder'] = @infos['encoder_version'];
-      #$ThisFileInfo['audio']['encoder_options'] = @infos['profile'];
-=end
-    elsif mpc_header =~ SV4_6_HEADER
+      @infos['album_gain_db'] = if (@infos['raw']['album_gain']).negative?
+                                  (32_768 + @infos['raw']['album_gain']) / -100.0
+                                else
+                                  @infos['raw']['album_gain'] / 100.0
+                                end
+      @infos['encoder_version'] = encoder_version(@infos['raw']['encoder_version'])
+
+    #       #FIXME
+    #       $ThisFileInfo['replay_gain']['track']['adjustment'] = @infos['title_gain_db'];
+    #       $ThisFileInfo['replay_gain']['album']['adjustment'] = @infos['album_gain_db'];
+    #       if @infos['title_peak'] > 0
+    #         #$ThisFileInfo['replay_gain']['track']['peak'] = @infos['title_peak']
+    #       elsif round(@infos['max_level'] * 1.18) > 0)
+    #         // why? I don't know - see mppdec.c
+    #         # ThisFileInfo['replay_gain']['track']['peak'] = getid3_lib::CastAsInt(round(@infos['max_level'] * 1.18));
+    #       end
+    #
+    #       if @infos['album_peak'] > 0
+    # 	      #$ThisFileInfo['replay_gain']['album']['peak'] = @infos['album_peak'];
+    #       end
+    #
+    #       #ThisFileInfo['audio']['encoder'] =
+    #       #  'SV'.@infos['stream_major_version'].'.'.@infos['stream_minor_version'].', '.@infos['encoder_version'];
+    #       #$ThisFileInfo['audio']['encoder'] = @infos['encoder_version'];
+    #       #$ThisFileInfo['audio']['encoder_options'] = @infos['profile'];
+    when SV4_6_HEADER
       # this is SV4 - SV6, handle seperately
       header_size = 8
-    elsif mpc_header == "ID3"
+    when 'ID3'
       @id3v2_tag = ID3v2.new
       @id3v2_tag.from_io(@file)
       @file.seek(@id3v2_tag.io_position)
       # very dirty hack to allow parsing of mpc infos after id3v2 tag
-      while @file.read(1) != "M"; end
-      if @file.read(2) == "P+"
+      while @file.read(1) != 'M'; end
+      if @file.read(2) == 'P+'
         @file.seek(-3, IO::SEEK_CUR)
         # we need to reparse the tag, since we have the beggining of the mpc file
         parse_infos
       else
-        raise(MpcInfoError, "cannot find MPC header after id3 tag")
+        raise(MpcInfoError, 'cannot find MPC header after id3 tag')
       end
     else
-      raise(MpcInfoError, "cannot find MPC header")
+      raise(MpcInfoError, 'cannot find MPC header')
     end
   end
-  
+
   def read8(io)
     io.read(1)[0].ord
   end
 
   def read16(io)
-    io.read(2).unpack("v").first
+    io.read(2).unpack1('v')
   end
 
   def read32(io, size = 4)
-    io.read(size).unpack("V").first
+    io.read(size).unpack1('V')
   end
 
-  def peak_db(i) 
+  def peak_db(i)
     ((Math.log10(i) / Math.log10(2)) - 15) * 6
   end
 
@@ -189,25 +186,24 @@ class MpcInfo
     # EncoderVersion %  2 == 0        Beta (1.06)
     # EncoderVersion %  2 == 1        Alpha (1.05a...z)
 
-    if encoderversion == 0
+    if encoderversion.zero?
       # very old version, not known exactly which
-      'Buschmann v1.7.0-v1.7.9 or Klemm v0.90-v1.05';
-    elsif encoderversion % 10 == 0
+      'Buschmann v1.7.0-v1.7.9 or Klemm v0.90-v1.05'
+    elsif (encoderversion % 10).zero?
       # release version
-      sprintf("%.2f", encoderversion/100.0)
-    elsif encoderversion % 2 == 0
-      sprintf("%.2f beta", encoderversion / 100.0)
+      format('%.2f', encoderversion / 100.0)
+    elsif encoderversion.even?
+      format('%.2f beta', encoderversion / 100.0)
     else
-      sprintf("%.2f alpha", encoderversion/100.0)
+      format('%.2f alpha', encoderversion / 100.0)
     end
   end
-
 end
 
-if __FILE__ == $0
-  require "pp"
+if __FILE__ == $PROGRAM_NAME
+  require 'pp'
 
   mpcinfo = MpcInfo.new(ARGV[0])
   pp mpcinfo.infos.sort
-  
+
 end