ruboty-github_assignor 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b4f189154d3633ba2c3bf0e70cea9234251b43bd
-  data.tar.gz: cd236b8776e7579ac0704c1abe5c7e75e0d7fe2e
+  metadata.gz: 67330e6c1b98d85adb47bb8bf12a4f1414a59b13
+  data.tar.gz: 4054e335ad22e25c1e14d8666e8f64360281912f
 SHA512:
-  metadata.gz: f9ce12f320ee1d3c2ad2fe06ab1b9fd855161b68e1e48a33082bf05907c3d189fd3d588363835913ebbf88ab90095cc0650120b54f900121bcdf417fc0f54dfc
-  data.tar.gz: dde4baa295adf27d5cedd7fdb1178b2c28a1bae47d837c4619a80cdc4a0b69bef6c7b82f5878bf1d51a256f8e62f3b702aba67eb1c9b4987b3b1552857eeb075
+  metadata.gz: 97b474de37e720314d5b89e0010da2a66936bbf1a5aab75837cef1197baf6a5612f0058068e17479021ef7795a52dbe4ddd0d5bb177a22c42b7c540057694839
+  data.tar.gz: 8deb62744daa469b526cb3007c7314fdf5fa73b2d18e89c7c08de7dade175c3d4eda3a35d00a92419c2733fbfda8d556a8275e6ff09b8ba5b62e0f58890f885b

data/lib/ruboty/github_assignor/repo_watcher.rb

@@ -3,12 +3,13 @@ require 'octokit'
 module Ruboty
   module GithubAssignor
     class RepoWatcher
-      def initialize(robot:, repo:, octokit:, assignor:, to:)
+      def initialize(robot:, repo:, octokit:, assignor:, to:, messages:)
         @robot = robot
         @repo = repo
         @octokit = octokit
         @assignor = assignor
         @to = to
+        @messages = messages
 
         @checked_issue_ids = []
 
@@ -21,7 +22,8 @@ module Ruboty
         @octokit.issues(@repo).each do |issue|
           unless @checked_issue_ids.include?(issue[:id])
             log "New issue found (#{issue[:id]} / #{issue[:title]})"
-            if assign && !issue[:assignee]
+            message = find_message(issue)
+            if message && assign && !issue[:assignee]
               # assign this issue
               assignee = @assignor.next
               log "Assigning this issue to #{assignee}..."
@@ -31,7 +33,7 @@ module Ruboty
 
               log "Reminding the user of the issue..."
               say(<<-EOC)
-@#{assignee.chat_name} さん、お願いします！
+@#{assignee.chat_name} さん、#{message['message']}お願いします！
 
 #{issue[:title]}
 <#{issue[:html_url]}>
@@ -60,6 +62,37 @@ module Ruboty
 
       private
 
+      # messages
+      # [
+      #   {
+      #     "message": "レビュー",
+      #     "conditions": [{
+      #       "keywords": [...], # AND
+      #       "including_mention": true/false,
+      #     }],
+      #   }
+      # ]
+      def find_message(issue)
+        body = issue[:body] || ''
+        including_mention = (/(^| )@\w+/ =~ body)
+
+        @messages.find do |message|
+          message['conditions'].any? do |condition|
+            if condition.has_key?('including_mention') &&
+              (condition['including_mention'] && !including_mention ||
+               !condition['including_mention'] && including_mention)
+              next false
+            end
+
+            including_all_keywords = condition['keywords'].all? do |keyword|
+              body.downcase.include?(keyword.downcase)
+            end
+
+            including_all_keywords
+          end
+        end
+      end
+
       def say(body)
         from = if @robot.send(:adapter).respond_to?(:jid, true)
                  @robot.send(:adapter).send(:jid)

data/lib/ruboty/github_assignor/version.rb

@@ -1,5 +1,5 @@
 module Ruboty
   module GithubAssignor
-    VERSION = "0.0.2"
+    VERSION = "0.0.3"
   end
 end

data/lib/ruboty/handlers/github_assignor.rb

@@ -24,6 +24,7 @@ module Ruboty
         data.each do |datum|
           repo = datum['repo']
           to = datum['to']
+          messages = datum['messages'] || []
           assignees = datum['assignees'].map {|assignee| Hash[assignee.map {|k, v| [k.to_sym, v] }] }
           assignor = Ruboty::GithubAssignor::Assignor.new(assignees)
 
@@ -33,6 +34,7 @@ module Ruboty
             octokit: octokit,
             assignor: assignor,
             to: to,
+            messages: messages,
           )
           watcher.start((ENV['GITHUB_ASSIGNOR_INTERVAL'] || 60).to_i)
         end

data/spec/fixtures/issues2.json

@@ -84,7 +84,7 @@
     "number": 1347,
     "state": "open",
     "title": "Found a bug",
-    "body": "I'm having a problem with this.",
+    "body": "Please review this.",
     "user": {
       "login": "octocat",
       "id": 1,

data/spec/ruboty/github_assignor/repo_watcher_spec.rb

@@ -17,6 +17,15 @@ describe Ruboty::GithubAssignor::RepoWatcher do
       octokit: octokit,
       assignor: assignor,
       to: 'room',
+      messages: [
+        {
+          'message' => 'レビュー',
+          'conditions' => [{
+            'including_mention' => false,
+            'keywords' => %w!please review!,
+          }],
+        },
+      ],
     )
   end
 
@@ -38,7 +47,7 @@ describe Ruboty::GithubAssignor::RepoWatcher do
 
       expect(robot).to receive(:say).with(
         hash_including(body: <<-EOC)
-@alice さん、お願いします！
+@alice さん、レビューお願いします！
 
 Found a bug
 <https://github.com/octocat/Hello-World/issues/1347>

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+ENV.delete('OCTOKIT_API_ENDPOINT')
+
 require 'ruboty/github_assignor'
 require 'webmock/rspec'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruboty-github_assignor
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Ryota Arai
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-13 00:00:00.000000000 Z
+date: 2014-12-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruboty