ruborg 0.7.5 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 288150d1a678f2df71346d94b797019f31a52008de43663aa19cb9fd3584d5a6
-  data.tar.gz: 460fe4bff0085989bc9a2d2ae4db7ae4591aff9a928ae9d320cd079d4d6a276d
+  metadata.gz: 8cc86659dca9c85fca163fd08ad8f23d4a0ca296cb32944274f6ae87e0086751
+  data.tar.gz: 2fb298807e3960026917f05a0552161c4d778cc7102ac62150b41710c8f0b1a7
 SHA512:
-  metadata.gz: 34f36001b129d8e0bd005ba1e908361df50df198626fe98b5015afa6cbce2860b055086e87c6f81e4aebec101c1297832b525d78e1ce995d5582d40ee9065eaf
-  data.tar.gz: b881f8bbd05e49893afb7213ab22d64d01117f3dedbdee6772b80720489d367b7a2bb6a1c33a9e63161f6673b3683198b33010a7c54dcf70e38e56461f7ec1ee
+  metadata.gz: 8443ac13e208645f5bce4126961c7c765b33f22038a2fcf92aedff110e3c3cc1def4db52c3c847c4aae13d3d8871c02dd00d67d71ec6d37698ad2084044954df
+  data.tar.gz: 33707f77cffb7e756fe0446786cd11807bf2f168b6b40ba40efc5ff4854017ec9871fe48127047f574d35e6fad376a32fcc5d348536b76079edaf14755dbc40e

data/CHANGELOG.md

@@ -7,6 +7,34 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.8.0] - 2025-10-09
+
+### Removed
+- **chattr/lsattr Functionality**: Completely removed Linux immutable attribute handling
+  - The feature caused issues with network filesystems (CIFS/SMB, NFS) that don't support chattr
+  - Users with truly immutable files should remove the attribute manually before using `--remove-source`
+  - Simplifies code and eliminates filesystem compatibility issues
+  - `--remove-source` now relies on standard file permissions only
+
+### Changed
+- File deletion now uses standard Ruby FileUtils methods without chattr checks
+- Improved compatibility with all filesystem types (local, network, cloud)
+
+## [0.7.6] - 2025-10-09
+
+### Fixed
+- **Filesystem Compatibility**: Gracefully handle filesystems that don't support chattr operations
+  - Network filesystems (NFS, CIFS/SMB) and non-Linux filesystems (NTFS, FAT, exFAT) often don't support Linux file attributes
+  - When chattr fails with "Operation not supported", log warning and continue with deletion
+  - Allows `--remove-source` to work on network shares and external drives
+  - Fixes error: "Cannot remove immutable file: ... Error: chattr: Operation not supported"
+
+### Technical Details
+- Detects "Operation not supported" error from chattr command (lib/ruborg/backup.rb:394)
+- Logs informative warning about filesystem limitations
+- Continues with file deletion (no longer raises error)
+- Test coverage: Added comprehensive test for unsupported filesystem scenario
+
 ## [0.7.5] - 2025-10-09
 
 ### Added

data/README.md

@@ -398,25 +398,6 @@ Error: Cannot use --remove-source: 'allow_remove_source' must be true (boolean).
 Current value: "true" (String). Set 'allow_remove_source: true' in configuration.
 ```
 
-**📌 Immutable File Handling (Linux)**
-
-Ruborg automatically detects and removes Linux immutable attributes (`chattr +i`) when deleting files with `--remove-source`:
-
-- **Automatic Detection**: Checks files with `lsattr` before deletion
-- **Automatic Removal**: Removes immutable flag with `chattr -i` if present
-- **Platform-Aware**: Gracefully skips on non-Linux systems (macOS, BSD, etc.)
-- **Comprehensive**: Works for both single files and directories (recursive)
-- **Logged**: All immutable attribute operations are logged for audit trail
-
-**Root Privileges**: If your files have immutable attributes, you'll need root privileges to remove them. Configure sudoers for ruborg:
-
-```bash
-# /etc/sudoers.d/ruborg
-michail ALL=(root) NOPASSWD: /usr/local/bin/ruborg
-```
-
-This allows running ruborg with sudo for file deletion without password prompts.
-
 ### List Archives
 
 ```bash

data/SECURITY.md

@@ -19,15 +19,7 @@ Ruborg implements several security measures to protect your backup operations:
 - Refuses to delete system directories even when targeted via symlinks
 - Uses `FileUtils.rm_rf` with `secure: true` option
 
-### 4. Immutable File Handling (Linux)
-- **Automatic Detection**: Checks for Linux immutable attributes (`lsattr`) before file deletion
-- **Safe Removal**: Removes immutable flag (`chattr -i`) only when necessary for deletion
-- **Platform-Aware**: Feature only active on Linux systems with lsattr/chattr commands available
-- **Error Handling**: Raises informative errors if immutable flag cannot be removed
-- **Audit Trail**: All immutable attribute operations are logged for security auditing
-- **Root Required**: Removing immutable attributes requires root privileges (use sudo with appropriate sudoers configuration)
-
-### 5. Safe YAML Loading
+### 4. Safe YAML Loading
 - Uses `YAML.safe_load_file` to prevent arbitrary code execution
 - Rejects YAML files containing Ruby objects or other dangerous constructs
 - Only permits basic data types and Symbol class

data/lib/ruborg/backup.rb

@@ -361,58 +361,10 @@ module Ruborg
         raise BorgError, "Refusing to delete system path: #{real_path}"
       end
 
-      # Check for immutable attribute and remove it if present
-      remove_immutable_attribute(real_path)
-
       @logger&.info("Removing file: #{real_path}")
       FileUtils.rm(real_path)
     end
 
-    def remove_immutable_attribute(file_path)
-      # Check if lsattr command is available (Linux only)
-      return unless system("which lsattr > /dev/null 2>&1")
-
-      # Get file attributes
-      require "open3"
-      stdout, stderr, status = Open3.capture3("lsattr", file_path)
-
-      unless status.success?
-        @logger&.warn("Could not check attributes for #{file_path}: #{stderr.strip}")
-        return
-      end
-
-      # Check if immutable flag is set (format: "----i--------e----- /path/to/file")
-      # Extract the flags portion (everything before the file path)
-      flags = stdout.split.first || ""
-      return unless flags.include?("i")
-
-      @logger&.info("Removing immutable attribute from: #{file_path}")
-      _chattr_stdout, chattr_stderr, chattr_status = Open3.capture3("chattr", "-i", file_path)
-
-      unless chattr_status.success?
-        @logger&.error("Failed to remove immutable attribute from #{file_path}: #{chattr_stderr.strip}")
-        raise BorgError, "Cannot remove immutable file: #{file_path}. Error: #{chattr_stderr.strip}"
-      end
-
-      @logger&.info("Successfully removed immutable attribute from: #{file_path}")
-    end
-
-    def remove_immutable_from_directory(dir_path)
-      # Check if lsattr command is available (Linux only)
-      return unless system("which lsattr > /dev/null 2>&1")
-
-      require "find"
-      require "open3"
-
-      # Remove immutable from directory itself
-      remove_immutable_attribute(dir_path)
-
-      # Recursively remove immutable from all files in directory
-      Find.find(dir_path) do |path|
-        remove_immutable_attribute(path) if File.file?(path)
-      end
-    end
-
     def remove_source_files
       require "fileutils"
 
@@ -446,12 +398,8 @@ module Ruborg
         @logger&.info("Removing #{file_type}: #{real_path}")
 
         if File.directory?(real_path)
-          # Remove immutable attributes from all files in directory
-          remove_immutable_from_directory(real_path)
           FileUtils.rm_rf(real_path, secure: true)
         elsif File.file?(real_path)
-          # Remove immutable attribute from single file
-          remove_immutable_attribute(real_path)
           FileUtils.rm(real_path)
         end
 

data/lib/ruborg/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ruborg
-  VERSION = "0.7.5"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruborg
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.8.0
 platform: ruby
 authors:
 - Michail Pantelelis