ruborg 0.7.4 → 0.7.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b7697818fdf4537e02f840cb2f30c71cc3cbd6bbfc8cb8b72fe4bba7908deac
-  data.tar.gz: 2c509aec3d6586f7f3ea85aa84a621516e8ea73cd191ff325f8c33f056eb5a15
+  metadata.gz: 6bf325414affb3c4e36149069cf2e07958d43bef4766765a32aa9e2d97dbda02
+  data.tar.gz: 17dc1a6fabbf9571c9b5568cd098e272de0292f593c8ca6bc2e650d6756dca44
 SHA512:
-  metadata.gz: 711e51216fcc8e7522d32567f4a1759dccadb2d9691599b6408eb2f46187586dca3e837b45f7a7044a15117747b3a39ff5b083254ada2fd64f8e88f1c01e9f22
-  data.tar.gz: d7d2a732e8fbf38b33a2a5b39d35a820b98f22d3515656663c4e64fc8b589ca7ad5f49441e00f0b117118b04fe13c6ca036c28bcc6109b387a67275b5b8e7d1d
+  metadata.gz: 46ccdff766a5d7b3b6d2e19fbc1dd4c2b57202a799a14d66683299b9f2d162ce8f7889c6ebe8f8e925fc358c22ad6a4e0253a95b07d40635fe98a71f74bab5a1
+  data.tar.gz: e1663b45f75858b0197ce89e8803f95da4d104a8b7e4b7398baeaecd9033e469aeec8f2d74c6f21eb72e16ba77d848a2e651b6e58590f7a0a0de1fb5f553998e

data/CHANGELOG.md

@@ -7,6 +7,39 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.7.6] - 2025-10-09
+
+### Fixed
+- **Filesystem Compatibility**: Gracefully handle filesystems that don't support chattr operations
+  - Network filesystems (NFS, CIFS/SMB) and non-Linux filesystems (NTFS, FAT, exFAT) often don't support Linux file attributes
+  - When chattr fails with "Operation not supported", log warning and continue with deletion
+  - Allows `--remove-source` to work on network shares and external drives
+  - Fixes error: "Cannot remove immutable file: ... Error: chattr: Operation not supported"
+
+### Technical Details
+- Detects "Operation not supported" error from chattr command (lib/ruborg/backup.rb:394)
+- Logs informative warning about filesystem limitations
+- Continues with file deletion (no longer raises error)
+- Test coverage: Added comprehensive test for unsupported filesystem scenario
+
+## [0.7.5] - 2025-10-09
+
+### Added
+- **Automatic Immutable Attribute Removal**: Ruborg now automatically detects and removes Linux immutable flags (`chattr +i`) when deleting files with `--remove-source`
+  - Checks files with `lsattr` before deletion
+  - Removes immutable flag with `chattr -i` if present
+  - Works for both single files (per-file mode) and directories (standard mode)
+  - Gracefully handles systems without lsattr/chattr (macOS, etc.)
+  - Logs all immutable attribute operations for audit trail
+
+### Technical Details
+- Per-file mode: Checks each file individually before deletion (lib/ruborg/backup.rb:365)
+- Standard mode: Recursively removes immutable from all files in directory (lib/ruborg/backup.rb:400-414)
+- Linux-only feature - silently skips on other platforms
+- Raises error if chattr command fails with proper error context
+- Immutable flag detection uses precise parsing of lsattr flags field (lib/ruborg/backup.rb:386-387)
+- Test coverage: 6 comprehensive specs covering all immutable file scenarios
+
 ## [0.7.4] - 2025-10-09
 
 ### Fixed

data/README.md

@@ -398,6 +398,25 @@ Error: Cannot use --remove-source: 'allow_remove_source' must be true (boolean).
 Current value: "true" (String). Set 'allow_remove_source: true' in configuration.
 ```
 
+**📌 Immutable File Handling (Linux)**
+
+Ruborg automatically detects and removes Linux immutable attributes (`chattr +i`) when deleting files with `--remove-source`:
+
+- **Automatic Detection**: Checks files with `lsattr` before deletion
+- **Automatic Removal**: Removes immutable flag with `chattr -i` if present
+- **Platform-Aware**: Gracefully skips on non-Linux systems (macOS, BSD, etc.)
+- **Comprehensive**: Works for both single files and directories (recursive)
+- **Logged**: All immutable attribute operations are logged for audit trail
+
+**Root Privileges**: If your files have immutable attributes, you'll need root privileges to remove them. Configure sudoers for ruborg:
+
+```bash
+# /etc/sudoers.d/ruborg
+michail ALL=(root) NOPASSWD: /usr/local/bin/ruborg
+```
+
+This allows running ruborg with sudo for file deletion without password prompts.
+
 ### List Archives
 
 ```bash

data/SECURITY.md

@@ -19,7 +19,15 @@ Ruborg implements several security measures to protect your backup operations:
 - Refuses to delete system directories even when targeted via symlinks
 - Uses `FileUtils.rm_rf` with `secure: true` option
 
-### 4. Safe YAML Loading
+### 4. Immutable File Handling (Linux)
+- **Automatic Detection**: Checks for Linux immutable attributes (`lsattr`) before file deletion
+- **Safe Removal**: Removes immutable flag (`chattr -i`) only when necessary for deletion
+- **Platform-Aware**: Feature only active on Linux systems with lsattr/chattr commands available
+- **Error Handling**: Raises informative errors if immutable flag cannot be removed
+- **Audit Trail**: All immutable attribute operations are logged for security auditing
+- **Root Required**: Removing immutable attributes requires root privileges (use sudo with appropriate sudoers configuration)
+
+### 5. Safe YAML Loading
 - Uses `YAML.safe_load_file` to prevent arbitrary code execution
 - Rejects YAML files containing Ruby objects or other dangerous constructs
 - Only permits basic data types and Symbol class
@@ -229,6 +237,20 @@ We will respond within 48 hours and work with you to address the issue.
 
 ## Security Audit History
 
+- **v0.7.5** (2025-10-09): Immutable file handling - security review passed
+  - **NEW FEATURE**: Automatic detection and removal of Linux immutable attributes (`chattr +i`) when deleting files with `--remove-source`
+  - **PLATFORM-AWARE**: Feature only active on Linux systems with lsattr/chattr commands available
+  - **SAFE OPERATION**: Checks files with `lsattr` before deletion, removes immutable flag with `chattr -i` only when necessary
+  - **ERROR HANDLING**: Raises informative errors if immutable flag cannot be removed (operation not permitted)
+  - **AUDIT TRAIL**: All immutable attribute operations logged for security monitoring
+  - **ROOT REQUIRED**: Removing immutable attributes requires root privileges (documented sudoers configuration)
+  - **SECURITY REVIEW**: No new security vulnerabilities introduced
+  - Uses Open3.capture3 for safe command execution (no shell injection)
+  - Precise flag parsing prevents false positives from filenames containing 'i'
+  - Works for both single files (per-file mode) and directories (recursive, standard mode)
+  - Gracefully handles systems without lsattr/chattr (macOS, BSD, etc.)
+  - Test coverage: 6 comprehensive specs covering all scenarios
+
 - **v0.7.1** (2025-10-08): Paranoid mode duplicate detection - security review passed
   - **NEW FEATURE**: SHA256 content hashing for detecting file changes even when mtime/size are identical
   - **NEW FEATURE**: Smart skip statistics showing backed-up and skipped file counts

data/lib/ruborg/backup.rb

@@ -361,10 +361,69 @@ module Ruborg
         raise BorgError, "Refusing to delete system path: #{real_path}"
       end
 
+      # Check for immutable attribute and remove it if present
+      remove_immutable_attribute(real_path)
+
       @logger&.info("Removing file: #{real_path}")
       FileUtils.rm(real_path)
     end
 
+    def remove_immutable_attribute(file_path)
+      # Check if lsattr command is available (Linux only)
+      return unless system("which lsattr > /dev/null 2>&1")
+
+      # Get file attributes
+      require "open3"
+      stdout, stderr, status = Open3.capture3("lsattr", file_path)
+
+      unless status.success?
+        @logger&.warn("Could not check attributes for #{file_path}: #{stderr.strip}")
+        return
+      end
+
+      # Check if immutable flag is set (format: "----i--------e----- /path/to/file")
+      # Extract the flags portion (everything before the file path)
+      flags = stdout.split.first || ""
+      return unless flags.include?("i")
+
+      @logger&.info("Removing immutable attribute from: #{file_path}")
+      _chattr_stdout, chattr_stderr, chattr_status = Open3.capture3("chattr", "-i", file_path)
+
+      unless chattr_status.success?
+        # Check if filesystem doesn't support chattr (common with NFS, CIFS, NTFS, etc.)
+        if chattr_stderr.include?("Operation not supported")
+          @logger&.warn(
+            "Filesystem does not support chattr operations for #{file_path}. " \
+            "This is normal for network filesystems (NFS, CIFS) or non-Linux filesystems. " \
+            "Attempting deletion anyway."
+          )
+          return
+        end
+
+        # Other errors (like permission denied) should still raise
+        @logger&.error("Failed to remove immutable attribute from #{file_path}: #{chattr_stderr.strip}")
+        raise BorgError, "Cannot remove immutable file: #{file_path}. Error: #{chattr_stderr.strip}"
+      end
+
+      @logger&.info("Successfully removed immutable attribute from: #{file_path}")
+    end
+
+    def remove_immutable_from_directory(dir_path)
+      # Check if lsattr command is available (Linux only)
+      return unless system("which lsattr > /dev/null 2>&1")
+
+      require "find"
+      require "open3"
+
+      # Remove immutable from directory itself
+      remove_immutable_attribute(dir_path)
+
+      # Recursively remove immutable from all files in directory
+      Find.find(dir_path) do |path|
+        remove_immutable_attribute(path) if File.file?(path)
+      end
+    end
+
     def remove_source_files
       require "fileutils"
 
@@ -398,8 +457,12 @@ module Ruborg
         @logger&.info("Removing #{file_type}: #{real_path}")
 
         if File.directory?(real_path)
+          # Remove immutable attributes from all files in directory
+          remove_immutable_from_directory(real_path)
           FileUtils.rm_rf(real_path, secure: true)
         elsif File.file?(real_path)
+          # Remove immutable attribute from single file
+          remove_immutable_attribute(real_path)
           FileUtils.rm(real_path)
         end
 

data/lib/ruborg/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ruborg
-  VERSION = "0.7.4"
+  VERSION = "0.7.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruborg
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.7.6
 platform: ruby
 authors:
 - Michail Pantelelis