ruborg 0.7.3 → 0.7.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 314fb4f24b1b5544d95257f5d3f315099f221ecc92b7920e935066319db72458
-  data.tar.gz: 0ef7e5183f7596e1417b4b12915557d9c177b0b2504f6a143c7ff8aa59f726aa
+  metadata.gz: 288150d1a678f2df71346d94b797019f31a52008de43663aa19cb9fd3584d5a6
+  data.tar.gz: 460fe4bff0085989bc9a2d2ae4db7ae4591aff9a928ae9d320cd079d4d6a276d
 SHA512:
-  metadata.gz: fb9bcdb3517dc9fd2c1c05d868e8015fd5fe3a55c00e5c277cf7b0257f238535821f8dbcda594dc9bc4b413a8b96d4739d327e1b420f6bad08ac19e724193199
-  data.tar.gz: 6544e4d87969bd59ca7912653ecaebedeca75795f934edb93ad9435a0e48cff5b0c95734aa5bdc70572a38cbed014ea8ac93cff4abee97867a910acba47d5240
+  metadata.gz: 34f36001b129d8e0bd005ba1e908361df50df198626fe98b5015afa6cbce2860b055086e87c6f81e4aebec101c1297832b525d78e1ce995d5582d40ee9065eaf
+  data.tar.gz: b881f8bbd05e49893afb7213ab22d64d01117f3dedbdee6772b80720489d367b7a2bb6a1c33a9e63161f6673b3683198b33010a7c54dcf70e38e56461f7ec1ee

data/CHANGELOG.md

@@ -7,6 +7,38 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.7.5] - 2025-10-09
+
+### Added
+- **Automatic Immutable Attribute Removal**: Ruborg now automatically detects and removes Linux immutable flags (`chattr +i`) when deleting files with `--remove-source`
+  - Checks files with `lsattr` before deletion
+  - Removes immutable flag with `chattr -i` if present
+  - Works for both single files (per-file mode) and directories (standard mode)
+  - Gracefully handles systems without lsattr/chattr (macOS, etc.)
+  - Logs all immutable attribute operations for audit trail
+
+### Technical Details
+- Per-file mode: Checks each file individually before deletion (lib/ruborg/backup.rb:365)
+- Standard mode: Recursively removes immutable from all files in directory (lib/ruborg/backup.rb:400-414)
+- Linux-only feature - silently skips on other platforms
+- Raises error if chattr command fails with proper error context
+- Immutable flag detection uses precise parsing of lsattr flags field (lib/ruborg/backup.rb:386-387)
+- Test coverage: 6 comprehensive specs covering all immutable file scenarios
+
+## [0.7.4] - 2025-10-09
+
+### Fixed
+- **Passbolt Error Reporting**: Enhanced error handling for Passbolt CLI failures
+  - Now captures and logs stderr from Passbolt CLI commands
+  - Error messages include actual Passbolt CLI output for easier debugging
+  - Improved error logging with detailed failure context
+
+### Changed
+- **Passbolt Environment Variables**: Passbolt env vars now explicitly passed to subprocess
+  - Preserves `PASSBOLT_SERVER_ADDRESS`, `PASSBOLT_USER_PRIVATE_KEY_FILE`, `PASSBOLT_USER_PASSWORD`
+  - Also preserves `PASSBOLT_GPG_HOME` and `PASSBOLT_CONFIG`
+  - Ensures Passbolt CLI has access to required configuration when run by Ruborg
+
 ## [0.7.3] - 2025-10-09
 
 ### Changed

data/README.md

@@ -398,6 +398,25 @@ Error: Cannot use --remove-source: 'allow_remove_source' must be true (boolean).
 Current value: "true" (String). Set 'allow_remove_source: true' in configuration.
 ```
 
+**📌 Immutable File Handling (Linux)**
+
+Ruborg automatically detects and removes Linux immutable attributes (`chattr +i`) when deleting files with `--remove-source`:
+
+- **Automatic Detection**: Checks files with `lsattr` before deletion
+- **Automatic Removal**: Removes immutable flag with `chattr -i` if present
+- **Platform-Aware**: Gracefully skips on non-Linux systems (macOS, BSD, etc.)
+- **Comprehensive**: Works for both single files and directories (recursive)
+- **Logged**: All immutable attribute operations are logged for audit trail
+
+**Root Privileges**: If your files have immutable attributes, you'll need root privileges to remove them. Configure sudoers for ruborg:
+
+```bash
+# /etc/sudoers.d/ruborg
+michail ALL=(root) NOPASSWD: /usr/local/bin/ruborg
+```
+
+This allows running ruborg with sudo for file deletion without password prompts.
+
 ### List Archives
 
 ```bash

data/SECURITY.md

@@ -19,7 +19,15 @@ Ruborg implements several security measures to protect your backup operations:
 - Refuses to delete system directories even when targeted via symlinks
 - Uses `FileUtils.rm_rf` with `secure: true` option
 
-### 4. Safe YAML Loading
+### 4. Immutable File Handling (Linux)
+- **Automatic Detection**: Checks for Linux immutable attributes (`lsattr`) before file deletion
+- **Safe Removal**: Removes immutable flag (`chattr -i`) only when necessary for deletion
+- **Platform-Aware**: Feature only active on Linux systems with lsattr/chattr commands available
+- **Error Handling**: Raises informative errors if immutable flag cannot be removed
+- **Audit Trail**: All immutable attribute operations are logged for security auditing
+- **Root Required**: Removing immutable attributes requires root privileges (use sudo with appropriate sudoers configuration)
+
+### 5. Safe YAML Loading
 - Uses `YAML.safe_load_file` to prevent arbitrary code execution
 - Rejects YAML files containing Ruby objects or other dangerous constructs
 - Only permits basic data types and Symbol class
@@ -229,6 +237,20 @@ We will respond within 48 hours and work with you to address the issue.
 
 ## Security Audit History
 
+- **v0.7.5** (2025-10-09): Immutable file handling - security review passed
+  - **NEW FEATURE**: Automatic detection and removal of Linux immutable attributes (`chattr +i`) when deleting files with `--remove-source`
+  - **PLATFORM-AWARE**: Feature only active on Linux systems with lsattr/chattr commands available
+  - **SAFE OPERATION**: Checks files with `lsattr` before deletion, removes immutable flag with `chattr -i` only when necessary
+  - **ERROR HANDLING**: Raises informative errors if immutable flag cannot be removed (operation not permitted)
+  - **AUDIT TRAIL**: All immutable attribute operations logged for security monitoring
+  - **ROOT REQUIRED**: Removing immutable attributes requires root privileges (documented sudoers configuration)
+  - **SECURITY REVIEW**: No new security vulnerabilities introduced
+  - Uses Open3.capture3 for safe command execution (no shell injection)
+  - Precise flag parsing prevents false positives from filenames containing 'i'
+  - Works for both single files (per-file mode) and directories (recursive, standard mode)
+  - Gracefully handles systems without lsattr/chattr (macOS, BSD, etc.)
+  - Test coverage: 6 comprehensive specs covering all scenarios
+
 - **v0.7.1** (2025-10-08): Paranoid mode duplicate detection - security review passed
   - **NEW FEATURE**: SHA256 content hashing for detecting file changes even when mtime/size are identical
   - **NEW FEATURE**: Smart skip statistics showing backed-up and skipped file counts

data/lib/ruborg/backup.rb

@@ -361,10 +361,58 @@ module Ruborg
         raise BorgError, "Refusing to delete system path: #{real_path}"
       end
 
+      # Check for immutable attribute and remove it if present
+      remove_immutable_attribute(real_path)
+
       @logger&.info("Removing file: #{real_path}")
       FileUtils.rm(real_path)
     end
 
+    def remove_immutable_attribute(file_path)
+      # Check if lsattr command is available (Linux only)
+      return unless system("which lsattr > /dev/null 2>&1")
+
+      # Get file attributes
+      require "open3"
+      stdout, stderr, status = Open3.capture3("lsattr", file_path)
+
+      unless status.success?
+        @logger&.warn("Could not check attributes for #{file_path}: #{stderr.strip}")
+        return
+      end
+
+      # Check if immutable flag is set (format: "----i--------e----- /path/to/file")
+      # Extract the flags portion (everything before the file path)
+      flags = stdout.split.first || ""
+      return unless flags.include?("i")
+
+      @logger&.info("Removing immutable attribute from: #{file_path}")
+      _chattr_stdout, chattr_stderr, chattr_status = Open3.capture3("chattr", "-i", file_path)
+
+      unless chattr_status.success?
+        @logger&.error("Failed to remove immutable attribute from #{file_path}: #{chattr_stderr.strip}")
+        raise BorgError, "Cannot remove immutable file: #{file_path}. Error: #{chattr_stderr.strip}"
+      end
+
+      @logger&.info("Successfully removed immutable attribute from: #{file_path}")
+    end
+
+    def remove_immutable_from_directory(dir_path)
+      # Check if lsattr command is available (Linux only)
+      return unless system("which lsattr > /dev/null 2>&1")
+
+      require "find"
+      require "open3"
+
+      # Remove immutable from directory itself
+      remove_immutable_attribute(dir_path)
+
+      # Recursively remove immutable from all files in directory
+      Find.find(dir_path) do |path|
+        remove_immutable_attribute(path) if File.file?(path)
+      end
+    end
+
     def remove_source_files
       require "fileutils"
 
@@ -398,8 +446,12 @@ module Ruborg
         @logger&.info("Removing #{file_type}: #{real_path}")
 
         if File.directory?(real_path)
+          # Remove immutable attributes from all files in directory
+          remove_immutable_from_directory(real_path)
           FileUtils.rm_rf(real_path, secure: true)
         elsif File.file?(real_path)
+          # Remove immutable attribute from single file
+          remove_immutable_attribute(real_path)
           FileUtils.rm(real_path)
         end
 

data/lib/ruborg/passbolt.rb

@@ -17,11 +17,12 @@ module Ruborg
       @logger&.info("Retrieving password from Passbolt (resource_id: #{@resource_id})")
 
       cmd = ["passbolt", "get", "resource", "--id", @resource_id, "--json"]
-      output, status = execute_command(cmd)
+      output, status, error_msg = execute_command(cmd)
 
       unless status
         @logger&.error("Failed to retrieve password from Passbolt for resource #{@resource_id}")
-        raise PassboltError, "Failed to retrieve password from Passbolt"
+        error_detail = error_msg ? ": #{error_msg}" : ""
+        raise PassboltError, "Failed to retrieve password from Passbolt#{error_detail}"
       end
 
       @logger&.info("Successfully retrieved password from Passbolt")
@@ -38,8 +39,29 @@ module Ruborg
 
     def execute_command(cmd)
       require "open3"
-      stdout, _, status = Open3.capture3(*cmd)
-      [stdout, status.success?]
+
+      # Preserve Passbolt environment variables
+      env = {}
+      %w[
+        PASSBOLT_SERVER_ADDRESS
+        PASSBOLT_USER_PRIVATE_KEY_FILE
+        PASSBOLT_USER_PASSWORD
+        PASSBOLT_GPG_HOME
+        PASSBOLT_CONFIG
+      ].each do |var|
+        env[var] = ENV[var] if ENV[var]
+      end
+
+      stdout, stderr, status = Open3.capture3(env, *cmd)
+
+      # Log stderr if command failed
+      error_msg = nil
+      if !status.success? && !stderr.strip.empty?
+        error_msg = stderr.strip
+        @logger&.error("Passbolt CLI error: #{error_msg}")
+      end
+
+      [stdout, status.success?, error_msg]
     end
 
     def parse_password(json_output)

data/lib/ruborg/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ruborg
-  VERSION = "0.7.3"
+  VERSION = "0.7.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ruborg
 version: !ruby/object:Gem::Version
-  version: 0.7.3
+  version: 0.7.5
 platform: ruby
 authors:
 - Michail Pantelelis