rubocul 2.0.2 → 4.0.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (11) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +4 -7
  3. data/rubocul.gemspec +8 -3
  4. data/rubocul_default.yml +47 -21
  5. data/rubocul_rules_bundler.yml +9 -0
  6. data/rubocul_rules_graphql.yml +2 -0
  7. data/rubocul_rules_performance.yml +2 -0
  8. data/rubocul_rules_rails.yml +8 -0
  9. data/rubocul_rules_rspec.yml +2 -0
  10. data/rubocul_rules_security.yml +3 -0
  11. metadata +85 -9
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: d5272e1b0c785ffbd90df920558e8437537698494f99a653148d164cca52a7b7
4
- data.tar.gz: a0ed2e74521e3fd37bb4d52d9616498d6f04f83d8f5d9a69cdb597bb2d8d7d1a
3
+ metadata.gz: dfcb4ecf818230dcb0b7de26e4b00d5942e2dcd4c9742ed53aeb0e975ad4f6ff
4
+ data.tar.gz: a28403e34f0a0b8ad46a8fb729e06d7d1b6baca97327d735b8497da496c4d8e0
5
5
  SHA512:
6
- metadata.gz: '08694ca5aee43a0db0343cfce44f08da39562a51c8b60323d60d5bdd11e0e1426c96ce9d484e39503c09ac3440ead6c4e01c2f945c88ec0eb578362f8a0a2816'
7
- data.tar.gz: 2d341f83feb549e1a3dedb21c37701eb4919ecc0745714c06821e91a29ffc023b40dfa0b6ae164223688d5af349be82a2e37819273b58ace5fa22f1e9a8536c7
6
+ metadata.gz: 61864f0db2a5cc93c493ca06a7844cac00ccb0e181cf59f361ef82c6c3c9168b75379d15e2d4f4ead95b376a5ed0b2a7409544cb1e41b64c0685865591941b60
7
+ data.tar.gz: c775e23f323418020f88230f96258419b2c0a861f92e14dc1beac9685d39ec6acc7cdac02cc1de99563702669443a7d862e5ddbbf4b77f7a36d712a03b05a9de
data/README.md CHANGED
@@ -7,7 +7,7 @@ RuboCop defaults for Columbia University Libraries projects.
7
7
  Add this line to your Gemfile:
8
8
 
9
9
  ```ruby
10
- gem 'rubocul', '~> 2.0'
10
+ gem 'rubocul', '~> 4.0'
11
11
  ```
12
12
 
13
13
  And then execute:
@@ -21,8 +21,8 @@ inherit_gem:
21
21
  rubocul: rubocul_default.yml
22
22
 
23
23
  AllCops:
24
- TargetRubyVersion: 2.5.3 # Update to your version of ruby
25
- TargetRailsVersion: 5.2.3 # Update to your version of rails
24
+ TargetRubyVersion: 3.1.0 # Update to your version of ruby
25
+ TargetRailsVersion: 7.0.1 # Update to your version of rails
26
26
  ```
27
27
 
28
28
  ## .rubocop_todo.yml
@@ -31,13 +31,10 @@ Understandably, it can be difficult to address all rubocop issues when adding ru
31
31
  ```
32
32
  rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 10000
33
33
  ```
34
- ## Versioning & Dependencies
35
-
36
- This project depends on `bixby`, which depends on `rubocop` and `rubocop-rspec`. `bixby` supports versions its dependent gems pessimistically. Therefore we also support version of `bixby` pessimistically. Once we get a release candidate we will match major version numbers with `bixby` major version numbers.
37
34
 
38
35
  ## Configuration Suggestion
39
36
 
40
- If a member of our team would like to suggest a change to our configuration, please open a github pull request with your change and an explanation of why you think it's necessary/valuable. Please add your new configuration to the `rubocop_default.yml` file.
37
+ If you'd like to propose a change to our configuration, please open a github pull request with the change (in rubocop_default, or the appropriate rubocup_rules_* file) with an explanation of why it would be useful.
41
38
 
42
39
  ## Testing
43
40
 
data/rubocul.gemspec CHANGED
@@ -1,7 +1,7 @@
1
1
  Gem::Specification.new do |spec|
2
2
  spec.name = 'rubocul'
3
- spec.version = '2.0.2'
4
- spec.authors = ["Carla Galarza", "Eric O'Hanlon", "Ben Armintor"]
3
+ spec.version = '4.0.1'
4
+ spec.authors = ["Eric O'Hanlon", "Ben Armintor", "Carla Galarza"]
5
5
 
6
6
  spec.summary = 'A style configuration for Rubocop'
7
7
  spec.description = 'Recommended Rubocop configuration for Ruby projects created by the Columbia University Libraries'
@@ -12,5 +12,10 @@ Gem::Specification.new do |spec|
12
12
 
13
13
  spec.add_development_dependency 'bundler', '~> 2.0'
14
14
 
15
- spec.add_dependency 'bixby', '2.0.0'
15
+ spec.add_dependency 'rubocop', '~> 1.25.1'
16
+ spec.add_dependency 'rubocop-ast'
17
+ spec.add_dependency 'rubocop-performance'
18
+ spec.add_dependency 'rubocop-rails'
19
+ spec.add_dependency 'rubocop-rspec'
20
+ spec.add_dependency 'rubocop-graphql'
16
21
  end
data/rubocul_default.yml CHANGED
@@ -1,38 +1,64 @@
1
- inherit_gem:
2
- bixby: bixby_default.yml
3
-
4
- inherit_mode:
5
- merge:
6
- - Exclude
7
-
8
1
  require:
9
- - ./lib/rubocop/cul.rb
2
+ - ./lib/rubocop/cul.rb
3
+
4
+ inherit_from:
5
+ - rubocul_rules_bundler.yml
6
+ - rubocul_rules_performance.yml
7
+ - rubocul_rules_rails.yml
8
+ - rubocul_rules_rspec.yml
9
+ - rubocul_rules_security.yml
10
10
 
11
11
  AllCops:
12
+ TargetRubyVersion: 2.7
13
+ # Disable any new "pending" cops that are introduced in a minor version update of rubocop.
14
+ # We only want to opt into these explicitly, or accept them when we update to a new MAJOR
15
+ # version of rubocop. See: https://docs.rubocop.org/rubocop/versioning.html#pending-cops
16
+ NewCops: disable
17
+ # DisabledByDefault: true
18
+ DisplayCopNames: true
12
19
  Exclude:
13
- - 'app/javascript/**/*'
20
+ - 'db/**/*'
21
+ - 'script/**/*'
22
+ - 'bin/**/*'
23
+ - 'tmp/**/*'
24
+ - 'vendor/**/*'
14
25
  - 'node_modules/**/*'
26
+ - 'app/javascript/**/*'
15
27
 
16
- # Turning off until we can support multiple enforced styles (key and table). This is available in newer version of rubocop.
17
- Layout/AlignHash:
28
+ Layout/HashAlignment:
29
+ SupportedHashRocketStyles:
30
+ - key
31
+ - table
32
+ SupportedColonStyles:
33
+ - key
34
+ - table
35
+
36
+ Style/RedundantSelf:
18
37
  Enabled: false
19
38
 
20
- # In Rubocop 0.68 (a newer version than we're using right now), the IndentHash rule has been renamed to IndentFirstHashElement.
21
- Layout/IndentHash:
22
- EnforcedStyle: consistent
39
+ Style/HashSyntax:
40
+ # We may change this at some point, but it'll take some getting used to. To be safe, we're
41
+ # forcing explicit hash literal values for now.
42
+ EnforcedShorthandSyntax: never
23
43
 
24
- RSpec/MessageSpies:
25
- Enabled: false
44
+ Layout/FirstHashElementIndentation:
45
+ EnforcedStyle: consistent
26
46
 
27
47
  Style/BlockDelimiters:
28
48
  EnforcedStyle: braces_for_chaining
29
49
 
30
- Style/RedundantSelf:
50
+ Style/ClassAndModuleChildren:
31
51
  Enabled: false
32
52
 
33
- Metrics/BlockLength:
34
- Exclude:
35
- - 'spec/**/*'
53
+ Style/WordArray:
54
+ Enabled: false
55
+
56
+ Style/SymbolArray:
57
+ Enabled: false
58
+
59
+ RSpec/ExpectInHook:
60
+ Enabled: false
36
61
 
37
- Rails/HasAndBelongsToMany:
62
+ # TODO: Decide how we feel about this later
63
+ Naming/VariableNumber:
38
64
  Enabled: false
data/rubocul_rules_bundler.yml ADDED
@@ -0,0 +1,9 @@
1
+ Bundler/DuplicatedGem:
2
+ Include:
3
+ - '**/Gemfile'
4
+ - '**/gems.rb'
5
+
6
+ Bundler/OrderedGems:
7
+ Include:
8
+ - '**/Gemfile'
9
+ - '**/gems.rb'
data/rubocul_rules_graphql.yml ADDED
@@ -0,0 +1,2 @@
1
+ require:
2
+ - rubocop-graphql
data/rubocul_rules_performance.yml ADDED
@@ -0,0 +1,2 @@
1
+ require:
2
+ - rubocop-performance
data/rubocul_rules_rails.yml ADDED
@@ -0,0 +1,8 @@
1
+ require:
2
+ - rubocop-rails
3
+
4
+ Rails:
5
+ Enabled: true
6
+
7
+ Rails/HasAndBelongsToMany:
8
+ Enabled: false
data/rubocul_rules_rspec.yml ADDED
@@ -0,0 +1,2 @@
1
+ require:
2
+ - rubocop-rspec
data/rubocul_rules_security.yml ADDED
@@ -0,0 +1,3 @@
1
+ Security/JSONLoad:
2
+ # See: https://github.com/samvera-labs/bixby/blob/f39116f714cf54880864960c22f2f937149f2f48/bixby_default.yml#L899-L900
3
+ AutoCorrect: false
metadata CHANGED
@@ -1,16 +1,16 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocul
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.0.2
4
+ version: 4.0.1
5
5
  platform: ruby
6
6
  authors:
7
- - Carla Galarza
8
7
  - Eric O'Hanlon
9
8
  - Ben Armintor
9
+ - Carla Galarza
10
10
  autorequire:
11
11
  bindir: bin
12
12
  cert_chain: []
13
- date: 2021-09-15 00:00:00.000000000 Z
13
+ date: 2022-03-09 00:00:00.000000000 Z
14
14
  dependencies:
15
15
  - !ruby/object:Gem::Dependency
16
16
  name: bundler
@@ -27,19 +27,89 @@ dependencies:
27
27
  - !ruby/object:Gem::Version
28
28
  version: '2.0'
29
29
  - !ruby/object:Gem::Dependency
30
- name: bixby
30
+ name: rubocop
31
+ requirement: !ruby/object:Gem::Requirement
32
+ requirements:
33
+ - - "~>"
34
+ - !ruby/object:Gem::Version
35
+ version: 1.25.1
36
+ type: :runtime
37
+ prerelease: false
38
+ version_requirements: !ruby/object:Gem::Requirement
39
+ requirements:
40
+ - - "~>"
41
+ - !ruby/object:Gem::Version
42
+ version: 1.25.1
43
+ - !ruby/object:Gem::Dependency
44
+ name: rubocop-ast
45
+ requirement: !ruby/object:Gem::Requirement
46
+ requirements:
47
+ - - ">="
48
+ - !ruby/object:Gem::Version
49
+ version: '0'
50
+ type: :runtime
51
+ prerelease: false
52
+ version_requirements: !ruby/object:Gem::Requirement
53
+ requirements:
54
+ - - ">="
55
+ - !ruby/object:Gem::Version
56
+ version: '0'
57
+ - !ruby/object:Gem::Dependency
58
+ name: rubocop-performance
59
+ requirement: !ruby/object:Gem::Requirement
60
+ requirements:
61
+ - - ">="
62
+ - !ruby/object:Gem::Version
63
+ version: '0'
64
+ type: :runtime
65
+ prerelease: false
66
+ version_requirements: !ruby/object:Gem::Requirement
67
+ requirements:
68
+ - - ">="
69
+ - !ruby/object:Gem::Version
70
+ version: '0'
71
+ - !ruby/object:Gem::Dependency
72
+ name: rubocop-rails
73
+ requirement: !ruby/object:Gem::Requirement
74
+ requirements:
75
+ - - ">="
76
+ - !ruby/object:Gem::Version
77
+ version: '0'
78
+ type: :runtime
79
+ prerelease: false
80
+ version_requirements: !ruby/object:Gem::Requirement
81
+ requirements:
82
+ - - ">="
83
+ - !ruby/object:Gem::Version
84
+ version: '0'
85
+ - !ruby/object:Gem::Dependency
86
+ name: rubocop-rspec
87
+ requirement: !ruby/object:Gem::Requirement
88
+ requirements:
89
+ - - ">="
90
+ - !ruby/object:Gem::Version
91
+ version: '0'
92
+ type: :runtime
93
+ prerelease: false
94
+ version_requirements: !ruby/object:Gem::Requirement
95
+ requirements:
96
+ - - ">="
97
+ - !ruby/object:Gem::Version
98
+ version: '0'
99
+ - !ruby/object:Gem::Dependency
100
+ name: rubocop-graphql
31
101
  requirement: !ruby/object:Gem::Requirement
32
102
  requirements:
33
- - - '='
103
+ - - ">="
34
104
  - !ruby/object:Gem::Version
35
- version: 2.0.0
105
+ version: '0'
36
106
  type: :runtime
37
107
  prerelease: false
38
108
  version_requirements: !ruby/object:Gem::Requirement
39
109
  requirements:
40
- - - '='
110
+ - - ">="
41
111
  - !ruby/object:Gem::Version
42
- version: 2.0.0
112
+ version: '0'
43
113
  description: Recommended Rubocop configuration for Ruby projects created by the Columbia
44
114
  University Libraries
45
115
  email:
@@ -57,6 +127,12 @@ files:
57
127
  - lib/rubocop/cul.rb
58
128
  - rubocul.gemspec
59
129
  - rubocul_default.yml
130
+ - rubocul_rules_bundler.yml
131
+ - rubocul_rules_graphql.yml
132
+ - rubocul_rules_performance.yml
133
+ - rubocul_rules_rails.yml
134
+ - rubocul_rules_rspec.yml
135
+ - rubocul_rules_security.yml
60
136
  - spec/rubocop/cop/cul/capybara_screenshots_spec.rb
61
137
  homepage: http://github.com/cul/rubocul
62
138
  licenses: []
@@ -76,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
76
152
  - !ruby/object:Gem::Version
77
153
  version: '0'
78
154
  requirements: []
79
- rubygems_version: 3.0.8
155
+ rubygems_version: 3.3.5
80
156
  signing_key:
81
157
  specification_version: 4
82
158
  summary: A style configuration for Rubocop