rubocopital 0.6.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f4b9b93e191e11f11d8f3874a361d37593c1cc8b7a19b6fcce3c71274ec2bbed
-  data.tar.gz: 1ab3f6fbb9d458fc666c226bb502f1697ebd06e11b2d9d0727bdaa90764908fa
+  metadata.gz: 63e97c9f503597572f1e1e8240e7ff2cbcca867a87f55173f5ae664702e00d48
+  data.tar.gz: 7521bdaf213c9637d21985fc1277bd092cab25d5d67c57d38ff285c3eee142e9
 SHA512:
-  metadata.gz: 69c149158bd67d8f1dd693c1c34ee126fcc7eb2a1d009c0fd90edda18308acaba079771aabf48382ed0e6568de4e9d4d419ed284999255d362e9955df50d91b2
-  data.tar.gz: dc529b9341797105580a1a55dfedabe82457ad0fb4ea21b32a5dde8f03afeec16a2759946ad2607b17e7f4cbac111f4d4229607c8880438c7ccf839d80cec5a9
+  metadata.gz: 7974b4cdc043aeb3e0adea9f343d0153c06126775da904cf9a4c0a4dba1a181f238f70a81143154f93d7e70e01fcbaa5dc4b89866d0341e89c60b85919fe9009
+  data.tar.gz: 61826ba3c21774a0419230b30ab85f1e7e4c2555d4d5f3d119b42a6f0d1754274559da0b7e12e1a7b6258532a68a6d4469396e282c0546dde3a5ed1197be1ce0

data/.github/workflows/ruby.yml

@@ -3,6 +3,22 @@ name: Ruby
 on: [push, pull_request]
 
 jobs:
+  build-ruby-30:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Ruby 3.0
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 3.0.x
+    - name: Build and test with Rake
+      run: |
+        gem install bundler
+        bundle install --jobs 4 --retry 3
+        bundle exec rake
+
   build-ruby-26:
 
     runs-on: ubuntu-latest

data/.rubocop-performance.yml

@@ -1,7 +1,55 @@
 require: rubocop-performance
 
+Performance/AncestorsInclude:
+  Enabled: true
+
+Performance/StringInclude:
+  Enabled: true
+
 Performance/ChainArrayAllocation:
   Enabled: true
 
 Performance/OpenStruct:
   Enabled: true
+
+Performance/Squeeze:
+  Enabled: true
+
+Performance/SortReverse:
+  Enabled: true
+
+Performance/ReverseFirst:
+  Enabled: true
+
+Performance/RedundantStringChars:
+  Enabled: true
+
+Performance/RedundantSortBlock:
+  Enabled: true
+
+Performance/IoReadlines:
+  Enabled: true
+
+Performance/DeleteSuffix:
+  Enabled: true
+
+Performance/BindCall:
+  Enabled: true
+
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: true
+
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+
+Performance/ConstantRegexp:
+  Enabled: true
+
+Performance/MethodObjectAsBlock:
+  Enabled: true
+
+Performance/Sum:
+  Enabled: true

data/.rubocop-rails.yml

@@ -51,6 +51,57 @@ Rails/SafeNavigationWithBlank:
 Rails/SkipsModelValidations:
   Enabled: false
 
+Rails/UniqueValidationWithoutIndex:
+  Enabled: true
+
+Rails/RenderPlainText:
+  Enabled: true
+
+Rails/RenderInline:
+  Enabled: true
+
+Rails/RedundantForeignKey:
+  Enabled: true
+
+Rails/PluckInWhere:
+  Enabled: true
+
+Rails/Pluck:
+  Enabled: true
+
+Rails/Pick:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: true
+
+Rails/MailerName:
+  Enabled: true
+
+Rails/FindById:
+  Enabled: true
+
+Rails/ContentTag:
+  Enabled: true
+
+Rails/MatchRoute:
+  Enabled: true
+
+Rails/ShortI18n:
+  Enabled: true
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+
+Rails/Inquiry:
+  Enabled: true
+
+Rails/WhereExists:
+  Enabled: true
+
 Rails/UnknownEnv:
   Environments:
     - development

data/.rubocop-rspec.yml

@@ -249,3 +249,30 @@ RSpec/VoidExpect:
 
 RSpec/Yield:
   Enabled: true
+
+RSpec/RepeatedExampleGroupDescription:
+  Enabled: true
+
+RSpec/VariableName:
+  Enabled: true
+
+RSpec/VariableDefinition:
+  Enabled: true
+
+RSpec/RepeatedExampleGroupBody:
+  Enabled: true
+
+RSpec/EmptyHook:
+  Enabled: true
+
+# TODO Cops
+Rails/AfterCommitOverride: # (new in 2.8)
+  Enabled: false
+Rails/AttributeDefaultBlockValue: # (new in 2.9)
+  Enabled: false
+Rails/SquishedSQLHeredocs: # (new in 2.8)
+  Enabled: false
+Rails/WhereEquals: # (new in 2.9)
+  Enabled: false
+Rails/WhereNot: # (new in 2.8)
+  Enabled: false

data/.rubocop.yml

@@ -3,7 +3,6 @@ require:
   - rubocop-rails
   - rubocop-rspec
 
-inherit_from: default.yml
+inherit_from:
+  - default.yml
 
-Style/Documentation:
-  Enabled: false

data/CHANGELOG.md

@@ -6,6 +6,88 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [1.0.1] - 05 February 2021
+
+### Fixed
+
+- Fixed projects without Rubocop-Rails
+
+## [1.0.0] - 05 February 2021
+
+### Changed
+
+- Upgrade Rubocop from 0.89.0 to 1.9.1
+- Upgrade Rubocop-Performance from 1.7.1 to 1.9.2
+- Upgrade Rubocop-Rails from 2.7.0 to 2.9.1
+
+## [0.7.1] - 05 October 2020
+
+- Upgrade rubocop to 0.89.0 to prevent bug in 0.88.0
+
+- Added Style/ExplicitBlockArgument disabled
+- Added Style/GlobalStdStream disabled
+- Added Style/OptionalBooleanParameter disabled
+- Added Style/SingleArgumentDig disabled
+- Added Style/StringConcatenation disabled
+
+- Added Lint/BinaryOperatorWithIdenticalOperands disabled
+- Added Lint/DuplicateRescueException disabled
+- Added Lint/EmptyConditionalBody disabled
+- Added Lint/FloatComparison disabled
+- Added Lint/MissingSuper disabled
+- Added Lint/OutOfRangeRegexpRef disabled
+- Added Lint/SelfAssignment disabled
+- Added Lint/TopLevelReturnWithArgument disabled
+- Added Lint/UnreachableLoop disabled
+
+## [0.7.0] - 10 August 2020
+
+- Added Rails/ActiveRecordCallbacksOrder
+- Added Rails/Inquiry
+- Added Rails/WhereExists
+
+- Added Lint/RaiseException
+- Added Lint/MixedRegexpCaptureTypes
+- Added Lint/DeprecatedOpenSSLConstant
+- Added Lint/DuplicateElsifCondition
+- Added Lint/MixedRegexpCaptureTypes
+
+- Added Performance/AncestorsInclude
+- Added Performance/StringInclude
+- Added Performance/Squeeze
+- Added Performance/SortReverse
+- Added Performance/ReverseFirst
+- Added Performance/RedundantStringChars
+- Added Performance/RedundantSortBlock
+- Added Performance/IoReadlines
+- Added Performance/ReverseFirst
+- Added Performance/DeleteSuffix
+- Added Performance/BindCall
+- Added Performance/BigDecimalWithNumericArgument
+- Added Performance/DeleteSuffix
+
+- Added RSpec/RepeatedExampleGroupDescription
+- Added RSpec/VariableName
+- Added RSpec/VariableDefinition
+- Added RSpec/RepeatedExampleGroupBody
+- Added RSpec/EmptyHook
+- Added RSpec/RepeatedExampleGroupBody
+
+- Added Style/SlicingWithRange
+- Added Style/RedundantRegexpEscape
+- Added Style/RedundantRegexpCharacterClass
+- Added Style/RedundantFetchBlock
+- Added Style/RedundantAssignment
+- Added Style/HashTransformValues
+- Added Style/HashEachMethods
+- Added Style/ExponentialNotation
+- Added Style/BisectedAttrAccessor
+- Added Style/AccessorGrouping
+
+## [0.6.1] - 11 March 2020
+
+- Bumped rake dependency to a higher version to mitigate CVE-2020-8130
+
 ## [0.6.0] - 20 January 2020
 
 - Updated rubocop gem to `0.77.0`

data/README.md

@@ -7,7 +7,7 @@ This is the common configuration for ruby-style checks by [Rubocop](https://gith
 Add this line to your application's Gemfile under the `development` and `test` groups to include a specific version of this gem:
 
 ```ruby
-gem 'rubocopital', '~> 0.5.1', require: false
+gem 'rubocopital', '~> 1.0.1', require: false
 ```
 
 And then execute:
@@ -36,7 +36,7 @@ you can just add them below.
       - default.yml
 
   AllCops:
-    TargetRubyVersion: 2.3
+    TargetRubyVersion: 3.0
     DisplayCopNames: false
     DisplayStyleGuide: true
 ```

data/default.yml

@@ -1,7 +1,9 @@
-inherit_from: .rubocop-performance.yml
+inherit_from:
+  - .rubocop-performance.yml
+  - new_cops.yml
 
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.6
   Exclude:
     - db/migrate/*
     - db/seeds/*
@@ -90,6 +92,12 @@ Style/EachWithObject:
 Style/UnpackFirst:
   Enabled: false
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/EndAlignment:
   EnforcedStyleAlignWith: variable
 
@@ -100,6 +108,9 @@ Layout/FirstParameterIndentation:
   Enabled: true
   EnforcedStyle: consistent
 
+Layout/LineLength:
+  Max: 120
+
 Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
@@ -112,9 +123,6 @@ Style/TrivialAccessors:
 Metrics/AbcSize:
   Enabled: false
 
-Metrics/LineLength:
-  Max: 120
-
 Metrics/BlockLength:
   CountComments: false  # count full line comments?
   Max: 50
@@ -165,9 +173,72 @@ Style/NegatedUnless:
 Style/StringLiterals:
   Enabled: false
 
+Style/ArrayCoercion:
+  Enabled: true
+
+Style/CaseLikeIf:
+  Enabled: true
+
+Style/HashAsLastArrayItem:
+  Enabled: true
+
+Style/HashLikeCase:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+Style/AccessorGrouping:
+  Enabled: true
+
 Style/StringLiteralsInInterpolation:
   Enabled: false
 
+Style/ExplicitBlockArgument:
+  Enabled: false
+
+Style/GlobalStdStream:
+  Enabled: false
+
+Style/OptionalBooleanParameter:
+  Enabled: false
+
+Style/SingleArgumentDig:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
 Lint/DisjunctiveAssignmentInConstructor:
   Enabled: true
 
@@ -185,3 +256,51 @@ Lint/ToJSON:
 
 Gemspec/RubyVersionGlobalsUsage:
   Enabled: true
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Lint/NonDeterministicRequireOrder:
+  Enabled: false
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: false
+
+Lint/DuplicateRescueException:
+  Enabled: false
+
+Lint/EmptyConditionalBody:
+  Enabled: false
+
+Lint/FloatComparison:
+  Enabled: false
+
+Lint/MissingSuper:
+  Enabled: false
+
+Lint/OutOfRangeRegexpRef:
+  Enabled: false
+
+Lint/SelfAssignment:
+  Enabled: false
+
+Lint/TopLevelReturnWithArgument:
+  Enabled: false
+
+Lint/UnreachableLoop:
+  Enabled: false

data/lib/rubocopital/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rubocopital
-  VERSION = "0.6.0"
+  VERSION = "1.0.1"
 end

data/new_cops.yml

@@ -0,0 +1,89 @@
+Lint/DuplicateRequire: # (new in 0.90)
+  Enabled: false
+Lint/EmptyFile: # (new in 0.90)
+  Enabled: false
+Lint/TrailingCommaInAttributeDeclaration: # (new in 0.90)
+  Enabled: false
+Lint/UselessMethodDefinition: # (new in 0.90)
+  Enabled: false
+Style/CombinableLoops: # (new in 0.90)
+  Enabled: false
+Style/KeywordParametersOrder: # (new in 0.90)
+  Enabled: false
+Style/RedundantSelfAssignment: # (new in 0.90)
+  Enabled: false
+Style/SoleNestedConditional: # (new in 0.89)
+  Enabled: false
+
+Layout/BeginEndAlignment: # (new in 0.91)
+  Enabled: false
+Lint/ConstantDefinitionInBlock: # (new in 0.91)
+  Enabled: false
+Lint/IdentityComparison: # (new in 0.91)
+  Enabled: false
+Lint/UselessTimes: # (new in 0.91)
+  Enabled: false
+
+Lint/HashCompareByIdentity: # (new in 0.93)
+  Enabled: false
+Lint/RedundantSafeNavigation: # (new in 0.93)
+  Enabled: false
+Style/ClassEqualityComparison: # (new in 0.93)
+  Enabled: false
+
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: false
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: false
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: false
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: false
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: false
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: false
+Style/SwapValues: # (new in 1.1)
+  Enabled: false
+
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: false
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: false
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: false
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: false
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: false
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: false
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: false
+Lint/NumberedParameterAssignment: # (new in 1.9)
+  Enabled: false
+Lint/OrAssignmentToConstant: # (new in 1.9)
+  Enabled: false
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: false
+Lint/SymbolConversion: # (new in 1.9)
+  Enabled: false
+Lint/TripleQuotes: # (new in 1.9)
+  Enabled: false
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: false
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: false
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: false
+Style/HashExcept: # (new in 1.7)
+  Enabled: false
+Style/IfWithBooleanLiteralBranches: # (new in 1.9)
+  Enabled: false
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: false
+Style/NilLambda: # (new in 1.3)
+  Enabled: false
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: false
+

data/rubocopital.gemspec

@@ -32,12 +32,12 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "rubocop", "~> 0.77.0"
-  spec.add_runtime_dependency "rubocop-performance", "~> 1.5.1"
-  spec.add_runtime_dependency "rubocop-rails", "2.4.0"
-  spec.add_runtime_dependency "rubocop-rspec", "1.37.0"
+  spec.add_runtime_dependency "rubocop", "~> 1.9.0"
+  spec.add_runtime_dependency "rubocop-performance", "~> 1.9.2"
+  spec.add_runtime_dependency "rubocop-rails", "2.9.1"
+  spec.add_runtime_dependency "rubocop-rspec", "2.2.0"
 
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake", "~> 10.0"
+  spec.add_development_dependency "rake", ">= 12.3.3"
   spec.add_development_dependency "rspec", "~> 3.0"
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: rubocopital
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Marcel Eeken
 - Martijn Bleeker
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-01-20 00:00:00.000000000 Z
+date: 2021-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,56 +17,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.77.0
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.77.0
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.5.1
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: 2.9.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.37.0
+        version: 2.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.37.0
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -85,16 +85,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -138,6 +138,7 @@ files:
 - default.yml
 - lib/rubocopital.rb
 - lib/rubocopital/version.rb
+- new_cops.yml
 - project.yml
 - rubocopital.gemspec
 homepage: https://github.com/youngcapital/rubocopital
@@ -147,7 +148,7 @@ metadata:
   hompeage_uri: https://github.com/youngcapital/rubocopital
   source_code_uri: https://github.com/youngcapital/rubocopital
   changelog_uri: https://github.com/youngcapital/rubocopital/blob/master/CHANGELOG.md
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -162,8 +163,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: Shared rubocop configuration
 test_files: []