rubocopital 0.5.3 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7651fef82b8bde7a33fc9b00acb986a10fc26781b1fa9a7e2e7317199ed13886
-  data.tar.gz: 0026601405735f8393291eec398feb58ba33855ba0cac7461950aa7d5d7f1b1f
+  metadata.gz: f4b9b93e191e11f11d8f3874a361d37593c1cc8b7a19b6fcce3c71274ec2bbed
+  data.tar.gz: 1ab3f6fbb9d458fc666c226bb502f1697ebd06e11b2d9d0727bdaa90764908fa
 SHA512:
-  metadata.gz: b093f210b6387f332025ab9574b54074b05a86c62973186ba0b8d37389ac20647cc732a066348633bce56914f345eaf2972c814f7045bfa1ef916aedabb7ae76
-  data.tar.gz: 5dcc0a424e884ea10186394657a03f3ac8ec2ade616d7fb076ed9ac0a3d53cffac111fcd576c94e97c2e66459ca027ae5b4cfe7f7b58bad360fcd926c624dc79
+  metadata.gz: 69c149158bd67d8f1dd693c1c34ee126fcc7eb2a1d009c0fd90edda18308acaba079771aabf48382ed0e6568de4e9d4d419ed284999255d362e9955df50d91b2
+  data.tar.gz: dc529b9341797105580a1a55dfedabe82457ad0fb4ea21b32a5dde8f03afeec16a2759946ad2607b17e7f4cbac111f4d4229607c8880438c7ccf839d80cec5a9

data/.rubocop-rails.yml

@@ -0,0 +1,62 @@
+require: rubocop-rails
+
+Rails:
+  Enabled: true
+
+Rails/ApplicationController:
+  Enabled: true
+
+Rails/ApplicationJob:
+  Enabled: false
+
+Rails/ApplicationMailer:
+  Enabled: true
+
+Rails/ApplicationRecord:
+  Enabled: false
+
+Rails/BelongsTo:
+  Enabled: true
+
+Rails/Date:
+  EnforcedStyle: flexible
+
+Rails/EnumHash:
+  Enabled: true
+
+Rails/HasAndBelongsToMany:
+  Enabled: false
+
+Rails/HttpPositionalArguments:
+  Enabled: false
+
+Rails/IgnoredSkipActionFilterOption:
+  Enabled: true
+
+Rails/LexicallyScopedActionFilter:
+  Enabled: false
+
+Rails/LinkToBlank:
+  Enabled: true
+
+Rails/OutputSafety:
+  Enabled: false
+
+Rails/RakeEnvironment:
+  Enabled: false
+
+Rails/SafeNavigationWithBlank:
+  Enabled: true
+
+Rails/SkipsModelValidations:
+  Enabled: false
+
+Rails/UnknownEnv:
+  Environments:
+    - development
+    - test
+    - review
+    - staging
+    - acceptance
+    - training
+    - production

data/.rubocop-rspec.yml

@@ -13,6 +13,9 @@ FactoryBot/CreateList:
   Enabled: true
   EnforcedStyle: create_list
 
+FactoryBot/FactoryClassName:
+  Enabled: true
+
 Rails/HttpStatus:
   Enabled: true
   EnforcedStyle: symbolic
@@ -38,6 +41,9 @@ RSpec/BeEql:
 RSpec/BeforeAfterAll:
   Enabled: true
 
+RSpec/ContextMethod:
+  Enabled: true
+
 RSpec/ContextWording:
   Enabled: true
 
@@ -54,6 +60,13 @@ RSpec/DescribedClass:
 RSpec/DescribeMethod:
   Enabled: true
 
+RSpec/Dialect:
+  Enabled: false
+
+RSpec/EmptyLineAfterExample:
+  Enabled: true
+  AllowConsecutiveOneLiners: true
+
 RSpec/EmptyExampleGroup:
   Enabled: true
 
@@ -107,6 +120,9 @@ RSpec/HookArgument:
 RSpec/HooksBeforeExamples:
   Enabled: true
 
+RSpec/ImplicitBlockExpectation:
+  Enabled: true
+
 RSpec/ImplicitExpect:
   Enabled: true
   EnforcedStyle: is_expected
@@ -135,6 +151,9 @@ RSpec/IteratedExpectation:
 RSpec/LeadingSubject:
   Enabled: true
 
+RSpec/LeakyConstantDeclaration:
+  Enabled: true
+
 RSpec/LetBeforeExamples:
   Enabled: true
 

data/.rubocop.yml

@@ -1,4 +1,9 @@
+require:
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rspec
+
 inherit_from: default.yml
 
-Documentation:
+Style/Documentation:
   Enabled: false

data/CHANGELOG.md

@@ -6,6 +6,35 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [0.6.0] - 20 January 2020
+
+- Updated rubocop gem to `0.77.0`
+- Updated rubocop-performance gem to `1.5.1`
+- Added rubocop-rails gem version `2.4.0`
+
+- Added Rails/ApplicationController
+- Added Rails/ApplicationMailer
+- Added Rails/EnumHash
+- Added Rails/SafeNavigationWithBlank
+- Added FactoryBot/FactoryClassNam
+- Added RSpec/ContextMethod
+- Added RSpec/EmptyLineAfterExample: with AllowConsecutiveOneLiners: true
+- Added RSpec/ImplicitBlockExpectation
+- Added RSpec/LeakyConstantDeclaration
+- Added Style/FloatDivision: with EnforcedStyle: single_coerce
+- Added Style/MultilineWhenThen
+- Added Lint/SendWithMixinArgument
+- Added Gemspec/RubyVersionGlobalsUsage
+
+- Disabled Rails/RakeEnvironment
+- Disabled RSpec/Dialect
+
+- Renamed Layout/AlignHash to Layout/HashAlignment
+- Renamed Layout/AlignParameters to Layout/ParameterAlignment
+- Renamed Layout/IndentFirstParameter to Layout/FirstParameterIndentation
+
+---
+
 ## [0.5.1] - 30 July 2019
 
 ### Disabled

data/README.md

@@ -25,6 +25,8 @@ inherit_gem:
     - default.yml
 ```
 
+`default.yml` does also require the `rubocop-performance` configuration.
+
 If you have specific configurations that differ from the agreed upon defaults,
 you can just add them below.
 
@@ -48,6 +50,16 @@ inherit_gem:
     - .rubocop-rspec.yml
 ```
 
+The same applies to Rails.
+
+```
+inherit_gem:
+  rubocopital:
+    - default.yml
+    - .rubocop-rails.yml
+    - .rubocop-rspec.yml
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run

data/default.yml

@@ -22,7 +22,7 @@ AllCops:
   DisplayCopNames: true
   DisplayStyleGuide: true
 
-Layout/AlignHash:
+Layout/HashAlignment:
   EnforcedHashRocketStyle: key
   # key - left alignment of keys
   #   'a' => 2
@@ -31,7 +31,6 @@ Layout/AlignHash:
   # key - left alignment of keys
   #   a: 0
   #   bb: 1
-  # YC Compliant
   EnforcedLastArgumentHashStyle: ignore_implicit
   # ignore_implicit - Ignore only implicit hashes.
   #   Accepts:
@@ -41,8 +40,7 @@ Layout/AlignHash:
   #     function({a: 1,
   #       b: 2})
 
-Layout/AlignParameters:
-  # YC Compliant
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
   # The `with_fixed_indentation` style aligns the following lines with one
   # level of indentation relative to the start of the line with the method call.
@@ -51,12 +49,10 @@ Layout/AlignParameters:
   #       b)
 
 Style/AndOr:
-  # YC Compliant
   EnforcedStyle: conditionals
   # `and` and `or` are banned only in conditionals (conditionals)
 
 Style/BlockDelimiters:
-  # YC Compliant
   EnforcedStyle: line_count_based
   # The `line_count_based` style enforces braces around single line blocks and
   # do..end around multi-line blocks.
@@ -64,11 +60,9 @@ Style/BlockDelimiters:
   - spec/**/*
 
 Style/ClassAndModuleChildren:
-  # YC Compliant
   EnforcedStyle: compact
 
 Style/IdenticalConditionalBranches:
-  # YC Compliant
   Enabled: false
   # Redirect_to usage in conditionals
 
@@ -80,40 +74,29 @@ Style/ExpandPathArguments:
   Enabled: false
 
 Style/NumericPredicate:
-  # YC Compliant
   Enabled: false
   # Use .positive? instead of > 0
   # Use .zero? instead of == 0
   # Use .nonzero? instead of != 0.
 
 Style/GlobalVars:
-  # YC Compliant
   Enabled: true
   AllowedVariables: [$ASSET_MODE]
   # Do not introduce global variables. (used for cucumber custom_env)
 
 Style/EachWithObject:
-  # YC Compliant
   Enabled: false
 
 Style/UnpackFirst:
   Enabled: false
 
-Rails/Date:
-  # YC Compliant
-  EnforcedStyle: flexible
-  # The value `flexible` allows usage of `Date.current`, `Date.yesterday`, etc
-  # (but not `Date.today`) which are overridden by ActiveSupport to handle current
-  # time zone.
-
 Layout/EndAlignment:
-  # YC Compliant
   EnforcedStyleAlignWith: variable
 
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: true
 
-Layout/IndentFirstParameter:
+Layout/FirstParameterIndentation:
   Enabled: true
   EnforcedStyle: consistent
 
@@ -121,22 +104,18 @@ Layout/MultilineMethodCallIndentation:
   EnforcedStyle: indented
 
 Layout/MultilineOperationIndentation:
-  # YC Compliant
   EnforcedStyle: indented
 
 Style/TrivialAccessors:
   Enabled: true
 
 Metrics/AbcSize:
-  # YC Compliant
   Enabled: false
 
 Metrics/LineLength:
-  # YC Compliant
   Max: 120
 
 Metrics/BlockLength:
-  # YC Compliant
   CountComments: false  # count full line comments?
   Max: 50
   Exclude:
@@ -144,89 +123,49 @@ Metrics/BlockLength:
     - config/routes.rb
 
 Metrics/ClassLength:
-  # YC Compliant
   Enabled: false
 
 Metrics/MethodLength:
-  # YC Compliant
   Max: 30
   Severity: warning
 
 Metrics/ModuleLength:
-  # YC Compliant
   Enabled: false
 
-Documentation:
-  # YC Compliant
+Style/Documentation:
   Enabled: false
 
-Rails:
-  # YC Compliant
-  Enabled: true
 
 Bundler/OrderedGems:
-  # YC Compliant
   TreatCommentsAsGroupSeparators: true
 
-Rails/OutputSafety:
-  # YC Compliant
-  Enabled: false
-  # Prefer safe_join instead of html_save
-
-Rails/HttpPositionalArguments:
-  # YC Compliant
-  Enabled: false
-  # prefer get(:new, params: {}) instead of get(:new, {})
-
-Rails/SkipsModelValidations:
-  # YC Compliant
-  Enabled: false
-
-Rails/HasAndBelongsToMany:
-  # YC Compliant
-  Enabled: false
-
-# This cop checks that models subclass ApplicationRecord with Rails 5.0.
-Rails/ApplicationRecord:
-  Enabled: false
-
-# This cop checks that models subclass ApplicationJob with Rails 5.0.
-Rails/ApplicationJob:
+Style/EmptyMethod:
   Enabled: false
 
-Rails/BelongsTo:
+Style/FloatDivision:
   Enabled: true
-
-Rails/IgnoredSkipActionFilterOption:
-  Enabled: true
-
-Rails/LinkToBlank:
-  Enabled: true
-
-Style/EmptyMethod:
-  # YC Compliant
-  Enabled: false
+  EnforcedStyle: single_coerce
 
 Style/IpAddresses:
   Enabled: true
 
 Style/ModuleFunction:
-  # YC Compliant
   Enabled: false
 
 Style/MultilineMethodSignature:
   Enabled: true
 
+Style/MultilineWhenThen:
+  Enabled: true
+
 Style/NegatedUnless:
   Enabled: true
   EnforcedStyle: both
 
 Style/StringLiterals:
-  # YC Compliant
   Enabled: false
 
 Style/StringLiteralsInInterpolation:
-  # YC Compliant
   Enabled: false
 
 Lint/DisjunctiveAssignmentInConstructor:
@@ -238,18 +177,11 @@ Lint/HeredocMethodCallPosition:
 Lint/SafeNavigationWithEmpty:
   Enabled: true
 
-Lint/ToJSON:
+Lint/SendWithMixinArgument:
   Enabled: true
 
-Rails/UnknownEnv:
-  Environments:
-    - development
-    - test
-    - review
-    - staging
-    - acceptance
-    - training
-    - production
+Lint/ToJSON:
+  Enabled: true
 
-Rails/LexicallyScopedActionFilter:
-  Enabled: false
+Gemspec/RubyVersionGlobalsUsage:
+  Enabled: true

data/lib/rubocopital/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Rubocopital
-  VERSION = "0.5.3"
+  VERSION = "0.6.0"
 end

data/rubocopital.gemspec

@@ -32,9 +32,10 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "rubocop", "~> 0.70.0"
-  spec.add_runtime_dependency "rubocop-performance", "1.0.0"
-  spec.add_runtime_dependency "rubocop-rspec", "1.32.0"
+  spec.add_runtime_dependency "rubocop", "~> 0.77.0"
+  spec.add_runtime_dependency "rubocop-performance", "~> 1.5.1"
+  spec.add_runtime_dependency "rubocop-rails", "2.4.0"
+  spec.add_runtime_dependency "rubocop-rspec", "1.37.0"
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake", "~> 10.0"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocopital
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.6.0
 platform: ruby
 authors:
 - Marcel Eeken
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-06 00:00:00.000000000 Z
+date: 2020-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,42 +17,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.70.0
+        version: 0.77.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.70.0
+        version: 0.77.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.5.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.32.0
+        version: 1.37.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.32.0
+        version: 1.37.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -110,6 +124,7 @@ files:
 - ".gitlab-ci.yml"
 - ".rspec"
 - ".rubocop-performance.yml"
+- ".rubocop-rails.yml"
 - ".rubocop-rspec.yml"
 - ".rubocop.yml"
 - ".travis.yml"
@@ -147,7 +162,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Shared rubocop configuration