rubocopital 0.5.1 → 0.7.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (13) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/ruby.yml +52 -0
  3. data/.gitlab-ci.yml +3 -17
  4. data/.rubocop-performance.yml +40 -0
  5. data/.rubocop-rails.yml +113 -0
  6. data/.rubocop-rspec.yml +34 -0
  7. data/.rubocop.yml +5 -3
  8. data/CHANGELOG.md +77 -0
  9. data/README.md +13 -1
  10. data/default.yml +102 -82
  11. data/lib/rubocopital/version.rb +1 -1
  12. data/rubocopital.gemspec +24 -24
  13. metadata +48 -16
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: f6f8da48a68128c440f206fab4fc9300aa2882a44c0399e98f0d93aa4daf7c98
4
- data.tar.gz: 37f431b740f81ff4446fa844dd38d2caac24191f27dea0175afae89e236c9670
3
+ metadata.gz: 8be767acbb954ab989a1dac67cfd61535fb49ad0d6aa29137a686938c68082c9
4
+ data.tar.gz: 64c899d86752ccad71e7ca8231edf2dd716588ad5d2fa74f31f67142169cb05c
5
5
  SHA512:
6
- metadata.gz: 7de2e6d1a9d8b9075e35544ab838e3342742db34c72f31bbbf01732803d7d4b41b1a375b4a2db38e5cf68e860bcb09e11c84bd6c065034c355dd3ce77958ac81
7
- data.tar.gz: ad32859b681c2db76fce59c84509510528c2e0b598cd21c047f0f7aa396a32e042ef8b5fd15b2abbeaefa83fe39b04c9072a248ad0c4945edcfc9fc6864fcb55
6
+ metadata.gz: 1d021a1ac67651e563860021f75922fb5c898af902b85c51ae33d37c15f5bf222bd2b7a7b2a5ada4ba51a0e996667041821d0777d6747192ff98e03db542d46e
7
+ data.tar.gz: bcf7e8eb2688d6a888346d6acdc09dcc9fe0918f164046806a8884bf759d818eba8511a270e8c1efa70a60aca56c6dd3e58a4cfc590780d4fc9188349836a355
data/.github/workflows/ruby.yml ADDED
@@ -0,0 +1,52 @@
1
+ name: Ruby
2
+
3
+ on: [push, pull_request]
4
+
5
+ jobs:
6
+ build-ruby-26:
7
+
8
+ runs-on: ubuntu-latest
9
+
10
+ steps:
11
+ - uses: actions/checkout@v1
12
+ - name: Set up Ruby 2.6
13
+ uses: actions/setup-ruby@v1
14
+ with:
15
+ ruby-version: 2.6.x
16
+ - name: Build and test with Rake
17
+ run: |
18
+ gem install bundler
19
+ bundle install --jobs 4 --retry 3
20
+ bundle exec rake
21
+
22
+ build-ruby-25:
23
+
24
+ runs-on: ubuntu-latest
25
+
26
+ steps:
27
+ - uses: actions/checkout@v1
28
+ - name: Set up Ruby 2.5
29
+ uses: actions/setup-ruby@v1
30
+ with:
31
+ ruby-version: 2.5.x
32
+ - name: Build and test with Rake
33
+ run: |
34
+ gem install bundler
35
+ bundle install --jobs 4 --retry 3
36
+ bundle exec rake
37
+
38
+ build-ruby-24:
39
+
40
+ runs-on: ubuntu-latest
41
+
42
+ steps:
43
+ - uses: actions/checkout@v1
44
+ - name: Set up Ruby 2.5
45
+ uses: actions/setup-ruby@v1
46
+ with:
47
+ ruby-version: 2.5.x
48
+ - name: Build and test with Rake
49
+ run: |
50
+ gem install bundler
51
+ bundle install --jobs 4 --retry 3
52
+ bundle exec rake
data/.gitlab-ci.yml CHANGED
@@ -1,36 +1,22 @@
1
1
  stages:
2
2
  - test
3
3
 
4
- test_ruby_2_2:
5
- image: ruby:2.2.10
6
- stage: test
7
- script:
8
- - bundle install
9
- - bundle exec rake
10
-
11
- test_ruby_2_3:
12
- image: ruby:2.3.7
13
- stage: test
14
- script:
15
- - bundle install
16
- - bundle exec rake
17
-
18
4
  test_ruby_2_4:
19
- image: ruby:2.4.4
5
+ image: ruby:2.4.9
20
6
  stage: test
21
7
  script:
22
8
  - bundle install
23
9
  - bundle exec rake
24
10
 
25
11
  test_ruby_2_5:
26
- image: ruby:2.5.1
12
+ image: ruby:2.5.7
27
13
  stage: test
28
14
  script:
29
15
  - bundle install
30
16
  - bundle exec rake
31
17
 
32
18
  test_ruby_2_6:
33
- image: ruby:2.6-rc
19
+ image: ruby:2.6.5
34
20
  stage: test
35
21
  script:
36
22
  - bundle install
data/.rubocop-performance.yml ADDED
@@ -0,0 +1,40 @@
1
+ require: rubocop-performance
2
+
3
+ Performance/AncestorsInclude:
4
+ Enabled: true
5
+
6
+ Performance/StringInclude:
7
+ Enabled: true
8
+
9
+ Performance/ChainArrayAllocation:
10
+ Enabled: true
11
+
12
+ Performance/OpenStruct:
13
+ Enabled: true
14
+
15
+ Performance/Squeeze:
16
+ Enabled: true
17
+
18
+ Performance/SortReverse:
19
+ Enabled: true
20
+
21
+ Performance/ReverseFirst:
22
+ Enabled: true
23
+
24
+ Performance/RedundantStringChars:
25
+ Enabled: true
26
+
27
+ Performance/RedundantSortBlock:
28
+ Enabled: true
29
+
30
+ Performance/IoReadlines:
31
+ Enabled: true
32
+
33
+ Performance/DeleteSuffix:
34
+ Enabled: true
35
+
36
+ Performance/BindCall:
37
+ Enabled: true
38
+
39
+ Performance/BigDecimalWithNumericArgument:
40
+ Enabled: true
data/.rubocop-rails.yml ADDED
@@ -0,0 +1,113 @@
1
+ require: rubocop-rails
2
+
3
+ Rails:
4
+ Enabled: true
5
+
6
+ Rails/ApplicationController:
7
+ Enabled: true
8
+
9
+ Rails/ApplicationJob:
10
+ Enabled: false
11
+
12
+ Rails/ApplicationMailer:
13
+ Enabled: true
14
+
15
+ Rails/ApplicationRecord:
16
+ Enabled: false
17
+
18
+ Rails/BelongsTo:
19
+ Enabled: true
20
+
21
+ Rails/Date:
22
+ EnforcedStyle: flexible
23
+
24
+ Rails/EnumHash:
25
+ Enabled: true
26
+
27
+ Rails/HasAndBelongsToMany:
28
+ Enabled: false
29
+
30
+ Rails/HttpPositionalArguments:
31
+ Enabled: false
32
+
33
+ Rails/IgnoredSkipActionFilterOption:
34
+ Enabled: true
35
+
36
+ Rails/LexicallyScopedActionFilter:
37
+ Enabled: false
38
+
39
+ Rails/LinkToBlank:
40
+ Enabled: true
41
+
42
+ Rails/OutputSafety:
43
+ Enabled: false
44
+
45
+ Rails/RakeEnvironment:
46
+ Enabled: false
47
+
48
+ Rails/SafeNavigationWithBlank:
49
+ Enabled: true
50
+
51
+ Rails/SkipsModelValidations:
52
+ Enabled: false
53
+
54
+ Rails/UniqueValidationWithoutIndex:
55
+ Enabled: true
56
+
57
+ Rails/RenderPlainText:
58
+ Enabled: true
59
+
60
+ Rails/RenderInline:
61
+ Enabled: true
62
+
63
+ Rails/RedundantForeignKey:
64
+ Enabled: true
65
+
66
+ Rails/PluckInWhere:
67
+ Enabled: true
68
+
69
+ Rails/Pluck:
70
+ Enabled: true
71
+
72
+ Rails/Pick:
73
+ Enabled: true
74
+
75
+ Rails/NegateInclude:
76
+ Enabled: true
77
+
78
+ Rails/MailerName:
79
+ Enabled: true
80
+
81
+ Rails/FindById:
82
+ Enabled: true
83
+
84
+ Rails/ContentTag:
85
+ Enabled: true
86
+
87
+ Rails/MatchRoute:
88
+ Enabled: true
89
+
90
+ Rails/ShortI18n:
91
+ Enabled: true
92
+
93
+ Rails/PluckId:
94
+ Enabled: false
95
+
96
+ Rails/ActiveRecordCallbacksOrder:
97
+ Enabled: true
98
+
99
+ Rails/Inquiry:
100
+ Enabled: true
101
+
102
+ Rails/WhereExists:
103
+ Enabled: true
104
+
105
+ Rails/UnknownEnv:
106
+ Environments:
107
+ - development
108
+ - test
109
+ - review
110
+ - staging
111
+ - acceptance
112
+ - training
113
+ - production
data/.rubocop-rspec.yml CHANGED
@@ -13,6 +13,9 @@ FactoryBot/CreateList:
13
13
  Enabled: true
14
14
  EnforcedStyle: create_list
15
15
 
16
+ FactoryBot/FactoryClassName:
17
+ Enabled: true
18
+
16
19
  Rails/HttpStatus:
17
20
  Enabled: true
18
21
  EnforcedStyle: symbolic
@@ -38,6 +41,9 @@ RSpec/BeEql:
38
41
  RSpec/BeforeAfterAll:
39
42
  Enabled: true
40
43
 
44
+ RSpec/ContextMethod:
45
+ Enabled: true
46
+
41
47
  RSpec/ContextWording:
42
48
  Enabled: true
43
49
 
@@ -54,6 +60,13 @@ RSpec/DescribedClass:
54
60
  RSpec/DescribeMethod:
55
61
  Enabled: true
56
62
 
63
+ RSpec/Dialect:
64
+ Enabled: false
65
+
66
+ RSpec/EmptyLineAfterExample:
67
+ Enabled: true
68
+ AllowConsecutiveOneLiners: true
69
+
57
70
  RSpec/EmptyExampleGroup:
58
71
  Enabled: true
59
72
 
@@ -107,6 +120,9 @@ RSpec/HookArgument:
107
120
  RSpec/HooksBeforeExamples:
108
121
  Enabled: true
109
122
 
123
+ RSpec/ImplicitBlockExpectation:
124
+ Enabled: true
125
+
110
126
  RSpec/ImplicitExpect:
111
127
  Enabled: true
112
128
  EnforcedStyle: is_expected
@@ -135,6 +151,9 @@ RSpec/IteratedExpectation:
135
151
  RSpec/LeadingSubject:
136
152
  Enabled: true
137
153
 
154
+ RSpec/LeakyConstantDeclaration:
155
+ Enabled: true
156
+
138
157
  RSpec/LetBeforeExamples:
139
158
  Enabled: true
140
159
 
@@ -230,3 +249,18 @@ RSpec/VoidExpect:
230
249
 
231
250
  RSpec/Yield:
232
251
  Enabled: true
252
+
253
+ RSpec/RepeatedExampleGroupDescription:
254
+ Enabled: true
255
+
256
+ RSpec/VariableName:
257
+ Enabled: true
258
+
259
+ RSpec/VariableDefinition:
260
+ Enabled: true
261
+
262
+ RSpec/RepeatedExampleGroupBody:
263
+ Enabled: true
264
+
265
+ RSpec/EmptyHook:
266
+ Enabled: true
data/.rubocop.yml CHANGED
@@ -1,4 +1,6 @@
1
- inherit_from: default.yml
1
+ require:
2
+ - rubocop-performance
3
+ - rubocop-rails
4
+ - rubocop-rspec
2
5
 
3
- Documentation:
4
- Enabled: false
6
+ inherit_from: default.yml
data/CHANGELOG.md CHANGED
@@ -6,6 +6,83 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
6
6
 
7
7
  ## [Unreleased]
8
8
 
9
+ ## [0.7.0] - 10 August 2020
10
+
11
+ - Added Rails/ActiveRecordCallbacksOrder
12
+ - Added Rails/Inquiry
13
+ - Added Rails/WhereExists
14
+
15
+ - Added Lint/RaiseException
16
+ - Added Lint/MixedRegexpCaptureTypes
17
+ - Added Lint/DeprecatedOpenSSLConstant
18
+ - Added Lint/DuplicateElsifCondition
19
+ - Added Lint/MixedRegexpCaptureTypes
20
+
21
+ - Added Performance/AncestorsInclude
22
+ - Added Performance/StringInclude
23
+ - Added Performance/Squeeze
24
+ - Added Performance/SortReverse
25
+ - Added Performance/ReverseFirst
26
+ - Added Performance/RedundantStringChars
27
+ - Added Performance/RedundantSortBlock
28
+ - Added Performance/IoReadlines
29
+ - Added Performance/ReverseFirst
30
+ - Added Performance/DeleteSuffix
31
+ - Added Performance/BindCall
32
+ - Added Performance/BigDecimalWithNumericArgument
33
+ - Added Performance/DeleteSuffix
34
+
35
+ - Added RSpec/RepeatedExampleGroupDescription
36
+ - Added RSpec/VariableName
37
+ - Added RSpec/VariableDefinition
38
+ - Added RSpec/RepeatedExampleGroupBody
39
+ - Added RSpec/EmptyHook
40
+ - Added RSpec/RepeatedExampleGroupBody
41
+
42
+ - Added Style/SlicingWithRange
43
+ - Added Style/RedundantRegexpEscape
44
+ - Added Style/RedundantRegexpCharacterClass
45
+ - Added Style/RedundantFetchBlock
46
+ - Added Style/RedundantAssignment
47
+ - Added Style/HashTransformValues
48
+ - Added Style/HashEachMethods
49
+ - Added Style/ExponentialNotation
50
+ - Added Style/BisectedAttrAccessor
51
+ - Added Style/AccessorGrouping
52
+
53
+ ## [0.6.1] - 11 March 2020
54
+
55
+ - Bumped rake dependency to a higher version to mitigate CVE-2020-8130
56
+
57
+ ## [0.6.0] - 20 January 2020
58
+
59
+ - Updated rubocop gem to `0.77.0`
60
+ - Updated rubocop-performance gem to `1.5.1`
61
+ - Added rubocop-rails gem version `2.4.0`
62
+
63
+ - Added Rails/ApplicationController
64
+ - Added Rails/ApplicationMailer
65
+ - Added Rails/EnumHash
66
+ - Added Rails/SafeNavigationWithBlank
67
+ - Added FactoryBot/FactoryClassNam
68
+ - Added RSpec/ContextMethod
69
+ - Added RSpec/EmptyLineAfterExample: with AllowConsecutiveOneLiners: true
70
+ - Added RSpec/ImplicitBlockExpectation
71
+ - Added RSpec/LeakyConstantDeclaration
72
+ - Added Style/FloatDivision: with EnforcedStyle: single_coerce
73
+ - Added Style/MultilineWhenThen
74
+ - Added Lint/SendWithMixinArgument
75
+ - Added Gemspec/RubyVersionGlobalsUsage
76
+
77
+ - Disabled Rails/RakeEnvironment
78
+ - Disabled RSpec/Dialect
79
+
80
+ - Renamed Layout/AlignHash to Layout/HashAlignment
81
+ - Renamed Layout/AlignParameters to Layout/ParameterAlignment
82
+ - Renamed Layout/IndentFirstParameter to Layout/FirstParameterIndentation
83
+
84
+ ---
85
+
9
86
  ## [0.5.1] - 30 July 2019
10
87
 
11
88
  ### Disabled
data/README.md CHANGED
@@ -7,7 +7,7 @@ This is the common configuration for ruby-style checks by [Rubocop](https://gith
7
7
  Add this line to your application's Gemfile under the `development` and `test` groups to include a specific version of this gem:
8
8
 
9
9
  ```ruby
10
- gem 'rubocopital', git: 'git@gitlab.ycdev.nl:youngcapital/rubocopital.git', tag: '0.5.1', require: false
10
+ gem 'rubocopital', '~> 0.6.1', require: false
11
11
  ```
12
12
 
13
13
  And then execute:
@@ -25,6 +25,8 @@ inherit_gem:
25
25
  - default.yml
26
26
  ```
27
27
 
28
+ `default.yml` does also require the `rubocop-performance` configuration.
29
+
28
30
  If you have specific configurations that differ from the agreed upon defaults,
29
31
  you can just add them below.
30
32
 
@@ -48,6 +50,16 @@ inherit_gem:
48
50
  - .rubocop-rspec.yml
49
51
  ```
50
52
 
53
+ The same applies to Rails.
54
+
55
+ ```
56
+ inherit_gem:
57
+ rubocopital:
58
+ - default.yml
59
+ - .rubocop-rails.yml
60
+ - .rubocop-rspec.yml
61
+ ```
62
+
51
63
  ## Development
52
64
 
53
65
  After checking out the repo, run `bin/setup` to install dependencies. Then, run
data/default.yml CHANGED
@@ -1,5 +1,7 @@
1
+ inherit_from: .rubocop-performance.yml
2
+
1
3
  AllCops:
2
- TargetRubyVersion: 2.3
4
+ TargetRubyVersion: 2.6
3
5
  Exclude:
4
6
  - db/migrate/*
5
7
  - db/seeds/*
@@ -20,7 +22,7 @@ AllCops:
20
22
  DisplayCopNames: true
21
23
  DisplayStyleGuide: true
22
24
 
23
- Layout/AlignHash:
25
+ Layout/HashAlignment:
24
26
  EnforcedHashRocketStyle: key
25
27
  # key - left alignment of keys
26
28
  # 'a' => 2
@@ -29,7 +31,6 @@ Layout/AlignHash:
29
31
  # key - left alignment of keys
30
32
  # a: 0
31
33
  # bb: 1
32
- # YC Compliant
33
34
  EnforcedLastArgumentHashStyle: ignore_implicit
34
35
  # ignore_implicit - Ignore only implicit hashes.
35
36
  # Accepts:
@@ -39,8 +40,7 @@ Layout/AlignHash:
39
40
  # function({a: 1,
40
41
  # b: 2})
41
42
 
42
- Layout/AlignParameters:
43
- # YC Compliant
43
+ Layout/ParameterAlignment:
44
44
  EnforcedStyle: with_fixed_indentation
45
45
  # The `with_fixed_indentation` style aligns the following lines with one
46
46
  # level of indentation relative to the start of the line with the method call.
@@ -49,12 +49,10 @@ Layout/AlignParameters:
49
49
  # b)
50
50
 
51
51
  Style/AndOr:
52
- # YC Compliant
53
52
  EnforcedStyle: conditionals
54
53
  # `and` and `or` are banned only in conditionals (conditionals)
55
54
 
56
55
  Style/BlockDelimiters:
57
- # YC Compliant
58
56
  EnforcedStyle: line_count_based
59
57
  # The `line_count_based` style enforces braces around single line blocks and
60
58
  # do..end around multi-line blocks.
@@ -62,11 +60,9 @@ Style/BlockDelimiters:
62
60
  - spec/**/*
63
61
 
64
62
  Style/ClassAndModuleChildren:
65
- # YC Compliant
66
63
  EnforcedStyle: compact
67
64
 
68
65
  Style/IdenticalConditionalBranches:
69
- # YC Compliant
70
66
  Enabled: false
71
67
  # Redirect_to usage in conditionals
72
68
 
@@ -78,56 +74,54 @@ Style/ExpandPathArguments:
78
74
  Enabled: false
79
75
 
80
76
  Style/NumericPredicate:
81
- # YC Compliant
82
77
  Enabled: false
83
78
  # Use .positive? instead of > 0
84
79
  # Use .zero? instead of == 0
85
80
  # Use .nonzero? instead of != 0.
86
81
 
87
82
  Style/GlobalVars:
88
- # YC Compliant
89
83
  Enabled: true
90
84
  AllowedVariables: [$ASSET_MODE]
91
85
  # Do not introduce global variables. (used for cucumber custom_env)
92
86
 
93
87
  Style/EachWithObject:
94
- # YC Compliant
95
88
  Enabled: false
96
89
 
97
90
  Style/UnpackFirst:
98
91
  Enabled: false
99
92
 
100
- Rails/Date:
101
- # YC Compliant
102
- EnforcedStyle: flexible
103
- # The value `flexible` allows usage of `Date.current`, `Date.yesterday`, etc
104
- # (but not `Date.today`) which are overridden by ActiveSupport to handle current
105
- # time zone.
93
+ Layout/EmptyLinesAroundAttributeAccessor:
94
+ Enabled: true
95
+
96
+ Layout/SpaceAroundMethodCallOperator:
97
+ Enabled: true
106
98
 
107
99
  Layout/EndAlignment:
108
- # YC Compliant
109
100
  EnforcedStyleAlignWith: variable
110
101
 
102
+ Layout/HeredocArgumentClosingParenthesis:
103
+ Enabled: true
104
+
105
+ Layout/FirstParameterIndentation:
106
+ Enabled: true
107
+ EnforcedStyle: consistent
108
+
109
+ Layout/LineLength:
110
+ Max: 120
111
+
111
112
  Layout/MultilineMethodCallIndentation:
112
113
  EnforcedStyle: indented
113
114
 
114
115
  Layout/MultilineOperationIndentation:
115
- # YC Compliant
116
116
  EnforcedStyle: indented
117
117
 
118
118
  Style/TrivialAccessors:
119
119
  Enabled: true
120
120
 
121
121
  Metrics/AbcSize:
122
- # YC Compliant
123
122
  Enabled: false
124
123
 
125
- Metrics/LineLength:
126
- # YC Compliant
127
- Max: 120
128
-
129
124
  Metrics/BlockLength:
130
- # YC Compliant
131
125
  CountComments: false # count full line comments?
132
126
  Max: 50
133
127
  Exclude:
@@ -135,105 +129,131 @@ Metrics/BlockLength:
135
129
  - config/routes.rb
136
130
 
137
131
  Metrics/ClassLength:
138
- # YC Compliant
139
132
  Enabled: false
140
133
 
141
134
  Metrics/MethodLength:
142
- # YC Compliant
143
135
  Max: 30
144
136
  Severity: warning
145
137
 
146
138
  Metrics/ModuleLength:
147
- # YC Compliant
148
139
  Enabled: false
149
140
 
150
- Performance/ChainArrayAllocation:
141
+ Style/Documentation:
142
+ Enabled: false
143
+
144
+
145
+ Bundler/OrderedGems:
146
+ TreatCommentsAsGroupSeparators: true
147
+
148
+ Style/EmptyMethod:
149
+ Enabled: false
150
+
151
+ Style/FloatDivision:
151
152
  Enabled: true
153
+ EnforcedStyle: single_coerce
152
154
 
153
- Performance/OpenStruct:
155
+ Style/IpAddresses:
154
156
  Enabled: true
155
157
 
156
- Documentation:
157
- # YC Compliant
158
+ Style/ModuleFunction:
158
159
  Enabled: false
159
160
 
160
- Rails:
161
- # YC Compliant
161
+ Style/MultilineMethodSignature:
162
162
  Enabled: true
163
163
 
164
- Bundler/OrderedGems:
165
- # YC Compliant
166
- TreatCommentsAsGroupSeparators: true
164
+ Style/MultilineWhenThen:
165
+ Enabled: true
167
166
 
168
- Rails/OutputSafety:
169
- # YC Compliant
170
- Enabled: false
171
- # Prefer safe_join instead of html_save
167
+ Style/NegatedUnless:
168
+ Enabled: true
169
+ EnforcedStyle: both
172
170
 
173
- Rails/HttpPositionalArguments:
174
- # YC Compliant
171
+ Style/StringLiterals:
175
172
  Enabled: false
176
- # prefer get(:new, params: {}) instead of get(:new, {})
177
173
 
178
- Rails/SkipsModelValidations:
179
- # YC Compliant
180
- Enabled: false
174
+ Style/ArrayCoercion:
175
+ Enabled: true
181
176
 
182
- Rails/HasAndBelongsToMany:
183
- # YC Compliant
184
- Enabled: false
177
+ Style/CaseLikeIf:
178
+ Enabled: true
185
179
 
186
- # This cop checks that models subclass ApplicationRecord with Rails 5.0.
187
- Rails/ApplicationRecord:
188
- Enabled: false
180
+ Style/HashAsLastArrayItem:
181
+ Enabled: true
189
182
 
190
- # This cop checks that models subclass ApplicationJob with Rails 5.0.
191
- Rails/ApplicationJob:
192
- Enabled: false
183
+ Style/HashLikeCase:
184
+ Enabled: true
193
185
 
194
- Rails/BelongsTo:
186
+ Style/HashTransformKeys:
195
187
  Enabled: true
196
188
 
197
- Rails/IgnoredSkipActionFilterOption:
189
+ Style/HashTransformValues:
198
190
  Enabled: true
199
191
 
200
- Rails/LinkToBlank:
192
+ Style/RedundantAssignment:
201
193
  Enabled: true
202
194
 
203
- Style/EmptyMethod:
204
- # YC Compliant
205
- Enabled: false
195
+ Style/RedundantFetchBlock:
196
+ Enabled: true
206
197
 
207
- Style/IpAddresses:
198
+ Style/RedundantFileExtensionInRequire:
208
199
  Enabled: true
209
200
 
210
- Style/ModuleFunction:
211
- # YC Compliant
212
- Enabled: false
201
+ Style/RedundantRegexpCharacterClass:
202
+ Enabled: true
213
203
 
214
- Style/MultilineMethodSignature:
204
+ Style/RedundantRegexpEscape:
215
205
  Enabled: true
216
206
 
217
- Style/StringLiterals:
218
- # YC Compliant
219
- Enabled: false
207
+ Style/SlicingWithRange:
208
+ Enabled: true
209
+
210
+ Style/HashEachMethods:
211
+ Enabled: true
212
+
213
+ Style/ExponentialNotation:
214
+ Enabled: true
215
+
216
+ Style/BisectedAttrAccessor:
217
+ Enabled: true
218
+
219
+ Style/AccessorGrouping:
220
+ Enabled: true
220
221
 
221
222
  Style/StringLiteralsInInterpolation:
222
- # YC Compliant
223
223
  Enabled: false
224
224
 
225
225
  Lint/DisjunctiveAssignmentInConstructor:
226
226
  Enabled: true
227
227
 
228
- Rails/UnknownEnv:
229
- Environments:
230
- - development
231
- - test
232
- - review
233
- - staging
234
- - acceptance
235
- - training
236
- - production
228
+ Lint/HeredocMethodCallPosition:
229
+ Enabled: true
230
+
231
+ Lint/SafeNavigationWithEmpty:
232
+ Enabled: true
233
+
234
+ Lint/SendWithMixinArgument:
235
+ Enabled: true
237
236
 
238
- Rails/LexicallyScopedActionFilter:
237
+ Lint/ToJSON:
238
+ Enabled: true
239
+
240
+ Gemspec/RubyVersionGlobalsUsage:
241
+ Enabled: true
242
+
243
+ Lint/NonDeterministicRequireOrder:
239
244
  Enabled: false
245
+
246
+ Lint/RaiseException:
247
+ Enabled: true
248
+
249
+ Lint/MixedRegexpCaptureTypes:
250
+ Enabled: true
251
+
252
+ Lint/DeprecatedOpenSSLConstant:
253
+ Enabled: true
254
+
255
+ Lint/StructNewOverride:
256
+ Enabled: true
257
+
258
+ Lint/DuplicateElsifCondition:
259
+ Enabled: true
data/lib/rubocopital/version.rb CHANGED
@@ -1,5 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  module Rubocopital
4
- VERSION = '0.5.1'
4
+ VERSION = "0.7.0"
5
5
  end
data/rubocopital.gemspec CHANGED
@@ -1,43 +1,43 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- lib = File.expand_path('../lib', __FILE__)
3
+ lib = File.expand_path("../lib", __FILE__)
4
4
  $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
5
- require 'rubocopital/version'
5
+ require "rubocopital/version"
6
6
 
7
7
  Gem::Specification.new do |spec|
8
- spec.name = 'rubocopital'
8
+ spec.name = "rubocopital"
9
9
  spec.version = Rubocopital::VERSION
10
- spec.authors = ['Marcel Eeken']
11
- spec.email = ['m.eeken@youngcapital.nl']
10
+ spec.authors = ["Marcel Eeken", "Martijn Bleeker"]
11
+ spec.email = ["m.eeken@youngcapital.nl", "martijn@thebleacher.com"]
12
12
 
13
- spec.summary = 'Shared rubocop configuration'
14
- spec.description = 'We need to have a common configuration of ruby style,
15
- this gem hold that.'
16
- spec.homepage = 'https://github.com/youngcapital/rubocopital'
17
- spec.license = 'MIT'
13
+ spec.summary = "Shared rubocop configuration"
14
+ spec.description = "We need to have a common configuration of ruby style,
15
+ this gem hold that."
16
+ spec.homepage = "https://github.com/youngcapital/rubocopital"
17
+ spec.license = "MIT"
18
18
 
19
19
  if spec.respond_to?(:metadata)
20
- spec.metadata['allowed_push_host'] = "https://rubygems.org"
21
-
22
- spec.metadata['hompeage_uri'] = spec.homepage
23
- spec.metadata['source_code_uri'] = spec.homepage
24
- spec.metadata['changelog_uri'] = 'https://github.com/youngcapital/rubocopital/blob/master/CHANGELOG.md'
20
+ spec.metadata["hompeage_uri"] = spec.homepage
21
+ spec.metadata["source_code_uri"] = spec.homepage
22
+ spec.metadata["changelog_uri"] = "https://github.com/youngcapital/rubocopital/blob/master/CHANGELOG.md"
25
23
  else
26
- raise 'RubyGems 2.0 or newer is required to protect against ' \
27
- 'public gem pushes.'
24
+ raise "RubyGems 2.0 or newer is required to protect against " \
25
+ "public gem pushes."
28
26
  end
29
27
 
30
28
  spec.files = `git ls-files -z`.split("\x0").reject do |f|
31
29
  f.match(%r{^(test|spec|features)/})
32
30
  end
33
- spec.bindir = 'exe'
31
+ spec.bindir = "exe"
34
32
  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
35
- spec.require_paths = ['lib']
33
+ spec.require_paths = ["lib"]
36
34
 
37
- spec.add_runtime_dependency 'rubocop', '~> 0.67.2'
38
- spec.add_runtime_dependency "rubocop-rspec", "1.32.0"
35
+ spec.add_runtime_dependency "rubocop", "~> 0.88.0"
36
+ spec.add_runtime_dependency "rubocop-performance", "~> 1.7.1"
37
+ spec.add_runtime_dependency "rubocop-rails", "2.7.0"
38
+ spec.add_runtime_dependency "rubocop-rspec", "1.42.0"
39
39
 
40
- spec.add_development_dependency 'bundler', '~> 1.15'
41
- spec.add_development_dependency 'rake', '~> 10.0'
42
- spec.add_development_dependency 'rspec', '~> 3.0'
40
+ spec.add_development_dependency "bundler"
41
+ spec.add_development_dependency "rake", ">= 12.3.3"
42
+ spec.add_development_dependency "rspec", "~> 3.0"
43
43
  end
metadata CHANGED
@@ -1,14 +1,15 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: rubocopital
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.5.1
4
+ version: 0.7.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Marcel Eeken
8
+ - Martijn Bleeker
8
9
  autorequire:
9
10
  bindir: exe
10
11
  cert_chain: []
11
- date: 2019-11-08 00:00:00.000000000 Z
12
+ date: 2020-08-18 00:00:00.000000000 Z
12
13
  dependencies:
13
14
  - !ruby/object:Gem::Dependency
14
15
  name: rubocop
@@ -16,56 +17,84 @@ dependencies:
16
17
  requirements:
17
18
  - - "~>"
18
19
  - !ruby/object:Gem::Version
19
- version: 0.67.2
20
+ version: 0.88.0
20
21
  type: :runtime
21
22
  prerelease: false
22
23
  version_requirements: !ruby/object:Gem::Requirement
23
24
  requirements:
24
25
  - - "~>"
25
26
  - !ruby/object:Gem::Version
26
- version: 0.67.2
27
+ version: 0.88.0
28
+ - !ruby/object:Gem::Dependency
29
+ name: rubocop-performance
30
+ requirement: !ruby/object:Gem::Requirement
31
+ requirements:
32
+ - - "~>"
33
+ - !ruby/object:Gem::Version
34
+ version: 1.7.1
35
+ type: :runtime
36
+ prerelease: false
37
+ version_requirements: !ruby/object:Gem::Requirement
38
+ requirements:
39
+ - - "~>"
40
+ - !ruby/object:Gem::Version
41
+ version: 1.7.1
42
+ - !ruby/object:Gem::Dependency
43
+ name: rubocop-rails
44
+ requirement: !ruby/object:Gem::Requirement
45
+ requirements:
46
+ - - '='
47
+ - !ruby/object:Gem::Version
48
+ version: 2.7.0
49
+ type: :runtime
50
+ prerelease: false
51
+ version_requirements: !ruby/object:Gem::Requirement
52
+ requirements:
53
+ - - '='
54
+ - !ruby/object:Gem::Version
55
+ version: 2.7.0
27
56
  - !ruby/object:Gem::Dependency
28
57
  name: rubocop-rspec
29
58
  requirement: !ruby/object:Gem::Requirement
30
59
  requirements:
31
60
  - - '='
32
61
  - !ruby/object:Gem::Version
33
- version: 1.32.0
62
+ version: 1.42.0
34
63
  type: :runtime
35
64
  prerelease: false
36
65
  version_requirements: !ruby/object:Gem::Requirement
37
66
  requirements:
38
67
  - - '='
39
68
  - !ruby/object:Gem::Version
40
- version: 1.32.0
69
+ version: 1.42.0
41
70
  - !ruby/object:Gem::Dependency
42
71
  name: bundler
43
72
  requirement: !ruby/object:Gem::Requirement
44
73
  requirements:
45
- - - "~>"
74
+ - - ">="
46
75
  - !ruby/object:Gem::Version
47
- version: '1.15'
76
+ version: '0'
48
77
  type: :development
49
78
  prerelease: false
50
79
  version_requirements: !ruby/object:Gem::Requirement
51
80
  requirements:
52
- - - "~>"
81
+ - - ">="
53
82
  - !ruby/object:Gem::Version
54
- version: '1.15'
83
+ version: '0'
55
84
  - !ruby/object:Gem::Dependency
56
85
  name: rake
57
86
  requirement: !ruby/object:Gem::Requirement
58
87
  requirements:
59
- - - "~>"
88
+ - - ">="
60
89
  - !ruby/object:Gem::Version
61
- version: '10.0'
90
+ version: 12.3.3
62
91
  type: :development
63
92
  prerelease: false
64
93
  version_requirements: !ruby/object:Gem::Requirement
65
94
  requirements:
66
- - - "~>"
95
+ - - ">="
67
96
  - !ruby/object:Gem::Version
68
- version: '10.0'
97
+ version: 12.3.3
69
98
  - !ruby/object:Gem::Dependency
70
99
  name: rspec
71
100
  requirement: !ruby/object:Gem::Requirement
@@ -85,13 +114,17 @@ description: |-
85
114
  this gem hold that.
86
115
  email:
87
116
  - m.eeken@youngcapital.nl
117
+ - martijn@thebleacher.com
88
118
  executables: []
89
119
  extensions: []
90
120
  extra_rdoc_files: []
91
121
  files:
122
+ - ".github/workflows/ruby.yml"
92
123
  - ".gitignore"
93
124
  - ".gitlab-ci.yml"
94
125
  - ".rspec"
126
+ - ".rubocop-performance.yml"
127
+ - ".rubocop-rails.yml"
95
128
  - ".rubocop-rspec.yml"
96
129
  - ".rubocop.yml"
97
130
  - ".travis.yml"
@@ -111,7 +144,6 @@ homepage: https://github.com/youngcapital/rubocopital
111
144
  licenses:
112
145
  - MIT
113
146
  metadata:
114
- allowed_push_host: https://rubygems.org
115
147
  hompeage_uri: https://github.com/youngcapital/rubocopital
116
148
  source_code_uri: https://github.com/youngcapital/rubocopital
117
149
  changelog_uri: https://github.com/youngcapital/rubocopital/blob/master/CHANGELOG.md
@@ -130,7 +162,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
130
162
  - !ruby/object:Gem::Version
131
163
  version: '0'
132
164
  requirements: []
133
- rubygems_version: 3.0.3
165
+ rubygems_version: 3.1.2
134
166
  signing_key:
135
167
  specification_version: 4
136
168
  summary: Shared rubocop configuration