rubocop_challenger 2.0.0.pre5 → 2.0.0.pre6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b7d1fa4268fdf70c18f0d5e2f0529e40f44932af9722c8b5d3d602711255fcb6
-  data.tar.gz: 3b1fce68b3d66ccfc0c504eccc608f5f02b41d731f027abe97fb78e07c8563ab
+  metadata.gz: 33d84d4d055937dc0fa3ee0aed23d03f38325ab53de12328fe9445240928d1ee
+  data.tar.gz: 0f59e8c4731ac330142392f6a9f6f0f4ad52bc981ca0b75cbbf6326fad5ad331
 SHA512:
-  metadata.gz: 229ca155ff15eabf0c94e00645a06ef3d443573952982e623fcb9dec475ace6353dddc0f328c2717d7f856762d942e4bb9225d4e9721647527c2c6365a68e834
-  data.tar.gz: abfb7b4136efe1f930fd3c87aaa9f08ad7f3cdeb7375def8d38e8c4571de9cf22584f486bcbe5f355a35adec37611499c3d58d28e5c04d736fa5bb7e0937a9c8
+  metadata.gz: e633830be11c008791b17b4bb77c730bc330a33d99072947a3f1a4212527fe2f9629a9a470fc53ff9acfc7b1aac7c74a52ddc3673ccc4556bde4a11e40d3b47e
+  data.tar.gz: 1a29a118c86d15f03dd181c924e6d87e08c26ca76f7e7eabe5cdaa953c3eaa47f0a9582e8972f7228f9d9b18a406463fad0a74fe112e459a2713b1d8354a0b20

data/.circleci/config.yml

@@ -145,7 +145,9 @@ jobs:
             bundle exec rubocop_challenger go \
               --email=ryz310@gmail.com \
               --name=ryz310 \
-              --template=./lib/templates/checklist.md.erb
+              --template=./lib/templates/checklist.md.erb \
+              --no-auto-gen-timestamp \
+              --exclude-limit=30
 
   release:
     docker:

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-06-13 12:10:32 +0900 using RuboCop version 0.71.0.
+# on 2019-06-22 17:06:28 +0900 using RuboCop version 0.71.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rubocop_challenger (2.0.0.pre5)
+    rubocop_challenger (2.0.0.pre6)
       pr_comet (~> 0.2.0)
       rainbow
       rubocop
@@ -21,7 +21,7 @@ GEM
     docile (1.3.2)
     faraday (0.15.4)
       multipart-post (>= 1.2, < 3)
-    jaro_winkler (1.5.2)
+    jaro_winkler (1.5.3)
     json (2.2.0)
     method_source (0.9.2)
     multipart-post (2.1.1)
@@ -46,12 +46,12 @@ GEM
       rspec-core (~> 3.8.0)
       rspec-expectations (~> 3.8.0)
       rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
+    rspec-core (3.8.1)
       rspec-support (~> 3.8.0)
     rspec-expectations (3.8.4)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
+    rspec-mocks (3.8.1)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.2)

data/README.md

@@ -7,7 +7,13 @@ On the other hand, `rubocop` has [`--auto-correct`](https://github.com/rubocop-h
 It is ideal that to remove a disabled rule from `.rubocop_todo.yml` every day, to check whether it passes test, and can be obtained consent from the team. But it requires strong persistence and time.
 I call such work *Rubocop Challenge*. And the *RubocopChallenger* is a gem to support this challenge!
 
-[![Rubocop Challenge](images/rubocop_challenge.png)](https://github.com/ryz310/rubocop_challenger/pull/97)
+## The history of RubocopChallenger with decrease of offence codes
+
+The following chart shows the history of RubocopChallenger and decrease of offence codes at a `.rubocop_todo.yml`. The project was released at 5 years ago, and then it was introduced the RuboCop gem for huge source code including a lots of offence codes. Before using the RubocopChallenger, it was not maintain to reduce offence codes. One day, I felt a crisis and started maintain with manual. I made a lots of Pull Requests to reduce them but it's a load for me and reviewers. So I created a script for automation the flow, which is the predecessor of Rubocop Challenger gem. It brought reducing the offence codes continuously. After 8 months, finally it has done. There is no auto-correctable offence codes.
+But there are many offences which is un-auto-correctable yet. I will try to reduce it with the RubocopChallenger. The RubocopChallenger will
+be continued to evolve.
+
+![Decrease of offence codes](images/decrease_of_offence_codes.png)
 
 ## Rubocop Challenge Flow
 
@@ -15,6 +21,8 @@ I call such work *Rubocop Challenge*. And the *RubocopChallenger* is a gem to su
 1. When *RubocopChallenger* starts, delete a disabled rule from `.rubocop_todo.yml` existing in your project, execute `$ rubocop --auto-correct` and create a PR which include modified results
 1. You confirm the PR passes testing and then merge it if there is no problem
 
+[![Rubocop Challenge](images/rubocop_challenge.png)](https://github.com/ryz310/rubocop_challenger/pull/97)
+
 ## Usage
 
 ### 1. Edit your Gemfile
@@ -116,8 +124,12 @@ Options:
   t, [--template=TEMPLATE]                               # A Pull Request template `erb` file path.You can use variable that `title`, `rubydoc_url`, `description` and `examples` into the erb file.
       [--mode=MODE]                                      # Mode to select deletion target. You can choice "most_occurrence", "least_occurrence", or "random"
                                                          # Default: most_occurrence
+  b, [--base-branch=BASE_BRANCH]                         # The Branch to merge into
+                                                         # Default: master
   l, [--labels=one two three]                            # Label to give to Pull Request
                                                          # Default: ["rubocop challenge"]
+      [--project-column-name=PROJECT_COLUMN_NAME]        # A project column name. You can add the created PR to the GitHub project
+      [--project-id=N]                                   # A target project ID. If does not supplied, this method will find a project which associated the repository. When the repository has multiple projects, you should supply this.
       [--no-create-pr]                                   # No create a pull request (for testing)
       [--exclude-limit=N]                                # For how many exclude properties when creating the .rubocop_todo.yml
       [--auto-gen-timestamp], [--no-auto-gen-timestamp]  # Include the date and time when creating the .rubocop_todo.yml

data/lib/rubocop_challenger/cli.rb

@@ -30,6 +30,11 @@ module RubocopChallenger
            default: 'most_occurrence',
            desc: 'Mode to select deletion target. You can choice ' \
                  '"most_occurrence", "least_occurrence", or "random"'
+    option :base_branch,
+           type: :string,
+           default: 'master',
+           aliases: :b,
+           desc: 'The Branch to merge into'
     option :labels,
            type: :array,
            default: ['rubocop challenge'],

data/lib/rubocop_challenger/go.rb

@@ -55,6 +55,7 @@ module RubocopChallenger
       {
         user_name: options[:name],
         user_email: options[:email],
+        base_branch: options[:base_branch],
         labels: options[:labels],
         dry_run: options[:'no-create-pr'],
         project_column_name: options[:project_column_name],

data/lib/rubocop_challenger/pull_request.rb

@@ -9,6 +9,8 @@ module RubocopChallenger
     #   The email address which use at the git commit
     # @param options [Hash]
     #   Optional parameters
+    # @option base_branch [String]
+    #   The Branch to merge into
     # @option labels [Array<String>]
     #   Will create a pull request with the labels
     # @option dry_run [Boolean]
@@ -21,7 +23,7 @@ module RubocopChallenger
     #   multiple projects, you should supply this.
     def initialize(user_name:, user_email:, **options)
       @pr_comet = PrComet.new(
-        base: 'master',
+        base: options[:base_branch],
         branch: "rubocop-challenge/#{timestamp}",
         user_name: user_name,
         user_email: user_email

data/lib/rubocop_challenger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RubocopChallenger
-  VERSION = '2.0.0.pre5'
+  VERSION = '2.0.0.pre6'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop_challenger
 version: !ruby/object:Gem::Version
-  version: 2.0.0.pre5
+  version: 2.0.0.pre6
 platform: ruby
 authors:
 - ryosuke_sato
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-06-13 00:00:00.000000000 Z
+date: 2019-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pr_comet
@@ -205,6 +205,7 @@ files:
 - challenger.gemspec
 - exe/rubocop_challenger
 - images/circleci_environment_variables.png
+- images/decrease_of_offence_codes.png
 - images/generate_token.png
 - images/rubocop_challenge.png
 - lib/rubocop_challenger.rb