rubocop_auto_corrector 0.1.0.beta2 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 327090c9bbd094d7a6dd418e76bf9821122dc5227919cefc4b2d891ad11e233c
-  data.tar.gz: 7fc67732f6da3c4af91ab25c493b252368ac8370c91952b09cac1d97c7066dea
+  metadata.gz: d4e67b9bf9193c7cd0bf3567b5b2a013d7b7f567c037ab5b24da012696e7386e
+  data.tar.gz: 44506fb91cfc0870753e367ed4e5cfa20ab91ca335c51e59fa6fc15cf58acc31
 SHA512:
-  metadata.gz: a6777932b5de6f3495f5dc03e7b171d0578fdbec59c8136571d0f836306ed58a471628b420dcc1ed5015ff6f6b48fab5368c8646a5be69332545009abe337b2c
-  data.tar.gz: a2201469cab50eb566860d9a4efaa41ed8bf514c15069f7a2ad8975645a656bf71a75008bf30e53ba9c8bed2eefbca94a37bbf20185cfea406938225e851ea2a
+  metadata.gz: d32a74a30272d7aef5ac683ab8c5c1fb6f4f3950a722abb89be76e2b7038350daa7181e3896f68d3b907156a77009cdaf516132501288fd9da58f1dfce1fb87c
+  data.tar.gz: 37b79cf33ae2054e3dcb738c998ce7e60a843ecfa4aa2055e4e57020c8828cba13d0ecbde337d83d509a8e982998930f786064ec1accd8d73b528cd1d892dd4b

data/.github/workflows/test.yml

@@ -0,0 +1,115 @@
+name: test
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types:
+      - opened
+      - synchronize
+      - reopened
+  schedule:
+    - cron: "0 10 * * 5" # JST 19:00 (Fri)
+
+env:
+  CI: "true"
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    container: ${{ matrix.ruby }}
+
+    strategy:
+      fail-fast: false
+
+      matrix:
+        ruby:
+          - ruby:2.4
+          - ruby:2.5
+          - ruby:2.6
+          - ruby:2.7
+          - rubylang/ruby:master-nightly-bionic
+        include:
+          - ruby: rubylang/ruby:master-nightly-bionic
+            allow_failures: "true"
+
+    steps:
+      - uses: actions/checkout@v2
+
+
+      - name: Cache vendor/bundle
+        uses: actions/cache@v1
+        id: cache_gem
+        with:
+          path: vendor/bundle
+          key: v1-gem-${{ runner.os }}-${{ matrix.ruby }}-${{ github.sha }}
+          restore-keys: |
+            v1-gem-${{ runner.os }}-${{ matrix.ruby }}-
+        continue-on-error: ${{ matrix.allow_failures == 'true' }}
+
+      - name: bundle update
+        run: |
+          set -xe
+          bundle config path vendor/bundle
+          bundle update --jobs $(nproc) --retry 3
+        continue-on-error: ${{ matrix.allow_failures == 'true' }}
+
+      - name: Setup Code Climate Test Reporter
+        uses: aktions/codeclimate-test-reporter@v1
+        with:
+          codeclimate-test-reporter-id: ${{ secrets.CC_TEST_REPORTER_ID }}
+          command: before-build
+        if: matrix.ruby >= 'ruby:2.4'
+        continue-on-error: true
+
+      - name: Set up git
+        run: |
+          set -xe
+          git config --global user.email "github-runner@example.com"
+          git config --global user.name "github runner"
+
+      - name: Run test
+        run: |
+          set -xe
+          bundle exec rspec
+          bundle exec rubocop -P
+        continue-on-error: ${{ matrix.allow_failures == 'true' }}
+
+      - name: Teardown Code Climate Test Reporter
+        uses: aktions/codeclimate-test-reporter@v1
+        with:
+          codeclimate-test-reporter-id: ${{ secrets.CC_TEST_REPORTER_ID }}
+          command: after-build
+        if: matrix.ruby >= 'ruby:2.4' && always()
+        continue-on-error: true
+
+      - name: Slack Notification (not success)
+        uses: homoluctus/slatify@master
+        if: "! success()"
+        continue-on-error: true
+        with:
+          job_name: ${{ format('*build* ({0})', matrix.ruby) }}
+          type: ${{ job.status }}
+          icon_emoji: ":octocat:"
+          url: ${{ secrets.SLACK_WEBHOOK }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+  notify:
+    needs:
+      - test
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Slack Notification (success)
+        uses: homoluctus/slatify@master
+        if: always()
+        continue-on-error: true
+        with:
+          job_name: '*build*'
+          type: ${{ job.status }}
+          icon_emoji: ":octocat:"
+          url: ${{ secrets.SLACK_WEBHOOK }}
+          token: ${{ secrets.GITHUB_TOKEN }}

data/.rubocop.yml

@@ -1,18 +1,23 @@
-require: rubocop-rspec
-
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.4
 
   Exclude:
-    - 'spec/dummy/**/*.rb'
+    - 'spec/dummy/**/*'
 
-    # via. https://github.com/rubocop-hq/rubocop/blob/v0.60.0/config/default.yml#L60
+    # c.f. https://github.com/rubocop-hq/rubocop/blob/v0.72.0/config/default.yml#L60-L63
     - 'node_modules/**/*'
     - 'vendor/**/*'
     - '.git/**/*'
 
-Layout/IndentHeredoc:
-  Enabled: false
+  NewCops: enable
+
+Metrics/BlockLength:
+  Exclude:
+    - '*.gemspec'
+    - 'spec/**/*_spec.rb'
+
+Layout/LineLength:
+  Max: 110
 
-RSpec/DescribedClass:
+Style/Documentation:
   Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,32 @@
 ## master
-[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.1.0...master)
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.4.1...master)
+
+## v0.4.1
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.4.0...v0.4.1)
+
+* Fixed. `auto_correctable?` doesn't work when cop has `.support_autocorrect?` and doesn't have `#autocorrect`
+  * https://github.com/sue445/rubocop_auto_corrector/pull/35
+
+## v0.4.0
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.3.0...v0.4.0)
+
+* Add `--all` option for `rubocop --auto-correct-all`
+  * https://github.com/sue445/rubocop_auto_corrector/pull/34
+  * When `--all` arg is passed to `rubocop_auto_corrector` (e.g. `rubocop_auto_corrector --all`), run `rubocop --auto-correct-all && git commit` with each cop.
+* Upgrade rubocop and drop support ruby 2.3
+  * https://github.com/sue445/rubocop_auto_corrector/pull/31
+
+## v0.3.0
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.2.0...v0.3.0)
+
+* Support `rubocop-rails` gem (requires rubocop 0.72.0+ and ruby 2.3.0+)
+  * https://github.com/sue445/rubocop_auto_corrector/pull/18
+
+## v0.2.0
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.1.0...v0.2.0)
+
+* Support `rubocop-performance` gem
+  * https://github.com/sue445/rubocop_auto_corrector/pull/16
 
 ## v0.1.0
 * first release

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

data/README.md

@@ -3,19 +3,25 @@
 Run `rubocop --auto-correct && git commit` with each cop.
 
 [![Gem Version](https://badge.fury.io/rb/rubocop_auto_corrector.svg)](https://badge.fury.io/rb/rubocop_auto_corrector)
-[![Build Status](https://travis-ci.org/sue445/rubocop_auto_corrector.svg?branch=master)](https://travis-ci.org/sue445/rubocop_auto_corrector)
+[![Build Status](https://github.com/sue445/rubocop_auto_corrector/workflows/test/badge.svg?branch=master)](https://github.com/sue445/rubocop_auto_corrector/actions?query=workflow%3Atest)
 [![Maintainability](https://api.codeclimate.com/v1/badges/384834e50f94e344c439/maintainability)](https://codeclimate.com/github/sue445/rubocop_auto_corrector/maintainability)
 [![Coverage Status](https://coveralls.io/repos/github/sue445/rubocop_auto_corrector/badge.svg?branch=master)](https://coveralls.io/github/sue445/rubocop_auto_corrector?branch=master)
 
-# Example
+## Example
 See https://github.com/sue445/rubocop_auto_corrector/pull/3/commits
 
+## Requirements
+* Ruby
+* git
+
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rubocop_auto_corrector'
+group :development do
+  gem 'rubocop_auto_corrector', require: false
+end
 ```
 
 And then execute:
@@ -36,6 +42,7 @@ $ bundle exec rubocop_auto_corrector
 $ bundle exec rubocop_auto_corrector --help
 Usage: rubocop_auto_corrector [options]
         --auto-correct-count COUNT   Run `rubocop --auto-correct` and `git commit` for this number of times. (default. 2)
+        --all                        Whether run `rubocop` with `--auto-correct-all`. (default. run with `--auto-correct`)
 ```
 
 ## Development

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'rubocop_auto_corrector'

data/exe/rubocop_auto_corrector

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'rubocop_auto_corrector/cli'
 require 'rubocop_auto_corrector/version'
@@ -6,16 +7,27 @@ require 'optparse'
 
 opt = OptionParser.new
 params = {
-  auto_correct_count: 2
+  auto_correct_count: 2,
+  auto_correct_all: false
 }
 
 Version = RubocopAutoCorrector::VERSION
-opt.on('--auto-correct-count COUNT', 'Run `rubocop --auto-correct` and `git commit` for this number of times. (default. 2)') { |v| params[:auto_correct_count] = v.to_i }
+
+opt.on(
+  '--auto-correct-count COUNT',
+  'Run `rubocop --auto-correct` and `git commit` for this number of times. (default. 2)'
+) do |v|
+  params[:auto_correct_count] = v.to_i
+end
+
+opt.on('--all', 'Whether run `rubocop` with `--auto-correct-all`. (default. run with `--auto-correct`)') do
+  params[:auto_correct_all] = true
+end
 
 opt.parse!(ARGV)
 
 cli = RubocopAutoCorrector::CLI.new
 
 params[:auto_correct_count].times do
-  cli.perform
+  cli.perform(params[:auto_correct_all])
 end

data/lib/rubocop_auto_corrector.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rubocop_auto_corrector/version'
 require 'rubocop_auto_corrector/cop_finder'
 

data/lib/rubocop_auto_corrector/cli.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RubocopAutoCorrector
   require 'json'
   require 'yaml'
@@ -13,11 +15,11 @@ module RubocopAutoCorrector
       @exclude_cops = data['exclude_cops']
     end
 
-    def perform
-      cop_names =
-        collect_offense_cop_names
-        .select { |cop_name| auto_correctable?(cop_name) }
-        .sort_by { |cop_name| [cop_order(cop_name), cop_name] }
+    def perform(auto_collect_all)
+      rubocop_option = auto_collect_all ? '--auto-correct-all' : '--auto-correct'
+
+      cop_names = collect_offense_cop_names.select { |cop_name| auto_correctable?(cop_name) }
+                                           .sort_by { |cop_name| [cop_order(cop_name), cop_name] }
 
       cop_names.each do |cop_name|
         if (reason = exclude_reason(cop_name))
@@ -25,7 +27,7 @@ module RubocopAutoCorrector
           next
         end
 
-        run_and_commit "rubocop --auto-correct --only #{cop_name}"
+        run_and_commit "rubocop #{rubocop_option} --only #{cop_name}"
       end
     end
 

data/lib/rubocop_auto_corrector/cop_finder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RubocopAutoCorrector
   class CopFinder
     attr_reader :cop_name
@@ -10,11 +12,13 @@ module RubocopAutoCorrector
     # Whether this cop is auto correctable
     # @return [Boolean]
     def auto_correctable?
-      Object.new.instance_eval <<-RUBY
+      Object.new.instance_eval <<-RUBY, __FILE__, __LINE__ + 1
         begin
           require '#{gem_name}'
         rescue LoadError
         end
+
+        return #{cop_class_name}.support_autocorrect? if #{cop_class_name}.respond_to?(:support_autocorrect?)
         #{cop_class_name}.new.respond_to?(:autocorrect)
       RUBY
     rescue NameError
@@ -35,6 +39,7 @@ module RubocopAutoCorrector
 
     private
 
+    # rubocop:disable Metrics/MethodLength
     def rubocop_cop_info
       cop_class_suffix = cop_name.gsub('/', '::')
 
@@ -43,14 +48,16 @@ module RubocopAutoCorrector
         ['rubocop-rspec', "::RuboCop::Cop::#{cop_class_suffix}"]
       when %r{^(FactoryBot|Capybara)/}, 'Rails/HttpStatus'
         ['rubocop-rspec', "::RuboCop::Cop::RSpec::#{cop_class_suffix}"]
-      when %r{^(Layout|Lint|Metrics|Naming|Performance|Rails|Security|Style|Bundler|Gemspec)/}
+      when %r{^(Layout|Lint|Metrics|Naming|Security|Style|Bundler|Gemspec)/}
         # Official cops
         ['rubocop', "::RuboCop::Cop::#{cop_class_suffix}"]
       else
         # Unknown cops
-        department = cop_name.split('/').first.downcase
-        ["rubocop-#{department}", "::RuboCop::Cop::#{cop_class_suffix}"]
+        department_camel = cop_name.split('/').first
+        department_snake = department_camel.gsub(/(?<=.)([A-Z])/) { |s| "_#{s}" }.downcase
+        ["rubocop-#{department_snake}", "::RuboCop::Cop::#{cop_class_suffix}"]
       end
     end
+    # rubocop:enable Metrics/MethodLength
   end
 end

data/lib/rubocop_auto_corrector/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RubocopAutoCorrector
-  VERSION = '0.1.0.beta2'.freeze
+  VERSION = '0.4.1'
 end

data/rubocop_auto_corrector.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rubocop_auto_corrector/version'
@@ -33,14 +35,17 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '>= 0.49.0'
+  spec.required_ruby_version = '>= 2.4.0'
+
+  spec.add_dependency 'rubocop', '>= 0.87.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.17'
+  spec.add_development_dependency 'bundler', '>= 1.17'
   spec.add_development_dependency 'coveralls'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-parameterized'
   spec.add_development_dependency 'rspec-temp_dir', '>= 1.1.0'
   spec.add_development_dependency 'rubocop-rspec'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'simplecov', '< 0.18.0'
+  spec.add_development_dependency 'unparser', '>= 0.4.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop_auto_corrector
 version: !ruby/object:Gem::Version
-  version: 0.1.0.beta2
+  version: 0.4.1
 platform: ruby
 authors:
 - sue445
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-29 00:00:00.000000000 Z
+date: 2020-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,26 +16,26 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.87.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.87.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.17'
 - !ruby/object:Gem::Dependency
@@ -56,16 +56,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -124,18 +124,32 @@ dependencies:
         version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.18.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.18.0
+- !ruby/object:Gem::Dependency
+  name: unparser
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.4.5
 description: Run `rubocop --auto-correct && git commit` with each cop.
 email:
 - sue445@sue445.net
@@ -145,10 +159,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".coveralls.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -178,15 +192,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Run `rubocop --auto-correct && git commit` with each cop.

data/.travis.yml

@@ -1,34 +0,0 @@
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.2
-  - 2.3
-  - 2.4
-  - 2.5
-  - ruby-head
-bundler_args: "--jobs=4"
-before_install:
-  - gem update --system --no-document
-  - gem install bundler --no-document
-before_script:
-  - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter
-  - chmod +x ./cc-test-reporter
-  - ./cc-test-reporter before-build
-script:
-  - bundle exec rspec
-after_script:
-  - ./cc-test-reporter after-build --exit-code $TRAVIS_TEST_RESULT
-branches:
-  only:
-    - master
-notifications:
-  email: false
-  slack:
-    secure: StdMcwf2erVzwfR45Rsw8hKmzaCdg7xl6UzEyPkyrNi1eKS/qeys8Ga1Q5I4HFlmybpBuOTk8dwiya0svGIJtABPUeIe7UjkmGDhS6Q+K+Gk8tNayrvOXgS71JJlqPdTVoWCPqNeqs/a+G9xa/T/TcQgZhh+57Jl9fH4hz/UaXhO0uVuL5LwHvKW6UX35xbAnIdPqMXF7finqF8nxU8nzaGvZ+UrUmnLDIRBeeW1eSopWQP7O+89BM+Nr7vC0oC/fJDcszTnZwYk6b38z9kD8Rvb3H0BktERmeR4QROdokq8BeXKj7uNluHZcr7KQc8qhJA7jAhx326A2oi8C+Yyl4Mz75WsQ+a+JFnVwYgpTXjd4/DnTEA5JUokO2DzsDmcPgnvOgOzAVWdtx3Q96GIcs9vU4X1HuIlctye05ylwVUbOE6up4m47NYLkVmjfYgUq3YVGrqprrlv5gqDqTPb8Il7l+plEobvZhM2cjGx+A/HkpVDgiqfE2IwP3BBeZp5Nkn2P4XUAoFtHkVuTVly55b/Jtnvo83UTv6qJWvTKjM7EorQT9+NlsWe64z5T6VVM6Z5FYHIofFpyRdqSTxcP2AHVpHFckw19px3tC4WiwZzgj4PuMvwcHsgK80wErYOJxlkVAUKuw1nh7g8KZpHjHXp1bCwM6pIK4F9PGMFY/g=
-matrix:
-  allow_failures:
-    - rvm: ruby-head
-env:
-  global:
-    - CC_TEST_REPORTER_ID=ae386af24f1ca076680045ecadf328fc77fd71bf6c014b5503d406d8bd87c42a