rubocop_auto_corrector 0.1.0.beta1 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a49a13088441b5013dc3201f355bdbe72dbed856f382e1e980ff6a1226708fb0
-  data.tar.gz: 0c7c9f3c2a254bd55d5c5011137dabef38c49e520ae45934e36466efb67c3d74
+  metadata.gz: 509d6918b9fdfe52298f58bbe9be36931e3dd47115becd4e4fda20de29dec3ef
+  data.tar.gz: f65fd537d05dc43b5c7e33d525781a67f2941b4f77e63caad3edae309d15a29f
 SHA512:
-  metadata.gz: 4c0f3e1c67c1a6d07f2a7e134c2ce99c0d45e042ede33c08f8c881f78cd87ae59a8b44fc274b33a9c6fc5681565a970ffa7ad427189841ab70f4ddcc2c977840
-  data.tar.gz: e3064d3ab780f08597235065f6502aec40e6df1497ef13783f0beea8382771d9298cda56a1fcef33cde002c235e2bc29abbd3445ed511ee8fff6411b32ca4f3f
+  metadata.gz: 5096bf602e4f4158c9f4daeee6f02ceb7f1dd144bcc4d3a46d01afecc3bfe55ed5e3ee73aa909f4ef2e4765c829e86091d56b40038f1b5c1c85f1da80c576855
+  data.tar.gz: 228c3f22ecad65538f108e3218079866e2c7b1071cca78e6dc266ec6e297ff950a719610a73fd88b9c7a1555c18f4180f4fc374cc2fb156ffa41e8b59043667f

data/.coveralls.yml

@@ -0,0 +1 @@
+repo_token: Qeqfezb3pV4exGsEupqPmLm4jYYZYVciw

data/.github/workflows/test.yml

@@ -0,0 +1,115 @@
+name: test
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    types:
+      - opened
+      - synchronize
+      - reopened
+  schedule:
+    - cron: "0 10 * * 5" # JST 19:00 (Fri)
+
+env:
+  CI: "true"
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    container: ${{ matrix.ruby }}
+
+    strategy:
+      fail-fast: false
+
+      matrix:
+        ruby:
+          - ruby:2.4
+          - ruby:2.5
+          - ruby:2.6
+          - ruby:2.7
+          - rubylang/ruby:master-nightly-bionic
+        include:
+          - ruby: rubylang/ruby:master-nightly-bionic
+            allow_failures: "true"
+
+    steps:
+      - uses: actions/checkout@v2
+
+
+      - name: Cache vendor/bundle
+        uses: actions/cache@v1
+        id: cache_gem
+        with:
+          path: vendor/bundle
+          key: v1-gem-${{ runner.os }}-${{ matrix.ruby }}-${{ github.sha }}
+          restore-keys: |
+            v1-gem-${{ runner.os }}-${{ matrix.ruby }}-
+        continue-on-error: ${{ matrix.allow_failures == 'true' }}
+
+      - name: bundle update
+        run: |
+          set -xe
+          bundle config path vendor/bundle
+          bundle update --jobs $(nproc) --retry 3
+        continue-on-error: ${{ matrix.allow_failures == 'true' }}
+
+      - name: Setup Code Climate Test Reporter
+        uses: aktions/codeclimate-test-reporter@v1
+        with:
+          codeclimate-test-reporter-id: ${{ secrets.CC_TEST_REPORTER_ID }}
+          command: before-build
+        if: matrix.ruby >= 'ruby:2.4'
+        continue-on-error: true
+
+      - name: Set up git
+        run: |
+          set -xe
+          git config --global user.email "github-runner@example.com"
+          git config --global user.name "github runner"
+
+      - name: Run test
+        run: |
+          set -xe
+          bundle exec rspec
+          bundle exec rubocop -P
+        continue-on-error: ${{ matrix.allow_failures == 'true' }}
+
+      - name: Teardown Code Climate Test Reporter
+        uses: aktions/codeclimate-test-reporter@v1
+        with:
+          codeclimate-test-reporter-id: ${{ secrets.CC_TEST_REPORTER_ID }}
+          command: after-build
+        if: matrix.ruby >= 'ruby:2.4' && always()
+        continue-on-error: true
+
+      - name: Slack Notification (not success)
+        uses: homoluctus/slatify@master
+        if: "! success()"
+        continue-on-error: true
+        with:
+          job_name: ${{ format('*build* ({0})', matrix.ruby) }}
+          type: ${{ job.status }}
+          icon_emoji: ":octocat:"
+          url: ${{ secrets.SLACK_WEBHOOK }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+
+  notify:
+    needs:
+      - test
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Slack Notification (success)
+        uses: homoluctus/slatify@master
+        if: always()
+        continue-on-error: true
+        with:
+          job_name: '*build*'
+          type: ${{ job.status }}
+          icon_emoji: ":octocat:"
+          url: ${{ secrets.SLACK_WEBHOOK }}
+          token: ${{ secrets.GITHUB_TOKEN }}

data/.rubocop.yml

@@ -1,18 +1,23 @@
-require: rubocop-rspec
-
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.4
 
   Exclude:
-    - 'spec/dummy/**/*.rb'
+    - 'spec/dummy/**/*'
 
-    # via. https://github.com/rubocop-hq/rubocop/blob/v0.60.0/config/default.yml#L60
+    # c.f. https://github.com/rubocop-hq/rubocop/blob/v0.72.0/config/default.yml#L60-L63
     - 'node_modules/**/*'
     - 'vendor/**/*'
     - '.git/**/*'
 
-Layout/IndentHeredoc:
-  Enabled: false
+  NewCops: enable
+
+Metrics/BlockLength:
+  Exclude:
+    - '*.gemspec'
+    - 'spec/**/*_spec.rb'
+
+Layout/LineLength:
+  Max: 110
 
-RSpec/DescribedClass:
+Style/Documentation:
   Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 ## master
-[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.1.0...master)
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.4.0...master)
+
+## v0.4.0
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.3.0...v0.4.0)
+
+* Add `--all` option for `rubocop --auto-correct-all`
+  * https://github.com/sue445/rubocop_auto_corrector/pull/34
+  * When `--all` arg is passed to `rubocop_auto_corrector` (e.g. `rubocop_auto_corrector --all`), run `rubocop --auto-correct-all && git commit` with each cop.
+* Upgrade rubocop and drop support ruby 2.3
+  * https://github.com/sue445/rubocop_auto_corrector/pull/31
+
+## v0.3.0
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.2.0...v0.3.0)
+
+* Support `rubocop-rails` gem (requires rubocop 0.72.0+ and ruby 2.3.0+)
+  * https://github.com/sue445/rubocop_auto_corrector/pull/18
+
+## v0.2.0
+[full changelog](http://github.com/sue445/rubocop_auto_corrector/compare/v0.1.0...v0.2.0)
+
+* Support `rubocop-performance` gem
+  * https://github.com/sue445/rubocop_auto_corrector/pull/16
 
 ## v0.1.0
 * first release

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

data/README.md

@@ -2,15 +2,26 @@
 
 Run `rubocop --auto-correct && git commit` with each cop.
 
-# Example
+[![Gem Version](https://badge.fury.io/rb/rubocop_auto_corrector.svg)](https://badge.fury.io/rb/rubocop_auto_corrector)
+[![Build Status](https://github.com/sue445/rubocop_auto_corrector/workflows/test/badge.svg?branch=master)](https://github.com/sue445/rubocop_auto_corrector/actions?query=workflow%3Atest)
+[![Maintainability](https://api.codeclimate.com/v1/badges/384834e50f94e344c439/maintainability)](https://codeclimate.com/github/sue445/rubocop_auto_corrector/maintainability)
+[![Coverage Status](https://coveralls.io/repos/github/sue445/rubocop_auto_corrector/badge.svg?branch=master)](https://coveralls.io/github/sue445/rubocop_auto_corrector?branch=master)
+
+## Example
 See https://github.com/sue445/rubocop_auto_corrector/pull/3/commits
 
+## Requirements
+* Ruby
+* git
+
 ## Installation
 
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'rubocop_auto_corrector'
+group :development do
+  gem 'rubocop_auto_corrector', require: false
+end
 ```
 
 And then execute:
@@ -31,6 +42,7 @@ $ bundle exec rubocop_auto_corrector
 $ bundle exec rubocop_auto_corrector --help
 Usage: rubocop_auto_corrector [options]
         --auto-correct-count COUNT   Run `rubocop --auto-correct` and `git commit` for this number of times. (default. 2)
+        --all                        Whether run `rubocop` with `--auto-correct-all`. (default. run with `--auto-correct`)
 ```
 
 ## Development

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'rubocop_auto_corrector'

data/exe/rubocop_auto_corrector

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'rubocop_auto_corrector/cli'
 require 'rubocop_auto_corrector/version'
@@ -6,16 +7,27 @@ require 'optparse'
 
 opt = OptionParser.new
 params = {
-  auto_correct_count: 2
+  auto_correct_count: 2,
+  auto_correct_all: false
 }
 
 Version = RubocopAutoCorrector::VERSION
-opt.on('--auto-correct-count COUNT', 'Run `rubocop --auto-correct` and `git commit` for this number of times. (default. 2)') { |v| params[:auto_correct_count] = v.to_i }
+
+opt.on(
+  '--auto-correct-count COUNT',
+  'Run `rubocop --auto-correct` and `git commit` for this number of times. (default. 2)'
+) do |v|
+  params[:auto_correct_count] = v.to_i
+end
+
+opt.on('--all', 'Whether run `rubocop` with `--auto-correct-all`. (default. run with `--auto-correct`)') do
+  params[:auto_correct_all] = true
+end
 
 opt.parse!(ARGV)
 
 cli = RubocopAutoCorrector::CLI.new
 
 params[:auto_correct_count].times do
-  cli.perform
+  cli.perform(params[:auto_correct_all])
 end

data/lib/rubocop_auto_corrector.rb

@@ -1,4 +1,7 @@
+# frozen_string_literal: true
+
 require 'rubocop_auto_corrector/version'
+require 'rubocop_auto_corrector/cop_finder'
 
 module RubocopAutoCorrector
   class Error < StandardError; end

data/lib/rubocop_auto_corrector/cli.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 module RubocopAutoCorrector
   require 'json'
   require 'yaml'
   require 'rubocop'
+  require 'rubocop_auto_corrector'
 
   class CLI
     DEFAULT_ORDER = 100
@@ -12,11 +15,11 @@ module RubocopAutoCorrector
       @exclude_cops = data['exclude_cops']
     end
 
-    def perform
-      cop_names =
-        collect_offense_cop_names
-        .select { |cop_name| auto_correctable?(cop_name) }
-        .sort_by { |cop_name| [cop_order(cop_name), cop_name] }
+    def perform(auto_collect_all)
+      rubocop_option = auto_collect_all ? '--auto-correct-all' : '--auto-correct'
+
+      cop_names = collect_offense_cop_names.select { |cop_name| auto_correctable?(cop_name) }
+                                           .sort_by { |cop_name| [cop_order(cop_name), cop_name] }
 
       cop_names.each do |cop_name|
         if (reason = exclude_reason(cop_name))
@@ -24,7 +27,7 @@ module RubocopAutoCorrector
           next
         end
 
-        run_and_commit "rubocop --auto-correct --only #{cop_name}"
+        run_and_commit "rubocop #{rubocop_option} --only #{cop_name}"
       end
     end
 
@@ -38,21 +41,13 @@ module RubocopAutoCorrector
       cop_names.uniq
     end
 
+    # Whether this cop is auto correctable
+    #
+    # @param cop_name [String]
+    #
+    # @return [Boolean]
     def auto_correctable?(cop_name)
-      cop_class_name = "::RuboCop::Cop::#{cop_name.gsub('/', '::')}"
-      plugin_name = "rubocop-#{cop_name.split('/').first.downcase}"
-
-      begin
-        Object.new.instance_eval <<-RUBY
-          begin
-            require '#{plugin_name}'
-          rescue LoadError
-          end
-          #{cop_class_name}.new.respond_to?(:autocorrect)
-        RUBY
-      rescue NameError
-        false
-      end
+      RubocopAutoCorrector::CopFinder.new(cop_name).auto_correctable?
     end
 
     private

data/lib/rubocop_auto_corrector/cop_finder.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+module RubocopAutoCorrector
+  class CopFinder
+    attr_reader :cop_name
+
+    # @param cop_name [String] e.g. Metrics/AbcSize
+    def initialize(cop_name)
+      @cop_name = cop_name
+    end
+
+    # Whether this cop is auto correctable
+    # @return [Boolean]
+    def auto_correctable?
+      Object.new.instance_eval <<-RUBY, __FILE__, __LINE__ + 1
+        begin
+          require '#{gem_name}'
+        rescue LoadError
+        end
+        #{cop_class_name}.new.respond_to?(:autocorrect)
+      RUBY
+    rescue NameError
+      false
+    end
+
+    # @return [String]
+    def gem_name
+      gem_name, = rubocop_cop_info
+      gem_name
+    end
+
+    # @return [String]
+    def cop_class_name
+      _, cop_class = rubocop_cop_info
+      cop_class
+    end
+
+    private
+
+    # rubocop:disable Metrics/MethodLength
+    def rubocop_cop_info
+      cop_class_suffix = cop_name.gsub('/', '::')
+
+      case cop_name
+      when %r{^RSpec/}
+        ['rubocop-rspec', "::RuboCop::Cop::#{cop_class_suffix}"]
+      when %r{^(FactoryBot|Capybara)/}, 'Rails/HttpStatus'
+        ['rubocop-rspec', "::RuboCop::Cop::RSpec::#{cop_class_suffix}"]
+      when %r{^(Layout|Lint|Metrics|Naming|Security|Style|Bundler|Gemspec)/}
+        # Official cops
+        ['rubocop', "::RuboCop::Cop::#{cop_class_suffix}"]
+      else
+        # Unknown cops
+        department_camel = cop_name.split('/').first
+        department_snake = department_camel.gsub(/(?<=.)([A-Z])/) { |s| "_#{s}" }.downcase
+        ["rubocop-#{department_snake}", "::RuboCop::Cop::#{cop_class_suffix}"]
+      end
+    end
+    # rubocop:enable Metrics/MethodLength
+  end
+end

data/lib/rubocop_auto_corrector/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RubocopAutoCorrector
-  VERSION = '0.1.0.beta1'.freeze
+  VERSION = '0.4.0'
 end

data/rubocop_auto_corrector.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rubocop_auto_corrector/version'
@@ -33,12 +35,17 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '>= 0.49.0'
+  spec.required_ruby_version = '>= 2.4.0'
+
+  spec.add_dependency 'rubocop', '>= 0.87.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.17'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '>= 1.17'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-parameterized'
   spec.add_development_dependency 'rspec-temp_dir', '>= 1.1.0'
   spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'simplecov', '< 0.18.0'
+  spec.add_development_dependency 'unparser', '>= 0.4.5'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop_auto_corrector
 version: !ruby/object:Gem::Version
-  version: 0.1.0.beta1
+  version: 0.4.0
 platform: ruby
 authors:
 - sue445
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2020-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,42 +16,56 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.87.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.87.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.17'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -108,6 +122,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.18.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.18.0
+- !ruby/object:Gem::Dependency
+  name: unparser
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.4.5
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.4.5
 description: Run `rubocop --auto-correct && git commit` with each cop.
 email:
 - sue445@sue445.net
@@ -116,10 +158,11 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".coveralls.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -130,6 +173,7 @@ files:
 - exe/rubocop_auto_corrector
 - lib/rubocop_auto_corrector.rb
 - lib/rubocop_auto_corrector/cli.rb
+- lib/rubocop_auto_corrector/cop_finder.rb
 - lib/rubocop_auto_corrector/data.yml
 - lib/rubocop_auto_corrector/version.rb
 - rubocop_auto_corrector.gemspec
@@ -148,15 +192,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.4.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Run `rubocop --auto-correct && git commit` with each cop.

data/.travis.yml

@@ -1,7 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.5.3
-before_install: gem install bundler -v 1.17.1