rubocop 1.88.2 → 1.89.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8642dc64b958118e0563ed93c4837ac13aca29cb8f8a6267155ef450380ea1b3
-  data.tar.gz: 569ff18924510b28b60ff03563053d0c53983829d7f4755c0ad39cc213b41f64
+  metadata.gz: e613534eb66c6766aa04d7e1075e0d09aa8a3a78690b8b921583d81ea9fb8e9e
+  data.tar.gz: c65ec7b8f764105d8950cc73c4deca24f6bec976c6c4041b5338f4a97e98645c
 SHA512:
-  metadata.gz: 1cc966f73a8b890c335fedbc55fa0ec0f8a73099703cf46111e8619933f2d4b9436cf1c7d597f7fef0282e1e1e2f6b6adc4b4e38c7195eabb600fe97d9931526
-  data.tar.gz: 94cc97c23eeaaff0ec7ab9046a2275547fe2363449d0582733e30be26868e098d12c609703fdc2318b1e4d96b8205abf6fe537d655950cf558debfcb6224366c
+  metadata.gz: 400677d5633740bb086f3f6e4c6cb9438423ce5a77ea6bc8a4bd72ff0249332c58370bbd98f809673699806cc2ae8dfde4d95a9313bfb8e465c631b506a18d20
+  data.tar.gz: a08736ea293673d3cebd8185df6b8b0cf718d24d23b772c20c09c1c00e61838c4963245e84074fe0b8732ad5eb32f9f459c3d915fb5a07ad9ee0e0019d2b9a2c

data/config/default.yml

@@ -110,6 +110,12 @@ AllCops:
   # a warning is shown and the flag has no effect.
   # The default `false` preserves RuboCop's traditional file-local analysis.
   UseProjectIndex: false
+  # When the project index is enabled, also index the sources of the gems in
+  # the project's bundle. This lets index-aware cops resolve ancestry chains
+  # and members that live in gems (e.g. framework base classes), at the cost
+  # of extra memory proportional to the bundle's size. Has no effect when
+  # `UseProjectIndex` is `false` or when RuboCop does not run inside Bundler.
+  ProjectIndexIncludesGems: false
   # Enables the result cache if `true`. Can be overridden by the `--cache` command
   # line option.
   UseCache: true
@@ -165,6 +171,7 @@ AllCops:
     rubocop-capybara: [capybara]
     rubocop-factory_bot: [factory_bot, factory_bot_rails]
     rubocop-rspec_rails: [rspec-rails]
+    rubocop-i18n: [i18n, gettext]
   # Enable/Disable checking the methods extended by Active Support.
   ActiveSupportExtensionsEnabled: false
   # Future version of Ruby will freeze string literals by default.
@@ -511,7 +518,7 @@ Layout/ClassStructure:
   Enabled: false
   SafeAutoCorrect: false
   VersionAdded: '0.52'
-  VersionChanged: '1.53'
+  VersionChanged: '1.89'
   Categories:
     module_inclusion:
       - include
@@ -524,6 +531,7 @@ Layout/ClassStructure:
     - initializer
     - public_methods
     - protected_methods
+    - private_class_methods
     - private_methods
 
 Layout/ClosingHeredocIndentation:
@@ -1069,6 +1077,7 @@ Layout/LeadingCommentSpace:
   AllowGemfileRubyComment: false
   AllowRBSInlineAnnotation: false
   AllowSteepAnnotation: false
+  AllowYARDCommentBlockSeparator: false
 
 Layout/LeadingEmptyLines:
   Description: Checks for unnecessary blank lines at the beginning of a file.
@@ -1615,7 +1624,7 @@ Lint/AmbiguousBlockAssociation:
                  parentheses.
   Enabled: true
   VersionAdded: '0.48'
-  VersionChanged: '1.13'
+  VersionChanged: '1.89'
   AllowedMethods: []
   AllowedPatterns: []
 
@@ -1713,6 +1722,7 @@ Lint/ConstantReassignment:
 
 Lint/ConstantResolution:
   Description: 'Checks that constants are fully qualified with `::`.'
+  VersionChanged: '1.89'
   Enabled: false
   VersionAdded: '0.86'
   # Restrict this cop to only looking at certain names
@@ -1829,6 +1839,14 @@ Lint/DeprecatedOpenSSLConstant:
   Enabled: true
   VersionAdded: '0.84'
 
+Lint/DeprecatedReference:
+  Description: >-
+                  Checks for references to methods and constants documented
+                  as deprecated with a YARD `@deprecated` tag.
+                  Requires `AllCops/UseProjectIndex` to be enabled.
+  Enabled: pending
+  VersionAdded: '1.89'
+
 Lint/DisjunctiveAssignmentInConstructor:
   Description: 'In constructor, plain assignment is preferred over disjunctive.'
   Enabled: true
@@ -1875,6 +1893,14 @@ Lint/DuplicateMethods:
   Description: 'Checks for duplicate method definitions.'
   Enabled: true
   VersionAdded: '0.29'
+  VersionChanged: '1.89'
+  # Methods that define instance methods by delegation, in the style of
+  # Active Support's `delegate` (`delegate :foo, :bar, to: :target`). Register
+  # a project's own `delegate`-shaped macros here so the cop recognizes the
+  # methods they define. Only takes effect when `AllCops/ActiveSupportExtensionsEnabled`
+  # is `true`.
+  DelegatingMethods:
+    - delegate
 
 Lint/DuplicateRegexpCharacterClassElement:
   Description: 'Checks for duplicate elements in Regexp character classes.'
@@ -2057,7 +2083,7 @@ Lint/InheritException:
   Enabled: true
   SafeAutoCorrect: false
   VersionAdded: '0.41'
-  VersionChanged: '1.26'
+  VersionChanged: '1.89'
   # The default base class in favour of `Exception`.
   EnforcedStyle: standard_error
   SupportedStyles:
@@ -2130,7 +2156,7 @@ Lint/MissingSuper:
                   without calls to `super`.
   Enabled: true
   VersionAdded: '0.89'
-  VersionChanged: '1.4'
+  VersionChanged: '1.89'
   AllowedParentClasses: []
 
 Lint/MixedCaseRange:
@@ -2150,6 +2176,16 @@ Lint/MultipleComparison:
   VersionAdded: '0.47'
   VersionChanged: '1.1'
 
+Lint/NameTypo:
+  Description: >-
+    Checks for probable typos in constant and method names,
+    using the project index.
+  Enabled: pending
+  CheckConstants: true
+  CheckMethods: true
+  AllowedNames: []
+  VersionAdded: '1.89'
+
 Lint/NestedMethodDefinition:
   Description: 'Do not use nested method definitions.'
   StyleGuide: '#no-nested-methods'
@@ -2409,8 +2445,9 @@ Lint/ReturnInVoidContext:
 Lint/SafeNavigationChain:
   Description: 'Do not chain ordinary method call after safe navigation operator.'
   Enabled: true
+  SafeAutoCorrect: false
   VersionAdded: '0.47'
-  VersionChanged: '0.77'
+  VersionChanged: '1.89'
   AllowedMethods:
     - present?
     - blank?
@@ -2632,6 +2669,18 @@ Lint/UnusedMethodArgument:
   NotImplementedExceptions:
     - NotImplementedError
 
+Lint/UnusedPrivateMethod:
+  Description: >-
+                  Checks for private instance methods that are not referenced
+                  anywhere in the project. Requires `AllCops/UseProjectIndex`
+                  to be enabled.
+  # This cop is disabled by default because symbol-based references from other
+  # files (e.g. Rails callbacks declared in a concern) cannot be detected and
+  # would be reported as false positives. It is intended for occasional
+  # dead-code sweeps rather than permanent enforcement.
+  Enabled: false
+  VersionAdded: '1.89'
+
 Lint/UriEscapeUnescape:
   Description: >-
                  `URI.escape` method is obsolete and should not be used. Instead, use
@@ -2863,6 +2912,7 @@ Migration/DepartmentName:
 Naming/AccessorMethodName:
   Description: Checks the naming of accessor methods for get_/set_.
   StyleGuide: '#accessor_mutator_method_names'
+  VersionChanged: '1.89'
   Enabled: true
   VersionAdded: '0.50'
 
@@ -3139,7 +3189,7 @@ Naming/PredicatePrefix:
   StyleGuide: '#bool-methods-qmark'
   Enabled: true
   VersionAdded: '0.50'
-  VersionChanged: '1.75'
+  VersionChanged: '1.89'
   # Predicate name prefixes.
   NamePrefix:
     - is_
@@ -3607,13 +3657,14 @@ Style/ClassAndModuleChildren:
   StyleGuide: '#namespace-definition'
   # Moving from compact to nested children requires knowledge of whether the
   # outer parent is a module or a class. Moving from nested to compact requires
-  # verification that the outer parent is defined elsewhere. RuboCop does not
-  # have the knowledge to perform either operation safely and thus requires
-  # manual oversight.
+  # verification that the outer parent is defined elsewhere. By default RuboCop
+  # does not have the knowledge to perform either operation safely and thus
+  # requires manual oversight. When `AllCops/UseProjectIndex` is enabled, the
+  # project-wide index is consulted for both operations.
   SafeAutoCorrect: false
   Enabled: true
   VersionAdded: '0.19'
-  VersionChanged: '1.74'
+  VersionChanged: '1.89'
   #
   # Basically there are two different styles:
   #
@@ -3925,8 +3976,9 @@ Style/DisableCopsWithinSourceCodeDirective:
                  Forbids disabling/enabling cops within source code.
   Enabled: false
   VersionAdded: '0.82'
-  VersionChanged: '1.9'
+  VersionChanged: '1.89'
   AllowedCops: []
+  DisallowedCops: []
 
 Style/DocumentDynamicEvalDefinition:
   Description: >-
@@ -3941,6 +3993,7 @@ Style/Documentation:
   Description: 'Document classes and non-namespace modules.'
   Enabled: true
   VersionAdded: '0.9'
+  VersionChanged: '1.89'
   AllowedConstants: []
   Exclude:
     - 'spec/**/*'
@@ -4778,6 +4831,7 @@ Style/MissingRespondToMissing:
   StyleGuide: '#no-method-missing'
   Enabled: true
   VersionAdded: '0.56'
+  VersionChanged: '1.89'
 
 Style/MixinGrouping:
   Description: 'Checks for grouping of mixins in `class` and `module` bodies.'
@@ -5397,6 +5451,7 @@ Style/RedundantConditional:
 
 Style/RedundantConstantBase:
   Description: Avoid redundant `::` prefix on constant.
+  VersionChanged: '1.89'
   Enabled: pending
   VersionAdded: '1.40'
 
@@ -5830,6 +5885,7 @@ Style/StabbyLambdaParentheses:
 Style/StaticClass:
   Description: 'Prefer modules to classes with only class methods.'
   StyleGuide: '#modules-vs-classes'
+  VersionChanged: '1.89'
   Enabled: false
   Safe: false
   VersionAdded: '1.3'

data/lib/rubocop/comment_config.rb

@@ -55,8 +55,8 @@ module RuboCop
 
     def extra_enabled_comments
       disable_count = Hash.new(0)
-      registry.disabled(config).each do |cop|
-        disable_count[cop.cop_name] += 1
+      registry.disabled_names(config).each do |cop_name|
+        disable_count[cop_name] += 1
       end
       extra_enabled_comments_with_names(extras: Hash.new { |h, k| h[k] = [] }, names: disable_count)
     end
@@ -65,6 +65,24 @@ module RuboCop
       non_comment_token_line_numbers.none?(line_number)
     end
 
+    # The names of the cops that are opted in by an `enable` comment directive,
+    # used to mobilize cops disabled in the config on demand.
+    #
+    # @api private
+    # @return [Set<String>]
+    def opt_in_cops
+      @opt_in_cops ||= begin
+        cops = Set.new
+        each_directive do |directive|
+          next unless directive.enabled?
+          next if directive.all_cops?
+
+          cops.merge(directive.raw_cop_names)
+        end
+        cops
+      end
+    end
+
     private
 
     def extra_enabled_comments_with_names(extras:, names:)
@@ -82,19 +100,6 @@ module RuboCop
       extras
     end
 
-    def opt_in_cops
-      @opt_in_cops ||= begin
-        cops = Set.new
-        each_directive do |directive|
-          next unless directive.enabled?
-          next if directive.all_cops?
-
-          cops.merge(directive.raw_cop_names)
-        end
-        cops
-      end
-    end
-
     # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
     def analyze
       return {} if @no_directives
@@ -119,6 +124,8 @@ module RuboCop
 
       analyses.each_with_object({}) do |element, hash|
         cop_name, analysis = *element
+        next if prevent_directive_disabling?(cop_name)
+
         hash[cop_name] = cop_line_ranges(analysis)
       end
     end
@@ -163,10 +170,10 @@ module RuboCop
     end
 
     def inject_disabled_cops_directives(analyses)
-      registry.disabled(config).each do |cop|
-        analyses[cop.cop_name] = analyze_cop(
-          analyses[cop.cop_name],
-          DirectiveComment.new(ConfigDisabledCopDirectiveComment.new(cop.cop_name))
+      registry.disabled_names(config).each do |cop_name|
+        analyses[cop_name] = analyze_cop(
+          analyses[cop_name],
+          DirectiveComment.new(ConfigDisabledCopDirectiveComment.new(cop_name))
         )
       end
     end
@@ -222,6 +229,15 @@ module RuboCop
       Cop::Registry.qualified_cop_name(cop_name.strip, processed_source.file_path)
     end
 
+    # `Style/DisableCopsWithinSourceCodeDirective` cannot be disabled via
+    # directive comments when it is explicitly enabled with `Enabled: true`.
+    # This prevents users from bypassing the cop by writing a disable
+    # directive that targets this cop itself.
+    def prevent_directive_disabling?(cop_name)
+      cop_name == DirectiveComment::STYLE_DISABLE_COPS_DIRECTIVE_COP &&
+        config.dig(cop_name, 'Enabled') == true
+    end
+
     def non_comment_token_line_numbers
       @non_comment_token_line_numbers ||= begin
         non_comment_tokens = processed_source.tokens.reject(&:comment?)

data/lib/rubocop/config.rb

@@ -209,6 +209,20 @@ module RuboCop
       for_all_cops['NewCops'] == 'enable'
     end
 
+    # Whether the given pending cop should be enabled, based on the `NewCops` setting of
+    # its department (if any) or of `AllCops`. A department may set `NewCops` to `enable`,
+    # `disable`, `pending`, or a version, in which case pending cops added in that version
+    # or earlier are enabled.
+    def enabled_new_cop?(qualified_cop_name)
+      setting = new_cops_setting_for(qualified_cop_name)
+
+      case setting.to_s
+      when 'enable' then true
+      when '', 'pending', 'disable' then false
+      else new_cops_version_covers?(setting, qualified_cop_name)
+      end
+    end
+
     def active_support_extensions_enabled?
       for_all_cops['ActiveSupportExtensionsEnabled']
     end
@@ -326,6 +340,7 @@ module RuboCop
 
         cop_metadata = self[qualified_cop_name]
         next unless cop_metadata['Enabled'] == 'pending'
+        next if new_cops_covered?(qualified_cop_name)
 
         pending_cops << CopConfig.new(qualified_cop_name, cop_metadata)
       end
@@ -399,6 +414,44 @@ module RuboCop
 
       self[cop_department.join('/')]
     end
+
+    # The effective `NewCops` setting for the given cop: the department-level
+    # setting if present, otherwise the `AllCops` setting.
+    def new_cops_setting_for(qualified_cop_name)
+      department = department_of(qualified_cop_name)
+      setting = department['NewCops'] if department
+
+      setting || for_all_cops['NewCops']
+    end
+
+    # Whether the cop's pending status is resolved by a `NewCops` setting,
+    # so that it should not appear in the pending cops warning.
+    # Unlike `enabled_new_cop?`, `disable` counts as covered.
+    def new_cops_covered?(qualified_cop_name)
+      setting = new_cops_setting_for(qualified_cop_name)
+
+      case setting.to_s
+      when 'enable', 'disable' then true
+      when '', 'pending' then false
+      else new_cops_version_covers?(setting, qualified_cop_name)
+      end
+    end
+
+    def new_cops_version_covers?(new_cops_version, qualified_cop_name)
+      cop_metadata = self[qualified_cop_name]
+      version_added = comparable_version(cop_metadata['VersionAdded']) if cop_metadata
+      pinned_version = comparable_version(new_cops_version)
+      return false if version_added.nil? || pinned_version.nil?
+
+      version_added <= pinned_version
+    end
+
+    # Returns a `Gem::Version` for values like `'1.19'` or `1.19`, and `nil`
+    # for non-version values like `'N/A'` or `'<<next>>'`.
+    def comparable_version(value)
+      value = value.to_s
+      Gem::Version.new(value) if value.match?(/\A\d/) && Gem::Version.correct?(value)
+    end
   end
 end
 # rubocop:enable Metrics/ClassLength

data/lib/rubocop/config_validator.rb

@@ -16,6 +16,8 @@ module RuboCop
                          Reference References Safe SafeAutoCorrect].freeze
     # @api private
     NEW_COPS_VALUES = %w[pending disable enable].freeze
+    # @api private
+    NEW_COPS_VERSION_PATTERN = /\A\d+(\.\d+)*\z/.freeze
 
     # @api private
     CONFIG_CHECK_KEYS = %w[Enabled Safe SafeAutoCorrect AutoCorrect References].to_set.freeze
@@ -164,16 +166,48 @@ module RuboCop
     end
 
     def validate_new_cops_parameter
+      validate_all_cops_new_cops_parameter
+      validate_department_new_cops_parameters
+    end
+
+    def validate_all_cops_new_cops_parameter
       new_cop_parameter = @config.for_all_cops['NewCops']
       return if new_cop_parameter.nil? || NEW_COPS_VALUES.include?(new_cop_parameter)
 
-      message = "invalid #{new_cop_parameter} for `NewCops` found in" \
+      message = "invalid #{new_cop_parameter} for `NewCops` found in " \
                 "#{smart_loaded_path}\n" \
                 "Valid choices are: #{NEW_COPS_VALUES.join(', ')}"
 
       raise ValidationError, message
     end
 
+    def validate_department_new_cops_parameters
+      @config.each do |name, section|
+        value = new_cops_value_for_department(name, section)
+        next if value.nil? || NEW_COPS_VALUES.include?(value) || new_cops_version_value?(value)
+
+        raise ValidationError,
+              "invalid #{value} for `NewCops` found in #{smart_loaded_path}\n" \
+              "Valid choices for a department are: #{NEW_COPS_VALUES.join(', ')}, " \
+              "or a version string like '1.50'"
+      end
+    end
+
+    def new_cops_value_for_department(name, section)
+      return nil if name == 'AllCops' || !section.is_a?(Hash)
+      return nil unless Cop::Registry.global.department?(name)
+
+      section['NewCops']
+    end
+
+    def new_cops_version_value?(value)
+      case value
+      when Float, Integer then true
+      when String then NEW_COPS_VERSION_PATTERN.match?(value)
+      else false
+      end
+    end
+
     def validate_parameter_shape(valid_cop_names)
       valid_cop_names.each do |name|
         if @config[name].nil?
@@ -207,6 +241,9 @@ module RuboCop
 
       @config[cop_name].each_key do |param|
         next if COMMON_PARAMS.include?(param) || default_config.key?(param)
+        # Departments shipped as top-level sections in an extension's default configuration accept
+        # `NewCops`, like any other department.
+        next if param == 'NewCops' && Cop::Registry.global.department?(cop_name)
 
         supported_params = default_config.keys - INTERNAL_PARAMS
 

data/lib/rubocop/cop/badge.rb

@@ -52,6 +52,14 @@ module RuboCop
         cop_name == other.cop_name && (!qualified? || department == other.department)
       end
 
+      # Returns true if the badge's qualified name or the badge's department
+      # matches any of the given names.
+      def match_name?(given_names)
+        return false unless given_names
+
+        given_names.include?(to_s) || given_names.include?(department_name)
+      end
+
       def to_s
         @to_s ||= qualified? ? "#{department}/#{cop_name}" : cop_name
       end

data/lib/rubocop/cop/base.rb

@@ -372,6 +372,12 @@ module RuboCop
 
       private
 
+      ### Reserved for Commissioner
+
+      private_class_method def self.restrict_on_send
+        @restrict_on_send ||= self::RESTRICT_ON_SEND.to_a.freeze
+      end
+
       ### Reserved for Cop::Cop
 
       def callback_argument(range)
@@ -400,10 +406,6 @@ module RuboCop
         @current_offenses ||= []
       end
 
-      private_class_method def self.restrict_on_send
-        @restrict_on_send ||= self::RESTRICT_ON_SEND.to_a.freeze
-      end
-
       EMPTY_OFFENSES = [].freeze
       private_constant :EMPTY_OFFENSES
       # Called to complete an investigation

data/lib/rubocop/cop/bundler.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Bundler` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Bundler
+      extend LazyLoader
+
+      register_cop :DuplicatedGem, "#{__dir__}/bundler/duplicated_gem"
+      register_cop :DuplicatedGroup, "#{__dir__}/bundler/duplicated_group"
+      register_cop :GemComment, "#{__dir__}/bundler/gem_comment"
+      register_cop :GemFilename, "#{__dir__}/bundler/gem_filename"
+      register_cop :GemVersion, "#{__dir__}/bundler/gem_version"
+      register_cop :InsecureProtocolSource, "#{__dir__}/bundler/insecure_protocol_source"
+      register_cop :OrderedGems, "#{__dir__}/bundler/ordered_gems"
+    end
+  end
+end

data/lib/rubocop/cop/corrector.rb

@@ -103,7 +103,7 @@ module RuboCop
       # :nodoc:
       def to_range(node_or_range)
         range = case node_or_range
-                when ::RuboCop::AST::Node, ::Parser::Source::Comment
+                when RuboCop::AST::Node, ::Parser::Source::Comment
                   node_or_range.source_range
                 when ::Parser::Source::Range
                   node_or_range

data/lib/rubocop/cop/correctors/alignment_corrector.rb

@@ -12,20 +12,28 @@ module RuboCop
       class << self
         attr_reader :processed_source
 
-        def correct(corrector, processed_source, node, column_delta)
+        # `tab_indentation` may only be set by callers whose `column_delta` represents
+        # whole indentation levels (e.g. `Layout/IndentationWidth`).
+        # Alignment to an arbitrary column cannot be expressed with tabs, so those callers
+        # leave tab correction disabled to avoid producing a never-converging correction.
+        def correct(corrector, processed_source, node, column_delta, tab_indentation: false)
           return unless node
 
           @processed_source = processed_source
-          # Disable autocorrection for tabs as it requires special handling
-          return if using_tabs?
 
           expr = node.respond_to?(:loc) ? node.source_range : node
           return if block_comment_within?(expr)
 
           taboo_ranges = inside_string_ranges(node)
 
-          each_line(expr) do |line_begin_pos|
-            autocorrect_line(corrector, line_begin_pos, expr, column_delta, taboo_ranges)
+          if using_tabs?
+            return unless tab_indentation
+
+            correct_tab_indentation(corrector, expr, column_delta, taboo_ranges)
+          else
+            each_line(expr) do |line_begin_pos|
+              autocorrect_line(corrector, line_begin_pos, expr, column_delta, taboo_ranges)
+            end
           end
         end
 
@@ -58,6 +66,48 @@ module RuboCop
           end
         end
 
+        # Tab indentation is corrected by rewriting each line's leading whitespace to
+        # the target number of tabs. Working in whole tabs rather than applying a column delta
+        # keeps the result idempotent, which avoids the infinite loops that delta-based correction
+        # caused for tabs.
+        def correct_tab_indentation(corrector, expr, column_delta, taboo_ranges)
+          buffer = expr.source_buffer
+
+          each_line(expr) do |line_begin_pos|
+            line_range = buffer.line_range(buffer.line_for_position(line_begin_pos))
+            correct_tab_line(corrector, line_range, column_delta, taboo_ranges)
+          end
+        end
+
+        def correct_tab_line(corrector, line_range, column_delta, taboo_ranges)
+          leading = line_range.source[/\A[ \t]*/]
+          return if leading.length == line_range.source.length # blank line
+
+          leading_range = range_between(line_range.begin_pos, line_range.begin_pos + leading.length)
+          return if taboo_ranges.any? { |t| within?(leading_range, t) }
+
+          target = target_tab_indentation(leading, column_delta)
+          corrector.replace(leading_range, target) unless leading == target
+        end
+
+        def target_tab_indentation(leading, column_delta)
+          width = configured_indentation_width
+          return leading unless width.positive?
+
+          visual_width = leading.chars.sum { |char| char == "\t" ? width : 1 }
+
+          "\t" * ([visual_width + column_delta, 0].max / width)
+        end
+
+        # The number of columns a single tab spans. This must match the width
+        # `Layout/IndentationWidth` uses to compute `column_delta`, otherwise
+        # the division below would not land on a tab boundary. `Layout/IndentationStyle`
+        # has its own `IndentationWidth`, but that only governs how that cop replaces tabs
+        # with spaces, so it must not be consulted here.
+        def configured_indentation_width
+          processed_source.config.for_cop('Layout/IndentationWidth')['Width'] || 2
+        end
+
         def inside_string_ranges(node)
           return [] unless node.is_a?(Parser::AST::Node)
 

data/lib/rubocop/cop/gemspec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Gemspec` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Gemspec
+      extend LazyLoader
+
+      register_cop :AddRuntimeDependency, "#{__dir__}/gemspec/add_runtime_dependency"
+      register_cop :AttributeAssignment, "#{__dir__}/gemspec/attribute_assignment"
+      register_cop :DependencyVersion, "#{__dir__}/gemspec/dependency_version"
+      register_cop :DeprecatedAttributeAssignment, "#{__dir__}/gemspec/deprecated_attribute_assignment"
+      register_cop :DevelopmentDependencies, "#{__dir__}/gemspec/development_dependencies"
+      register_cop :DuplicatedAssignment, "#{__dir__}/gemspec/duplicated_assignment"
+      register_cop :OrderedDependencies, "#{__dir__}/gemspec/ordered_dependencies"
+      register_cop :RequireMFA, "#{__dir__}/gemspec/require_mfa"
+      register_cop :RequiredRubyVersion, "#{__dir__}/gemspec/required_ruby_version"
+      register_cop :RubyVersionGlobalsUsage, "#{__dir__}/gemspec/ruby_version_globals_usage"
+    end
+  end
+end