rubocop 1.88.2 → 1.89.0

data/lib/rubocop/cop/lint.rb

@@ -0,0 +1,176 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Lint` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Lint
+      extend LazyLoader
+
+      register_cop :AmbiguousAssignment, "#{__dir__}/lint/ambiguous_assignment"
+      register_cop :AmbiguousBlockAssociation, "#{__dir__}/lint/ambiguous_block_association"
+      register_cop :AmbiguousOperator, "#{__dir__}/lint/ambiguous_operator"
+      register_cop :AmbiguousOperatorPrecedence, "#{__dir__}/lint/ambiguous_operator_precedence"
+      register_cop :AmbiguousRange, "#{__dir__}/lint/ambiguous_range"
+      register_cop :AmbiguousRegexpLiteral, "#{__dir__}/lint/ambiguous_regexp_literal"
+      register_cop :ArrayLiteralInRegexp, "#{__dir__}/lint/array_literal_in_regexp"
+      register_cop :AssignmentInCondition, "#{__dir__}/lint/assignment_in_condition"
+      register_cop :BigDecimalNew, "#{__dir__}/lint/big_decimal_new"
+      register_cop :BinaryOperatorWithIdenticalOperands, "#{__dir__}/lint/binary_operator_with_identical_operands"
+      register_cop :BooleanSymbol, "#{__dir__}/lint/boolean_symbol"
+      register_cop :CircularArgumentReference, "#{__dir__}/lint/circular_argument_reference"
+      register_cop :ConstantDefinitionInBlock, "#{__dir__}/lint/constant_definition_in_block"
+      register_cop :ConstantOverwrittenInRescue, "#{__dir__}/lint/constant_overwritten_in_rescue"
+      register_cop :ConstantReassignment, "#{__dir__}/lint/constant_reassignment"
+      register_cop :ConstantResolution, "#{__dir__}/lint/constant_resolution"
+      register_cop :CopDirectiveSyntax, "#{__dir__}/lint/cop_directive_syntax"
+      register_cop :DataDefineOverride, "#{__dir__}/lint/data_define_override"
+      register_cop :Debugger, "#{__dir__}/lint/debugger"
+      register_cop :DeprecatedClassMethods, "#{__dir__}/lint/deprecated_class_methods"
+      register_cop :DeprecatedConstants, "#{__dir__}/lint/deprecated_constants"
+      register_cop :DeprecatedOpenSSLConstant, "#{__dir__}/lint/deprecated_open_ssl_constant"
+      register_cop :DeprecatedReference, "#{__dir__}/lint/deprecated_reference"
+      register_cop :DisjunctiveAssignmentInConstructor, "#{__dir__}/lint/disjunctive_assignment_in_constructor"
+      register_cop :DuplicateBranch, "#{__dir__}/lint/duplicate_branch"
+      register_cop :DuplicateCaseCondition, "#{__dir__}/lint/duplicate_case_condition"
+      register_cop :DuplicateElsifCondition, "#{__dir__}/lint/duplicate_elsif_condition"
+      register_cop :DuplicateHashKey, "#{__dir__}/lint/duplicate_hash_key"
+      register_cop :DuplicateMagicComment, "#{__dir__}/lint/duplicate_magic_comment"
+      register_cop :DuplicateMatchPattern, "#{__dir__}/lint/duplicate_match_pattern"
+      register_cop :DuplicateMethods, "#{__dir__}/lint/duplicate_methods"
+      register_cop :DuplicateRegexpCharacterClassElement, "#{__dir__}/lint/duplicate_regexp_character_class_element"
+      register_cop :DuplicateRequire, "#{__dir__}/lint/duplicate_require"
+      register_cop :DuplicateRescueException, "#{__dir__}/lint/duplicate_rescue_exception"
+      register_cop :DuplicateSetElement, "#{__dir__}/lint/duplicate_set_element"
+      register_cop :EachWithObjectArgument, "#{__dir__}/lint/each_with_object_argument"
+      register_cop :ElseLayout, "#{__dir__}/lint/else_layout"
+      register_cop :EmptyBlock, "#{__dir__}/lint/empty_block"
+      register_cop :EmptyClass, "#{__dir__}/lint/empty_class"
+      register_cop :EmptyConditionalBody, "#{__dir__}/lint/empty_conditional_body"
+      register_cop :EmptyEnsure, "#{__dir__}/lint/empty_ensure"
+      register_cop :EmptyExpression, "#{__dir__}/lint/empty_expression"
+      register_cop :EmptyFile, "#{__dir__}/lint/empty_file"
+      register_cop :EmptyInPattern, "#{__dir__}/lint/empty_in_pattern"
+      register_cop :EmptyInterpolation, "#{__dir__}/lint/empty_interpolation"
+      register_cop :EmptyWhen, "#{__dir__}/lint/empty_when"
+      register_cop :EnsureReturn, "#{__dir__}/lint/ensure_return"
+      register_cop :SharedMutableDefault, "#{__dir__}/lint/shared_mutable_default"
+      register_cop :ErbNewArguments, "#{__dir__}/lint/erb_new_arguments"
+      register_cop :FlipFlop, "#{__dir__}/lint/flip_flop"
+      register_cop :FloatComparison, "#{__dir__}/lint/float_comparison"
+      register_cop :FloatOutOfRange, "#{__dir__}/lint/float_out_of_range"
+      register_cop :FormatParameterMismatch, "#{__dir__}/lint/format_parameter_mismatch"
+      register_cop :HashCompareByIdentity, "#{__dir__}/lint/hash_compare_by_identity"
+      register_cop :HashNewWithKeywordArgumentsAsDefault, "#{__dir__}/lint/hash_new_with_keyword_arguments_as_default"
+      register_cop :HeredocMethodCallPosition, "#{__dir__}/lint/heredoc_method_call_position"
+      register_cop :IdentityComparison, "#{__dir__}/lint/identity_comparison"
+      register_cop :ImplicitStringConcatenation, "#{__dir__}/lint/implicit_string_concatenation"
+      register_cop :IncompatibleIoSelectWithFiberScheduler, "#{__dir__}/lint/incompatible_io_select_with_fiber_scheduler"
+      register_cop :IneffectiveAccessModifier, "#{__dir__}/lint/ineffective_access_modifier"
+      register_cop :InheritException, "#{__dir__}/lint/inherit_exception"
+      register_cop :InterpolationCheck, "#{__dir__}/lint/interpolation_check"
+      register_cop :ItWithoutArgumentsInBlock, "#{__dir__}/lint/it_without_arguments_in_block"
+      register_cop :LambdaWithoutLiteralBlock, "#{__dir__}/lint/lambda_without_literal_block"
+      register_cop :LiteralAsCondition, "#{__dir__}/lint/literal_as_condition"
+      register_cop :LiteralAssignmentInCondition, "#{__dir__}/lint/literal_assignment_in_condition"
+      register_cop :LiteralInInterpolation, "#{__dir__}/lint/literal_in_interpolation"
+      register_cop :Loop, "#{__dir__}/lint/loop"
+      register_cop :MissingCopEnableDirective, "#{__dir__}/lint/missing_cop_enable_directive"
+      register_cop :MissingSuper, "#{__dir__}/lint/missing_super"
+      register_cop :MixedCaseRange, "#{__dir__}/lint/mixed_case_range"
+      register_cop :MixedRegexpCaptureTypes, "#{__dir__}/lint/mixed_regexp_capture_types"
+      register_cop :MultipleComparison, "#{__dir__}/lint/multiple_comparison"
+      register_cop :NameTypo, "#{__dir__}/lint/name_typo"
+      register_cop :NestedMethodDefinition, "#{__dir__}/lint/nested_method_definition"
+      register_cop :NestedPercentLiteral, "#{__dir__}/lint/nested_percent_literal"
+      register_cop :NextWithoutAccumulator, "#{__dir__}/lint/next_without_accumulator"
+      register_cop :NoReturnInBeginEndBlocks, "#{__dir__}/lint/no_return_in_begin_end_blocks"
+      register_cop :NonAtomicFileOperation, "#{__dir__}/lint/non_atomic_file_operation"
+      register_cop :NonDeterministicRequireOrder, "#{__dir__}/lint/non_deterministic_require_order"
+      register_cop :NonLocalExitFromIterator, "#{__dir__}/lint/non_local_exit_from_iterator"
+      register_cop :NumberConversion, "#{__dir__}/lint/number_conversion"
+      register_cop :NumberedParameterAssignment, "#{__dir__}/lint/numbered_parameter_assignment"
+      register_cop :NumericOperationWithConstantResult, "#{__dir__}/lint/numeric_operation_with_constant_result"
+      register_cop :OrAssignmentToConstant, "#{__dir__}/lint/or_assignment_to_constant"
+      register_cop :OrderedMagicComments, "#{__dir__}/lint/ordered_magic_comments"
+      register_cop :OutOfRangeRegexpRef, "#{__dir__}/lint/out_of_range_regexp_ref"
+      register_cop :ParenthesesAsGroupedExpression, "#{__dir__}/lint/parentheses_as_grouped_expression"
+      register_cop :PercentStringArray, "#{__dir__}/lint/percent_string_array"
+      register_cop :PercentSymbolArray, "#{__dir__}/lint/percent_symbol_array"
+      register_cop :RaiseException, "#{__dir__}/lint/raise_exception"
+      register_cop :RandOne, "#{__dir__}/lint/rand_one"
+      register_cop :RedundantCopDisableDirective, "#{__dir__}/lint/redundant_cop_disable_directive"
+      register_cop :RedundantCopEnableDirective, "#{__dir__}/lint/redundant_cop_enable_directive"
+      register_cop :RedundantDirGlobSort, "#{__dir__}/lint/redundant_dir_glob_sort"
+      register_cop :RedundantRegexpQuantifiers, "#{__dir__}/lint/redundant_regexp_quantifiers"
+      register_cop :RedundantRequireStatement, "#{__dir__}/lint/redundant_require_statement"
+      register_cop :RedundantSafeNavigation, "#{__dir__}/lint/redundant_safe_navigation"
+      register_cop :RedundantSplatExpansion, "#{__dir__}/lint/redundant_splat_expansion"
+      register_cop :RedundantStringCoercion, "#{__dir__}/lint/redundant_string_coercion"
+      register_cop :RedundantTypeConversion, "#{__dir__}/lint/redundant_type_conversion"
+      register_cop :RedundantWithIndex, "#{__dir__}/lint/redundant_with_index"
+      register_cop :RedundantWithObject, "#{__dir__}/lint/redundant_with_object"
+      register_cop :RefinementImportMethods, "#{__dir__}/lint/refinement_import_methods"
+      register_cop :RegexpAsCondition, "#{__dir__}/lint/regexp_as_condition"
+      register_cop :RequireParentheses, "#{__dir__}/lint/require_parentheses"
+      register_cop :RequireRangeParentheses, "#{__dir__}/lint/require_range_parentheses"
+      register_cop :RequireRelativeSelfPath, "#{__dir__}/lint/require_relative_self_path"
+      register_cop :RescueException, "#{__dir__}/lint/rescue_exception"
+      register_cop :RescueType, "#{__dir__}/lint/rescue_type"
+      register_cop :ReturnInVoidContext, "#{__dir__}/lint/return_in_void_context"
+      register_cop :SafeNavigationConsistency, "#{__dir__}/lint/safe_navigation_consistency"
+      register_cop :SafeNavigationChain, "#{__dir__}/lint/safe_navigation_chain"
+      register_cop :SafeNavigationWithEmpty, "#{__dir__}/lint/safe_navigation_with_empty"
+      register_cop :ScriptPermission, "#{__dir__}/lint/script_permission"
+      register_cop :SelfAssignment, "#{__dir__}/lint/self_assignment"
+      register_cop :SendWithMixinArgument, "#{__dir__}/lint/send_with_mixin_argument"
+      register_cop :ShadowedArgument, "#{__dir__}/lint/shadowed_argument"
+      register_cop :ShadowedException, "#{__dir__}/lint/shadowed_exception"
+      register_cop :ShadowingOuterLocalVariable, "#{__dir__}/lint/shadowing_outer_local_variable"
+      register_cop :StructNewOverride, "#{__dir__}/lint/struct_new_override"
+      register_cop :SuppressedException, "#{__dir__}/lint/suppressed_exception"
+      register_cop :SuppressedExceptionInNumberConversion, "#{__dir__}/lint/suppressed_exception_in_number_conversion"
+      register_cop :SymbolConversion, "#{__dir__}/lint/symbol_conversion"
+      register_cop :Syntax, "#{__dir__}/lint/syntax"
+      register_cop :ToEnumArguments, "#{__dir__}/lint/to_enum_arguments"
+      register_cop :ToJSON, "#{__dir__}/lint/to_json"
+      register_cop :TopLevelReturnWithArgument, "#{__dir__}/lint/top_level_return_with_argument"
+      register_cop :TrailingCommaInAttributeDeclaration, "#{__dir__}/lint/trailing_comma_in_attribute_declaration"
+      register_cop :TripleQuotes, "#{__dir__}/lint/triple_quotes"
+      register_cop :UnderscorePrefixedVariableName, "#{__dir__}/lint/underscore_prefixed_variable_name"
+      register_cop :UnescapedBracketInRegexp, "#{__dir__}/lint/unescaped_bracket_in_regexp"
+      register_cop :UnexpectedBlockArity, "#{__dir__}/lint/unexpected_block_arity"
+      register_cop :UnifiedInteger, "#{__dir__}/lint/unified_integer"
+      register_cop :UnmodifiedReduceAccumulator, "#{__dir__}/lint/unmodified_reduce_accumulator"
+      register_cop :UnreachableCode, "#{__dir__}/lint/unreachable_code"
+      register_cop :UnreachableLoop, "#{__dir__}/lint/unreachable_loop"
+      register_cop :UnreachablePatternBranch, "#{__dir__}/lint/unreachable_pattern_branch"
+      register_cop :UnusedBlockArgument, "#{__dir__}/lint/unused_block_argument"
+      register_cop :UnusedMethodArgument, "#{__dir__}/lint/unused_method_argument"
+      register_cop :UnusedPrivateMethod, "#{__dir__}/lint/unused_private_method"
+      register_cop :UriEscapeUnescape, "#{__dir__}/lint/uri_escape_unescape"
+      register_cop :UriRegexp, "#{__dir__}/lint/uri_regexp"
+      register_cop :UselessAccessModifier, "#{__dir__}/lint/useless_access_modifier"
+      register_cop :UselessAssignment, "#{__dir__}/lint/useless_assignment"
+      register_cop :UselessConstantScoping, "#{__dir__}/lint/useless_constant_scoping"
+      register_cop :UselessDefaultValueArgument, "#{__dir__}/lint/useless_default_value_argument"
+      register_cop :UselessDefined, "#{__dir__}/lint/useless_defined"
+      register_cop :UselessElseWithoutRescue, "#{__dir__}/lint/useless_else_without_rescue"
+      register_cop :UselessMethodDefinition, "#{__dir__}/lint/useless_method_definition"
+      register_cop :UselessNumericOperation, "#{__dir__}/lint/useless_numeric_operation"
+      register_cop :UselessOr, "#{__dir__}/lint/useless_or"
+      register_cop :UselessRescue, "#{__dir__}/lint/useless_rescue"
+      register_cop :UselessRuby2Keywords, "#{__dir__}/lint/useless_ruby2_keywords"
+      register_cop :UselessSetterCall, "#{__dir__}/lint/useless_setter_call"
+      register_cop :UselessTimes, "#{__dir__}/lint/useless_times"
+      register_cop :Void, "#{__dir__}/lint/void"
+
+      autoload :UnusedArgument, "#{__dir__}/mixin/unused_argument"
+
+      # Utility classes for `Lint` department cops.
+      module Utils
+        autoload :NilReceiverChecker, "#{__dir__}/lint/utils/nil_receiver_checker"
+      end
+    end
+  end
+end

data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb

@@ -189,7 +189,7 @@ module RuboCop
           def source_from_node_with_heredoc(node)
             last_line = -1
             node.each_descendant do |descendant|
-              next unless descendant.source
+              next if descendant.loc.nil? || descendant.source_range.nil?
 
               descendant_last_line =
                 if heredoc_node?(descendant)

data/lib/rubocop/cop/metrics.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Metrics` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Metrics
+      extend LazyLoader
+
+      register_cop :CyclomaticComplexity, "#{__dir__}/metrics/cyclomatic_complexity"
+      register_cop :AbcSize, "#{__dir__}/metrics/abc_size"
+      register_cop :BlockLength, "#{__dir__}/metrics/block_length"
+      register_cop :BlockNesting, "#{__dir__}/metrics/block_nesting"
+      register_cop :ClassLength, "#{__dir__}/metrics/class_length"
+      register_cop :CollectionLiteralLength, "#{__dir__}/metrics/collection_literal_length"
+      register_cop :MethodLength, "#{__dir__}/metrics/method_length"
+      register_cop :ModuleLength, "#{__dir__}/metrics/module_length"
+      register_cop :ParameterLists, "#{__dir__}/metrics/parameter_lists"
+      register_cop :PerceivedComplexity, "#{__dir__}/metrics/perceived_complexity"
+
+      # Utility classes for `Metrics` department cops.
+      module Utils
+        autoload :AbcSizeCalculator, "#{__dir__}/metrics/utils/abc_size_calculator"
+        autoload :CodeLengthCalculator, "#{__dir__}/metrics/utils/code_length_calculator"
+        autoload :IteratingBlock, "#{__dir__}/metrics/utils/iterating_block"
+        autoload :RepeatedAttributeDiscount, "#{__dir__}/metrics/utils/repeated_attribute_discount"
+        autoload :RepeatedCsendDiscount, "#{__dir__}/metrics/utils/repeated_csend_discount"
+      end
+    end
+  end
+end

data/lib/rubocop/cop/migration/department_name.rb

@@ -50,10 +50,6 @@ module RuboCop
 
         private
 
-        def disable_comment_offset
-          Regexp.last_match(1).length
-        end
-
         def check_cop_name(name, comment, offset)
           start = comment.source_range.begin_pos + offset
           range = range_between(start, start + name.length)

data/lib/rubocop/cop/migration.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Migration` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Migration
+      extend LazyLoader
+
+      register_cop :DepartmentName, "#{__dir__}/migration/department_name"
+    end
+  end
+end

data/lib/rubocop/cop/mixin/check_line_breakable.rb

@@ -61,11 +61,13 @@ module RuboCop
       # @api private
       def extract_breakable_node_from_elements(node, elements, max)
         return unless breakable_collection?(node, elements)
-        return if safe_to_ignore?(node)
 
+        # Check the cheap conditions first, `safe_to_ignore?` may traverse all elements of
+        # a containing collection.
         line = processed_source.lines[node.first_line - 1]
+        return if max && line.length <= max
         return if processed_source.line_with_comment?(node.loc.line)
-        return if line.length <= max
+        return if safe_to_ignore?(node)
 
         extract_first_element_over_column_limit(node, elements, max)
       end
@@ -173,20 +175,36 @@ module RuboCop
         node.each_ancestor.find do |ancestor|
           if ancestor.type?(:hash, :array) &&
              breakable_collection?(ancestor, ancestor.children)
-            return children_could_be_broken_up?(ancestor.children)
+            return children_could_be_broken_up?(ancestor, ancestor.children)
           end
 
           next unless ancestor.call_type?
 
           args = process_args(ancestor.arguments)
-          return children_could_be_broken_up?(args) if breakable_collection?(ancestor, args)
+          if breakable_collection?(ancestor, args)
+            return children_could_be_broken_up?(ancestor, args)
+          end
         end
 
         false
       end
 
       # @api private
-      def children_could_be_broken_up?(children)
+      # The result depends only on the given node, but the check may traverse all children of
+      # a large collection and is repeated for each contained element, so memoize it per node.
+      def children_could_be_broken_up?(node, children)
+        if @check_line_breakable_processed_source != processed_source
+          @check_line_breakable_processed_source = processed_source
+          @children_could_be_broken_up_cache = {}.compare_by_identity
+        end
+
+        @children_could_be_broken_up_cache.fetch(node) do
+          @children_could_be_broken_up_cache[node] = compute_children_could_be_broken_up?(children)
+        end
+      end
+
+      # @api private
+      def compute_children_could_be_broken_up?(children)
         return false if all_on_same_line?(children)
 
         last_seen_line = -1

data/lib/rubocop/cop/mixin/endless_method_rewriter.rb

@@ -5,20 +5,28 @@ module RuboCop
     # Common functionality for rewriting endless methods to normal method definitions
     module EndlessMethodRewriter
       def correct_to_multiline(corrector, node)
-        replacement = <<~RUBY.strip
-          def #{node.method_name}#{arguments(node)}
-            #{node.body.source}
-          end
-        RUBY
+        replacement = [
+          "def #{receiver(node)}#{node.method_name}#{arguments(node)}",
+          "#{indent(node, offset: configured_indentation_width)}#{node.body.source}",
+          "#{indent(node)}end"
+        ].join("\n")
 
         corrector.replace(node, replacement)
       end
 
       private
 
+      def receiver(node)
+        node.receiver ? "#{node.receiver.source}#{node.loc.operator.source}" : ''
+      end
+
       def arguments(node, missing = '')
         node.arguments.any? ? node.arguments.source : missing
       end
+
+      def configured_indentation_width
+        cop_config['IndentationWidth'] || config.for_cop('Layout/IndentationWidth')['Width'] || 2
+      end
     end
   end
 end

data/lib/rubocop/cop/mixin/hash_alignment_styles.rb

@@ -96,20 +96,37 @@ module RuboCop
         end
 
         def hash_rocket_delta(first_pair, current_pair)
-          first_pair.loc.column + max_key_width(first_pair.parent) + 1 -
-            current_pair.loc.operator.column
+          target_operator_column(first_pair) - current_pair.loc.operator.column
         end
 
         def value_delta(first_pair, current_pair)
-          correct_value_column = first_pair.key.loc.column +
-                                 max_key_width(first_pair.parent) +
-                                 max_delimiter_width(first_pair.parent)
+          correct_value_column = target_operator_column(first_pair) +
+                                 max_delimiter_width(first_pair.parent) - 1
 
           current_pair.value_omission? ? 0 : correct_value_column - current_pair.value.loc.column
         end
 
+        # The column the separator should land on: the shared key margin
+        # plus the widest single-line key, or, if larger, a multiline key's
+        # own last-line end column. The latter can't be measured from a
+        # multiline key's (newline-including) source length, so it's a
+        # separate candidate rather than folded into `max_key_width`.
+        def target_operator_column(first_pair)
+          hash_node = first_pair.parent
+          candidates = multiline_key_end_columns(hash_node)
+
+          key_width = max_key_width(hash_node)
+          candidates << (first_pair.loc.column + key_width + 1) if key_width.positive?
+
+          candidates.max
+        end
+
+        def multiline_key_end_columns(hash_node)
+          hash_node.keys.reject(&:single_line?).map { |key| key.source_range.end.column + 1 }
+        end
+
         def max_key_width(hash_node)
-          hash_node.keys.map { |key| key.source.length }.max
+          hash_node.keys.select(&:single_line?).map { |key| key.source.length }.max || 0
         end
 
         def max_delimiter_width(hash_node)

data/lib/rubocop/cop/mixin/project_index_help.rb

@@ -17,6 +17,14 @@ module RuboCop
       # remains after stripping `file://` from a `file:///C:/...` URI.
       WINDOWS_DRIVE_PREFIX = %r{\A/(?=[A-Za-z]:[/\\])}.freeze
 
+      class << self
+        # The signature is a property of the index, not of the cop, and computing
+        # it stats every indexed file, so all cops sharing an index share one
+        # computation. A single-entry cache (instead of a hash keyed by index)
+        # avoids retaining stale graphs in long-lived processes.
+        attr_accessor :cached_index_signature
+      end
+
       def external_dependency_checksum
         return nil unless project_index
 
@@ -27,7 +35,139 @@ module RuboCop
 
       private
 
+      # Returns the definitions among `definitions` that live in a file other than the
+      # one being inspected, ordered by path and line. Definitions without a `file://`
+      # URI (e.g. Rubydex's built-in declarations) are ignored.
+      def definitions_in_other_files(definitions)
+        current = processed_source.file_path
+
+        definitions
+          .select { |definition| definition.location.uri.start_with?(FILE_URI_PREFIX) }
+          .reject { |definition| File.identical?(definition.location.to_file_path, current) }
+          .sort_by do |definition|
+          [definition.location.to_file_path,
+           definition.location.start_line]
+        end
+      end
+
+      def prior_definition_in_other_file(definitions)
+        definitions_in_other_files(definitions).first
+      end
+
+      # Resolves a constant node the way Ruby does: the first segment through
+      # the lexical nesting and every following segment inside the previous
+      # one. (Qualified names cannot be passed to `resolve_constant` as a
+      # whole, since it only applies the nesting to the full name. Later
+      # segments use `find_member` — the namespace and its ancestors — since
+      # `resolve_constant` cannot take an already-resolved namespace as the
+      # scope, only names as they appear in source.)
+      def resolve_constant_in_index(const_node)
+        segments = const_node.const_name.split('::')
+        nesting = const_node.absolute? ? [] : lexical_nesting_of(const_node)
+
+        declaration = project_index.resolve_constant(segments.first, nesting)
+        segments.drop(1).each do |segment|
+          return nil unless declaration.is_a?(Rubydex::Namespace)
+
+          declaration = declaration.find_member(segment)
+        end
+
+        declaration
+      end
+
+      # The lexical nesting the node's constants resolve through, outermost
+      # first. Only scopes whose *body* contains the node count: a class or
+      # module's identifier and superclass expression are evaluated before its
+      # scope exists, so ancestors reached through them are excluded.
+      def lexical_nesting_of(node)
+        nesting = []
+        child = node
+
+        node.each_ancestor do |ancestor|
+          if ancestor.type?(:class, :module) && child.equal?(ancestor.body)
+            nesting << ancestor.identifier.const_name
+          end
+          child = ancestor
+        end
+
+        nesting.reverse
+      end
+
+      # The declaration of `declaration`'s singleton class, or nil when no
+      # singleton method is defined on it anywhere in the project.
+      def indexed_singleton_of(declaration)
+        project_index["#{declaration.name}::<#{declaration.name.split('::').last}>"]
+      end
+
+      # A namespace without any singleton method has no singleton-class
+      # declaration of its own, so the lookup starts from the first ancestor
+      # that has one; its `find_member` covers the rest of the chain.
+      def indexed_singleton_member(namespace, member_name)
+        namespace.ancestors.each do |ancestor|
+          singleton = indexed_singleton_of(ancestor)
+          return singleton.find_member(member_name) if singleton
+        end
+
+        nil
+      end
+
+      # Whether an ancestor of `scope` other than `scope` itself defines
+      # `member_name`.
+      def inherited_index_member?(scope, member_name)
+        scope.ancestors.any? do |ancestor|
+          ancestor.name != scope.name && ancestor.member(member_name)
+        end
+      end
+
+      # Whether every link of the declaration's ancestry is resolved in the
+      # index: no definition of any ancestor has an unresolved superclass or
+      # mixin reference. Unresolved links silently vanish from `ancestors`,
+      # so this is the completeness check that must pass before reasoning
+      # about what an ancestry does or does not define. `extend` mixins only
+      # affect the singleton class; pass `ignore_extend: true` when reasoning
+      # about instance-side ancestry only.
+      def fully_resolved_index_ancestry?(declaration, ignore_extend: false)
+        declaration.ancestors.all? do |ancestor|
+          ancestor.definitions.all? do |definition|
+            resolved_superclass_reference?(definition) &&
+              resolved_mixin_references?(definition, ignore_extend: ignore_extend)
+          end
+        end
+      end
+
+      def resolved_superclass_reference?(definition)
+        return true unless definition.is_a?(Rubydex::ClassDefinition)
+
+        !definition.superclass.is_a?(Rubydex::UnresolvedConstantReference)
+      end
+
+      def resolved_mixin_references?(definition, ignore_extend: false)
+        return true unless definition.respond_to?(:mixins)
+
+        definition.mixins.none? do |mixin|
+          next false if ignore_extend && mixin.is_a?(Rubydex::Extend)
+
+          mixin.constant_reference.is_a?(Rubydex::UnresolvedConstantReference)
+        end
+      end
+
+      def same_file?(path, other)
+        return true if File.identical?(path, other)
+
+        normalized = [path, other].map { |p| File.expand_path(p).tr('\\', '/') }
+        normalized.uniq.one? || (Platform.windows? && normalized[0].casecmp?(normalized[1]))
+      end
+
       def project_index_signature
+        index, signature = ProjectIndexHelp.cached_index_signature
+        return signature if index.equal?(project_index)
+
+        compute_project_index_signature.tap do |computed|
+          ProjectIndexHelp.cached_index_signature = [project_index, computed]
+        end
+      end
+
+      def compute_project_index_signature
         project_index.documents.filter_map do |doc|
           uri = doc.uri
           next if uri == BUILTIN_DOCUMENT_URI