rubocop 0.55.0 → 0.56.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b6193bafb35931ae47f1a4d40c8b9919f4f8df07
-  data.tar.gz: 8b4c066f46a71fe4d35d84d0b1063f22130e2b4d
+  metadata.gz: fb9916f20b5502d5f82b3dda566fc49d305b165e
+  data.tar.gz: 0eb589fa94973ba3c4d06e147312982cb8cfe35c
 SHA512:
-  metadata.gz: a619c39a295a5cfdc1a2d82a51391f8d995ea04e20a865eba6951056f57766be7df10718194782f715750f0d9007c6ee730688289acd277c371fc408e137c065
-  data.tar.gz: 3ad640cddf0bedeaa238e9e13beef2da09f156c1bc957784c2779cc65076a7f142e0b85c113a6221e7792e491db4ebabeafea4c7424a92750523ddd55ecb4128
+  metadata.gz: 60768e70eb0d1066092c6d45b22be8d1f5bb154c5996296a32e48ba8aec05514bad6e5492d97849b70f0b357f99050237503a0da1ef33afdfb56c76e7f493126
+  data.tar.gz: 3d62fe67836732767da27fb00ab203103050466fd1064295a71109892ba10741ceaeea6f82a19c7866df6d77dbcec7af7d8cfe52bce3800457f5107f1d4ac3bb

data/README.md

@@ -52,7 +52,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version locking in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.55.0', require: false
+gem 'rubocop', '~> 0.56.0', require: false
 ```
 
 ## Quickstart

data/config/default.yml

@@ -7,8 +7,15 @@ inherit_from:
 
 # Common configuration.
 AllCops:
+  RubyInterpreters:
+    - ruby
+    - macruby
+    - rake
+    - jruby
+    - rbx
   # Include common Ruby source files.
   Include:
+    - '**/*.rb'
     - '**/*.arb'
     - '**/*.axlsx'
     - '**/*.builder'
@@ -361,6 +368,9 @@ Layout/FirstParameterIndentation:
     # The first parameter should always be indented one step more than the
     # preceding line.
     - consistent
+    # The first parameter should always be indented one level relative to the
+    # parent that is receiving the parameter
+    - consistent_relative_to_receiver
     # The first parameter should normally be indented one step more than the
     # preceding line, but if it's a parameter for a method call that is itself
     # a parameter in a method call, then the inner parameter should be indented
@@ -1258,6 +1268,7 @@ Style/OptionHash:
 # Allow safe assignment in conditions.
 Style/ParenthesesAroundCondition:
   AllowSafeAssignment: true
+  AllowInMultilineConditions: false
 
 Style/PercentLiteralDelimiters:
   # Specify the default preferred delimiter for all types with the 'default' key
@@ -1330,6 +1341,7 @@ Style/SafeNavigation:
     - blank?
     - presence
     - try
+    - try!
 
 Style/Semicolon:
   # Allow `;` to separate several expressions on the same line.
@@ -1596,6 +1608,15 @@ Lint/SafeNavigationChain:
     - blank?
     - presence
     - try
+    - try!
+
+Lint/SafeNavigationConsistency:
+  Whitelist:
+    - present?
+    - blank?
+    - presence
+    - try
+    - try!
 
 # Checks for shadowed arguments
 Lint/ShadowedArgument:
@@ -1635,6 +1656,18 @@ Rails/ActionFilter:
   Include:
     - app/controllers/**/*.rb
 
+Rails/AssertNot:
+  Include:
+    - '**/test/**/*'
+
+Rails/Blank:
+  # Convert usages of `nil? || empty?` to `blank?`
+  NilOrEmpty: true
+  # Convert usages of `!present?` to `blank?`
+  NotPresent: true
+  # Convert usages of `unless present?` to `if blank?`
+  UnlessPresent: true
+
 Rails/CreateTableWithTimestamps:
   Include:
     - db/migrate/*.rb
@@ -1713,10 +1746,22 @@ Rails/Output:
     - db/**/*.rb
     - lib/**/*.rb
 
+Rails/Present:
+  # Convert usages of `!nil? && !empty?` to `present?`
+  NotNilAndNotEmpty: true
+  # Convert usages of `!blank?` to `present?`
+  NotBlank: true
+  # Convert usages of `unless blank?` to `if present?`
+  UnlessBlank: true
+
 Rails/ReadWriteAttribute:
   Include:
     - app/models/**/*.rb
 
+Rails/RefuteMethods:
+  Include:
+    - '**/test/**/*'
+
 Rails/RequestReferer:
   EnforcedStyle: referer
   SupportedStyles:

data/config/disabled.yml

@@ -5,6 +5,10 @@ Layout/ClassStructure:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#consistent-classes'
   Enabled: false
 
+Layout/EmptyLineAfterGuardClause:
+  Description: 'Add empty line after guard clause.'
+  Enabled: false
+
 Layout/FirstArrayElementLineBreak:
   Description: >-
                  Checks for a line break before the first element in a
@@ -68,10 +72,6 @@ Style/DocumentationMethod:
     - 'spec/**/*'
     - 'test/**/*'
 
-Style/EmptyLineAfterGuardClause:
-  Description: 'Add empty line after guard clause.'
-  Enabled: false
-
 Style/ImplicitRuntimeError:
   Description: >-
                  Use `raise` or `fail` with an explicit exception class and

data/config/enabled.yml

@@ -513,6 +513,10 @@ Lint/EnsureReturn:
   StyleGuide: '#no-return-ensure'
   Enabled: true
 
+Lint/ErbNewArguments:
+  Description: 'Use `:trim_mode` and `:eoutvar` keyword arguments to `ERB.new`.'
+  Enabled: true
+
 Lint/FloatOutOfRange:
   Description: >-
                  Catches floating-point literals too large or small for Ruby to
@@ -681,6 +685,10 @@ Lint/ShadowingOuterLocalVariable:
                  for block arguments or block local variables.
   Enabled: true
 
+Lint/SplatKeywordArguments:
+  Description: 'Checks for use of splat keyword arguments as a single Hash.'
+  Enabled: true
+
 Lint/StringConversionInInterpolation:
   Description: 'Checks for Object#to_s usage in string interpolation.'
   StyleGuide: '#no-to-s'
@@ -983,6 +991,11 @@ Performance/FlatMap:
   # This can be dangerous since `flat_map` will only flatten 1 level, and
   # `flatten` without any parameters can flatten multiple levels.
 
+Performance/InefficientHashSearch:
+  Description: 'Use `key?` or `value?` instead of `keys.include?` or `values.include?`'
+  Reference: 'https://github.com/JuanitoFatas/fast-ruby#hashkey-instead-of-hashkeysinclude-code'
+  Enabled: true
+
 Performance/LstripRstrip:
   Description: 'Use `strip` instead of `lstrip.rstrip`.'
   Enabled: true
@@ -1101,15 +1114,13 @@ Rails/ApplicationRecord:
   Description: 'Check that models subclass ApplicationRecord.'
   Enabled: true
 
+Rails/AssertNot:
+  Description: 'Use `assert_not` instead of `assert !`.'
+  Enabled: true
+
 Rails/Blank:
-  Description: 'Enforce using `blank?` and `present?`.'
+  Description: 'Enforces use of `blank?`.'
   Enabled: true
-  # Convert checks for `nil` or `empty?` to `blank?`
-  NilOrEmpty: true
-  # Convert usages of not `present?` to `blank?`
-  NotPresent: true
-  # Convert usages of `unless` `present?` to `if` `blank?`
-  UnlessPresent: true
 
 Rails/CreateTableWithTimestamps:
   Description: >-
@@ -1216,14 +1227,8 @@ Rails/Presence:
   Enabled: true
 
 Rails/Present:
-  Description: 'Enforce using `blank?` and `present?`.'
+  Description: 'Enforces use of `present?`.'
   Enabled: true
-  NotNilAndNotEmpty: true
-  # Convert checks for not `nil` and not `empty?` to `present?`
-  NotBlank: true
-  # Convert usages of not `blank?` to `present?`
-  UnlessBlank: true
-  # Convert usages of `unless` `blank?` to `if` `present?`
 
 Rails/ReadWriteAttribute:
   Description: >-
@@ -1236,6 +1241,10 @@ Rails/RedundantReceiverInWithOptions:
   Description: 'Checks for redundant receiver in `with_options`.'
   Enabled: true
 
+Rails/RefuteMethods:
+  Description: 'Use `assert_not` methods instead of `refute` methods.'
+  Enabled: true
+
 Rails/RelativeDateConstant:
   Description: 'Do not assign relative date to constants.'
   Enabled: true
@@ -1636,8 +1645,8 @@ Style/MethodDefParentheses:
   StyleGuide: '#method-parens'
   Enabled: true
 
-Style/MethodMissing:
-  Description: 'Avoid using `method_missing`.'
+Style/MethodMissingSuper:
+  Description: Checks for `method_missing` to call `super`.
   StyleGuide: '#no-method-missing'
   Enabled: true
 
@@ -1647,6 +1656,13 @@ Style/MinMax:
                  and `Enumerable#max` in conjunction.'
   Enabled: true
 
+Style/MissingRespondToMissing:
+  Description: >-
+                  Checks if `method_missing` is implemented
+                  without implementing `respond_to_missing`.
+  StyleGuide: '#no-method-missing'
+  Enabled: true
+
 Style/MixinGrouping:
   Description: 'Checks for grouping of mixins in `class` and `module` bodies.'
   StyleGuide: '#mixin-grouping'

data/lib/rubocop.rb

@@ -180,6 +180,7 @@ require_relative 'rubocop/cop/layout/def_end_alignment'
 require_relative 'rubocop/cop/layout/dot_position'
 require_relative 'rubocop/cop/layout/else_alignment'
 require_relative 'rubocop/cop/layout/empty_comment'
+require_relative 'rubocop/cop/layout/empty_line_after_guard_clause'
 require_relative 'rubocop/cop/layout/empty_line_after_magic_comment'
 require_relative 'rubocop/cop/layout/empty_line_between_defs'
 require_relative 'rubocop/cop/layout/empty_lines_around_access_modifier'
@@ -264,6 +265,7 @@ require_relative 'rubocop/cop/lint/empty_interpolation'
 require_relative 'rubocop/cop/lint/empty_when'
 require_relative 'rubocop/cop/lint/end_in_method'
 require_relative 'rubocop/cop/lint/ensure_return'
+require_relative 'rubocop/cop/lint/erb_new_arguments'
 require_relative 'rubocop/cop/lint/float_out_of_range'
 require_relative 'rubocop/cop/lint/format_parameter_mismatch'
 require_relative 'rubocop/cop/lint/handle_exceptions'
@@ -299,6 +301,7 @@ require_relative 'rubocop/cop/lint/script_permission'
 require_relative 'rubocop/cop/lint/shadowed_argument'
 require_relative 'rubocop/cop/lint/shadowed_exception'
 require_relative 'rubocop/cop/lint/shadowing_outer_local_variable'
+require_relative 'rubocop/cop/lint/splat_keyword_arguments'
 require_relative 'rubocop/cop/lint/string_conversion_in_interpolation'
 require_relative 'rubocop/cop/lint/syntax'
 require_relative 'rubocop/cop/lint/underscore_prefixed_variable_name'
@@ -356,6 +359,7 @@ require_relative 'rubocop/cop/performance/double_start_end_with'
 require_relative 'rubocop/cop/performance/end_with'
 require_relative 'rubocop/cop/performance/fixed_size'
 require_relative 'rubocop/cop/performance/flat_map'
+require_relative 'rubocop/cop/performance/inefficient_hash_search'
 require_relative 'rubocop/cop/performance/lstrip_rstrip'
 require_relative 'rubocop/cop/performance/range_include'
 require_relative 'rubocop/cop/performance/redundant_block_call'
@@ -411,7 +415,6 @@ require_relative 'rubocop/cop/style/empty_block_parameter'
 require_relative 'rubocop/cop/style/empty_case_condition'
 require_relative 'rubocop/cop/style/empty_else'
 require_relative 'rubocop/cop/style/empty_lambda_parameter'
-require_relative 'rubocop/cop/style/empty_line_after_guard_clause'
 require_relative 'rubocop/cop/style/empty_literal'
 require_relative 'rubocop/cop/style/empty_method'
 require_relative 'rubocop/cop/style/encoding'
@@ -443,9 +446,10 @@ require_relative 'rubocop/cop/style/method_call_without_args_parentheses'
 require_relative 'rubocop/cop/style/method_call_with_args_parentheses'
 require_relative 'rubocop/cop/style/method_called_on_do_end_block'
 require_relative 'rubocop/cop/style/method_def_parentheses'
-require_relative 'rubocop/cop/style/method_missing'
+require_relative 'rubocop/cop/style/method_missing_super'
 require_relative 'rubocop/cop/style/min_max'
 require_relative 'rubocop/cop/style/missing_else'
+require_relative 'rubocop/cop/style/missing_respond_to_missing'
 require_relative 'rubocop/cop/style/mixin_grouping'
 require_relative 'rubocop/cop/style/mixin_usage'
 require_relative 'rubocop/cop/style/module_function'
@@ -538,6 +542,7 @@ require_relative 'rubocop/cop/rails/active_record_aliases'
 require_relative 'rubocop/cop/rails/active_support_aliases'
 require_relative 'rubocop/cop/rails/application_job'
 require_relative 'rubocop/cop/rails/application_record'
+require_relative 'rubocop/cop/rails/assert_not'
 require_relative 'rubocop/cop/rails/blank'
 require_relative 'rubocop/cop/rails/create_table_with_timestamps'
 require_relative 'rubocop/cop/rails/date'
@@ -564,6 +569,7 @@ require_relative 'rubocop/cop/rails/presence'
 require_relative 'rubocop/cop/rails/present'
 require_relative 'rubocop/cop/rails/read_write_attribute'
 require_relative 'rubocop/cop/rails/redundant_receiver_in_with_options'
+require_relative 'rubocop/cop/rails/refute_methods'
 require_relative 'rubocop/cop/rails/request_referer'
 require_relative 'rubocop/cop/rails/reversible_migration'
 require_relative 'rubocop/cop/rails/relative_date_constant'

data/lib/rubocop/cli.rb

@@ -50,6 +50,10 @@ module RuboCop
     rescue IncorrectCopNameError => e
       warn e.message
       STATUS_ERROR
+    rescue OptionParser::InvalidOption => e
+      warn e.message
+      warn 'For usage information, use --help'
+      STATUS_ERROR
     rescue StandardError, SyntaxError, LoadError => e
       warn e.message
       warn e.backtrace

data/lib/rubocop/comment_config.rb

@@ -43,17 +43,14 @@ module RuboCop
     def extra_enabled_comments_with_names(extras, names)
       each_directive do |comment, cop_names, disabled|
         next unless comment_only_line?(comment.loc.expression.line)
-        cop_names.each do |name|
-          names[name] ||= 0
-          if disabled
-            names[name] += 1
-          elsif names[name] > 0
-            names[name] -= 1
-          else
-            extras << [comment, name]
-          end
+
+        if !disabled && enable_all?(comment)
+          handle_enable_all(names, extras, comment)
+        else
+          handle_switch(cop_names, names, disabled, extras, comment)
         end
       end
+
       extras
     end
 
@@ -169,5 +166,35 @@ module RuboCop
         non_comment_tokens.map(&:line).uniq
       end
     end
+
+    def enable_all?(comment)
+      _, cops = comment.text.match(COMMENT_DIRECTIVE_REGEXP).captures
+      cops == 'all'
+    end
+
+    def handle_enable_all(names, extras, comment)
+      enabled_cops = 0
+      names.each do |name, counter|
+        next unless counter > 0
+
+        names[name] -= 1
+        enabled_cops += 1
+      end
+
+      extras << [comment, 'all'] if enabled_cops.zero?
+    end
+
+    def handle_switch(cop_names, names, disabled, extras, comment)
+      cop_names.each do |name|
+        names[name] ||= 0
+        if disabled
+          names[name] += 1
+        elsif names[name] > 0
+          names[name] -= 1
+        else
+          extras << [comment, name]
+        end
+      end
+    end
   end
 end

data/lib/rubocop/config.rb

@@ -108,7 +108,10 @@ module RuboCop
       'Performance/HashEachMethods' =>
         'The `Performance/HashEachMethods` cop has been removed ' \
           'since it no longer provides performance benefits in ' \
-          'modern rubies.'
+          'modern rubies.',
+      'Style/MethodMissing' =>
+        'The `Style/MethodMissing` cop has been split into ' \
+          '`Style/MethodMissingSuper` and `Style/MissingRespondToMissing`.'
     }.freeze
 
     OBSOLETE_PARAMETERS = [
@@ -288,6 +291,10 @@ module RuboCop
       @to_s ||= @hash.to_s
     end
 
+    def signature
+      @signature ||= Digest::MD5.hexdigest(to_s)
+    end
+
     def make_excludes_absolute
       each_key do |key|
         validate_section_presence(key)

data/lib/rubocop/cop/generator.rb

@@ -98,8 +98,9 @@ module RuboCop
         end
       SPEC
 
-      def initialize(name, output: $stdout)
+      def initialize(name, github_user, output: $stdout)
         @badge = Badge.parse(name)
+        @github_user = github_user
         @output = output
         return if badge.qualified?
 
@@ -145,7 +146,7 @@ module RuboCop
         <<-TODO.strip_indent
           Do 3 steps:
             1. Add an entry to the "New features" section in CHANGELOG.md,
-               e.g. "Add new `#{badge}` cop. ([@your_id][])"
+               e.g. "Add new `#{badge}` cop. ([@#{github_user}][])"
             2. Modify the description of #{badge} in config/enabled.yml
             3. Implement your new cop in the generated file!
         TODO
@@ -153,7 +154,7 @@ module RuboCop
 
       private
 
-      attr_reader :badge, :output
+      attr_reader :badge, :github_user, :output
 
       def write_unless_file_exists(path, contents)
         if File.exist?(path)

data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb

@@ -9,28 +9,70 @@ module RuboCop
       #
       # @example
       #
-      #   # good: when x is on its own line, indent this way
-      #   func(
-      #     x,
-      #     y
-      #   )
+      #   # bad
+      #   some_method(
+      #     a,
+      #     b
+      #     )
+      #
+      #   some_method(
+      #     a, b
+      #     )
       #
-      #   # good: when x follows opening parenthesis, align parentheses
-      #   a = b * (x +
-      #            y
-      #           )
+      #   some_method(a, b, c
+      #     )
       #
-      #   # bad
-      #   def func(
-      #     x,
-      #     y
+      #   some_method(a,
+      #               b,
+      #               c
+      #     )
+      #
+      #   some_method(a,
+      #     x: 1,
+      #     y: 2
       #     )
-      #   end
+      #
+      #   # Scenario 1: When First Parameter Is On Its Own Line
+      #
+      #   # good: when first param is on a new line, right paren is *always*
+      #   #       outdented by IndentationWidth
+      #   some_method(
+      #     a,
+      #     b
+      #   )
+      #
+      #   # good
+      #   some_method(
+      #     a, b
+      #   )
+      #
+      #   # Scenario 2: When First Parameter Is On The Same Line
+      #
+      #   # good: when all other params are also on the same line, outdent
+      #   #       right paren by IndentationWidth
+      #   some_method(a, b, c
+      #              )
+      #
+      #   # good: when all other params are on multiple lines, but are lined
+      #   #       up, align right paren with left paren
+      #   some_method(a,
+      #               b,
+      #               c
+      #              )
+      #
+      #   # good: when other params are not lined up on multiple lines, outdent
+      #   #       right paren by IndentationWidth
+      #   some_method(a,
+      #     x: 1,
+      #     y: 2
+      #   )
+      #
+      #
       class ClosingParenthesisIndentation < Cop
         include Alignment
 
-        MSG_INDENT =
-          'Indent `)` the same as the start of the line where `(` is.'.freeze
+        MSG_INDENT = 'Indent `)` to column %<expected>d (not %<actual>d)'
+                     .freeze
         MSG_ALIGN = 'Align `)` with `(`.'.freeze
 
         def on_send(node)
@@ -53,35 +95,65 @@ module RuboCop
         private
 
         def check(node, elements)
+          left_paren  = node.loc.begin
           right_paren = node.loc.end
 
           return unless right_paren && begins_its_line?(right_paren)
 
-          correct_column = expected_column(node, elements)
+          correct_column = expected_column(left_paren, elements)
+
           @column_delta = correct_column - right_paren.column
 
           return if @column_delta.zero?
 
-          left_paren = node.loc.begin
-          msg = correct_column == left_paren.column ? MSG_ALIGN : MSG_INDENT
+          add_offense(right_paren,
+                      location: right_paren,
+                      message:  message(correct_column,
+                                        left_paren,
+                                        right_paren))
+        end
 
-          add_offense(right_paren, location: right_paren, message: msg)
+        def expected_column(left_paren, elements)
+          if !line_break_after_left_paren?(left_paren, elements) &&
+             all_elements_aligned?(elements)
+            left_paren.column
+          else
+            source_indent = processed_source
+                            .line_indentation(last_argument_line(elements))
+            new_indent    = source_indent - indentation_width
+
+            new_indent < 0 ? 0 : new_indent
+          end
         end
 
-        def expected_column(node, elements)
-          left_paren = node.loc.begin
+        def all_elements_aligned?(elements)
+          elements
+            .map { |e| e.loc.column }
+            .uniq
+            .count == 1
+        end
 
-          if node.send_type? && fixed_parameter_indentation? ||
-             line_break_after_left_paren?(left_paren, elements)
-            left_paren.source_line =~ /\S/
+        def last_argument_line(elements)
+          elements
+            .last
+            .loc
+            .first_line
+        end
+
+        def message(correct_column, left_paren, right_paren)
+          if correct_column == left_paren.column
+            MSG_ALIGN
           else
-            left_paren.column
+            format(
+              MSG_INDENT,
+              expected: correct_column,
+              actual: right_paren.column
+            )
           end
         end
 
-        def fixed_parameter_indentation?
-          config.for_cop('Layout/AlignParameters')['EnforcedStyle'] ==
-            'with_fixed_indentation'
+        def indentation_width
+          @config.for_cop('IndentationWidth')['Width'] || 2
         end
 
         def line_break_after_left_paren?(left_paren, elements)