rubocop 0.55.0 → 0.56.0

data/lib/rubocop/result_cache.rb

@@ -7,7 +7,7 @@ require 'etc'
 module RuboCop
   # Provides functionality for caching rubocop runs.
   class ResultCache
-    NON_CHANGING = %i[color format formatters out debug fail_level
+    NON_CHANGING = %i[color format formatters out debug fail_level auto_correct
                       cache fail_fast stdin parallel].freeze
 
     # Remove old files so that the cache doesn't grow too big. When the
@@ -84,6 +84,7 @@ module RuboCop
                         relevant_options_digest(options),
                         file_checksum(file, config_store))
       @cached_data = CachedData.new(file)
+      @pwd = Dir.pwd
     end
 
     def valid?
@@ -132,9 +133,13 @@ module RuboCop
     end
 
     def file_checksum(file, config_store)
-      Digest::MD5.hexdigest(Dir.pwd + file + IO.binread(file) +
-                            File.stat(file).mode.to_s +
-                            config_store.for(file).to_s)
+      digester = Digest::MD5.new
+      mode = File.stat(file).mode
+      digester.update(
+        "#{@pwd}#{file}#{mode}#{config_store.for(file).signature}"
+      )
+      digester.file(file)
+      digester.hexdigest
     rescue Errno::ENOENT
       # Spurious files that come and go should not cause a crash, at least not
       # here.

data/lib/rubocop/rspec/shared_contexts.rb

@@ -79,6 +79,10 @@ shared_context 'ruby 2.5', :ruby25 do
   let(:ruby_version) { 2.5 }
 end
 
+shared_context 'ruby 2.6', :ruby26 do
+  let(:ruby_version) { 2.6 }
+end
+
 shared_context 'with Rails', :enabled_rails do
   let(:enabled_rails) { true }
 end

data/lib/rubocop/runner.rb

@@ -117,7 +117,15 @@ module RuboCop
       cache = ResultCache.new(file, @options, @config_store) if cached_run?
       if cache && cache.valid?
         offenses = cache.load
+        # If we're running --auto-correct and the cache says there are
+        # offenses, we need to actually inspect the file. If the cache shows no
+        # offenses, we're good.
+        real_run_needed = @options[:auto_correct] && offenses.any?
       else
+        real_run_needed = true
+      end
+
+      if real_run_needed
         offenses = yield
         save_in_cache(cache, offenses)
       end
@@ -176,8 +184,6 @@ module RuboCop
         # cops related to calculating the Max parameters for Metrics cops. We
         # need to do that processing and can not use caching.
         !@options[:auto_gen_config] &&
-        # Auto-correction needs a full run. It can not use cached results.
-        !@options[:auto_correct] &&
         # We can't cache results from code which is piped in to stdin
         !@options[:stdin]
     end

data/lib/rubocop/target_finder.rb

@@ -3,61 +3,6 @@
 require 'set'
 
 module RuboCop
-  RUBY_EXTENSIONS = %w[.rb
-                       .arb
-                       .axlsx
-                       .builder
-                       .fcgi
-                       .gemfile
-                       .gemspec
-                       .god
-                       .jb
-                       .jbuilder
-                       .mspec
-                       .opal
-                       .pluginspec
-                       .podspec
-                       .rabl
-                       .rake
-                       .rbuild
-                       .rbw
-                       .rbx
-                       .ru
-                       .ruby
-                       .spec
-                       .thor
-                       .watchr].freeze
-
-  RUBY_INTERPRETERS = %w[ruby
-                         macruby
-                         rake
-                         jruby
-                         rbx].freeze
-
-  RUBY_FILENAMES = %w[.irbrc
-                      .pryrc
-                      Appraisals
-                      Berksfile
-                      Brewfile
-                      Buildfile
-                      Capfile
-                      Cheffile
-                      Dangerfile
-                      Deliverfile
-                      Fastfile
-                      Gemfile
-                      Guardfile
-                      Jarfile
-                      Mavenfile
-                      Podfile
-                      Puppetfile
-                      Rakefile
-                      Snapfile
-                      Thorfile
-                      Vagabondfile
-                      Vagrantfile
-                      buildfile].freeze
-
   # This class finds target files to inspect by scanning the directory tree
   # and picking ruby files.
   class TargetFinder
@@ -169,30 +114,65 @@ module RuboCop
     end
 
     def ruby_extension?(file)
-      RUBY_EXTENSIONS.include?(File.extname(file))
+      ruby_extensions.include?(File.extname(file))
+    end
+
+    def ruby_extensions
+      ext_patterns = all_cops_include.select do |pattern|
+        pattern.start_with?('**/*.')
+      end
+      ext_patterns.map { |pattern| pattern.sub('**/*', '') }
     end
 
     def ruby_filename?(file)
-      RUBY_FILENAMES.include?(File.basename(file))
+      ruby_filenames.include?(File.basename(file))
+    end
+
+    def ruby_filenames
+      file_patterns = all_cops_include.reject do |pattern|
+        pattern.start_with?('**/*.')
+      end
+      file_patterns.map { |pattern| pattern.sub('**/', '') }
+    end
+
+    def all_cops_include
+      @config_store.for('.').for_all_cops['Include'].map(&:to_s)
     end
 
     def ruby_executable?(file)
       return false unless File.extname(file).empty? && File.exist?(file)
       first_line = File.open(file, &:readline)
-      !(first_line =~ /#!.*(#{RUBY_INTERPRETERS.join('|')})/).nil?
+      !(first_line =~ /#!.*(#{ruby_interpreters(file).join('|')})/).nil?
     rescue EOFError, ArgumentError => e
       warn "Unprocessable file #{file}: #{e.class}, #{e.message}" if debug?
       false
     end
 
+    def ruby_interpreters(file)
+      @config_store.for(file).for_all_cops['RubyInterpreters']
+    end
+
+    def stdin?
+      @options.key?(:stdin)
+    end
+
     def ruby_file?(file)
-      ruby_extension?(file) || ruby_filename?(file) || ruby_executable?(file)
+      stdin? || ruby_extension?(file) || ruby_filename?(file) ||
+        ruby_executable?(file)
+    end
+
+    def configured_include?(file)
+      @config_store.for('.').file_to_include?(file)
+    end
+
+    def included_file?(file)
+      ruby_file?(file) || configured_include?(file)
     end
 
     def process_explicit_path(path)
       files = path.include?('*') ? Dir[path] : [path]
 
-      files.select! { |file| ruby_file?(file) }
+      files.select! { |file| included_file?(file) }
 
       return files unless force_exclusion?
 

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.55.0'.freeze
+    STRING = '0.56.0'.freeze
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'.freeze

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.55.0
+  version: 0.56.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-16 00:00:00.000000000 Z
+date: 2018-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parallel
@@ -254,6 +254,7 @@ files:
 - lib/rubocop/cop/layout/dot_position.rb
 - lib/rubocop/cop/layout/else_alignment.rb
 - lib/rubocop/cop/layout/empty_comment.rb
+- lib/rubocop/cop/layout/empty_line_after_guard_clause.rb
 - lib/rubocop/cop/layout/empty_line_after_magic_comment.rb
 - lib/rubocop/cop/layout/empty_line_between_defs.rb
 - lib/rubocop/cop/layout/empty_lines.rb
@@ -337,6 +338,7 @@ files:
 - lib/rubocop/cop/lint/empty_when.rb
 - lib/rubocop/cop/lint/end_in_method.rb
 - lib/rubocop/cop/lint/ensure_return.rb
+- lib/rubocop/cop/lint/erb_new_arguments.rb
 - lib/rubocop/cop/lint/float_out_of_range.rb
 - lib/rubocop/cop/lint/format_parameter_mismatch.rb
 - lib/rubocop/cop/lint/handle_exceptions.rb
@@ -372,6 +374,7 @@ files:
 - lib/rubocop/cop/lint/shadowed_argument.rb
 - lib/rubocop/cop/lint/shadowed_exception.rb
 - lib/rubocop/cop/lint/shadowing_outer_local_variable.rb
+- lib/rubocop/cop/lint/splat_keyword_arguments.rb
 - lib/rubocop/cop/lint/string_conversion_in_interpolation.rb
 - lib/rubocop/cop/lint/syntax.rb
 - lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb
@@ -486,6 +489,7 @@ files:
 - lib/rubocop/cop/performance/end_with.rb
 - lib/rubocop/cop/performance/fixed_size.rb
 - lib/rubocop/cop/performance/flat_map.rb
+- lib/rubocop/cop/performance/inefficient_hash_search.rb
 - lib/rubocop/cop/performance/lstrip_rstrip.rb
 - lib/rubocop/cop/performance/range_include.rb
 - lib/rubocop/cop/performance/redundant_block_call.rb
@@ -507,6 +511,7 @@ files:
 - lib/rubocop/cop/rails/active_support_aliases.rb
 - lib/rubocop/cop/rails/application_job.rb
 - lib/rubocop/cop/rails/application_record.rb
+- lib/rubocop/cop/rails/assert_not.rb
 - lib/rubocop/cop/rails/blank.rb
 - lib/rubocop/cop/rails/create_table_with_timestamps.rb
 - lib/rubocop/cop/rails/date.rb
@@ -533,6 +538,7 @@ files:
 - lib/rubocop/cop/rails/present.rb
 - lib/rubocop/cop/rails/read_write_attribute.rb
 - lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb
+- lib/rubocop/cop/rails/refute_methods.rb
 - lib/rubocop/cop/rails/relative_date_constant.rb
 - lib/rubocop/cop/rails/request_referer.rb
 - lib/rubocop/cop/rails/reversible_migration.rb
@@ -588,7 +594,6 @@ files:
 - lib/rubocop/cop/style/empty_case_condition.rb
 - lib/rubocop/cop/style/empty_else.rb
 - lib/rubocop/cop/style/empty_lambda_parameter.rb
-- lib/rubocop/cop/style/empty_line_after_guard_clause.rb
 - lib/rubocop/cop/style/empty_literal.rb
 - lib/rubocop/cop/style/empty_method.rb
 - lib/rubocop/cop/style/encoding.rb
@@ -620,9 +625,10 @@ files:
 - lib/rubocop/cop/style/method_call_without_args_parentheses.rb
 - lib/rubocop/cop/style/method_called_on_do_end_block.rb
 - lib/rubocop/cop/style/method_def_parentheses.rb
-- lib/rubocop/cop/style/method_missing.rb
+- lib/rubocop/cop/style/method_missing_super.rb
 - lib/rubocop/cop/style/min_max.rb
 - lib/rubocop/cop/style/missing_else.rb
+- lib/rubocop/cop/style/missing_respond_to_missing.rb
 - lib/rubocop/cop/style/mixin_grouping.rb
 - lib/rubocop/cop/style/mixin_usage.rb
 - lib/rubocop/cop/style/module_function.rb