rubocop 0.19.1 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b7123eae3f7c324c84d026c2aeb11ebddb376064
-  data.tar.gz: 18fe22cdfb3bebefc347a49510eddfc2ef5bc39b
+  metadata.gz: 9bfa5cdcf23439710744d9065a22970e4c30918d
+  data.tar.gz: c931f4765d359ef1bf54ebb76c5393e6d0c223de
 SHA512:
-  metadata.gz: d3435aa3b04824630ecccfbc802c7d4ef8c74f4d8b0c7d697cd2e2b6d535ca0c6e7953ddb2a2f741303f3fc307776725053c6d9e3dc7b7a61d4e73811cadf6bb
-  data.tar.gz: dbc6fd5c8ab02d9f759c416d6a2e111f2715c4a9cb93620980e6bd8dac59b03d3b5c1b349fd59b86f0693b0dff9b66f1924870868e58c2a1245a5d90158c00d1
+  metadata.gz: cd67703e4e607f48f45618e3c28a250528dd658ab9d7258e93ad678978e6c17f1d0c47d57a4eafe0adbd1f796450de89f4d62fa144c008f343db8dfc314b32c6
+  data.tar.gz: c9812cfa4889a4f15c1f81bef017f5e256551cbcc43716f501609a06ef8d518b6514ed98a7c1784cadfe805db23b6e5180932551767b8e35b88050fbde557c30

data/.travis.yml

@@ -4,8 +4,12 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - ruby-head
   - jruby-19mode
   - rbx-2
+matrix:
+  allow_failures:
+    - rvm: ruby-head
 before_install: gem update --remote bundler
 script:
   - bundle exec rspec

data/CHANGELOG.md

@@ -1,7 +1,62 @@
-# Changelog
+# Change log
 
 ## master (unreleased)
 
+## 0.20.0 (02/04/2014)
+
+### New features
+
+* New cop `GuardClause` checks for conditionals that can be replaced by guard clauses. ([@bbatsov][])
+* New cop `EmptyInterpolation` checks for empty interpolation in double-quoted strings. ([@bbatsov][])
+* [#899](https://github.com/bbatsov/rubocop/issues/899): Make `LineEndConcatenation` cop `<<` aware. ([@mockdeep][])
+* [#896](https://github.com/bbatsov/rubocop/issues/896): New option `--fail-level` changes minimum severity for exit with error code. ([@hiroponz][])
+* [#893](https://github.com/bbatsov/rubocop/issues/893): New option `--force-exclusion` forces excluding files specified in the configuration `Exclude` even if they are explicitly passed as arguments. ([@yujinakayama][])
+* `VariableInterpolation` cop does auto-correction. ([@bbatsov][])
+* `Not` cop does auto-correction. ([@bbatsov][])
+* `ClassMethods` cop does auto-correction. ([@bbatsov][])
+* `StringConversionInInterpolation` cop does auto-correction. ([@bbatsov][])
+* `NilComparison` cop does auto-correction. ([@bbatsov][])
+* `NonNilComparison` cop does auto-correction. ([@bbatsov][])
+* `NegatedIf` cop does auto-correction. ([@bbatsov][])
+* `NegatedWhile` cop does auto-correction. ([@bbatsov][])
+* New lint cop `SpaceBeforeFirstArg` checks for space between the method name and the first argument in method calls without parentheses. ([@jonas054][])
+* New style cop `SingleSpaceBeforeFirstArg` checks that no more than one space is used between the method name and the first argument in method calls without parentheses. ([@jonas054][])
+* New formatter `disabled_lines` displays cops and line ranges disabled by inline comments. ([@fshowalter][])
+* New cop `UselessAccessModifiers` checks for access modifiers that have no effect. ([@fshowalter][])
+
+### Changes
+
+* [#913](https://github.com/bbatsov/rubocop/issues/913): `FileName` accepts multiple extensions. ([@tamird][])
+* `AllCops/Excludes` and `AllCops/Includes` were renamed to `AllCops/Exclude` and `AllCops/Include` for consistency with standard cop params. ([@bbatsov][])
+* Extract `NonNilCheck` cop from `NilComparison`. ([@bbatsov][])
+* Renamed `FavorJoin` to `ArrayJoin`. ([@bbatsov][])
+* Renamed `FavorUnlessOverNegatedIf` to `NegatedIf`. ([@bbatsov][])
+* Renamed `FavorUntilOverNegatedWhile`to `NegatedWhile`. ([@bbatsov][])
+* Renamed `HashMethods` to `DeprecatedHashMethods`. ([@bbatsov][])
+* Renamed `ReadAttribute` to `ReadWriteAttribute` and extended it to check for uses of `write_attribute`. ([@bbatsov][])
+* Add experimental support for Ruby 2.2 (development version) by falling back to Ruby 2.1 parser. ([@yujinakayama][])
+
+### Bugs fixed
+
+* [#926](https://github.com/bbatsov/rubocop/issues/926): Fixed `BlockNesting` not auto-generating correctly. ([@tmorris-fiksu][])
+* [#904](https://github.com/bbatsov/rubocop/issues/904): Fixed a NPE in `LiteralInInterpolation`. ([@bbatsov][])
+* [#904](https://github.com/bbatsov/rubocop/issues/904): Fixed a NPE in `StringConversionInInterpolation`. ([@bbatsov][])
+* [#892](https://github.com/bbatsov/rubocop/issues/892): Make sure `Include` and `Exclude` paths in a `.rubocop.yml` are interpreted as relative to the directory of that file. ([@jonas054][])
+* [#906](https://github.com/bbatsov/rubocop/issues/906): Fixed a false positive in `LiteralInInterpolation`. ([@bbatsov][])
+* [#909](https://github.com/bbatsov/rubocop/issues/909): Handle properly multiple `rescue` clauses in `SignalException`. ([@bbatsov][])
+* [#876](https://github.com/bbatsov/rubocop/issues/876): Do a deep merge of hashes when overriding default configuration in a `.rubocop.yml` file. ([@jonas054][])
+* [#912](https://github.com/bbatsov/rubocop/issues/912): Fix a false positive in `LineEndConcatenation` for `%` string literals. ([@bbatsov][])
+* [#912](https://github.com/bbatsov/rubocop/issues/912): Handle top-level constant resolution in `DeprecatedClassMethods` (e.g. `::File.exists?`). ([@bbatsov][])
+* [#914](https://github.com/bbatsov/rubocop/issues/914): Fixed rdoc error during gem installation. ([@bbatsov][])
+* The `--only` option now enables the given cop in case it is disabled in configuration. ([@jonas054][])
+* Fix path resolution so that the default exclusion of `vendor` directories works. ([@jonas054][])
+* [#908](https://github.com/bbatsov/rubocop/issues/908): Fixed hanging while auto correct for `SpaceAfterComma` and `SpaceInsideBrackets`. ([@hiroponz][])
+* [#919](https://github.com/bbatsov/rubocop/issues/919): Don't avoid auto-correction in `HashSyntax` when there is missing space around operator. ([@jonas054][])
+* Fixed handling of floats in `NumericLiterals`. ([@bbatsov][])
+* [#927](https://github.com/bbatsov/rubocop/issues/927): Let `--auto-gen-config` overwrite an existing `rubocop-todo.yml` file instead of asking the user to remove it. ([@jonas054][])
+* [#936](https://github.com/bbatsov/rubocop/issues/936): Allow `_other` as well as `other` in `OpMethod`. ([@bbatsov][])
+
+
 ## 0.19.1 (17/03/2014)
 
 ### Bugs fixed
@@ -772,3 +827,7 @@
 [@geniou]: https://github.com/geniou
 [@jkogara]: https://github.com/jkogara
 [@tmorris-fiksu]: https://github.com/tmorris-fiksu
+[@mockdeep]: https://github.com/mockdeep
+[@hiroponz]: https://github.com/hiroponz
+[@tamird]: https://github.com/tamird
+[@fshowalter]: https://github.com/fshowalter

data/CONTRIBUTING.md

@@ -37,7 +37,7 @@ $ rubocop -V
   you want to have your own version, or is otherwise necessary, that
   is fine, but please isolate to its own commit so I can cherry-pick
   around it.
-* Make sure the test suite is passing and the code you wrote doesn't produce
+* Make sure the test suite is passing ([including rbx and jruby][7]) and the code you wrote doesn't produce
   RuboCop offences.
 * [Squash related commits together][5].
 * Open a [pull request][4] that relates to *only* one subject with a clear title
@@ -65,3 +65,4 @@ Here are a few examples:
 [4]: https://help.github.com/articles/using-pull-requests
 [5]: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
 [6]: http://daringfireball.net/projects/markdown/syntax
+[7]: http://blog.stwrt.ca/2013/09/06/installing-rubinius-with-rbenv

data/README.md

@@ -141,6 +141,7 @@ Command flag              | Description
 `--only`                  | Run only the specified cop
 `--auto-gen-config`       | Generate a configuration file acting as a TODO list
 `--show-cops`             | Shows available cops and their configuration
+`--fail-level`            | Minimum severity for exit with error code
 
 ### Cops
 
@@ -165,7 +166,7 @@ own. You can run only the lint cops like this:
 $ rubocop -l
 ```
 
-Disabling any of the lint cops in generally a bad idea.
+Disabling any of the lint cops is generally a bad idea.
 
 #### Rails
 
@@ -235,17 +236,17 @@ RuboCop checks all files recursively within the directory it is run
 on.  However, it only recognizes files ending with `.rb` or
 extensionless files with a `#!.*ruby` declaration as Ruby files. If
 you'd like it to check other files you'll need to manually pass them
-in, or to add entries for them under `AllCops`/`Includes`.  Files and
-directories can also be ignored through `AllCops`/`Excludes`.
+in, or to add entries for them under `AllCops`/`Include`.  Files and
+directories can also be ignored through `AllCops`/`Exclude`.
 
 Here is an example that might be used for a Rails project:
 
 ```yaml
 AllCops:
-  Includes:
+  Include:
     - Rakefile
     - config.ru
-  Excludes:
+  Exclude:
     - db/**
     - config/**
     - script/**
@@ -257,9 +258,9 @@ AllCops:
 
 Files and directories are specified relative to the `.rubocop.yml` file.
 
-**Note**: The `Excludes` parameter is special. It is valid for the
+**Note**: The `Exclude` parameter is special. It is valid for the
 directory tree starting where it is defined. It is not shadowed by the
-setting of `Excludes` in other `.rubocop.yml` files in
+setting of `Exclude` in other `.rubocop.yml` files in
 subdirectories. This is different from all other parameters, who
 follow RuboCop's general principle that configuration for an inspected
 file is taken from the nearest `.rubocop.yml`, searching upwards.
@@ -293,6 +294,7 @@ LineLength:
 ```
 
 Cops can customize their severity level. All cops support the `Severity` param.
+Allowed params are `refactor`, `convention`, `warning`, `error` and `fatal`.
 
 ```yaml
 CyclomaticComplexity:

data/config/default.yml

@@ -8,10 +8,10 @@ inherit_from:
 # Common configuration.
 AllCops:
   # Include gemspec and Rakefile
-  Includes:
+  Include:
     - '**/*.gemspec'
     - '**/Rakefile'
-  Excludes:
+  Exclude:
     - 'vendor/**'
   # By default, the rails cops are not run. Override in project or home
   # directory .rubocop.yml files, or by giving the -R/--rails option.
@@ -437,7 +437,7 @@ HasAndBelongsToMany:
   Include:
     - app/models/*.rb
 
-ReadAttribute:
+ReadWriteAttribute:
   Include:
     - app/models/*.rb
 

data/config/disabled.yml

@@ -1,5 +1,9 @@
 # These are all the cops that are disabled in the default configuration.
 
+GuardClause:
+  Description: 'Check for conditionals that can be replaced with guard clauses'
+  Enabled: false
+
 MethodCalledOnDoEndBlock:
   Description: 'Avoid chaining a method call on a do...end block.'
   Enabled: false

data/config/enabled.yml

@@ -34,6 +34,10 @@ AndOr:
   Description: 'Use &&/|| instead of and/or.'
   Enabled: true
 
+ArrayJoin:
+  Description: 'Use Array#join instead of Array#*.'
+  Enabled: true
+
 AsciiComments:
   Description: 'Use only ascii symbols in comments.'
   Enabled: true
@@ -127,6 +131,10 @@ DefWithParentheses:
   Description: 'Use def with parentheses when there are arguments.'
   Enabled: true
 
+DeprecatedHashMethods:
+  Description: 'Checks for use of deprecated Hash methods.'
+  Enabled: true
+
 Documentation:
   Description: 'Document classes and non-namespace modules.'
   Enabled: true
@@ -175,20 +183,6 @@ EvenOdd:
   Description: 'Favor the use of Fixnum#even? && Fixnum#odd?'
   Enabled: true
 
-FavorJoin:
-  Description: 'Use Array#join instead of Array#*.'
-  Enabled: true
-
-FavorUnlessOverNegatedIf:
-  Description: >-
-                 Favor unless over if for negative conditions
-                 (or control flow or).
-  Enabled: true
-
-FavorUntilOverNegatedWhile:
-  Description: 'Favor until over while for negative conditions.'
-  Enabled: true
-
 FileName:
   Description: 'Use snake_case for source file names.'
   Enabled: true
@@ -213,10 +207,6 @@ GlobalVars:
   Description: 'Do not introduce global variables.'
   Enabled: true
 
-HashMethods:
-  Description: 'Checks for use of deprecated Hash methods.'
-  Enabled: true
-
 HashSyntax:
   Description: >-
                  Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax
@@ -307,6 +297,16 @@ MultilineTernaryOperator:
                  use if/unless instead.
   Enabled: true
 
+NegatedIf:
+  Description: >-
+                 Favor unless over if for negative conditions
+                 (or control flow or).
+  Enabled: true
+
+NegatedWhile:
+  Description: 'Favor until over while for negative conditions.'
+  Enabled: true
+
 NestedTernaryOperator:
   Description: 'Use one expression per branch in a ternary operator.'
   Enabled: true
@@ -315,6 +315,10 @@ NilComparison:
   Description: 'Prefer x.nil? to x == nil.'
   Enabled: true
 
+NonNilCheck:
+  Description: 'Checks for redundant nil checks.'
+  Enabled: true
+
 Not:
   Description: 'Use ! instead of not.'
   Enabled: true
@@ -413,6 +417,12 @@ SingleLineMethods:
   Description: 'Avoid single-line methods.'
   Enabled: true
 
+SingleSpaceBeforeFirstArg:
+  Description: >-
+                 Checks that exactly one space is used between a method name
+                 and the first argument for method calls without parentheses.
+  Enabled: true
+
 SpaceAfterColon:
   Description: 'Use spaces after colons.'
   Enabled: true
@@ -428,7 +438,7 @@ SpaceAfterControlKeyword:
 SpaceAfterMethodName:
   Description: >-
                  Never put a space between a method name and the opening
-                 parenthesis.
+                 parenthesis in a method definition.
   Enabled: true
 
 SpaceAfterNot:
@@ -584,6 +594,10 @@ EmptyEnsure:
   Description: 'Checks for empty ensure block.'
   Enabled: true
 
+EmptyInterpolation:
+  Description: 'Checks for empty string interpolation.'
+  Enabled: true
+
 EndAlignment:
   Description: 'Align ends correctly.'
   Enabled: true
@@ -646,6 +660,12 @@ ShadowingOuterLocalVariable:
                  for block arguments or block local variables.
   Enabled: true
 
+SpaceBeforeFirstArg:
+  Description: >-
+                 Put a space between a method name and the first argument
+                 in a method call wihtout parentheses.
+  Enabled: true
+
 StringConversionInInterpolation:
   Description: 'Checks for Object#to_s usage in string interpolation.'
   Enabled: true
@@ -654,6 +674,10 @@ UnreachableCode:
   Description: 'Unreachable code.'
   Enabled: true
 
+UselessAccessModifier:
+  Description: 'Checks for useless access modifiers.'
+  Enabled: true
+
 UselessAssignment:
   Description: 'Checks for useless assignment to a local variable.'
   Enabled: true
@@ -692,8 +716,8 @@ Output:
   Description: 'Checks for calls to puts, print, etc.'
   Enabled: true
 
-ReadAttribute:
-  Description: 'Prefer self[:attribute] over read_attribute(:attribute).'
+ReadWriteAttribute:
+  Description: 'Checks for read_attribute(:attr) and write_attribute(:attr, val).'
   Enabled: true
 
 ScopeArgs:

data/lib/rubocop.rb

@@ -1,14 +1,27 @@
 # encoding: utf-8
 
+# Try to load the latest parser and fall back to the latest supported version,
+# if parser does not yet support the current Ruby version.
+# This should only be problem when using development Ruby builds.
+begin
+  require 'parser/current'
+rescue NotImplementedError => error
+  warn "Falling back to Ruby 2.1 parser: #{error.message}"
+  require 'parser/ruby21'
+  Parser::CurrentRuby = Parser::Ruby21
+end
+
 require 'rainbow'
 # Rainbow 2.0 does not load the monkey-patch for String by default.
 require 'rainbow/ext/string' unless String.method_defined?(:color)
 
 require 'English'
 require 'set'
-require 'parser/current'
 require 'ast/sexp'
-require 'powerpack'
+require 'powerpack/enumerable/drop_last'
+require 'powerpack/hash/symbolize_keys'
+require 'powerpack/string/blank'
+require 'powerpack/string/strip_indent'
 
 require 'rubocop/version'
 
@@ -21,6 +34,7 @@ require 'rubocop/cop/cop'
 require 'rubocop/cop/commissioner'
 require 'rubocop/cop/corrector'
 require 'rubocop/cop/team'
+require 'rubocop/cop/severity'
 
 require 'rubocop/cop/variable_inspector'
 require 'rubocop/cop/variable_inspector/locatable'
@@ -59,6 +73,7 @@ require 'rubocop/cop/lint/debugger'
 require 'rubocop/cop/lint/deprecated_class_methods'
 require 'rubocop/cop/lint/else_layout'
 require 'rubocop/cop/lint/empty_ensure'
+require 'rubocop/cop/lint/empty_interpolation'
 require 'rubocop/cop/lint/end_alignment'
 require 'rubocop/cop/lint/end_in_method'
 require 'rubocop/cop/lint/ensure_return'
@@ -69,12 +84,14 @@ require 'rubocop/cop/lint/literal_in_condition'
 require 'rubocop/cop/lint/literal_in_interpolation'
 require 'rubocop/cop/lint/loop'
 require 'rubocop/cop/lint/parentheses_as_grouped_expression'
-require 'rubocop/cop/lint/rescue_exception'
 require 'rubocop/cop/lint/require_parentheses'
+require 'rubocop/cop/lint/rescue_exception'
 require 'rubocop/cop/lint/shadowing_outer_local_variable'
+require 'rubocop/cop/lint/space_before_first_arg'
 require 'rubocop/cop/lint/string_conversion_in_interpolation'
 require 'rubocop/cop/lint/syntax'
 require 'rubocop/cop/lint/unreachable_code'
+require 'rubocop/cop/lint/useless_access_modifier'
 require 'rubocop/cop/lint/useless_assignment'
 require 'rubocop/cop/lint/useless_comparison'
 require 'rubocop/cop/lint/useless_else_without_rescue'
@@ -88,6 +105,7 @@ require 'rubocop/cop/style/align_array'
 require 'rubocop/cop/style/align_hash'
 require 'rubocop/cop/style/align_parameters'
 require 'rubocop/cop/style/and_or'
+require 'rubocop/cop/style/array_join'
 require 'rubocop/cop/style/ascii_comments'
 require 'rubocop/cop/style/ascii_identifiers'
 require 'rubocop/cop/style/attr'
@@ -109,7 +127,8 @@ require 'rubocop/cop/style/colon_method_call'
 require 'rubocop/cop/style/comment_annotation'
 require 'rubocop/cop/style/constant_name'
 require 'rubocop/cop/style/cyclomatic_complexity'
-require 'rubocop/cop/style/def_parentheses'
+require 'rubocop/cop/style/def_with_parentheses'
+require 'rubocop/cop/style/deprecated_hash_methods'
 require 'rubocop/cop/style/documentation'
 require 'rubocop/cop/style/dot_position'
 require 'rubocop/cop/style/double_negation'
@@ -122,16 +141,13 @@ require 'rubocop/cop/style/encoding'
 require 'rubocop/cop/style/end_block'
 require 'rubocop/cop/style/end_of_line'
 require 'rubocop/cop/style/even_odd'
-require 'rubocop/cop/style/favor_join'
-require 'rubocop/cop/style/favor_unless_over_negated_if'
-require 'rubocop/cop/style/favor_until_over_negated_while'
 require 'rubocop/cop/style/file_name'
 require 'rubocop/cop/style/final_newline'
 require 'rubocop/cop/style/flip_flop'
 require 'rubocop/cop/style/for'
 require 'rubocop/cop/style/format_string'
 require 'rubocop/cop/style/global_vars'
-require 'rubocop/cop/style/hash_methods'
+require 'rubocop/cop/style/guard_clause'
 require 'rubocop/cop/style/hash_syntax'
 require 'rubocop/cop/style/if_unless_modifier'
 require 'rubocop/cop/style/if_with_semicolon'
@@ -153,8 +169,11 @@ require 'rubocop/cop/style/module_function'
 require 'rubocop/cop/style/multiline_block_chain'
 require 'rubocop/cop/style/multiline_if_then'
 require 'rubocop/cop/style/multiline_ternary_operator'
+require 'rubocop/cop/style/negated_if'
+require 'rubocop/cop/style/negated_while'
 require 'rubocop/cop/style/nested_ternary_operator'
 require 'rubocop/cop/style/nil_comparison'
+require 'rubocop/cop/style/non_nil_check'
 require 'rubocop/cop/style/not'
 require 'rubocop/cop/style/numeric_literals'
 require 'rubocop/cop/style/one_line_conditional'
@@ -177,6 +196,7 @@ require 'rubocop/cop/style/semicolon'
 require 'rubocop/cop/style/signal_exception'
 require 'rubocop/cop/style/single_line_block_params'
 require 'rubocop/cop/style/single_line_methods'
+require 'rubocop/cop/style/single_space_before_first_arg'
 require 'rubocop/cop/style/space_after_colon'
 require 'rubocop/cop/style/space_after_comma'
 require 'rubocop/cop/style/space_after_control_keyword'
@@ -211,12 +231,13 @@ require 'rubocop/cop/rails/action_filter'
 require 'rubocop/cop/rails/default_scope'
 require 'rubocop/cop/rails/has_and_belongs_to_many'
 require 'rubocop/cop/rails/output'
-require 'rubocop/cop/rails/read_attribute'
+require 'rubocop/cop/rails/read_write_attribute'
 require 'rubocop/cop/rails/scope_args'
 require 'rubocop/cop/rails/validation'
 
 require 'rubocop/formatter/base_formatter'
 require 'rubocop/formatter/simple_text_formatter'
+require 'rubocop/formatter/disabled_lines_formatter'
 require 'rubocop/formatter/disabled_config_formatter'
 require 'rubocop/formatter/emacs_style_formatter'
 require 'rubocop/formatter/clang_style_formatter'