RubyGems - rubocop - Versions diffs - 0.19.1 → 0.20.0 - Mend

rubocop 0.19.1 → 0.20.0

Potentially problematic release.

This version of rubocop might be problematic. Click here for more details.

Files changed (192) hide show

checksums.yaml +4 -4
data/.travis.yml +4 -0
data/CHANGELOG.md +60 -1
data/CONTRIBUTING.md +2 -1
data/README.md +9 -7
data/config/default.yml +3 -3
data/config/disabled.yml +4 -0
data/config/enabled.yml +45 -21
data/lib/rubocop.rb +30 -9
data/lib/rubocop/cli.rb +1 -1
data/lib/rubocop/comment_config.rb +4 -2
data/lib/rubocop/config.rb +16 -22
data/lib/rubocop/config_loader.rb +29 -26
data/lib/rubocop/cop/commissioner.rb +1 -1
data/lib/rubocop/cop/cop.rb +6 -6
data/lib/rubocop/cop/lint/assignment_in_condition.rb +1 -1
data/lib/rubocop/cop/lint/condition_position.rb +1 -1
data/lib/rubocop/cop/lint/debugger.rb +1 -1
data/lib/rubocop/cop/lint/deprecated_class_methods.rb +9 -7
data/lib/rubocop/cop/lint/else_layout.rb +1 -1
data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
data/lib/rubocop/cop/lint/empty_interpolation.rb +22 -0
data/lib/rubocop/cop/lint/end_in_method.rb +1 -1
data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
data/lib/rubocop/cop/lint/eval.rb +1 -1
data/lib/rubocop/cop/lint/literal_in_condition.rb +2 -2
data/lib/rubocop/cop/lint/literal_in_interpolation.rb +9 -0
data/lib/rubocop/cop/lint/loop.rb +2 -2
data/lib/rubocop/cop/lint/require_parentheses.rb +0 -4
data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +1 -1
data/lib/rubocop/cop/lint/space_before_first_arg.rb +36 -0
data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +14 -2
data/lib/rubocop/cop/lint/useless_access_modifier.rb +57 -0
data/lib/rubocop/cop/lint/useless_setter_call.rb +1 -1
data/lib/rubocop/cop/lint/void.rb +3 -3
data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
data/lib/rubocop/cop/offense.rb +3 -21
data/lib/rubocop/cop/rails/action_filter.rb +1 -1
data/lib/rubocop/cop/rails/default_scope.rb +1 -1
data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +1 -1
data/lib/rubocop/cop/rails/read_write_attribute.rb +43 -0
data/lib/rubocop/cop/rails/scope_args.rb +1 -1
data/lib/rubocop/cop/rails/validation.rb +1 -1
data/lib/rubocop/cop/severity.rb +76 -0
data/lib/rubocop/cop/style/access_modifier_indentation.rb +1 -1
data/lib/rubocop/cop/style/accessor_method_name.rb +2 -2
data/lib/rubocop/cop/style/alias.rb +1 -1
data/lib/rubocop/cop/style/align_hash.rb +1 -1
data/lib/rubocop/cop/style/and_or.rb +1 -1
data/lib/rubocop/cop/style/{favor_join.rb → array_join.rb} +2 -2
data/lib/rubocop/cop/style/begin_block.rb +1 -1
data/lib/rubocop/cop/style/block_nesting.rb +12 -8
data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +1 -1
data/lib/rubocop/cop/style/case_equality.rb +1 -1
data/lib/rubocop/cop/style/case_indentation.rb +5 -5
data/lib/rubocop/cop/style/class_methods.rb +19 -3
data/lib/rubocop/cop/style/class_vars.rb +1 -1
data/lib/rubocop/cop/style/collection_methods.rb +17 -7
data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
data/lib/rubocop/cop/style/{def_parentheses.rb → def_with_parentheses.rb} +0 -0
data/lib/rubocop/cop/style/{hash_methods.rb → deprecated_hash_methods.rb} +5 -4
data/lib/rubocop/cop/style/double_negation.rb +1 -1
data/lib/rubocop/cop/style/empty_lines_around_access_modifier.rb +1 -1
data/lib/rubocop/cop/style/end_block.rb +1 -1
data/lib/rubocop/cop/style/even_odd.rb +2 -2
data/lib/rubocop/cop/style/file_name.rb +1 -1
data/lib/rubocop/cop/style/for.rb +2 -2
data/lib/rubocop/cop/style/format_string.rb +1 -1
data/lib/rubocop/cop/style/guard_clause.rb +69 -0
data/lib/rubocop/cop/style/hash_syntax.rb +6 -10
data/lib/rubocop/cop/style/if_unless_modifier.rb +2 -2
data/lib/rubocop/cop/style/lambda.rb +2 -2
data/lib/rubocop/cop/style/line_end_concatenation.rb +16 -9
data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
data/lib/rubocop/cop/style/multiline_ternary_operator.rb +2 -2
data/lib/rubocop/cop/style/negated_if.rb +37 -0
data/lib/rubocop/cop/style/negated_while.rb +33 -0
data/lib/rubocop/cop/style/nested_ternary_operator.rb +1 -1
data/lib/rubocop/cop/style/nil_comparison.rb +14 -10
data/lib/rubocop/cop/style/non_nil_check.rb +70 -0
data/lib/rubocop/cop/style/not.rb +25 -1
data/lib/rubocop/cop/style/numeric_literals.rb +1 -1
data/lib/rubocop/cop/style/op_method.rb +4 -4
data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
data/lib/rubocop/cop/style/predicate_name.rb +1 -1
data/lib/rubocop/cop/style/proc.rb +1 -1
data/lib/rubocop/cop/style/raise_args.rb +3 -2
data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
data/lib/rubocop/cop/style/self_assignment.rb +2 -2
data/lib/rubocop/cop/style/signal_exception.rb +6 -3
data/lib/rubocop/cop/style/single_line_block_params.rb +1 -1
data/lib/rubocop/cop/style/single_line_methods.rb +6 -5
data/lib/rubocop/cop/style/single_space_before_first_arg.rb +41 -0
data/lib/rubocop/cop/style/space_around_operators.rb +1 -2
data/lib/rubocop/cop/style/special_global_vars.rb +8 -8
data/lib/rubocop/cop/style/trailing_comma.rb +1 -1
data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
data/lib/rubocop/cop/style/unless_else.rb +1 -1
data/lib/rubocop/cop/style/variable_interpolation.rb +10 -5
data/lib/rubocop/cop/style/when_then.rb +1 -1
data/lib/rubocop/cop/style/while_until_modifier.rb +1 -1
data/lib/rubocop/cop/style/word_array.rb +1 -1
data/lib/rubocop/cop/team.rb +12 -13
data/lib/rubocop/cop/util.rb +4 -0
data/lib/rubocop/cop/variable_inspector/locatable.rb +1 -1
data/lib/rubocop/cop/variable_inspector/variable_table.rb +1 -1
data/lib/rubocop/file_inspector.rb +46 -10
data/lib/rubocop/formatter/disabled_config_formatter.rb +1 -1
data/lib/rubocop/formatter/disabled_lines_formatter.rb +56 -0
data/lib/rubocop/formatter/emacs_style_formatter.rb +1 -1
data/lib/rubocop/formatter/formatter_set.rb +2 -1
data/lib/rubocop/formatter/fuubar_style_formatter.rb +2 -4
data/lib/rubocop/formatter/json_formatter.rb +3 -7
data/lib/rubocop/formatter/progress_formatter.rb +1 -3
data/lib/rubocop/formatter/simple_text_formatter.rb +7 -3
data/lib/rubocop/options.rb +29 -10
data/lib/rubocop/path_util.rb +2 -1
data/lib/rubocop/processed_source.rb +8 -0
data/lib/rubocop/target_finder.rb +33 -12
data/lib/rubocop/version.rb +1 -1
data/relnotes/v0.20.0.md +69 -0
data/rubocop-todo.yml +2 -2
data/spec/rubocop/cli_spec.rb +269 -94
data/spec/rubocop/config_loader_spec.rb +14 -14
data/spec/rubocop/config_spec.rb +8 -8
data/spec/rubocop/cop/lint/deprecated_class_methods_spec.rb +11 -6
data/spec/rubocop/cop/lint/empty_interpolation_spec.rb +18 -0
data/spec/rubocop/cop/lint/eval_spec.rb +2 -4
data/spec/rubocop/cop/lint/literal_in_interpolation_spec.rb +10 -0
data/spec/rubocop/cop/lint/rescue_exception_spec.rb +0 -8
data/spec/rubocop/cop/lint/shadowing_outer_local_variable_spec.rb +4 -4
data/spec/rubocop/cop/lint/space_before_first_arg_spec.rb +48 -0
data/spec/rubocop/cop/lint/string_conversion_in_interpolation_spec.rb +10 -0
data/spec/rubocop/cop/lint/useless_access_modifier_spec.rb +154 -0
data/spec/rubocop/cop/offense_spec.rb +1 -1
data/spec/rubocop/cop/rails/read_write_attribute_spec.rb +19 -0
data/spec/rubocop/cop/severity_spec.rb +113 -0
data/spec/rubocop/cop/style/access_modifier_indentation_spec.rb +10 -10
data/spec/rubocop/cop/style/alias_spec.rb +2 -2
data/spec/rubocop/cop/style/and_or_spec.rb +2 -2
data/spec/rubocop/cop/style/{favor_join_spec.rb → array_join_spec.rb} +1 -3
data/spec/rubocop/cop/style/block_nesting_spec.rb +4 -4
data/spec/rubocop/cop/style/case_equality_spec.rb +1 -0
data/spec/rubocop/cop/style/case_indentation_spec.rb +12 -9
data/spec/rubocop/cop/style/class_methods_spec.rb +23 -0
data/spec/rubocop/cop/style/collection_methods_spec.rb +2 -2
data/spec/rubocop/cop/style/{hash_methods_spec.rb → deprecated_hash_methods_spec.rb} +3 -3
data/spec/rubocop/cop/style/empty_lines_around_access_modifier_spec.rb +2 -2
data/spec/rubocop/cop/style/even_odd_spec.rb +8 -8
data/spec/rubocop/cop/style/file_name_spec.rb +55 -42
data/spec/rubocop/cop/style/for_spec.rb +4 -4
data/spec/rubocop/cop/style/format_string_spec.rb +10 -10
data/spec/rubocop/cop/style/guard_clause_spec.rb +77 -0
data/spec/rubocop/cop/style/hash_syntax_spec.rb +4 -2
data/spec/rubocop/cop/style/if_unless_modifier_spec.rb +4 -4
data/spec/rubocop/cop/style/lambda_spec.rb +2 -2
data/spec/rubocop/cop/style/line_end_concatenation_spec.rb +21 -0
data/spec/rubocop/cop/style/multiline_if_then_spec.rb +1 -1
data/spec/rubocop/cop/style/{favor_unless_over_negated_if_spec.rb → negated_if_spec.rb} +8 -3
data/spec/rubocop/cop/style/{favor_until_over_negated_while_spec.rb → negated_while_spec.rb} +8 -3
data/spec/rubocop/cop/style/nil_comparison_spec.rb +7 -13
data/spec/rubocop/cop/style/non_nil_check_spec.rb +35 -0
data/spec/rubocop/cop/style/not_spec.rb +11 -0
data/spec/rubocop/cop/style/numeric_literals_spec.rb +0 -2
data/spec/rubocop/cop/style/op_method_spec.rb +10 -2
data/spec/rubocop/cop/style/parentheses_around_condition_spec.rb +2 -2
data/spec/rubocop/cop/style/predicate_name_spec.rb +2 -1
data/spec/rubocop/cop/style/raise_args_spec.rb +5 -0
data/spec/rubocop/cop/style/rescue_modifier_spec.rb +2 -2
data/spec/rubocop/cop/style/self_assignment_spec.rb +4 -4
data/spec/rubocop/cop/style/signal_exception_spec.rb +24 -0
data/spec/rubocop/cop/style/single_line_block_params_spec.rb +2 -0
data/spec/rubocop/cop/style/single_space_before_first_arg_spec.rb +63 -0
data/spec/rubocop/cop/style/special_global_vars_spec.rb +6 -5
data/spec/rubocop/cop/style/trivial_accessors_spec.rb +6 -3
data/spec/rubocop/cop/style/unless_else_spec.rb +2 -4
data/spec/rubocop/cop/style/variable_interpolation_spec.rb +15 -6
data/spec/rubocop/cop/style/when_then_spec.rb +3 -4
data/spec/rubocop/cop/team_spec.rb +4 -18
data/spec/rubocop/file_inspector_spec.rb +4 -0
data/spec/rubocop/formatter/disabled_config_formatter_spec.rb +1 -1
data/spec/rubocop/formatter/disabled_lines_formatter_spec.rb +69 -0
data/spec/rubocop/options_spec.rb +5 -0
data/spec/rubocop/target_finder_spec.rb +42 -11
data/spec/support/shared_context.rb +1 -1
data/spec/support/statement_modifier_helper.rb +1 -1
metadata +75 -50
data/lib/rubocop/cop/rails/read_attribute.rb +0 -28
data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb +0 -24
data/lib/rubocop/cop/style/favor_until_over_negated_while.rb +0 -20
data/spec/rubocop/cop/rails/read_attribute_spec.rb +0 -13

data/lib/rubocop/cop/rails/read_attribute.rb DELETED

@@ -1,28 +0,0 @@
-# encoding: utf-8
-module Rubocop
-  module Cop
-    module Rails
-      # This cop checks for the use of the read_attribute method.
-      #
-      # @example
-      #
-      #   # bad
-      #   read_attributed(:attr)
-      #
-      #   # good
-      #   self[:attr]
-      class ReadAttribute < Cop
-        MSG = 'Prefer self[:attribute] over read_attribute(:attribute).'
-        def on_send(node)
-          receiver, method_name, *_args = *node
-          if receiver.nil? && method_name == :read_attribute
-            add_offense(node, :selector)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/favor_unless_over_negated_if.rb DELETED

@@ -1,24 +0,0 @@
-# encoding: utf-8
-module Rubocop
-  module Cop
-    module Style
-      # Checks for uses of if with a negated condition. Only ifs
-      # without else are considered.
-      class FavorUnlessOverNegatedIf < Cop
-        include NegativeConditional
-        def on_if(node)
-          return unless node.loc.respond_to?(:keyword)
-          return if node.loc.keyword.is?('elsif')
-          check(node)
-        end
-        def error_message
-          'Favor unless (or control flow or) over if for negative conditions.'
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/style/favor_until_over_negated_while.rb DELETED

@@ -1,20 +0,0 @@
-# encoding: utf-8
-module Rubocop
-  module Cop
-    module Style
-      # Checks for uses of while with a negated condition.
-      class FavorUntilOverNegatedWhile < Cop
-        include NegativeConditional
-        def on_while(node)
-          check(node)
-        end
-        def error_message
-          'Favor until over while for negative conditions.'
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/cop/rails/read_attribute_spec.rb DELETED

@@ -1,13 +0,0 @@
-# encoding: utf-8
-require 'spec_helper'
-describe Rubocop::Cop::Rails::ReadAttribute do
-  subject(:cop) { described_class.new }
-  it 'registers an offense for read_attribute' do
-    inspect_source(cop,
-                   ['res = read_attribute(:test)'])
-    expect(cop.offenses.size).to eq(1)
-  end
-end