rubocop 1.72.0 → 1.72.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4660ddf63f92b10c83414d6a542725aacda2df1b9f47aec675b075fcdaa58817
-  data.tar.gz: b7c045964213e406e20675c06ed8df3a7e19bff18cf48b0db9891b8e1ae6cd8a
+  metadata.gz: 4a6ff0f849d961da13d2131ff60e0ed49dce01a4c2d32caa8484a2344344609b
+  data.tar.gz: 9da9fc43212c62cd6542649c90423e9365f50cb00e82b6337be1a241c6a17283
 SHA512:
-  metadata.gz: 0c4982b57b3c2cfbd48d2768eefeb839b6b91a5c9c90a55f4dfc1f1c37b655d73b64d99bbebc642d928ecfb9740c6992ed340ea38f2f1638626aa3d2e2c7a190
-  data.tar.gz: f4d6cfcfb42615a5a4065c961aac1dd55eb7e6bd28812d0a31aef135be94b9248eab2b53f1a452847b49c206aab7b3eb19b45581203af63d10be9e7cb71e67da
+  metadata.gz: 7ff34957554167b3b1e30645e3754094968fae93d0284a3882460b3e24f44fd64bcf358b23fd0e8154489206fd9c95fc6555b551f1af5ac810805fac2b6d27be
+  data.tar.gz: 48e989049de37523554c740ba1368e32de38bc0f879c1fc717924a758a1ba465ef4413cba80a42be59ccaaf87616b52c0ad437256702bf5fd091c4a5818f428a

data/config/default.yml

@@ -5171,7 +5171,9 @@ Style/RedundantFilterChain:
 Style/RedundantFormat:
   Description: 'Checks for usages of `Kernel#format` or `Kernel#sprintf` with only a single argument.'
   Enabled: pending
+  SafeAutoCorrect: false
   VersionAdded: '1.72'
+  VersionChanged: '1.72'
 
 Style/RedundantFreeze:
   Description: "Checks usages of Object#freeze on immutable objects."

data/lib/rubocop/config_loader.rb

@@ -163,6 +163,10 @@ module RuboCop
         end
       end
 
+      # This API is primarily intended for testing and documenting plugins.
+      # When testing a plugin using `rubocop/rspec/support`, the plugin is loaded automatically,
+      # so this API is usually not needed. It is intended to be used only when implementing tests
+      # that do not use `rubocop/rspec/support`.
       # rubocop:disable Metrics/MethodLength
       def inject_defaults!(config_yml_path)
         if Pathname(config_yml_path).directory?

data/lib/rubocop/cop/internal_affairs/example_description.rb

@@ -90,8 +90,10 @@ module RuboCop
           description_text = string_contents(current_description)
           return unless (new_description = correct_description(description_text, description_map))
 
+          quote = current_description.dstr_type? ? '"' : "'"
+
           add_offense(current_description, message: message) do |corrector|
-            corrector.replace(current_description, "'#{new_description}'")
+            corrector.replace(current_description, "#{quote}#{new_description}#{quote}")
           end
         end
 
@@ -106,7 +108,7 @@ module RuboCop
         end
 
         def string_contents(node)
-          node.str_type? ? node.value : node.source
+          node.type?(:str, :dstr) ? node.value : node.source
         end
       end
     end

data/lib/rubocop/cop/lint/redundant_type_conversion.rb

@@ -161,7 +161,10 @@ module RuboCop
           }
         PATTERN
 
+        # rubocop:disable Metrics/AbcSize
         def on_send(node)
+          return if hash_or_set_with_block?(node)
+
           receiver = find_receiver(node)
           return unless literal_receiver?(node, receiver) ||
                         constructor?(node, receiver) ||
@@ -174,10 +177,17 @@ module RuboCop
             corrector.remove(node.loc.dot.join(node.loc.selector))
           end
         end
+        # rubocop:enable Metrics/AbcSize
         alias on_csend on_send
 
         private
 
+        def hash_or_set_with_block?(node)
+          return false if !node.method?(:to_h) && !node.method?(:to_set)
+
+          node.parent&.any_block_type? || node.last_argument&.block_pass_type?
+        end
+
         def find_receiver(node)
           receiver = node.receiver
           return unless receiver

data/lib/rubocop/cop/lint/useless_constant_scoping.rb

@@ -56,7 +56,13 @@ module RuboCop
         private
 
         def after_private_modifier?(left_siblings)
-          left_siblings.compact.select(&:send_type?).any? { |node| node.command?(:private) }
+          access_modifier_candidates = left_siblings.compact.select do |left_sibling|
+            left_sibling.respond_to?(:send_type?) && left_sibling.send_type?
+          end
+
+          access_modifier_candidates.any? do |candidate|
+            candidate.command?(:private) && candidate.arguments.none?
+          end
         end
 
         def private_constantize?(right_siblings, const_value)

data/lib/rubocop/cop/mixin/allowed_pattern.rb

@@ -18,12 +18,12 @@ module RuboCop
       end
 
       # @deprecated Use allowed_line? instead
-      def ignored_line?
+      def ignored_line?(line)
         warn Rainbow(<<~WARNING).yellow, uplevel: 1
           `ignored_line?` is deprecated. Use `allowed_line?` instead.
         WARNING
 
-        allowed_line?
+        allowed_line?(line)
       end
 
       def matches_allowed_pattern?(line)
@@ -31,12 +31,12 @@ module RuboCop
       end
 
       # @deprecated Use matches_allowed_pattern? instead
-      def matches_ignored_pattern?
+      def matches_ignored_pattern?(line)
         warn Rainbow(<<~WARNING).yellow, uplevel: 1
           `matches_ignored_pattern?` is deprecated. Use `matches_allowed_pattern?` instead.
         WARNING
 
-        matches_allowed_pattern?
+        matches_allowed_pattern?(line)
       end
 
       def allowed_patterns

data/lib/rubocop/cop/naming/block_forwarding.rb

@@ -14,10 +14,10 @@ module RuboCop
       # autocorrected.
       #
       # [NOTE]
-      # --
+      # ====
       # Because of a bug in Ruby 3.3.0, when a block is referenced inside of another block,
       # no offense will be registered until Ruby 3.4:
-
+      #
       # [source,ruby]
       # ----
       # def foo(&block)
@@ -25,7 +25,7 @@ module RuboCop
       #   block_method { bar(&block) }
       # end
       # ----
-      # --
+      # ====
       #
       # @example EnforcedStyle: anonymous (default)
       #

data/lib/rubocop/cop/style/arguments_forwarding.rb

@@ -32,10 +32,10 @@ module RuboCop
       # This cop handles not only method forwarding but also forwarding to `super`.
       #
       # [NOTE]
-      # --
+      # ====
       # Because of a bug in Ruby 3.3.0, when a block is referenced inside of another block,
       # no offense will be registered until Ruby 3.4:
-
+      #
       # [source,ruby]
       # ----
       # def foo(&block)
@@ -43,7 +43,7 @@ module RuboCop
       #   block_method { bar(&block) }
       # end
       # ----
-      # --
+      # ====
       #
       # @example
       #   # bad

data/lib/rubocop/cop/style/redundant_format.rb

@@ -12,6 +12,22 @@ module RuboCop
       # inlined into a string easily. This applies to the `%s`, `%d`, `%i`, `%u`, and
       # `%f` format specifiers.
       #
+      # @safety
+      #   This cop's autocorrection is unsafe because string object returned by
+      #   `format` and `sprintf` are never frozen. If `format('string')` is autocorrected to
+      #   `'string'`, `FrozenError` may occur when calling a destructive method like `String#<<`.
+      #   Consider using `'string'.dup` instead of `format('string')`.
+      #   Additionally, since the necessity of `dup` cannot be determined automatically,
+      #   this autocorrection is inherently unsafe.
+      #
+      #   [source,ruby]
+      #   ----
+      #   # frozen_string_literal: true
+      #
+      #   format('template').frozen? # => false
+      #   'template'.frozen?         # => true
+      #   ----
+      #
       # @example
       #
       #   # bad
@@ -113,7 +129,7 @@ module RuboCop
         end
 
         def find_argument(sequence, arguments, hash)
-          if sequence.annotated? || sequence.template?
+          if hash && (sequence.annotated? || sequence.template?)
             find_hash_value_node(hash, sequence.name.to_sym).first
           elsif sequence.arg_number
             arguments[sequence.arg_number.to_i - 1]
@@ -144,7 +160,7 @@ module RuboCop
         end
 
         def numeric?(argument)
-          argument.type?(:numeric, :str) ||
+          argument&.type?(:numeric, :str) ||
             rational_number?(argument) ||
             complex_number?(argument)
         end

data/lib/rubocop/cop/style/redundant_parentheses.rb

@@ -13,8 +13,7 @@ module RuboCop
       #   # good
       #   x if y.z.nil?
       #
-      # rubocop:disable Metrics/ClassLength
-      class RedundantParentheses < Base
+      class RedundantParentheses < Base # rubocop:disable Metrics/ClassLength
         include Parentheses
         extend AutoCorrector
 
@@ -217,7 +216,9 @@ module RuboCop
 
         def disallowed_literal?(begin_node, node)
           if node.range_type?
-            begin_node.parent&.begin_type?
+            return false unless (parent = begin_node.parent)
+
+            parent.begin_type? && parent.children.one?
           else
             !raised_to_power_negative_numeric?(begin_node, node)
           end
@@ -297,7 +298,6 @@ module RuboCop
           block.keywords? && begin_node.each_ancestor(:call).any?
         end
       end
-      # rubocop:enable Metrics/ClassLength
     end
   end
 end

data/lib/rubocop/plugin/configuration_integrator.rb

@@ -57,6 +57,8 @@ module RuboCop
                 all_cop_keys_configured_by_plugins
               )
 
+              plugin_config.make_excludes_absolute
+
               ConfigLoader.merge_with_default(plugin_config, plugin_config_path)
             end
           end

data/lib/rubocop/plugin/load_error.rb

@@ -13,21 +13,12 @@ module RuboCop
 
       def message
         <<~MESSAGE
-          Failed loading plugin `#{@plugin_name}` because we couldn't determine the corresponding plugin class to instantiate.
-          First, try upgrading it. If the issue persists, please check with the developer regarding the following points.
+          Failed to load plugin `#{@plugin_name}` because the corresponding plugin class could not be determined for instantiation.
+          Try upgrading it first (e.g., `bundle update #{@plugin_name}`).
+          If `#{@plugin_name}` is not yet a plugin, use `require: #{@plugin_name}` instead of `plugins: `#{@plugin_name}` in your configuration.
 
-          RuboCop plugin class names must either be:
-
-            - If the plugin is a gem, defined in the gemspec as `default_lint_roller_plugin'
-
-              spec.metadata['default_lint_roller_plugin'] = 'MyModule::Plugin'
-
-            - Set in YAML as `plugin_class_name'; example:
-
-              plugins:
-                - incomplete:
-                    require_path: my_module/plugin
-                    plugin_class_name: "MyModule::Plugin"
+          For further assistance, check with the developer regarding the following points:
+          https://docs.rubocop.org/rubocop/plugin_migration_guide.html
         MESSAGE
       end
     end

data/lib/rubocop/rspec/cop_helper.rb

@@ -13,6 +13,15 @@ module CopHelper
   let(:parser_engine) { ENV.fetch('PARSER_ENGINE', :parser_whitequark).to_sym }
   let(:rails_version) { false }
 
+  before(:all) do
+    next if ENV['RUBOCOP_CORE_DEVELOPMENT']
+
+    plugins = Gem.loaded_specs.filter_map do |feature_name, feature_specification|
+      feature_name if feature_specification.metadata['default_lint_roller_plugin']
+    end
+    RuboCop::Plugin.integrate_plugins(RuboCop::Config.new, plugins)
+  end
+
   def inspect_source(source, file = nil)
     RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
     RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '1.72.0'
+    STRING = '1.72.2'
 
     MSG = '%<version>s (using %<parser_version>s, ' \
           'rubocop-ast %<rubocop_ast_version>s, ' \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 1.72.0
+  version: 1.72.2
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -9,7 +9,7 @@ authors:
 - Yuji Nakayama
 bindir: exe
 cert_chain: []
-date: 2025-02-14 00:00:00.000000000 Z
+date: 2025-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -1075,7 +1075,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://rubocop.org/
-  changelog_uri: https://github.com/rubocop/rubocop/releases/tag/v1.72.0
+  changelog_uri: https://github.com/rubocop/rubocop/releases/tag/v1.72.2
   source_code_uri: https://github.com/rubocop/rubocop/
   documentation_uri: https://docs.rubocop.org/rubocop/1.72/
   bug_tracker_uri: https://github.com/rubocop/rubocop/issues