rubocop 1.71.0 → 1.71.1

data/lib/rubocop/cop/style/return_nil.rb

@@ -83,7 +83,7 @@ module RuboCop
         end
 
         def scoped_node?(node)
-          node.def_type? || node.defs_type? || node.lambda?
+          node.type?(:def, :defs) || node.lambda?
         end
 
         # @!method chained_send?(node)

data/lib/rubocop/cop/style/safe_navigation.rb

@@ -312,7 +312,7 @@ module RuboCop
         end
 
         def chain_length(method_chain, method)
-          method.each_ancestor(:send, :csend).inject(0) do |total, ancestor|
+          method.each_ancestor(:call).inject(0) do |total, ancestor|
             break total + 1 if ancestor == method_chain
 
             total + 1

data/lib/rubocop/cop/style/semicolon.rb

@@ -164,7 +164,7 @@ module RuboCop
 
           ast = processed_source.ast
           @range_nodes = ast.range_type? ? [ast] : []
-          @range_nodes.concat(ast.each_descendant(:irange, :erange).to_a)
+          @range_nodes.concat(ast.each_descendant(:range).to_a)
         end
       end
     end

data/lib/rubocop/cop/style/single_line_methods.rb

@@ -68,7 +68,7 @@ module RuboCop
           return false if body_node.parent.assignment_method? ||
                           NOT_SUPPORTED_ENDLESS_METHOD_BODY_TYPES.include?(body_node.type)
 
-          !(body_node.begin_type? || body_node.kwbegin_type?)
+          !body_node.type?(:begin, :kwbegin)
         end
 
         def correct_to_multiline(corrector, node)

data/lib/rubocop/cop/style/sole_nested_conditional.rb

@@ -156,7 +156,7 @@ module RuboCop
           # Handle `send` and `block` nodes that need to be wrapped in parens
           # FIXME: autocorrection prevents syntax errors by wrapping the entire node in parens,
           #        but wrapping the argument list would be a more ergonomic correction.
-          node_to_check = condition&.block_type? ? condition.send_node : condition
+          node_to_check = condition&.any_block_type? ? condition.send_node : condition
           return unless wrap_condition?(node_to_check)
 
           if condition.call_type?

data/lib/rubocop/cop/style/string_concatenation.rb

@@ -132,7 +132,7 @@ module RuboCop
         end
 
         def heredoc?(node)
-          return false unless node.str_type? || node.dstr_type?
+          return false unless node.type?(:str, :dstr)
 
           node.heredoc?
         end

data/lib/rubocop/cop/style/string_literals.rb

@@ -69,7 +69,7 @@ module RuboCop
         end
 
         def all_string_literals?(nodes)
-          nodes.all? { |n| n.str_type? || n.dstr_type? }
+          nodes.all? { |n| n.type?(:str, :dstr) }
         end
 
         def detect_quote_styles(node)

data/lib/rubocop/cop/style/super_arguments.rb

@@ -98,7 +98,7 @@ module RuboCop
             # When defining dynamic methods, implicitly calling `super` is not possible.
             # Since there is a possibility of delegation to `define_method`,
             # `super` used within the block is always allowed.
-            break if node.block_type? && !block_sends_to_super?(super_node, node)
+            break if node.any_block_type? && !block_sends_to_super?(super_node, node)
 
             break node if DEF_TYPES.include?(node.type)
           end
@@ -136,13 +136,13 @@ module RuboCop
           # Checks if the send node of a block is the given super node,
           # or a method chain containing it.
           return false unless parent_node
-          return false unless parent_node.type?(:block, :numblock)
+          return false unless parent_node.any_block_type?
 
           parent_node.send_node.each_node(:super).any?(super_node)
         end
 
         def positional_arg_same?(def_arg, super_arg)
-          return false unless def_arg.arg_type? || def_arg.optarg_type?
+          return false unless def_arg.type?(:arg, :optarg)
           return false unless super_arg.lvar_type?
 
           def_arg.name == super_arg.children.first
@@ -159,7 +159,7 @@ module RuboCop
         end
 
         def keyword_arg_same?(def_arg, super_arg)
-          return false unless def_arg.kwarg_type? || def_arg.kwoptarg_type?
+          return false unless def_arg.type?(:kwarg, :kwoptarg)
           return false unless (pair_node = super_arg).pair_type?
           return false unless (sym_node = pair_node.key).sym_type?
           return false unless (lvar_node = pair_node.value).lvar_type?

data/lib/rubocop/cop/style/ternary_parentheses.rb

@@ -232,7 +232,7 @@ module RuboCop
         end
 
         def node_with_args?(node)
-          node.call_type? || node.defined_type?
+          node.type?(:call, :defined?)
         end
       end
     end

data/lib/rubocop/cop/style/top_level_method_definition.rb

@@ -77,7 +77,7 @@ module RuboCop
 
         # @!method define_method_block?(node)
         def_node_matcher :define_method_block?, <<~PATTERN
-          ({block numblock} (send _ :define_method _) ...)
+          (any_block (send _ :define_method _) ...)
         PATTERN
       end
     end

data/lib/rubocop/cop/style/yoda_expression.rb

@@ -72,7 +72,7 @@ module RuboCop
         end
 
         def constant_portion?(node)
-          node.numeric_type? || node.const_type?
+          node.type?(:numeric, :const)
         end
 
         def supported_operators

data/lib/rubocop/cop/util.rb

@@ -74,9 +74,9 @@ module RuboCop
 
       def args_begin(node)
         loc = node.loc
-        selector = if node.super_type? || node.yield_type?
+        selector = if node.type?(:super, :yield)
                      loc.keyword
-                   elsif node.def_type? || node.defs_type?
+                   elsif node.type?(:def, :defs)
                      loc.name
                    else
                      loc.selector

data/lib/rubocop/cop/variable_force/variable.rb

@@ -72,7 +72,7 @@ module RuboCop
           parent = parent.parent if parent&.begin_type?
           return false if parent.nil?
 
-          (parent.if_type? || parent.while_type? || parent.until_type?) && parent.modifier_form?
+          parent.type?(:if, :while, :until) && parent.modifier_form?
         end
 
         def capture_with_block!

data/lib/rubocop/cop/variable_force/variable_table.rb

@@ -100,7 +100,7 @@ module RuboCop
 
             # Only block scope allows referencing outer scope variables.
             node = scope.node
-            return nil unless node.block_type? || node.numblock_type?
+            return nil unless node.any_block_type?
           end
 
           nil
@@ -113,14 +113,14 @@ module RuboCop
         def accessible_variables
           scope_stack.reverse_each.with_object([]) do |scope, variables|
             variables.concat(scope.variables.values)
-            break variables unless scope.node.block_type? || scope.node.numblock_type?
+            break variables unless scope.node.any_block_type?
           end
         end
 
         private
 
         def mark_variable_as_captured_by_block_if_so(variable)
-          return unless current_scope.node.block_type? || current_scope.node.numblock_type?
+          return unless current_scope.node.any_block_type?
           return if variable.scope == current_scope
 
           variable.capture_with_block!

data/lib/rubocop/rspec/support.rb

@@ -4,13 +4,12 @@
 
 require_relative 'cop_helper'
 require_relative 'expect_offense'
-require_relative 'host_environment_simulation_helper'
 require_relative 'parallel_formatter'
 require_relative 'shared_contexts'
 
 RSpec.configure do |config|
   config.include CopHelper
-  config.include HostEnvironmentSimulatorHelper
+  config.include RuboCop::RSpec::ExpectOffense
   config.include_context 'config', :config
   config.include_context 'isolated environment', :isolated_environment
   config.include_context 'isolated bundler', :isolated_bundler

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '1.71.0'
+    STRING = '1.71.1'
 
     MSG = '%<version>s (using %<parser_version>s, ' \
           'rubocop-ast %<rubocop_ast_version>s, ' \

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 1.71.0
+  version: 1.71.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -9,7 +9,7 @@ authors:
 - Yuji Nakayama
 bindir: exe
 cert_chain: []
-date: 2025-01-22 00:00:00.000000000 Z
+date: 2025-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -113,7 +113,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.36.2
+        version: 1.38.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -123,7 +123,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.36.2
+        version: 1.38.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -279,6 +279,10 @@ files:
 - lib/rubocop/cop/internal_affairs/node_destructuring.rb
 - lib/rubocop/cop/internal_affairs/node_first_or_last_argument.rb
 - lib/rubocop/cop/internal_affairs/node_matcher_directive.rb
+- lib/rubocop/cop/internal_affairs/node_pattern_groups.rb
+- lib/rubocop/cop/internal_affairs/node_pattern_groups/ast_processor.rb
+- lib/rubocop/cop/internal_affairs/node_pattern_groups/ast_walker.rb
+- lib/rubocop/cop/internal_affairs/node_type_multiple_predicates.rb
 - lib/rubocop/cop/internal_affairs/node_type_predicate.rb
 - lib/rubocop/cop/internal_affairs/numblock_handler.rb
 - lib/rubocop/cop/internal_affairs/offense_location_keyword.rb
@@ -1009,7 +1013,6 @@ files:
 - lib/rubocop/result_cache.rb
 - lib/rubocop/rspec/cop_helper.rb
 - lib/rubocop/rspec/expect_offense.rb
-- lib/rubocop/rspec/host_environment_simulation_helper.rb
 - lib/rubocop/rspec/parallel_formatter.rb
 - lib/rubocop/rspec/shared_contexts.rb
 - lib/rubocop/rspec/support.rb
@@ -1046,7 +1049,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://rubocop.org/
-  changelog_uri: https://github.com/rubocop/rubocop/releases/tag/v1.71.0
+  changelog_uri: https://github.com/rubocop/rubocop/releases/tag/v1.71.1
   source_code_uri: https://github.com/rubocop/rubocop/
   documentation_uri: https://docs.rubocop.org/rubocop/1.71/
   bug_tracker_uri: https://github.com/rubocop/rubocop/issues

data/lib/rubocop/rspec/host_environment_simulation_helper.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-# RuboCop can be run in contexts where unexpected other libraries are included,
-# which may interfere with its normal behavior. In order to test those
-# situations, it may be necessary to require another library for the duration
-# of one spec
-module HostEnvironmentSimulatorHelper
-  def in_its_own_process_with(*files)
-    if ::Process.respond_to?(:fork)
-      pid = ::Process.fork do
-        # Need to write coverage result under different name
-        if defined?(SimpleCov)
-          SimpleCov.command_name "rspec-fork-#{Process.pid}"
-          SimpleCov.pid = Process.pid
-        end
-
-        files.each { |file| require file }
-        yield
-      end
-      ::Process.wait(pid)
-
-      # assert that the block did not fail
-      expect($CHILD_STATUS).to be_success
-    else
-      warn 'Process.fork is not available.'
-    end
-  end
-end