rubocop 1.69.2 → 1.75.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (372) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +4 -4
  4. data/config/default.yml +183 -41
  5. data/config/internal_affairs.yml +20 -0
  6. data/config/obsoletion.yml +3 -1
  7. data/lib/rubocop/cli/command/execute_runner.rb +3 -3
  8. data/lib/rubocop/cli/command/show_cops.rb +24 -2
  9. data/lib/rubocop/cli/command/suggest_extensions.rb +7 -1
  10. data/lib/rubocop/cli.rb +1 -1
  11. data/lib/rubocop/comment_config.rb +2 -2
  12. data/lib/rubocop/config.rb +52 -10
  13. data/lib/rubocop/config_loader.rb +52 -9
  14. data/lib/rubocop/config_loader_resolver.rb +36 -10
  15. data/lib/rubocop/config_obsoletion/extracted_cop.rb +4 -3
  16. data/lib/rubocop/config_obsoletion/renamed_cop.rb +18 -3
  17. data/lib/rubocop/config_obsoletion.rb +46 -2
  18. data/lib/rubocop/config_validator.rb +25 -14
  19. data/lib/rubocop/cop/autocorrect_logic.rb +1 -1
  20. data/lib/rubocop/cop/base.rb +6 -0
  21. data/lib/rubocop/cop/bundler/duplicated_gem.rb +1 -1
  22. data/lib/rubocop/cop/bundler/gem_comment.rb +1 -1
  23. data/lib/rubocop/cop/internal_affairs/cop_enabled.rb +85 -0
  24. data/lib/rubocop/cop/internal_affairs/example_description.rb +8 -4
  25. data/lib/rubocop/cop/internal_affairs/location_exists.rb +116 -0
  26. data/lib/rubocop/cop/internal_affairs/location_expression.rb +2 -1
  27. data/lib/rubocop/cop/internal_affairs/node_first_or_last_argument.rb +3 -2
  28. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -1
  29. data/lib/rubocop/cop/internal_affairs/node_pattern_groups/ast_processor.rb +63 -0
  30. data/lib/rubocop/cop/internal_affairs/node_pattern_groups/ast_walker.rb +131 -0
  31. data/lib/rubocop/cop/internal_affairs/node_pattern_groups.rb +230 -0
  32. data/lib/rubocop/cop/internal_affairs/node_type_group.rb +91 -0
  33. data/lib/rubocop/cop/internal_affairs/node_type_multiple_predicates.rb +126 -0
  34. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +4 -3
  35. data/lib/rubocop/cop/internal_affairs/on_send_without_on_csend.rb +90 -0
  36. data/lib/rubocop/cop/internal_affairs/plugin.rb +33 -0
  37. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +6 -5
  38. data/lib/rubocop/cop/internal_affairs/redundant_source_range.rb +3 -1
  39. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +5 -4
  40. data/lib/rubocop/cop/internal_affairs/undefined_config.rb +13 -2
  41. data/lib/rubocop/cop/internal_affairs.rb +6 -16
  42. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +1 -1
  43. data/lib/rubocop/cop/layout/argument_alignment.rb +2 -8
  44. data/lib/rubocop/cop/layout/block_alignment.rb +3 -1
  45. data/lib/rubocop/cop/layout/block_end_newline.rb +1 -0
  46. data/lib/rubocop/cop/layout/class_structure.rb +9 -9
  47. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +4 -4
  48. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  49. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  50. data/lib/rubocop/cop/layout/else_alignment.rb +2 -2
  51. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +2 -2
  52. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +7 -11
  53. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +28 -1
  54. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +1 -0
  55. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  56. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +22 -2
  57. data/lib/rubocop/cop/layout/end_alignment.rb +1 -1
  58. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  59. data/lib/rubocop/cop/layout/first_argument_indentation.rb +3 -8
  60. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +2 -7
  61. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +2 -7
  62. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  63. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
  64. data/lib/rubocop/cop/layout/hash_alignment.rb +7 -5
  65. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -1
  66. data/lib/rubocop/cop/layout/indentation_width.rb +1 -0
  67. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +7 -1
  68. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +2 -2
  69. data/lib/rubocop/cop/layout/line_length.rb +9 -4
  70. data/lib/rubocop/cop/layout/multiline_block_layout.rb +1 -0
  71. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  72. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +25 -0
  73. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -0
  74. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +4 -4
  75. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +1 -0
  76. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +1 -1
  77. data/lib/rubocop/cop/layout/redundant_line_break.rb +16 -11
  78. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +3 -5
  79. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  80. data/lib/rubocop/cop/layout/space_after_colon.rb +2 -2
  81. data/lib/rubocop/cop/layout/space_after_comma.rb +1 -1
  82. data/lib/rubocop/cop/layout/space_after_method_name.rb +1 -1
  83. data/lib/rubocop/cop/layout/space_after_semicolon.rb +1 -1
  84. data/lib/rubocop/cop/layout/space_around_keyword.rb +1 -0
  85. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +1 -1
  86. data/lib/rubocop/cop/layout/space_around_operators.rb +7 -4
  87. data/lib/rubocop/cop/layout/space_before_block_braces.rb +1 -0
  88. data/lib/rubocop/cop/layout/space_before_comma.rb +1 -1
  89. data/lib/rubocop/cop/layout/space_before_semicolon.rb +1 -1
  90. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +1 -0
  91. data/lib/rubocop/cop/layout/trailing_whitespace.rb +5 -3
  92. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +1 -1
  93. data/lib/rubocop/cop/lint/array_literal_in_regexp.rb +119 -0
  94. data/lib/rubocop/cop/lint/assignment_in_condition.rb +1 -3
  95. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  96. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  97. data/lib/rubocop/cop/lint/circular_argument_reference.rb +2 -5
  98. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +3 -3
  99. data/lib/rubocop/cop/lint/constant_reassignment.rb +148 -0
  100. data/lib/rubocop/cop/lint/cop_directive_syntax.rb +84 -0
  101. data/lib/rubocop/cop/lint/debugger.rb +3 -3
  102. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +1 -1
  103. data/lib/rubocop/cop/lint/duplicate_match_pattern.rb +1 -1
  104. data/lib/rubocop/cop/lint/duplicate_methods.rb +2 -17
  105. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  106. data/lib/rubocop/cop/lint/duplicate_set_element.rb +20 -7
  107. data/lib/rubocop/cop/lint/empty_conditional_body.rb +14 -64
  108. data/lib/rubocop/cop/lint/empty_expression.rb +0 -2
  109. data/lib/rubocop/cop/lint/erb_new_arguments.rb +0 -6
  110. data/lib/rubocop/cop/lint/float_comparison.rb +6 -8
  111. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  112. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +2 -2
  113. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  114. data/lib/rubocop/cop/lint/literal_as_condition.rb +117 -9
  115. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +24 -6
  116. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  117. data/lib/rubocop/cop/lint/missing_super.rb +2 -2
  118. data/lib/rubocop/cop/lint/mixed_case_range.rb +3 -3
  119. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -1
  120. data/lib/rubocop/cop/lint/nested_method_definition.rb +9 -5
  121. data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
  122. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +4 -3
  123. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +3 -3
  124. data/lib/rubocop/cop/lint/numeric_operation_with_constant_result.rb +18 -31
  125. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +1 -1
  126. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +2 -1
  127. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -5
  128. data/lib/rubocop/cop/lint/raise_exception.rb +29 -10
  129. data/lib/rubocop/cop/lint/redundant_regexp_quantifiers.rb +1 -1
  130. data/lib/rubocop/cop/lint/redundant_require_statement.rb +0 -21
  131. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +2 -2
  132. data/lib/rubocop/cop/lint/redundant_type_conversion.rb +261 -0
  133. data/lib/rubocop/cop/lint/redundant_with_index.rb +3 -0
  134. data/lib/rubocop/cop/lint/redundant_with_object.rb +3 -0
  135. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  136. data/lib/rubocop/cop/lint/return_in_void_context.rb +9 -11
  137. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +8 -1
  138. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +8 -1
  139. data/lib/rubocop/cop/lint/shared_mutable_default.rb +76 -0
  140. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  141. data/lib/rubocop/cop/lint/suppressed_exception_in_number_conversion.rb +111 -0
  142. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  143. data/lib/rubocop/cop/lint/syntax.rb +4 -1
  144. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  145. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  146. data/lib/rubocop/cop/lint/unescaped_bracket_in_regexp.rb +1 -4
  147. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +3 -1
  148. data/lib/rubocop/cop/lint/unmodified_reduce_accumulator.rb +1 -1
  149. data/lib/rubocop/cop/lint/unreachable_code.rb +2 -1
  150. data/lib/rubocop/cop/lint/unreachable_loop.rb +6 -6
  151. data/lib/rubocop/cop/lint/useless_access_modifier.rb +5 -4
  152. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  153. data/lib/rubocop/cop/lint/useless_constant_scoping.rb +71 -0
  154. data/lib/rubocop/cop/lint/useless_method_definition.rb +1 -1
  155. data/lib/rubocop/cop/lint/useless_numeric_operation.rb +2 -1
  156. data/lib/rubocop/cop/lint/useless_rescue.rb +1 -1
  157. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +2 -2
  158. data/lib/rubocop/cop/lint/void.rb +12 -9
  159. data/lib/rubocop/cop/message_annotator.rb +7 -3
  160. data/lib/rubocop/cop/metrics/block_length.rb +1 -0
  161. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  162. data/lib/rubocop/cop/metrics/collection_literal_length.rb +7 -0
  163. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -1
  164. data/lib/rubocop/cop/metrics/method_length.rb +9 -1
  165. data/lib/rubocop/cop/metrics/module_length.rb +1 -1
  166. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -1
  167. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -1
  168. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +7 -7
  169. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  170. data/lib/rubocop/cop/mixin/allowed_pattern.rb +4 -4
  171. data/lib/rubocop/cop/mixin/check_line_breakable.rb +13 -13
  172. data/lib/rubocop/cop/mixin/check_single_line_suitability.rb +2 -2
  173. data/lib/rubocop/cop/mixin/comments_help.rb +4 -2
  174. data/lib/rubocop/cop/mixin/def_node.rb +1 -1
  175. data/lib/rubocop/cop/mixin/dig_help.rb +1 -1
  176. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +1 -1
  177. data/lib/rubocop/cop/mixin/forbidden_identifiers.rb +20 -0
  178. data/lib/rubocop/cop/mixin/forbidden_pattern.rb +16 -0
  179. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +0 -1
  180. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +22 -22
  181. data/lib/rubocop/cop/mixin/hash_subset.rb +203 -0
  182. data/lib/rubocop/cop/mixin/hash_transform_method.rb +74 -74
  183. data/lib/rubocop/cop/mixin/method_complexity.rb +2 -1
  184. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +2 -0
  185. data/lib/rubocop/cop/mixin/percent_literal.rb +1 -1
  186. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +48 -24
  187. data/lib/rubocop/cop/mixin/range_help.rb +15 -3
  188. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  189. data/lib/rubocop/cop/mixin/statement_modifier.rb +8 -3
  190. data/lib/rubocop/cop/mixin/string_help.rb +2 -2
  191. data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
  192. data/lib/rubocop/cop/mixin/target_ruby_version.rb +1 -1
  193. data/lib/rubocop/cop/mixin/trailing_comma.rb +16 -4
  194. data/lib/rubocop/cop/naming/block_forwarding.rb +19 -15
  195. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  196. data/lib/rubocop/cop/naming/method_name.rb +64 -8
  197. data/lib/rubocop/cop/naming/predicate_name.rb +44 -0
  198. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +3 -3
  199. data/lib/rubocop/cop/naming/variable_name.rb +51 -6
  200. data/lib/rubocop/cop/registry.rb +9 -6
  201. data/lib/rubocop/cop/security/compound_hash.rb +1 -0
  202. data/lib/rubocop/cop/style/access_modifier_declarations.rb +34 -5
  203. data/lib/rubocop/cop/style/accessor_grouping.rb +19 -5
  204. data/lib/rubocop/cop/style/and_or.rb +1 -1
  205. data/lib/rubocop/cop/style/arguments_forwarding.rb +44 -28
  206. data/lib/rubocop/cop/style/array_first_last.rb +18 -2
  207. data/lib/rubocop/cop/style/array_intersect.rb +39 -28
  208. data/lib/rubocop/cop/style/block_delimiters.rb +9 -21
  209. data/lib/rubocop/cop/style/class_and_module_children.rb +52 -11
  210. data/lib/rubocop/cop/style/class_equality_comparison.rb +1 -1
  211. data/lib/rubocop/cop/style/collection_methods.rb +2 -1
  212. data/lib/rubocop/cop/style/combinable_defined.rb +1 -1
  213. data/lib/rubocop/cop/style/combinable_loops.rb +3 -2
  214. data/lib/rubocop/cop/style/commented_keyword.rb +12 -5
  215. data/lib/rubocop/cop/style/comparable_between.rb +75 -0
  216. data/lib/rubocop/cop/style/concat_array_literals.rb +1 -1
  217. data/lib/rubocop/cop/style/conditional_assignment.rb +20 -6
  218. data/lib/rubocop/cop/style/documentation.rb +1 -1
  219. data/lib/rubocop/cop/style/double_negation.rb +4 -4
  220. data/lib/rubocop/cop/style/each_for_simple_loop.rb +4 -7
  221. data/lib/rubocop/cop/style/each_with_object.rb +2 -3
  222. data/lib/rubocop/cop/style/empty_else.rb +4 -2
  223. data/lib/rubocop/cop/style/empty_literal.rb +5 -1
  224. data/lib/rubocop/cop/style/empty_method.rb +1 -1
  225. data/lib/rubocop/cop/style/endless_method.rb +163 -18
  226. data/lib/rubocop/cop/style/eval_with_location.rb +4 -4
  227. data/lib/rubocop/cop/style/exact_regexp_match.rb +3 -10
  228. data/lib/rubocop/cop/style/expand_path_arguments.rb +2 -7
  229. data/lib/rubocop/cop/style/explicit_block_argument.rb +16 -3
  230. data/lib/rubocop/cop/style/exponential_notation.rb +3 -3
  231. data/lib/rubocop/cop/style/fetch_env_var.rb +1 -1
  232. data/lib/rubocop/cop/style/float_division.rb +8 -4
  233. data/lib/rubocop/cop/style/for.rb +1 -0
  234. data/lib/rubocop/cop/style/format_string_token.rb +38 -11
  235. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +3 -2
  236. data/lib/rubocop/cop/style/global_std_stream.rb +3 -0
  237. data/lib/rubocop/cop/style/guard_clause.rb +2 -1
  238. data/lib/rubocop/cop/style/hash_each_methods.rb +6 -8
  239. data/lib/rubocop/cop/style/hash_except.rb +24 -148
  240. data/lib/rubocop/cop/style/hash_fetch_chain.rb +104 -0
  241. data/lib/rubocop/cop/style/hash_slice.rb +80 -0
  242. data/lib/rubocop/cop/style/hash_syntax.rb +9 -3
  243. data/lib/rubocop/cop/style/hash_transform_keys.rb +2 -2
  244. data/lib/rubocop/cop/style/hash_transform_values.rb +2 -2
  245. data/lib/rubocop/cop/style/identical_conditional_branches.rb +22 -3
  246. data/lib/rubocop/cop/style/if_inside_else.rb +10 -13
  247. data/lib/rubocop/cop/style/if_unless_modifier.rb +5 -5
  248. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +2 -2
  249. data/lib/rubocop/cop/style/if_with_semicolon.rb +2 -2
  250. data/lib/rubocop/cop/style/infinite_loop.rb +1 -1
  251. data/lib/rubocop/cop/style/inverse_methods.rb +15 -11
  252. data/lib/rubocop/cop/style/invertible_unless_condition.rb +2 -2
  253. data/lib/rubocop/cop/style/ip_addresses.rb +2 -2
  254. data/lib/rubocop/cop/style/it_assignment.rb +36 -0
  255. data/lib/rubocop/cop/style/it_block_parameter.rb +100 -0
  256. data/lib/rubocop/cop/style/keyword_parameters_order.rb +14 -8
  257. data/lib/rubocop/cop/style/lambda.rb +1 -0
  258. data/lib/rubocop/cop/style/lambda_call.rb +7 -2
  259. data/lib/rubocop/cop/style/line_end_concatenation.rb +10 -4
  260. data/lib/rubocop/cop/style/map_into_array.rb +5 -2
  261. data/lib/rubocop/cop/style/map_to_hash.rb +1 -1
  262. data/lib/rubocop/cop/style/map_to_set.rb +3 -2
  263. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +23 -16
  264. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -0
  265. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +2 -1
  266. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +3 -4
  267. data/lib/rubocop/cop/style/method_def_parentheses.rb +1 -1
  268. data/lib/rubocop/cop/style/missing_else.rb +2 -0
  269. data/lib/rubocop/cop/style/multiline_block_chain.rb +3 -2
  270. data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -9
  271. data/lib/rubocop/cop/style/multiple_comparison.rb +26 -20
  272. data/lib/rubocop/cop/style/mutable_constant.rb +3 -3
  273. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  274. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +1 -1
  275. data/lib/rubocop/cop/style/next.rb +44 -0
  276. data/lib/rubocop/cop/style/object_then.rb +14 -15
  277. data/lib/rubocop/cop/style/open_struct_use.rb +5 -5
  278. data/lib/rubocop/cop/style/parallel_assignment.rb +1 -5
  279. data/lib/rubocop/cop/style/parentheses_around_condition.rb +2 -2
  280. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  281. data/lib/rubocop/cop/style/proc.rb +2 -2
  282. data/lib/rubocop/cop/style/quoted_symbols.rb +1 -1
  283. data/lib/rubocop/cop/style/raise_args.rb +14 -12
  284. data/lib/rubocop/cop/style/random_with_offset.rb +3 -3
  285. data/lib/rubocop/cop/style/redundant_begin.rb +2 -1
  286. data/lib/rubocop/cop/style/redundant_condition.rb +59 -2
  287. data/lib/rubocop/cop/style/redundant_current_directory_in_path.rb +16 -5
  288. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +6 -10
  289. data/lib/rubocop/cop/style/redundant_each.rb +1 -1
  290. data/lib/rubocop/cop/style/redundant_exception.rb +2 -2
  291. data/lib/rubocop/cop/style/redundant_format.rb +257 -0
  292. data/lib/rubocop/cop/style/redundant_freeze.rb +3 -3
  293. data/lib/rubocop/cop/style/redundant_initialize.rb +12 -3
  294. data/lib/rubocop/cop/style/redundant_line_continuation.rb +34 -16
  295. data/lib/rubocop/cop/style/redundant_parentheses.rb +48 -16
  296. data/lib/rubocop/cop/style/redundant_regexp_argument.rb +3 -0
  297. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +1 -1
  298. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +1 -1
  299. data/lib/rubocop/cop/style/redundant_self.rb +1 -0
  300. data/lib/rubocop/cop/style/redundant_self_assignment.rb +14 -28
  301. data/lib/rubocop/cop/style/redundant_sort.rb +2 -2
  302. data/lib/rubocop/cop/style/redundant_sort_by.rb +17 -1
  303. data/lib/rubocop/cop/style/redundant_string_escape.rb +2 -2
  304. data/lib/rubocop/cop/style/rescue_modifier.rb +3 -0
  305. data/lib/rubocop/cop/style/return_nil.rb +2 -2
  306. data/lib/rubocop/cop/style/safe_navigation.rb +20 -5
  307. data/lib/rubocop/cop/style/select_by_regexp.rb +4 -1
  308. data/lib/rubocop/cop/style/semicolon.rb +1 -1
  309. data/lib/rubocop/cop/style/send_with_literal_method_name.rb +2 -1
  310. data/lib/rubocop/cop/style/single_line_block_params.rb +1 -1
  311. data/lib/rubocop/cop/style/single_line_do_end_block.rb +4 -3
  312. data/lib/rubocop/cop/style/single_line_methods.rb +6 -7
  313. data/lib/rubocop/cop/style/slicing_with_range.rb +40 -11
  314. data/lib/rubocop/cop/style/sole_nested_conditional.rb +41 -106
  315. data/lib/rubocop/cop/style/string_concatenation.rb +2 -2
  316. data/lib/rubocop/cop/style/string_literals.rb +1 -1
  317. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  318. data/lib/rubocop/cop/style/super_arguments.rb +66 -19
  319. data/lib/rubocop/cop/style/symbol_proc.rb +2 -0
  320. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -1
  321. data/lib/rubocop/cop/style/top_level_method_definition.rb +2 -1
  322. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +11 -2
  323. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +47 -6
  324. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +48 -6
  325. data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
  326. data/lib/rubocop/cop/style/while_until_modifier.rb +0 -1
  327. data/lib/rubocop/cop/style/yoda_condition.rb +8 -4
  328. data/lib/rubocop/cop/style/yoda_expression.rb +2 -1
  329. data/lib/rubocop/cop/util.rb +12 -5
  330. data/lib/rubocop/cop/utils/format_string.rb +10 -5
  331. data/lib/rubocop/cop/variable_force/scope.rb +1 -1
  332. data/lib/rubocop/cop/variable_force/variable.rb +10 -3
  333. data/lib/rubocop/cop/variable_force/variable_table.rb +3 -3
  334. data/lib/rubocop/cop/variable_force.rb +1 -1
  335. data/lib/rubocop/cops_documentation_generator.rb +31 -16
  336. data/lib/rubocop/directive_comment.rb +45 -11
  337. data/lib/rubocop/ext/regexp_node.rb +0 -1
  338. data/lib/rubocop/formatter/disabled_config_formatter.rb +1 -1
  339. data/lib/rubocop/formatter/formatter_set.rb +1 -1
  340. data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
  341. data/lib/rubocop/lsp/diagnostic.rb +189 -0
  342. data/lib/rubocop/lsp/logger.rb +2 -2
  343. data/lib/rubocop/lsp/routes.rb +7 -23
  344. data/lib/rubocop/lsp/runtime.rb +18 -50
  345. data/lib/rubocop/lsp/server.rb +0 -2
  346. data/lib/rubocop/lsp/stdin_runner.rb +85 -0
  347. data/lib/rubocop/magic_comment.rb +8 -0
  348. data/lib/rubocop/options.rb +28 -12
  349. data/lib/rubocop/path_util.rb +15 -8
  350. data/lib/rubocop/plugin/configuration_integrator.rb +143 -0
  351. data/lib/rubocop/plugin/load_error.rb +26 -0
  352. data/lib/rubocop/plugin/loader.rb +100 -0
  353. data/lib/rubocop/plugin/not_supported_error.rb +29 -0
  354. data/lib/rubocop/plugin.rb +46 -0
  355. data/lib/rubocop/rake_task.rb +4 -1
  356. data/lib/rubocop/result_cache.rb +13 -13
  357. data/lib/rubocop/rspec/cop_helper.rb +13 -1
  358. data/lib/rubocop/rspec/expect_offense.rb +6 -2
  359. data/lib/rubocop/rspec/shared_contexts.rb +38 -1
  360. data/lib/rubocop/rspec/support.rb +4 -2
  361. data/lib/rubocop/runner.rb +10 -7
  362. data/lib/rubocop/server/cache.rb +47 -11
  363. data/lib/rubocop/server/cli.rb +2 -2
  364. data/lib/rubocop/target_finder.rb +7 -2
  365. data/lib/rubocop/target_ruby.rb +16 -1
  366. data/lib/rubocop/version.rb +30 -8
  367. data/lib/rubocop.rb +16 -1
  368. data/lib/ruby_lsp/rubocop/addon.rb +75 -0
  369. data/lib/ruby_lsp/rubocop/runtime_adapter.rb +65 -0
  370. metadata +59 -16
  371. data/lib/rubocop/cop/utils/regexp_ranges.rb +0 -113
  372. data/lib/rubocop/rspec/host_environment_simulation_helper.rb +0 -28
@@ -1,113 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module Cop
5
- module Utils
6
- # Helper to abstract complexity of building range pairs
7
- # with octal escape reconstruction (needed for regexp_parser < 2.7).
8
- class RegexpRanges
9
- attr_reader :root
10
-
11
- def initialize(root)
12
- @root = root
13
- @compound_token = []
14
- @pairs = []
15
- @populated = false
16
- end
17
-
18
- def compound_token
19
- populate_all unless @populated
20
-
21
- @compound_token
22
- end
23
-
24
- def pairs
25
- populate_all unless @populated
26
-
27
- @pairs
28
- end
29
-
30
- private
31
-
32
- def populate_all
33
- populate(@root)
34
-
35
- # If either bound is a compound the first one is an escape
36
- # and that's all we need to work with.
37
- # If there are any cops that wanted to operate on the compound
38
- # expression we could wrap it with a facade class.
39
- @pairs.map! { |pair| pair.map(&:first) }
40
-
41
- @populated = true
42
- end
43
-
44
- def populate(expr)
45
- expressions = expr.expressions.to_a
46
-
47
- until expressions.empty?
48
- current = expressions.shift
49
-
50
- if escaped_octal?(current)
51
- @compound_token << current
52
- @compound_token.concat(pop_octal_digits(expressions))
53
- # If we have all the digits we can discard.
54
- end
55
-
56
- next unless current.type == :set
57
-
58
- process_set(expressions, current)
59
- @compound_token.clear
60
- end
61
- end
62
-
63
- def process_set(expressions, current)
64
- case current.token
65
- when :range
66
- @pairs << compose_range(expressions, current)
67
- when :character
68
- # Child expressions may include the range we are looking for.
69
- populate(current)
70
- when :intersection
71
- # Each child expression could have child expressions that lead to ranges.
72
- current.expressions.each do |intersected|
73
- populate(intersected)
74
- end
75
- end
76
- end
77
-
78
- def compose_range(expressions, current)
79
- range_start, range_end = current.expressions
80
- range_start = if @compound_token.size.between?(1, 2) && octal_digit?(range_start.text)
81
- @compound_token.dup << range_start
82
- else
83
- [range_start]
84
- end
85
- range_end = [range_end]
86
- range_end.concat(pop_octal_digits(expressions)) if escaped_octal?(range_end.first)
87
- [range_start, range_end]
88
- end
89
-
90
- def escaped_octal?(expr)
91
- expr.text.valid_encoding? && expr.text =~ /^\\[0-7]$/
92
- end
93
-
94
- def octal_digit?(char)
95
- ('0'..'7').cover?(char)
96
- end
97
-
98
- def pop_octal_digits(expressions)
99
- digits = []
100
-
101
- 2.times do
102
- next unless (next_child = expressions.first)
103
- next unless next_child.type == :literal && next_child.text =~ /^[0-7]$/
104
-
105
- digits << expressions.shift
106
- end
107
-
108
- digits
109
- end
110
- end
111
- end
112
- end
113
- end
@@ -1,28 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- # RuboCop can be run in contexts where unexpected other libraries are included,
4
- # which may interfere with its normal behavior. In order to test those
5
- # situations, it may be necessary to require another library for the duration
6
- # of one spec
7
- module HostEnvironmentSimulatorHelper
8
- def in_its_own_process_with(*files)
9
- if ::Process.respond_to?(:fork)
10
- pid = ::Process.fork do
11
- # Need to write coverage result under different name
12
- if defined?(SimpleCov)
13
- SimpleCov.command_name "rspec-fork-#{Process.pid}"
14
- SimpleCov.pid = Process.pid
15
- end
16
-
17
- files.each { |file| require file }
18
- yield
19
- end
20
- ::Process.wait(pid)
21
-
22
- # assert that the block did not fail
23
- expect($CHILD_STATUS).to be_success
24
- else
25
- warn 'Process.fork is not available.'
26
- end
27
- end
28
- end