rubocop 1.29.1 → 1.46.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (633) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +6 -4
  4. data/config/default.yml +335 -52
  5. data/config/obsoletion.yml +25 -1
  6. data/exe/rubocop +15 -7
  7. data/lib/rubocop/arguments_env.rb +17 -0
  8. data/lib/rubocop/arguments_file.rb +17 -0
  9. data/lib/rubocop/cache_config.rb +29 -0
  10. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +20 -5
  11. data/lib/rubocop/cli/command/execute_runner.rb +8 -8
  12. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  13. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  14. data/lib/rubocop/cli/command/suggest_extensions.rb +61 -16
  15. data/lib/rubocop/cli.rb +57 -9
  16. data/lib/rubocop/comment_config.rb +58 -1
  17. data/lib/rubocop/config.rb +45 -17
  18. data/lib/rubocop/config_finder.rb +68 -0
  19. data/lib/rubocop/config_loader.rb +41 -61
  20. data/lib/rubocop/config_loader_resolver.rb +11 -12
  21. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  22. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  23. data/lib/rubocop/config_obsoletion.rb +7 -2
  24. data/lib/rubocop/config_validator.rb +22 -5
  25. data/lib/rubocop/cop/autocorrect_logic.rb +4 -2
  26. data/lib/rubocop/cop/badge.rb +9 -4
  27. data/lib/rubocop/cop/base.rb +114 -82
  28. data/lib/rubocop/cop/bundler/duplicated_gem.rb +1 -1
  29. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  30. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  31. data/lib/rubocop/cop/commissioner.rb +19 -6
  32. data/lib/rubocop/cop/cop.rb +52 -32
  33. data/lib/rubocop/cop/corrector.rb +32 -12
  34. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  35. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  36. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +1 -1
  37. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  38. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  39. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  40. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  41. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  42. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +25 -9
  43. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +2 -7
  44. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  45. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  46. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  47. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  48. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  49. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  50. data/lib/rubocop/cop/gemspec/dependency_version.rb +16 -18
  51. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  52. data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
  53. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +1 -1
  54. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
  55. data/lib/rubocop/cop/gemspec/require_mfa.rb +21 -21
  56. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  57. data/lib/rubocop/cop/generator.rb +6 -3
  58. data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
  59. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  60. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  61. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  62. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  63. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +1 -1
  64. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +1 -1
  65. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -5
  66. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  67. data/lib/rubocop/cop/internal_affairs/processed_source_buffer_name.rb +42 -0
  68. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  69. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +12 -4
  70. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  71. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  72. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  73. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  74. data/lib/rubocop/cop/internal_affairs.rb +8 -0
  75. data/lib/rubocop/cop/layout/argument_alignment.rb +22 -1
  76. data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
  77. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  78. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  79. data/lib/rubocop/cop/layout/block_alignment.rb +17 -13
  80. data/lib/rubocop/cop/layout/block_end_newline.rb +42 -6
  81. data/lib/rubocop/cop/layout/case_indentation.rb +1 -1
  82. data/lib/rubocop/cop/layout/class_structure.rb +31 -24
  83. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +3 -7
  84. data/lib/rubocop/cop/layout/comment_indentation.rb +4 -2
  85. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  86. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  87. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  88. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  89. data/lib/rubocop/cop/layout/empty_comment.rb +2 -2
  90. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  91. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  92. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +1 -1
  93. data/lib/rubocop/cop/layout/empty_lines.rb +3 -1
  94. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +5 -2
  95. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  96. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  97. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  98. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  99. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  100. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  101. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  102. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  103. data/lib/rubocop/cop/layout/end_alignment.rb +5 -1
  104. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  105. data/lib/rubocop/cop/layout/extra_spacing.rb +10 -6
  106. data/lib/rubocop/cop/layout/first_argument_indentation.rb +36 -30
  107. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +21 -14
  108. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +39 -3
  109. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +52 -13
  110. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +50 -3
  111. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +62 -3
  112. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +53 -3
  113. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  114. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -0
  115. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +9 -3
  116. data/lib/rubocop/cop/layout/heredoc_indentation.rb +7 -10
  117. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  118. data/lib/rubocop/cop/layout/indentation_style.rb +8 -3
  119. data/lib/rubocop/cop/layout/indentation_width.rb +14 -7
  120. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  121. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  122. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  123. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
  124. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +140 -0
  125. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +1 -1
  126. data/lib/rubocop/cop/layout/line_length.rb +9 -2
  127. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  128. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +52 -3
  129. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  130. data/lib/rubocop/cop/layout/multiline_block_layout.rb +5 -3
  131. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  132. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +50 -3
  133. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +58 -4
  134. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  135. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +3 -3
  136. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  137. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
  138. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +3 -3
  139. data/lib/rubocop/cop/layout/redundant_line_break.rb +4 -4
  140. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +1 -1
  141. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  142. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  143. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  144. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
  145. data/lib/rubocop/cop/layout/space_around_operators.rb +2 -2
  146. data/lib/rubocop/cop/layout/space_before_block_braces.rb +5 -3
  147. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  148. data/lib/rubocop/cop/layout/space_before_first_arg.rb +1 -1
  149. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  150. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -30
  151. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
  152. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +33 -15
  153. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +30 -3
  154. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
  155. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +10 -6
  156. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +6 -5
  157. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +9 -9
  158. data/lib/rubocop/cop/layout/trailing_whitespace.rb +13 -6
  159. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  160. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  161. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  162. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +28 -8
  163. data/lib/rubocop/cop/lint/ambiguous_operator.rb +5 -1
  164. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  165. data/lib/rubocop/cop/lint/ambiguous_range.rb +3 -3
  166. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +1 -1
  167. data/lib/rubocop/cop/lint/assignment_in_condition.rb +12 -2
  168. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  169. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  170. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  171. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  172. data/lib/rubocop/cop/lint/constant_resolution.rb +4 -0
  173. data/lib/rubocop/cop/lint/debugger.rb +28 -32
  174. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +67 -111
  175. data/lib/rubocop/cop/lint/deprecated_constants.rb +9 -2
  176. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  177. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -3
  178. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  179. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  180. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  181. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  182. data/lib/rubocop/cop/lint/duplicate_methods.rb +48 -18
  183. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +26 -7
  184. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  185. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  186. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  187. data/lib/rubocop/cop/lint/else_layout.rb +5 -9
  188. data/lib/rubocop/cop/lint/empty_block.rb +3 -7
  189. data/lib/rubocop/cop/lint/empty_class.rb +4 -2
  190. data/lib/rubocop/cop/lint/empty_conditional_body.rb +109 -3
  191. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  192. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  193. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  194. data/lib/rubocop/cop/lint/empty_in_pattern.rb +1 -1
  195. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  196. data/lib/rubocop/cop/lint/empty_when.rb +1 -1
  197. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  198. data/lib/rubocop/cop/lint/erb_new_arguments.rb +9 -9
  199. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  200. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  201. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  202. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
  203. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +16 -18
  204. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
  205. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +1 -1
  206. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  207. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  208. data/lib/rubocop/cop/lint/interpolation_check.rb +6 -5
  209. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +2 -2
  210. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  211. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +5 -1
  212. data/lib/rubocop/cop/lint/loop.rb +1 -1
  213. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +19 -4
  214. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  215. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
  216. data/lib/rubocop/cop/lint/nested_method_definition.rb +52 -8
  217. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  218. data/lib/rubocop/cop/lint/next_without_accumulator.rb +25 -6
  219. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
  220. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +12 -0
  221. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  222. data/lib/rubocop/cop/lint/number_conversion.rb +32 -10
  223. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  224. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  225. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -5
  226. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +16 -1
  227. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +6 -1
  228. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  229. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  230. data/lib/rubocop/cop/lint/raise_exception.rb +1 -1
  231. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  232. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +51 -11
  233. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +3 -3
  234. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +7 -0
  235. data/lib/rubocop/cop/lint/redundant_require_statement.rb +48 -7
  236. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +16 -3
  237. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  238. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  239. data/lib/rubocop/cop/lint/redundant_with_index.rb +14 -11
  240. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  241. data/lib/rubocop/cop/lint/refinement_import_methods.rb +3 -2
  242. data/lib/rubocop/cop/lint/regexp_as_condition.rb +9 -3
  243. data/lib/rubocop/cop/lint/require_parentheses.rb +4 -2
  244. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  245. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  246. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -1
  247. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +44 -8
  248. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  249. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  250. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  251. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  252. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -4
  253. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  254. data/lib/rubocop/cop/lint/shadowed_exception.rb +16 -11
  255. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +29 -4
  256. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  257. data/lib/rubocop/cop/lint/suppressed_exception.rb +2 -2
  258. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  259. data/lib/rubocop/cop/lint/syntax.rb +1 -1
  260. data/lib/rubocop/cop/lint/to_enum_arguments.rb +7 -3
  261. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  262. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  263. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  264. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  265. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  266. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  267. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  268. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  269. data/lib/rubocop/cop/lint/unreachable_loop.rb +10 -4
  270. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  271. data/lib/rubocop/cop/lint/unused_method_argument.rb +7 -2
  272. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  273. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  274. data/lib/rubocop/cop/lint/useless_access_modifier.rb +9 -12
  275. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  276. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +44 -0
  277. data/lib/rubocop/cop/lint/useless_method_definition.rb +4 -4
  278. data/lib/rubocop/cop/lint/useless_rescue.rb +86 -0
  279. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +16 -6
  280. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  281. data/lib/rubocop/cop/lint/useless_times.rb +1 -1
  282. data/lib/rubocop/cop/lint/void.rb +27 -16
  283. data/lib/rubocop/cop/metrics/abc_size.rb +5 -3
  284. data/lib/rubocop/cop/metrics/block_length.rb +17 -12
  285. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  286. data/lib/rubocop/cop/metrics/class_length.rb +10 -5
  287. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -2
  288. data/lib/rubocop/cop/metrics/method_length.rb +18 -12
  289. data/lib/rubocop/cop/metrics/module_length.rb +10 -5
  290. data/lib/rubocop/cop/metrics/parameter_lists.rb +28 -1
  291. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  292. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +3 -6
  293. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +7 -4
  294. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  295. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
  296. data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
  297. data/lib/rubocop/cop/mixin/allowed_pattern.rb +17 -1
  298. data/lib/rubocop/cop/mixin/annotation_comment.rb +13 -6
  299. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  300. data/lib/rubocop/cop/mixin/comments_help.rb +22 -4
  301. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
  302. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  303. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
  304. data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
  305. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
  306. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +155 -12
  307. data/lib/rubocop/cop/mixin/hash_transform_method.rb +10 -6
  308. data/lib/rubocop/cop/mixin/line_length_help.rb +11 -2
  309. data/lib/rubocop/cop/mixin/method_complexity.rb +13 -16
  310. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
  311. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -6
  312. data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
  313. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
  314. data/lib/rubocop/cop/mixin/range_help.rb +33 -7
  315. data/lib/rubocop/cop/mixin/require_library.rb +2 -0
  316. data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
  317. data/lib/rubocop/cop/mixin/statement_modifier.rb +16 -1
  318. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  319. data/lib/rubocop/cop/mixin/surrounding_space.rb +13 -11
  320. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  321. data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
  322. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  323. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  324. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  325. data/lib/rubocop/cop/naming/block_forwarding.rb +7 -3
  326. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  327. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +4 -2
  328. data/lib/rubocop/cop/naming/constant_name.rb +3 -3
  329. data/lib/rubocop/cop/naming/file_name.rb +1 -1
  330. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  331. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  332. data/lib/rubocop/cop/naming/inclusive_language.rb +5 -2
  333. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  334. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  335. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  336. data/lib/rubocop/cop/naming/predicate_name.rb +30 -1
  337. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  338. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  339. data/lib/rubocop/cop/naming/variable_number.rb +18 -18
  340. data/lib/rubocop/cop/registry.rb +70 -44
  341. data/lib/rubocop/cop/security/compound_hash.rb +3 -2
  342. data/lib/rubocop/cop/security/eval.rb +1 -1
  343. data/lib/rubocop/cop/security/json_load.rb +1 -1
  344. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  345. data/lib/rubocop/cop/security/open.rb +1 -1
  346. data/lib/rubocop/cop/security/yaml_load.rb +1 -1
  347. data/lib/rubocop/cop/style/access_modifier_declarations.rb +92 -3
  348. data/lib/rubocop/cop/style/accessor_grouping.rb +23 -18
  349. data/lib/rubocop/cop/style/alias.rb +10 -2
  350. data/lib/rubocop/cop/style/and_or.rb +11 -11
  351. data/lib/rubocop/cop/style/arguments_forwarding.rb +4 -3
  352. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  353. data/lib/rubocop/cop/style/array_intersect.rb +111 -0
  354. data/lib/rubocop/cop/style/array_join.rb +1 -1
  355. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  356. data/lib/rubocop/cop/style/attr.rb +1 -1
  357. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  358. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  359. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  360. data/lib/rubocop/cop/style/block_comments.rb +2 -2
  361. data/lib/rubocop/cop/style/block_delimiters.rb +38 -11
  362. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  363. data/lib/rubocop/cop/style/case_like_if.rb +1 -1
  364. data/lib/rubocop/cop/style/character_literal.rb +1 -1
  365. data/lib/rubocop/cop/style/class_and_module_children.rb +8 -15
  366. data/lib/rubocop/cop/style/class_check.rb +1 -1
  367. data/lib/rubocop/cop/style/class_equality_comparison.rb +55 -6
  368. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  369. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  370. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  371. data/lib/rubocop/cop/style/collection_compact.rb +13 -4
  372. data/lib/rubocop/cop/style/collection_methods.rb +3 -1
  373. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  374. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  375. data/lib/rubocop/cop/style/combinable_loops.rb +4 -2
  376. data/lib/rubocop/cop/style/command_literal.rb +2 -2
  377. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  378. data/lib/rubocop/cop/style/commented_keyword.rb +4 -4
  379. data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
  380. data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
  381. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -7
  382. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  383. data/lib/rubocop/cop/style/date_time.rb +1 -1
  384. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -1
  385. data/lib/rubocop/cop/style/dir.rb +4 -1
  386. data/lib/rubocop/cop/style/documentation.rb +13 -7
  387. data/lib/rubocop/cop/style/documentation_method.rb +11 -5
  388. data/lib/rubocop/cop/style/double_negation.rb +3 -1
  389. data/lib/rubocop/cop/style/each_for_simple_loop.rb +42 -7
  390. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  391. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  392. data/lib/rubocop/cop/style/empty_case_condition.rb +1 -1
  393. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  394. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  395. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  396. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  397. data/lib/rubocop/cop/style/empty_method.rb +18 -3
  398. data/lib/rubocop/cop/style/encoding.rb +2 -2
  399. data/lib/rubocop/cop/style/end_block.rb +1 -1
  400. data/lib/rubocop/cop/style/endless_method.rb +2 -2
  401. data/lib/rubocop/cop/style/env_home.rb +1 -1
  402. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  403. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  404. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  405. data/lib/rubocop/cop/style/explicit_block_argument.rb +6 -2
  406. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  407. data/lib/rubocop/cop/style/fetch_env_var.rb +37 -224
  408. data/lib/rubocop/cop/style/float_division.rb +1 -1
  409. data/lib/rubocop/cop/style/for.rb +3 -1
  410. data/lib/rubocop/cop/style/format_string.rb +1 -1
  411. data/lib/rubocop/cop/style/format_string_token.rb +73 -23
  412. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +6 -3
  413. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  414. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  415. data/lib/rubocop/cop/style/guard_clause.rb +132 -43
  416. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
  417. data/lib/rubocop/cop/style/hash_conversion.rb +1 -1
  418. data/lib/rubocop/cop/style/hash_each_methods.rb +49 -13
  419. data/lib/rubocop/cop/style/hash_except.rb +89 -9
  420. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  421. data/lib/rubocop/cop/style/hash_syntax.rb +24 -3
  422. data/lib/rubocop/cop/style/hash_transform_keys.rb +6 -1
  423. data/lib/rubocop/cop/style/hash_transform_values.rb +4 -1
  424. data/lib/rubocop/cop/style/identical_conditional_branches.rb +17 -2
  425. data/lib/rubocop/cop/style/if_unless_modifier.rb +1 -1
  426. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +29 -4
  427. data/lib/rubocop/cop/style/if_with_semicolon.rb +4 -4
  428. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  429. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  430. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  431. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  432. data/lib/rubocop/cop/style/inverse_methods.rb +12 -8
  433. data/lib/rubocop/cop/style/invertible_unless_condition.rb +114 -0
  434. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  435. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  436. data/lib/rubocop/cop/style/lambda.rb +1 -1
  437. data/lib/rubocop/cop/style/lambda_call.rb +1 -1
  438. data/lib/rubocop/cop/style/line_end_concatenation.rb +6 -3
  439. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  440. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  441. data/lib/rubocop/cop/style/map_to_hash.rb +3 -3
  442. data/lib/rubocop/cop/style/map_to_set.rb +61 -0
  443. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +39 -19
  444. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +5 -1
  445. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +8 -8
  446. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +22 -3
  447. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  448. data/lib/rubocop/cop/style/method_def_parentheses.rb +12 -5
  449. data/lib/rubocop/cop/style/min_max.rb +1 -1
  450. data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
  451. data/lib/rubocop/cop/style/missing_else.rb +37 -25
  452. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  453. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  454. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  455. data/lib/rubocop/cop/style/module_function.rb +30 -8
  456. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  457. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
  458. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  459. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  460. data/lib/rubocop/cop/style/multiline_memoization.rb +3 -3
  461. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  462. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +21 -6
  463. data/lib/rubocop/cop/style/multiline_when_then.rb +2 -4
  464. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  465. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  466. data/lib/rubocop/cop/style/negated_if_else_condition.rb +9 -7
  467. data/lib/rubocop/cop/style/nested_file_dirname.rb +1 -1
  468. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  469. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  470. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  471. data/lib/rubocop/cop/style/next.rb +3 -5
  472. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  473. data/lib/rubocop/cop/style/nil_lambda.rb +4 -4
  474. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  475. data/lib/rubocop/cop/style/not.rb +2 -2
  476. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  477. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +12 -4
  478. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  479. data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
  480. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  481. data/lib/rubocop/cop/style/object_then.rb +6 -1
  482. data/lib/rubocop/cop/style/one_line_conditional.rb +4 -7
  483. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  484. data/lib/rubocop/cop/style/operator_method_call.rb +67 -0
  485. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  486. data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
  487. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +1 -1
  488. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  489. data/lib/rubocop/cop/style/parallel_assignment.rb +3 -1
  490. data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
  491. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  492. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  493. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  494. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  495. data/lib/rubocop/cop/style/proc.rb +5 -2
  496. data/lib/rubocop/cop/style/quoted_symbols.rb +1 -1
  497. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  498. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  499. data/lib/rubocop/cop/style/redundant_argument.rb +5 -2
  500. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  501. data/lib/rubocop/cop/style/redundant_begin.rb +20 -6
  502. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -1
  503. data/lib/rubocop/cop/style/redundant_condition.rb +48 -11
  504. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -5
  505. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  506. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +45 -0
  507. data/lib/rubocop/cop/style/redundant_each.rb +116 -0
  508. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  509. data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -2
  510. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  511. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  512. data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
  513. data/lib/rubocop/cop/style/redundant_initialize.rb +3 -1
  514. data/lib/rubocop/cop/style/redundant_interpolation.rb +22 -1
  515. data/lib/rubocop/cop/style/redundant_parentheses.rb +23 -25
  516. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  517. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +9 -3
  518. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +14 -4
  519. data/lib/rubocop/cop/style/redundant_return.rb +9 -2
  520. data/lib/rubocop/cop/style/redundant_self.rb +3 -1
  521. data/lib/rubocop/cop/style/redundant_self_assignment.rb +2 -2
  522. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  523. data/lib/rubocop/cop/style/redundant_sort.rb +23 -8
  524. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  525. data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
  526. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  527. data/lib/rubocop/cop/style/require_order.rb +135 -0
  528. data/lib/rubocop/cop/style/rescue_modifier.rb +2 -2
  529. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  530. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  531. data/lib/rubocop/cop/style/safe_navigation.rb +43 -9
  532. data/lib/rubocop/cop/style/sample.rb +1 -1
  533. data/lib/rubocop/cop/style/select_by_regexp.rb +14 -6
  534. data/lib/rubocop/cop/style/self_assignment.rb +3 -3
  535. data/lib/rubocop/cop/style/semicolon.rb +53 -6
  536. data/lib/rubocop/cop/style/send.rb +1 -1
  537. data/lib/rubocop/cop/style/signal_exception.rb +9 -7
  538. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  539. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  540. data/lib/rubocop/cop/style/slicing_with_range.rb +2 -2
  541. data/lib/rubocop/cop/style/sole_nested_conditional.rb +42 -14
  542. data/lib/rubocop/cop/style/static_class.rb +33 -2
  543. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  544. data/lib/rubocop/cop/style/string_concatenation.rb +6 -7
  545. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -2
  546. data/lib/rubocop/cop/style/string_literals.rb +1 -5
  547. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  548. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  549. data/lib/rubocop/cop/style/strip.rb +1 -1
  550. data/lib/rubocop/cop/style/struct_inheritance.rb +4 -4
  551. data/lib/rubocop/cop/style/swap_values.rb +2 -2
  552. data/lib/rubocop/cop/style/symbol_array.rb +12 -7
  553. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  554. data/lib/rubocop/cop/style/symbol_proc.rb +46 -14
  555. data/lib/rubocop/cop/style/ternary_parentheses.rb +2 -14
  556. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  557. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  558. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  559. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  560. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -5
  561. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +1 -1
  562. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  563. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +1 -1
  564. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  565. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  566. data/lib/rubocop/cop/style/trivial_accessors.rb +4 -1
  567. data/lib/rubocop/cop/style/unless_else.rb +1 -1
  568. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  569. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  570. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  571. data/lib/rubocop/cop/style/when_then.rb +1 -1
  572. data/lib/rubocop/cop/style/word_array.rb +60 -6
  573. data/lib/rubocop/cop/style/yoda_condition.rb +13 -6
  574. data/lib/rubocop/cop/style/yoda_expression.rb +90 -0
  575. data/lib/rubocop/cop/style/zero_length_predicate.rb +32 -15
  576. data/lib/rubocop/cop/team.rb +64 -57
  577. data/lib/rubocop/cop/util.rb +43 -7
  578. data/lib/rubocop/cop/variable_force/assignment.rb +1 -1
  579. data/lib/rubocop/cop/variable_force/scope.rb +3 -3
  580. data/lib/rubocop/cop/variable_force/variable_table.rb +4 -2
  581. data/lib/rubocop/cop/variable_force.rb +18 -30
  582. data/lib/rubocop/cops_documentation_generator.rb +53 -13
  583. data/lib/rubocop/directive_comment.rb +1 -1
  584. data/lib/rubocop/ext/processed_source.rb +2 -0
  585. data/lib/rubocop/ext/range.rb +15 -0
  586. data/lib/rubocop/feature_loader.rb +94 -0
  587. data/lib/rubocop/file_patterns.rb +43 -0
  588. data/lib/rubocop/formatter/clang_style_formatter.rb +1 -1
  589. data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -16
  590. data/lib/rubocop/formatter/formatter_set.rb +20 -19
  591. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  592. data/lib/rubocop/formatter/html_formatter.rb +4 -5
  593. data/lib/rubocop/formatter/markdown_formatter.rb +3 -1
  594. data/lib/rubocop/formatter/offense_count_formatter.rb +10 -5
  595. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  596. data/lib/rubocop/formatter/tap_formatter.rb +1 -1
  597. data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -3
  598. data/lib/rubocop/formatter.rb +34 -0
  599. data/lib/rubocop/magic_comment.rb +27 -2
  600. data/lib/rubocop/options.rb +128 -53
  601. data/lib/rubocop/path_util.rb +50 -22
  602. data/lib/rubocop/rake_task.rb +34 -9
  603. data/lib/rubocop/result_cache.rb +26 -23
  604. data/lib/rubocop/rspec/cop_helper.rb +26 -3
  605. data/lib/rubocop/rspec/expect_offense.rb +9 -7
  606. data/lib/rubocop/rspec/shared_contexts.rb +46 -9
  607. data/lib/rubocop/rspec/support.rb +16 -2
  608. data/lib/rubocop/runner.rb +78 -23
  609. data/lib/rubocop/server/cache.rb +155 -0
  610. data/lib/rubocop/server/cli.rb +147 -0
  611. data/lib/rubocop/server/client_command/base.rb +44 -0
  612. data/lib/rubocop/server/client_command/exec.rb +64 -0
  613. data/lib/rubocop/server/client_command/restart.rb +25 -0
  614. data/lib/rubocop/server/client_command/start.rb +48 -0
  615. data/lib/rubocop/server/client_command/status.rb +28 -0
  616. data/lib/rubocop/server/client_command/stop.rb +31 -0
  617. data/lib/rubocop/server/client_command.rb +26 -0
  618. data/lib/rubocop/server/core.rb +111 -0
  619. data/lib/rubocop/server/errors.rb +23 -0
  620. data/lib/rubocop/server/helper.rb +34 -0
  621. data/lib/rubocop/server/server_command/base.rb +50 -0
  622. data/lib/rubocop/server/server_command/exec.rb +34 -0
  623. data/lib/rubocop/server/server_command/stop.rb +24 -0
  624. data/lib/rubocop/server/server_command.rb +21 -0
  625. data/lib/rubocop/server/socket_reader.rb +69 -0
  626. data/lib/rubocop/server.rb +53 -0
  627. data/lib/rubocop/target_finder.rb +1 -1
  628. data/lib/rubocop/target_ruby.rb +8 -7
  629. data/lib/rubocop/version.rb +22 -9
  630. data/lib/rubocop.rb +45 -35
  631. metadata +90 -36
  632. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
  633. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
data/config/default.yml CHANGED
@@ -153,13 +153,17 @@ AllCops:
153
153
  rubocop-sequel: [sequel]
154
154
  rubocop-rake: [rake]
155
155
  rubocop-graphql: [graphql]
156
+ # Enable/Disable checking the methods extended by Active Support.
157
+ ActiveSupportExtensionsEnabled: false
156
158
 
157
159
  #################### Bundler ###############################
158
160
 
159
161
  Bundler/DuplicatedGem:
160
162
  Description: 'Checks for duplicate gem entries in Gemfile.'
161
163
  Enabled: true
164
+ Severity: warning
162
165
  VersionAdded: '0.46'
166
+ VersionChanged: '1.40'
163
167
  Include:
164
168
  - '**/*.gemfile'
165
169
  - '**/Gemfile'
@@ -211,7 +215,9 @@ Bundler/InsecureProtocolSource:
211
215
  because HTTP requests are insecure. Please change your source to
212
216
  'https://rubygems.org' if possible, or 'http://rubygems.org' if not.
213
217
  Enabled: true
218
+ Severity: warning
214
219
  VersionAdded: '0.50'
220
+ VersionChanged: '1.40'
215
221
  AllowHttpProtocol: true
216
222
  Include:
217
223
  - '**/*.gemfile'
@@ -235,13 +241,6 @@ Bundler/OrderedGems:
235
241
 
236
242
  #################### Gemspec ###############################
237
243
 
238
- Gemspec/DateAssignment:
239
- Description: 'Checks that `date =` is not used in gemspec file, it is set automatically when the gem is packaged.'
240
- Enabled: pending
241
- VersionAdded: '1.10'
242
- Include:
243
- - '**/*.gemspec'
244
-
245
244
  Gemspec/DependencyVersion:
246
245
  Description: 'Requires or forbids specifying gem dependency versions.'
247
246
  Enabled: false
@@ -254,10 +253,36 @@ Gemspec/DependencyVersion:
254
253
  - '**/*.gemspec'
255
254
  AllowedGems: []
256
255
 
256
+ Gemspec/DeprecatedAttributeAssignment:
257
+ Description: Checks that deprecated attribute assignments are not set in a gemspec file.
258
+ Enabled: pending
259
+ Severity: warning
260
+ VersionAdded: '1.30'
261
+ VersionChanged: '1.40'
262
+ Include:
263
+ - '**/*.gemspec'
264
+
265
+ Gemspec/DevelopmentDependencies:
266
+ Description: Checks that development dependencies are specified in Gemfile rather than gemspec.
267
+ Enabled: pending
268
+ VersionAdded: '1.44'
269
+ EnforcedStyle: Gemfile
270
+ SupportedStyles:
271
+ - Gemfile
272
+ - gems.rb
273
+ - gemspec
274
+ AllowedGems: []
275
+ Include:
276
+ - '**/*.gemspec'
277
+ - '**/Gemfile'
278
+ - '**/gems.rb'
279
+
257
280
  Gemspec/DuplicatedAssignment:
258
281
  Description: 'An attribute assignment method calls should be listed only once in a gemspec.'
259
282
  Enabled: true
283
+ Severity: warning
260
284
  VersionAdded: '0.52'
285
+ VersionChanged: '1.40'
261
286
  Include:
262
287
  - '**/*.gemspec'
263
288
 
@@ -276,7 +301,9 @@ Gemspec/OrderedDependencies:
276
301
  Gemspec/RequireMFA:
277
302
  Description: 'Checks that the gemspec has metadata to require Multi-Factor Authentication from RubyGems.'
278
303
  Enabled: pending
304
+ Severity: warning
279
305
  VersionAdded: '1.23'
306
+ VersionChanged: '1.40'
280
307
  Reference:
281
308
  - https://guides.rubygems.org/mfa-requirement-opt-in/
282
309
  Include:
@@ -285,8 +312,9 @@ Gemspec/RequireMFA:
285
312
  Gemspec/RequiredRubyVersion:
286
313
  Description: 'Checks that `required_ruby_version` of gemspec is specified and equal to `TargetRubyVersion` of .rubocop.yml.'
287
314
  Enabled: true
315
+ Severity: warning
288
316
  VersionAdded: '0.52'
289
- VersionChanged: '1.22'
317
+ VersionChanged: '1.40'
290
318
  Include:
291
319
  - '**/*.gemspec'
292
320
 
@@ -294,7 +322,9 @@ Gemspec/RubyVersionGlobalsUsage:
294
322
  Description: Checks usage of RUBY_VERSION in gemspec.
295
323
  StyleGuide: '#no-ruby-version-in-the-gemspec'
296
324
  Enabled: true
325
+ Severity: warning
297
326
  VersionAdded: '0.72'
327
+ VersionChanged: '1.40'
298
328
  Include:
299
329
  - '**/*.gemspec'
300
330
 
@@ -377,7 +407,7 @@ Layout/AssignmentIndentation:
377
407
  right-hand-side of a multi-line assignment.
378
408
  Enabled: true
379
409
  VersionAdded: '0.49'
380
- VersionChanged: '0.77'
410
+ VersionChanged: '1.45'
381
411
  # By default the indentation width from `Layout/IndentationWidth` is used,
382
412
  # but it can be overridden by setting this parameter.
383
413
  IndentationWidth: ~
@@ -746,6 +776,7 @@ Layout/FirstArrayElementLineBreak:
746
776
  multi-line array.
747
777
  Enabled: false
748
778
  VersionAdded: '0.49'
779
+ AllowMultilineFinalElement: false
749
780
 
750
781
  Layout/FirstHashElementIndentation:
751
782
  Description: 'Checks the indentation of the first key in a hash literal.'
@@ -778,6 +809,7 @@ Layout/FirstHashElementLineBreak:
778
809
  multi-line hash.
779
810
  Enabled: false
780
811
  VersionAdded: '0.49'
812
+ AllowMultilineFinalElement: false
781
813
 
782
814
  Layout/FirstMethodArgumentLineBreak:
783
815
  Description: >-
@@ -785,6 +817,7 @@ Layout/FirstMethodArgumentLineBreak:
785
817
  multi-line method call.
786
818
  Enabled: false
787
819
  VersionAdded: '0.49'
820
+ AllowMultilineFinalElement: false
788
821
 
789
822
  Layout/FirstMethodParameterLineBreak:
790
823
  Description: >-
@@ -792,6 +825,7 @@ Layout/FirstMethodParameterLineBreak:
792
825
  multi-line method parameter definition.
793
826
  Enabled: false
794
827
  VersionAdded: '0.49'
828
+ AllowMultilineFinalElement: false
795
829
 
796
830
  Layout/FirstParameterIndentation:
797
831
  Description: >-
@@ -928,7 +962,7 @@ Layout/IndentationStyle:
928
962
  VersionChanged: '0.82'
929
963
  # By default the indentation width from `Layout/IndentationWidth` is used,
930
964
  # but it can be overridden by setting this parameter.
931
- # It is used during auto-correction to determine how many spaces should
965
+ # It is used during autocorrection to determine how many spaces should
932
966
  # replace each tab.
933
967
  IndentationWidth: ~
934
968
  EnforcedStyle: spaces
@@ -944,7 +978,6 @@ Layout/IndentationWidth:
944
978
  # Number of spaces for each indentation level.
945
979
  Width: 2
946
980
  AllowedPatterns: []
947
- IgnoredPatterns: [] # deprecated
948
981
 
949
982
  Layout/InitialIndentation:
950
983
  Description: >-
@@ -967,6 +1000,29 @@ Layout/LeadingEmptyLines:
967
1000
  VersionAdded: '0.57'
968
1001
  VersionChanged: '0.77'
969
1002
 
1003
+ Layout/LineContinuationLeadingSpace:
1004
+ Description: >-
1005
+ Use trailing spaces instead of leading spaces in strings
1006
+ broken over multiple lines (by a backslash).
1007
+ Enabled: pending
1008
+ VersionAdded: '1.31'
1009
+ VersionChanged: '1.45'
1010
+ EnforcedStyle: trailing
1011
+ SupportedStyles:
1012
+ - leading
1013
+ - trailing
1014
+
1015
+ Layout/LineContinuationSpacing:
1016
+ Description: 'Checks the spacing in front of backslash in line continuations.'
1017
+ Enabled: pending
1018
+ AutoCorrect: true
1019
+ SafeAutoCorrect: true
1020
+ VersionAdded: '1.31'
1021
+ EnforcedStyle: space
1022
+ SupportedStyles:
1023
+ - space
1024
+ - no_space
1025
+
970
1026
  Layout/LineEndStringConcatenationIndentation:
971
1027
  Description: >-
972
1028
  Checks the indentation of the next line after a line that
@@ -1002,7 +1058,6 @@ Layout/LineLength:
1002
1058
  # elements. Strings will be converted to Regexp objects. A line that matches
1003
1059
  # any regular expression listed in this option will be ignored by LineLength.
1004
1060
  AllowedPatterns: []
1005
- IgnoredPatterns: [] # deprecated
1006
1061
 
1007
1062
  Layout/MultilineArrayBraceLayout:
1008
1063
  Description: >-
@@ -1026,6 +1081,7 @@ Layout/MultilineArrayLineBreaks:
1026
1081
  starts on a separate line.
1027
1082
  Enabled: false
1028
1083
  VersionAdded: '0.67'
1084
+ AllowMultilineFinalElement: false
1029
1085
 
1030
1086
  Layout/MultilineAssignmentLayout:
1031
1087
  Description: 'Check for a newline after the assignment operator in multi-line assignments.'
@@ -1076,6 +1132,7 @@ Layout/MultilineHashKeyLineBreaks:
1076
1132
  starts on a separate line.
1077
1133
  Enabled: false
1078
1134
  VersionAdded: '0.67'
1135
+ AllowMultilineFinalElement: false
1079
1136
 
1080
1137
  Layout/MultilineMethodArgumentLineBreaks:
1081
1138
  Description: >-
@@ -1083,6 +1140,7 @@ Layout/MultilineMethodArgumentLineBreaks:
1083
1140
  starts on a separate line.
1084
1141
  Enabled: false
1085
1142
  VersionAdded: '0.67'
1143
+ AllowMultilineFinalElement: false
1086
1144
 
1087
1145
  Layout/MultilineMethodCallBraceLayout:
1088
1146
  Description: >-
@@ -1131,6 +1189,14 @@ Layout/MultilineMethodDefinitionBraceLayout:
1131
1189
  - new_line
1132
1190
  - same_line
1133
1191
 
1192
+ Layout/MultilineMethodParameterLineBreaks:
1193
+ Description: >-
1194
+ Checks that each parameter in a multi-line method definition
1195
+ starts on a separate line.
1196
+ Enabled: false
1197
+ VersionAdded: '1.32'
1198
+ AllowMultilineFinalElement: false
1199
+
1134
1200
  Layout/MultilineOperationIndentation:
1135
1201
  Description: >-
1136
1202
  Checks indentation of binary operations that span more than
@@ -1468,7 +1534,8 @@ Lint/AmbiguousBlockAssociation:
1468
1534
  Enabled: true
1469
1535
  VersionAdded: '0.48'
1470
1536
  VersionChanged: '1.13'
1471
- IgnoredMethods: []
1537
+ AllowedMethods: []
1538
+ AllowedPatterns: []
1472
1539
 
1473
1540
  Lint/AmbiguousOperator:
1474
1541
  Description: >-
@@ -1505,7 +1572,9 @@ Lint/AssignmentInCondition:
1505
1572
  Description: "Don't use assignment in conditions."
1506
1573
  StyleGuide: '#safe-assignment-in-condition'
1507
1574
  Enabled: true
1575
+ SafeAutoCorrect: false
1508
1576
  VersionAdded: '0.9'
1577
+ VersionChanged: '1.45'
1509
1578
  AllowSafeAssignment: true
1510
1579
 
1511
1580
  Lint/BigDecimalNew:
@@ -1543,6 +1612,11 @@ Lint/ConstantDefinitionInBlock:
1543
1612
  AllowedMethods:
1544
1613
  - enums
1545
1614
 
1615
+ Lint/ConstantOverwrittenInRescue:
1616
+ Description: 'Checks for overwriting an exception with an exception result by use `rescue =>`.'
1617
+ Enabled: pending
1618
+ VersionAdded: '1.31'
1619
+
1546
1620
  Lint/ConstantResolution:
1547
1621
  Description: 'Check that constants are fully qualified with `::`.'
1548
1622
  Enabled: false
@@ -1556,13 +1630,13 @@ Lint/Debugger:
1556
1630
  Description: 'Check for debugger calls.'
1557
1631
  Enabled: true
1558
1632
  VersionAdded: '0.14'
1559
- VersionChanged: '1.10'
1560
- DebuggerReceivers: [] # deprecated
1633
+ VersionChanged: '1.46'
1561
1634
  DebuggerMethods:
1562
1635
  # Groups are available so that a specific group can be disabled in
1563
1636
  # a user's configuration, but are otherwise not significant.
1564
1637
  Kernel:
1565
1638
  - binding.irb
1639
+ - Kernel.binding.irb
1566
1640
  Byebug:
1567
1641
  - byebug
1568
1642
  - remote_byebug
@@ -1580,6 +1654,9 @@ Lint/Debugger:
1580
1654
  - binding.pry
1581
1655
  - binding.remote_pry
1582
1656
  - binding.pry_remote
1657
+ - Kernel.binding.pry
1658
+ - Kernel.binding.remote_pry
1659
+ - Kernel.binding.pry_remote
1583
1660
  - Pry.rescue
1584
1661
  Rails:
1585
1662
  - debugger
@@ -1598,7 +1675,7 @@ Lint/DeprecatedConstants:
1598
1675
  Description: 'Checks for deprecated constants.'
1599
1676
  Enabled: pending
1600
1677
  VersionAdded: '1.8'
1601
- VersionChanged: '1.22'
1678
+ VersionChanged: '1.40'
1602
1679
  # You can configure deprecated constants.
1603
1680
  # If there is an alternative method, you can set alternative value as `Alternative`.
1604
1681
  # And you can set the deprecated version as `DeprecatedVersion`.
@@ -1625,6 +1702,12 @@ Lint/DeprecatedConstants:
1625
1702
  'Random::DEFAULT':
1626
1703
  Alternative: 'Random.new'
1627
1704
  DeprecatedVersion: '3.0'
1705
+ 'Struct::Group':
1706
+ Alternative: 'Etc::Group'
1707
+ DeprecatedVersion: '3.0'
1708
+ 'Struct::Passwd':
1709
+ Alternative: 'Etc::Passwd'
1710
+ DeprecatedVersion: '3.0'
1628
1711
 
1629
1712
  Lint/DeprecatedOpenSSLConstant:
1630
1713
  Description: "Don't use algorithm constants for `OpenSSL::Cipher` and `OpenSSL::Digest`."
@@ -1662,6 +1745,11 @@ Lint/DuplicateHashKey:
1662
1745
  VersionAdded: '0.34'
1663
1746
  VersionChanged: '0.77'
1664
1747
 
1748
+ Lint/DuplicateMagicComment:
1749
+ Description: 'Check for duplicated magic comments.'
1750
+ Enabled: pending
1751
+ VersionAdded: '1.37'
1752
+
1665
1753
  Lint/DuplicateMethods:
1666
1754
  Description: 'Check for duplicate method definitions.'
1667
1755
  Enabled: true
@@ -1712,8 +1800,10 @@ Lint/EmptyClass:
1712
1800
  Lint/EmptyConditionalBody:
1713
1801
  Description: 'Checks for the presence of `if`, `elsif` and `unless` branches without a body.'
1714
1802
  Enabled: true
1803
+ SafeAutoCorrect: false
1715
1804
  AllowComments: true
1716
1805
  VersionAdded: '0.89'
1806
+ VersionChanged: '1.34'
1717
1807
 
1718
1808
  Lint/EmptyEnsure:
1719
1809
  Description: 'Checks for empty ensure block.'
@@ -1842,11 +1932,11 @@ Lint/InheritException:
1842
1932
  - runtime_error
1843
1933
 
1844
1934
  Lint/InterpolationCheck:
1845
- Description: 'Raise warning for interpolation in single q strs.'
1935
+ Description: 'Checks for interpolation in a single quoted string.'
1846
1936
  Enabled: true
1847
- Safe: false
1937
+ SafeAutoCorrect: false
1848
1938
  VersionAdded: '0.50'
1849
- VersionChanged: '0.87'
1939
+ VersionChanged: '1.40'
1850
1940
 
1851
1941
  Lint/LambdaWithoutLiteralBlock:
1852
1942
  Description: 'Checks uses of lambda without a literal block.'
@@ -1910,6 +2000,8 @@ Lint/NestedMethodDefinition:
1910
2000
  Description: 'Do not use nested method definitions.'
1911
2001
  StyleGuide: '#no-nested-methods'
1912
2002
  Enabled: true
2003
+ AllowedMethods: []
2004
+ AllowedPatterns: []
1913
2005
  VersionAdded: '0.32'
1914
2006
 
1915
2007
  Lint/NestedPercentLiteral:
@@ -1929,6 +2021,13 @@ Lint/NoReturnInBeginEndBlocks:
1929
2021
  Enabled: pending
1930
2022
  VersionAdded: '1.2'
1931
2023
 
2024
+ Lint/NonAtomicFileOperation:
2025
+ Description: Checks for non-atomic file operations.
2026
+ StyleGuide: '#atomic-file-operations'
2027
+ Enabled: pending
2028
+ VersionAdded: '1.31'
2029
+ SafeAutoCorrect: false
2030
+
1932
2031
  Lint/NonDeterministicRequireOrder:
1933
2032
  Description: 'Always sort arrays returned by Dir.glob when requiring files.'
1934
2033
  Enabled: true
@@ -1946,7 +2045,8 @@ Lint/NumberConversion:
1946
2045
  VersionAdded: '0.53'
1947
2046
  VersionChanged: '1.1'
1948
2047
  SafeAutoCorrect: false
1949
- IgnoredMethods: []
2048
+ AllowedMethods: []
2049
+ AllowedPatterns: []
1950
2050
  IgnoredClasses:
1951
2051
  - Time
1952
2052
  - DateTime
@@ -1965,7 +2065,9 @@ Lint/OrAssignmentToConstant:
1965
2065
  Lint/OrderedMagicComments:
1966
2066
  Description: 'Checks the proper ordering of magic comments and whether a magic comment is not placed before a shebang.'
1967
2067
  Enabled: true
2068
+ SafeAutoCorrect: false
1968
2069
  VersionAdded: '0.53'
2070
+ VersionChanged: '1.37'
1969
2071
 
1970
2072
  Lint/OutOfRangeRegexpRef:
1971
2073
  Description: 'Checks for out of range reference for Regexp because it always returns nil.'
@@ -2095,6 +2197,11 @@ Lint/RequireParentheses:
2095
2197
  Enabled: true
2096
2198
  VersionAdded: '0.18'
2097
2199
 
2200
+ Lint/RequireRangeParentheses:
2201
+ Description: 'Checks that a range literal is enclosed in parentheses when the end of the range is at a line break.'
2202
+ Enabled: pending
2203
+ VersionAdded: '1.32'
2204
+
2098
2205
  Lint/RequireRelativeSelfPath:
2099
2206
  Description: 'Checks for uses a file requiring itself with `require_relative`.'
2100
2207
  Enabled: pending
@@ -2290,7 +2397,6 @@ Lint/UnreachableLoop:
2290
2397
  # RSpec uses `times` in its message expectations
2291
2398
  # eg. `exactly(2).times`
2292
2399
  - !ruby/regexp /(exactly|at_least|at_most)\(\d+\)\.times/
2293
- IgnoredPatterns: [] # deprecated
2294
2400
 
2295
2401
  Lint/UnusedBlockArgument:
2296
2402
  Description: 'Checks for unused block arguments.'
@@ -2341,6 +2447,12 @@ Lint/UselessAssignment:
2341
2447
  Enabled: true
2342
2448
  VersionAdded: '0.11'
2343
2449
 
2450
+ Lint/UselessElseWithoutRescue:
2451
+ Description: 'Checks for useless `else` in `begin..end` without `rescue`.'
2452
+ Enabled: true
2453
+ VersionAdded: '0.17'
2454
+ VersionChanged: '1.31'
2455
+
2344
2456
  Lint/UselessMethodDefinition:
2345
2457
  Description: 'Checks for useless method definitions.'
2346
2458
  Enabled: true
@@ -2348,6 +2460,11 @@ Lint/UselessMethodDefinition:
2348
2460
  VersionChanged: '0.91'
2349
2461
  Safe: false
2350
2462
 
2463
+ Lint/UselessRescue:
2464
+ Description: 'Checks for useless `rescue`s.'
2465
+ Enabled: pending
2466
+ VersionAdded: '1.43'
2467
+
2351
2468
  Lint/UselessRuby2Keywords:
2352
2469
  Description: 'Finds unnecessary uses of `ruby2_keywords`.'
2353
2470
  Enabled: pending
@@ -2387,7 +2504,8 @@ Metrics/AbcSize:
2387
2504
  VersionChanged: '1.5'
2388
2505
  # The ABC size is a calculated magnitude, so this number can be an Integer or
2389
2506
  # a Float.
2390
- IgnoredMethods: []
2507
+ AllowedMethods: []
2508
+ AllowedPatterns: []
2391
2509
  CountRepeatedAttributes: true
2392
2510
  Max: 17
2393
2511
 
@@ -2399,11 +2517,11 @@ Metrics/BlockLength:
2399
2517
  CountComments: false # count full line comments?
2400
2518
  Max: 25
2401
2519
  CountAsOne: []
2402
- ExcludedMethods: [] # deprecated, retained for backwards compatibility
2403
- IgnoredMethods:
2520
+ AllowedMethods:
2404
2521
  # By default, exclude the `#refine` method, as it tends to have larger
2405
2522
  # associated blocks.
2406
2523
  - refine
2524
+ AllowedPatterns: []
2407
2525
  Exclude:
2408
2526
  - '**/*.gemspec'
2409
2527
 
@@ -2433,7 +2551,8 @@ Metrics/CyclomaticComplexity:
2433
2551
  Enabled: true
2434
2552
  VersionAdded: '0.25'
2435
2553
  VersionChanged: '0.81'
2436
- IgnoredMethods: []
2554
+ AllowedMethods: []
2555
+ AllowedPatterns: []
2437
2556
  Max: 7
2438
2557
 
2439
2558
  Metrics/MethodLength:
@@ -2445,8 +2564,8 @@ Metrics/MethodLength:
2445
2564
  CountComments: false # count full line comments?
2446
2565
  Max: 10
2447
2566
  CountAsOne: []
2448
- ExcludedMethods: [] # deprecated, retained for backwards compatibility
2449
- IgnoredMethods: []
2567
+ AllowedMethods: []
2568
+ AllowedPatterns: []
2450
2569
 
2451
2570
  Metrics/ModuleLength:
2452
2571
  Description: 'Avoid modules longer than 100 lines of code.'
@@ -2474,7 +2593,8 @@ Metrics/PerceivedComplexity:
2474
2593
  Enabled: true
2475
2594
  VersionAdded: '0.25'
2476
2595
  VersionChanged: '0.81'
2477
- IgnoredMethods: []
2596
+ AllowedMethods: []
2597
+ AllowedPatterns: []
2478
2598
  Max: 8
2479
2599
 
2480
2600
  ################## Migration #############################
@@ -2645,7 +2765,7 @@ Naming/HeredocDelimiterNaming:
2645
2765
  Enabled: true
2646
2766
  VersionAdded: '0.50'
2647
2767
  ForbiddenDelimiters:
2648
- - !ruby/regexp '/(^|\s)(EO[A-Z]{1}|END)(\s|$)/'
2768
+ - !ruby/regexp '/(^|\s)(EO[A-Z]{1}|END)(\s|$)/i'
2649
2769
 
2650
2770
  Naming/InclusiveLanguage:
2651
2771
  Description: 'Recommend the use of inclusive language instead of problematic terms.'
@@ -2703,7 +2823,6 @@ Naming/MethodName:
2703
2823
  # - '\A\s*onSelectionCleared\s*'
2704
2824
  #
2705
2825
  AllowedPatterns: []
2706
- IgnoredPatterns: [] # deprecated
2707
2826
 
2708
2827
  Naming/MethodParameterName:
2709
2828
  Description: >-
@@ -2717,10 +2836,13 @@ Naming/MethodParameterName:
2717
2836
  AllowNamesEndingInNumbers: true
2718
2837
  # Allowed names that will not register an offense
2719
2838
  AllowedNames:
2839
+ - as
2720
2840
  - at
2721
2841
  - by
2842
+ - cc
2722
2843
  - db
2723
2844
  - id
2845
+ - if
2724
2846
  - in
2725
2847
  - io
2726
2848
  - ip
@@ -2801,6 +2923,7 @@ Naming/VariableNumber:
2801
2923
  - rfc822 # Time#rfc822
2802
2924
  - rfc2822 # Time#rfc2822
2803
2925
  - rfc3339 # DateTime.rfc3339
2926
+ - x86_64 # Allowed by default as an underscore separated CPU architecture name
2804
2927
  AllowedPatterns: []
2805
2928
 
2806
2929
  #################### Security ##############################
@@ -2871,6 +2994,7 @@ Style/AccessModifierDeclarations:
2871
2994
  - inline
2872
2995
  - group
2873
2996
  AllowModifiersOnSymbols: true
2997
+ SafeAutoCorrect: false
2874
2998
 
2875
2999
  Style/AccessorGrouping:
2876
3000
  Description: 'Checks for grouping of accessors in `class` and `module` bodies.'
@@ -2924,6 +3048,12 @@ Style/ArrayCoercion:
2924
3048
  Enabled: false
2925
3049
  VersionAdded: '0.88'
2926
3050
 
3051
+ Style/ArrayIntersect:
3052
+ Description: 'Use `array1.intersect?(array2)` instead of `(array1 & array2).any?`.'
3053
+ Enabled: 'pending'
3054
+ Safe: false
3055
+ VersionAdded: '1.40'
3056
+
2927
3057
  Style/ArrayJoin:
2928
3058
  Description: 'Use Array#join instead of Array#*.'
2929
3059
  StyleGuide: '#array-join'
@@ -3005,7 +3135,7 @@ Style/BlockDelimiters:
3005
3135
  # This looks at the usage of a block's method to determine its type (e.g. is
3006
3136
  # the result of a `map` assigned to a variable or passed to another
3007
3137
  # method) but exceptions are permitted in the `ProceduralMethods`,
3008
- # `FunctionalMethods` and `IgnoredMethods` sections below.
3138
+ # `FunctionalMethods` and `AllowedMethods` sections below.
3009
3139
  - semantic
3010
3140
  # The `braces_for_chaining` style enforces braces around single line blocks
3011
3141
  # and do..end around multi-line blocks, except for multi-line blocks whose
@@ -3046,7 +3176,7 @@ Style/BlockDelimiters:
3046
3176
  - let!
3047
3177
  - subject
3048
3178
  - watch
3049
- IgnoredMethods:
3179
+ AllowedMethods:
3050
3180
  # Methods that can be either procedural or functional and cannot be
3051
3181
  # categorised from their usage alone, e.g.
3052
3182
  #
@@ -3063,6 +3193,7 @@ Style/BlockDelimiters:
3063
3193
  - lambda
3064
3194
  - proc
3065
3195
  - it
3196
+ AllowedPatterns: []
3066
3197
  # The AllowBracesOnProceduralOneLiners option is ignored unless the
3067
3198
  # EnforcedStyle is set to `semantic`. If so:
3068
3199
  #
@@ -3086,7 +3217,7 @@ Style/BlockDelimiters:
3086
3217
  # collection.each do |element| puts element end
3087
3218
  AllowBracesOnProceduralOneLiners: false
3088
3219
  # The BracesRequiredMethods overrides all other configurations except
3089
- # IgnoredMethods. It can be used to enforce that all blocks for specific
3220
+ # AllowedMethods. It can be used to enforce that all blocks for specific
3090
3221
  # methods use braces. For example, you can use this to enforce Sorbet
3091
3222
  # signatures use braces even when the rest of your codebase enforces
3092
3223
  # the `line_count_based` style.
@@ -3107,6 +3238,15 @@ Style/CaseEquality:
3107
3238
  # # good
3108
3239
  # String === "string"
3109
3240
  AllowOnConstant: false
3241
+ # If `AllowOnSelfClass` option is enabled, the cop will ignore violations when the receiver of
3242
+ # the case equality operator is `self.class`.
3243
+ #
3244
+ # # bad
3245
+ # some_class === object
3246
+ #
3247
+ # # good
3248
+ # self.class === object
3249
+ AllowOnSelfClass: false
3110
3250
 
3111
3251
  Style/CaseLikeIf:
3112
3252
  Description: 'Identifies places where `if-elsif` constructions can be replaced with `case-when`.'
@@ -3166,10 +3306,11 @@ Style/ClassEqualityComparison:
3166
3306
  StyleGuide: '#instance-of-vs-class-comparison'
3167
3307
  Enabled: true
3168
3308
  VersionAdded: '0.93'
3169
- IgnoredMethods:
3309
+ AllowedMethods:
3170
3310
  - ==
3171
3311
  - equal?
3172
3312
  - eql?
3313
+ AllowedPatterns: []
3173
3314
 
3174
3315
  Style/ClassMethods:
3175
3316
  Description: 'Use self when defining module/class methods.'
@@ -3290,6 +3431,17 @@ Style/CommentedKeyword:
3290
3431
  VersionAdded: '0.51'
3291
3432
  VersionChanged: '1.19'
3292
3433
 
3434
+ Style/ComparableClamp:
3435
+ Description: 'Enforces the use of `Comparable#clamp` instead of comparison by minimum and maximum.'
3436
+ Enabled: pending
3437
+ VersionAdded: '1.44'
3438
+
3439
+ Style/ConcatArrayLiterals:
3440
+ Description: 'Enforces the use of `Array#push(item)` instead of `Array#concat([item])` to avoid redundant array literals.'
3441
+ Enabled: pending
3442
+ Safe: false
3443
+ VersionAdded: '1.41'
3444
+
3293
3445
  Style/ConditionalAssignment:
3294
3446
  Description: >-
3295
3447
  Use the return value of `if` and `case` statements for
@@ -3347,7 +3499,7 @@ Style/Copyright:
3347
3499
 
3348
3500
  Style/DateTime:
3349
3501
  Description: 'Use Time over DateTime.'
3350
- StyleGuide: '#date--time'
3502
+ StyleGuide: '#date-time'
3351
3503
  Enabled: false
3352
3504
  VersionAdded: '0.51'
3353
3505
  VersionChanged: '0.92'
@@ -3456,6 +3608,12 @@ Style/EmptyElse:
3456
3608
  - empty
3457
3609
  - nil
3458
3610
  - both
3611
+ AllowComments: false
3612
+
3613
+ Style/EmptyHeredoc:
3614
+ Description: 'Checks for using empty heredoc to reduce redundancy.'
3615
+ Enabled: pending
3616
+ VersionAdded: '1.32'
3459
3617
 
3460
3618
  Style/EmptyLambdaParameter:
3461
3619
  Description: 'Omit parens for empty lambda parameters.'
@@ -3625,7 +3783,8 @@ Style/FormatStringToken:
3625
3783
  MaxUnannotatedPlaceholdersAllowed: 1
3626
3784
  VersionAdded: '0.49'
3627
3785
  VersionChanged: '1.0'
3628
- IgnoredMethods: []
3786
+ AllowedMethods: []
3787
+ AllowedPatterns: []
3629
3788
 
3630
3789
  Style/FrozenStringLiteralComment:
3631
3790
  Description: >-
@@ -3670,7 +3829,7 @@ Style/GuardClause:
3670
3829
  StyleGuide: '#no-nested-conditionals'
3671
3830
  Enabled: true
3672
3831
  VersionAdded: '0.20'
3673
- VersionChanged: '1.28'
3832
+ VersionChanged: '1.31'
3674
3833
  # `MinBodyLength` defines the number of lines of the a body of an `if` or `unless`
3675
3834
  # needs to have to trigger this cop
3676
3835
  MinBodyLength: 1
@@ -3703,14 +3862,17 @@ Style/HashEachMethods:
3703
3862
  Safe: false
3704
3863
  VersionAdded: '0.80'
3705
3864
  VersionChanged: '1.16'
3706
- AllowedReceivers: []
3865
+ AllowedReceivers:
3866
+ - Thread.current
3707
3867
 
3708
3868
  Style/HashExcept:
3709
3869
  Description: >-
3710
3870
  Checks for usages of `Hash#reject`, `Hash#select`, and `Hash#filter` methods
3711
3871
  that can be replaced with `Hash#except` method.
3712
3872
  Enabled: pending
3873
+ Safe: false
3713
3874
  VersionAdded: '1.7'
3875
+ VersionChanged: '1.39'
3714
3876
 
3715
3877
  Style/HashLikeCase:
3716
3878
  Description: >-
@@ -3749,6 +3911,8 @@ Style/HashSyntax:
3749
3911
  - never
3750
3912
  # accepts both shorthand and explicit use of hash literal value.
3751
3913
  - either
3914
+ # forces use of the 3.1 syntax only if all values can be omitted in the hash.
3915
+ - consistent
3752
3916
  # Force hashes that have a symbol value to use hash rockets
3753
3917
  UseHashRocketsWithSymbolValues: false
3754
3918
  # Do not suggest { a?: 1 } over { :a? => 1 } in ruby19 style
@@ -3861,16 +4025,41 @@ Style/InverseMethods:
3861
4025
  :=~: :!~
3862
4026
  :<: :>=
3863
4027
  :>: :<=
3864
- # `ActiveSupport` defines some common inverse methods. They are listed below,
3865
- # and not enabled by default.
3866
- # :present?: :blank?,
3867
- # :include?: :exclude?
3868
4028
  # `InverseBlocks` are methods that are inverted by inverting the return
3869
4029
  # of the block that is passed to the method
3870
4030
  InverseBlocks:
3871
4031
  :select: :reject
3872
4032
  :select!: :reject!
3873
4033
 
4034
+ Style/InvertibleUnlessCondition:
4035
+ Description: 'Favor `if` with inverted condition over `unless`.'
4036
+ Enabled: false
4037
+ VersionAdded: '1.44'
4038
+ # `InverseMethods` are methods that can be inverted in a `unless` condition.
4039
+ # The relationship of inverse methods needs to be defined in both directions.
4040
+ # Keys and values both need to be defined as symbols.
4041
+ InverseMethods:
4042
+ :!=: :==
4043
+ :>: :<=
4044
+ :<=: :>
4045
+ :<: :>=
4046
+ :>=: :<
4047
+ :!~: :=~
4048
+ :zero?: :nonzero?
4049
+ :nonzero?: :zero?
4050
+ :any?: :none?
4051
+ :none?: :any?
4052
+ :even?: :odd?
4053
+ :odd?: :even?
4054
+ # `ActiveSupport` defines some common inverse methods. They are listed below,
4055
+ # and not enabled by default.
4056
+ # :present?: :blank?
4057
+ # :blank?: :present?
4058
+ # :include?: :exclude?
4059
+ # :exclude?: :include?
4060
+ # :one?: :many?
4061
+ # :many?: :one?
4062
+
3874
4063
  Style/IpAddresses:
3875
4064
  Description: "Don't include literal IP addresses in code."
3876
4065
  Enabled: false
@@ -3925,12 +4114,43 @@ Style/LineEndConcatenation:
3925
4114
  VersionAdded: '0.18'
3926
4115
  VersionChanged: '0.64'
3927
4116
 
4117
+ Style/MagicCommentFormat:
4118
+ Description: 'Use a consistent style for magic comments.'
4119
+ Enabled: pending
4120
+ VersionAdded: '1.35'
4121
+ EnforcedStyle: snake_case
4122
+ SupportedStyles:
4123
+ # `snake` will enforce the magic comment is written
4124
+ # in snake case (words separated by underscores).
4125
+ # Eg: froze_string_literal: true
4126
+ - snake_case
4127
+ # `kebab` will enforce the magic comment is written
4128
+ # in kebab case (words separated by hyphens).
4129
+ # Eg: froze-string-literal: true
4130
+ - kebab_case
4131
+ DirectiveCapitalization: lowercase
4132
+ ValueCapitalization: ~
4133
+ SupportedCapitalizations:
4134
+ - lowercase
4135
+ - uppercase
4136
+
4137
+ Style/MapCompactWithConditionalBlock:
4138
+ Description: 'Prefer `select` or `reject` over `map { ... }.compact`.'
4139
+ Enabled: pending
4140
+ VersionAdded: '1.30'
4141
+
3928
4142
  Style/MapToHash:
3929
4143
  Description: 'Prefer `to_h` with a block over `map.to_h`.'
3930
4144
  Enabled: pending
3931
4145
  VersionAdded: '1.24'
3932
4146
  Safe: false
3933
4147
 
4148
+ Style/MapToSet:
4149
+ Description: 'Prefer `to_set` with a block over `map.to_set`.'
4150
+ Enabled: pending
4151
+ Safe: false
4152
+ VersionAdded: '1.42'
4153
+
3934
4154
  Style/MethodCallWithArgsParentheses:
3935
4155
  Description: 'Use parentheses for method calls with arguments.'
3936
4156
  StyleGuide: '#method-invocation-parens'
@@ -3938,9 +4158,8 @@ Style/MethodCallWithArgsParentheses:
3938
4158
  VersionAdded: '0.47'
3939
4159
  VersionChanged: '1.7'
3940
4160
  IgnoreMacros: true
3941
- IgnoredMethods: []
4161
+ AllowedMethods: []
3942
4162
  AllowedPatterns: []
3943
- IgnoredPatterns: [] # deprecated
3944
4163
  IncludedMacros: []
3945
4164
  AllowParenthesesInMultilineCall: false
3946
4165
  AllowParenthesesInChaining: false
@@ -3955,7 +4174,8 @@ Style/MethodCallWithoutArgsParentheses:
3955
4174
  Description: 'Do not use parentheses for method calls with no arguments.'
3956
4175
  StyleGuide: '#method-invocation-parens'
3957
4176
  Enabled: true
3958
- IgnoredMethods: []
4177
+ AllowedMethods: []
4178
+ AllowedPatterns: []
3959
4179
  VersionAdded: '0.47'
3960
4180
  VersionChanged: '0.55'
3961
4181
 
@@ -3986,6 +4206,12 @@ Style/MinMax:
3986
4206
  Enabled: true
3987
4207
  VersionAdded: '0.50'
3988
4208
 
4209
+ Style/MinMaxComparison:
4210
+ Description: 'Enforces the use of `max` or `min` instead of comparison for greater or less.'
4211
+ Enabled: pending
4212
+ Safe: false
4213
+ VersionAdded: '1.42'
4214
+
3989
4215
  Style/MissingElse:
3990
4216
  Description: >-
3991
4217
  Require if/case expressions to have an else branches.
@@ -4307,6 +4533,7 @@ Style/NumericLiterals:
4307
4533
  Strict: false
4308
4534
  # You can specify allowed numbers. (e.g. port number 3000, 8080, and etc)
4309
4535
  AllowedNumbers: []
4536
+ AllowedPatterns: []
4310
4537
 
4311
4538
  Style/NumericPredicate:
4312
4539
  Description: >-
@@ -4325,7 +4552,8 @@ Style/NumericPredicate:
4325
4552
  SupportedStyles:
4326
4553
  - predicate
4327
4554
  - comparison
4328
- IgnoredMethods: []
4555
+ AllowedMethods: []
4556
+ AllowedPatterns: []
4329
4557
  # Exclude RSpec specs because assertions like `expect(1).to be > 0` cause
4330
4558
  # false positives.
4331
4559
  Exclude:
@@ -4364,6 +4592,12 @@ Style/OpenStructUse:
4364
4592
  Enabled: pending
4365
4593
  VersionAdded: '1.23'
4366
4594
 
4595
+ Style/OperatorMethodCall:
4596
+ Description: 'Checks for redundant dot before operator method call.'
4597
+ StyleGuide: '#operator-method-call'
4598
+ Enabled: pending
4599
+ VersionAdded: '1.37'
4600
+
4367
4601
  Style/OptionHash:
4368
4602
  Description: "Don't use option hashes when you can use keyword arguments."
4369
4603
  Enabled: false
@@ -4509,10 +4743,12 @@ Style/RedundantArgument:
4509
4743
  Enabled: pending
4510
4744
  Safe: false
4511
4745
  VersionAdded: '1.4'
4512
- VersionChanged: '1.7'
4746
+ VersionChanged: '1.40'
4513
4747
  Methods:
4514
4748
  # Array#join
4515
4749
  join: ''
4750
+ # Array#sum
4751
+ sum: 0
4516
4752
  # String#split
4517
4753
  split: ' '
4518
4754
  # String#chomp
@@ -4547,6 +4783,22 @@ Style/RedundantConditional:
4547
4783
  Enabled: true
4548
4784
  VersionAdded: '0.50'
4549
4785
 
4786
+ Style/RedundantConstantBase:
4787
+ Description: Avoid redundant `::` prefix on constant.
4788
+ Enabled: pending
4789
+ VersionAdded: '1.40'
4790
+
4791
+ Style/RedundantDoubleSplatHashBraces:
4792
+ Description: 'Checks for redundant uses of double splat hash braces.'
4793
+ Enabled: pending
4794
+ VersionAdded: '1.41'
4795
+
4796
+ Style/RedundantEach:
4797
+ Description: 'Checks for redundant `each`.'
4798
+ Enabled: pending
4799
+ Safe: false
4800
+ VersionAdded: '1.38'
4801
+
4550
4802
  Style/RedundantException:
4551
4803
  Description: "Checks for an obsolete RuntimeException argument in raise/fail."
4552
4804
  StyleGuide: '#no-explicit-runtimeerror'
@@ -4581,6 +4833,11 @@ Style/RedundantFreeze:
4581
4833
  VersionAdded: '0.34'
4582
4834
  VersionChanged: '0.66'
4583
4835
 
4836
+ Style/RedundantHeredocDelimiterQuotes:
4837
+ Description: 'Checks for redundant heredoc delimiter quotes.'
4838
+ Enabled: pending
4839
+ VersionAdded: '1.45'
4840
+
4584
4841
  Style/RedundantInitialize:
4585
4842
  Description: 'Checks for redundant `initialize` methods.'
4586
4843
  Enabled: pending
@@ -4592,7 +4849,9 @@ Style/RedundantInitialize:
4592
4849
  Style/RedundantInterpolation:
4593
4850
  Description: 'Checks for strings that are just an interpolated expression.'
4594
4851
  Enabled: true
4852
+ SafeAutoCorrect: false
4595
4853
  VersionAdded: '0.76'
4854
+ VersionChanged: '1.30'
4596
4855
 
4597
4856
  Style/RedundantParentheses:
4598
4857
  Description: "Checks for parentheses that seem not to serve any purpose."
@@ -4656,6 +4915,11 @@ Style/RedundantSortBy:
4656
4915
  Enabled: true
4657
4916
  VersionAdded: '0.36'
4658
4917
 
4918
+ Style/RedundantStringEscape:
4919
+ Description: 'Checks for redundant escapes in string literals.'
4920
+ Enabled: pending
4921
+ VersionAdded: '1.37'
4922
+
4659
4923
  Style/RegexpLiteral:
4660
4924
  Description: 'Use / or %r around regular expressions.'
4661
4925
  StyleGuide: '#percent-r'
@@ -4674,6 +4938,12 @@ Style/RegexpLiteral:
4674
4938
  # are found in the regexp string.
4675
4939
  AllowInnerSlashes: false
4676
4940
 
4941
+ Style/RequireOrder:
4942
+ Description: Sort `require` and `require_relative` in alphabetical order.
4943
+ Enabled: false
4944
+ SafeAutoCorrect: false
4945
+ VersionAdded: '1.40'
4946
+
4677
4947
  Style/RescueModifier:
4678
4948
  Description: 'Avoid using rescue in its modifier form.'
4679
4949
  StyleGuide: '#no-rescue-modifiers'
@@ -4706,7 +4976,7 @@ Style/SafeNavigation:
4706
4976
  Transforms usages of a method call safeguarded by
4707
4977
  a check for the existence of the object to
4708
4978
  safe navigation (`&.`).
4709
- Auto-correction is unsafe as it assumes the object will
4979
+ Autocorrection is unsafe as it assumes the object will
4710
4980
  be `nil` or truthy, but never `false`.
4711
4981
  Enabled: true
4712
4982
  VersionAdded: '0.43'
@@ -4958,13 +5228,13 @@ Style/SymbolProc:
4958
5228
  Enabled: true
4959
5229
  Safe: false
4960
5230
  VersionAdded: '0.26'
4961
- VersionChanged: '1.28'
5231
+ VersionChanged: '1.40'
4962
5232
  AllowMethodsWithArguments: false
4963
- # A list of method names to be ignored by the check.
5233
+ # A list of method names to be always allowed by the check.
4964
5234
  # The names should be fairly unique, otherwise you'll end up ignoring lots of code.
4965
- IgnoredMethods:
4966
- - respond_to
5235
+ AllowedMethods:
4967
5236
  - define_method
5237
+ AllowedPatterns: []
4968
5238
  AllowComments: false
4969
5239
 
4970
5240
  Style/TernaryParentheses:
@@ -5203,6 +5473,19 @@ Style/YodaCondition:
5203
5473
  VersionAdded: '0.49'
5204
5474
  VersionChanged: '0.75'
5205
5475
 
5476
+ Style/YodaExpression:
5477
+ Description: 'Forbid the use of yoda expressions.'
5478
+ Enabled: false
5479
+ Safe: false
5480
+ VersionAdded: '1.42'
5481
+ VersionChanged: '1.43'
5482
+ SupportedOperators:
5483
+ - '*'
5484
+ - '+'
5485
+ - '&'
5486
+ - '|'
5487
+ - '^'
5488
+
5206
5489
  Style/ZeroLengthPredicate:
5207
5490
  Description: 'Use #empty? when testing for objects of length 0.'
5208
5491
  Enabled: true