rubocop 1.29.1 → 1.45.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (632) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +6 -4
  4. data/config/default.yml +336 -47
  5. data/config/obsoletion.yml +25 -1
  6. data/exe/rubocop +15 -7
  7. data/lib/rubocop/arguments_env.rb +17 -0
  8. data/lib/rubocop/arguments_file.rb +17 -0
  9. data/lib/rubocop/cache_config.rb +29 -0
  10. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +20 -5
  11. data/lib/rubocop/cli/command/execute_runner.rb +8 -8
  12. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  13. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  14. data/lib/rubocop/cli/command/suggest_extensions.rb +61 -16
  15. data/lib/rubocop/cli.rb +57 -9
  16. data/lib/rubocop/comment_config.rb +41 -1
  17. data/lib/rubocop/config.rb +45 -17
  18. data/lib/rubocop/config_finder.rb +68 -0
  19. data/lib/rubocop/config_loader.rb +41 -61
  20. data/lib/rubocop/config_loader_resolver.rb +11 -12
  21. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  22. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  23. data/lib/rubocop/config_obsoletion.rb +7 -2
  24. data/lib/rubocop/config_validator.rb +22 -5
  25. data/lib/rubocop/cop/autocorrect_logic.rb +4 -2
  26. data/lib/rubocop/cop/badge.rb +9 -4
  27. data/lib/rubocop/cop/base.rb +114 -82
  28. data/lib/rubocop/cop/bundler/duplicated_gem.rb +1 -1
  29. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  30. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  31. data/lib/rubocop/cop/commissioner.rb +19 -6
  32. data/lib/rubocop/cop/cop.rb +52 -32
  33. data/lib/rubocop/cop/corrector.rb +32 -12
  34. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  35. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  36. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +1 -1
  37. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  38. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  39. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  40. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  41. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  42. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +25 -9
  43. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +2 -7
  44. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  45. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  46. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  47. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  48. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  49. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  50. data/lib/rubocop/cop/gemspec/dependency_version.rb +16 -18
  51. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  52. data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
  53. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +1 -1
  54. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
  55. data/lib/rubocop/cop/gemspec/require_mfa.rb +21 -21
  56. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  57. data/lib/rubocop/cop/generator.rb +6 -3
  58. data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
  59. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  60. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  61. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  62. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  63. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +1 -1
  64. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +1 -1
  65. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -5
  66. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  67. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  68. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +12 -4
  69. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  70. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  71. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  72. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  73. data/lib/rubocop/cop/internal_affairs.rb +7 -0
  74. data/lib/rubocop/cop/layout/argument_alignment.rb +22 -1
  75. data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
  76. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  77. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  78. data/lib/rubocop/cop/layout/block_alignment.rb +17 -13
  79. data/lib/rubocop/cop/layout/block_end_newline.rb +42 -6
  80. data/lib/rubocop/cop/layout/case_indentation.rb +1 -1
  81. data/lib/rubocop/cop/layout/class_structure.rb +31 -24
  82. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +3 -7
  83. data/lib/rubocop/cop/layout/comment_indentation.rb +4 -2
  84. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  85. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  86. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  87. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  88. data/lib/rubocop/cop/layout/empty_comment.rb +2 -2
  89. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  90. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  91. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +1 -1
  92. data/lib/rubocop/cop/layout/empty_lines.rb +3 -1
  93. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +5 -2
  94. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  95. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  96. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  97. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  98. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  99. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  100. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  101. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  102. data/lib/rubocop/cop/layout/end_alignment.rb +1 -1
  103. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  104. data/lib/rubocop/cop/layout/extra_spacing.rb +10 -6
  105. data/lib/rubocop/cop/layout/first_argument_indentation.rb +36 -30
  106. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +21 -14
  107. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +39 -3
  108. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +52 -13
  109. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +50 -3
  110. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +62 -3
  111. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +53 -3
  112. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  113. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -0
  114. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +1 -1
  115. data/lib/rubocop/cop/layout/heredoc_indentation.rb +7 -10
  116. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  117. data/lib/rubocop/cop/layout/indentation_style.rb +8 -3
  118. data/lib/rubocop/cop/layout/indentation_width.rb +14 -7
  119. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  120. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  121. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  122. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
  123. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
  124. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +1 -1
  125. data/lib/rubocop/cop/layout/line_length.rb +9 -2
  126. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  127. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +52 -3
  128. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  129. data/lib/rubocop/cop/layout/multiline_block_layout.rb +5 -3
  130. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  131. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +50 -3
  132. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +58 -4
  133. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  134. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +3 -3
  135. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  136. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
  137. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +3 -3
  138. data/lib/rubocop/cop/layout/redundant_line_break.rb +4 -4
  139. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +1 -1
  140. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  141. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  142. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  143. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
  144. data/lib/rubocop/cop/layout/space_around_operators.rb +2 -2
  145. data/lib/rubocop/cop/layout/space_before_block_braces.rb +5 -3
  146. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  147. data/lib/rubocop/cop/layout/space_before_first_arg.rb +1 -1
  148. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  149. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -30
  150. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
  151. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +33 -15
  152. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +30 -3
  153. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
  154. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +10 -6
  155. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +6 -5
  156. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +9 -9
  157. data/lib/rubocop/cop/layout/trailing_whitespace.rb +13 -6
  158. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  159. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  160. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  161. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +28 -8
  162. data/lib/rubocop/cop/lint/ambiguous_operator.rb +5 -1
  163. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  164. data/lib/rubocop/cop/lint/ambiguous_range.rb +3 -3
  165. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +1 -1
  166. data/lib/rubocop/cop/lint/assignment_in_condition.rb +12 -2
  167. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  168. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  169. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  170. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  171. data/lib/rubocop/cop/lint/constant_resolution.rb +4 -0
  172. data/lib/rubocop/cop/lint/debugger.rb +25 -32
  173. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +67 -111
  174. data/lib/rubocop/cop/lint/deprecated_constants.rb +9 -2
  175. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  176. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -3
  177. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  178. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  179. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  180. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  181. data/lib/rubocop/cop/lint/duplicate_methods.rb +48 -18
  182. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +26 -7
  183. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  184. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  185. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  186. data/lib/rubocop/cop/lint/else_layout.rb +5 -9
  187. data/lib/rubocop/cop/lint/empty_block.rb +3 -7
  188. data/lib/rubocop/cop/lint/empty_class.rb +4 -2
  189. data/lib/rubocop/cop/lint/empty_conditional_body.rb +109 -3
  190. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  191. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  192. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  193. data/lib/rubocop/cop/lint/empty_in_pattern.rb +1 -1
  194. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  195. data/lib/rubocop/cop/lint/empty_when.rb +1 -1
  196. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  197. data/lib/rubocop/cop/lint/erb_new_arguments.rb +9 -9
  198. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  199. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  200. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  201. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
  202. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +16 -18
  203. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
  204. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +1 -1
  205. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  206. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  207. data/lib/rubocop/cop/lint/interpolation_check.rb +6 -5
  208. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +2 -2
  209. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  210. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +5 -1
  211. data/lib/rubocop/cop/lint/loop.rb +1 -1
  212. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +19 -4
  213. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  214. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
  215. data/lib/rubocop/cop/lint/nested_method_definition.rb +58 -6
  216. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  217. data/lib/rubocop/cop/lint/next_without_accumulator.rb +25 -6
  218. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
  219. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +12 -0
  220. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  221. data/lib/rubocop/cop/lint/number_conversion.rb +32 -10
  222. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  223. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  224. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -5
  225. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +20 -1
  226. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +6 -1
  227. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  228. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  229. data/lib/rubocop/cop/lint/raise_exception.rb +1 -1
  230. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  231. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +44 -10
  232. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +3 -3
  233. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +7 -0
  234. data/lib/rubocop/cop/lint/redundant_require_statement.rb +48 -7
  235. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +16 -3
  236. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  237. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  238. data/lib/rubocop/cop/lint/redundant_with_index.rb +14 -11
  239. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  240. data/lib/rubocop/cop/lint/refinement_import_methods.rb +1 -1
  241. data/lib/rubocop/cop/lint/regexp_as_condition.rb +9 -3
  242. data/lib/rubocop/cop/lint/require_parentheses.rb +4 -2
  243. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  244. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  245. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -1
  246. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +44 -8
  247. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  248. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  249. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  250. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  251. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -4
  252. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  253. data/lib/rubocop/cop/lint/shadowed_exception.rb +16 -11
  254. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +29 -4
  255. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  256. data/lib/rubocop/cop/lint/suppressed_exception.rb +2 -2
  257. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  258. data/lib/rubocop/cop/lint/syntax.rb +1 -1
  259. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  260. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  261. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  262. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  263. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  264. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  265. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  266. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  267. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  268. data/lib/rubocop/cop/lint/unreachable_loop.rb +10 -4
  269. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  270. data/lib/rubocop/cop/lint/unused_method_argument.rb +7 -2
  271. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  272. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  273. data/lib/rubocop/cop/lint/useless_access_modifier.rb +15 -10
  274. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  275. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +44 -0
  276. data/lib/rubocop/cop/lint/useless_method_definition.rb +4 -4
  277. data/lib/rubocop/cop/lint/useless_rescue.rb +85 -0
  278. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +16 -6
  279. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  280. data/lib/rubocop/cop/lint/useless_times.rb +1 -1
  281. data/lib/rubocop/cop/lint/void.rb +27 -16
  282. data/lib/rubocop/cop/metrics/abc_size.rb +5 -3
  283. data/lib/rubocop/cop/metrics/block_length.rb +17 -12
  284. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  285. data/lib/rubocop/cop/metrics/class_length.rb +10 -5
  286. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -2
  287. data/lib/rubocop/cop/metrics/method_length.rb +18 -12
  288. data/lib/rubocop/cop/metrics/module_length.rb +10 -5
  289. data/lib/rubocop/cop/metrics/parameter_lists.rb +28 -1
  290. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  291. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +3 -6
  292. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +7 -4
  293. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  294. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
  295. data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
  296. data/lib/rubocop/cop/mixin/allowed_pattern.rb +17 -1
  297. data/lib/rubocop/cop/mixin/annotation_comment.rb +13 -6
  298. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  299. data/lib/rubocop/cop/mixin/comments_help.rb +22 -4
  300. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
  301. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  302. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
  303. data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
  304. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
  305. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +152 -12
  306. data/lib/rubocop/cop/mixin/hash_transform_method.rb +10 -6
  307. data/lib/rubocop/cop/mixin/line_length_help.rb +11 -2
  308. data/lib/rubocop/cop/mixin/method_complexity.rb +13 -16
  309. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
  310. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -3
  311. data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
  312. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
  313. data/lib/rubocop/cop/mixin/range_help.rb +33 -7
  314. data/lib/rubocop/cop/mixin/require_library.rb +2 -0
  315. data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
  316. data/lib/rubocop/cop/mixin/statement_modifier.rb +16 -1
  317. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  318. data/lib/rubocop/cop/mixin/surrounding_space.rb +13 -11
  319. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  320. data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
  321. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  322. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  323. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  324. data/lib/rubocop/cop/naming/block_forwarding.rb +7 -3
  325. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  326. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +4 -2
  327. data/lib/rubocop/cop/naming/constant_name.rb +3 -3
  328. data/lib/rubocop/cop/naming/file_name.rb +1 -1
  329. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  330. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  331. data/lib/rubocop/cop/naming/inclusive_language.rb +5 -2
  332. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  333. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  334. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  335. data/lib/rubocop/cop/naming/predicate_name.rb +30 -1
  336. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  337. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  338. data/lib/rubocop/cop/naming/variable_number.rb +18 -18
  339. data/lib/rubocop/cop/registry.rb +70 -44
  340. data/lib/rubocop/cop/security/compound_hash.rb +3 -2
  341. data/lib/rubocop/cop/security/eval.rb +1 -1
  342. data/lib/rubocop/cop/security/json_load.rb +1 -1
  343. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  344. data/lib/rubocop/cop/security/open.rb +1 -1
  345. data/lib/rubocop/cop/security/yaml_load.rb +1 -1
  346. data/lib/rubocop/cop/style/access_modifier_declarations.rb +92 -3
  347. data/lib/rubocop/cop/style/accessor_grouping.rb +11 -7
  348. data/lib/rubocop/cop/style/alias.rb +10 -2
  349. data/lib/rubocop/cop/style/and_or.rb +11 -11
  350. data/lib/rubocop/cop/style/arguments_forwarding.rb +4 -3
  351. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  352. data/lib/rubocop/cop/style/array_intersect.rb +111 -0
  353. data/lib/rubocop/cop/style/array_join.rb +1 -1
  354. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  355. data/lib/rubocop/cop/style/attr.rb +1 -1
  356. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  357. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  358. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  359. data/lib/rubocop/cop/style/block_comments.rb +2 -2
  360. data/lib/rubocop/cop/style/block_delimiters.rb +38 -11
  361. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  362. data/lib/rubocop/cop/style/case_like_if.rb +1 -1
  363. data/lib/rubocop/cop/style/character_literal.rb +1 -1
  364. data/lib/rubocop/cop/style/class_and_module_children.rb +8 -15
  365. data/lib/rubocop/cop/style/class_check.rb +1 -1
  366. data/lib/rubocop/cop/style/class_equality_comparison.rb +55 -6
  367. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  368. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  369. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  370. data/lib/rubocop/cop/style/collection_compact.rb +13 -4
  371. data/lib/rubocop/cop/style/collection_methods.rb +3 -1
  372. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  373. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  374. data/lib/rubocop/cop/style/combinable_loops.rb +4 -2
  375. data/lib/rubocop/cop/style/command_literal.rb +2 -2
  376. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  377. data/lib/rubocop/cop/style/commented_keyword.rb +4 -4
  378. data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
  379. data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
  380. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -7
  381. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  382. data/lib/rubocop/cop/style/date_time.rb +1 -1
  383. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -1
  384. data/lib/rubocop/cop/style/dir.rb +4 -1
  385. data/lib/rubocop/cop/style/documentation.rb +13 -7
  386. data/lib/rubocop/cop/style/documentation_method.rb +7 -1
  387. data/lib/rubocop/cop/style/double_negation.rb +3 -1
  388. data/lib/rubocop/cop/style/each_for_simple_loop.rb +42 -7
  389. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  390. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  391. data/lib/rubocop/cop/style/empty_case_condition.rb +1 -1
  392. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  393. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  394. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  395. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  396. data/lib/rubocop/cop/style/empty_method.rb +18 -3
  397. data/lib/rubocop/cop/style/encoding.rb +2 -2
  398. data/lib/rubocop/cop/style/end_block.rb +1 -1
  399. data/lib/rubocop/cop/style/endless_method.rb +2 -2
  400. data/lib/rubocop/cop/style/env_home.rb +1 -1
  401. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  402. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  403. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  404. data/lib/rubocop/cop/style/explicit_block_argument.rb +6 -2
  405. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  406. data/lib/rubocop/cop/style/fetch_env_var.rb +37 -224
  407. data/lib/rubocop/cop/style/float_division.rb +1 -1
  408. data/lib/rubocop/cop/style/for.rb +3 -1
  409. data/lib/rubocop/cop/style/format_string.rb +1 -1
  410. data/lib/rubocop/cop/style/format_string_token.rb +73 -23
  411. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +6 -3
  412. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  413. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  414. data/lib/rubocop/cop/style/guard_clause.rb +132 -43
  415. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
  416. data/lib/rubocop/cop/style/hash_conversion.rb +1 -1
  417. data/lib/rubocop/cop/style/hash_each_methods.rb +49 -13
  418. data/lib/rubocop/cop/style/hash_except.rb +89 -9
  419. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  420. data/lib/rubocop/cop/style/hash_syntax.rb +24 -3
  421. data/lib/rubocop/cop/style/hash_transform_keys.rb +6 -1
  422. data/lib/rubocop/cop/style/hash_transform_values.rb +4 -1
  423. data/lib/rubocop/cop/style/identical_conditional_branches.rb +17 -2
  424. data/lib/rubocop/cop/style/if_unless_modifier.rb +1 -1
  425. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +29 -4
  426. data/lib/rubocop/cop/style/if_with_semicolon.rb +4 -4
  427. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  428. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  429. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  430. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  431. data/lib/rubocop/cop/style/inverse_methods.rb +12 -8
  432. data/lib/rubocop/cop/style/invertible_unless_condition.rb +114 -0
  433. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  434. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  435. data/lib/rubocop/cop/style/lambda.rb +1 -1
  436. data/lib/rubocop/cop/style/lambda_call.rb +1 -1
  437. data/lib/rubocop/cop/style/line_end_concatenation.rb +6 -3
  438. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  439. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  440. data/lib/rubocop/cop/style/map_to_hash.rb +3 -3
  441. data/lib/rubocop/cop/style/map_to_set.rb +61 -0
  442. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +39 -19
  443. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +5 -1
  444. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +8 -8
  445. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +22 -3
  446. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  447. data/lib/rubocop/cop/style/method_def_parentheses.rb +12 -5
  448. data/lib/rubocop/cop/style/min_max.rb +1 -1
  449. data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
  450. data/lib/rubocop/cop/style/missing_else.rb +37 -25
  451. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  452. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  453. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  454. data/lib/rubocop/cop/style/module_function.rb +30 -8
  455. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  456. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
  457. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  458. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  459. data/lib/rubocop/cop/style/multiline_memoization.rb +3 -3
  460. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  461. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +21 -6
  462. data/lib/rubocop/cop/style/multiline_when_then.rb +2 -4
  463. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  464. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  465. data/lib/rubocop/cop/style/negated_if_else_condition.rb +9 -7
  466. data/lib/rubocop/cop/style/nested_file_dirname.rb +1 -1
  467. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  468. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  469. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  470. data/lib/rubocop/cop/style/next.rb +3 -5
  471. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  472. data/lib/rubocop/cop/style/nil_lambda.rb +4 -4
  473. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  474. data/lib/rubocop/cop/style/not.rb +2 -2
  475. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  476. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +12 -4
  477. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  478. data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
  479. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  480. data/lib/rubocop/cop/style/object_then.rb +6 -1
  481. data/lib/rubocop/cop/style/one_line_conditional.rb +4 -7
  482. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  483. data/lib/rubocop/cop/style/operator_method_call.rb +67 -0
  484. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  485. data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
  486. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +1 -1
  487. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  488. data/lib/rubocop/cop/style/parallel_assignment.rb +3 -1
  489. data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
  490. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  491. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  492. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  493. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  494. data/lib/rubocop/cop/style/proc.rb +5 -2
  495. data/lib/rubocop/cop/style/quoted_symbols.rb +1 -1
  496. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  497. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  498. data/lib/rubocop/cop/style/redundant_argument.rb +5 -2
  499. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  500. data/lib/rubocop/cop/style/redundant_begin.rb +20 -6
  501. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -1
  502. data/lib/rubocop/cop/style/redundant_condition.rb +48 -11
  503. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -5
  504. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  505. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +45 -0
  506. data/lib/rubocop/cop/style/redundant_each.rb +116 -0
  507. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  508. data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -2
  509. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  510. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  511. data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
  512. data/lib/rubocop/cop/style/redundant_initialize.rb +3 -1
  513. data/lib/rubocop/cop/style/redundant_interpolation.rb +22 -1
  514. data/lib/rubocop/cop/style/redundant_parentheses.rb +22 -24
  515. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  516. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +10 -3
  517. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +14 -4
  518. data/lib/rubocop/cop/style/redundant_return.rb +9 -2
  519. data/lib/rubocop/cop/style/redundant_self.rb +3 -1
  520. data/lib/rubocop/cop/style/redundant_self_assignment.rb +2 -2
  521. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  522. data/lib/rubocop/cop/style/redundant_sort.rb +23 -8
  523. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  524. data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
  525. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  526. data/lib/rubocop/cop/style/require_order.rb +135 -0
  527. data/lib/rubocop/cop/style/rescue_modifier.rb +2 -2
  528. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  529. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  530. data/lib/rubocop/cop/style/safe_navigation.rb +43 -9
  531. data/lib/rubocop/cop/style/sample.rb +1 -1
  532. data/lib/rubocop/cop/style/select_by_regexp.rb +14 -6
  533. data/lib/rubocop/cop/style/self_assignment.rb +3 -3
  534. data/lib/rubocop/cop/style/semicolon.rb +53 -6
  535. data/lib/rubocop/cop/style/send.rb +1 -1
  536. data/lib/rubocop/cop/style/signal_exception.rb +9 -7
  537. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  538. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  539. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  540. data/lib/rubocop/cop/style/sole_nested_conditional.rb +42 -14
  541. data/lib/rubocop/cop/style/static_class.rb +33 -2
  542. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  543. data/lib/rubocop/cop/style/string_concatenation.rb +6 -7
  544. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -2
  545. data/lib/rubocop/cop/style/string_literals.rb +1 -5
  546. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  547. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  548. data/lib/rubocop/cop/style/strip.rb +1 -1
  549. data/lib/rubocop/cop/style/struct_inheritance.rb +4 -4
  550. data/lib/rubocop/cop/style/swap_values.rb +2 -2
  551. data/lib/rubocop/cop/style/symbol_array.rb +12 -7
  552. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  553. data/lib/rubocop/cop/style/symbol_proc.rb +46 -14
  554. data/lib/rubocop/cop/style/ternary_parentheses.rb +2 -14
  555. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  556. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  557. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  558. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  559. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -5
  560. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +1 -1
  561. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  562. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +1 -1
  563. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  564. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  565. data/lib/rubocop/cop/style/trivial_accessors.rb +4 -1
  566. data/lib/rubocop/cop/style/unless_else.rb +1 -1
  567. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  568. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  569. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  570. data/lib/rubocop/cop/style/when_then.rb +1 -1
  571. data/lib/rubocop/cop/style/word_array.rb +48 -6
  572. data/lib/rubocop/cop/style/yoda_condition.rb +13 -6
  573. data/lib/rubocop/cop/style/yoda_expression.rb +90 -0
  574. data/lib/rubocop/cop/style/zero_length_predicate.rb +32 -15
  575. data/lib/rubocop/cop/team.rb +54 -50
  576. data/lib/rubocop/cop/util.rb +34 -7
  577. data/lib/rubocop/cop/variable_force/assignment.rb +1 -1
  578. data/lib/rubocop/cop/variable_force/scope.rb +3 -3
  579. data/lib/rubocop/cop/variable_force/variable_table.rb +4 -2
  580. data/lib/rubocop/cop/variable_force.rb +18 -30
  581. data/lib/rubocop/cops_documentation_generator.rb +53 -13
  582. data/lib/rubocop/directive_comment.rb +1 -1
  583. data/lib/rubocop/ext/processed_source.rb +2 -0
  584. data/lib/rubocop/ext/range.rb +15 -0
  585. data/lib/rubocop/feature_loader.rb +94 -0
  586. data/lib/rubocop/file_patterns.rb +43 -0
  587. data/lib/rubocop/formatter/clang_style_formatter.rb +1 -1
  588. data/lib/rubocop/formatter/disabled_config_formatter.rb +36 -16
  589. data/lib/rubocop/formatter/formatter_set.rb +20 -19
  590. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  591. data/lib/rubocop/formatter/html_formatter.rb +4 -5
  592. data/lib/rubocop/formatter/markdown_formatter.rb +3 -1
  593. data/lib/rubocop/formatter/offense_count_formatter.rb +10 -5
  594. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  595. data/lib/rubocop/formatter/tap_formatter.rb +1 -1
  596. data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -3
  597. data/lib/rubocop/formatter.rb +34 -0
  598. data/lib/rubocop/magic_comment.rb +27 -2
  599. data/lib/rubocop/options.rb +128 -53
  600. data/lib/rubocop/path_util.rb +50 -22
  601. data/lib/rubocop/rake_task.rb +34 -9
  602. data/lib/rubocop/result_cache.rb +26 -23
  603. data/lib/rubocop/rspec/cop_helper.rb +25 -2
  604. data/lib/rubocop/rspec/expect_offense.rb +9 -7
  605. data/lib/rubocop/rspec/shared_contexts.rb +42 -9
  606. data/lib/rubocop/rspec/support.rb +16 -2
  607. data/lib/rubocop/runner.rb +78 -23
  608. data/lib/rubocop/server/cache.rb +155 -0
  609. data/lib/rubocop/server/cli.rb +147 -0
  610. data/lib/rubocop/server/client_command/base.rb +44 -0
  611. data/lib/rubocop/server/client_command/exec.rb +64 -0
  612. data/lib/rubocop/server/client_command/restart.rb +25 -0
  613. data/lib/rubocop/server/client_command/start.rb +48 -0
  614. data/lib/rubocop/server/client_command/status.rb +28 -0
  615. data/lib/rubocop/server/client_command/stop.rb +31 -0
  616. data/lib/rubocop/server/client_command.rb +26 -0
  617. data/lib/rubocop/server/core.rb +111 -0
  618. data/lib/rubocop/server/errors.rb +23 -0
  619. data/lib/rubocop/server/helper.rb +34 -0
  620. data/lib/rubocop/server/server_command/base.rb +50 -0
  621. data/lib/rubocop/server/server_command/exec.rb +34 -0
  622. data/lib/rubocop/server/server_command/stop.rb +24 -0
  623. data/lib/rubocop/server/server_command.rb +21 -0
  624. data/lib/rubocop/server/socket_reader.rb +69 -0
  625. data/lib/rubocop/server.rb +53 -0
  626. data/lib/rubocop/target_finder.rb +1 -1
  627. data/lib/rubocop/target_ruby.rb +8 -7
  628. data/lib/rubocop/version.rb +22 -9
  629. data/lib/rubocop.rb +45 -35
  630. metadata +89 -36
  631. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
  632. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
@@ -1,7 +1,8 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  require 'optparse'
4
- require 'shellwords'
4
+ require_relative 'arguments_env'
5
+ require_relative 'arguments_file'
5
6
 
6
7
  module RuboCop
7
8
  class IncorrectCopNameError < StandardError; end
@@ -24,7 +25,10 @@ module RuboCop
24
25
  end
25
26
 
26
27
  def parse(command_line_args)
28
+ args_from_file = ArgumentsFile.read_as_arguments
29
+ args_from_env = ArgumentsEnv.read_as_arguments
27
30
  args = args_from_file.concat(args_from_env).concat(command_line_args)
31
+
28
32
  define_options.parse!(args)
29
33
 
30
34
  @validator.validate_compatibility
@@ -45,34 +49,26 @@ module RuboCop
45
49
 
46
50
  private
47
51
 
48
- def args_from_file
49
- if File.exist?('.rubocop') && !File.directory?('.rubocop')
50
- File.read('.rubocop').shellsplit
51
- else
52
- []
53
- end
54
- end
55
-
56
- def args_from_env
57
- Shellwords.split(ENV.fetch('RUBOCOP_OPTS', ''))
58
- end
59
-
60
52
  def define_options
61
53
  OptionParser.new do |opts|
62
54
  opts.banner = rainbow.wrap('Usage: rubocop [options] [file1, file2, ...]').bright
63
55
 
64
56
  add_check_options(opts)
65
57
  add_cache_options(opts)
58
+ add_server_options(opts)
66
59
  add_output_options(opts)
67
60
  add_autocorrection_options(opts)
68
61
  add_config_generation_options(opts)
69
62
  add_additional_modes(opts)
70
63
  add_general_options(opts)
64
+
65
+ # `stackprof` is not supported on JRuby and Windows.
66
+ add_profile_options(opts) if RUBY_ENGINE == 'ruby' && !Platform.windows?
71
67
  end
72
68
  end
73
69
 
74
70
  def add_check_options(opts) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
75
- section(opts, 'Basic Options') do
71
+ section(opts, 'Basic Options') do # rubocop:disable Metrics/BlockLength
76
72
  option(opts, '-l', '--lint') do
77
73
  @options[:only] ||= []
78
74
  @options[:only] << 'Lint'
@@ -80,7 +76,7 @@ module RuboCop
80
76
  option(opts, '-x', '--fix-layout') do
81
77
  @options[:only] ||= []
82
78
  @options[:only] << 'Layout'
83
- @options[:auto_correct] = true
79
+ @options[:autocorrect] = true
84
80
  end
85
81
  option(opts, '--safe')
86
82
  add_cop_selection_csv_option('except', opts)
@@ -93,9 +89,11 @@ module RuboCop
93
89
  option(opts, '--force-exclusion')
94
90
  option(opts, '--only-recognized-file-types')
95
91
  option(opts, '--ignore-parent-exclusion')
92
+ option(opts, '--ignore-unrecognized-cops')
96
93
  option(opts, '--force-default-config')
97
94
  option(opts, '-s', '--stdin FILE')
98
95
  option(opts, '-P', '--[no-]parallel')
96
+ option(opts, '--raise-cop-error')
99
97
  add_severity_option(opts)
100
98
  end
101
99
  end
@@ -128,17 +126,35 @@ module RuboCop
128
126
  end
129
127
  end
130
128
 
131
- def add_autocorrection_options(opts)
132
- section(opts, 'Auto-correction') do
133
- option(opts, '-a', '--auto-correct') { @options[:safe_auto_correct] = true }
129
+ # rubocop:todo Naming/InclusiveLanguage
130
+ # the autocorrect command-line arguments map to the autocorrect @options values like so:
131
+ # :fix_layout :autocorrect :safe_autocorrect :autocorrect_all
132
+ # -x, --fix-layout true true - -
133
+ # -a, --auto-correct - true true -
134
+ # --safe-auto-correct - true true -
135
+ # -A, --auto-correct-all - true - true
136
+ def add_autocorrection_options(opts) # rubocop:disable Metrics/MethodLength
137
+ section(opts, 'Autocorrection') do
138
+ option(opts, '-a', '--autocorrect') { @options[:safe_autocorrect] = true }
139
+ option(opts, '--auto-correct') do
140
+ handle_deprecated_option('--auto-correct', '--autocorrect')
141
+ @options[:safe_autocorrect] = true
142
+ end
134
143
  option(opts, '--safe-auto-correct') do
135
- warn '--safe-auto-correct is deprecated; use --auto-correct'
136
- @options[:safe_auto_correct] = @options[:auto_correct] = true
144
+ handle_deprecated_option('--safe-auto-correct', '--autocorrect')
145
+ @options[:safe_autocorrect] = true
146
+ end
147
+
148
+ option(opts, '-A', '--autocorrect-all') { @options[:autocorrect] = true }
149
+ option(opts, '--auto-correct-all') do
150
+ handle_deprecated_option('--auto-correct-all', '--autocorrect-all')
151
+ @options[:autocorrect] = true
137
152
  end
138
- option(opts, '-A', '--auto-correct-all') { @options[:auto_correct] = true }
153
+
139
154
  option(opts, '--disable-uncorrectable')
140
155
  end
141
156
  end
157
+ # rubocop:enable Naming/InclusiveLanguage
142
158
 
143
159
  def add_config_generation_options(opts)
144
160
  section(opts, 'Config Generation') do
@@ -149,10 +165,12 @@ module RuboCop
149
165
  end
150
166
 
151
167
  option(opts, '--exclude-limit COUNT') { @validator.validate_exclude_limit_option }
168
+ option(opts, '--no-exclude-limit')
152
169
 
153
170
  option(opts, '--[no-]offense-counts')
154
171
  option(opts, '--[no-]auto-gen-only-exclude')
155
172
  option(opts, '--[no-]auto-gen-timestamp')
173
+ option(opts, '--[no-]auto-gen-enforced-style')
156
174
  end
157
175
  end
158
176
 
@@ -184,6 +202,17 @@ module RuboCop
184
202
  end
185
203
  end
186
204
 
205
+ def add_server_options(opts)
206
+ section(opts, 'Server Options') do
207
+ option(opts, '--[no-]server')
208
+ option(opts, '--restart-server')
209
+ option(opts, '--start-server')
210
+ option(opts, '--stop-server')
211
+ option(opts, '--server-status')
212
+ option(opts, '--no-detach')
213
+ end
214
+ end
215
+
187
216
  def add_additional_modes(opts)
188
217
  section(opts, 'Additional Modes') do
189
218
  option(opts, '-L', '--list-target-files')
@@ -208,6 +237,21 @@ module RuboCop
208
237
  end
209
238
  end
210
239
 
240
+ def add_profile_options(opts)
241
+ section(opts, 'Profiling Options') do
242
+ option(opts, '--profile') do
243
+ @options[:profile] = true
244
+ @options[:cache] = 'false' unless @options.key?(:cache)
245
+ end
246
+ option(opts, '--memory')
247
+ end
248
+ end
249
+
250
+ def handle_deprecated_option(old_option, new_option)
251
+ warn rainbow.wrap("#{old_option} is deprecated; use #{new_option} instead.").yellow
252
+ @options[long_opt_symbol([new_option])] = @options.delete(long_opt_symbol([old_option]))
253
+ end
254
+
211
255
  def rainbow
212
256
  @rainbow ||= begin
213
257
  rainbow = Rainbow.new
@@ -236,7 +280,7 @@ module RuboCop
236
280
  end
237
281
 
238
282
  # Finds the option in `args` starting with -- and converts it to a symbol,
239
- # e.g. [..., '--auto-correct', ...] to :auto_correct.
283
+ # e.g. [..., '--autocorrect', ...] to :autocorrect.
240
284
  def long_opt_symbol(args)
241
285
  long_opt = args.find { |arg| arg.start_with?('--') }
242
286
  long_opt[2..].sub('[no-]', '').sub(/ .*/, '').tr('-', '_').gsub(/[\[\]]/, '').to_sym
@@ -309,15 +353,14 @@ module RuboCop
309
353
  end
310
354
 
311
355
  if display_only_fail_level_offenses_with_autocorrect?
312
- raise OptionArgumentError, '--auto-correct cannot be used with ' \
313
- '--display-only-fail-level-offenses'
356
+ raise OptionArgumentError, '--autocorrect cannot be used with ' \
357
+ '--display-only-fail-level-offenses.'
314
358
  end
315
-
316
359
  validate_auto_gen_config
317
- validate_auto_correct
360
+ validate_autocorrect
318
361
  validate_display_only_failed
319
362
  validate_display_only_failed_and_display_only_correctable
320
- validate_display_only_correctable_and_auto_correct
363
+ validate_display_only_correctable_and_autocorrect
321
364
  disable_parallel_when_invalid_option_combo
322
365
 
323
366
  return if incompatible_options.size <= 1
@@ -347,13 +390,13 @@ module RuboCop
347
390
  format('--display-only-failed can only be used together with --format junit.')
348
391
  end
349
392
 
350
- def validate_display_only_correctable_and_auto_correct
351
- return if !@options.key?(:safe_auto_correct) && !@options.key?(:auto_correct)
393
+ def validate_display_only_correctable_and_autocorrect
394
+ return unless @options.key?(:autocorrect)
352
395
  return if !@options.key?(:display_only_correctable) &&
353
396
  !@options.key?(:display_only_safe_correctable)
354
397
 
355
398
  raise OptionArgumentError,
356
- '--auto-correct cannot be used with --display-only-[safe-]correctable.'
399
+ '--autocorrect cannot be used with --display-only-[safe-]correctable.'
357
400
  end
358
401
 
359
402
  def validate_display_only_failed_and_display_only_correctable
@@ -365,35 +408,39 @@ module RuboCop
365
408
  format('--display-only-failed cannot be used together with other display options.')
366
409
  end
367
410
 
368
- def validate_auto_correct
369
- return if @options.key?(:auto_correct)
411
+ def validate_autocorrect
412
+ if @options.key?(:safe_autocorrect) && @options.key?(:autocorrect_all)
413
+ message = Rainbow(<<~MESSAGE).red
414
+ Error: Both safe and unsafe autocorrect options are specified, use only one.
415
+ MESSAGE
416
+ raise OptionArgumentError, message
417
+ end
418
+ return if @options.key?(:autocorrect)
370
419
  return unless @options.key?(:disable_uncorrectable)
371
420
 
372
421
  raise OptionArgumentError,
373
- format('--disable-uncorrectable can only be used together with --auto-correct.')
422
+ format('--disable-uncorrectable can only be used together with --autocorrect.')
374
423
  end
375
424
 
376
425
  def disable_parallel_when_invalid_option_combo
377
426
  return unless @options.key?(:parallel)
378
427
 
379
- invalid_options = [
380
- { name: :auto_gen_config, value: true, flag: '--auto-gen-config' },
381
- { name: :fail_fast, value: true, flag: '-F/--fail-fast.' },
382
- { name: :auto_correct, value: true, flag: '--auto-correct.' },
383
- { name: :cache, value: 'false', flag: '--cache false' }
384
- ]
385
-
386
- invalid_flags = invalid_options.each_with_object([]) do |option, flags|
387
- # `>` rather than `>=` because `@options` will also contain `parallel: true`
388
- flags << option[:flag] if @options > { option[:name] => option[:value] }
389
- end
428
+ invalid_flags = invalid_arguments_for_parallel
390
429
 
391
430
  return if invalid_flags.empty?
392
431
 
393
432
  @options.delete(:parallel)
394
433
 
395
434
  puts '-P/--parallel is being ignored because ' \
396
- "it is not compatible with #{invalid_flags.join(', ')}"
435
+ "it is not compatible with #{invalid_flags.join(', ')}."
436
+ end
437
+
438
+ def invalid_arguments_for_parallel
439
+ [('--auto-gen-config' if @options.key?(:auto_gen_config)),
440
+ ('-F/--fail-fast' if @options.key?(:fail_fast)),
441
+ ('--profile' if @options[:profile]),
442
+ ('--memory' if @options[:memory]),
443
+ ('--cache false' if @options > { cache: 'false' })].compact
397
444
  end
398
445
 
399
446
  def only_includes_redundant_disable?
@@ -402,8 +449,7 @@ module RuboCop
402
449
  end
403
450
 
404
451
  def display_only_fail_level_offenses_with_autocorrect?
405
- @options[:display_only_fail_level_offenses] &&
406
- (@options.key?(:auto_correct) || @options.key?(:safe_auto_correct))
452
+ @options.key?(:display_only_fail_level_offenses) && @options.key?(:autocorrect)
407
453
  end
408
454
 
409
455
  def except_syntax?
@@ -435,6 +481,7 @@ module RuboCop
435
481
 
436
482
  # This module contains help texts for command line options.
437
483
  # @api private
484
+ # rubocop:disable Metrics/ModuleLength
438
485
  module OptionsHelp
439
486
  MAX_EXCL = RuboCop::Options::DEFAULT_MAXIMUM_EXCLUSION_ITEMS.to_s
440
487
  FORMATTER_OPTION_LIST = RuboCop::Formatter::FormatterSet::BUILTIN_FORMATTERS_FOR_KEYS.keys
@@ -457,6 +504,13 @@ module RuboCop
457
504
  auto_gen_timestamp:
458
505
  ['Include the date and time when the --auto-gen-config',
459
506
  'was run in the file it generates. Default is true.'],
507
+ auto_gen_enforced_style:
508
+ ['Add a setting to the TODO configuration file to enforce',
509
+ 'the style used, rather than a per-file exclusion',
510
+ 'if one style is used in all files for cop with',
511
+ 'EnforcedStyle as a configurable option',
512
+ 'when the --auto-gen-config was run',
513
+ 'in the file it generates. Default is true.'],
460
514
  auto_gen_only_exclude:
461
515
  ['Generate only Exclude parameters and not Max',
462
516
  'when running --auto-gen-config, except if the',
@@ -465,9 +519,10 @@ module RuboCop
465
519
  exclude_limit: ['Set the limit for how many files to explicitly exclude.',
466
520
  'If there are more files than the limit, the cop will',
467
521
  "be disabled instead. Default is #{MAX_EXCL}."],
468
- disable_uncorrectable: ['Used with --auto-correct to annotate any',
522
+ disable_uncorrectable: ['Used with --autocorrect to annotate any',
469
523
  'offenses that do not support autocorrect',
470
524
  'with `rubocop:todo` comments.'],
525
+ no_exclude_limit: ['Do not set the limit for how many files to exclude.'],
471
526
  force_exclusion: ['Any files excluded by `Exclude` in configuration',
472
527
  'files will be excluded, even if given explicitly',
473
528
  'as arguments.'],
@@ -478,6 +533,7 @@ module RuboCop
478
533
  'by a `rubocop:disable` directive.'],
479
534
  ignore_parent_exclusion: ['Prevent from inheriting `AllCops/Exclude` from',
480
535
  'parent folders.'],
536
+ ignore_unrecognized_cops: ['Ignore unrecognized cops or departments in the config.'],
481
537
  force_default_config: ['Use default configuration even if configuration',
482
538
  'files are present in the directory tree.'],
483
539
  format: ['Choose an output formatter. This option',
@@ -534,12 +590,14 @@ module RuboCop
534
590
  safe: 'Run only safe cops.',
535
591
  stderr: ['Write all output to stderr except for the',
536
592
  'autocorrected source. This is especially useful',
537
- 'when combined with --auto-correct and --stdin.'],
593
+ 'when combined with --autocorrect and --stdin.'],
538
594
  list_target_files: 'List all files RuboCop will inspect.',
539
- auto_correct: 'Auto-correct offenses (only when it\'s safe).',
595
+ autocorrect: 'Autocorrect offenses (only when it\'s safe).',
596
+ auto_correct: '(same, deprecated)',
540
597
  safe_auto_correct: '(same, deprecated)',
541
- auto_correct_all: 'Auto-correct offenses (safe and unsafe)',
542
- fix_layout: 'Run only layout cops, with auto-correct on.',
598
+ autocorrect_all: 'Autocorrect offenses (safe and unsafe).',
599
+ auto_correct_all: '(same, deprecated)',
600
+ fix_layout: 'Run only layout cops, with autocorrect on.',
543
601
  color: 'Force color output on or off.',
544
602
  version: 'Display version.',
545
603
  verbose_version: 'Display verbose version.',
@@ -547,7 +605,24 @@ module RuboCop
547
605
  'parallel. Default is true.'],
548
606
  stdin: ['Pipe source from STDIN, using FILE in offense',
549
607
  'reports. This is useful for editor integration.'],
550
- init: 'Generate a .rubocop.yml file in the current directory.'
608
+ init: 'Generate a .rubocop.yml file in the current directory.',
609
+ server: ['If a server process has not been started yet, start',
610
+ 'the server process and execute inspection with server.',
611
+ 'Default is false.',
612
+ 'You can specify the server host and port with the',
613
+ '$RUBOCOP_SERVER_HOST and the $RUBOCOP_SERVER_PORT',
614
+ 'environment variables.'],
615
+ restart_server: 'Restart server process.',
616
+ start_server: 'Start server process.',
617
+ stop_server: 'Stop server process.',
618
+ server_status: 'Show server status.',
619
+ no_detach: 'Run the server process in the foreground.',
620
+ raise_cop_error: ['Raise cop-related errors with cause and location.',
621
+ 'This is used to prevent cops from failing silently.',
622
+ 'Default is false.'],
623
+ profile: 'Profile rubocop',
624
+ memory: 'Profile rubocop memory usage'
551
625
  }.freeze
552
626
  end
627
+ # rubocop:enable Metrics/ModuleLength
553
628
  end
@@ -3,41 +3,59 @@
3
3
  module RuboCop
4
4
  # Common methods and behaviors for dealing with paths.
5
5
  module PathUtil
6
+ class << self
7
+ attr_accessor :relative_paths_cache
8
+ end
9
+ self.relative_paths_cache = Hash.new { |hash, key| hash[key] = {} }
10
+
6
11
  module_function
7
12
 
8
13
  def relative_path(path, base_dir = Dir.pwd)
9
- # Optimization for the common case where path begins with the base
10
- # dir. Just cut off the first part.
11
- if path.start_with?(base_dir)
12
- base_dir_length = base_dir.length
13
- result_length = path.length - base_dir_length - 1
14
- return path[base_dir_length + 1, result_length]
15
- end
16
-
17
- path_name = Pathname.new(File.expand_path(path))
18
- begin
19
- path_name.relative_path_from(Pathname.new(base_dir)).to_s
20
- rescue ArgumentError
21
- path
22
- end
14
+ PathUtil.relative_paths_cache[base_dir][path] ||=
15
+ # Optimization for the common case where path begins with the base
16
+ # dir. Just cut off the first part.
17
+ if path.start_with?(base_dir)
18
+ base_dir_length = base_dir.length
19
+ result_length = path.length - base_dir_length - 1
20
+ path[base_dir_length + 1, result_length]
21
+ else
22
+ path_name = Pathname.new(File.expand_path(path))
23
+ begin
24
+ path_name.relative_path_from(Pathname.new(base_dir)).to_s
25
+ rescue ArgumentError
26
+ path
27
+ end
28
+ end
23
29
  end
24
30
 
31
+ SMART_PATH_CACHE = {} # rubocop:disable Style/MutableConstant
32
+ private_constant :SMART_PATH_CACHE
33
+
25
34
  def smart_path(path)
26
- # Ideally, we calculate this relative to the project root.
27
- base_dir = Dir.pwd
35
+ SMART_PATH_CACHE[path] ||= begin
36
+ # Ideally, we calculate this relative to the project root.
37
+ base_dir = Dir.pwd
28
38
 
29
- if path.start_with? base_dir
30
- relative_path(path, base_dir)
31
- else
32
- path
39
+ if path.start_with? base_dir
40
+ relative_path(path, base_dir)
41
+ else
42
+ path
43
+ end
33
44
  end
34
45
  end
35
46
 
47
+ # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
36
48
  def match_path?(pattern, path)
37
49
  case pattern
38
50
  when String
39
- File.fnmatch?(pattern, path, File::FNM_PATHNAME | File::FNM_EXTGLOB) ||
40
- hidden_file_in_not_hidden_dir?(pattern, path)
51
+ matches =
52
+ if pattern == path
53
+ true
54
+ elsif glob?(pattern)
55
+ File.fnmatch?(pattern, path, File::FNM_PATHNAME | File::FNM_EXTGLOB)
56
+ end
57
+
58
+ matches || hidden_file_in_not_hidden_dir?(pattern, path)
41
59
  when Regexp
42
60
  begin
43
61
  pattern.match?(path)
@@ -48,12 +66,18 @@ module RuboCop
48
66
  end
49
67
  end
50
68
  end
69
+ # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
51
70
 
52
71
  # Returns true for an absolute Unix or Windows path.
53
72
  def absolute?(path)
54
73
  %r{\A([A-Z]:)?/}i.match?(path)
55
74
  end
56
75
 
76
+ # Returns true for a glob
77
+ def glob?(path)
78
+ path.match?(/[*{\[?]/)
79
+ end
80
+
57
81
  def hidden_file_in_not_hidden_dir?(pattern, path)
58
82
  hidden_file?(path) &&
59
83
  File.fnmatch?(
@@ -67,8 +91,12 @@ module RuboCop
67
91
  maybe_hidden_file?(path) && File.basename(path).start_with?('.')
68
92
  end
69
93
 
94
+ HIDDEN_FILE_PATTERN = "#{File::SEPARATOR}."
95
+
70
96
  # Loose check to reduce memory allocations
71
97
  def maybe_hidden_file?(path)
98
+ return false unless path.include?(HIDDEN_FILE_PATTERN)
99
+
72
100
  separator_index = path.rindex(File::SEPARATOR)
73
101
  return false unless separator_index
74
102
 
@@ -32,6 +32,15 @@ module RuboCop
32
32
 
33
33
  private
34
34
 
35
+ def perform(option)
36
+ options = full_options.unshift(option)
37
+ # `parallel` will automatically be removed from the options internally.
38
+ # This is a nice to have to suppress the warning message
39
+ # about --parallel and --autocorrect not being compatible.
40
+ options.delete('--parallel')
41
+ run_cli(verbose, options)
42
+ end
43
+
35
44
  def run_cli(verbose, options)
36
45
  # We lazy-load RuboCop so that the task doesn't dramatically impact the
37
46
  # load time of your Rakefile.
@@ -60,19 +69,35 @@ module RuboCop
60
69
  @formatters = []
61
70
  end
62
71
 
63
- def setup_subtasks(name, *args, &task_block)
72
+ def setup_subtasks(name, *args, &task_block) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
64
73
  namespace(name) do
65
- desc 'Auto-correct RuboCop offenses'
74
+ # rubocop:todo Naming/InclusiveLanguage
75
+ task(:auto_correct, *args) do
76
+ require 'rainbow'
77
+ warn Rainbow(
78
+ 'rubocop:auto_correct task is deprecated; ' \
79
+ 'use rubocop:autocorrect task or rubocop:autocorrect_all task instead.'
80
+ ).yellow
81
+ RakeFileUtils.verbose(verbose) do
82
+ yield(*[self, task_args].slice(0, task_block.arity)) if task_block
83
+ perform('--autocorrect')
84
+ end
85
+ end
86
+ # rubocop:enable Naming/InclusiveLanguage
87
+
88
+ desc "Autocorrect RuboCop offenses (only when it's safe)."
89
+ task(:autocorrect, *args) do |_, task_args|
90
+ RakeFileUtils.verbose(verbose) do
91
+ yield(*[self, task_args].slice(0, task_block.arity)) if task_block
92
+ perform('--autocorrect')
93
+ end
94
+ end
66
95
 
67
- task(:auto_correct, *args) do |_, task_args|
96
+ desc 'Autocorrect RuboCop offenses (safe and unsafe).'
97
+ task(:autocorrect_all, *args) do |_, task_args|
68
98
  RakeFileUtils.verbose(verbose) do
69
99
  yield(*[self, task_args].slice(0, task_block.arity)) if task_block
70
- options = full_options.unshift('--auto-correct-all')
71
- # `parallel` will automatically be removed from the options internally.
72
- # This is a nice to have to suppress the warning message
73
- # about parallel and auto-correct not being compatible.
74
- options.delete('--parallel')
75
- run_cli(verbose, options)
100
+ perform('--autocorrect-all')
76
101
  end
77
102
  end
78
103
  end
@@ -1,17 +1,25 @@
1
1
  # frozen_string_literal: true
2
2
 
3
3
  require 'digest/sha1'
4
- require 'find'
5
4
  require 'etc'
5
+ require 'find'
6
6
  require 'zlib'
7
+ require_relative 'cache_config'
7
8
 
8
9
  module RuboCop
9
10
  # Provides functionality for caching RuboCop runs.
10
11
  # @api private
11
12
  class ResultCache
12
- NON_CHANGING = %i[color format formatters out debug fail_level auto_correct
13
+ NON_CHANGING = %i[color format formatters out debug fail_level
14
+ fix_layout autocorrect safe_autocorrect autocorrect_all
13
15
  cache fail_fast stdin parallel].freeze
14
16
 
17
+ DL_EXTENSIONS = ::RbConfig::CONFIG
18
+ .values_at('DLEXT', 'DLEXT2')
19
+ .reject { |ext| !ext || ext.empty? }
20
+ .map { |ext| ".#{ext}" }
21
+ .freeze
22
+
15
23
  # Remove old files so that the cache doesn't grow too big. When the
16
24
  # threshold MaxFilesInCache has been exceeded, the oldest 50% of all the
17
25
  # files in the cache are removed. The reason for removing so much is that
@@ -45,7 +53,7 @@ module RuboCop
45
53
  def remove_oldest_files(files, dirs, cache_root, verbose)
46
54
  # Add 1 to half the number of files, so that we remove the file if
47
55
  # there's only 1 left.
48
- remove_count = 1 + (files.length / 2)
56
+ remove_count = (files.length / 2) + 1
49
57
  puts "Removing the #{remove_count} oldest files from #{cache_root}" if verbose
50
58
  sorted = files.sort_by { |path| File.mtime(path) }
51
59
  remove_files(sorted, dirs, remove_count)
@@ -66,24 +74,9 @@ module RuboCop
66
74
  end
67
75
 
68
76
  def self.cache_root(config_store)
69
- root = ENV.fetch('RUBOCOP_CACHE_ROOT', nil)
70
- root ||= config_store.for_pwd.for_all_cops['CacheRootDirectory']
71
- root ||= if ENV.key?('XDG_CACHE_HOME')
72
- # Include user ID in the path to make sure the user has write
73
- # access.
74
- File.join(ENV.fetch('XDG_CACHE_HOME'), Process.uid.to_s)
75
- else
76
- # On FreeBSD, the /home path is a symbolic link to /usr/home
77
- # and the $HOME environment variable returns the /home path.
78
- #
79
- # As $HOME is a built-in environment variable, FreeBSD users
80
- # always get a warning message.
81
- #
82
- # To avoid raising warn log messages on FreeBSD, we retrieve
83
- # the real path of the home folder.
84
- File.join(File.realpath(Dir.home), '.cache')
85
- end
86
- File.join(root, 'rubocop_cache')
77
+ CacheConfig.root_dir do
78
+ config_store.for_pwd.for_all_cops['CacheRootDirectory']
79
+ end
87
80
  end
88
81
 
89
82
  def self.allow_symlinks_in_cache_location?(config_store)
@@ -187,14 +180,24 @@ module RuboCop
187
180
  .select { |path| File.file?(path) }
188
181
  .sort!
189
182
  .each do |path|
190
- content = File.binread(path)
191
- digest << Zlib.crc32(content).to_s # mtime not reliable
183
+ digest << digest(path)
192
184
  end
193
185
  digest << RuboCop::Version::STRING << RuboCop::AST::Version::STRING
194
186
  digest.hexdigest
195
187
  end
196
188
  end
197
189
 
190
+ def digest(path)
191
+ content = if path.end_with?(*DL_EXTENSIONS)
192
+ # Shared libraries often contain timestamps of when
193
+ # they were compiled and other non-stable data.
194
+ File.basename(path)
195
+ else
196
+ File.binread(path) # mtime not reliable
197
+ end
198
+ Zlib.crc32(content).to_s
199
+ end
200
+
198
201
  def rubocop_extra_features
199
202
  lib_root = File.join(File.dirname(__FILE__), '..')
200
203
  exe_root = File.join(lib_root, '..', 'exe')
@@ -28,7 +28,30 @@ module CopHelper
28
28
  file = file.path
29
29
  end
30
30
 
31
- RuboCop::ProcessedSource.new(source, ruby_version, file)
31
+ processed_source = RuboCop::ProcessedSource.new(source, ruby_version, file)
32
+ processed_source.config = configuration
33
+ processed_source.registry = registry
34
+ processed_source
35
+ end
36
+
37
+ def configuration
38
+ @configuration ||= if defined?(config)
39
+ config
40
+ else
41
+ RuboCop::Config.new({}, "#{Dir.pwd}/.rubocop.yml")
42
+ end
43
+ end
44
+
45
+ def registry
46
+ @registry ||= begin
47
+ keys = configuration.keys
48
+ cops =
49
+ keys.map { |directive| RuboCop::Cop::Registry.global.find_cops_by_directive(directive) }
50
+ .flatten
51
+ cops << cop_class if defined?(cop_class) && !cops.include?(cop_class)
52
+ cops.compact!
53
+ RuboCop::Cop::Registry.new(cops)
54
+ end
32
55
  end
33
56
 
34
57
  def autocorrect_source_file(source)
@@ -38,7 +61,7 @@ module CopHelper
38
61
  def autocorrect_source(source, file = nil)
39
62
  RuboCop::Formatter::DisabledConfigFormatter.config_to_allow_offenses = {}
40
63
  RuboCop::Formatter::DisabledConfigFormatter.detected_styles = {}
41
- cop.instance_variable_get(:@options)[:auto_correct] = true
64
+ cop.instance_variable_get(:@options)[:autocorrect] = true
42
65
  processed_source = parse_source(source, file)
43
66
  _investigate(cop, processed_source)
44
67